On 10/25/2015 2:03 PM, Alexander Duyck wrote:
On 10/24/2015 08:43 AM, Lan, Tianyu wrote:
On 10/22/2015 4:52 AM, Alexander Duyck wrote:
Also have you even considered the MSI-X configuration on the VF? I
haven't seen anything anywhere that would have migrated the VF's MSI-X
configuration from
> > +/* counts the iids for the CDU/CDUC ILT client configuration */
> > +struct qed_cdu_iids {
> > + u32 pf_cids;
> > +};
Actually, this will [in future] also include a `per_vf_cids' field;
I've extracted it and all its usages when preparing this patch series
[As our initial submission does
On 10/24/2015 08:43 AM, Lan, Tianyu wrote:
On 10/22/2015 4:52 AM, Alexander Duyck wrote:
Also have you even considered the MSI-X configuration on the VF? I
haven't seen anything anywhere that would have migrated the VF's MSI-X
configuration from BAR 3 on one system to the new system.
MSI-X m
On Friday, October 23, 2015 02:44:14 PM Eric Dumazet wrote:
> On Fri, 2015-10-23 at 22:50 +0200, Bendik Rønning Opstad wrote:
>
> >
> > +/**
> > + * tcp_stream_is_thin_dpifl() - Tests if the stream is thin based on
> > dynamic PIF
> > + * limit
> > + * @tp: the tcp_
On 10/24/2015 07:43 AM, Helge Deller wrote:
* Alexander Duyck :
On 10/23/2015 03:17 PM, Helge Deller wrote:
On 24.10.2015 00:00, Alexander Duyck wrote:
On 10/23/2015 02:08 PM, Helge Deller wrote:
* Eric Dumazet :
On Fri, 2015-10-23 at 21:25 +0200, Helge Deller wrote:
Then, how about simply
The fib6_get_table() is called twice to show the warning.
This patch reduces calling the function.
Signed-off-by: Masashi Honma
---
include/net/ip6_fib.h | 2 +-
net/ipv6/fib6_rules.c | 3 ++-
net/ipv6/ip6_fib.c| 10 +++---
net/ipv6/route.c | 13 -
4 files changed, 14
On 2015/10/19 15:09, David Miller wrote:
This is not correct.
The whole point of the test is so that the kernel log message
warning for failing to provide NLM_F_CREATE can be printed
in precisely the correct conditions.
Thanks. Now I understand importance of the warning.
Though fib6_get_table
On Sat, Oct 24, 2015 at 6:55 AM, David Miller wrote:
>
> I needed to do a merge of 'net' into 'net-next' in order to
> facilitate a set of tipc patches that I wanted to apply to
> 'net-next'.
>
> There were several openvswitch merge conflicts, mostly to do with the
> egress tunnel info bug fix con
In a low memory situation the following kernel oops occurs:
Unable to handle kernel NULL pointer dereference at virtual address 0050
pgd = 8490c000
[0050] *pgd=4651e831, *pte=, *ppte=
Internal error: Oops: 17 [#1] PREEMPT ARM
Modules linked in:
CPU: 0Not tainted (3.4-a
Acked-by: Jon Maloy
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-
> ow...@vger.kernel.org] On Behalf Of kbuild test robot
> Sent: Saturday, 24 October, 2015 11:11
> To: kbuild-inter...@linux.intel.com; l...@eclists.intel.com
> Cc: kbuild-...@01.org; netdev@vg
Acked-by: Jon Maloy
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-
> ow...@vger.kernel.org] On Behalf Of kbuild test robot
> Sent: Saturday, 24 October, 2015 10:56
> To: kbuild-inter...@linux.intel.com; l...@eclists.intel.com
> Cc: kbuild-...@01.org; netdev@vge
On 24 October 2015 at 01:20, Florian Westphal wrote:
> Joe Stringer wrote:
>> err:
>> + if (err)
>> + kfree_skb(skb);
>> skb_push(skb, nh_ofs);
>
> That looks... wrong :-}
D'oh. Teaches me for last minute adjustments. I'll resend.
--
To unsubscribe from this list: send the
Please refer to the thread "linux 3.4.43 : kernel crash at
__nf_conntrack_confirm" on netdev for context.
thanks
On Sat, Oct 24, 2015 at 11:27 AM, Ani Sinha wrote:
> netfilter: nf_conntrack: fix RCU race in nf_conntrack_find_get
>
> Lets look at destroy_conntrack:
>
> hlist_nulls_del_rcu(&ct->tu
Please refer to the thread "linux 3.4.43 : kernel crash at
__nf_conntrack_confirm" on netdev for context.
thanks
On Sat, Oct 24, 2015 at 10:27 AM, Ani Sinha wrote:
> netfilter: nf_conntrack: don't release a conntrack with non-zero
> refcnt
>
> With this patch, the conntrack refcount is initially
netfilter: nf_conntrack: fix RCU race in nf_conntrack_find_get
Lets look at destroy_conntrack:
hlist_nulls_del_rcu(&ct->tuplehash[IP_CT_DIR_ORIGINAL].hnnode);
...
nf_conntrack_free(ct)
kmem_cache_free(net->ct.nf_conntrack_cachep, ct);
net->ct.nf_conntrack_cachep is created with SLAB_DEST
When fib_netdev_event calls fib_disable_ip on NETDEV_DOWN event
we should not delete the local routes if the local address
is still present. The confusion comes from the fact that both
fib_netdev_event and fib_inetaddr_event use the NETDEV_DOWN
constant. Fix it by returning back the variable 'force
netfilter: nf_conntrack: don't release a conntrack with non-zero
refcnt
With this patch, the conntrack refcount is initially set to zero and
it is bumped once it is added to any of the list, so we fulfill
Eric's golden rule which is that all released objects always have a
refcount that equals zero
Hi Tom,
On Sat, Oct 24, 2015, at 18:46, Tom Herbert wrote:
> On Sat, Oct 24, 2015 at 12:28 PM, Hannes Frederic Sowa
> wrote:
> > Hi Tom,
> >
> > On Sat, Oct 24, 2015, at 18:21, Tom Herbert wrote:
> >> On Fri, Oct 23, 2015 at 9:13 AM, Hannes Frederic Sowa
> >> wrote:
> >> > CHECKSUM_PARTIAL shoul
On Sat, Oct 24, 2015 at 12:28 PM, Hannes Frederic Sowa
wrote:
> Hi Tom,
>
> On Sat, Oct 24, 2015, at 18:21, Tom Herbert wrote:
>> On Fri, Oct 23, 2015 at 9:13 AM, Hannes Frederic Sowa
>> wrote:
>> > CHECKSUM_PARTIAL should only be used on plain vanilla IPv6 + UDP packets
>> > in ip6_append_data.
Hi Tom,
On Sat, Oct 24, 2015, at 18:21, Tom Herbert wrote:
> On Fri, Oct 23, 2015 at 9:13 AM, Hannes Frederic Sowa
> wrote:
> > CHECKSUM_PARTIAL should only be used on plain vanilla IPv6 + UDP packets
> > in ip6_append_data. Some drivers don't correctly handle extension headers,
> > especially no
On Fri, Oct 23, 2015 at 9:13 AM, Hannes Frederic Sowa
wrote:
> CHECKSUM_PARTIAL should only be used on plain vanilla IPv6 + UDP packets
> in ip6_append_data. Some drivers don't correctly handle extension headers,
> especially not ipv6 fragmentation which could result in broken checksums.
>
Yes, we
On 10/22/2015 5:14 AM, Alexander Duyck wrote:
Where is i being initialized? It was here but you removed it. Are you
using i without initializing it?
Sorry, the initialization was put into patch 10 by mistake. "i" is
assigned with "tx_ring->next_to_clean".
--
To unsubscribe from this list: se
On 10/22/2015 8:58 PM, Michael S. Tsirkin wrote:
Do you really need to play the shifting games?
Can't you just reset everything and re-initialize the rings?
It's slower but way less intrusive.
Also removes the need to track writes into rings.
Shift ring is to avoid losing those packets in the
Florian Fainelli writes:
+static void nb8800_set_rx_mode(struct net_device *dev)
+{
+ struct nb8800_priv *priv = netdev_priv(dev);
+ struct netdev_hw_addr *ha;
+ int af_en;
+
+ if ((dev->flags & (IFF_PROMISC | IFF_ALLMULTI)) ||
+ netdev_mc_count(de
On 10/22/2015 4:52 AM, Alexander Duyck wrote:
Also have you even considered the MSI-X configuration on the VF? I
haven't seen anything anywhere that would have migrated the VF's MSI-X
configuration from BAR 3 on one system to the new system.
MSI-X migration is done by Hypervisor(Qemu).
Follow
TO: "David S. Miller"
CC: netdev@vger.kernel.org
CC: Jon Maloy
CC: Ying Xue
CC: tipc-discuss...@lists.sourceforge.net
CC: linux-ker...@vger.kernel.org
Signed-off-by: Fengguang Wu
---
link.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tipc/link.c b/net/tipc/link
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
master
head: 687f079addba1ac7f97ce97080c2291bbe8c8dce
commit: c72fa872a23f03b2b9c17e88f3b0a8070924e5f1 [1610/1613] tipc: eliminate
link's reference to owner node
reproduce:
# apt-get install sparse
git ch
TO: "David S. Miller"
CC: netdev@vger.kernel.org
CC: Jon Maloy
CC: Ying Xue
CC: tipc-discuss...@lists.sourceforge.net
CC: linux-ker...@vger.kernel.org
Signed-off-by: Fengguang Wu
---
link.c |8
node.c |2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
master
head: 687f079addba1ac7f97ce97080c2291bbe8c8dce
commit: 5266698661401afc5e4a1a521cf9ba10724d10dd [1605/1613] tipc: let
broadcast packet reception use new link receive function
reproduce:
# apt-get install s
On 10/22/2015 2:07 AM, Alexander Duyck wrote:
On 10/21/2015 09:37 AM, Lan Tianyu wrote:
Add "virtfn_index" member in the struct pci_device to record VF sequence
of PF. This will be used in the VF sysfs node handle.
Signed-off-by: Lan Tianyu
---
drivers/pci/iov.c | 1 +
include/linux/pci
* Alexander Duyck :
> On 10/23/2015 03:17 PM, Helge Deller wrote:
> >On 24.10.2015 00:00, Alexander Duyck wrote:
> >>On 10/23/2015 02:08 PM, Helge Deller wrote:
> >>>* Eric Dumazet :
> On Fri, 2015-10-23 at 21:25 +0200, Helge Deller wrote:
>
> >Then, how about simply changing it to twi
Hi,
On Sat, Oct 24, 2015, at 00:48, Eric Dumazet wrote:
> On Fri, 2015-10-23 at 15:13 +0200, Hannes Frederic Sowa wrote:
> > CHECKSUM_PARTIAL should only be used on plain vanilla IPv6 + UDP packets
> > in ip6_append_data. Some drivers don't correctly handle extension headers,
> > especially not ip
From: Mans Rullgard
Date: Thu, 22 Oct 2015 17:28:50 +0100
> +static void nb8800_mac_tx(struct net_device *dev, int enable)
...
> +static void nb8800_mac_rx(struct net_device *dev, int enable)
...
> +static void nb8800_mac_af(struct net_device *dev, int enable)
Please use 'bool' and true/false
From: Jon Maloy
Date: Thu, 22 Oct 2015 08:51:32 -0400
> The TIPC broadcast link implementation is currently complex and hard to
> follow. It also incurs some amount of code and structure duplication,
> something that can be reduced significantly with a little effort.
>
> This commit series intro
I needed to do a merge of 'net' into 'net-next' in order to
facilitate a set of tipc patches that I wanted to apply to
'net-next'.
There were several openvswitch merge conflicts, mostly to do with the
egress tunnel info bug fix conflicting with the simplification of the
vport ->send() method.
I
On 10/23/2015 6:32 PM, Alexander Duyck wrote:
On 10/23/2015 02:34 PM, Brian Rak wrote:
I've got a weird situation here. I have a route that the kernel knows
about, but won't display via the general RTM_GETROUTE call, but will
display if I query for that particular route:
# ip -4 route show |
On Sat, 2015-10-24 at 08:00 +, Jonas Markussen wrote:
> Repacketization is only on retransmissions; RDB bundles previously sent
> segments with the next “normal” transmission instead.
>
> This makes the flow recover the lost segment before a retransmission is
> triggered by an RTO or fast
From: Eric Dumazet
gre_gso_segment() chokes if SIT frames were aggregated by GRO engine.
Fixes: 61c1db7fae21e ("ipv6: sit: add GSO/TSO support")
Signed-off-by: Eric Dumazet
---
net/ipv4/gre_offload.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/gre_offload.
Hello.
On 10/24/2015 2:09 AM, Sergei Shtylyov wrote:
In a low memory situation the following kernel oops occurs:
Unable to handle kernel NULL pointer dereference at virtual address 0050
pgd = 8490c000
[0050] *pgd=4651e831, *pte=, *ppte=
Internal error: Oops: 17 [#1] PRE
Messages like "icmp6_send: no reply to icmp error" are close
to useless. Adding source and destination addresses to provide
some more clue.
Signed-off-by: Bjørn Mork
---
I've had this laying around for much too long because I haven't been
convinced it's a good idea... But keeping it around longe
From: Johan Hedberg
Date: Thu, 22 Oct 2015 13:54:55 +0300
> Here's probably the last bluetooth-next pull request for 4.4. Among
> several other changes it contains the rest of the fixes & cleanups from
> the Bluetooth UnplugFest (that didn't need to be hurried to 4.3).
>
> - Refactoring & clean
From: Yuval Mintz
Date: Thu, 22 Oct 2015 08:06:48 +0300
> diff --git a/drivers/net/ethernet/qlogic/qed/Makefile
> b/drivers/net/ethernet/qlogic/qed/Makefile
> new file mode 100644
> index 000..5bbe0c7
> --- /dev/null
> +++ b/drivers/net/ethernet/qlogic/qed/Makefile
> @@ -0,0 +1,3 @@
> +obj-$
From: Lucas Stach
Date: Wed, 21 Oct 2015 15:20:00 +0200
> can you please add
>
> b0c6ce24911fcb64715de9569f0f7b4f54d1d045
> net: fec: Remove unneeded use of IS_ERR_VALUE() macro
>
> 42ea4457aea7aaeddf0c0b06724f297608f5e9d2
> net: fec: normalize return value of pm_runtime_get_sync() in MDIO writ
From: Paul Durrant
Date: Wed, 21 Oct 2015 11:36:17 +0100
> This series adds xen-netback support for hash negotiation with a frontend
> driver, and an implementation of toeplitz hashing as the initial negotiable
> algorithm.
Ping, I want to see some review from some other xen networking folks.
T
> On 24 Oct 2015, at 08:11, Yuchung Cheng wrote:
>
> On Fri, Oct 23, 2015 at 1:50 PM, Bendik Rønning Opstad
> wrote:
>>
>> This is a request for comments.
>>
>> Redundant Data Bundling (RDB) is a mechanism for TCP aimed at reducing
>> the latency for applications sending time-dependent data.
On Fri, 23 Oct 2015 12:47:09 -0700, Pravin Shelar wrote:
> This is not complete code. I found couple of issues with it.
That's likely, I didn't test it :-)
> This code does not copy lwtunnel_state state into new dst.
Not sure what state you mean. All the relevant state should be in
struct ip_tun
David,
I found my patch set is marked with Changes Requested, but I haven't
seen any feedback.
Could you give me your feedback?
Thanks,
Toshiaki Makita
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info a
Joe Stringer wrote:
> err:
> + if (err)
> + kfree_skb(skb);
> skb_push(skb, nh_ofs);
That looks... wrong :-}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel
48 matches
Mail list logo
