Re: [PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate

2015-10-21 Thread Eliad Peller
On Wed, Oct 21, 2015 at 10:07 PM, Punit Vara wrote: > Remove int ret suggested by kbuild test robot > > This patch is to the wlcore/acx.c file that fixes up warning > reported by coccicheck: > > WARNING: end returns can be simplified if negative or 0 value > > Prefer direct return value instead of

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-21 Thread Casper . Dik
>And I'm really curious about the things Solaris would do with dup2() there. >Does it take into account the possibility of new accept() coming just as >dup2() is trying to terminate the ongoing ones? Is there a window when >descriptor-to-file lookups would fail? Looks like a race/deadlock count

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-21 Thread Casper . Dik
>It's been said that the current mechanisms in Linux & some BSD variants >can be subject to races, and the behaviour exhibited doesn't conform to >POSIX, for example requiring the use of shutdown() on unconnected >sockets because close() doesn't kick off other threads accept()ing on >the same

Re: [PATCH v2 net-next] bpf: fix bpf_perf_event_read() helper

2015-10-21 Thread Alexei Starovoitov
On 10/21/15 10:31 PM, Wangnan (F) wrote: +if ((attr->type != PERF_TYPE_RAW && + !(attr->type == PERF_TYPE_SOFTWARE && + attr->config == PERF_COUNT_SW_BPF_OUTPUT) && + attr->type != PERF_TYPE_HARDWARE) || +attr->inherit) { This 'if' statement is so complex.

[PATCH 2/4] xfrm6: Fix ICMPv6 and MH header checks in _decode_session6

2015-10-21 Thread Steffen Klassert
From: Mathias Krause Ensure there's enough data left prior calling pskb_may_pull(). If skb->data was already advanced, we'll call pskb_may_pull() with a negative value converted to unsigned int -- leading to a huge positive value. That won't matter in practice as pskb_may_pull() will likely fail

Re: [RFC v3 1/2] iwlwifi: pcie: allow to build an A-MSDU using TSO core

2015-10-21 Thread Grumbach, Emmanuel
On 10/22/2015 05:27 AM, Eric Dumazet wrote: > On Thu, 2015-10-22 at 00:14 +, Grumbach, Emmanuel wrote: > >> >> Well. I guess I should at least check, but even with very small MSS, our >> device supports up to 20 pointers for the same 802.11 packet: 2 are for >> metadata. So basically, so lea

[PATCH 4/4] xfrm: Fix pmtu discovery for local generated packets.

2015-10-21 Thread Steffen Klassert
Commit 044a832a777 ("xfrm: Fix local error reporting crash with interfamily tunnels") moved the setting of skb->protocol behind the last access of the inner mode family to fix an interfamily crash. Unfortunately now skb->protocol might not be set at all, so we fail dispatch to the inner address fam

[PATCH 3/4] xfrm: Fix state threshold configuration from userspace

2015-10-21 Thread Steffen Klassert
From: Michael Rossberg Allow to change the replay threshold (XFRMA_REPLAY_THRESH) and expiry timer (XFRMA_ETIMER_THRESH) of a state without having to set other attributes like replay counter and byte lifetime. Changing these other values while traffic flows will break the state. Signed-off-by: M

[PATCH 1/4] ipv6: Fix IPsec pre-encap fragmentation check

2015-10-21 Thread Steffen Klassert
From: Herbert Xu The IPv6 IPsec pre-encap path performs fragmentation for tunnel-mode packets. That is, we perform fragmentation pre-encap rather than post-encap. A check was added later to ensure that proper MTU information is passed back for locally generated traffic. Unfortunately this chec

pull request (net): ipsec 2015-10-22

2015-10-21 Thread Steffen Klassert
1) Fix IPsec pre-encap fragmentation for GSO packets. From Herbert Xu. 2) Fix some header checks in _decode_session6. We skip the header informations if the data pointer points already behind the header in question for some protocols. This is because we call pskb_may_pull with a negati

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-21 Thread Al Viro
On Thu, Oct 22, 2015 at 05:44:58AM +0100, Al Viro wrote: > Except that in this case "correctness" is the matter of rather obscure and > ill-documented areas in POSIX. Don't get me wrong - this semantics isn't > inherently bad, but it's nowhere near being an absolute requirement. PS: in principle

Re: [PATCH v2 net-next] bpf: fix bpf_perf_event_read() helper

2015-10-21 Thread Wangnan (F)
On 2015/10/22 6:58, Alexei Starovoitov wrote: Fix safety checks for bpf_perf_event_read(): - only non-inherited events can be added to perf_event_array map (do this check statically at map insertion time) - dynamically check that event is local and !pmu->count Otherwise buggy bpf program can

Re: [PATCH v2 net-next] bpf: fix bpf_perf_event_read() helper

2015-10-21 Thread Wangnan (F)
On 2015/10/22 13:00, Alexei Starovoitov wrote: On 10/21/15 9:49 PM, Wangnan (F) wrote: After applying this patch I'm unable to use perf passing perf_event again like this: please do not top post and trim your replies. # perf record -a -e evt=cycles -e ./test_config_map.c/maps.pmu_map.eve

[PATCH net-next RFC 2/2] vhost_net: basic polling support

2015-10-21 Thread Jason Wang
This patch tries to poll for new added tx buffer for a while at the end of tx processing. The maximum time spent on polling were limited through a module parameter. To avoid block rx, the loop will end it there's new other works queued on vhost so in fact socket receive queue is also be polled. bu

[PATCH net-next RFC 1/2] vhost: introduce vhost_has_work()

2015-10-21 Thread Jason Wang
This path introduces a helper which can give a hint for whether or not there's a work queued in the work list. Signed-off-by: Jason Wang --- drivers/vhost/vhost.c | 6 ++ drivers/vhost/vhost.h | 1 + 2 files changed, 7 insertions(+) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c

[PATCH v6] can: xilinx: Convert to runtime_pm

2015-10-21 Thread Kedareswara rao Appana
Instead of enabling/disabling clocks at several locations in the driver, Use the runtime_pm framework. This consolidates the actions for runtime PM In the appropriate callbacks and makes the driver more readable and mantainable. Signed-off-by: Kedareswara rao Appana --- Sorry for the long delay f

[PATCH 1/2] can: xilinx: use readl/writel instead of ioread/iowrite

2015-10-21 Thread Kedareswara rao Appana
The driver only supports memory-mapped I/O [by ioremap()], so readl/writel is actually the right thing to do, IMO. During the validation of this driver or IP on ARM 64-bit processor while sending lot of packets observed that the tx packet drop with iowrite Putting the barriers for each tx fifo regi

[PATCH net-next v7 06/10] qede: classification configuration

2015-10-21 Thread Yuval Mintz
From: Sudarsana Kalluru Add the ability to configure basic classification in driver by implementing ndo_set_mac_address() and ndo_set_rx_mode(). Signed-off-by: Sudarsana Kalluru Signed-off-by: Yuval Mintz Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qede/qede.h | 10 ++ d

[PATCH net-next v7 07/10] qed: Add link support

2015-10-21 Thread Yuval Mintz
Physical link is handled by the management Firmware. This patch lays the infrastructure for attention handling in the driver, as link change notifications arrive via async. attentions, as well the handling of such notifications. This patch also extends the API with the protocol drivers by adding r

[PATCH net-next v7 09/10] qed: Add statistics support

2015-10-21 Thread Yuval Mintz
From: Manish Chopra Device statistics can be gathered on-demand. This adds the qed support for reading the statistics [both function and port] from the device, and adds to the public API a method for requesting the current statistics. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz Sig

[PATCH net-next v7 10/10] qede: Add basic ethtool support

2015-10-21 Thread Yuval Mintz
From: Sudarsana Kalluru This adds basic ethtool operations to the qed driver, allowing support in: - Statistics gathering [ethtool -S] - Setting of debug level [ethtool -s msglvl] - Getting basic information [ethtool, ethtool -i] In addition it adds the ability to change the MTU. Signed-off

[PATCH net-next v7 02/10] qed: Add basic L2 interface

2015-10-21 Thread Yuval Mintz
From: Manish Chopra This patch adds a public API for a network driver to work on top of QED. The interface itself is very minimal - it's mostly infrastructure, as the only content it has after this patch is a query for HW-based information required for the creation of a network interface [I.e., n

[PATCH net-next v7 08/10] qede: Add support for link

2015-10-21 Thread Yuval Mintz
From: Sudarsana Kalluru This adds basic link functionality to qede - driver still doesn't provide users with an API to change any link property, but it does request qed to initialize the link using default configuration, and registers a callback that allows it to get link notifications. This pat

[PATCH net-next v7 05/10] qede: Add basic network device support

2015-10-21 Thread Yuval Mintz
This patch includes the basic Rx/Tx support for the driver [although carrier will still never be turned on]. Following this patch the driver registers a network device, initializes it and prepares it for traffic. Signed-off-by: Sudarsana Kalluru Signed-off-by: Yuval Mintz Signed-off-by: Ariel El

[PATCH net-next v7 00/10] Add new drivers: qed & qede

2015-10-21 Thread Yuval Mintz
From: Ariel Elior This series implements the driver set for Qlogic's new QL4xxx series. These are 10/20/25/40/50/100 Gig capable converged nics, supporting ethernet (obviously), iscsi, fcoe, roce and iwarp protocols. The overall driver design includes a common module ('qed') and protocol specifi

[PATCH net-next v7 03/10] qede: Add basic Network driver

2015-10-21 Thread Yuval Mintz
The Qlogic Everest Driver for Ethernet is the Ethernet specific module for QL4xxx ethernet products by Qlogic. This patch adds a very minimal PCI driver, one that doesn't yet register a network device, but one that does interact with qed and does a basic initialization of the HW. Signed-off-by: Y

[PATCH net-next v7 04/10] qed: Add slowpath L2 support

2015-10-21 Thread Yuval Mintz
From: Manish Chopra This patch adds to the qed the support to configure various L2 elements, such as channels and basic filtering conditions. It also enhances its public API to allow qede to later utilize this functionality. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz Signed-off-by

[PATCH 2/2] can: xilinx: fix bug in bus error handling

2015-10-21 Thread Kedareswara rao Appana
Simply resetting the peripheral on bus off condition is not enough, Because we also need to re-initialize the whole device. This patch fixes this issue. Signed-off-by: Kedareswara rao Appana --- drivers/net/can/xilinx_can.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2 net-next] bpf: fix bpf_perf_event_read() helper

2015-10-21 Thread Alexei Starovoitov
On 10/21/15 9:49 PM, Wangnan (F) wrote: After applying this patch I'm unable to use perf passing perf_event again like this: please do not top post and trim your replies. # perf record -a -e evt=cycles -e ./test_config_map.c/maps.pmu_map.event=evt/ --exclude-perf ls With -v it output: ...

Re: [PATCH v2 net-next] bpf: fix bpf_perf_event_read() helper

2015-10-21 Thread Wangnan (F)
After applying this patch I'm unable to use perf passing perf_event again like this: # perf record -a -e evt=cycles -e ./test_config_map.c/maps.pmu_map.event=evt/ --exclude-perf ls With -v it output: ... adding perf_bpf_probe:func_write adding perf_bpf_probe:func_write to 0x367d6a0 add bpf

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-21 Thread Al Viro
On Thu, Oct 22, 2015 at 05:17:50AM +0100, Alan Burlison wrote: > It's been said that the current mechanisms in Linux & some BSD > variants can be subject to races You do realize that it goes for the entire area? And the races found in this thread are in the BSD variant that tries to do something

[PATCH 0/8] mm: memcontrol: account socket memory in unified hierarchy

2015-10-21 Thread Johannes Weiner
Hi, this series adds socket buffer memory tracking and accounting to the unified hierarchy memory cgroup controller. [ Networking people, at this time please check the diffstat below to avoid going into convulsions. ] Socket buffer memory can make up a significant share of a workload's memory

[PATCH 1/8] mm: page_counter: let page_counter_try_charge() return bool

2015-10-21 Thread Johannes Weiner
page_counter_try_charge() currently returns 0 on success and -ENOMEM on failure, which is surprising behavior given the function name. Make it follow the expected pattern of try_stuff() functions that return a boolean true to indicate success, or false for failure. Signed-off-by: Johannes Weiner

[PATCH 3/8] net: consolidate memcg socket buffer tracking and accounting

2015-10-21 Thread Johannes Weiner
The tcp memory controller has extensive provisions for future memory accounting interfaces that won't materialize after all. Cut the code base down to what's actually used, now and in the likely future. - There won't be any different protocol counters in the future, so a direct sock->sk_memcg li

[PATCH 4/8] mm: memcontrol: prepare for unified hierarchy socket accounting

2015-10-21 Thread Johannes Weiner
The unified hierarchy memory controller will account socket memory. Move the infrastructure functions accordingly. Signed-off-by: Johannes Weiner --- mm/memcontrol.c | 136 1 file changed, 68 insertions(+), 68 deletions(-) diff --git a/mm

[PATCH 2/8] mm: memcontrol: export root_mem_cgroup

2015-10-21 Thread Johannes Weiner
A later patch will need this symbol in files other than memcontrol.c, so export it now and replace mem_cgroup_root_css at the same time. Signed-off-by: Johannes Weiner --- include/linux/memcontrol.h | 3 ++- mm/backing-dev.c | 2 +- mm/memcontrol.c| 5 ++--- 3 files changed

[PATCH 7/8] mm: vmscan: report vmpressure at the level of reclaim activity

2015-10-21 Thread Johannes Weiner
The vmpressure metric is based on reclaim efficiency, which in turn is an attribute of the LRU. However, vmpressure events are currently reported at the source of pressure rather than at the reclaim level. Switch the reporting to the reclaim level to allow finer-grained analysis of which memcg is

[PATCH 8/8] mm: memcontrol: hook up vmpressure to socket pressure

2015-10-21 Thread Johannes Weiner
Let the networking stack know when a memcg is under reclaim pressure, so it can shrink its transmit windows accordingly. Whenever the reclaim efficiency of a memcg's LRU lists drops low enough for a MEDIUM or HIGH vmpressure event to occur, assert a pressure state in the socket and tcp memory code

[PATCH 6/8] mm: vmscan: simplify memcg vs. global shrinker invocation

2015-10-21 Thread Johannes Weiner
Letting shrink_slab() handle the root_mem_cgroup, and implicitely the !CONFIG_MEMCG case, allows shrink_zone() to invoke the shrinkers unconditionally from within the memcg iteration loop. Signed-off-by: Johannes Weiner --- include/linux/memcontrol.h | 2 ++ mm/vmscan.c| 31

[PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-10-21 Thread Johannes Weiner
Socket memory can be a significant share of overall memory consumed by common workloads. In order to provide reasonable resource isolation out-of-the-box in the unified hierarchy, this type of memory needs to be accounted and tracked per default in the memory controller. Signed-off-by: Johannes We

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-21 Thread Al Viro
On Wed, Oct 21, 2015 at 10:33:04PM +0200, casper@oracle.com wrote: > > >On Wed, Oct 21, 2015 at 03:38:51PM +0100, Alan Burlison wrote: > > > >> >There's going to be a notion of "last close"; that's what this refcount is > >> >about and _that_ is more than implementation detail. > >> > >> Yes,

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-21 Thread Alan Burlison
On 22/10/2015 02:29, David Miller wrote: From: Al Viro Date: Wed, 21 Oct 2015 19:51:04 +0100 Sure, but the upkeep of data structures it would need is there whether you actually end up triggering it or not. Both in memory footprint and in cacheline pingpong... +1 It's been said that the c

Re: [PATCH net-next v4 0/2] mpls: multipath support

2015-10-21 Thread Eric W. Biederman
Roopa Prabhu writes: > From: Roopa Prabhu > > This patch adds support for MPLS multipath routes. > > Includes following changes to support multipath: > - splits struct mpls_route into 'struct mpls_route + struct mpls_nh'. > > - struct mpls_nh represents a mpls nexthop label forwarding entry > >

Re: [PATCH] pcnet32: fix a logic error with pci_set_dma_mask

2015-10-21 Thread Don Fry
On Mon, 2015-10-12 at 05:38 -0700, David Miller wrote: > From: Geliang Tang > Date: Fri, 9 Oct 2015 03:45:39 -0700 > > > pcnet32 can't work on my machine recently. It says "architecture > > does not support 32bit PCI busmaster DMA". There is a logic error > > in it: pci_set_dma_mask() return 0 m

[PATCH] af_key: fix two typos

2015-10-21 Thread roy . qing . li
From: Li RongQing Signed-off-by: Li RongQing --- net/key/af_key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/key/af_key.c b/net/key/af_key.c index 83a7068..f9c9ecb 100644 --- a/net/key/af_key.c +++ b/net/key/af_key.c @@ -261,7 +261,7 @@ static int pfkey_broadcast(st

Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling

2015-10-21 Thread Alexei Starovoitov
On 10/21/15 8:12 PM, Wangnan (F) wrote: On 2015/10/22 11:09, Alexei Starovoitov wrote: On 10/21/15 6:56 PM, Wangnan (F) wrote: One alternative solution I can image is to attach a BPF program at sampling like kprobe, and return 0 if we don't want sampling take action. Thought? Do you think a

[PATCH] net: sysctl: fix a kmemleak warning

2015-10-21 Thread roy . qing . li
From: Li RongQing the returned buffer of register_sysctl() is stored into net_header variable, but net_header is not used after, and compiler maybe optimise the variable out, and lead kmemleak reported the below warning comm "swapper/0", pid 1, jiffies 4294937448 (age 267.270s) h

Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling

2015-10-21 Thread Wangnan (F)
On 2015/10/22 11:09, Alexei Starovoitov wrote: On 10/21/15 6:56 PM, Wangnan (F) wrote: One alternative solution I can image is to attach a BPF program at sampling like kprobe, and return 0 if we don't want sampling take action. Thought? Do you think attaching BPF programs to sampling is an a

Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling

2015-10-21 Thread Alexei Starovoitov
On 10/21/15 6:56 PM, Wangnan (F) wrote: One alternative solution I can image is to attach a BPF program at sampling like kprobe, and return 0 if we don't want sampling take action. Thought? Do you think attaching BPF programs to sampling is an acceptable idea? If you mean to extend 'filter' c

Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling

2015-10-21 Thread Wangnan (F)
On 2015/10/22 0:57, Peter Zijlstra wrote: On Wed, Oct 21, 2015 at 11:06:47PM +0800, pi3orama wrote: So explain; how does this eBPF stuff work. I think I get your point this time, and let me explain the eBPF stuff to you. You are aware that BPF programmer can break the system in this way: A=

Re: [PATCH net-next 2/2] net: mdio-gpio: move platform data header

2015-10-21 Thread David Miller
From: Vivien Didelot Date: Tue, 20 Oct 2015 10:08:59 -0400 > This header file only contains the platform data structure definition, > so move it to the include/linux/platform_data/ directory. > > Signed-off-by: Vivien Didelot Applied. -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH net-next 1/2] ARM: gemini: remove unnecessary mdio-gpio includes

2015-10-21 Thread David Miller
From: Vivien Didelot Date: Tue, 20 Oct 2015 10:08:58 -0400 > Remove the inclusion of linux/mdio-gpio.h in nas4220b, wbd111 and wbd222 > boards since mdio-gpio is not used. > > Signed-off-by: Vivien Didelot Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the bod

Re: [PATCH resend] net: sun4i-emac: Properly free resources on probe failure and remove

2015-10-21 Thread David Miller
From: Hans de Goede Date: Tue, 20 Oct 2015 10:42:24 +0200 > Fix sun4i-emac not releasing the following resources: > -iomapped memory not released on probe-failure nor on remove > -clock not getting disabled on probe-failure nor on remove > -sram not being released on remove > > And while at it a

Re: [RFC v3 1/2] iwlwifi: pcie: allow to build an A-MSDU using TSO core

2015-10-21 Thread Eric Dumazet
On Thu, 2015-10-22 at 00:14 +, Grumbach, Emmanuel wrote: > > Well. I guess I should at least check, but even with very small MSS, our > device supports up to 20 pointers for the same 802.11 packet: 2 are for > metadata. So basically, so leaves me only 18 pointers. for each MSS I > need at lea

Re: [PATCH] net: hisilicon: fix ptr_ret.cocci warnings

2015-10-21 Thread David Miller
From: kbuild test robot Date: Tue, 20 Oct 2015 14:56:00 +0800 > drivers/net/ethernet/hisilicon/hns/hnae.c:442:1-3: WARNING: PTR_ERR_OR_ZERO > can be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > CC: Arnd Bergm

Re: [PATCH net-next] ipv6: gro: support sit protocol

2015-10-21 Thread David Miller
From: Eric Dumazet Date: Mon, 19 Oct 2015 20:40:17 -0700 > From: Eric Dumazet > > Tom Herbert added SIT support to GRO with commit > 19424e052fb4 ("sit: Add gro callbacks to sit_offload"), > later reverted by Herbert Xu. > > The problem came because Tom patch was building GRO > packets without

Re: [PATCH net-next] net: dummy: add more features

2015-10-21 Thread David Miller
From: Eric Dumazet Date: Mon, 19 Oct 2015 20:17:59 -0700 > From: Eric Dumazet > > While testing my SIT/GRO patch using netfilter TEE module and a dummy > device, I found some features were missing : > > TSO IPv6, UFO, and encapsulated traffic. > > ethtool -k dummy0 now gives : > ... > tcp-seg

Re: [PATCHv3 net 3/4] openvswitch: Mark connections new when not confirmed.

2015-10-21 Thread David Miller
From: Joe Stringer Date: Mon, 19 Oct 2015 19:18:59 -0700 > New, related connections are marked as such as part of ovs_ct_lookup(), > but they are not marked as "new" if the commit flag is used. Make this > consistent by setting the "new" flag whenever !nf_ct_is_confirmed(ct). > > Reported-by: Ja

Re: [PATCHv3 net 1/4] openvswitch: Reject ct_state masks for unknown bits

2015-10-21 Thread David Miller
From: Joe Stringer Date: Mon, 19 Oct 2015 19:18:57 -0700 > Currently, 0-bits are generated in ct_state where the bit position is > undefined, and matches are accepted on these bit-positions. If userspace > requests to match the 0-value for this bit then it may expect only a > subset of traffic to

Re: [PATCHv3 net 4/4] openvswitch: Serialize nested ct actions if provided

2015-10-21 Thread David Miller
From: Joe Stringer Date: Mon, 19 Oct 2015 19:19:00 -0700 > If userspace provides a ct action with no nested mark or label, then the > storage for these fields is zeroed. Later when actions are requested, > such zeroed fields are serialized even though userspace didn't > originally specify them. F

Re: [PATCHv3 net 2/4] openvswitch: Clarify conntrack COMMIT behaviour

2015-10-21 Thread David Miller
From: Joe Stringer Date: Mon, 19 Oct 2015 19:18:58 -0700 > The presence of this attribute does not modify the ct_state for the > current packet, only future packets. Make this more clear in the header > definition. > > Signed-off-by: Joe Stringer Applied. -- To unsubscribe from this list: send

Re: [PATCH] tcp: remove improper preemption check in tcp_xmit_probe_skb()

2015-10-21 Thread David Miller
From: Renato Westphal Date: Mon, 19 Oct 2015 18:51:34 -0200 > Commit e520af48c7e5a introduced the following bug when setting the > TCP_REPAIR sockoption: ... > Since tcp_xmit_probe_skb() can be called from process context, use > NET_INC_STATS() instead of NET_INC_STATS_BH(). > > Signed-off-by:

Re: [PATCH 0/4] Netfilter fixes for net

2015-10-21 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 19 Oct 2015 20:22:51 +0200 > The following patchset contains four Netfilter fixes for net, they are: > > 1) Fix Kconfig dependencies of new nf_dup_ipv4 and nf_dup_ipv6. > > 2) Remove bogus test nh_scope in IPv4 rpfilter match that is breaking >--accept-loc

Re: [PATCH net-next v4 1/2] mpls: multipath route support

2015-10-21 Thread Eric W. Biederman
Roopa Prabhu writes: > From: Roopa Prabhu > > This patch adds support for MPLS multipath routes. > > Includes following changes to support multipath: > - splits struct mpls_route into 'struct mpls_route + struct mpls_nh' > > - 'struct mpls_nh' represents a mpls nexthop label forwarding entry > >

Re: [PATCH net-next 2/4] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver

2015-10-21 Thread Yisen.Zhuang(Zhuangyuzeng)
Please check my comment below. thanks. Yisen On 2015/10/20 23:01, Salil wrote: > From: Salil Mehta > > This patch adds the support of "RSS (Receive Side Scaling)" feature > provided by the Hip06 ethernet hardware to the HNS ethernet > driver. > > This feature helps in distributing the differen

Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling

2015-10-21 Thread Wangnan (F)
Hi Alexei, On 2015/10/21 21:42, Wangnan (F) wrote: One alternative solution I can image is to attach a BPF program at sampling like kprobe, and return 0 if we don't want sampling take action. Thought? Do you think attaching BPF programs to sampling is an acceptable idea? Thank you. Actual

Re: [PATCH net-next v3] netlink: Rightsize IFLA_AF_SPEC size calculation

2015-10-21 Thread David Miller
From: Ronen Arad Date: Mon, 19 Oct 2015 09:23:28 -0700 > if_nlmsg_size() overestimates the minimum allocation size of netlink > dump request (when called from rtnl_calcit()) or the size of the > message (when called from rtnl_getlink()). This is because > ext_filter_mask is not supported by rtnl_

Re: [PATCH net 1/1] tipc: conditionally expand buffer headroom over udp tunnel

2015-10-21 Thread David Miller
From: Jon Maloy Date: Mon, 19 Oct 2015 11:43:11 -0400 > In commit d999297c3dbbe ("tipc: reduce locking scope during packet reception") > we altered the packet retransmission function. Since then, when > restransmitting packets, we create a clone of the original buffer > using __pskb_copy(skb, MIN

Re: [PATCH] net: cavium: change NET_VENDOR_CAVIUM to bool

2015-10-21 Thread David Miller
From: Andreas Schwab Date: Mon, 19 Oct 2015 17:37:13 +0200 > CONFIG_NET_VENDOR_CAVIUM is only used to hide/show config options and to > include subdirectories in the build, so it doesn't make sense to make it > tristate. > > Signed-off-by: Andreas Schwab Applied, thanks. -- To unsubscribe from

Re: [PATCH net 1/1] tipc: allow non-linear first fragment buffer

2015-10-21 Thread David Miller
From: Jon Maloy Date: Mon, 19 Oct 2015 11:33:00 -0400 > The current code for message reassembly is erroneously assuming that > the the first arriving fragment buffer always is linear, and then goes > ahead resetting the fragment list of that buffer in anticipation of > more arriving fragments. >

Re: [PATCH net v3] openvswitch: Allocate memory for ovs internal device stats.

2015-10-21 Thread David Miller
From: James Morse Date: Mon, 19 Oct 2015 16:31:55 +0100 > "openvswitch: Remove vport stats" removed the per-vport statistics, in > order to use the netdev's statistics fields. > "openvswitch: Fix ovs_vport_get_stats()" fixed the export of these stats > to user-space, by using the provided netdev_

Re: [PATCH] net: Really fix vti6 with oif in dst lookups

2015-10-21 Thread David Miller
From: David Ahern Date: Mon, 19 Oct 2015 08:26:05 -0700 > 6e28b000825d ("net: Fix vti use case with oif in dst lookups for IPv6") > is missing the checks on FLOWI_FLAG_SKIP_NH_OIF. Add them. > > Fixes: 42a7b32b73d6 ("xfrm: Add oif to dst lookups") > Cc: Steffen Klassert > Signed-off-by: David A

Re: [PATCH net 1/1] tipc: extend broadcast link window size

2015-10-21 Thread David Miller
From: Jon Maloy Date: Mon, 19 Oct 2015 09:21:37 -0400 > The default fix broadcast window size is currently set to 20 packets. > This is a very low value, set at a time when we were still testing on > 10 Mb/s hubs, and a change to it is long overdue. > > Commit 7845989cb4b3da1db ("net: tipc: fix

Re: [PATCH net-next v4 0/2] mpls: multipath support

2015-10-21 Thread David Miller
From: Roopa Prabhu Date: Sun, 18 Oct 2015 18:20:43 -0700 > This patch adds support for MPLS multipath routes. Eric, can you please review these changes? Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majord

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-21 Thread Rob Herring
On Mon, Oct 19, 2015 at 1:58 AM, Marc Kleine-Budde wrote: > On 10/19/2015 08:39 AM, Heiko Schocher wrote: >> add DT support for the ti hecc controller, used on >> am3517 SoCs. > > A similar patch was posted a few days ago, see > http://comments.gmane.org/gmane.linux.can/8616 and my comments. I do

Re: [GIT PULL] ARCNET: code simplification and features

2015-10-21 Thread David Miller
From: Michael Grzeschik Date: Wed, 21 Oct 2015 17:45:26 +0200 > This series includes code simplifaction. The main changes are the correct > xceiver handling (enable/disable) of the com20020 cards. The driver now > handles > link status change detection. The EAE PCI-ARCNET cards now make use of t

Re: [PATCH for-next 0/2] RDMA/cxgb4: Add iWARP support for T6 adapter

2015-10-21 Thread David Miller
From: Doug Ledford Date: Wed, 21 Oct 2015 16:58:50 -0400 > Probably. Unless David objects, I'll queue them up. No objection from me. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ker

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-21 Thread David Miller
From: Al Viro Date: Wed, 21 Oct 2015 19:51:04 +0100 > Sure, but the upkeep of data structures it would need is there > whether you actually end up triggering it or not. Both in > memory footprint and in cacheline pingpong... +1 -- To unsubscribe from this list: send the line "unsubscribe netdev

Re: [PATCH -next] net: hisilicon: Never build on SPARC

2015-10-21 Thread David Miller
From: Guenter Roeck Date: Wed, 21 Oct 2015 10:03:05 -0700 > On 10/21/2015 08:57 AM, Arnd Bergmann wrote: >> On Wednesday 21 October 2015 08:33:11 David Miller wrote: >>> From: Guenter Roeck >>> Date: Wed, 21 Oct 2015 07:56:18 -0700 >>> > @@ -57,6 +57,11 @@ extern int of_dma_get_range(struct

Re: [PATCH net] ppp: don't override sk->sk_state in pppoe_flush_dev()

2015-10-21 Thread Denys Fedoryshchenko
On 2015-10-22 03:14, Matt Bennett wrote: On Tue, 2015-10-13 at 05:13 +0300, Denys Fedoryshchenko wrote: On 2015-10-07 15:12, Guillaume Nault wrote: > On Mon, Oct 05, 2015 at 02:08:44PM +0200, Guillaume Nault wrote: >>if (po) { >>struct sock *sk = sk_pppox(po); >> >> -

Re: [PATCH net-next v4] bnxt_en: New Broadcom ethernet driver.

2015-10-21 Thread Stephen Hemminger
On Wed, 21 Oct 2015 03:45:08 -0400 Michael Chan wrote: > +static inline void bnxt_enable_poll(struct bnxt_napi *bnapi) > +{ > +#ifdef CONFIG_NET_RX_BUSY_POLL > + atomic_set(&bnapi->poll_state, BNXT_STATE_IDLE); > +#endif > +} We need a better way to abstract this and get the #ifdef clutter o

Re: [PATCH net] ppp: don't override sk->sk_state in pppoe_flush_dev()

2015-10-21 Thread Matt Bennett
On Tue, 2015-10-13 at 05:13 +0300, Denys Fedoryshchenko wrote: > On 2015-10-07 15:12, Guillaume Nault wrote: > > On Mon, Oct 05, 2015 at 02:08:44PM +0200, Guillaume Nault wrote: > >>if (po) { > >>struct sock *sk = sk_pppox(po); > >> > >> - bh_lock_sock(sk); > >> - > >> -

Re: [RFC v3 1/2] iwlwifi: pcie: allow to build an A-MSDU using TSO core

2015-10-21 Thread Grumbach, Emmanuel
Hi Eric, On 10/22/2015 02:30 AM, Eric Dumazet wrote: > On Wed, 2015-10-21 at 21:34 +0300, Emmanuel Grumbach wrote: >> When the op_mode sends an skb whose payload is bigger than >> MSS, PCIe will create an A-MSDU out of it. PCIe assumes >> that the skb that is coming from the op_mode can fit in one

Re: [ovs-dev] [RFC PATCH 1/5] netfilter: Remove IP_CT_NEW_REPLY definition.

2015-10-21 Thread Thomas Graf
On 10/21/15 at 01:15pm, Jarno Rajahalme wrote: > > > On Oct 21, 2015, at 1:33 AM, Thomas Graf wrote: > > I understand what you are doing here but this is part of the published > > UAPI and removing this might break compilation of a user application > > even if the definition is not used right now

Re: [RFC PATCH 5/5] openvswitch: Interface with NAT.

2015-10-21 Thread Thomas Graf
On 10/21/15 at 02:04pm, Jarno Rajahalme wrote: > > > On Oct 21, 2015, at 3:59 AM, Thomas Graf wrote: > > Simplify this with an OVS_NAT_ATTR_FLAGS? > > The use of separate flag attributes was actually intentional, as it makes the > interface easier to understand, and code also easier to read. O

Re: [RFC v3 1/2] iwlwifi: pcie: allow to build an A-MSDU using TSO core

2015-10-21 Thread Eric Dumazet
On Wed, 2015-10-21 at 21:34 +0300, Emmanuel Grumbach wrote: > When the op_mode sends an skb whose payload is bigger than > MSS, PCIe will create an A-MSDU out of it. PCIe assumes > that the skb that is coming from the op_mode can fit in one > A-MSDU. It is the op_mode's responsibility to make sure

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-21 Thread Alexander Duyck
On 10/21/2015 12:20 PM, Alex Williamson wrote: On Wed, 2015-10-21 at 21:45 +0300, Or Gerlitz wrote: On Wed, Oct 21, 2015 at 7:37 PM, Lan Tianyu wrote: This patchset is to propose a new solution to add live migration support for 82599 SRIOV network card. In our solution, we prefer to put all

[PATCH v2 net-next] bpf: fix bpf_perf_event_read() helper

2015-10-21 Thread Alexei Starovoitov
Fix safety checks for bpf_perf_event_read(): - only non-inherited events can be added to perf_event_array map (do this check statically at map insertion time) - dynamically check that event is local and !pmu->count Otherwise buggy bpf program can cause kernel splat. Fixes: 35578d798400 ("bpf: Im

Re: [PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-21 Thread Alexei Starovoitov
On 10/21/15 11:34 AM, Thomas Graf wrote: So far, during this discussion, it was proposed to modify the file system >to a single-mount one and to stick this under/sys/kernel/bpf/. This >will not have "real" namespace support either, but it was proposed to >have a following structure: > > /sys/ke

Re: Fw: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-21 Thread Alan Burlison
On 21/10/2015 19:51, Al Viro wrote: BTW, is SCM_RIGHTS outside of scope? They do mention it in one place only: | Ancillary data is also possible at the socket level. The | header shall define the following symbolic constant for use as the cmsg_type | value when cmsg_level is SOL_SOCKET: | | SC

Re: [PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate

2015-10-21 Thread Sergei Shtylyov
On 10/21/2015 10:07 PM, Punit Vara wrote: Remove int ret suggested by kbuild test robot This patch is to the wlcore/acx.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified if negative or 0 value Prefer direct return value instead of writing 2-3 more sen

Re: [RFC Patch 10/12] IXGBEVF: Add lock to protect tx/rx ring operation

2015-10-21 Thread Alexander Duyck
On 10/21/2015 09:37 AM, Lan Tianyu wrote: Ring shifting during restoring VF function maybe race with original ring operation(transmit/receive package). This patch is to add tx/rx lock to protect ring related data. Signed-off-by: Lan Tianyu --- drivers/net/ethernet/intel/ixgbevf/ixgbevf.h

Re: [PATCH -next] net: hisilicon: Never build on SPARC

2015-10-21 Thread Guenter Roeck
On Wed, Oct 21, 2015 at 09:11:53PM +0200, Arnd Bergmann wrote: > On Wednesday 21 October 2015 10:03:05 Guenter Roeck wrote: > > > > > > Something like this? > > > > > > static inline u64 of_translate_address(struct device_node *np, const > > > __be32 *addr) > > > { > > > #if defined(CONFIG_SPARC)

Re: [RFC Patch 09/12] IXGBEVF: Add live migration support for VF driver

2015-10-21 Thread Alexander Duyck
On 10/21/2015 09:37 AM, Lan Tianyu wrote: To let VF driver in the guest to know migration status, Qemu will fake PCI configure reg 0xF0 and 0xF1 to show migrate status and get ack from VF driver. When migration starts, Qemu will set reg "0xF0" to 1, notify VF driver via triggering mail box msg a

Re: [PATCH] net/phy: micrel: Add workaround for bad autoneg

2015-10-21 Thread Florian Fainelli
On 21/10/15 12:42, Nathan Sullivan wrote: > On Wed, Oct 21, 2015 at 12:20:21PM -0700, Florian Fainelli wrote: >> 2015-10-21 12:17 GMT-07:00 Nathan Sullivan : >>> Very rarely, the KSZ9031 will appear to complete autonegotiation, but >>> will drop all traffic afterwards. When this happens, the idle

Re: [PATCH 15/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-21 Thread Sergei Shtylyov
On 10/21/2015 05:55 PM, Punit Vara wrote: This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: Unneeded variable: "ret". Return "0" on line 980 Remove unneeded variable ret created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/wcn36xx/mai

Re: [PATCH 11/15] net: wireless: iwlegacy: Remove unneeded variable ret

2015-10-21 Thread Sergei Shtylyov
On 10/21/2015 05:55 PM, Punit Vara wrote: This patch is to the 3945-mac.c file that fixes up following warning by coccicheck: drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable: "ret". Return "- EOPNOTSUPP" on line 249 Return -EOPNOTSUPP directly instead of return using ret S

Re: [PATCH 01/15] net: wireless: ath: use | instead of + for summing bitmasks

2015-10-21 Thread Sergei Shtylyov
Hello. On 10/21/2015 05:55 PM, Punit Vara wrote: This patch is to the ath10k/pci.h file that fixes following warning pci.c, you mean? reported by coccicheck: WARNING: sum of probable bitmasks, consider | I have replaced + with OR operator | for summing bitmasks Signed-off-by: Punit

Re: [RFC PATCH 2/5] netfilter: Factor out nf_ct_get_info().

2015-10-21 Thread Jarno Rajahalme
> On Oct 21, 2015, at 3:45 AM, Pablo Neira Ayuso wrote: > > On Tue, Oct 20, 2015 at 03:20:26PM -0700, Jarno Rajahalme wrote: >> Define a new inline function to map conntrack status to enum >> ip_conntrack_info. This removes the need to otherwise duplicate this >> code in a later patch. > > Whe

[PATCH net-next] bpf: fix bpf_perf_event_read() helper

2015-10-21 Thread Alexei Starovoitov
Fix safety checks for bpf_perf_event_read(): - only !inherited and !pmu->count events can be added to perf_event_array map (do this check statically at map insertion time) - dynamically check that event is local Otherwise buggy bpf program can cause kernel splat. Fixes: 35578d798400 ("bpf: Imple

  1   2   3   4   >