[PATCH v3] netfilter: ipset: Fix sleeping memory allocation in atomic context

2015-10-15 Thread Nikolay Borisov
Commit 00590fdd5be0 introduced RCU locking in list type and in doing so introduced a memory allocation in list_set_add, which is done in an atomic context, due to the fact that ipset rcu list modifications are serialised with a spin lock. The reason why we can't use a mutex is that in addition t

Re: [RFC PATCH net-next 0/9] netlink: strict attribute checking option

2015-10-15 Thread David Miller
From: Jiri Benc Date: Thu, 15 Oct 2015 18:39:05 +0200 > When sending a netlink request (NLM_F_REQUEST), any unknown attributes are > ignored. This behavior is problematic in some situations. For example if the > user asks for a particular config, the request finishes successfully, yet > the confi

Re: [PATCH] xen-netback: corretly check failed allocation

2015-10-15 Thread David Miller
From: Insu Yun Date: Thu, 15 Oct 2015 12:26:16 -0400 > Since vzalloc can be failed in memory pressure, > return value should be checked and return ENOMEM. > > Signed-off-by: Insu Yun > --- > drivers/net/xen-netback/xenbus.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers

Re: [PATCH 2/2] isdn: correctly check failed allocation

2015-10-15 Thread David Miller
From: Insu Yun Date: Thu, 15 Oct 2015 12:29:28 -0400 > Since skb_clone is memory allocation, it could be failed when lack of > resource. > Therefore, return value of skb_clone needs to be checked and handle error. > > Signed-off-by: Insu Yun > --- > drivers/isdn/mISDN/layer2.c | 6 ++ > 1

Re: [PATCH] mlx4: corretly check failed allocation

2015-10-15 Thread David Miller
From: Insu Yun Date: Thu, 15 Oct 2015 12:24:09 -0400 > When allocation fails, mlx4_alloc_cmd_mailbox returns -ENOMEM. > Since there is no case that mlx4_alloc_cmd_mailbox returns NULL, > it needs to be checked by IS_ERR, not IS_ERR_OR_NULL > > Signed-off-by: Insu Yun Applied to net-next, thank

Re: [PATCH net-next] bonding: support encapsulated ipv6 TSO

2015-10-15 Thread David Miller
From: Eric Dumazet Date: Thu, 15 Oct 2015 09:22:11 -0700 > From: Eric Dumazet > > If using a sixtofour device on top of a bonding device, > skb segmentation of TCP traffic is done right before calling > bonding xmit, because bonding only enables TSO for IPv4. > > This patch improves single flo

Re: [patch net-next 00/15] mlxsw: Driver update, cleanups

2015-10-15 Thread David Miller
From: Jiri Pirko Date: Thu, 15 Oct 2015 17:43:14 +0200 > This patchset contains various cleanups and improvements in mlxsw driver. Series applied, thanks Jiri. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordom

Re: [PATCH iproute2] ip route get: change exit to return to support batch commands

2015-10-15 Thread Vadim Kochan
On Thu, Oct 15, 2015 at 08:13:23PM -0700, roopa wrote: > On 10/15/15, 7:38 PM, David Ahern wrote: > > Hi Roopa: > > > > On 10/15/15 4:23 PM, Roopa Prabhu wrote: > >> From: Roopa Prabhu > >> > >> replace exit with return -2 on rtnl_talk failure > >> > >> Signed-off-by: Roopa Prabhu > >> --- > >>

Re: [PATCH net-next V16 0/3] openvswitch: Add support for 802.1ad

2015-10-15 Thread David Miller
From: Thomas F Herbert Date: Thu, 15 Oct 2015 10:01:52 -0400 > This patch accompanies version 14 of the user level openvswitch patch > submitted to openvswitch dev list. > > V16,15: Implement reviewer comments. Missing signoffs, missed handling of feedback from Sergei, so sorry this still ne

Re: [PATCH] net: phy: smsc: disable energy detect mode

2015-10-15 Thread Heiko Schocher
Hello Florian, Am 14.10.2015 um 06:17 schrieb Heiko Schocher: Hello Florian, Am 13.10.2015 um 21:26 schrieb Florian Fainelli: On 12/10/15 22:13, Heiko Schocher wrote: On some boards the energy enable detect mode leads in trouble with some switches, so make the enabling of this mode configurab

[PATCH] ath6kl: Use vmalloc for loading firmware using api1 method

2015-10-15 Thread Brent Taylor
Signed-off-by: Brent Taylor --- drivers/net/wireless/ath/ath6kl/init.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/init.c b/drivers/net/wireless/ath/ath6kl/init.c index 6e473fa..2155739 100644 --- a/drivers/net/wireless/ath

[no subject]

2015-10-15 Thread arwen lai
Dear Sirs or Madam, My name is James Chang from Senke Mechanical Equipment Engineering Co.,Ltd. We are a leading machine shop in China, We supply all kinds of precision machining parts as per technical drawing or sample at very competitive price with good quality .if interested ,please feel f

[PATCH net-next v3 2/2] net: hisilicon fix a bug on Hisilicon Network Subsystem

2015-10-15 Thread huangdaode
This patch fixes the wrong judgement of mac_id when get port num. Signed-off-by: huangdaode Signed-off-by: yankejian --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/dri

[PATCH net-next v3 1/2] net: hisilicon rm hnae sysfs interface

2015-10-15 Thread huangdaode
This patch removes the hns driver hnae sysfs interface according to Arnd's review comments. Signed-off-by: huangdaode --- drivers/net/ethernet/hisilicon/hns/hnae.c | 47 --- 1 file changed, 47 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.c b/dri

[PATCH net-next v3 0/2] net: hisilicon fix some bugs in HNS drivers

2015-10-15 Thread huangdaode
This patchset fixes the two bugs in HNS driver, one is remove the hnae sysfs interface according to the review comments from Arnd Bergmann , another is fixing the wrong mac_id judgement bug which is found during internal tests. change log: v3: remove the hnae sysfs interface. v2: 1) remove fi

Re: SoCFPGA ethernet broken

2015-10-15 Thread Andrew Lunn
> Another debugging point, the SoCFPGA board has a Micrel ksz9021 PHY attached > to the ethernet port. What I'm seeing is that with 8b63ec1837fa patch, when > the call to ksz9021_config_init() is made both of_node and > dev->parent->of_node > are NULL, without the patch the dev->parent->of_node is

Re: [PATCH iproute2] ip route get: change exit to return to support batch commands

2015-10-15 Thread roopa
On 10/15/15, 7:38 PM, David Ahern wrote: > Hi Roopa: > > On 10/15/15 4:23 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> replace exit with return -2 on rtnl_talk failure >> >> Signed-off-by: Roopa Prabhu >> --- >> ip/iproute.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>

Re: SoCFPGA ethernet broken

2015-10-15 Thread Dinh Nguyen
On Thu, 15 Oct 2015, Florian Fainelli wrote: > On 15/10/15 13:49, Dinh Nguyen wrote: > >> > >> Does this text change with and without the 8b63ec1837fa patch? > > > > No, this text does not change with/without the 8b63ec1837fa patch. > > Could you instrument mdiobus_scan(), get_phy_device() and >

Re: SoCFPGA ethernet broken

2015-10-15 Thread Dinh Nguyen
On Thu, 15 Oct 2015, Florian Fainelli wrote: > On 15/10/15 13:49, Dinh Nguyen wrote: > >> > >> Does this text change with and without the 8b63ec1837fa patch? > > > > No, this text does not change with/without the 8b63ec1837fa patch. > > Could you instrument mdiobus_scan(), get_phy_device() and >

Re: [PATCH iproute2] ip route get: change exit to return to support batch commands

2015-10-15 Thread David Ahern
Hi Roopa: On 10/15/15 4:23 PM, Roopa Prabhu wrote: From: Roopa Prabhu replace exit with return -2 on rtnl_talk failure Signed-off-by: Roopa Prabhu --- ip/iproute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iproute.c b/ip/iproute.c index da25548..b137f55 100644

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-15 Thread Kosuke Tatsukawa
Tatsukawa Kosuke wrote: > J. Bruce Fields wrote: >> On Thu, Oct 15, 2015 at 11:44:20AM +, Kosuke Tatsukawa wrote: >>> Tatsukawa Kosuke wrote: >>> > J. Bruce Fields wrote: >>> >> Thanks for the detailed investigation. >>> >> >>> >> I think it would be worth adding a comment if that might help s

Re: [PATCH net-next V16 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-15 Thread Thomas F Herbert
On 10/15/15 8:37 PM, Pravin Shelar wrote: On Thu, Oct 15, 2015 at 4:48 PM, Thomas F Herbert wrote: On 10/15/15 7:02 PM, Pravin Shelar wrote: Thanks for the review. See my comment below. --TFH On Thu, Oct 15, 2015 at 7:01 AM, Thomas F Herbert wrote: Add support for 802.1ad including the ab

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-15 Thread Kosuke Tatsukawa
J. Bruce Fields wrote: > On Thu, Oct 15, 2015 at 11:44:20AM +, Kosuke Tatsukawa wrote: >> Tatsukawa Kosuke wrote: >> > J. Bruce Fields wrote: >> >> Thanks for the detailed investigation. >> >> >> >> I think it would be worth adding a comment if that might help someone >> >> having to reinvesti

[PATCH net-next 1/4] bpf: abstract anon_inode_getfd invocations

2015-10-15 Thread Daniel Borkmann
Since we're going to use anon_inode_getfd() invocations in more than just the current places, make a helper function for both, so that we only need to pass a map/prog pointer to the helper itself in order to get a fd. The new helpers are called bpf_map_new_fd() and bpf_prog_new_fd(). Signed-off-by

[PATCH net-next 3/4] bpf: add support for persistent maps/progs

2015-10-15 Thread Daniel Borkmann
This work adds support for "persistent" eBPF maps/programs. The term "persistent" is to be understood that maps/programs have a facility that lets them survive process termination. This is desired by various eBPF subsystem users. Just to name one example: tc classifier/action. Whenever tc parses t

[PATCH net-next 4/4] bpf: add sample usages for persistent maps/progs

2015-10-15 Thread Daniel Borkmann
This patch adds a couple of stand-alone examples on how BPF_PIN_FD and BPF_NEW_FD commands can be used. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov --- samples/bpf/Makefile | 2 + samples/bpf/fds_example.c | 224 ++ samples/bpf/

[PATCH net-next 2/4] bpf: align and clean bpf_{map,prog}_get helpers

2015-10-15 Thread Daniel Borkmann
Add a bpf_map_get() function that we're going to use later on and align/clean the remaining helpers a bit so that we have them a bit more consistent: - __bpf_map_get() and __bpf_prog_get() that both work on the fd struct, check whether the descriptor is eBPF and return the pointer to the

[PATCH net-next 0/4] BPF updates

2015-10-15 Thread Daniel Borkmann
This set adds support for persistent maps/progs. Please see individual patches for further details. A man-page update to bpf(2) will be sent afterwards, also a iproute2 patch for support in tc. Thanks! Daniel Borkmann (4): bpf: abstract anon_inode_getfd invocations bpf: align and clean bpf_{

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-15 Thread Neil Brown
"J. Bruce Fields" writes: > On Thu, Oct 15, 2015 at 11:44:20AM +, Kosuke Tatsukawa wrote: >> Tatsukawa Kosuke wrote: >> > J. Bruce Fields wrote: >> >> Thanks for the detailed investigation. >> >> >> >> I think it would be worth adding a comment if that might help someone >> >> having to rein

Re: [PATCH net-next V16 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-15 Thread Pravin Shelar
On Thu, Oct 15, 2015 at 4:48 PM, Thomas F Herbert wrote: > On 10/15/15 7:02 PM, Pravin Shelar wrote: > Thanks for the review. See my comment below. > > --TFH > > >> On Thu, Oct 15, 2015 at 7:01 AM, Thomas F Herbert >> wrote: >>> >>> Add support for 802.1ad including the ability to push and pop do

Re: [PATCH net-next v2] ipconfig: send Client-identifier in DHCP requests

2015-10-15 Thread Li RongQing
On Thu, Oct 15, 2015 at 10:56 PM, Florian Fainelli wrote: > Did not you mean strlen(dhcp_client_identifer) + 1 instead? no; dhcp_client_identifer[0] is client identifier type, and it maybe 0; dhcp_client_identifer+1 is the start address of client identifier value; -Roy -- To unsubscribe from th

Re: [PATCH net-next V16 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-15 Thread Thomas F Herbert
On 10/15/15 7:02 PM, Pravin Shelar wrote: Thanks for the review. See my comment below. --TFH On Thu, Oct 15, 2015 at 7:01 AM, Thomas F Herbert wrote: Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netlink parsing and flow conversi

[PATCH net 2/2] ipv6: Initialize rt6_info properly in ip6_blackhole_route()

2015-10-15 Thread Martin KaFai Lau
ip6_blackhole_route() does not initialize the newly allocated rt6_info properly. This patch: 1. Call rt6_info_init() to initialize rt6i_siblings and rt6i_uncached 2. The current rt->dst._metrics init code is incorrect: - 'rt->dst._metrics = ort->dst._metris' is not always safe - Not sure wh

[PATCH net 1/2] ipv6: Move common init code for rt6_info to a new function rt6_info_init()

2015-10-15 Thread Martin KaFai Lau
Introduce rt6_info_init() to do the common init work for 'struct rt6_info' (after calling dst_alloc). It is a prep work to fix the rt6_info init logic in the ip6_blackhole_route(). Signed-off-by: Martin KaFai Lau Cc: Hannes Frederic Sowa Cc: Julian Anastasov Cc: Phil Sutter Cc: Steffen Klasse

[PATCH net 0/2] ipv6: Initialize rt6_info properly in ip6_blackhole_route()

2015-10-15 Thread Martin KaFai Lau
This patchset ensures the rt6_info's fields are initialized properly in ip6_blackhole_route() where xfrm_policy is the primarily user. The first patch is a prep work. The second patch is the fix. It fixes d52d3997f843 ("ipv6: Create percpu rt6_info"). Here is the oops reported by Phil Sutter :

Re: [PATCH net-next V16 3/3] openvswitch: 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-15 Thread Pravin Shelar
On Thu, Oct 15, 2015 at 7:01 AM, Thomas F Herbert wrote: > Add support for 802.1ad including the ability to push and pop double > tagged vlans. Add support for 802.1ad to netlink parsing and flow > conversion. Uses double nested encap attributes to represent double > tagged vlan. Inner TPID encode

[PATCH iproute2] ip route get: change exit to return to support batch commands

2015-10-15 Thread Roopa Prabhu
From: Roopa Prabhu replace exit with return -2 on rtnl_talk failure Signed-off-by: Roopa Prabhu --- ip/iproute.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iproute.c b/ip/iproute.c index da25548..b137f55 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -1643,7 +1643,

Re: [net-next 03/17] i40evf: Add support for netpoll

2015-10-15 Thread Sergei Shtylyov
Hello. On 10/16/2015 12:43 AM, Jeff Kirsher wrote: From: Alexander Duyck Signed-off-by: Alexander Duyck Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 26 + 1 file changed, 26 insertions(+) diff --git a

Re: [RFC PATCH net-next 0/9] netlink: strict attribute checking option

2015-10-15 Thread Hannes Frederic Sowa
Jiri Benc writes: > Before using this new facility, the application should check whether it is > supported by the kernel. This is done by sending a NLMSG_NOOP message with > NLM_F_REQUEST | NLM_F_STRICT | NLM_F_ACK flags set. If the returned message > has NLM_F_STRICT set, the kernel does support

[PATCH iproute2] bridge: add calls to fflush in fdb and mdb print functions

2015-10-15 Thread Roopa Prabhu
From: Wilson Kok This patch adds fflush in fdb and mdb print functions Signed-off-by: Wilson Kok Signed-off-by: Roopa Prabhu --- bridge/fdb.c | 2 ++ bridge/mdb.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/bridge/fdb.c b/bridge/fdb.c index bd7e4f9..5ea50ab 100644 --- a/bridge/fdb.

[net-next 06/17] i40e/i40evf: Fix compile issue related to const string

2015-10-15 Thread Jeff Kirsher
From: Jingjing Wu Add const to functions that return strings that aren't going to be modified. This addresses some reported compile complaints. Change-ID: Ic56b1e814ab4d23a50480e7fdec652445f776ee8 Signed-off-by: Jingjing Wu Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net

[net-next 07/17] i40e: remove read/write failed messages from nvmupdate

2015-10-15 Thread Jeff Kirsher
From: Shannon Nelson Allow the nvmupdate application to decide when a read or write error should be exposed to the user. Since the application needs to use write probes to find the ReadOnly sections on a potentially unknown NVM version in the HW and read probes to check the status of the last wr

[net-next 04/17] drivers/net/intel: use napi_complete_done()

2015-10-15 Thread Jeff Kirsher
From: Jesse Brandeburg As per Eric Dumazet's previous patches: (see commit (24d2e4a50737) - tg3: use napi_complete_done()) Quoting verbatim: Using napi_complete_done() instead of napi_complete() allows us to use /sys/class/net/ethX/gro_flush_timeout GRO layer can aggregate more packets if the f

[net-next 01/17] i40e/i40evf: Fix handling of napi budget

2015-10-15 Thread Jeff Kirsher
From: Alexander Duyck The polling routine for i40e was rounding up the budget for Rx cleanup to 1. This is incorrect as the netpoll poll call is expecting no Rx to be processed as the budget passed was 0. Signed-off-by: Alexander Duyck Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 13/17] i40evf: correctly populate vlan_features

2015-10-15 Thread Jeff Kirsher
From: Mitch Williams The vlan_features field was correctly being set to the same value as the netdev features field. However, this was being done before the features were actually being set up, leaving the vlan_features empty. Also, after a reset, vlan_features will be incorrectly assigned the p

[net-next 11/17] i40e/i40evf: moderate interrupts differently

2015-10-15 Thread Jeff Kirsher
From: Jesse Brandeburg The XL710 hardware has a different interrupt moderation design that can support a limit of total interrupts per second per vector, in addition to the "number of interrupts per second" controls already established in the driver. This combination of hardware features allows

[net-next 09/17] i40e: priv flag for controlling VEB stats

2015-10-15 Thread Jeff Kirsher
From: Shannon Nelson Add an ethtool priv flag to enable and disable printing the VEB statistics. Change-ID: I7654054a3a73b08aa8310d94ee8fce6219107dd8 Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e.h | 1 + d

[net-next 05/17] i40e: generate fewer startup messages

2015-10-15 Thread Jeff Kirsher
From: Shannon Nelson Cut down on the number of startup log entries by putting a couple behind debug flags and combining a couple others into a single line. Change-ID: I708089f086308f84d43f8b6f0e8a634a02d058fb Signed-off-by: Shannon Nelson Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher -

[net-next 12/17] i40e: reset the invalid msg counter in vf when a valid msg is received

2015-10-15 Thread Jeff Kirsher
From: Jingjing Wu When the number of invalid messages from a VF is exceeded, the VF will be disabled, due to the invalid messages. This happens if other VF drivers (like DPDK) send a message through the driver's mailbox (aka virtchannel) interface, but the message is not supported by the i40e pf

[net-next 08/17] i40e: Removed unused defines

2015-10-15 Thread Jeff Kirsher
From: Greg Rose Two defines that are not used are causing customer confusion - remove them. Change-ID: Icef0325aca8e0f4fcdfc519e026bdd375e791200 Signed-off-by: Greg Rose Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h | 2 -- 1 file

[net-next 02/17] i40e/i40evf: Drop useless "IN_NETPOLL" flag

2015-10-15 Thread Jeff Kirsher
From: Alexander Duyck The code in i40e and i40evf is using an "IN_NETPOLL" flag that has never added any value due to the fact that the Rx clean-up is handled in NAPI. As such the flag was set, the queue was scheduled via NAPI, and then polled from the netpoll controller and if any Rx packets wer

[net-next 17/17] i40e/i40evf: Bump i40e to 1.3.34 and i40evf to 1.3.21

2015-10-15 Thread Jeff Kirsher
From: Catherine Sullivan Bump. Change-ID: I7ec818a507554648675b9b245ced9e6b6bd9ed4e Signed-off-by: Catherine Sullivan Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- 2 fil

[net-next 16/17] i40e: increase AQ work limit

2015-10-15 Thread Jeff Kirsher
From: Mitch Williams With 64 VFs, we can easily overwhelm the AQ on the PF if we have too low a limit on the number of AQ requests. This leads to ARQ overflow errors, and occasionally VFs that fail to initialize. Since we really only hit this condition on initial VF driver load, the requests tha

[net-next 14/17] i40e: Recognize 1000Base_T_Optical phy type when link is up

2015-10-15 Thread Jeff Kirsher
From: Catherine Sullivan 1000Base_T_Optical got added to the function that figures out what is supported when link is down but not when link is up. Add it in there too so that we display the correct information. Change-ID: I85ebcdfa7c02d898c44c673b1500552a53c8042e Signed-off-by: Catherine Sulliv

[net-next 10/17] i40e: Add support for non-willing Apps

2015-10-15 Thread Jeff Kirsher
From: Greg Bowers Adds support for setting a new bit in the Set Local LLDP MIB AQ command Type field. When set to 1, the bit indicates to FW that Apps should be treated as non-willing. When 0, FW behaves as before. Change-ID: I0d2101c1606c59c7188d3e6a0c7810e0f205233a Signed-off-by: Greg Bowers

[net-next 15/17] i40evf: relax and stagger init timing a bit

2015-10-15 Thread Jeff Kirsher
From: Mitch Williams On some devices, in some systems, in some configurations, the VFs would fail to initialize the first time you loaded the driver. To correct this, increase the delay time for the init task slightly, and wait longer before giving up. If we enable VFs and load the VF driver in

[net-next 03/17] i40evf: Add support for netpoll

2015-10-15 Thread Jeff Kirsher
From: Alexander Duyck Signed-off-by: Alexander Duyck Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 26 + 1 file changed, 26 insertions(+) diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drive

[net-next 00/17][pull request] Intel Wired LAN Driver Updates 2015-10-15

2015-10-15 Thread Jeff Kirsher
This series contains updates to e1000, e1000e, igb, igbvf, ixgbe, ixgbevf, i40e, i40evf and fm10k. Alex Duyck fixes the polling routine for i40e/i40evf were the NAPI budget for receive cleanup was being rounded up to 1 but the netpoll call was expecting no Rx to be processed as the budget passed w

Re: SoCFPGA ethernet broken

2015-10-15 Thread Florian Fainelli
On 15/10/15 13:49, Dinh Nguyen wrote: >> >> Does this text change with and without the 8b63ec1837fa patch? > > No, this text does not change with/without the 8b63ec1837fa patch. Could you instrument mdiobus_scan(), get_phy_device() and phy_device_create/register to see if the parent is NULL, non-

Re: [PATCH v2] sunrpc: fix waitqueue_active without memory barrier in sunrpc

2015-10-15 Thread J. Bruce Fields
On Thu, Oct 15, 2015 at 11:44:20AM +, Kosuke Tatsukawa wrote: > Tatsukawa Kosuke wrote: > > J. Bruce Fields wrote: > >> Thanks for the detailed investigation. > >> > >> I think it would be worth adding a comment if that might help someone > >> having to reinvestigate this again some day. > >

Re: SoCFPGA ethernet broken

2015-10-15 Thread Dinh Nguyen
On 10/15/2015 03:35 PM, David Daney wrote: > On 10/15/2015 01:25 PM, Florian Fainelli wrote: >> On 15/10/15 12:59, Dinh Nguyen wrote: >>> On 10/15/2015 03:03 PM, Florian Fainelli wrote: On 15/10/15 12:09, Dinh Nguyen wrote: > Hi, > > commit "8b63ec1837fa phylib: Make PHYs children

Re: [PATCH v2] netfilter: ipset: Fix sleeping memory allocation in atomic context

2015-10-15 Thread Eric Dumazet
On Thu, 2015-10-15 at 23:20 +0300, Nikolay Borisov wrote: > While GFP_ATOMIC does indeed look the correct solution for this particular > case I was wondering whether something like (GFP_KERNEL & ~__GFP_WAIT) > wouldn't also make the cut without causing sleeping? I guess this is exactly > the sort

SoCFPGA ethernet broken

2015-10-15 Thread Dinh Nguyen
Hi, commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not the bus' parent." seems to have broken ethernet support for the SoCFPGA platform which is using the stmmac ethernet driver. It appears that during DHCP, it cannot get an IP address. This only happens if ethernet was not us

Re: SoCFPGA ethernet broken

2015-10-15 Thread David Daney
On 10/15/2015 01:25 PM, Florian Fainelli wrote: On 15/10/15 12:59, Dinh Nguyen wrote: On 10/15/2015 03:03 PM, Florian Fainelli wrote: On 15/10/15 12:09, Dinh Nguyen wrote: Hi, commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not the bus' parent." seems to have broken etherne

[PATCH] ip-rule: neither prohibit nor reject or unreachable flags exist

2015-10-15 Thread Phil Sutter
This has been inconsistent since the beginning of Git and seems to be merely a documentation leftover, therefore just remove it from help output and man page. Signed-off-by: Phil Sutter --- ip/iprule.c| 1 - man/man8/ip-rule.8 | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff

Re: SoCFPGA ethernet broken

2015-10-15 Thread Florian Fainelli
On 15/10/15 12:59, Dinh Nguyen wrote: > On 10/15/2015 03:03 PM, Florian Fainelli wrote: >> On 15/10/15 12:09, Dinh Nguyen wrote: >>> Hi, >>> >>> commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not >>> the bus' parent." seems to have broken ethernet support for the SoCFPGA >>> pla

[PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

2015-10-15 Thread Michal Marek
Otherwise make tags can't parse them: ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern "\1" ctags: Warning: drivers/xen/events/events_2l.c:41: null expansion of name pattern "\1" ctags: Warning: drivers/acpi/processor_idle.c:64: null expansion of name pattern "\1" ctags:

Re: [PATCH v2] netfilter: ipset: Fix sleeping memory allocation in atomic context

2015-10-15 Thread Nikolay Borisov
On Thu, Oct 15, 2015 at 9:46 PM, Eric Dumazet wrote: > On Thu, 2015-10-15 at 20:25 +0200, Jozsef Kadlecsik wrote: > >> Nikolay answered this pretty well: we wouldn't need the spinlock at all, >> because all commands are serialized anyway with the netlink mutex. But the >> garbage collector is call

Re: SoCFPGA ethernet broken

2015-10-15 Thread Dinh Nguyen
On 10/15/2015 03:03 PM, Florian Fainelli wrote: > On 15/10/15 12:09, Dinh Nguyen wrote: >> Hi, >> >> commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not >> the bus' parent." seems to have broken ethernet support for the SoCFPGA >> platform which is using the stmmac ethernet drive

Re: SoCFPGA ethernet broken

2015-10-15 Thread Florian Fainelli
On 15/10/15 12:09, Dinh Nguyen wrote: > Hi, > > commit "8b63ec1837fa phylib: Make PHYs children of their MDIO bus, not > the bus' parent." seems to have broken ethernet support for the SoCFPGA > platform which is using the stmmac ethernet driver. It is not clear to me how this relates to what you

Re: [PATCH] bcm63xx_enet: check 1000BASE-T advertisement configuration

2015-10-15 Thread Florian Fainelli
Adding a few people, On 15/10/15 13:00, Simon Arlott wrote: > If a gigabit ethernet PHY is connected to a fast ethernet MAC, > then it can detect 1000 support from the partner but not use it. > > This results in a forced speed of 1000 and RX/TX failure. > > Check for 1000BASE-T support and then

[PATCH] bcm63xx_enet: check 1000BASE-T advertisement configuration

2015-10-15 Thread Simon Arlott
If a gigabit ethernet PHY is connected to a fast ethernet MAC, then it can detect 1000 support from the partner but not use it. This results in a forced speed of 1000 and RX/TX failure. Check for 1000BASE-T support and then check the advertisement configuration before setting the MAC speed to 100

[PATCH net-next v3] drivers/net: get rid of unnecessary initializations in .get_drvinfo()

2015-10-15 Thread Ivan Vecera
Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len, eedump_len & regdump_len fields in their .get_drvinfo() ethtool op. It's not necessary as these fields is filled in ethtool_get_drvinfo(). v2: removed unused variable v3: removed another unused variable Signed-off-by: Ivan Vec

[PATCH iproute2] ss: return -1 if an unrecognized option was given

2015-10-15 Thread Phil Sutter
When getopt_long encounters an option which has not been registered, it returns '?'. React upon that and call usage() instead of help() so ss returns with a non-zero exit status. Signed-off-by: Phil Sutter --- misc/ss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/ss.

[PATCH net-next 1/7] tipc: limit usage of temporary skb list during packet reception

2015-10-15 Thread Jon Maloy
During packet reception, the function tipc_link_rcv() adds its accepted packets to a temporary buffer queue, before finally splicing this queue into the lock protected input queue that will be delivered up to the socket layer. The purpose is to reduce potential contention on the input queue lock. H

[PATCH net-next 0/7] tipc: some link level code improvements

2015-10-15 Thread Jon Maloy
Extensive testing has revealed some weaknesses and non-optimal solutions in the link level code. This commit series addresses those issues. Jon Maloy (7): tipc: limit usage of temporary skb list during packet reception tipc: simplify tipc_link_rcv() reception loop tipc: improve sequence nu

[PATCH net-next 6/7] tipc: send out RESET immediately when link goes down

2015-10-15 Thread Jon Maloy
When a link is taken down because of a node local event, such as disabling of a bearer or an interface, we currently leave it to the peer node to discover the broken communication. The default time for such failure discovery is 1.5-2 seconds. If we instead allow the terminating link endpoint to se

[PATCH net-next 5/7] tipc: delay ESTABLISH state event when link is established

2015-10-15 Thread Jon Maloy
Link establishing, just like link teardown, is a non-atomic action, in the sense that discovering that conditions are right to establish a link, and the actual adding of the link to one of the node's send slots is done in two different lock contexts. The link FSM is designed to help bridging the ga

[PATCH net-next 3/7] tipc: improve sequence number checking

2015-10-15 Thread Jon Maloy
The sequence number of an incoming packet is currently only checked for less than, equality to, or bigger than the next expected number, meaning that the receive window in practice becomes one half sequence number cycle, or U16_MAX/2. This does not make sense, and may not even be safe if there are

[PATCH net-next 2/7] tipc: simplify tipc_link_rcv() reception loop

2015-10-15 Thread Jon Maloy
Currently, all packets received in tipc_link_rcv() are unconditionally added to the packet deferred queue, whereafter that queue is walked and all its buffers evaluated for delivery. This is both non-optimal and and makes the queue sorting function unnecessary complex. This commit changes the loop

[PATCH net-next 4/7] tipc: disallow packet duplicates in link deferred queue

2015-10-15 Thread Jon Maloy
After the previous commits, we are guaranteed that no packets of type LINK_PROTOCOL or with illegal sequence numbers will be attempted added to the link deferred queue. This makes it possible to make some simplifications to the sorting algorithm in the function tipc_skb_queue_sorted(). We also alt

[PATCH net-next 7/7] tipc: update node FSM when peer RESET message is received

2015-10-15 Thread Jon Maloy
The change made in the previous commit revealed a small flaw in the way the node FSM is updated. When the function tipc_node_link_down() is called for the last link to a node, we should check whether this was caused by a local reset or by a received RESET message from the peer. In the latter case,

[PATCH iproute2] ip monitor neigh: Change 'delete' to 'Deleted' to be consistent with ip route

2015-10-15 Thread Roopa Prabhu
From: Roopa Prabhu It helps to grep for one string "Deleted" when monitoring all events. Fixes: 6ea3ebafe077 ("iproute2: inform user when a neighbor is removed") Signed-off-by: Roopa Prabhu --- I am not sure if it is too late for this change. But, sending this patch out because it only affects

Re: [PATCH v2] netfilter: ipset: Fix sleeping memory allocation in atomic context

2015-10-15 Thread Eric Dumazet
On Thu, 2015-10-15 at 20:25 +0200, Jozsef Kadlecsik wrote: > Nikolay answered this pretty well: we wouldn't need the spinlock at all, > because all commands are serialized anyway with the netlink mutex. But the > garbage collector is called by a timer and therefore spinlock is used. > Good, pl

Re: [PATCH 2/2] isdn: correctly check failed allocation

2015-10-15 Thread isdn
Hi Insu, thanks for bringing up this issue again. I thought I did fix this a year ago, but seems it did not managed to sent it upstream. The patch do not fix this completly, since it will drop the original skb from the L2 I frame queue, so the transmission would lost an I-FRAME, which is not allo

Re: [PATCH net-next v2] drivers/net: get rid of unnecessary initializations in .get_drvinfo()

2015-10-15 Thread kbuild test robot
Hi Ivan, [auto build test WARNING on net-next/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Ivan-Vecera/drivers-net-get-rid-of-unnecessary-initializations-in-get_drvinfo/20151016-010035 config: x

Re: [PATCH v2] netfilter: ipset: Fix sleeping memory allocation in atomic context

2015-10-15 Thread Jozsef Kadlecsik
Hi, On Thu, 15 Oct 2015, Eric Dumazet wrote: > On Thu, 2015-10-15 at 16:41 +0300, Nikolay Borisov wrote: > > > > On 10/15/2015 04:32 PM, Eric Dumazet wrote: > > > On Thu, 2015-10-15 at 13:56 +0300, Nikolay Borisov wrote: > > >> Commit 00590fdd5be0 introduced RCU locking in list type and in > > >

Re: [PATCH net 3/3] openvswitch: Serialize nested ct actions if provided

2015-10-15 Thread Pravin Shelar
On Wed, Oct 14, 2015 at 11:10 AM, Joe Stringer wrote: > If userspace provides a ct action with no nested mark or label, then the > storage for these fields is zeroed. Later when actions are requested, > such zeroed fields are serialized even though userspace didn't > originally specify them. Fix t

Re: [PATCH net 2/3] openvswitch: Treat IP_CT_RELATED as new

2015-10-15 Thread Pravin Shelar
On Wed, Oct 14, 2015 at 11:10 AM, Joe Stringer wrote: > New, related connections are marked as such as part of ovs_ct_lookup(), > but they are not marked as "new" if the commit flag is used. Make this > consistent by treating IP_CT_RELATED as new as well. > > Reported-by: Jarno Rajahalme > Signed

Re: [PATCH net 1/3] openvswitch: Reject ct_state masks for unknown bits

2015-10-15 Thread Pravin Shelar
On Wed, Oct 14, 2015 at 11:10 AM, Joe Stringer wrote: > Currently, 0-bits are generated in ct_state where the bit position is > undefined, and matches are accepted on these bit-positions. If userspace > requests to match the 0-value for this bit then it may expect only a > subset of traffic to mat

[PATCH] xen-netback: correctly check failed allocation

2015-10-15 Thread Insu Yun
Since vzalloc can be failed in memory pressure, writes -ENOMEM to xenstore to indicate error. Signed-off-by: Insu Yun --- drivers/net/xen-netback/xenbus.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen-netback/xenbus.c index 929a6e7..

[PATCH] net: asix: add support for the Billionton GUSB2AM-1G-B USB adapter

2015-10-15 Thread changchias
From: Chia-Sheng Chang Just another AX88178-based 10/100/1000 USB-to-Ethernet dongle. This one shows up in lsusb as: "ID 08dd:0114 Billionton Systems, Inc". Signed-off-by: Chia-Sheng Chang Cc: "David S. Miller" Cc: Luca Ceresoli Cc: Christoph Jaeger Cc: "woojung@microchip.com" Cc: Matth

[PATCH v2 0/1] Fix for module license in Broadcom Phy Library

2015-10-15 Thread Arun Parameswaran
Hi This patchset adds the module description, license & author to the Broadcom Phy Library (drivers/net/phy/bcm-phy-lib.c) introduced by the commit: a1cba5613edf5 ("net: phy: Add Broadcom phy library for common interfaces") Changes from v1: -Created the patch based on David Miller's 'net-next' Ker

Re: [PATCH v2 1/1] net: phy: bcm-phy-lib: Fix module license issue

2015-10-15 Thread Florian Fainelli
On 15/10/15 10:37, Arun Parameswaran wrote: > The 'bcm-phy-lib.c', added as a part of the commit > "net: phy: Add Broadcom phy library for common interfaces" > was missing the module license. This was causing an issue > when the library is built as a module; "module license > 'unspecified' taints k

[PATCH v2 1/1] net: phy: bcm-phy-lib: Fix module license issue

2015-10-15 Thread Arun Parameswaran
The 'bcm-phy-lib.c', added as a part of the commit "net: phy: Add Broadcom phy library for common interfaces" was missing the module license. This was causing an issue when the library is built as a module; "module license 'unspecified' taints kernel". This patch fixes the issue by adding the modu

Re: [PATCH net-next V16 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

2015-10-15 Thread Sergei Shtylyov
On 10/15/2015 05:36 PM, Thomas F Herbert wrote: Signed-off-by: Thomas F Herbert --- include/linux/if_vlan.h | 16 1 file changed, 16 insertions(+) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 67ce5bd..ac23521 100644 --- a/include/linux/if_vlan.h +++

Re: [PATCH 2/2] openvswitch: Allocate memory for ovs internal device stats.

2015-10-15 Thread Pravin Shelar
On Thu, Oct 15, 2015 at 7:54 AM, James Morse wrote: > "openvswitch: Remove vport stats" removed the per-vport statistics, in > order to use the netdev's statistics fields. > "openvswitch: Fix ovs_vport_get_stats()" fixed the export of these stats > to user-space, by using the provided netdev_ops t

Re: [PATCH] net: asix: add support for the Billionton GUSB2AM-1G-B USB adapter

2015-10-15 Thread Jonathan Chang
On Thu, 15 Oct 2015 06:05:07 -0700, David Miller writes: > From: > Date: Thu, 15 Oct 2015 18:51:38 +0800 > > > * > > This email message, including any attachments, is for the sole > > use of the intended recipient(s) and may

Re: [PATCH] xen-netback: corretly check failed allocation

2015-10-15 Thread Wei Liu
On Thu, Oct 15, 2015 at 12:26:16PM -0400, Insu Yun wrote: > Since vzalloc can be failed in memory pressure, > return value should be checked and return ENOMEM. This function doesn't return ENOMEM, instead it writes to xenstore to indicate error. The commit log needs to be updated. > > Signed-off

Re: [PATCH 1/1] net: phy: bcm-phy-lib: Fix module license issue

2015-10-15 Thread Arun Parameswaran
On 15-10-14 06:39 PM, David Miller wrote: > From: Arun Parameswaran > Date: Tue, 13 Oct 2015 13:40:12 -0700 > >> The 'bcm-phy-lib.c', added as a part of the commit >> "net: phy: Add Broadcom phy library for common interfaces" >> was missing the module license. This was causing an issue >> when t

  1   2   3   >