pull-request: can 2015-08-25

2015-08-24 Thread Marc Kleine-Budde
Hello David, this is the updated pull request of one patch by me for the peak_usb driver. It fixes the driver, so that non FD adapters don't provide CAN FD bittimings. regards, Marc --- The following changes since commit b6df7d61c8776a882dd47ba4714d1445dd7ef2d9: net: bcmgenet: fix uncleaned

[PATCH] can: pcan_usb: don't provide CAN FD bittimings by non-FD adapters

2015-08-24 Thread Marc Kleine-Budde
The CAN FD data bittiming constants are provided via netlink only when there are valid CAN FD constants available in priv->data_bittiming_const. Due to the indirection of pointer assignments in the peak_usb driver the priv->data_bittiming_const never becomes NULL - not even for non-FD adapters. T

Re: pull-request: can 2015-08-24

2015-08-24 Thread Marc Kleine-Budde
On 08/24/2015 11:20 AM, Marc Kleine-Budde wrote: > Hello David, > > this is a pull request of one patch by me for the peak_usb driver. It fixes > the > driver, so that non FD adapters don't provide CAN FD bittimings. As there are some typos in the commit message I'll send an updated pull request

Re: [net-next PATCH 1/3] drivers: net: cpsw: add am335x errata workarround for interrutps

2015-08-24 Thread Mugunthan V N
On Monday 24 August 2015 03:34 PM, Sekhar Nori wrote: > Hi Mugunthan, > > On Wednesday 12 August 2015 03:22 PM, Mugunthan V N wrote: >> > +static const struct of_device_id cpsw_of_mtable[] = { >> > + { .compatible = "ti,cpsw", .data = &cpsw_devtype[CPSW], }, >> > + { .compatible = "ti,am335x-cps

Re: iproute2: Behavioural Bug?

2015-08-24 Thread Cong Wang
On Mon, Aug 24, 2015 at 10:14 PM, Akshat Kakkar wrote: > Dear Florian, > > There are two filters 15:2:2 and 15:2:3 and I have deleted only > 15:2:3, so 15:2:2 will still be there and hence this condition > "destroy proto tp when all filters are gone" should not be applicable > over here. > Floria

use after free again...

2015-08-24 Thread Cong Wang
Hi, Jiri, In your commit 61adedf3e3f1d3f032c5a6a299978d91eff6d555 ("route: move lwtunnel state to dst_entry"), how the hell could the following piece be correct? :-/ @@ -264,6 +266,7 @@ again: kfree(dst); else kmem_cache_free(dst->ops->kmem_cachep, dst); +

Compile error: 'nf_skb_duplicated' undeclared (first use in this function)

2015-08-24 Thread Cong Wang
Hi, I just got: net/ipv4/netfilter/nf_dup_ipv4.c: In function ‘nf_dup_ipv4’: net/ipv4/netfilter/nf_dup_ipv4.c:72:16: error: ‘nf_skb_duplicated’ undeclared (first use in this function) if (this_cpu_read(nf_skb_duplicated)) ^ net/ipv4/netfilter/nf_dup_ipv4.c:72:16: note: each unde

Re: iproute2: Behavioural Bug?

2015-08-24 Thread Akshat Kakkar
Dear Florian, There are two filters 15:2:2 and 15:2:3 and I have deleted only 15:2:3, so 15:2:2 will still be there and hence this condition "destroy proto tp when all filters are gone" should not be applicable over here. On Tue, Aug 25, 2015 at 4:52 AM, Florian Westphal wrote: > Akshat Kakkar

Re: [PATCH, net-next] r8169: On RTL 8101 series bit SYSErr is reserved.

2015-08-24 Thread Marian Corcodel
May be entire program must rewritten due multiple errors. 2015-08-24 21:38 GMT+03:00, David Miller : > From: Corcodel Marian > Date: Mon, 24 Aug 2015 21:12:53 +0300 > >> diff --git a/drivers/net/ethernet/realtek/r8169.c >> b/drivers/net/ethernet/realtek/r8169.c >> index 5693e65..32d2072 100644 >>

Re: [RFC] netlink: netlink_ack send a capped message in case of error

2015-08-24 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 24 Aug 2015 20:56:37 +0200 > On Mon, Aug 24, 2015 at 10:08:22AM +0200, Christophe Ricard wrote: >> Hi Scott, >> >> I think i understand the potential limitation of my solution. >> I saw something was proposed by Jiri Benc who pushed an additional flag to >> tel

Re: [PATCH v3 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-24 Thread Pravin Shelar
On Mon, Aug 24, 2015 at 6:42 PM, Jesse Gross wrote: > On Mon, Aug 24, 2015 at 10:43 AM, Pravin B Shelar wrote: >> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c >> index 0a6d974..c05bc13 100644 >> --- a/drivers/net/geneve.c >> +++ b/drivers/net/geneve.c >> @@ -141,10 +190,15 @@ drop: >>

Re: [v2 03/11] soc/fsl: Introduce the DPAA BMan portal driver

2015-08-24 Thread Scott Wood
On Wed, Aug 12, 2015 at 04:14:49PM -0400, Roy Pledge wrote: > diff --git a/drivers/soc/fsl/qbman/bman.c b/drivers/soc/fsl/qbman/bman.c > index 9a500ce..d6e2204 100644 > --- a/drivers/soc/fsl/qbman/bman.c > +++ b/drivers/soc/fsl/qbman/bman.c > @@ -165,11 +165,11 @@ static struct bman *bm_create(void

Re: [PATCH v3 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-24 Thread Jesse Gross
On Mon, Aug 24, 2015 at 10:43 AM, Pravin B Shelar wrote: > diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c > index 0a6d974..c05bc13 100644 > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > @@ -141,10 +190,15 @@ drop: > /* Setup stats when device is created */ > static int gene

[PATCH iproute2 v2] add support for brief output for link and addresses

2015-08-24 Thread Andy Gospodarek
This adds support for slightly less output than is normally provided by 'ip link show' and 'ip addr show'. This is a bit better when you have a host with lots of interfaces. Sample output: $ ip -br link show lo UNKNOWN 00:00:00:00:00:00 p7p1 UP 08:00:27:9d:62:9

Re: [PATCH iproute2] add support for brief output for link and addresses

2015-08-24 Thread Andy Gospodarek
On Mon, Aug 24, 2015 at 02:08:29PM -0700, Stephen Hemminger wrote: > On Mon, 24 Aug 2015 20:41:16 + > Andy Gospodarek wrote: > > > This adds support for slightly less output than is normally provided by > > 'ip link show' and 'ip addr show'. This is a bit better when you have a > > host with

[PATCHv5 net-next 00/10] OVS conntrack support

2015-08-24 Thread Joe Stringer
The goal of this series is to allow OVS to send packets through the Linux kernel connection tracker, and subsequently match on fields populated by conntrack. This version addresses the feedback from v4, mostly minor fixes, including shifting the conntrack init into the per-namespace functions rath

[PATCHv5 net-next 04/10] dst: Add __skb_dst_copy() variation

2015-08-24 Thread Joe Stringer
This variation on skb_dst_copy() doesn't require two skbs. Signed-off-by: Joe Stringer Acked-by: Pravin B Shelar --- v4: Add ack. v5: No change. --- include/net/dst.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/include/net/dst.h b/include/net/dst.h index 0a9a723

[PATCHv5 net-next 01/10] openvswitch: Serialize acts with original netlink len

2015-08-24 Thread Joe Stringer
Previously, we used the kernel-internal netlink actions length to calculate the size of messages to serialize back to userspace. However,the sw_flow_actions may not be formatted exactly the same as the actions on the wire, so store the original actions length when de-serializing and re-use the orig

[PATCHv5 net-next 03/10] ipv6: Export nf_ct_frag6_gather()

2015-08-24 Thread Joe Stringer
Signed-off-by: Joe Stringer Acked-by: Thomas Graf Acked-by: Pravin B Shelar --- v4: Add ack. v5: No change. --- net/ipv6/netfilter/nf_conntrack_reasm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_reasm.c index 6d

[PATCHv5 net-next 02/10] openvswitch: Move MASKED* macros to datapath.h

2015-08-24 Thread Joe Stringer
This will allow the ovs-conntrack code to reuse these macros. Signed-off-by: Joe Stringer Acked-by: Thomas Graf Acked-by: Pravin B Shelar --- v4: Add ack. v5: No change. --- net/openvswitch/actions.c | 52 ++ net/openvswitch/datapath.h | 4 2

Re: [PATCH net-next 09/13] vxlan: provide access function for vxlan socket address family

2015-08-24 Thread Rustad, Mark D
> On Aug 18, 2015, at 1:33 PM, Jiri Benc wrote: > > Signed-off-by: Jiri Benc > --- > drivers/net/vxlan.c | 8 > include/net/vxlan.h | 5 + > 2 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c > index e4b8ab63d0fa..d5ca1d7e0b81

[PATCHv5 net-next 05/10] openvswitch: Add conntrack action

2015-08-24 Thread Joe Stringer
Expose the kernel connection tracker via OVS. Userspace components can make use of the CT action to populate the connection state (ct_state) field for a flow. This state can be subsequently matched. Exposed connection states are OVS_CS_F_*: - NEW (0x01) - Beginning of a new connection. - ESTABLISH

[PATCHv5 net-next 08/10] netfilter: connlabels: Export setting connlabel length

2015-08-24 Thread Joe Stringer
Add functions to change connlabel length into nf_conntrack_labels.c so they may be reused by other modules like OVS and nftables without needing to jump through xt_match_check() hoops. Suggested-by: Florian Westphal Signed-off-by: Joe Stringer Acked-by: Florian Westphal Acked-by: Thomas Graf -

[PATCHv5 net-next 09/10] openvswitch: Allow matching on conntrack label

2015-08-24 Thread Joe Stringer
Allow matching and setting the ct_label field. As with ct_mark, this is populated by executing the CT action. The label field may be modified by specifying a label and mask nested under the CT action. It is stored as metadata attached to the connection. Label modification occurs after lookup, and w

[PATCHv5 net-next 07/10] netfilter: Always export nf_connlabels_replace()

2015-08-24 Thread Joe Stringer
The following patches will reuse this code from OVS. Signed-off-by: Joe Stringer Acked-by: Pravin B Shelar Acked-by: Thomas Graf --- v2-v4: No change. v5: Add acks. --- net/netfilter/nf_conntrack_labels.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/netfilter/nf_conntrack_labels.c

[PATCHv5 net-next 10/10] openvswitch: Allow attaching helpers to ct action

2015-08-24 Thread Joe Stringer
Add support for using conntrack helpers to assist protocol detection. The new OVS_CT_ATTR_HELPER attribute of the CT action specifies a helper to be used for this connection. If no helper is specified, then helpers will be automatically applied as per the sysctl configuration of net.netfilter.nf_co

[PATCHv5 net-next 06/10] openvswitch: Allow matching on conntrack mark

2015-08-24 Thread Joe Stringer
Allow matching and setting the ct_mark field. As with ct_state and ct_zone, these fields are populated when the CT action is executed. To write to this field, a value and mask can be specified as a nested attribute under the CT action. This data is stored with the conntrack entry, and is executed a

Re: Correct way to access MDIO bus - phy.c seems buggy

2015-08-24 Thread Florian Fainelli
On 24/08/15 17:09, Russell King - ARM Linux wrote: > Hi, > > While trying to track down instability in the FEC driver, I've come > across this question: what is the correct way to access the MDIO bus? > > Is it via: > > bus->write() > > where 'bus' is a struct mii_bus, or should it be via

Re: [v2 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-08-24 Thread Scott Wood
On Wed, 2015-08-12 at 16:14 -0400, Roy Pledge wrote: > From: Geoff Thorpe > > This driver enables the Freescale DPAA 1.0 Buffer Manager block. BMan > is a hardware buffer pool manager that allows accelerators > connected to the SoC datapath to acquire and release buffers during > data processing.

Correct way to access MDIO bus - phy.c seems buggy

2015-08-24 Thread Russell King - ARM Linux
Hi, While trying to track down instability in the FEC driver, I've come across this question: what is the correct way to access the MDIO bus? Is it via: bus->write() where 'bus' is a struct mii_bus, or should it be via mdiobus_write()? What I'm seeing in the FEC driver is two thread tr

Re: [PATCH v2 net-next] r8169: Add values missing in @get_stats64 from HW counters

2015-08-24 Thread Francois Romieu
Corinna Vinschen : > On Aug 22 13:23, Francois Romieu wrote: [...] > > Sorry, my english was really bad: > > > > the code should propagate failure when rtl8169_reset_counters and > > rtl8169_update_counters *simultaneously* fail. > > Uhm... sorry, but that still doesn't answer the question. As

Re: iproute2: Behavioural Bug?

2015-08-24 Thread Florian Westphal
Akshat Kakkar wrote: [ CC Cong ] > When I am trying to delete a single tc filter (i.e. specifying its > handle), it is deleting all the > filters with the same priority/preference. i.e. it is ignoring the > handle specified. > > But, When I am doing similar activity in hashtable 800: it is dele

Re: [v2 00/11] Freescale DPAA QBMan Drivers

2015-08-24 Thread Scott Wood
On Wed, 2015-08-12 at 16:14 -0400, Roy Pledge wrote: > The Freescale Data Path Acceleration Architecture (DPAA) is a set of > hardware components on specific QorIQ multicore processors. This > architecture provides the infrastructure to support simplified sharing of > networking interfaces and a

Re: [PATCH v3 net-next 3/8] tunnel: introduce udp_tun_rx_dst()

2015-08-24 Thread Jesse Gross
On Mon, Aug 24, 2015 at 10:43 AM, Pravin B Shelar wrote: > Introduce function udp_tun_rx_dst() to initialize tunnel dst on > receive path. > > Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH v2] net: Fix RCU splat in af_key

2015-08-24 Thread David Miller
From: David Ahern Date: Mon, 24 Aug 2015 15:17:17 -0600 > Hit the following splat testing VRF change for ipsec: ... > In pfkey_sendmsg the net mutex is taken and then pfkey_broadcast takes > the RCU lock. > > Since pfkey_broadcast takes the RCU lock the allocation argument is > pointless since

Re: [PATCH v2] net: Fix RCU splat in af_key

2015-08-24 Thread Eric Dumazet
On Mon, 2015-08-24 at 15:17 -0600, David Ahern wrote: > Hit the following splat testing VRF change for ipsec: > > In pfkey_sendmsg the net mutex is taken and then pfkey_broadcast takes > the RCU lock. > > Since pfkey_broadcast takes the RCU lock the allocation argument is > pointless since GFP_A

[PATCH net-next] MAINTAINERS: update vmxnet3 driver maintainer

2015-08-24 Thread Shrikrishna Khare
Shreyas Bhatewara would no longer maintain the vmxnet3 driver. Taking over the role of vmxnet3 maintainer. Signed-off-by: Shrikrishna Khare Signed off-by: Shreyas Bhatewara --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4e6dcb

[PATCH v2] net: Fix RCU splat in af_key

2015-08-24 Thread David Ahern
Hit the following splat testing VRF change for ipsec: [ 113.475692] === [ 113.476194] [ INFO: suspicious RCU usage. ] [ 113.476667] 4.2.0-rc6-1+deb7u2+clUNRELEASED #3.2.65-1+deb7u2+clUNRELEASED Not tainted [ 113.477545] --- [ 113.478013

Re: [PATCH v3 00/22] FUJITSU Extended Socket network device driver

2015-08-24 Thread David Miller
From: Taku Izumi Date: Fri, 21 Aug 2015 17:28:00 +0900 > This patchsets adds FUJITSU Extended Socket network device driver. > Extended Socket network device is a shared memory based high-speed > network interface between Extended Partitions of PRIMEQUEST 2000 E2 > series. > > You can get some in

Re: [PATCH iproute2] add support for brief output for link and addresses

2015-08-24 Thread Stephen Hemminger
On Mon, 24 Aug 2015 20:41:16 + Andy Gospodarek wrote: > This adds support for slightly less output than is normally provided by > 'ip link show' and 'ip addr show'. This is a bit better when you have a > host with lots of interfaces. Sample output: > > $ ip -br link show > lo

Re: [PATCH 2/2] usbnet: Fix a race between usbnet_stop() and the BH

2015-08-24 Thread Bjørn Mork
Eugene Shatokhin writes: > The race may happen when a device (e.g. YOTA 4G LTE Modem) is > unplugged while the system is downloading a large file from the Net. > > Hardware breakpoints and Kprobes with delays were used to confirm that > the race does actually happen. > > The race is on skb_queue

[PATCH iproute2] add support for brief output for link and addresses

2015-08-24 Thread Andy Gospodarek
This adds support for slightly less output than is normally provided by 'ip link show' and 'ip addr show'. This is a bit better when you have a host with lots of interfaces. Sample output: $ ip -br link show lo UNKNOWN 00:00:00:00:00:00 p7p1 UP 08:00:27:9d:62:9

RE: [PATCH net-next 2/2] lan78xx: update eee code

2015-08-24 Thread Woojung.Huh
Hi Florian, Thanks for comments. Will update to utilize phylib. - Woojung > -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Friday, August 21, 2015 5:57 PM > To: Woojung Huh - C21699; da...@davemloft.net > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH

[PATCH 0/2] usbnet: Fix 2 problems in usbnet_stop()

2015-08-24 Thread Eugene Shatokhin
The following problems found when investigating races in usbnet module are fixed here: 1. EVENT_NO_RUNTIME_PM bit of dev->flags should be read before it is cleared by "dev->flags = 0". Thanks to Oliver Neukum for spotting this problem and providing a fix. 2. A race on on skb_queue between usbne

RE: [PATCH v3 3/4] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-08-24 Thread Hall, Christopher S
> -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Sunday, August 23, 2015 4:26 AM > To: Thomas Gleixner > Cc: Hall, Christopher S; Kirsher, Jeffrey T; h...@zytor.com; > mi...@redhat.com; john.stu...@linaro.org; x...@kernel.org; linux- > ker...@vger.kerne

Re: [PATCH net-next] udp_offload: Allow device GRO without checksum-complete

2015-08-24 Thread Eric Dumazet
On Mon, 2015-08-24 at 12:34 -0700, Tom Herbert wrote: > diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c > index c0a15e7..1d91227 100644 > --- a/net/ipv4/udp.c > +++ b/net/ipv4/udp.c > @@ -130,6 +130,9 @@ EXPORT_SYMBOL(sysctl_udp_wmem_min); > atomic_long_t udp_memory_allocated; > EXPORT_SYMBOL(udp_m

[PATCH 1/2] usbnet: Get EVENT_NO_RUNTIME_PM bit before it is cleared

2015-08-24 Thread Eugene Shatokhin
It is needed to check EVENT_NO_RUNTIME_PM bit of dev->flags in usbnet_stop(), but its value should be read before it is cleared when dev->flags is set to 0. The problem was spotted and the fix was provided by Oliver Neukum . Signed-off-by: Eugene Shatokhin --- drivers/net/usb/usbnet.c | 7 -

[PATCH 2/2] usbnet: Fix a race between usbnet_stop() and the BH

2015-08-24 Thread Eugene Shatokhin
The race may happen when a device (e.g. YOTA 4G LTE Modem) is unplugged while the system is downloading a large file from the Net. Hardware breakpoints and Kprobes with delays were used to confirm that the race does actually happen. The race is on skb_queue ('next' pointer) between usbnet_stop()

[PATCH net-next] udp_offload: Allow device GRO without checksum-complete

2015-08-24 Thread Tom Herbert
This patch adds a sysctl which allows GRO for a UDP offload protocol to be performed in the device NAPI. This potentially is a performance improvement if the savings of doing GRO in device NAPI outweighs the cost of performing the checksum. Note that the performing the checksum in device NAPI may n

Re: [PATCH net-next] 3c59x: Add BQL support for 3c59x ethernet driver.

2015-08-24 Thread David Miller
From: Loganaden Velvindron Date: Thu, 20 Aug 2015 19:22:18 -0700 > This BQL patch is based on work done by Tino Reichardt. > > Tested on :05:00.0: 3Com PCI 3c905C Tornado at c9e6e000 by running > Flent several times. > > > Signed-off-by: Loganaden Velvindron Applied, thanks. -- T

Re: iproute2: Behavioural Bug?

2015-08-24 Thread Vadim Kochan
On Mon, Aug 24, 2015 at 02:00:29PM +0530, Akshat Kakkar wrote: > When I am trying to delete a single tc filter (i.e. specifying its > handle), it is deleting all the > filters with the same priority/preference. i.e. it is ignoring the > handle specified. > > But, When I am doing similar activity i

[PATCH v4 11/11] mtrr: bury MTRR - unexport mtrr_add() and mtrr_del()

2015-08-24 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The crusade to replace mtrr_add() with architecture agnostic arch_phys_wc_add() is complete, this will ensure write-combining implementations (PAT on x86) is taken advantage instead of using MTRR. With the crusade done now, hide direct MTRR access for drivers. Update x8

Re: [PATCH net v2] sctp: start t5 timer only when peer.rwnd is 0 and local.state is SHUTDOWN_PENDING

2015-08-24 Thread Marcelo Ricardo Leitner
On Mon, Aug 24, 2015 at 02:36:59PM -0400, Vlad Yasevich wrote: > On 08/24/2015 02:31 PM, Marcelo Ricardo Leitner wrote: > > On Mon, Aug 24, 2015 at 02:13:38PM -0400, Vlad Yasevich wrote: > >> On 08/23/2015 07:30 AM, Xin Long wrote: > >>> when A sends a data to B, then A close() and enter into SHUTD

Re: [RFC] netlink: netlink_ack send a capped message in case of error

2015-08-24 Thread Pablo Neira Ayuso
On Mon, Aug 24, 2015 at 10:08:22AM +0200, Christophe Ricard wrote: > Hi Scott, > > I think i understand the potential limitation of my solution. > I saw something was proposed by Jiri Benc who pushed an additional flag to > tell if the payload can be ignored in case of an error. > http://patchwork

Re: [PATCH v3 01/10] ss: rooted out ss type declarations for output formatters

2015-08-24 Thread Matthias Tafelmeier
-BEGIN PGP MESSAGE- Charset: windows-1252 Version: GnuPG v1 hQQOAweL74a5LMkVEA//azcgajmoTO+UKZPf5wl+V8QAi/r9gCmyyJR0wV6RsH0N sUpnR2c9uSVNU+J41L206vDsnNk0Huoa6m6miibLFg3mxQ9KTDdzaePmkfk9FwCC Au7RsDzxo8nq/rpZsPeD2r/EAod6C3XVGRNc6nAMMi84tMCtObjDFDQs+mPcWf5n nCZwmdovGtzCHpw6moq51K8pql0CmRpFSnM

Re: [PATCH, net-next] r8169: On RTL 8101 series bit SYSErr is reserved.

2015-08-24 Thread David Miller
From: Corcodel Marian Date: Mon, 24 Aug 2015 21:12:53 +0300 > diff --git a/drivers/net/ethernet/realtek/r8169.c > b/drivers/net/ethernet/realtek/r8169.c > index 5693e65..32d2072 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -8256,6 +8256,14

Re: [PATCH net v2] sctp: start t5 timer only when peer.rwnd is 0 and local.state is SHUTDOWN_PENDING

2015-08-24 Thread Vlad Yasevich
On 08/24/2015 02:31 PM, Marcelo Ricardo Leitner wrote: > On Mon, Aug 24, 2015 at 02:13:38PM -0400, Vlad Yasevich wrote: >> On 08/23/2015 07:30 AM, Xin Long wrote: >>> when A sends a data to B, then A close() and enter into SHUTDOWN_PENDING >>> state, >>> if B neither claim his rwnd is 0 nor send S

Re: [PATCH] usbnet: Fix two races between usbnet_stop() and the BH

2015-08-24 Thread David Miller
From: Alan Stern Date: Mon, 24 Aug 2015 14:06:15 -0400 (EDT) > On Mon, 24 Aug 2015, David Miller wrote: >> Atomic operations like clear_bit also will behave that way. > > Are you certain about that? I couldn't find any mention of it in > Documentation/atomic_ops.txt. > > In theory, an architec

Re: [PATCH net v2] sctp: start t5 timer only when peer.rwnd is 0 and local.state is SHUTDOWN_PENDING

2015-08-24 Thread Marcelo Ricardo Leitner
On Mon, Aug 24, 2015 at 02:13:38PM -0400, Vlad Yasevich wrote: > On 08/23/2015 07:30 AM, Xin Long wrote: > > when A sends a data to B, then A close() and enter into SHUTDOWN_PENDING > > state, > > if B neither claim his rwnd is 0 nor send SACK for this data, A will keep > > retransmitting this dat

Re: [PATCH net] sctp: partial chunk should be drop without sending abort packet

2015-08-24 Thread Daniel Borkmann
On 08/24/2015 02:47 PM, Marcelo Ricardo Leitner wrote: On Mon, Aug 24, 2015 at 06:08:30PM +0800, Xin Long wrote: as RFC 4960, 6.10 said, *if the receiver detects a partial chunk, it MUST drop the chunk*, we should not send the abort. but if we put this discard to inside state machine, it will se

Re: [PATCH] usbnet: Fix two races between usbnet_stop() and the BH

2015-08-24 Thread Alan Stern
On Mon, 24 Aug 2015, Alan Stern wrote: > On Mon, 24 Aug 2015, David Miller wrote: > > > From: Eugene Shatokhin > > Date: Wed, 19 Aug 2015 14:59:01 +0300 > > > > > So the following might be possible, although unlikely: > > > > > > CPU0 CPU1 > > > clear_bit: read dev

[PATCH, net-next] r8169: On RTL 8101 series bit SYSErr is reserved.

2015-08-24 Thread Corcodel Marian
On RTL 8101 series bit SYSErr is reserved. Signed-off-by: Corcodel Marian diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 5693e65..32d2072 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -8256,6 +8256

Re: Low throughput in VMs using VxLAN

2015-08-24 Thread Vlad Yasevich
On 08/24/2015 12:19 PM, Santosh R wrote: > Hi, > >Earlier I was seeing lower throughput in VMs using VxLan as GRO was > not happening in VM. > Tom Herbert suggested to use "vxlan: GRO support at tunnel layer" patch > series. > With today's net-next (4.2.0-rc7) in host and VM, I could see GRO

Re: [PATCH net v2] sctp: start t5 timer only when peer.rwnd is 0 and local.state is SHUTDOWN_PENDING

2015-08-24 Thread Vlad Yasevich
On 08/23/2015 07:30 AM, Xin Long wrote: > when A sends a data to B, then A close() and enter into SHUTDOWN_PENDING > state, > if B neither claim his rwnd is 0 nor send SACK for this data, A will keep > retransmitting this data util t5 timeout, Max.Retrans times can't work > anymore, > which is ba

Re: [PATCH] usbnet: Fix two races between usbnet_stop() and the BH

2015-08-24 Thread Eugene Shatokhin
24.08.2015 20:43, David Miller пишет: From: Eugene Shatokhin Date: Wed, 19 Aug 2015 14:59:01 +0300 So the following might be possible, although unlikely: CPU0 CPU1 clear_bit: read dev->flags clear_bit: clear EVENT_RX_KILL in the read value dev-

Re: [PATCH] usbnet: Fix two races between usbnet_stop() and the BH

2015-08-24 Thread Alan Stern
On Mon, 24 Aug 2015, David Miller wrote: > From: Eugene Shatokhin > Date: Wed, 19 Aug 2015 14:59:01 +0300 > > > So the following might be possible, although unlikely: > > > > CPU0 CPU1 > > clear_bit: read dev->flags > > clear_bit: clear EVENT_RX_KIL

Re: [PATCH net] sctp: partial chunk should be drop without sending abort packet

2015-08-24 Thread Vlad Yasevich
On 08/24/2015 06:08 AM, Xin Long wrote: > as RFC 4960, 6.10 said, *if the receiver detects a partial chunk, it MUST drop > the chunk*, we should not send the abort. but if we put this discard to inside > state machine, it will send abort. > Actually, silently dropping this is _very_ bad. There r

Re: [PATCH net] sctp: asconf process should treat multiple address parameter as unrecognized parameter

2015-08-24 Thread Vlad Yasevich
On 08/24/2015 06:07 AM, Xin Long wrote: > currently, we sctp_walk_params(), if we encounter the address parameter, we > will > skip them, we do not care about how many addr params are there. > > but the params of ASCONF chunk should consist of one *Address Parameter* and > one > or more *ASCONF

Re: [PATCH net-next 4/9] net: dsa: Allow configuration of CPU & DSA port speeds/duplex

2015-08-24 Thread Florian Fainelli
On 23/08/15 14:24, Andrew Lunn wrote: >>> + port_dn = cd->port_dn[port]; >>> + if (of_phy_is_fixed_link(port_dn)) { >>> + ret = of_phy_register_fixed_link(port_dn); >>> + if (ret) { >>> + netdev_err(master, >>> +

[PATCH v3 net-next 3/8] tunnel: introduce udp_tun_rx_dst()

2015-08-24 Thread Pravin B Shelar
Introduce function udp_tun_rx_dst() to initialize tunnel dst on receive path. Signed-off-by: Pravin B Shelar --- Rebased to support ipv6 tun-dst. --- drivers/net/vxlan.c| 29 ++-- include/net/dst_metadata.h | 61 include/ne

Re: [PATCH] usbnet: Fix two races between usbnet_stop() and the BH

2015-08-24 Thread David Miller
From: Eugene Shatokhin Date: Wed, 19 Aug 2015 14:59:01 +0300 > So the following might be possible, although unlikely: > > CPU0 CPU1 > clear_bit: read dev->flags > clear_bit: clear EVENT_RX_KILL in the read value > > dev->flags=0; > >

[PATCH v3 net-next 6/8] openvswitch: Use Geneve device.

2015-08-24 Thread Pravin B Shelar
With help of tunnel metadata mode OVS can directly use Geneve devices to implement Geneve tunnels. This patch removes all of the OVS specific Geneve code and make OVS use a Geneve net_device. Basic geneve vport is still there to handle compatibility with current userspace application. Signed-off-b

[PATCH v3 net-next 1/8] geneve: Initialize ethernet address in device setup.

2015-08-24 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf --- drivers/net/geneve.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index 897e1a3..95e9da0 100644 --- a/drivers/net/geneve.c +++ b/drivers/n

[PATCH v3 net-next 5/8] geneve: Add support to collect tunnel metadata.

2015-08-24 Thread Pravin B Shelar
Following patch create new tunnel flag which enable tunnel metadata collection on given device. These devices can be used by tunnel metadata based routing or by OVS. Geneve Consolidation patch get rid of collect_md_tun to simplify tunnel lookup further. Signed-off-by: Pravin B Shelar --- v2-v3: D

[PATCH v3 net-next 2/8] geneve: Use skb mark and protocol to lookup route.

2015-08-24 Thread Pravin B Shelar
On packet transmit path geneve need to lookup route. Following patch improves route lookup using more parameters. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross Acked-by: Thomas Graf --- drivers/net/geneve.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dr

[PATCH v3 net-next 7/8] geneve: Consolidate Geneve functionality in single module.

2015-08-24 Thread Pravin B Shelar
geneve_core module handles send and receive functionality. This way OVS could use the Geneve API. Now with use of tunnel meatadata mode OVS can directly use Geneve netdevice. So there is no need for separate module for Geneve. Following patch consolidates Geneve protocol processing in single module

[PATCH v3 net-next 8/8] geneve: Move device hash table to geneve socket.

2015-08-24 Thread Pravin B Shelar
This change simplifies Geneve Tunnel hash table management. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross --- drivers/net/geneve.c | 58 ++--- 1 files changed, 26 insertions(+), 32 deletions(-) diff --git a/drivers/net/geneve.c b/drivers/

[PATCH v3 net-next 0/8] Geneve: Add support for tunnel metadata mode

2015-08-24 Thread Pravin B Shelar
Following patches adds support for Geneve tunnel metadata mode. OVS can make use of Geneve net-device with tunnel metadata API from kernel. This also allows us to consolidate Geneve implementation from two kernel modules geneve_core and geneve to single geneve module. geneve_core module was target

[PATCH v3 net-next 4/8] geneve: Make dst-port configurable.

2015-08-24 Thread Pravin B Shelar
Add netlink interface to configure Geneve UDP port number. So that user can configure it for a Gevene device. Signed-off-by: Pravin B Shelar Reviewed-by: Jesse Gross --- Fixed dst-port netlink encoding --- drivers/net/geneve.c | 25 + include/uapi/linux/if_link

Re: [PATCH net-next v3 0/2] ila: Precompute checksums

2015-08-24 Thread David Miller
From: Tom Herbert Date: Mon, 24 Aug 2015 09:45:40 -0700 > This patch set: > - Adds argument ot LWT build_state that holds a pointer to the fib >configuration being applied to the new route > - Adds support in ILA to precompute checksum difference for >performance optimization > > v2: >

Re: [PATCH net] sctp: asconf's process should verify address parameter is in the beginning

2015-08-24 Thread Vlad Yasevich
On 08/24/2015 06:07 AM, Xin Long wrote: > in sctp_process_asconf(), we get address parameter from the beginning of the > addip params. but we never check if it's really there. if the addr param is > not > there, it still can pass sctp_verify_asconf(), then to be handled by > sctp_process_asconf(),

Re: Low throughput in VMs using VxLAN

2015-08-24 Thread Rick Jones
On 08/24/2015 09:19 AM, Santosh R wrote: Hi, Earlier I was seeing lower throughput in VMs using VxLan as GRO was not happening in VM. Tom Herbert suggested to use "vxlan: GRO support at tunnel layer" patch series. With today's net-next (4.2.0-rc7) in host and VM, I could see GRO happening

Re: [PATCH net-next 6/9] dsa: mv88e6xxx: Set the RGMII delay based on phy interface

2015-08-24 Thread Florian Fainelli
On 23/08/15 14:10, Andrew Lunn wrote: > On Sun, Aug 23, 2015 at 11:44:01AM -0700, Florian Fainelli wrote: >> Le 08/23/15 02:46, Andrew Lunn a écrit : >>> Some Marvell switches allow the RGMII Rx and Tx clock to be delayed >>> when the port is using RGMII. Have the adjust_link function look at >>> t

Re: [PATCH] usbnet: Fix two races between usbnet_stop() and the BH

2015-08-24 Thread Eugene Shatokhin
24.08.2015 16:29, Bjørn Mork пишет: Eugene Shatokhin writes: 19.08.2015 15:31, Bjørn Mork пишет: Eugene Shatokhin writes: The problem is not in the reordering but rather in the fact that "dev->flags = 0" is not necessarily atomic w.r.t. "clear_bit(EVENT_RX_KILL, &dev->flags)", and vice ver

[PATCH net-next v3 1/2] lwt: Add cfg argument to build_state

2015-08-24 Thread Tom Herbert
Add cfg and family arguments to lwt build state functions. cfg is a void pointer and will either be a pointer to a fib_config or fib6_config structure. The family parameter indicates which one (either AF_INET or AF_INET6). LWT encpasulation implementation may use the fib configuration to build the

[PATCH net-next v3 2/2] ila: Precompute checksum difference for translations

2015-08-24 Thread Tom Herbert
In the ILA build state for LWT compute the checksum difference to apply to transport checksums that include the IPv6 pseudo header. The difference is between the route destination (from fib6_config) and the locator to write. Signed-off-by: Tom Herbert --- net/ipv6/ila.c | 18 ++

[PATCH net-next v3 0/2] ila: Precompute checksums

2015-08-24 Thread Tom Herbert
This patch set: - Adds argument ot LWT build_state that holds a pointer to the fib configuration being applied to the new route - Adds support in ILA to precompute checksum difference for performance optimization v2: - Move return argument in build_state to end of arguments v3: - Update

Re: [PATCH net-next] vrf: rename the framework to mrf

2015-08-24 Thread Nicolas Dichtel
Le 22/08/2015 19:47, David Miller a écrit : From: Nicolas Dichtel Date: Sat, 22 Aug 2015 18:10:20 +0200 This patch renames the recently added vrf driver. 'VRF' term is very generic and there is no clear definition of it. For example, someone may expect more isolation and uses network namespace

Re: [PATCH net-next 9/9] phy: fixed_phy: Set phy capabilities even when link is down

2015-08-24 Thread Andrew Lunn
On Sun, Aug 23, 2015 at 11:40:07AM -0700, Florian Fainelli wrote: > Le 08/23/15 02:47, Andrew Lunn a écrit : > > What features a phy supports is masked in genphy_config_init() by > > looking at the PHYs BMSR register. > > > > If the link is down, fixed_phy_update_regs() will only set the auto- > >

Low throughput in VMs using VxLAN

2015-08-24 Thread Santosh R
Hi, Earlier I was seeing lower throughput in VMs using VxLan as GRO was not happening in VM. Tom Herbert suggested to use "vxlan: GRO support at tunnel layer" patch series. With today's net-next (4.2.0-rc7) in host and VM, I could see GRO happening for vxlan, macvtap and virtual interface in V

[no subject]

2015-08-24 Thread Koray Uçar
-- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[no subject]

2015-08-24 Thread Koray Uçar
subscribe netdev -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] man ip-link: Add little explanations about VLAN qos map

2015-08-24 Thread Vadim Kochan
From: Vadim Kochan Add little more info about how to manually set priority by iptables, and some little clarifications about ingress/egress QoS mapping. Signed-off-by: Vadim Kochan --- man/man8/ip-link.8.in | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) dif

[patch net-next 1/3] mlxsw: Remove duplicate included header

2015-08-24 Thread Jiri Pirko
From: Ido Schimmel Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko Signed-off-by: Elad Raz --- drivers/net/ethernet/mellanox/mlxsw/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c index 093

[patch net-next 3/3] mlxsw: adjust log messages level in __mlxsw_emad_transmit

2015-08-24 Thread Jiri Pirko
From: Jiri Pirko When transmit fails, it is an error, not a warning. Do not warn when timeout happens as that is handled by a counter. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel Signed-off-by: Elad Raz --- drivers/net/ethernet/mellanox/mlxsw/core.c | 8 1 file changed, 4

[patch net-next 0/3] mlxsw: small driver update

2015-08-24 Thread Jiri Pirko
From: Jiri Pirko Ido Schimmel (1): mlxsw: Remove duplicate included header Jiri Pirko (2): mlxsw: expose EMAD transactions statistics via debugfs mlxsw: adjust log messages level in __mlxsw_emad_transmit drivers/net/ethernet/mellanox/mlxsw/core.c | 60 ++ 1 fi

[patch net-next 2/3] mlxsw: expose EMAD transactions statistics via debugfs

2015-08-24 Thread Jiri Pirko
From: Jiri Pirko Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel Signed-off-by: Elad Raz --- drivers/net/ethernet/mellanox/mlxsw/core.c | 51 -- 1 file changed, 48 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drive

[PATCH] net-next: Fix warning while make xmldocs caused by skbuff.c

2015-08-24 Thread Masanari Iida
This patch fix following warnings. .//net/core/skbuff.c:407: warning: No description found for parameter 'len' .//net/core/skbuff.c:407: warning: Excess function parameter 'length' description in '__netdev_alloc_skb' .//net/core/skbuff.c:476: warning: No description found for parameter 'len' .//

Re: [linux-sunxi] Re: [PATCH] net: sun4i-emac: Claim emac sram

2015-08-24 Thread Maxime Ripard
On Mon, Aug 24, 2015 at 11:17:43AM +0200, Hans de Goede wrote: > Hi, > > On 24-08-15 09:46, Maxime Ripard wrote: > >Hi Hans, > > > >On Sun, Aug 23, 2015 at 08:31:38PM +0200, Hans de Goede wrote: > >>Claim the emac sram ourselves, rather then relying on the bootloader > >>having mapped the sram to

Re: [PATCH] usbnet: Fix two races between usbnet_stop() and the BH

2015-08-24 Thread Bjørn Mork
Eugene Shatokhin writes: > 19.08.2015 15:31, Bjørn Mork пишет: >> Eugene Shatokhin writes: >> >>> The problem is not in the reordering but rather in the fact that >>> "dev->flags = 0" is not necessarily atomic >>> w.r.t. "clear_bit(EVENT_RX_KILL, &dev->flags)", and vice versa. >>> >>> So the fol

  1   2   >