Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

2015-08-10 Thread yalin wang
HWM_REVERSE() macro is unused, remove it. Signed-off-by: yalin wang --- drivers/net/fddi/skfp/h/hwmtm.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/net/fddi/skfp/h/hwmtm.h b/drivers/net/fddi/skfp/h/hwmtm.h index 5924d42..4ca2341 100644 --- a/drivers/net/fddi/skfp/h/hwmtm.

[PATCH v2 net-next] bpf: s390: Fix build error caused by the struct bpf_array member name changed

2015-08-10 Thread Kaixu Xia
There is a build error that "'struct bpf_array' has no member named 'prog'" on s390. In commit 2a36f0b, the member 'prog' of struct bpf_array is replaced by 'ptrs'. So this patch fixes it. Signed-off-by: Kaixu Xia --- arch/s390/net/bpf_jit_comp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

Re: [PATCH net] netconsole: Check for carrier before calling netpoll_send_udp()

2015-08-10 Thread Jonathan Maxwell
> What if the carrier check passes, and then the chip reset starts on > another cpu? You'll have the same problem. Okay, let me see if I can come up with a better way to mitigate this. On Tue, Aug 11, 2015 at 2:22 PM, David Miller wrote: > From: Jon Maxwell > Date: Tue, 11 Aug 2015 11:32:26 +1

Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

2015-08-10 Thread yalin wang
> On Aug 11, 2015, at 13:37, David Miller wrote: > > From: yalin wang > Date: Tue, 11 Aug 2015 13:11:22 +0800 > >> HWM_REVERSE() macro is unused, remove it. >> >> Signed-off-by: yalin wang > > You did not do as I asked you to, this patch is still corrupted > and there is no way you successf

Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

2015-08-10 Thread David Miller
From: yalin wang Date: Tue, 11 Aug 2015 13:11:22 +0800 > HWM_REVERSE() macro is unused, remove it. > > Signed-off-by: yalin wang You did not do as I asked you to, this patch is still corrupted and there is no way you successfully applied what is in this patch. > -#defineHWM_REVERSE(x)

Re: VxLAN support question

2015-08-10 Thread Alexei Starovoitov
On 8/10/15 4:47 PM, Andrew Qu wrote: Pretty much what I want is that kernel will have about 1K interfaces (something like Tunnel100.1-tunnel100.1000 To be created and attached to 1K bridge domains on which each VNI is associated with given VNI to bridge-domain will be assigned using other CLI

Re: [PATCH net-next] bpf: fix the bug "'struct bpf_array' has no member named 'prog'" in s390 architecture

2015-08-10 Thread David Miller
From: Kaixu Xia Date: Tue, 11 Aug 2015 05:00:24 + > 'Kbuild test robot' sent me an email about a build error > "'struct bpf_array' has no member named 'prog'" in s390 > architecture. This error is caused by commit: 2a36f0b92eb > 638dd023870574eb471b1c56be9ad [656/692] bpf: Make the bpf > _pro

[PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro

2015-08-10 Thread yalin wang
HWM_REVERSE() macro is unused, remove it. Signed-off-by: yalin wang --- drivers/net/fddi/skfp/h/hwmtm.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/net/fddi/skfp/h/hwmtm.h b/drivers/net/fddi/skfp/h/hwmtm.h index 5924d42..4ca2341 100644 --- a/drivers/net/fddi/skfp/h/hwmtm

Re: [PATCH v2] net/fddi: remove HWM_REVERSE() macro

2015-08-10 Thread yalin wang
> On Aug 11, 2015, at 12:24, David Miller wrote: > > From: yalin wang > Date: Tue, 11 Aug 2015 09:57:21 +0800 > >> HWM_REVERSE() macro is unused, remove it. >> >> Signed-off-by: yalin wang > > Your email client has corrupted this patch. > > Please read Documentation/email-clients.txt, send

[PATCH net-next] bpf: fix the bug "'struct bpf_array' has no member named 'prog'" in s390 architecture

2015-08-10 Thread Kaixu Xia
'Kbuild test robot' sent me an email about a build error "'struct bpf_array' has no member named 'prog'" in s390 architecture. This error is caused by commit: 2a36f0b92eb 638dd023870574eb471b1c56be9ad [656/692] bpf: Make the bpf _prog_array_map more generic. In this patch, the member 'prog' of stru

Re: [RFC PATCH net] sctp: ASCONF-ACK with Unresolvable Address should be sent

2015-08-10 Thread lucien xin
On Mon, Jul 27, 2015 at 9:44 PM, Marcelo Ricardo Leitner wrote: > On Sat, Jul 25, 2015 at 01:08:08PM +0800, Xin Long wrote: >> RFC 5061: >> This is an opaque integer assigned by the sender to identify each >> request parameter. The receiver of the ASCONF Chunk will copy this >> 32-bit

Re: [PATCH v2] net/fddi: remove HWM_REVERSE() macro

2015-08-10 Thread David Miller
From: yalin wang Date: Tue, 11 Aug 2015 09:57:21 +0800 > HWM_REVERSE() macro is unused, remove it. > > Signed-off-by: yalin wang Your email client has corrupted this patch. Please read Documentation/email-clients.txt, send a test patch to yourself, and only resubmit this change once you are

Re: [PATCH net] netconsole: Check for carrier before calling netpoll_send_udp()

2015-08-10 Thread David Miller
From: Jon Maxwell Date: Tue, 11 Aug 2015 11:32:26 +1000 > We have seen a few crashes recently where a NIC is getting > reset for some reason and then the driver or another module calls > printk() which invokes netconsole. Netconsole then calls the > adapter specific poll routine via netpoll which

Re: [patch] hamradio/kiss: missing error code in mkiss_open()

2015-08-10 Thread David Miller
From: Dan Carpenter Date: Tue, 11 Aug 2015 00:39:22 +0300 > If register_netdev() fails we return success but we should return an > error code instead. > > Reported-by: RUC_Soft_Sec > Signed-off-by: Dan Carpenter I just applied another patch which fixes this earlier. -- To unsubscribe from thi

Re: [PATCH net] inet: fix races with reqsk timers

2015-08-10 Thread David Miller
From: Eric Dumazet Date: Mon, 10 Aug 2015 09:09:13 -0700 > From: Eric Dumazet > > reqsk_queue_destroy() and reqsk_queue_unlink() should use > del_timer_sync() instead of del_timer() before calling reqsk_put(), > otherwise we could free a req still used by another cpu. > > But before doing so,

Re: [PATCH net] inet: fix possible request socket leak

2015-08-10 Thread David Miller
From: Eric Dumazet Date: Mon, 10 Aug 2015 15:07:34 -0700 > From: Eric Dumazet > > In commit b357a364c57c9 ("inet: fix possible panic in > reqsk_queue_unlink()"), I missed fact that tcp_check_req() > can return the listener socket in one case, and that we must > release the request socket refcou

Re: [PATCH net-next] vxlan: fix fdb_dump index calculation

2015-08-10 Thread David Miller
From: Atzm Watanabe Date: Mon, 10 Aug 2015 23:39:09 +0900 > When too many remotes are bound to an FDB entry, index may not be increased. > This problem will be caused on the large scale environment that is based on > the unicast default destination, for instance. > > Signed-off-by: Atzm Watanabe

Re: [PATCH v2 bluetooth-next] cc2520: set the default fifo pin value from platform data

2015-08-10 Thread Marcel Holtmann
Hi Yong, > When the device tree support is disabled, the fifo_pin is uninitialized, > this patch will set the fifo_pin value based on platform data > > Signed-off-by: Yong Li > --- > drivers/net/ieee802154/cc2520.c | 1 + > 1 file changed, 1 insertion(+) patch has been applied to bluetooth-next

Re: [PATCH net-next] mellanox: mlxsw: Use '%zx' to print size_t format

2015-08-10 Thread David Miller
From: Fabio Estevam Date: Mon, 10 Aug 2015 09:54:28 -0300 > Use '%zx' to print size_t format in order to fix the following build warning: > > drivers/net/ethernet/mellanox/mlxsw/item.h:65:3: warning: format '%lx' > expects argument of type 'long unsigned int', but argument 6 has type > 'size_t

Re: [PATCH] net: eth: altera: Remove sgdmadesclen member from altera_tse_private

2015-08-10 Thread David Miller
From: Tobias Klauser Date: Mon, 10 Aug 2015 12:26:32 +0200 > altera_tse_private->sgdmadesclen is always assigned assigned the same > value and never changes during runtime. Remove the struct member and > use a new define for sizeof(struct sgdma_descrip) instead. > > Signed-off-by: Tobias Klause

Re: [PATCH] mkiss: Fix error handling in mkiss_open()

2015-08-10 Thread David Miller
From: Fabio Estevam Date: Mon, 10 Aug 2015 14:22:43 -0300 > If register_netdev() fails we are not propagating the error and > we return success because ax_open() succeeded previously. > > Fix this by checking the return value of ax_open() and > register_netdev() and propagate the error in case

Re: [PATCH 0/5] Netfilter fixes for net

2015-08-10 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 10 Aug 2015 19:58:34 +0200 > The following patchset contains five Netfilter fixes for your net tree, > they are: > > 1) Silence a warning on falling back to vmalloc(). Since 88eab472ec21, we can >easily hit this warning message, that gets users confused. So

Re: [PATCH] net: Unbreak resetting default values for tcp_wmem/udp_wmem_min

2015-08-10 Thread David Miller
From: Calvin Owens Date: Mon, 10 Aug 2015 20:34:06 -0700 > I'm really questioning the limitation itself: why enforce a minimum of > SOCK_MIN_SNDBUF here? Why not SK_MEM_QUANTUM? > > Commit 8133534c760d4083 referred to b1cb59cf2efe7971, which choose to > use the SOCK_MIN constants as the lower li

Re: [PATCH] net: Unbreak resetting default values for tcp_wmem/udp_wmem_min

2015-08-10 Thread Calvin Owens
On Sunday 08/09 at 22:41 -0700, David Miller wrote: > From: Calvin Owens > Date: Wed, 5 Aug 2015 13:26:54 -0700 > > > Commit 8133534c760d4083 ("net: limit tcp/udp rmem/wmem to > > SOCK_{RCV,SND}BUF_MIN") modified four sysctls to enforce that the values > > written to them are not less than SOCK_M

Re: [PATCH v2 bluetooth-next] cc2520: set the default fifo pin value from platform data

2015-08-10 Thread Varka Bhadram
On 08/11/2015 08:13 AM, sdliy...@gmail.com wrote: From: Yong Li When the device tree support is disabled, the fifo_pin is uninitialized, this patch will set the fifo_pin value based on platform data Signed-off-by: Yong Li Acked-by: Varka Bhadram --- drivers/net/ieee802154/cc2520.c | 1

[PATCH v2 bluetooth-next] cc2520: set the default fifo pin value from platform data

2015-08-10 Thread sdliyong
From: Yong Li When the device tree support is disabled, the fifo_pin is uninitialized, this patch will set the fifo_pin value based on platform data Signed-off-by: Yong Li --- drivers/net/ieee802154/cc2520.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ieee802154/cc2520.c b/

[RFC V2] bmac:change to use bitrev8() generic function

2015-08-10 Thread yalin wang
This change to use generic bitrev8() for bmac driver. Signed-off-by: yalin wang --- drivers/net/ethernet/apple/bmac.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/apple/bmac.c b/drivers/net/ethernet/apple/bmac.c index a65d7a6..7f7a3

RE: [PATCH] igb: Fix a memory leak in igb_probe

2015-08-10 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Jia-Ju Bai > Sent: Wednesday, August 05, 2015 7:05 AM > To: Kirsher, Jeffrey T; Brandeburg, Jesse > Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Jia-Ju Bai > S

RE: [Intel-wired-lan] [PATCH 1/2] igb: Teardown SR-IOV before unregister_netdev()

2015-08-10 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Alex Williamson > Sent: Monday, July 27, 2015 4:19 PM > To: intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH 1/

RE: [PATCH] igb: Fix a deadlock in igb_sriov_reinit

2015-08-10 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Jia-Ju Bai > Sent: Sunday, August 02, 2015 8:36 PM > To: Kirsher, Jeffrey T; Brandeburg, Jesse > Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Jia-Ju Bai > Subj

Re: [RFC] bmac:change to use bitrev8() generic function

2015-08-10 Thread yalin wang
> On Aug 10, 2015, at 20:02, David Laight wrote: > >> From: Tobias Klauser >> Sent: 10 August 2015 12:49 >> On 2015-08-10 at 11:53:41 +0200, yalin wang wrote: >>> This change to use generic bitrev8() for bmac driver. > ... >>> @@ -871,7 +860,7 @@ bmac_addhash(struct bmac_data *bp, unsigned char

[PATCH v2] net/fddi: remove HWM_REVERSE() macro

2015-08-10 Thread yalin wang
HWM_REVERSE() macro is unused, remove it. Signed-off-by: yalin wang --- drivers/net/fddi/skfp/h/hwmtm.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/net/fddi/skfp/h/hwmtm.h b/drivers/net/fddi/skfp/h/hwmtm.h index 5924d42..4ca2341 100644 --- a/drivers/net/fddi/skfp/h/hw

Re: [PATCH] net/fddi:change HWM_REVERSE() macro

2015-08-10 Thread yalin wang
> On Aug 11, 2015, at 00:36, Joe Perches wrote: > > On Tue, 2015-08-11 at 00:14 +0800, yalin wang wrote: >> HWM_REVERSE > > Is unused and it would be better if removed. > ok, i will send V2 patch . -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message t

Re: [PATCH] isdn:remove reverse_bits(), use revbit8()

2015-08-10 Thread yalin wang
> On Aug 11, 2015, at 05:30, David Miller wrote: > > From: yalin wang > Date: Mon, 10 Aug 2015 17:15:57 +0800 > >> This change isdn driver, remove reverse_bits() function, >> use the generic revbit8() function instead. >> >> Signed-off-by: yalin wang > > Applied, however please format your

[PATCH net] netconsole: Check for carrier before calling netpoll_send_udp()

2015-08-10 Thread Jon Maxwell
We have seen a few crashes recently where a NIC is getting reset for some reason and then the driver or another module calls printk() which invokes netconsole. Netconsole then calls the adapter specific poll routine via netpoll which crashes because the adapter is resetting and its structures are

[PATCH v2 0/2] net: thunder: Add ACPI support.

2015-08-10 Thread David Daney
From: David Daney Change from v1: Drop PHY binding part, use fwnode_property* APIs. The first patch (1/2) rearranges the existing code a little with no functional change to get ready for the second. The second (2/2) does the actual work of adding support to extract the needed information from

[PATCH v2 2/2] net, thunder, bgx: Add support to get MAC address from ACPI.

2015-08-10 Thread David Daney
From: David Daney Currently there is no way to get the MAC address in a firmware independent manner, so set the MAC address of the device directly from the ACPI tables. The binding agrees with the proposed standard here: http://www.uefi.org/sites/default/files/resources/nic-request-v2.pdf Base

[PATCH v2 1/2] net: thunder: Factor out DT specific code in BGX

2015-08-10 Thread David Daney
From: Robert Richter Separate DT code in preparation for follow-on ACPI integration. Based on code from: Tomasz Nowicki Signed-off-by: Robert Richter Signed-off-by: David Daney --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 48 +-- 1 file changed, 35 insertions(

Re: [patch] hamradio/kiss: missing error code in mkiss_open()

2015-08-10 Thread Fabio Estevam
On Mon, Aug 10, 2015 at 6:39 PM, Dan Carpenter wrote: > If register_netdev() fails we return success but we should return an > error code instead. > > Reported-by: RUC_Soft_Sec > Signed-off-by: Dan Carpenter I have also sent a similar one: https://patchwork.ozlabs.org/patch/505758/ -- To unsubs

VxLAN support question

2015-08-10 Thread Andrew Qu
Hi VxLAN experts, In user space, we are developing a CLI as the following: Interface tunnel 100 Mode vxlan Remote ip ipv4 19.1.1.1 Local ip ipv4 20.1.1.1 Vni 1-1000 < With Kernel 3.12.37, we can't support above configurations in kernel. (OR PLEASE Correct me if I am wrong)

[PATCH] xfrm: Add oif to dst lookups

2015-08-10 Thread David Ahern
Rules can be installed that direct route lookups to specific tables based on oif. Plumb the oif through the xfrm lookups so it gets set in the flow struct and passed to the resolver routines. Signed-off-by: David Ahern --- include/net/xfrm.h | 7 +-- net/ipv4/xfrm4_policy.c | 11 ++

[PATCH] rt2x00: adjust EEPROM_SIZE for rt2500usb

2015-08-10 Thread Adrien Schildknecht
rt2500usb_validate_eeprom() read data up to 0x6e (EEPROM_CALIBRATE_OFFSET) but only 0x6a bytes has been allocated and read from the eeprom. This lead to out-of-bound accesses and invalid values for EEPROM_BBPTUNE_R17 and EEPROM_CALIBRATE_OFFSET. Change the EEPROM_SIZE to 0x6e in order to retrieve

[PATCH net] inet: fix possible request socket leak

2015-08-10 Thread Eric Dumazet
From: Eric Dumazet In commit b357a364c57c9 ("inet: fix possible panic in reqsk_queue_unlink()"), I missed fact that tcp_check_req() can return the listener socket in one case, and that we must release the request socket refcount or we leak it. Tested: Following packetdrill test template shows

ipv6_mc_check_mld - kernel BUG at net/core/skbuff.c:1128

2015-08-10 Thread Brenden Blanco
Hi folks, Here is a crash that I am able to easily reproduce. The setup is: 2 VMs, running in libvirt (qemu-kvm) CPU mode is host-passthrough, virtio drivers used wherever available Disable ipv6 (just to limit the amount of multicast noise) Set up a multicast vxlan tunnel between the two VMs Atta

Re: kernel warning in tcp_fragment

2015-08-10 Thread Jovi Zhangwei
Hi Neal, Great thanks for your reply, we will arrange testing against that patch. On Mon, Aug 10, 2015 at 11:35 AM, Neal Cardwell wrote: > On Mon, Aug 10, 2015 at 2:10 PM, Jovi Zhangwei wrote: >> >> Ping? >> >> We saw a lot of this warnings in our production system. It would be >> great appreci

[patch] hamradio/kiss: missing error code in mkiss_open()

2015-08-10 Thread Dan Carpenter
If register_netdev() fails we return success but we should return an error code instead. Reported-by: RUC_Soft_Sec Signed-off-by: Dan Carpenter diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index 2ffbf13..dcb6bb7 100644 --- a/drivers/net/hamradio/mkiss.c +++ b/drivers

Re: [PATCH net 0/2] bnx2x: small fixes

2015-08-10 Thread David Miller
From: Yuval Mintz Date: Mon, 10 Aug 2015 12:49:34 +0300 > This adds 2 small fixes, one to error flows during memory release > and the other to flash writes via ethtool API. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to ma

Re: [PATCH] isdn:remove reverse_bits(), use revbit8()

2015-08-10 Thread David Miller
From: yalin wang Date: Mon, 10 Aug 2015 17:15:57 +0800 > This change isdn driver, remove reverse_bits() function, > use the generic revbit8() function instead. > > Signed-off-by: yalin wang Applied, however please format your Subject lines better in the future. There should be a space after t

Re: [patch 1/2 -mainline] cxgb4: missing curly braces in t4_setup_debugfs()

2015-08-10 Thread David Miller
From: Dan Carpenter Date: Sat, 8 Aug 2015 22:15:25 +0300 > There were missing curly braces so it means we call add_debugfs_mem() > unintentionally. > > Fixes: 3ccc6cf74d8c ('cxgb4: Adds support for T6 adapter') > Signed-off-by: Dan Carpenter Applied to 'net'. -- To unsubscribe from this list:

Re: [patch 2/2] cxgb4: cleanup some indenting

2015-08-10 Thread David Miller
From: Dan Carpenter Date: Sat, 8 Aug 2015 22:15:59 +0300 > Add or remove some tabs so that statements line up correctly. > > Signed-off-by: Dan Carpenter Applied to 'net-next', thanks Dan. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord..

Re: [RFC PATCH net-next] tcp: reduce cpu usage under tcp memory pressure when SO_SNDBUF is set

2015-08-10 Thread Eric Dumazet
On Mon, 2015-08-10 at 13:29 -0400, Jason Baron wrote: > > + > > > > > > > > > > thanks. better? > > --- a/include/net/sock.h > +++ b/include/net/sock.h > @@ -798,8 +798,10 @@ static inline int sk_stream_min_wspace(const struct > sock *sk) > > static inline int sk_stream_wspace(const struct

Re: [PATCH net-next] dsa: Support multiple MDIO busses

2015-08-10 Thread David Miller
From: Andrew Lunn Date: Sat, 8 Aug 2015 17:09:14 +0200 > When using a cluster of switches, some topologies will have an MDIO > bus per switch, not one for the whole cluster. Allow this to be > represented in the device tree, by adding an optional mii-bus property > at the switch level. The old p

Re: [PATCH net-next] net: dsa: mv88e6352: Use mnemonics for EEPROM registers and bits

2015-08-10 Thread David Miller
From: Andrew Lunn Date: Sat, 8 Aug 2015 17:04:50 +0200 > Add register definitions #defines for accessing the EEPROM. > > Signed-off-by: Andrew Lunn Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] eventfd: implementation of EFD_MASK flag

2015-08-10 Thread Martin Sustrik
On 2015-08-10 10:57, Damian Hobson-Garcia wrote: Hi Martin, Thanks for your comments. On 2015-08-10 3:39 PM, Martin Sustrik wrote: On 2015-08-10 08:23, Damian Hobson-Garcia wrote: Replying to my own post, but I had the following comments/questions. Martin, if you have any response to my comme

Re: [RFC PATCH 1/4] vhost: Introduce a universal thread to serve all users

2015-08-10 Thread Bandan Das
Bandan Das writes: > "Michael S. Tsirkin" writes: > >> On Mon, Jul 13, 2015 at 12:07:32AM -0400, Bandan Das wrote: >>> vhost threads are per-device, but in most cases a single thread >>> is enough. This change creates a single thread that is used to >>> serve all guests. >>> >>> However, this c

Re: [PATCH net-next v5 0/4] GRE: Use flow based tunneling for OVS GRE vport.

2015-08-10 Thread David Miller
From: Pravin B Shelar Date: Fri, 7 Aug 2015 23:49:50 -0700 > Following patches make use of new Using GRE tunnel meta data > collection feature. This allows us to directly use netdev > based GRE tunnel implementation. While doing so I have > removed GRE demux API which were targeted for OVS. Most

Re: [PATCH net-next] net: add explicit logging and stat for neighbour table overflow

2015-08-10 Thread David Miller
From: r...@tardy.usa.hp.com (Rick Jones) Date: Fri, 7 Aug 2015 11:10:37 -0700 (PDT) > From: Rick Jones > > Add an explicit neighbour table overflow message (ratelimited) and > statistic to make diagnosing neighbour table overflows tractable in > the wild. > > Diagnosing a neighbour table overf

Re: [PATCH] net-timestamp: Update skb_complete_tx_timestamp comment

2015-08-10 Thread David Miller
From: Benjamin Poirier Date: Fri, 7 Aug 2015 09:32:21 -0700 > After "62bccb8 net-timestamp: Make the clone operation stand-alone from phy > timestamping" the hwtstamps parameter of skb_complete_tx_timestamp() may no > longer be NULL. > > Signed-off-by: Benjamin Poirier > Cc: Alexander Duyck

Re: [PATCHv2 net-next 5/9] openvswitch: Add conntrack action

2015-08-10 Thread Joe Stringer
On 6 August 2015 at 14:36, Pravin Shelar wrote: +static void ovs_fragment(struct vport *vport, struct sk_buff *skb, +unsigned int mru, __be16 ethertype) +{ + if (skb_network_offset(skb) > MAX_L2_LEN) { + OVS_NLERR(1, "L2 header t

Re: [PATCH net-next v2] bridge: netlink: add support for vlan_filtering attribute

2015-08-10 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 7 Aug 2015 19:40:45 +0300 > From: Nikolay Aleksandrov > > This patch adds the ability to toggle the vlan filtering support via > netlink. Since we're already running with rtnl in .changelink() we don't > need to take any additional locks. > > Signed-off-by

Re: [PATCH net-next 0/6] qlcnic: enhancements

2015-08-10 Thread David Miller
From: Shahed Shaikh Date: Fri, 7 Aug 2015 07:17:01 -0400 > This series adds few enhancements. > > o Patch from Harish reorders the sequence of header files inclusion, > keeping kernel's header files on top. > > o Firmware introduced a new feature which allows driver to increases > t

Re: [PATCH] net: phy: select copper mode when Marvel 88e1111 in SGMII

2015-08-10 Thread David Miller
From: Date: Fri, 7 Aug 2015 17:07:50 +0800 > From: Madalin Bucur > > For the Marvel 88e PHY only two SGMII modes are available, both > allowing only SGMII to copper mode (with or without clock). SGMII > to fiber mode is not supported. Make sure the fiber/copper registers > selector bits are

Re: [PATCH net] ipv6: don't reject link-local nexthop on other interface

2015-08-10 Thread David Miller
From: Florian Westphal Date: Fri, 7 Aug 2015 10:54:28 +0200 > 48ed7b26faa7 ("ipv6: reject locally assigned nexthop addresses") is too > strict; it rejects following corner-case: > > ip -6 route add default via fe80::1:2:3 dev eth1 > > [ where fe80::1:2:3 is assigned to a local interface, but n

Re: [PATCH net-next] net: fec: fix the race between xmit and bdp reclaiming path

2015-08-10 Thread David Miller
From: Kevin Hao Date: Fri, 7 Aug 2015 13:52:37 +0800 > When we transmit a fragmented skb, we may run into a race like the > following scenario (assume txq->cur_tx is next to txq->dirty_tx): >cpu 0 cpu 1 > fec_enet_txq_submit_skb > reserv

[PATCH 0/3] gianfar: filer changes

2015-08-10 Thread Jakub Kicinski
From: Jakub Kicinski Hi, I've been working with the gianfar filer code recently and got some code to offer. Well, maybe not that much code to offer actually: two small fixes and removal of the current optimizer. I'm not sure what your feelings on patch 3 will be. It would be great to have a wo

[PATCH 1/3] gianfar: correct filer table writing

2015-08-10 Thread Jakub Kicinski
From: Jakub Kicinski MAX_FILER_IDX is the last usable index. Using less-than will already guarantee that one entry for catch-all rule will be left, no need to subtract 1 here. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 5 ++--- 1 file changed, 2 inser

[PATCH 3/3] gianfar: remove faulty filer optimizer

2015-08-10 Thread Jakub Kicinski
From: Jakub Kicinski Current filer rule optimization is broken in several ways: (1) It destroys rule ordering. (2) It performs reads/writes beyond end of allocated tables. (3) It breaks badly for rules with more than 2 specifiers (e.g. matching ip, port, tos). (4) We observed that the ma

[PATCH 2/3] gianfar: correct list membership accounting

2015-08-10 Thread Jakub Kicinski
From: Jakub Kicinski At a cost of one line let's make sure .count is correct when calling gfar_process_filer_changes(). Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/

Re: [RFC PATCH 1/4] vhost: Introduce a universal thread to serve all users

2015-08-10 Thread Bandan Das
"Michael S. Tsirkin" writes: > On Mon, Jul 13, 2015 at 12:07:32AM -0400, Bandan Das wrote: >> vhost threads are per-device, but in most cases a single thread >> is enough. This change creates a single thread that is used to >> serve all guests. >> >> However, this complicates cgroups association

Re: [RFC PATCH 0/4] Shared vhost design

2015-08-10 Thread Bandan Das
"Michael S. Tsirkin" writes: > On Sat, Aug 08, 2015 at 07:06:38PM -0400, Bandan Das wrote: >> Hi Michael, ... >> >> > - does the design address the issue of VM 1 being blocked >> > (e.g. because it hits swap) and blocking VM 2? >> Good question. I haven't thought of this yet. But IIUC, >> the w

RE: [v4, 0/9] Freescale DPAA FMan

2015-08-10 Thread Liberman Igal
Hello David, Thank you for your feedback. I understand your concerns regarding the FMan driver, we've come a long way from where we started but still there are issues. The community support is critical for getting the code to the desired quality level and I appreciate the support I receive from

Re: [PATCH] r8169: Filtered data on Rx descriptor status context

2015-08-10 Thread Francois Romieu
Marian Corcodel : > This is specified on data sheet only when LS is set must evaluate > RES bit very important patch.Whi say no here not undestand .Please > read Data sheet for more info. Your patch ignores the following fact: the driver works with maximally sized receive buffers to avoid fra

[PATCH 02/10] ss: created formatters for json and hr

2015-08-10 Thread Matthias Tafelmeier
This patch creates a central formatter module that acts as a kind of switch. From there, more specific handler modules for the certain output formats are called. Up to now, humand readable and json do exist. That prepares ss for potential output format extensions in the future. With the help of su

[PATCH 05/10] ss: framed skeleton for json output in ss

2015-08-10 Thread Matthias Tafelmeier
This patch just adds the --json flag to ss. Also it ensures proper stats components bracketization – that goes for ex. TCP, UDP, NETLINK etc. Moreover, this patch prevents human readable headers to be printed. The first element flag ensures, that every first output json container element is treate

[PATCH 01/10] ss: rooted out ss type declarations for output formatters

2015-08-10 Thread Matthias Tafelmeier
The prospected output formatters and ss do share type declarations like slabstat or tcpstat so that the decision has been made to centralize those declarations in ss_types.h. Potential future declarations shall be placed there. The latter should help amend the extent of ss.c as well. Signed-off-b

[PATCH 10/10] ss: fixed free on local array for valid json output

2015-08-10 Thread Matthias Tafelmeier
Minor fix to enable json output. Freeing of automatic char array name which will get freed after function stack cleanup. Another one after tcp_stats_fmt for freeing automatic tcpstats struct instance. Signed-off-by: Matthias Tafelmeier Suggested-by: Hagen Paul Pfeifer --- misc/ss.c | 6 --

[PATCH 08/10] ss: symmetrical subhandler output extension example

2015-08-10 Thread Matthias Tafelmeier
This small sized patch shall convey the locations which have to be changed for a symmetrical output extension. Symmetrical means in this context all existing semantically related handlers in the diverse formatters (for hr and json up to now). Signed-off-by: Matthias Tafelmeier Suggested-by: Hagen

[PATCH 04/10] ss: prepare timer for output handler usage

2015-08-10 Thread Matthias Tafelmeier
Minor preparation Patch Renamed, and exported timer to not have to pass it as a function local parameter argument. Signed-off-by: Matthias Tafelmeier Suggested-by: Hagen Paul Pfeifer --- misc/ss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index e

[PATCH 07/10] ss: renaming and export of current_filter

2015-08-10 Thread Matthias Tafelmeier
Exported current_filter as ss_current_filter, because in the fmt handlers, I need that piece of info to resolve out issues of json. Signed-off-by: Matthias Tafelmeier Suggested-by: Hagen Paul Pfeifer --- misc/ss.c | 218 +++--- 1 file chan

[PATCH 06/10] ss: replaced old output mechanisms with fmt handlers interfaces

2015-08-10 Thread Matthias Tafelmeier
Now, since the fmt (json, hr) handlers are in place, all can be output via these newly deviced code parts. Signed-off-by: Matthias Tafelmeier Suggested-by: Hagen Paul Pfeifer --- misc/ss.c | 330 +- 1 file changed, 152 insertions(+), 1

[PATCH 09/10] ss: symmetrical formatter extension example

2015-08-10 Thread Matthias Tafelmeier
This commit shall show shortly where to place changes when one wants to extend an ss output formatter with a new handler (format print procedure). The extension is done symmetrically. That means, every up to now existing formatter is extended with a semantically equivalent handler (hr and json form

V2 iproute2: full ss json support and general output simplification

2015-08-10 Thread Matthias Tafelmeier
TLDR: - add full JSON support for ss - Patchset provides a general and easy to use abstraction to extend ss later - Patchset size is large to minimize daily use ("user" should not deal with formation (json, human readble) later on) - Patches 8/10 and 9/10 illustrate how to extend ss for ne

[PATCH 03/10] ss: removed obsolet fmt functions

2015-08-10 Thread Matthias Tafelmeier
Those functions are obsoleted since the new fmt handler mechanism subsumes their tasks. Rendundancy would be contradictory to the new mechanism. Signed-off-by: Matthias Tafelmeier Suggested-by: Hagen Paul Pfeifer --- misc/ss.c | 190 --

Re: [PATCH net-next 1/2] net: track link status of ipv6 nexthops

2015-08-10 Thread Andy Gospodarek
On Mon, Aug 10, 2015 at 10:54:00AM -0700, David Miller wrote: > From: Andy Gospodarek > Date: Thu, 6 Aug 2015 11:42:33 -0400 > > > Add support to track current link status of ipv6 nexthops to match > > recent changes that added support for ipv4 nexthops. There was not a > > field already availa

Re: kernel warning in tcp_fragment

2015-08-10 Thread Neal Cardwell
On Mon, Aug 10, 2015 at 2:10 PM, Jovi Zhangwei wrote: > > Ping? > > We saw a lot of this warnings in our production system. It would be > great appreciate if someone can give us the fix on this warnings. :) What is your net.ipv4.tcp_mtu_probing setting? If 1, have you tried setting it to 0? Previ

Re: [iproute PATCH] misc/ss: don't imply -a when -A was specified

2015-08-10 Thread Stephen Hemminger
On Fri, 7 Aug 2015 15:31:27 +0200 Phil Sutter wrote: > Signed-off-by: Phil Sutter Ok, applied -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] openvswitch: Fix L4 checksum handling when dealing with IP fragments

2015-08-10 Thread David Miller
From: Glenn Griffin Date: Mon, 10 Aug 2015 10:43:16 -0700 > On Mon, Aug 03, 2015 at 02:03:28PM -0700, David Miller wrote: >> From: Glenn Griffin >> Date: Mon, 3 Aug 2015 09:56:54 -0700 >> >> > openvswitch modifies the L4 checksum of a packet when modifying >> > the ip address. When an IP packet

Re: [PATCH iproute2 net-next] iplink: bonding: add support for IFLA_BOND_TLB_DYNAMIC_LB

2015-08-10 Thread Stephen Hemminger
On Mon, 3 Aug 2015 12:19:55 +0200 Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > Add support to be able to set and show the value of tlb_dynamic_lb > (IFLA_BOND_TLB_DYNAMIC_LB). > Example: > $ ip -d link show dev bond0 type bond > 7: bond0: mtu 1500 qdisc noop state DOWN > mode DE

Re: [PATCH 08/10] ss: symmetrical subhandler output extension example

2015-08-10 Thread Sergei Shtylyov
On 08/10/2015 05:53 PM, Eric Dumazet wrote: {} not needed. I guess you haven't run your patches thru scripts/checkpatch.pl? Yes, although this is missing from iproute2 sources ;) Oh, sorry, somehow I thought it's a kernel patch. :-) MBR, Sergei -- To unsubscribe from this list: se

Re: [PATCH iproute2 -next] m_bpf: add frontend support for late binding

2015-08-10 Thread Stephen Hemminger
On Fri, 7 Aug 2015 11:36:50 +0200 Daniel Borkmann wrote: > Frontend support for kernel commit a5c90b29e5cc ("act_bpf: properly > support late binding of bpf action to a classifier"). > > Signed-off-by: Daniel Borkmann Applied to net-next -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH iproute2] tipc: fix bearer get/set help synopsis

2015-08-10 Thread Stephen Hemminger
On Fri, 7 Aug 2015 09:55:09 +0200 wrote: > From: Richard Alpe > > One option is required for bearer set and bearer get. Applied, thanks -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vge

Re: kernel warning in tcp_fragment

2015-08-10 Thread Jovi Zhangwei
Ping? We saw a lot of this warnings in our production system. It would be great appreciate if someone can give us the fix on this warnings. :) On Fri, Jul 31, 2015 at 11:04 AM, Jovi Zhangwei wrote: > Hi Eric, > > Would you like share your thought on this bug? great thanks. > > > On Mon, Jul 27,

Re: [PATCH net] netlink: make sure -EBUSY won't escape from netlink_insert

2015-08-10 Thread David Miller
From: Daniel Borkmann Date: Fri, 7 Aug 2015 00:26:41 +0200 > Linus reports the following deadlock on rtnl_mutex; triggered only > once so far (extract): ... > It seems so far plausible that the recursive call into rtnetlink_rcv() > looks suspicious. One way, where this could trigger is that the

Re: [PATCH net] bna: fix interrupts storm caused by erroneous packets

2015-08-10 Thread David Miller
From: Ivan Vecera Date: Thu, 6 Aug 2015 22:48:23 +0200 > The commit "e29aa33 bna: Enable Multi Buffer RX" moved packets counter > increment from the beginning of the NAPI processing loop after the check > for erroneous packets so they are never accounted. This counter is used > to inform firmwar

Re: [PATCH 0/3] Fixes for the network driver of Marvell Armada 375 SoC

2015-08-10 Thread David Miller
From: Marcin Wojtas Date: Thu, 6 Aug 2015 19:00:27 +0200 > This is a set of three patches that fix long-lasting problems implemented in > the initial support for the Armada 375 network controller. > > Due to an inappropriate concept of handling the per-CPU sent packets' > processing on TX path

[PATCH] mkiss: Fix error handling in mkiss_open()

2015-08-10 Thread Fabio Estevam
If register_netdev() fails we are not propagating the error and we return success because ax_open() succeeded previously. Fix this by checking the return value of ax_open() and register_netdev() and propagate the error in case of failure. Reported-by: RUC_Soft_Sec Signed-off-by: Fabio Estevam

[PATCH 5/5] netfilter: SYNPROXY: fix sending window update to client

2015-08-10 Thread Pablo Neira Ayuso
From: Phil Sutter Upon receipt of SYNACK from the server, ipt_SYNPROXY first sends back an ACK to finish the server handshake, then calls nf_ct_seqadj_init() to initiate sequence number adjustment of forwarded packets to the client and finally sends a window update to the client to unblock it's T

[PATCH 2/5] netfilter: nf_conntrack: checking for IS_ERR() instead of NULL

2015-08-10 Thread Pablo Neira Ayuso
From: Dan Carpenter We recently changed this from nf_conntrack_alloc() to nf_ct_tmpl_alloc() so the error handling needs to changed to check for NULL instead of IS_ERR(). Fixes: 0838aa7fcfcd ('netfilter: fix netns dependencies with conntrack templates') Signed-off-by: Dan Carpenter Signed-off-

Re: [PATCH net-next 1/2] net: track link status of ipv6 nexthops

2015-08-10 Thread David Miller
From: Andy Gospodarek Date: Thu, 6 Aug 2015 11:42:33 -0400 > Add support to track current link status of ipv6 nexthops to match > recent changes that added support for ipv4 nexthops. There was not a > field already available that could track these and no space available in > the existing rt6i_f

[PATCH 3/5] netfilter: conntrack: Use flags in nf_ct_tmpl_alloc()

2015-08-10 Thread Pablo Neira Ayuso
From: Joe Stringer The flags were ignored for this function when it was introduced. Also fix the style problem in kzalloc. Fixes: 0838aa7fc (netfilter: fix netns dependencies with conntrack templates) Signed-off-by: Joe Stringer Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_conntrack_

  1   2   >