Re: [RFC PATCH 0/2] net: macb: Add mdio driver for accessing multiple phy devices

2015-08-02 Thread Michal Simek
Hi, On 07/31/2015 11:53 PM, Nathan Sullivan wrote: > On Tue, Jul 28, 2015 at 03:34:51AM +, Punnaiah Choudary Kalluri wrote: >> Ok. I will send you updated patch for mdio support soon and we will finalize >> next >> Course of actions if it doesn't break the existing flow. >> >> Thanks, >> Pun

Re: [PATCH net-next] ebpf: add skb->hash to offset map for usage in {cls,act}_bpf or filters

2015-08-02 Thread Alexei Starovoitov
On 8/2/15 6:09 PM, Tom Herbert wrote: I was thinking whether to add skb_get_hash(), but then concluded the >raw skb->hash seems fine in this case: we can directly access the hash >w/o extra eBPF helper function call, it's filled out by many NICs on >ingress, and in case the entropy level would no

[PATCH] fddi: Use a more more typical logging style

2015-08-02 Thread Joe Perches
Use macros that don't require fixed argument counts so format and arguments can be verified by the compiler. Miscellanea: o Remove a few #if uses to allow dynamic debug to always work o whitespace neatening Signed-off-by: Joe Perches --- drivers/net/fddi/skfp/cfm.c| 16 +++ drivers

[PATCH] igb: Fix a deadlock in igb_sriov_reinit

2015-08-02 Thread Jia-Ju Bai
When igb_init_interrupt_scheme in igb_sriov_reinit is failed, the lock acquired by rtnl_lock() is not released, which causes a deadlock. This patch adds rtnl_unlock() in error handling to fix it. Signed-off-by: Jia-Ju Bai --- drivers/net/ethernet/intel/igb/igb_main.c |1 + 1 file changed, 1

[PATCH] 3c59x: Fix resource leaks in vortex_open

2015-08-02 Thread Jia-Ju Bai
When vortex_up is failed, the skb buffers allocated by __netdev_alloc_skb in vortex_open are not released, which may cause resource leaks. This bug has been submitted before. This patch modifies the error handling code to fix it. Signed-off-by: Jia-Ju Bai --- drivers/net/ethernet/3com/3c59x.c |

[PATCH] e100: Release skb when DMA mapping is failed in e100_xmit_prepare

2015-08-02 Thread Jia-Ju Bai
When pci_dma_mapping_error in e100_xmit_prepare is failed, the skb buffer allocated by netdev_alloc_skb_ip_align in e100_rx_alloc_skb is not released, which causes a possible resource leak. This patch adds error handling code to fix it. Signed-off-by: Jia-Ju Bai --- drivers/net/ethernet/intel/e1

Re: Kernel Oops in __inet_twsk_kill()

2015-08-02 Thread charley
Phani yahoo.com> writes: > > > > > > > The problem has been fixed. It is introduced by a third party patch, > > > which decreases the refcnt of timewait socket. > > > > What is the fix? > pl share the gerrit. > > Here you go. https://android.googlesource.com/kernel/common/+/android- 3.14/

[PATCH] e100: Add a check after pci_pool_create to avoid null pointer dereference

2015-08-02 Thread Jia-Ju Bai
The driver lacks the check of nic->cbs_pool after pci_pool_create in e100_probe. When this function is failed, a null pointer dereference occurs when pci_pool_alloc uses nic->cbs_pool in e100_alloc_cbs. This patch adds a check and related error handling code to fix it. Signed-off-by: Jia-Ju Bai

[PATCH] net: dsa: fix EDSA frame from hwaccel frame

2015-08-02 Thread Vivien Didelot
If the underlying network device features NETIF_F_HW_VLAN_CTAG_TX, an EDSA frame is prepended with a 802.1q header once queued. To fix this, push the VLAN tag to the payload if present, before checking the frame protocol. [note: we may prefer to access directly VLAN TCI from hwaccel frames, but t

[PATCH]Fix a null dereference in e1000_open

2015-08-02 Thread Jia-Ju Bai
When e1000e_setup_rx_resources is failed in e1000_open, e1000e_free_tx_resources in "err_setup_rx" segment is executed. "writel(0, tx_ring->head)" statement in e1000_clean_tx_ring in e1000e_free_tx_resources will cause a null dereference(crash), because "tx_ring->head" is only assigned in e1000_co

Re: [PATCH net-next] ebpf: add skb->hash to offset map for usage in {cls,act}_bpf or filters

2015-08-02 Thread Tom Herbert
On Fri, Jul 31, 2015 at 3:46 PM, Daniel Borkmann wrote: > Add skb->hash to the __sk_buff offset map, so it can be accessed from > an eBPF program. We currently already do this for classic BPF filters, > but not yet on eBPF, it might be useful as a demuxer in combination with > helpers like bpf_clo

Re: [patch net] rocker: free netdevice during netdevice removal

2015-08-02 Thread David Miller
From: Jiri Pirko Date: Sun, 2 Aug 2015 19:29:16 +0200 > From: Ido Schimmel > > When removing a port's netdevice in 'rocker_remove_ports', we should > also free the allocated 'net_device' structure. Do that by calling > 'free_netdev' after unregistering it. > > Signed-off-by: Ido Schimmel > S

Re: [PATCH net-next] ebpf: add skb->hash to offset map for usage in {cls,act}_bpf or filters

2015-08-02 Thread David Miller
From: Daniel Borkmann Date: Sat, 1 Aug 2015 00:46:29 +0200 > Add skb->hash to the __sk_buff offset map, so it can be accessed from > an eBPF program. We currently already do this for classic BPF filters, > but not yet on eBPF, it might be useful as a demuxer in combination with > helpers like bp

Re: [Patch net] fq_codel: explicitly reset flows in ->reset()

2015-08-02 Thread David Miller
From: Cong Wang Date: Fri, 31 Jul 2015 17:53:39 -0700 > From: Eric Dumazet > > Alex reported the following crash when using fq_codel > with htb: ... > As Jamal pointed out, there is actually no need to call dequeue > to purge the queued skb's in reset, data structures can be just > reset expli

Re: [PATCH net-next] bnx2x: Correct logic for pvid configuration.

2015-08-02 Thread David Miller
From: Yuval Mintz Date: Sun, 2 Aug 2015 12:42:41 +0300 > Commit 05cc5a39ddb7 ("bnx2x: add vlan filtering offload") has introduced > an incorrect logic for checking whether pvid should be configured for > a vf, causing the hypervisor driver to send unneeded ramrods for all of > the vfs each time a

RE: Panic with demuxed ipv4 multicast udp sockets on 4.0.4

2015-08-02 Thread Gregory Hoggarth
Hi Eric, The previous fix, which included the change to __udp4_lib_rcv did not fix the issue. The reproduction rate may perhaps have been slightly lower with that fix in place, hard to tell as our automated tests unfortunately failed after 600 runs due to another issue and didn't automatically

Re: [patch net] rocker: free netdevice during netdevice removal

2015-08-02 Thread Scott Feldman
On Sun, Aug 2, 2015 at 10:29 AM, Jiri Pirko wrote: > From: Ido Schimmel > > When removing a port's netdevice in 'rocker_remove_ports', we should > also free the allocated 'net_device' structure. Do that by calling > 'free_netdev' after unregistering it. > > Signed-off-by: Ido Schimmel > Signed-o

[patch net-next 1/2] rocker: enable support for scattered packets

2015-08-02 Thread Jiri Pirko
From: Ido Schimmel rocker supports the transmission of scattered packets, so let the kernel know about it by setting the NETIF_F_SG bit in the device's features. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker.c | 2 +- 1 file changed, 1 insertion(

[patch net-next 2/2] rocker: linearize skb in case frags would not fit into tx descriptor

2015-08-02 Thread Jiri Pirko
Suggested-by: Scott Feldman Signed-off-by: Jiri Pirko --- drivers/net/ethernet/rocker/rocker.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/rocker/rocker.c b/drivers/net/ethernet/rocker/rocker.c index 730bdc0..4cd5a71 100644 --- a/drivers/net/e

[PATCH -4.2] rtlwifi: rtl8723be: Add module parameter for MSI interrupts

2015-08-02 Thread Larry Finger
The driver code allows for the disabling of MSI interrupts; however the module_parm line was missed and the option fails to show with modinfo. Signed-off-by: Larry Finger Cc: Stable [3.15+] --- Kalle, This one-liner should be applied as soon as possible. Thanks, Larry --- drivers/net/wirele

[patch net] rocker: free netdevice during netdevice removal

2015-08-02 Thread Jiri Pirko
From: Ido Schimmel When removing a port's netdevice in 'rocker_remove_ports', we should also free the allocated 'net_device' structure. Do that by calling 'free_netdev' after unregistering it. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko Fixes: 4b8ac9660af ("rocker: introduce rocker s

[PATCH v2] MIPS: Remove all the uses of custom gpio.h

2015-08-02 Thread Alban Bedel
Currently CONFIG_ARCH_HAVE_CUSTOM_GPIO_H is defined for all MIPS machines, and each machine type provides its own gpio.h. However only a handful really implement the GPIO API, most just forward everythings to gpiolib. The Alchemy machine is notable as it provides a system to allow implementing the

[PATCH net-next] bnx2x: Correct logic for pvid configuration.

2015-08-02 Thread Yuval Mintz
Commit 05cc5a39ddb7 ("bnx2x: add vlan filtering offload") has introduced an incorrect logic for checking whether pvid should be configured for a vf, causing the hypervisor driver to send unneeded ramrods for all of the vfs each time a pvid has changed. Reported-by: Dan Carpenter Signed-off-by: Yu

[PATCH v2 04/11] net: phy: Allow compile test of GPIO consumers if !GPIOLIB

2015-08-02 Thread Geert Uytterhoeven
The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer functionality only, can still be compiled if GPIOLIB is not enabled. Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where appropriate. Sign

[PATCH v2 11/11] net: rfkill: Allow compile test of GPIO consumers if !GPIOLIB

2015-08-02 Thread Geert Uytterhoeven
The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer functionality only, can still be compiled if GPIOLIB is not enabled. Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where appropriate. Sign

Re: [PATCH net-next] virtio_net: add gro capability

2015-08-02 Thread Michael S. Tsirkin
On Fri, Jul 31, 2015 at 04:57:32PM -0700, David Miller wrote: > From: Eric Dumazet > Date: Fri, 31 Jul 2015 18:25:17 +0200 > > > From: Eric Dumazet > > > > Straightforward patch to add GRO processing to virtio_net. > > > ... > > Signed-off-by: Eric Dumazet > > Tested-by: Rick Jones > > Cc:

Re: [PATCH for-next V7 00/10] Move RoCE GID management to IB/Core

2015-08-02 Thread Matan Barak
On 8/2/2015 12:48 AM, Or Gerlitz wrote: On Sat, Aug 1, 2015 at 1:01 AM, Jason Gunthorpe wrote: On Sat, Aug 01, 2015 at 12:24:23AM +0300, Or Gerlitz wrote: addressed in incremental patch, as Doug suggested. Jason, it's wrong to send developers again and again to fix things which were perfect