Re: [PATCH net 1/1] qlcnic: Fix corruption while copying

2015-07-29 Thread David Miller
From: Shahed Shaikh Date: Wed, 29 Jul 2015 07:55:35 -0400 > From: Shahed Shaikh > > Use proper typecasting while performing byte-by-byte copy > > Signed-off-by: Shahed Shaikh Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH net] act_bpf: fix memory leaks when replacing bpf programs

2015-07-29 Thread David Miller
From: Daniel Borkmann Date: Wed, 29 Jul 2015 18:40:56 +0200 > We currently trigger multiple memory leaks when replacing bpf > actions, besides others: ... > Fixes: d23b8ad8ab23 ("tc: add BPF based action") > Signed-off-by: Daniel Borkmann Applied and queued up for -stable, thanks Daniel. -- To

Re: [PATCH] net/phy: micrel: Reenable interrupts during resume

2015-07-29 Thread David Miller
From: Nathan Sullivan Date: Wed, 29 Jul 2015 10:21:14 -0500 > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > index 499185e..7a93af6 100644 > --- a/drivers/net/phy/micrel.c > +++ b/drivers/net/phy/micrel.c > @@ -447,6 +447,22 @@ static int ksz9031_center_flp_timing(struct phy_d

Re: [PATCH net-next] be2net: Support vxlan offload stats in the driver

2015-07-29 Thread David Miller
From: Sriharsha Basavapatna Date: Wed, 29 Jul 2015 19:35:32 +0530 > This patch adds vxlan offload specific counters to ethtool stats. We > provide tx/rx queue counters to show the number of vxlan offload pkts > sent/received. > > Signed-off-by: Sriharsha Basavapatna Applied, thanks. -- To unsu

Re: [PATCH net 00/11] net: thunderx: Misc fixes

2015-07-29 Thread David Miller
From: Aleksey Makarov Date: Wed, 29 Jul 2015 16:49:35 +0300 > Miscellaneous fixes for the ThunderX VNIC driver > > All the patches can be applied individually. > It's ok to drop some if the maintainer feels uncomfortable > with applying for 4.2. Series applied to 'net', thanks. -- To unsubscrib

Re: [[PATCH net-next v5] net/ipv6: add sysctl option accept_ra_min_hop_limit

2015-07-29 Thread YOSHIFUJI Hideaki
Hi, Hangbin Liu wrote: > Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") > disabled accept hop limit from RA if it is smaller than the current hop > limit for security stuff. But this behavior kind of break the RFC definition. > > RFC 4861, 6.3.4. Processing Received Router

[[PATCH net-next v5] net/ipv6: add sysctl option accept_ra_min_hop_limit

2015-07-29 Thread Hangbin Liu
Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") disabled accept hop limit from RA if it is smaller than the current hop limit for security stuff. But this behavior kind of break the RFC definition. RFC 4861, 6.3.4. Processing Received Router Advertisements A Router Advert

Re: [PATCH net-next] bnx2x: add vlan filtering offload

2015-07-29 Thread David Miller
From: Yuval Mintz Date: Wed, 29 Jul 2015 15:52:46 +0300 > Current driver always uses vlan-promisc mode, i.e., it receives both > tagged and untagged traffic and lets the network stack drop packets > tagged with unrequested vlan tags. > > This patch implements vlan-filtering offload in the driver

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-29 Thread Mugunthan V N
On Thursday 30 July 2015 04:27 AM, Francois Romieu wrote: > Mugunthan V N : >> On Wednesday 29 July 2015 04:00 AM, Francois Romieu wrote: >>> Mugunthan V N : On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: > [...] > cpsw_ndo_stop calls napi_disable: you can remove netif_running.

Re: [PATCH net-next v4] net/ipv6: add sysctl option accept_ra_min_hop_limit

2015-07-29 Thread YOSHIFUJI Hideaki
Hi, Hangbin Liu wrote: > Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") > disabled accept hop limit from RA if it is higher than the current hop higher? > limit for security stuff. But this behavior kind of break the RFC definition. > > RFC 4861, 6.3.4. Processing Receiv

Re: [PATCH net-next 0/8] net/mlx5e: Driver update 29-Jul-2015

2015-07-29 Thread David Miller
From: Amir Vadai Date: Wed, 29 Jul 2015 15:05:38 +0300 > This patchset contain bug fixes and code cleaning patches to the ConnectX-4 > Ethernet driver. > > Patchset was applied and tested over commit 8c1a91f ("Merge branch > 'mlx4-802.1ad-accel'") Series applied, thanks Amir. -- To unsubscribe

Re: [PATCH net-next] openvswitch: Re-add CONFIG_OPENVSWITCH_VXLAN

2015-07-29 Thread David Miller
From: Thomas Graf Date: Wed, 29 Jul 2015 13:52:06 +0200 > This readds the config option CONFIG_OPENVSWITCH_VXLAN to avoid a > hard dependency of OVS on VXLAN. It moves the VXLAN config compat > code to vport-vxlan.c and allows compliation as a module. > > Fixes: 614732eaa12d ("openvswitch: Use r

Re: [PATCH net] ipv6: flush nd cache on IFF_NOARP change

2015-07-29 Thread David Miller
From: Eric Dumazet Date: Wed, 29 Jul 2015 12:01:41 +0200 > From: Eric Dumazet > > This patch is the IPv6 equivalent of commit > 6c8b4e3ff81b ("arp: flush arp cache on IFF_NOARP change") > > Without it, we keep buggy neighbours in the cache, with destination > MAC address equal to our own MAC

Re: [PATCH] net: pktgen: Remove unused 'allocated_skbs' field

2015-07-29 Thread David Miller
From: Bogdan Hamciuc Date: Wed, 29 Jul 2015 12:47:16 +0300 > Field pktgen_dev.allocated_skbs had been written to, but never read > from. The number of allocated skbs can be deduced anyway, from the total > number of sent packets and the 'clone_skb' param. > > Signed-off-by: Bogdan Hamciuc Also

Re: [PATCH] net: pktgen: Observe needed_headroom of the device

2015-07-29 Thread David Miller
From: Bogdan Hamciuc Date: Wed, 29 Jul 2015 12:45:58 +0300 > Allocate enough space so as not to force the outgoing net device to do > skb_realloc_headroom(). > > Signed-off-by: Bogdan Hamciuc Applied to net-next. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body

Re: [PATCH net-next] lwtunnel: Make lwtun_encaps[] static

2015-07-29 Thread David Miller
From: Thomas Graf Date: Wed, 29 Jul 2015 09:45:40 +0200 > Any external user should use the registration API instead of > accessing this directly. > > Cc: Roopa Prabhu > Signed-off-by: Thomas Graf Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body

Re: [PATCH net-next v2] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread David Miller
From: Claudiu Manoil Date: Wed, 29 Jul 2015 16:13:06 +0300 > From: Scott Wood > > As part of defconfig consolidation using fragments, we'd like to be > able to have the same drivers enabled on 32-bit and 64-bit. Gianfar > happens to only exist on 32-bit systems, and when building the > resulti

RE: [Question]Why a skb with frag_list causes BUG_ON in function skb_segment

2015-07-29 Thread Zhangjie (HZ)
Get it. Eric, thanks for your explaination. :-) Jason, thank you! I will remember cc netdev@vger.kernel.org next time. -Original Message- From: Eric Dumazet [mailto:eric.duma...@gmail.com] Sent: Thursday, July 30, 2015 1:01 PM To: Jason Wang Cc: Zhangjie (HZ); linux-ker...@vger.kernel.or

Re: [PATCH] net/wireless: enable wiphy device to suspend/resume asynchronously

2015-07-29 Thread Emmanuel Grumbach
On Thu, Jul 30, 2015 at 8:18 AM, Fu, Zhonghui wrote: > Enable wiphy device to suspend/resume asynchronously. This can improve > system suspend/resume speed. > How will that impact the timing with respect to the suspend call coming from the bus? I think that a few drivers rely on the suspend call

Re: Panic with demuxed ipv4 multicast udp sockets on 4.0.4

2015-07-29 Thread Eric Dumazet
On Thu, 2015-07-30 at 07:42 +0200, Eric Dumazet wrote: > On Thu, 2015-07-30 at 01:41 +, Gregory Hoggarth wrote: > > Hi, > > > > My company has also started having what appears to be the same problem, > > since we upgraded our embedded system to > > linux kernel 3.16. > > > > I tried applyin

Re: [PATCH net-next 0/2] net: Initialize sk_hash to random value and reset for failing cnxs

2015-07-29 Thread David Miller
From: Tom Herbert Date: Tue, 28 Jul 2015 16:02:04 -0700 > This patch set implements a common function to simply set sk_txhash to > a random number instead of going through the trouble to call flow > dissector. From dst_negative_advice we now reset the sk_txhash in hopes > of finding a better ECMP

Re: Panic with demuxed ipv4 multicast udp sockets on 4.0.4

2015-07-29 Thread Eric Dumazet
On Thu, 2015-07-30 at 01:41 +, Gregory Hoggarth wrote: > Hi, > > My company has also started having what appears to be the same problem, since > we upgraded our embedded system to > linux kernel 3.16. > > I tried applying the suggested fix of READ_ONCE (and also had to add in the > necessa

Re: [PATCH net-next v5 0/2] af_mpls: fix undefined reference to ip6_route_output with CONFIG_IPV6=n

2015-07-29 Thread David Miller
From: Roopa Prabhu Date: Tue, 28 Jul 2015 15:27:39 -0700 > v4 - v5: Use ipv6_stub_impl.ipv6_dst_lookup as suggested by Hannes I think this might not work. The ipv6_stub pointer is NULL until the ipv6 module is loaded. VXLAN can safely call through ipv6_stub->foo() because it _knows_ the ipv6 m

Re: bridge vlan range, kernel 4.1 : "message truncated" warning when too much vlans defined

2015-07-29 Thread Alexandre DERUMIER
Thanks Ronen, I have tested - char buf[16384]; + char buf[3*16384]; and It's working fine to handle 4096 vlans numbers. (The problem was really the number of vlans ids defined, could be 1 interface with 2-4095vlans, or 100 interfaces with same 2-4095vlans). With this buffer size it's worki

[PATCH] net/wireless: enable wiphy device to suspend/resume asynchronously

2015-07-29 Thread Fu, Zhonghui
Enable wiphy device to suspend/resume asynchronously. This can improve system suspend/resume speed. Signed-off-by: Zhonghui Fu --- net/wireless/core.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/wireless/core.c b/net/wireless/core.c index 2a0bbd2..bc5e68f 100644

Re: [Question]Why a skb with frag_list causes BUG_ON in function skb_segment

2015-07-29 Thread Eric Dumazet
On Thu, 2015-07-30 at 12:26 +0800, Jason Wang wrote: > cc netdev for more experts > > On 07/28/2015 04:53 PM, Zhangjie (HZ) wrote: > > > > Hi, > > > > I generate a skb as follows: > > > > It has a linear data region, 17 frags and the last fragment is in > > skb_shinfo(skb)->frag_list. > > > > Befo

Re: [Question]Why a skb with frag_list causes BUG_ON in function skb_segment

2015-07-29 Thread Jason Wang
cc netdev for more experts On 07/28/2015 04:53 PM, Zhangjie (HZ) wrote: > > Hi, > > I generate a skb as follows: > > It has a linear data region, 17 frags and the last fragment is in > skb_shinfo(skb)->frag_list. > > Before this skb is sent to driver, dev_hard_start_xmit() will segment > it first(

[PATCH][v2] net: phy: add driver for aquantia phy

2015-07-29 Thread shh.xie
From: Shaohui Xie This patch added driver to support Aquantia PHYs AQ1202, AQ2104, AQR105, AQR405, which accessed through clause 45. Signed-off-by: Shaohui Xie --- changes in v2: addressed Florian's comments. drivers/net/phy/Kconfig| 5 ++ drivers/net/phy/Makefile | 1 + drivers/net

[PATCH net-next v4] net/ipv6: add sysctl option accept_ra_min_hop_limit

2015-07-29 Thread Hangbin Liu
Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") disabled accept hop limit from RA if it is higher than the current hop limit for security stuff. But this behavior kind of break the RFC definition. RFC 4861, 6.3.4. Processing Received Router Advertisements A Router Adverti

Re: [PATCHv3] net/ipv6: add sysctl option accept_ra_min_hop_limit

2015-07-29 Thread Hangbin Liu
2015-07-30 8:45 GMT+08:00 YOSHIFUJI Hideaki : >>> How about ignoring hop limit without message is configured value is >>> larger than 255, BTW? >> >> Although set accept_ra_min_hop_limit great than 255 is meaningless, there >> is also no need to check it since icmp6_hop_limit will not larger than

[PATCH V4.2] rtlwifi: Fix NULL dereference when PCI driver used as an AP

2015-07-29 Thread Larry Finger
From: Luis Felipe Dominguez Vega In commit 33511b157bbcebaef853cc1811992b664a2e5862 ("rtlwifi: add support to send beacon frame"), the mechanism for sending beacons was established. That patch works correctly for rtl8192cu, but there is a possibility of getting the following warnings in the PCI d

linux-next: manual merge of the net-next tree with the net tree

2015-07-29 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/bridge/br_multicast.c between commit: 544586f742b4 ("bridge: mcast: give fast leave precedence over multicast router and querier") from the net tree and commit: 09cf0211f970 ("bridge: mdb: fill state in br_mdb

RE: bridge vlan range, kernel 4.1 : "message truncated" warning when too much vlans defined

2015-07-29 Thread Arad, Ronen
The easiest fix is in iproute2. Increasing the buffer size used in rtnl_dump_filter_l 3x empirically resolves the issue. The root-cause is due to the buffer size calculation of dump request in the kernel. It is based on the total number of VLANs and does not account for compressed vlan requests.

Re: Panic with demuxed ipv4 multicast udp sockets on 4.0.4

2015-07-29 Thread Gregory Hoggarth
Hi, My company has also started having what appears to be the same problem, since we upgraded our embedded system to linux kernel 3.16. I tried applying the suggested fix of READ_ONCE (and also had to add in the necessary code to compiler.h as 3.16 didn't have it) and unfortunately it did not

Re: [PATCH 0/3] net: netcp: bug fixes for dynamic module support

2015-07-29 Thread David Miller
From: Murali Karicheri Date: Tue, 28 Jul 2015 18:20:11 -0400 > This series fixes few bugs to allow keystone netcp modules to be > dynamically loaded and removed. Currently it allows following > sequence multiple times ... Series applied, thanks. -- To unsubscribe from this list: send the line "

Re: [RFC PATCH 1/1] net/ipv4: Enable flow-based ECMP

2015-07-29 Thread Richard Laing
On 07/30/2015 04:12 AM, Tom Herbert wrote: > On Tue, Jul 28, 2015 at 11:11 PM, Michal Kubecek wrote: >> On Tue, Jul 28, 2015 at 09:20:02PM +, Richard Laing wrote: > diff --git a/include/net/flow.h b/include/net/flow.h > index 8109a15..d1d933d 100644 > --- a/include/net/flow.h >>>

Re: [PATCH net] net: sched: fix refcount imbalance in actions

2015-07-29 Thread Daniel Borkmann
On 07/30/2015 02:33 AM, Cong Wang wrote: ... diff --git a/net/sched/act_api.c b/net/sched/act_api.c index af427a3..bd63a39 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -53,8 +53,11 @@ int tcf_hash_release(struct tc_action *a, int bind) if (p) { if (bind)

Re: [PATCH iproute2] bridge fdb: add 'use' option to set NTF_USE flag in fdb add requests

2015-07-29 Thread roopa
On 7/29/15, 2:26 PM, Roopa Prabhu wrote: From: Roopa Prabhu This is similar to command options corresponding to other NTF_* flags already exposed to the user space (examples self/master). Also updates bridge man page (The man page patch also includes a fix to the 'self' entry and documents 'ma

Re: [PATCHv3] net/ipv6: add sysctl option accept_ra_min_hop_limit

2015-07-29 Thread YOSHIFUJI Hideaki
Hi, Hangbin Liu wrote: >>> diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c >>> index 0a05b35..acda056 100644 >>> --- a/net/ipv6/ndisc.c >>> +++ b/net/ipv6/ndisc.c >>> @@ -1226,13 +1226,11 @@ static void ndisc_router_discovery(struct sk_buff >>> *skb) >>> if (rt) >>> rt6_set_e

Re: [PATCH net] net: sched: fix refcount imbalance in actions

2015-07-29 Thread Cong Wang
On Wed, Jul 29, 2015 at 2:35 PM, Daniel Borkmann wrote: > What happens is that in tcf_hash_check(), we check tcf_common for a given > index and increase tcfc_refcnt and conditionally tcfc_bindcnt when we've > found an existing action. Now there are the following cases: > > 1) We do a late bindin

Re: [PATCH v2 0/3] Add MDIO support to ThunderX NIC driver

2015-07-29 Thread David Miller
From: mohun...@gmail.com Date: Tue, 28 Jul 2015 15:12:10 -0700 > This patch series adds MDIO support to ThunderX NIC driver by making use > of existing mdio-octeon driver. In the process modified the mdio-octeon > driver to work on both Octeon and ThunderX platforms. > > * From v1: > - Removed

Re: [net-next PATCH] net: netcp: Fixes efuse mac addr swap on k2e and k2l

2015-07-29 Thread David Miller
From: WingMan Kwok Date: Tue, 28 Jul 2015 16:01:11 -0400 > On some of the K2E and K2L platforms, the two DWORDs in > efuse occupied by the pre-programmed mac address for > slave port 1 are swapped. To workaround this issue, > this patch adds a new define NETCP_EFUSE_ADDR_SWAP (2) > which signifi

Re: [PATCH net] sctp: fix sockopt size check

2015-07-29 Thread David Miller
From: Marcelo Ricardo Leitner Date: Tue, 28 Jul 2015 11:16:23 -0300 > The problem is not on being bigger than what we want, but on being > smaller, as it causes read of invalid memory. > > Note that the struct changes on commit 7e8616d8e773 didn't affect > sctp_setsockopt_events one but that's w

Re: [PATCH net] ebpf, x86: fix general protection fault when tail call is invoked

2015-07-29 Thread David Miller
From: Daniel Borkmann Date: Tue, 28 Jul 2015 15:26:36 +0200 > With eBPF JIT compiler enabled on x86_64, I was able to reliably trigger > the following general protection fault out of an eBPF program with a simple > tail call, f.e. tracex5 (or a stripped down version of it): ... > Changing the em

Re: [PATCH v2 0/3] Add MDIO support to ThunderX NIC driver

2015-07-29 Thread Radha Mohan
On Tue, Jul 28, 2015 at 3:12 PM, wrote: > From: Radha Mohan Chintakuntla > > This patch series adds MDIO support to ThunderX NIC driver by making use > of existing mdio-octeon driver. In the process modified the mdio-octeon > driver to work on both Octeon and ThunderX platforms. > > * From v1: >

Re: [PATCH net-next 1/1] tipc: fix bug in broadcast synch message create function

2015-07-29 Thread David Miller
From: Jon Maloy Date: Wed, 29 Jul 2015 18:28:01 -0400 > In commit d999297c3dbbe7fdd832f7fa4ec84301e170b3e6 > ("tipc: reduce locking scope during packet reception") we introduced > a new function tipc_build_bcast_sync_msg(), which carries initial > synchronization data between two nodes at first c

Re: [net-next PATCH 0/3] Backwards-compatible noqueue in virtual interfaces

2015-07-29 Thread Cong Wang
On Wed, Jul 29, 2015 at 1:51 PM, Phil Sutter wrote: > This series is inspired by a patch sent[1] in from Jesper Brouer and the > discussion it started. Basically it tries to provide a solution which is > backwards compatible while still enabling the veth performance > improvement by default. You

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-29 Thread Francois Romieu
Mugunthan V N : > On Wednesday 29 July 2015 04:00 AM, Francois Romieu wrote: > > Mugunthan V N : > >> On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: [...] > >>> cpsw_ndo_stop calls napi_disable: you can remove netif_running. > >>> > >> > >> This netif_running check is to find which inte

[PATCH net-next 0/3] net: Switch tag HW extraction/insertion

2015-07-29 Thread Florian Fainelli
Hi all, This patch series adds two new feature flags to allow Ethernet controllers capable of doing Ethernet switch proprietary tag insertion/extraction to benefit from that. The last two patches modify the Broadcom tag parsing code in DSA to utilize that feature and finally, the SYSTEMPORT contr

[PATCH net-next 1/3] net: add flags for HW assisted extraction/insertions of switch tags

2015-07-29 Thread Florian Fainelli
Some hardware (e.g: Broadcom's SYSTEMPORT) is capable of automatically extracting and inserting a proprietary switch tag (e.g: Broadcom tag) which saves us packet modifications when using DSA. Add the required ethtool changes and netdevice feature bits to support such devices. Signed-off-by: Flori

[PATCH net-next 2/3] net: dsa: tag_brcm: Support extracting tags from HW

2015-07-29 Thread Florian Fainelli
In case an adapter advertises NETIF_F_HW_SWITCH_RX_TAG, proceed with extracting the 4-bytes Broadcom tag directly from skb->cb[] and utilize that instead of copying and memmoving() data around. To establish a contract between the Ethernet MAC advertisign NETIF_F_HW_SWITCH_RX_TAG and the Broadcom t

[PATCH net-next 3/3] net: systemport: Add support for switch tag HW extraction

2015-07-29 Thread Florian Fainelli
The Broadcom SYSTEMPORT Ethernet controller is capable of extracting a switch tag (4-bytes Broadcom tag) and put it in the second 32-bits word of its pre-pended Receive Status Block. When this feature is requested, make sure that we can satisfy it by turning on receive checksum offload, and copy th

Re: [PATCH V4 4/7] Drivers: hv: vmbus: add APIs to register callbacks to process hvsock connection

2015-07-29 Thread David Miller
From: Dexuan Cui Date: Tue, 28 Jul 2015 05:35:11 -0700 > With the 2 APIs supplied by the VMBus driver, the coming net/hvsock driver > can register 2 callbacks and can know when a new hvsock connection is > offered by the host, and when a hvsock connection is being closed by the > host. > > Signe

[PATCH net-next 1/1] tipc: fix bug in broadcast synch message create function

2015-07-29 Thread Jon Maloy
In commit d999297c3dbbe7fdd832f7fa4ec84301e170b3e6 ("tipc: reduce locking scope during packet reception") we introduced a new function tipc_build_bcast_sync_msg(), which carries initial synchronization data between two nodes at first contact and at re-contact. In this function, we missed to add syn

Re: [PATCH V4 7/7] Drivers: hv: vmbus: disable local interrupt when hvsock's callback is running

2015-07-29 Thread David Miller
From: Dexuan Cui Date: Tue, 28 Jul 2015 05:35:30 -0700 > In the SMP guest case, when the per-channel callback hvsock_events() is > running on virtual CPU A, if the guest tries to close the connection on > virtual CPU B: we invoke vmbus_close() -> vmbus_close_internal(), > then we can have trouble

Re: [PATCH V4 6/7] hvsock: introduce Hyper-V VM Sockets feature

2015-07-29 Thread David Miller
From: Dexuan Cui Date: Tue, 28 Jul 2015 05:35:23 -0700 > +/* hvsock_release() can be invoked in 2 paths: > + * 1. on process termination: > + * hvsock_sk_destruct+0x1a/0x20 > + * __sk_free+0x1d/0x130 > + * sk_free+0x19/0x20 > + * hvsock_release+0x138/0x160 > + * sock_release+0x1f/0x90 >

Re: [PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-29 Thread Tom Herbert
On Wed, Jul 29, 2015 at 3:15 PM, Eric Dumazet wrote: > On Wed, 2015-07-29 at 14:47 -0700, Tom Herbert wrote: > >> Hi Eric, >> >> So the scenario you're thinking is conntrack in the forwarding path, >> RPS enabled (RSS not relevant), no hash from device, no IPv6 flow >> labels or any other asymmetr

Re: [PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-29 Thread Eric Dumazet
On Wed, 2015-07-29 at 14:47 -0700, Tom Herbert wrote: > Hi Eric, > > So the scenario you're thinking is conntrack in the forwarding path, > RPS enabled (RSS not relevant), no hash from device, no IPv6 flow > labels or any other asymmetric inputs into the flow hash? I can look > at that, but it do

Re: [PATCH net-next] packet: remove handling of tx_ring from prb_shutdown_retire_blk_timer()

2015-07-29 Thread David Miller
From: Tobias Klauser Date: Tue, 28 Jul 2015 14:21:26 +0200 > Follow e8e85cc5eb57 ("packet: remove handling of tx_ring") and remove > the tx_ring parameter from prb_shutdown_retire_blk_timer() as it is only > called with tx_ring = 0. > > Signed-off-by: Tobias Klauser Applied, thanks. -- To unsu

Re: [net-next PATCH 2/3] net: sched: set tx_queue_len to default when changing noqueue device's qdisc

2015-07-29 Thread Phil Sutter
On Wed, Jul 29, 2015 at 11:10:45PM +0200, Eric Dumazet wrote: > On Wed, 2015-07-29 at 22:51 +0200, Phil Sutter wrote: [...] > > diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c > > index f06aa01..79b8900 100644 > > --- a/net/sched/sch_api.c > > +++ b/net/sched/sch_api.c > > @@ -1315,6 +1315,1

Re: [PATCH net] bridge: mdb: fix delmdb state in the notification

2015-07-29 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 28 Jul 2015 13:10:44 +0200 > From: Nikolay Aleksandrov > > Since mdb states were introduced when deleting an entry the state was > left as it was set in the delete request from the user which leads to > the following output when doing a monitor (for example)

Re: [PATCH net-next v2 0/5] s390/bpf: recache skb->data/hlen for skb_vlan_push/pop

2015-07-29 Thread David Miller
From: Michael Holzheu Date: Wed, 29 Jul 2015 21:15:13 +0200 > Here the s390 backend for Alexei's patch 4e10df9a60d9 ("bpf: introduce > bpf_skb_vlan_push/pop() helpers") plus two bugfixes and two minor > improvements. > > The first patch "s390/bpf: clear correct BPF accumulator register" will > a

RE: [PATCH net-next 1/1] Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver

2015-07-29 Thread Woojung.Huh
Thanks for review and comment. Will repost after update. > -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, July 29, 2015 3:14 PM > To: Woojung Huh - C21699 > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH net-next 1/1] Microchip's LAN7800 family U

Re: [PATCH net] bridge: mcast: give fast leave precedence over multicast router and querier

2015-07-29 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 28 Jul 2015 03:28:27 -0700 > From: Satish Ashok > > When fast leave is configured on a bridge port and an IGMP leave is > received for a group, the group is not deleted immediately if there is > a router detected or if multicast querier is configured. > Idea

[PATCH] net: phy: spi_ks8995: clean up ks8995_registers_read/write

2015-07-29 Thread Vladimir Zapolskiy
The change removes redundant sysfs binary file boundary checks, since this task is already done on caller side in fs/sysfs/file.c Signed-off-by: Vladimir Zapolskiy --- drivers/net/phy/spi_ks8995.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/net/phy/spi_ks89

Re: [PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-29 Thread Tom Herbert
On Wed, Jul 29, 2015 at 2:19 PM, Eric Dumazet wrote: > On Wed, 2015-07-29 at 13:49 -0700, Tom Herbert wrote: >> The intent of this function was to produce a consistent hash for both >> directions of a flow. However, since we added more inputs to the flow >> hashing (IPv6 flow labels for instance)

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-07-29 Thread David Miller
From: Phil Sutter Date: Wed, 29 Jul 2015 23:34:28 +0200 > On Wed, Jul 29, 2015 at 11:06:18PM +0200, Florian Westphal wrote: >> Phil Sutter wrote: > [...] >> > +config DEFAULT_TX_QUEUE_LEN >> > + prompt "Default TX queue length (in packets)" if EXPERT >> > + int >> > + default 1000# Ethern

[patch net-next v2 3/4] mlxsw: Add interface to access registers and process events

2015-07-29 Thread Jiri Pirko
From: Ido Schimmel Ethernet Management Datagrams (EMADs) are Ethernet packets sent between the host and the device in order to configure the available device registers. Another use case is notifications sent from the device to the host, letting it know about certain events, such as port up / down

[PATCH net] net: sched: fix refcount imbalance in actions

2015-07-29 Thread Daniel Borkmann
Since commit 55334a5db5cd ("net_sched: act: refuse to remove bound action outside"), we end up with a wrong reference count for a tc action. Test case 1: FOO="1,6 0 0 4294967295," BAR="1,6 0 0 4294967294," tc filter add dev foo parent 1: bpf bytecode "$FOO" flowid 1:1 \ action bpf byte

[patch net-next v2 4/4] mlxsw: Introduce Mellanox SwitchX-2 ASIC support

2015-07-29 Thread Jiri Pirko
From: Jiri Pirko Benefit from the previously introduced Mellanox Switch infrastructure and add driver for SwitchX-2 ASIC. Note that this driver is very simple now. It implements bare minimum for getting device to work on slow-path. Fast-path offload functionality is going to be added soon. Signe

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-07-29 Thread Phil Sutter
On Wed, Jul 29, 2015 at 11:06:18PM +0200, Florian Westphal wrote: > Phil Sutter wrote: [...] > > +config DEFAULT_TX_QUEUE_LEN > > + prompt "Default TX queue length (in packets)" if EXPERT > > + int > > + default 1000# Ethernet wants good queues > > + help > > + Set the default valu

[patch net-next v2 2/4] mlxsw: Add PCI bus implementation

2015-07-29 Thread Jiri Pirko
From: Jiri Pirko Add PCI bus implementation for Mellanox Technologies Switch ASICs. This includes firmware initialization, async queues manipulation and command interface implementation. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel Signed-off-by: Elad Raz Reviewed-by: Scott Feldman

[patch net-next v2 1/4] mlxsw: Introduce Mellanox switch driver core

2015-07-29 Thread Jiri Pirko
From: Jiri Pirko Add core components of Mellanox switch driver infrastructure. Core infrastructure is designed so that it can be used by multiple bus drivers (PCI now, I2C and SGMII are planned to be implemented in the future). Multiple switch kind drivers can be registered as well. This core ser

[patch net-next v2 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers

2015-07-29 Thread Jiri Pirko
From: Jiri Pirko This patchset introduces Mellanox Technologies Switch driver infrastructure and support for SwitchX-2 ASIC. The driver is divided into 3 logical parts: 1) Bus - implements switch bus interface. Currently only PCI bus is implemented, but more buses will be added in the future.

Re: [PATCH 0/2] igb/ixgbe: Fix ordering of SR-IOV teardown

2015-07-29 Thread David Miller
From: Alex Williamson Date: Wed, 29 Jul 2015 13:33:07 -0600 > I expect that's because of this patch that's in Jeff's dev-queue branch: > > http://git.kernel.org/cgit/linux/kernel/git/jkirsher/next-queue.git/commit/?h=dev-queue&id=ddf766a812a13eca1116b5905e902184904266f9 > > I based these patche

Xen-unstable + Linux 4.2-rc4: GPF RIP: e030:[] [] detach_if_pending+0x18/0x80

2015-07-29 Thread linux
Hi, Running on Xen testing a 4.2-rc4 kernel it got the crash below. Could this be related to the changes in 3bb475a3446facd0425d3f2fe7e85bf03c5c6c05 ? It crashes dom0 when i put some strain onto the network + bridge. -- Sander [ 2108.078763] general protection fault: [#1] SMP [ 2108.1

[PATCH iproute2] bridge fdb: add 'use' option to set NTF_USE flag in fdb add requests

2015-07-29 Thread Roopa Prabhu
From: Roopa Prabhu This is similar to command options corresponding to other NTF_* flags already exposed to the user space (examples self/master). Also updates bridge man page (The man page patch also includes a fix to the 'self' entry and documents 'master' for fdb entries) Signed-off-by: Roop

Re: [PATCH 2/2] net: netcp: Allocate RX packet buffers using __GFP_DMA

2015-07-29 Thread Murali Karicheri
On 07/29/2015 04:59 PM, Eric Dumazet wrote: On Wed, 2015-07-29 at 11:10 -0400, WingMan Kwok wrote: The Keystone II DMA hardware can only access addresses in the lower 2 GiB of SDRAM. This patch makes sure the RX buffers are allocated using the __GFP_DMA flag so they meet this requirement. Signe

Re: [PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-29 Thread Eric Dumazet
On Wed, 2015-07-29 at 13:49 -0700, Tom Herbert wrote: > The intent of this function was to produce a consistent hash for both > directions of a flow. However, since we added more inputs to the flow > hashing (IPv6 flow labels for instance) in a lot of cases we won't get > the same hash computed for

Re: [PATCH] net: switchdev: restrict vid range abstraction

2015-07-29 Thread Scott Feldman
On Wed, Jul 29, 2015 at 12:14 PM, Vivien Didelot wrote: > Hi Scott, David, > > On Jul 29, 2015, at 2:28 PM, David da...@davemloft.net wrote: > >> From: Scott Feldman >> Date: Wed, 29 Jul 2015 00:31:44 -0700 >> >>> Since the netlink request (for example vlan add) includes the range, >>> I'm not se

Re: [PATCH net-next v3] route: allow to route in a peer netns via lwt framework

2015-07-29 Thread Nicolas Dichtel
Le 29/07/2015 17:20, Eric Dumazet a écrit : On Wed, 2015-07-29 at 15:16 +0200, Nicolas Dichtel wrote: This patch takes advantage of the newly added lwtunnel framework to allow the user to set routes that point to a peer netns. Packets are injected to the peer netns via the loopback device. It w

Re: [net-next PATCH 2/3] net: sched: set tx_queue_len to default when changing noqueue device's qdisc

2015-07-29 Thread Eric Dumazet
On Wed, 2015-07-29 at 22:51 +0200, Phil Sutter wrote: > Virtual interfaces don't necessarily need a qdisc attached to them. This > is signalled by setting dev->tx_queue_len to zero upon initialisation. The > problems begin when a user still adds a qdisc, as then the special value > is used as a reg

Re: [net-next PATCH 2/3] net: sched: set tx_queue_len to default when changing noqueue device's qdisc

2015-07-29 Thread Florian Westphal
Phil Sutter wrote: > Virtual interfaces don't necessarily need a qdisc attached to them. This > is signalled by setting dev->tx_queue_len to zero upon initialisation. The > problems begin when a user still adds a qdisc, as then the special value > is used as a regular one causing massive packet dr

Re: [net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-07-29 Thread Florian Westphal
Phil Sutter wrote: > Signed-off-by: Phil Sutter > --- > net/Kconfig| 12 > net/ethernet/eth.c | 2 +- > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/net/Kconfig b/net/Kconfig > index 7021c1b..21c164f 100644 > --- a/net/Kconfig > +++ b/net/Kconfig > @@

Re: [PATCH] gianfar: Fix warnings when built on 64-bit

2015-07-29 Thread Arnd Bergmann
On Wednesday 29 July 2015 11:02:41 Scott Wood wrote: > On Wed, 2015-07-29 at 10:02 +0200, Arnd Bergmann wrote: > > On Wednesday 29 July 2015 00:24:37 Scott Wood wrote: > > > +#ifdef CONFIG_PM > > > static void lock_tx_qs(struct gfar_private *priv) > > > { > > > int i; > > > @@ -580,6 +581,7 @

Re: [PATCH 2/2] net: netcp: Allocate RX packet buffers using __GFP_DMA

2015-07-29 Thread Eric Dumazet
On Wed, 2015-07-29 at 11:10 -0400, WingMan Kwok wrote: > The Keystone II DMA hardware can only access addresses in the > lower 2 GiB of SDRAM. This patch makes sure the RX buffers are > allocated using the __GFP_DMA flag so they meet this requirement. > > Signed-off-by: WingMan Kwok > Signed-off-

[net-next PATCH 2/3] net: sched: set tx_queue_len to default when changing noqueue device's qdisc

2015-07-29 Thread Phil Sutter
Virtual interfaces don't necessarily need a qdisc attached to them. This is signalled by setting dev->tx_queue_len to zero upon initialisation. The problems begin when a user still adds a qdisc, as then the special value is used as a regular one causing massive packet drops as soon as the device se

[net-next PATCH 3/3] veth: don't assign a qdisc to veth

2015-07-29 Thread Phil Sutter
From: Jesper Dangaard Brouer The veth driver is a virtual device, and should not have assigned the default qdisc. Verified (ndo_start_xmit) veth_xmit can only return NETDEV_TX_OK, thus this should be safe to bypass qdisc. Not assigning a qdisc is subtly done by setting tx_queue_len to zero. Re

[net-next PATCH 1/3] net: make default tx_queue_len configurable

2015-07-29 Thread Phil Sutter
Signed-off-by: Phil Sutter --- net/Kconfig| 12 net/ethernet/eth.c | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/net/Kconfig b/net/Kconfig index 7021c1b..21c164f 100644 --- a/net/Kconfig +++ b/net/Kconfig @@ -48,6 +48,18 @@ config COMPAT_NETLINK_MESS

[net-next PATCH 0/3] Backwards-compatible noqueue in virtual interfaces

2015-07-29 Thread Phil Sutter
This series is inspired by a patch sent[1] in from Jesper Brouer and the discussion it started. Basically it tries to provide a solution which is backwards compatible while still enabling the veth performance improvement by default. [1]: http://www.spinics.net/lists/netdev/msg299407.html Jesper D

[PATCH net-next] flow_dissector: remove __flow_hash_consistentify

2015-07-29 Thread Tom Herbert
The intent of this function was to produce a consistent hash for both directions of a flow. However, since we added more inputs to the flow hashing (IPv6 flow labels for instance) in a lot of cases we won't get the same hash computed for each direction anyway. Also, there is no defined correlation

Re: [PATCH 1/2] net: Export __netdev_alloc_frag() to allow gfp_mask flags

2015-07-29 Thread Eric Dumazet
On Wed, 2015-07-29 at 16:22 -0400, Murali Karicheri wrote: > Eric, > > On 07/29/2015 12:31 PM, Eric Dumazet wrote: > > On Wed, 2015-07-29 at 11:10 -0400, WingMan Kwok wrote: > >> This patch makes the function __netdev_alloc_frag() non-static and > >> exports it so that drivers that need to specify

[PATCH v2 1/2] igb: Teardown SR-IOV before unregister_netdev()

2015-07-29 Thread Alex Williamson
When the .remove() callback for a PF is called, SR-IOV support for the device is disabled, which requires unbinding and removing the VFs. The VFs may be in-use either by the host kernel or userspace, such as assigned to a VM through vfio-pci. In this latter case, the VFs may be removed either by s

[PATCH v2 2/2] ixgbe: Teardown SR-IOV before unregister_netdev()

2015-07-29 Thread Alex Williamson
When the .remove() callback for a PF is called, SR-IOV support for the device is disabled, which requires unbinding and removing the VFs. The VFs may be in-use either by the host kernel or userspace, such as assigned to a VM through vfio-pci. In this latter case, the VFs may be removed either by s

[PATCH v2 0/2] igb/ixgbe: Fix ordering of SR-IOV teardown

2015-07-29 Thread Alex Williamson
v2: - Rebase to DaveM's net tree, context-only change - Add Mitch's Acks There's no functional change from v1, so the choice of v1 or v2 is just a matter of which maintainer wants to take these. Original description: When running a Windows 2012 R2 guest with a pair of VFs assigned through vfio

Re: [PATCH 1/2] net: Export __netdev_alloc_frag() to allow gfp_mask flags

2015-07-29 Thread Murali Karicheri
Eric, On 07/29/2015 12:31 PM, Eric Dumazet wrote: On Wed, 2015-07-29 at 11:10 -0400, WingMan Kwok wrote: This patch makes the function __netdev_alloc_frag() non-static and exports it so that drivers that need to specify additional flags, such as __GFP_DMA, can use it. The currently exported fun

Re: [PATCH net-next 1/2] net: Set sk_txhash from a random number

2015-07-29 Thread Thomas Graf
On 07/29/15 at 08:58am, Tom Herbert wrote: > The salient property of both sk_txhash and skb->hash is that they > provide a uniform distribution over flows. It is incorrect to assume > that either of these immutable during the lifetime of a flow, so yes > this means that packets of a flow may go to

Re: [PATCH net-next] openvswitch: Re-add CONFIG_OPENVSWITCH_VXLAN

2015-07-29 Thread Thomas Graf
On 07/29/15 at 12:05pm, Pravin Shelar wrote: > On Wed, Jul 29, 2015 at 4:52 AM, Thomas Graf wrote: > > This readds the config option CONFIG_OPENVSWITCH_VXLAN to avoid a > > hard dependency of OVS on VXLAN. It moves the VXLAN config compat > > code to vport-vxlan.c and allows compliation as a modul

Re: [PATCH net-next] lwtunnel: Make lwtun_encaps[] static

2015-07-29 Thread roopa
On 7/29/15, 12:45 AM, Thomas Graf wrote: Any external user should use the registration API instead of accessing this directly. Cc: Roopa Prabhu Signed-off-by: Thomas Graf Acked-by: Roopa Prabhu thanks. --- include/net/lwtunnel.h | 3 --- net/core/lwtunnel.c| 2 +- 2 files changed,

Re: [PATCH 0/2] igb/ixgbe: Fix ordering of SR-IOV teardown

2015-07-29 Thread Alex Williamson
On Wed, 2015-07-29 at 12:16 -0700, David Miller wrote: > From: Alex Williamson > Date: Mon, 27 Jul 2015 17:18:28 -0600 > > > When running a Windows 2012 R2 guest with a pair of VFs assigned > > through vfio-pci, we run into a problem trying to hot-unplug those VFs > > after the PF has unregistere

  1   2   3   >