[RFC PATCH net] sctp: ASCONF-ACK with Unresolvable Address should be sent

2015-07-23 Thread Xin Long
RFC 5061: This is an opaque integer assigned by the sender to identify each request parameter. The receiver of the ASCONF Chunk will copy this 32-bit value into the ASCONF Response Correlation ID field of the ASCONF-ACK response parameter. The sender of the ASCONF can use this

Re: [PATCH V3 3/7] Drivers: hv: vmbus: add APIs to send/recv hvsock packet and get the r/w-ability

2015-07-23 Thread Sudip Mukherjee
On Thu, Jul 23, 2015 at 01:24:50PM +0300, Dan Carpenter wrote: > On Thu, Jul 23, 2015 at 01:10:57PM +0300, Dan Carpenter wrote: > > In this specific case, writing it as "if (ret != 0)" caused the bug. If > > we had written it as "if (ret) return ret;" then there are no zeroes so > > wouldn't have

[PATCH] net: phy: dp83867: fix simple_return.cocci warnings

2015-07-23 Thread kbuild test robot
drivers/net/phy/dp83867.c:126:1-4: WARNING: end returns can be simpified drivers/net/phy/dp83867.c:74:5-8: WARNING: end returns can be simpified if tested value is negative or 0 Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/cocci

[PATCH net v2 0/3] r8152: issues fix

2015-07-23 Thread Hayes Wang
v2: Replace patch #2 with "r8152: fix wakeup settings". v1: These patches are used to fix issues. Hayes Wang (3): r8152: fix the issue about U1/U2 - r8152: fix remote wakeup + r8152: fix wakeup settings r8152: don't enable napi before rx ready drivers/net/usb/r8152.c | 103 +++

[PATCH net v2 2/3] r8152: fix wakeup settings

2015-07-23 Thread Hayes Wang
Avoid the driver to enable WOL if the device doesn't support it. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index e3a0110..d537c30 100644

[PATCH net v2 3/3] r8152: don't enable napi before rx ready

2015-07-23 Thread Hayes Wang
Adjust napi_disable() and napi_enable() to avoid r8152_poll() start working before rx ready. Otherwise, it may have race condition for rx_agg. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b

[PATCH net v2 1/3] r8152: fix the issue about U1/U2

2015-07-23 Thread Hayes Wang
- Disable U1/U2 during initialization. - Disable lpm when linking is on, and enable it when linking is off. - Disable U1/U2 when enabling runtime suspend. It is possible to let hw stop working, if the U1/U2 request occurs during some situations. The patch is used to avoid it. Signed-off-by: Hayes

Re: [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers

2015-07-23 Thread Jiri Pirko
Fri, Jul 24, 2015 at 02:03:20AM CEST, sfel...@gmail.com wrote: >On Thu, Jul 23, 2015 at 8:43 AM, Jiri Pirko wrote: >> This patchset introduces Mellanox Technologies Switch driver infrastructure >> and support for SwitchX-2 ASIC. >> >> The driver is divided into 3 logical parts: >> 1) Bus - impleme

Re: [patch net-next 2/4] mlxsw: Add PCI bus implementation

2015-07-23 Thread Jiri Pirko
Fri, Jul 24, 2015 at 06:52:16AM CEST, sfel...@gmail.com wrote: >On Thu, Jul 23, 2015 at 8:43 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Add PCI bus implementation for Mellanox Technologies Switch ASICs. This >> includes firmware initialization, async queues manipulation and command >> interf

Re: [patch net-next 3/4] mlxsw: Add interface to access registers and process events

2015-07-23 Thread Jiri Pirko
Thu, Jul 23, 2015 at 11:12:20PM CEST, go...@cumulusnetworks.com wrote: >On Thu, Jul 23, 2015 at 05:43:35PM +0200, Jiri Pirko wrote: >> From: Ido Schimmel >> >> Add the ability to construct mailbox-style register access messages >> called EMADs with provisions to construct and parse the registers

Re: [patch net-next 3/4] mlxsw: Add interface to access registers and process events

2015-07-23 Thread Jiri Pirko
Fri, Jul 24, 2015 at 07:13:42AM CEST, sfel...@gmail.com wrote: >On Thu, Jul 23, 2015 at 8:43 AM, Jiri Pirko wrote: >> From: Ido Schimmel >> >> Add the ability to construct mailbox-style register access messages >> called EMADs with provisions to construct and parse the registers payload. >> Imple

Re: [patch net-next 3/4] mlxsw: Add interface to access registers and process events

2015-07-23 Thread Scott Feldman
On Thu, Jul 23, 2015 at 8:43 AM, Jiri Pirko wrote: > From: Ido Schimmel > > Add the ability to construct mailbox-style register access messages > called EMADs with provisions to construct and parse the registers payload. > Implement EMAD transaction layer which is responsible for the reliable > t

Re: [RFC PATCH v3 net-next 2/3] tcp: add in_flight to tcp_skb_cb

2015-07-23 Thread YOSHIFUJI Hideaki/吉藤英明
Hi, Lawrence Brakmo wrote: > Based on comments by Neal Cardwell to tcp_nv patch: > > AFAICT this patch would not require an increase in the size of sk_buff > cb[] if it were to take advantage of the fact that the tcp_skb_cb > header.h4 and header.h6 fields are only used in the packet recept

Re: [patch net-next 2/4] mlxsw: Add PCI bus implementation

2015-07-23 Thread Scott Feldman
On Thu, Jul 23, 2015 at 8:43 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Add PCI bus implementation for Mellanox Technologies Switch ASICs. This > includes firmware initialization, async queues manipulation and command > interface implementation. > > Signed-off-by: Jiri Pirko > Signed-off-by: I

Re: [PATCH] net/ipv6: add sysctl option accept_ra_hop_limit

2015-07-23 Thread YOSHIFUJI Hideaki
Hi, Hangbin Liu wrote: > Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") > disabled accept hop limit from RA if it is higher than the current hop > limit for security stuff. But this behavior kind of break the RFC definition. > > RFC 4861, 6.3.4. Processing Received Router

Re: [PATCH] phylib: add driver for aquantia phy

2015-07-23 Thread Florian Fainelli
Le 07/23/15 20:46, shh@gmail.com a écrit : > From: Shaohui Xie > > This patch added driver to support Aquantia PHYs AQ1202, AQ2104, AQR105, > AQR405, which accessed through clause 45. Could you prefix your patches with "net: phy: " in the future to be consistent with what is typically used?

[PATCH] net/ipv6: add sysctl option accept_ra_hop_limit

2015-07-23 Thread Hangbin Liu
Commit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") disabled accept hop limit from RA if it is higher than the current hop limit for security stuff. But this behavior kind of break the RFC definition. RFC 4861, 6.3.4. Processing Received Router Advertisements If the received

[PATCH] phylib: add driver for aquantia phy

2015-07-23 Thread shh.xie
From: Shaohui Xie This patch added driver to support Aquantia PHYs AQ1202, AQ2104, AQR105, AQR405, which accessed through clause 45. Signed-off-by: Shaohui Xie --- drivers/net/phy/Kconfig| 5 ++ drivers/net/phy/Makefile | 1 + drivers/net/phy/aquantia.c | 157

[PATCH net-next] dev: Spelling fix in comments

2015-07-23 Thread subashab
Fix the following typo - unchainged -> unchanged Signed-off-by: Subash Abhinov Kasiviswanathan --- net/core/dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 488ba6c..44d1384 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -49

Re: 4.2-rc3: APM xgene2: ethernet doesn't work

2015-07-23 Thread Suman Tripathi
Hi Ming, On Thu, Jul 23, 2015 at 2:37 PM, Ming Lei wrote: > Hi Guys, > > When booting from UEFI/ACPI, sometimes there is a crash[1] > from rx path, sometimes there isn't any rx packets comming. > > Firmware version: 2.02.10 > > Thanks, > > [1], crash log > Call trace: > skbuff: skb_over_panic: te

[RFC PATCH v3 net-next 3/3] tcp: add NV congestion control

2015-07-23 Thread Lawrence Brakmo
This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC (slides). It is a delayed based congestion avoidance for the data center. This version has been tested within a 10G rack where the HW RTTs are 20-50us. A descrip

[RFC PATCH v3 net-next 0/3] tcp: add NV congestion control

2015-07-23 Thread Lawrence Brakmo
This patchset adds support for NV congestion control. The first patch replaces two arguments in the pkts_acked() function of the congestion control modules with a struct, making it easier to add more parameters later without modifying the existing congestion control modules. The second patch adds

[RFC PATCH v3 net-next 1/3] tcp: replace cnt & rtt with struct in pkts_acked()

2015-07-23 Thread Lawrence Brakmo
Replace 2 arguments (cnt and rtt) in the congestion control modules' pkts_acked() function with a struct. This will allow adding more information without having to modify existing congestion control modules (tcp_nv in particular needs bytes in flight when packet was sent). As proposed by Neal Card

[RFC PATCH v3 net-next 2/3] tcp: add in_flight to tcp_skb_cb

2015-07-23 Thread Lawrence Brakmo
Based on comments by Neal Cardwell to tcp_nv patch: AFAICT this patch would not require an increase in the size of sk_buff cb[] if it were to take advantage of the fact that the tcp_skb_cb header.h4 and header.h6 fields are only used in the packet reception code path, and this in_flight fi

Re: [PATCH net-next] inet: Always increment refcount in inet_twsk_schedule

2015-07-23 Thread subashab
> Actually we do increment refcnt, for every socket found in ehash. > > Carefully read again __inet_lookup_established() > > This code is generic for ESTABLISH and TIME-WAIT sockets > > If you found a code that performed the lookup without taking the refcnt, > please point me at it, this would be a

Re: [RFC PATCH v2 net-next 3/3] tcp: add NV congestion control

2015-07-23 Thread Lawrence Brakmo
Thank you all for your comments, I¹m currently testing the changes. Other comments inline. On 7/21/15, 11:50 PM, "Yuchung Cheng" wrote: >On Tue, Jul 21, 2015 at 9:21 PM, Lawrence Brakmo wrote: >> This is a request for comments. >> >> TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier

Re: [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers

2015-07-23 Thread Rustad, Mark D
> On Jul 23, 2015, at 5:03 PM, Scott Feldman wrote: > > On the CHECKs on space after cast, should we modify checkpatch.pl to > not flag those for drivers/net? Please don't. My internal parser really wants to see the cast right up against whatever it is casting. Has this practice been changing a

Re: [patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers

2015-07-23 Thread Scott Feldman
On Thu, Jul 23, 2015 at 8:43 AM, Jiri Pirko wrote: > This patchset introduces Mellanox Technologies Switch driver infrastructure > and support for SwitchX-2 ASIC. > > The driver is divided into 3 logical parts: > 1) Bus - implements switch bus interface. Currently only PCI bus is >implemented,

[PATCH] e1000: make eeprom read/write scheduler friendly

2015-07-23 Thread Spencer Baugh
From: Joern Engel Code was responsible for ~150ms scheduler latencies. Signed-off-by: Joern Engel Signed-off-by: Spencer Baugh --- drivers/net/ethernet/intel/e1000/e1000_hw.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000/e10

Re: [PATCH v2 iproute2] tc: fix bpf compilation with old glibc

2015-07-23 Thread Alexei Starovoitov
On Thu, Jul 23, 2015 at 09:17:41AM +0200, Nicolas Dichtel wrote: > Error was: > f_bpf.o: In function `bpf_parse_opt': > f_bpf.c:(.text+0x88f): undefined reference to `secure_getenv' > m_bpf.o: In function `parse_bpf': > m_bpf.c:(.text+0x587): undefined reference to `secure_getenv' > collect2: error

Re: [PATCH net-next] ebpf: Allow dereferences of PTR_TO_STACK registers

2015-07-23 Thread Alexei Starovoitov
On Thu, Jul 23, 2015 at 02:24:40PM -0700, Alex Gartrell wrote: > mov %rsp, %r1 ; r1 = rsp > add $-8, %r1; r1 = rsp - 8 > store_q $123, -8(%rsp) ; *(u64*)r1 = 123 <- valid > store_q $123, (%r1) ; *(u64*)r1 = 123 <- previously invalid >

[PATCH net-next] ebpf: Allow dereferences of PTR_TO_STACK registers

2015-07-23 Thread Alex Gartrell
mov %rsp, %r1 ; r1 = rsp add $-8, %r1; r1 = rsp - 8 store_q $123, -8(%rsp) ; *(u64*)r1 = 123 <- valid store_q $123, (%r1) ; *(u64*)r1 = 123 <- previously invalid mov $0, %r0 exit; Always need to exit A

Re: [PATCH net-next] openvswitch: Retrieve tunnel metadata when receiving from vport-netdev

2015-07-23 Thread Pravin Shelar
On Thu, Jul 23, 2015 at 4:04 AM, Thomas Graf wrote: > Retrieve the tunnel metadata for packets received by a net_device and > provide it to ovs_vport_receive() for flow key extraction. > > [This hunk was in the GRE patch in the initial series and missed the > cut for the initial submission for me

Re: [patch net-next 3/4] mlxsw: Add interface to access registers and process events

2015-07-23 Thread Andy Gospodarek
On Thu, Jul 23, 2015 at 05:43:35PM +0200, Jiri Pirko wrote: > From: Ido Schimmel > > Add the ability to construct mailbox-style register access messages > called EMADs with provisions to construct and parse the registers payload. > Implement EMAD transaction layer which is responsible for the rel

[PATCH net-next 3/6] net/mlx5e: Support TX packet copy into WQE

2015-07-23 Thread Amir Vadai
From: Achiad Shochat AKA inline WQE. A TX latency optimization to save data gather DMA reads. Controlled by ETHTOOL_TX_COPYBREAK. Signed-off-by: Achiad Shochat Signed-off-by: Amir Vadai --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 + .../net/ethernet/mellanox/mlx5/core/en_ethto

[PATCH net-next 1/6] net/mlx5e: Support ETH_RSS_HASH_XOR

2015-07-23 Thread Amir Vadai
From: Saeed Mahameed The ConnectX-4 HW implements inverted XOR8. To make it act as XOR we re-order the HW RSS indirection table. Set XOR to be the default RSS hash function and add ethtool API to control it. Signed-off-by: Saeed Mahameed Signed-off-by: Amir Vadai --- drivers/net/ethernet/mel

[PATCH net-next 5/6] net/mlx5e: Cosmetics: use BIT() instead of "1 <<", and others

2015-07-23 Thread Amir Vadai
From: Achiad Shochat No logical change in this commit. Signed-off-by: Achiad Shochat Signed-off-by: Amir Vadai --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 16 +- .../ethernet/mellanox/mlx5/core/en_flow_table.c| 166 +++-- drivers/net/ethernet/mellanox/mlx5/co

[PATCH net-next 4/6] net/mlx5e: TX latency optimization to save DMA reads

2015-07-23 Thread Amir Vadai
From: Achiad Shochat A regular TX WQE execution involves two or more DMA reads - one to fetch the WQE, and another one per WQE gather entry. These DMA reads obviously increase the TX latency. There are two mlx5 mechanisms to bypass these DMA reads: 1) Inline WQE 2) Blue Flame (BF) An inline WQE

[PATCH net-next 2/6] net/mlx5e: Allocate DMA coherent memory on reader NUMA node

2015-07-23 Thread Amir Vadai
From: Saeed Mahameed By affinity hints and XPS, each mlx5e channel is assigned a CPU core. Channel DMA coherent memory that is written by the NIC and read by SW (e.g CQ buffer) is allocated on the NUMA node of the CPU core assigned for the channel. Channel DMA coherent memory that is written by

[PATCH net-next 6/6] net/mlx5e: Input IPSEC.SPI into the RX RSS hash function

2015-07-23 Thread Amir Vadai
From: Achiad Shochat In addition to the source/destination IP which are already hashed. Only for unicast traffic for now. Signed-off-by: Achiad Shochat Signed-off-by: Amir Vadai --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 4 + .../ethernet/mellanox/mlx5/core/en_flow_table.c|

[PATCH net-next 0/6] ConnectX-4 driver update 2015-07-23

2015-07-23 Thread Amir Vadai
Hi Dave, This patchset introduce some performance enhancements to the ConnectX-4 driver. 1. Improving RSS distribution, and make RSS function controlable using ethtool. 2. Make memory that is written by NIC and read by host CPU allocate in the local NUMA to the processing CPU 3. Support tx copy

[net-next PATCH v1 0/6] net: netcp: Bug fixes of CPSW statistics collection

2015-07-23 Thread WingMan Kwok
This patch set contains bug fixes and enhencements of hw ethernet statistics processing on TI's Keystone2 CPSW ethernet switches. v1: Removes unused defines in PATCH 3/6 based on reviewer's comment WingMan Kwok (6): net: netcp: Fixes the use of spin_lock_bh in timer function net: netcp: Fixes

[net-next PATCH v1 1/6] net: netcp: Fixes the use of spin_lock_bh in timer function

2015-07-23 Thread WingMan Kwok
This patch fixes a bug in which the timer routine synchronized against the ethtool-triggered statistics updates with spin_lock_bh(). A timer function is itself a bottom-half, so this should be spin_lock(). Signed-off-by: WingMan Kwok --- drivers/net/ethernet/ti/netcp_ethss.c |5 +++-- 1 file

[net-next PATCH v1 3/6] net: netcp: Fixes error in oversized memory allocation for statistics storage

2015-07-23 Thread WingMan Kwok
The CPSW driver keeps internally some, but not all, of the statistics available in the hw statistics modules. Furthermore, some of the locations in the hw statistics modules are reserved and contain no useful information. Prior to this patch, the driver allocates memory of the size of the the who

[net-next PATCH v1 2/6] net: netcp: Fixes hw statistics module base setting error

2015-07-23 Thread WingMan Kwok
This patch fixes error in the setting of the hw statistics module base for K2HK platform. In K2HK although there are 4 hw statistics modules, but only 2 are visible at a time. Thus when setting up the pointers to the base of the corresponding hw statistics modules, modules 0 and 2 should point to

[net-next PATCH v1 6/6] net: netcp: Adds missing statistics for K2L and K2E

2015-07-23 Thread WingMan Kwok
This patch adds the missing statistics for the host and slave ports of the CPSW on K2L and K2E platforms. Signed-off-by: WingMan Kwok --- drivers/net/ethernet/ti/netcp_ethss.c | 177 - 1 file changed, 174 insertions(+), 3 deletions(-) diff --git a/drivers/net/et

[net-next PATCH v1 5/6] net: netcp: Fixes to CPSW statistics collection

2015-07-23 Thread WingMan Kwok
In certain applications it's beneficial to allow the CPSW h/w stats counters to continue to increment even while the kernel polls them. This patch implements this behavior for both 1G and 10G ethernet subsystem modules. Signed-off-by: WingMan Kwok --- drivers/net/ethernet/ti/netcp_ethss.c | 86

[net-next PATCH v1 4/6] net: netcp: Consolidates statistics collection code

2015-07-23 Thread WingMan Kwok
Different Keystone2 platforms have different number and layouts of hw statistics modules. This patch consolidates the statistics processing of different Keystone2 platforms for easy maintenance. Signed-off-by: WingMan Kwok --- drivers/net/ethernet/ti/netcp_ethss.c | 99 ++-

Re: [patch net-next 4/4] mlxsw: Introduce Mellanox SwitchX-2 ASIC support

2015-07-23 Thread Jiri Pirko
Thu, Jul 23, 2015 at 07:19:46PM CEST, alexander.du...@gmail.com wrote: >On 07/23/2015 08:43 AM, Jiri Pirko wrote: >>From: Jiri Pirko >> >>Benefit from the previously introduced Mellanox Switch infrastructure and >>add driver for SwitchX-2 ASIC. Note that this driver is very simple now. >>It implem

Re: [PATCH] MIPS: Remove most of the custom gpio.h

2015-07-23 Thread Lars-Peter Clausen
On 07/22/2015 07:33 PM, Alban Bedel wrote: diff --git a/arch/mips/jz4740/gpio.c b/arch/mips/jz4740/gpio.c index 54c80d4..3dc500c 100644 --- a/arch/mips/jz4740/gpio.c +++ b/arch/mips/jz4740/gpio.c @@ -262,18 +262,6 @@ uint32_t jz_gpio_port_get_value(int port, uint32_t mask) } EXPORT_SYMBOL(jz_

[PATCH net v2] bridge: stp: when using userspace stp stop kernel hello and hold timers

2015-07-23 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov These should be handled only by the respective STP which is in control. They become problematic for devices with limited resources with many ports because the hold_timer is per port and fires each second and the hello timer fires each 2 seconds even though it's global. W

Re: [PATCH net] bridge: stp: when using userspace stp stop kernel hello and hold timers

2015-07-23 Thread Nikolay Aleksandrov
On 07/23/2015 07:13 PM, Stephen Hemminger wrote: > On Thu, 23 Jul 2015 19:05:56 +0200 > Nikolay Aleksandrov wrote: > >> On 07/23/2015 06:59 PM, Stephen Hemminger wrote: >>> On Thu, 23 Jul 2015 09:07:37 -0700 >>> Nikolay Aleksandrov wrote: >>> + /* Stop hello and hold timer */ >>

Re: [patch net-next 4/4] mlxsw: Introduce Mellanox SwitchX-2 ASIC support

2015-07-23 Thread Alexander Duyck
On 07/23/2015 08:43 AM, Jiri Pirko wrote: From: Jiri Pirko Benefit from the previously introduced Mellanox Switch infrastructure and add driver for SwitchX-2 ASIC. Note that this driver is very simple now. It implements bare minimum for getting device to work on slow-path. Fast-path offload fun

[PULL v2] virtio/vhost: fixes for 4.2

2015-07-23 Thread Michael S. Tsirkin
Really same as previous pull, but as a problem was found in that one, I rebased and fixed. The following changes since commit 59a5b0f7bf74f88da6670bcbf924d8cc1e75b1ee: virtio-pci: alloc only resources actually used. (2015-06-24 08:15:09 +0200) are available in the git repository at: git://g

Re: [PATCH net] bridge: stp: when using userspace stp stop kernel hello and hold timers

2015-07-23 Thread Stephen Hemminger
On Thu, 23 Jul 2015 19:05:56 +0200 Nikolay Aleksandrov wrote: > On 07/23/2015 06:59 PM, Stephen Hemminger wrote: > > On Thu, 23 Jul 2015 09:07:37 -0700 > > Nikolay Aleksandrov wrote: > > > >> + /* Stop hello and hold timer */ > >> + spin_lock_bh(&br->lock); > >> + d

Re: [PATCH net] bridge: stp: when using userspace stp stop kernel hello and hold timers

2015-07-23 Thread Nikolay Aleksandrov
On 07/23/2015 06:59 PM, Stephen Hemminger wrote: > On Thu, 23 Jul 2015 09:07:37 -0700 > Nikolay Aleksandrov wrote: > >> +/* Stop hello and hold timer */ >> +spin_lock_bh(&br->lock); >> +del_timer(&br->hello_timer); >> +list_for_each_entry(p, &br->po

Re: [PATCH net] bridge: stp: when using userspace stp stop kernel hello and hold timers

2015-07-23 Thread Stephen Hemminger
On Thu, 23 Jul 2015 09:07:37 -0700 Nikolay Aleksandrov wrote: > + /* Stop hello and hold timer */ > + spin_lock_bh(&br->lock); > + del_timer(&br->hello_timer); > + list_for_each_entry(p, &br->port_list, list) > + del_timer(&p->ho

[PATCH net] bridge: stp: when using userspace stp stop kernel hello and hold timers

2015-07-23 Thread Nikolay Aleksandrov
From: Satish Ashok Stop the kernel STP hello and hold timers when user-space STP is being used to stop generating both packets. These should be handled only by the respective STP which is in control. Also ensure that when the bridge is up these timers are started only when running with kernel STP

Re: [PATCH net-next] route: allow to route in a peer netns via lwt framework

2015-07-23 Thread roopa
On 7/23/15, 8:25 AM, Nicolas Dichtel wrote: Le 23/07/2015 17:01, roopa a écrit : On 7/23/15, 7:22 AM, Nicolas Dichtel wrote: [snip] +static inline u32 *lwt_netns_info(struct lwtunnel_state *lwtstate) +{ +return (u32 *)lwtstate->data; +} + +static inline int skb_lwt_netns_info(struct sk_buf

[patch net-next 2/4] mlxsw: Add PCI bus implementation

2015-07-23 Thread Jiri Pirko
From: Jiri Pirko Add PCI bus implementation for Mellanox Technologies Switch ASICs. This includes firmware initialization, async queues manipulation and command interface implementation. Signed-off-by: Jiri Pirko Signed-off-by: Ido Schimmel Signed-off-by: Elad Raz --- drivers/net/ethernet/me

[patch net-next 3/4] mlxsw: Add interface to access registers and process events

2015-07-23 Thread Jiri Pirko
From: Ido Schimmel Add the ability to construct mailbox-style register access messages called EMADs with provisions to construct and parse the registers payload. Implement EMAD transaction layer which is responsible for the reliable transmission of EMADs. Also, add an infrastructure used by the s

[patch net-next 4/4] mlxsw: Introduce Mellanox SwitchX-2 ASIC support

2015-07-23 Thread Jiri Pirko
From: Jiri Pirko Benefit from the previously introduced Mellanox Switch infrastructure and add driver for SwitchX-2 ASIC. Note that this driver is very simple now. It implements bare minimum for getting device to work on slow-path. Fast-path offload functionality is going to be added soon. Signe

[patch net-next 1/4] mlxsw: Introduce Mellanox switch driver core

2015-07-23 Thread Jiri Pirko
From: Jiri Pirko Add core components of Mellanox switch driver infrastructure. Core infrastructure is designed so that it can be used by multiple bus drivers (PCI now, I2C and SGMII are planned to be implemented in the future). Multiple switch kind drivers can be registered as well. This core ser

[patch net-next 0/4] Introduce Mellanox Technologies Switch ASICs switchdev drivers

2015-07-23 Thread Jiri Pirko
This patchset introduces Mellanox Technologies Switch driver infrastructure and support for SwitchX-2 ASIC. The driver is divided into 3 logical parts: 1) Bus - implements switch bus interface. Currently only PCI bus is implemented, but more buses will be added in the future. Namely I2C and

Re: [PATCH] net: via/Kconfig: GENERIC_PCI_IOMAP required if PCI not selected

2015-07-23 Thread Alexey Charkov
2015-07-23 4:35 GMT+03:00 Antonio Borneo : > On Thu, Jul 23, 2015 at 2:08 AM, David Miller wrote: >> From: Antonio Borneo >> Date: Thu, 23 Jul 2015 00:34:14 +0800 >> >>> - depends on (PCI || OF_IRQ) >>> + depends on (PCI || (OF_IRQ && GENERIC_PCI_IOMAP)) >> >> Having GENERIC_PCI_IOMAP wit

Re: [PATCH net-next] route: allow to route in a peer netns via lwt framework

2015-07-23 Thread Nicolas Dichtel
Le 23/07/2015 17:01, roopa a écrit : On 7/23/15, 7:22 AM, Nicolas Dichtel wrote: [snip] +static inline u32 *lwt_netns_info(struct lwtunnel_state *lwtstate) +{ +return (u32 *)lwtstate->data; +} + +static inline int skb_lwt_netns_info(struct sk_buff *skb) +{ +if (skb->protocol == htons(ET

pull request: bluetooth 2015-07-23

2015-07-23 Thread Johan Hedberg
Hi Dave, Here's another one-patch pull request for 4.2 which targets a potential NULL pointer dereference in the LE Security Manager code that can be triggered by using older user space tools. The issue has been there since 4.0 so there's the appropriate "Cc: stable" in place. Let me know if ther

Re: [PATCH net-next] route: allow to route in a peer netns via lwt framework

2015-07-23 Thread roopa
On 7/23/15, 7:22 AM, Nicolas Dichtel wrote: This patch takes advantage of the newly added lwtunnel framework to allow the user to set routes that points to a peer netns. Packets are injected to the peer netns via the loopback device. It works only when the output device is 'lo'. Example: ip rou

[PATCH net v3] macvtap: fix network header pointer for VLAN tagged pkts

2015-07-23 Thread Ivan Vecera
Network header is set with offset ETH_HLEN but it is not true for VLAN (multiple-)tagged and results in checksum issues in lower devices. v2: leave skb->protocol untouched (thx Vlad), comment added v3: moved after skb_probe_transport_header() call (thx Toshiaki) Signed-off-by: Ivan Vecera --- d

[PATCH net-next] route: allow to route in a peer netns via lwt framework

2015-07-23 Thread Nicolas Dichtel
This patch takes advantage of the newly added lwtunnel framework to allow the user to set routes that points to a peer netns. Packets are injected to the peer netns via the loopback device. It works only when the output device is 'lo'. Example: ip route add 40.1.1.1/32 encap netns nsid 5 via dev

Re: [PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM

2015-07-23 Thread Jeff Kirsher
On Wed, 2015-07-22 at 11:41 +1000, Michael Ellerman wrote: > On Wed, 2015-07-15 at 03:30 -0700, Jeff Kirsher wrote: > > On Tue, 2015-07-14 at 13:54 +1000, Michael Ellerman wrote: > > > e1000e_disable_aspm_locked() is only used in __e1000_resume() > which is > > > inside CONFIG_PM. So when CONFIG_PM

[Patch v2 resend 2/2] net: fec: introduce fec_ptp_stop and use in probe fail path

2015-07-23 Thread Lucas Stach
This function frees resources and cancels delayed work item that have been initialized in fec_ptp_init(). Use this to do proper error handling if something goes wrong in probe function after fec_ptp_init has been called. Signed-off-by: Lucas Stach Acked-by: Fugang Duan --- drivers/net/ethernet

[Patch v2 resend 1/2] net: fec: use managed DMA API functions to allocate BD ring

2015-07-23 Thread Lucas Stach
So it gets freed when the device is going away. This fixes a DMA memory leak on driver probe() fail and driver remove(). Signed-off-by: Lucas Stach --- v2: Fix indentation of second line to fix alignment with opening bracket. --- drivers/net/ethernet/freescale/fec_main.c | 4 ++-- 1 file changed

Re: [net-next PATCH v0 3/6] net: netcp: Fixes error in oversized memory allocation for statistics storage

2015-07-23 Thread Murali Karicheri
On 07/23/2015 09:32 AM, WingMan Kwok wrote: The CPSW driver keeps internally some, but not all, of the statistics available in the hw statistics modules. Furthermore, some of the locations in the hw statistics modules are reserved and contain no useful information. Prior to this patch, the driv

[net-next 05/15] igb: bump version to igb-5.3.0

2015-07-23 Thread Jeff Kirsher
From: Todd Fujinaka Signed-off-by: Todd Fujinaka Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/igb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb

[net-next 09/15] i40e/i40evf: add macros for virtual channel API version and device capability

2015-07-23 Thread Jeff Kirsher
From: Mitch Williams Now that we've rolled the virtual channel API version to 1.1, add some macros to test what version is being used by our partner in crime. For the VF, add some macros to determine what our device capabilities are. Change-ID: I79f6683d4c23bd76a8ad9fd492776fcc1208e1dc Signed-of

[net-next 14/15] i40e: clean up error status messages

2015-07-23 Thread Jeff Kirsher
From: Shannon Nelson Clean up a little confusion in reporting error status in phy and fcoe setup error reports by separating the return status from the AQ error. Add two decoder functions to make this easier. Change-ID: I960bcdeef3978a15fec1cdb5eff781d5cbae42fb Signed-off-by: Shannon Nelson Te

[net-next 12/15] i40evf: support virtual channel API version 1.1

2015-07-23 Thread Jeff Kirsher
From: Mitch Williams Store off the PF's API version, then use it to determine whether or not to send it our capabilities. Change the version checking to allow for PF drivers with lower API versions than our current version, so we can still talk to PF drivers over the 1.0 API. Change-ID: I8edc55d

[net-next 15/15] i40e: use BIT and BIT_ULL macros

2015-07-23 Thread Jeff Kirsher
From: Jesse Brandeburg Use macros for abstracting (1 << foo) to BIT(foo) and (1ULL << foo64) to BIT_ULL(foo64) in order to match better with kernel requirements. NOTE: the adminq_cmd.h file was not modified on purpose because of the dependency upon firmware for that file. Change-ID: I73ee2e48c8

[net-next 07/15] i40e: clean up unneeded gotos

2015-07-23 Thread Jeff Kirsher
From: Shannon Nelson With a little work we can clean up some unnecessary logic jumping and drop a variable. Signed-off-by: Shannon Nelson Cc: Laurent Navet Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_hmc.c | 37 ++ 1 file changed, 12 inser

[net-next 10/15] i40e: support virtual channel API 1.1

2015-07-23 Thread Jeff Kirsher
From: Mitch Williams Store off the VF API version for use when figuring out the VF driver capabilities. Add support for the VF driver handing its capabilities to the PF driver and then use this information when sending VF resource information back to the VF driver. Change-ID: Ic00d0eeeb5b8118085

[net-next 11/15] i40evf: handle big resets

2015-07-23 Thread Jeff Kirsher
From: Mitch Williams The most common type of reset that the VF will encounter is a PF reset that cascades down into a VF reset for each VF. In this case, the VF will always be assigned the same VSI and recovery is fairly simple. However, in the case of 'bigger' resets, such as a Core or EMP rese

[net-next 13/15] i40e: provide correct API version to older VF drivers

2015-07-23 Thread Jeff Kirsher
From: Mitch Williams This driver fully supports VF drivers using both the 1.0 and 1.1 versions of the virtual channel API. However, VF drivers using version 1.0 get upset if we provide them with a version other than that, and refuse to play with us. Correct this by checking the VFs API version a

[net-next 08/15] i40e: add VF capabilities to virtual channel interface

2015-07-23 Thread Jeff Kirsher
From: Mitch Williams To prepare for the changes coming up in the X722 device and future devices, the virtual channel interface has to change slightly. The VF driver can now report what its capable of supporting, which then informs the PF driver when it sends the configuration information back to

[net-next 04/15] igb: use ARRAY_SIZE to replace calculating sizeof(a)/sizeof(a[0])

2015-07-23 Thread Jeff Kirsher
From: Todd Fujinaka Use the ARRAY_SIZE macro rather than calculating sizeof(a)/sizeof(a[0]). Also directly replace the code rather than using an unnecessary define. Reported-by: Maninder Singh Reported-by: Joe Perches Signed-off-by: Todd Fujinaka Tested-by: Aaron Brown Signed-off-by: Jeff Ki

[net-next 03/15] igb: report unsupported ethtool settings in set_coalesce

2015-07-23 Thread Jeff Kirsher
From: Todd Fujinaka There are many settings possible using ethtool -C/--coalesce, but not all of them are supported in igb. Report failure when an unsupported option is set. Signed-off-by: Todd Fujinaka Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/igb

[net-next 00/15][pull request] Intel Wired LAN Driver Updates 2015-07-23

2015-07-23 Thread Jeff Kirsher
This series contains updates to e1000e, igb, ixgbevf, i40e and i40evf. Emil extends the reporting of the RSS key and hash table by adding support for x550 VFs. Jia-Ju Bai fixes a QoS issue in e1000e where the error handling lacked a call to pm_qos_remove_request() to cleanup the QoS request made

[net-next 06/15] i40e/i40evf: Fix and refactor dynamic ITR code

2015-07-23 Thread Jeff Kirsher
From: Carolyn Wyborny This patch changes the switch statement for dynamic interrupt throttling and adds a default case. With this patch, we check the latency setting instead of the current ITR settings and the included refactor improves performance. Without this patch, the ITR setting would neve

[net-next 01/15] ixgbevf: add support for reporting RSS key and hash table for X550

2015-07-23 Thread Jeff Kirsher
From: Emil Tantilov This patch extends the reporting of the RSS key and hash table by adding support for X550 VFs. The difference is that X550 VFs have their own registers for RSS key and indirection table, so there is no need to query the PF. The RSS key and indirection table are stored in the

[net-next 02/15] e1000e: Cleanup qos request in error handling of e1000_open

2015-07-23 Thread Jeff Kirsher
From: Jia-Ju Bai The driver lacks pm_qos_remove_request in error handling (err_req_irq) of e1000_open, and qos request inserted by pm_qos_add_request is not removed. This patch add pm_qos_remove_request in error handling to fix it. Signed-off-by: Jia-Ju Bai Tested-by: Aaron Brown Signed-off-by

Re: [PATCH net-next] lwtunnel: export linux/lwtunnel.h to userspace

2015-07-23 Thread roopa
On 7/23/15, 6:43 AM, Nicolas Dichtel wrote: Note also that include/linux/lwtunnel.h is not needed. CC: Thomas Graf CC: Roopa Prabhu Fixes: 499a24256862 ("lwtunnel: infrastructure for handling light weight tunnels like mpls") Signed-off-by: Nicolas Dichtel Acked-by: Roopa Prabhu Thanks. -

Re: [PATCH net-next] af_mpls: fix undefined reference to ip6_route_output

2015-07-23 Thread roopa
On 7/23/15, 12:09 AM, David Miller wrote: From: roopa Date: Wed, 22 Jul 2015 13:38:31 -0700 I cant think of a way to fix the current problem with my patch... I guess it's not obvious that adding CONFIG_MPLS_IPV6 would solve the problem perfectly. I thought that was not an option because CONF

[PATCH net-next] lwtunnel: export linux/lwtunnel.h to userspace

2015-07-23 Thread Nicolas Dichtel
Note also that include/linux/lwtunnel.h is not needed. CC: Thomas Graf CC: Roopa Prabhu Fixes: 499a24256862 ("lwtunnel: infrastructure for handling light weight tunnels like mpls") Signed-off-by: Nicolas Dichtel --- include/linux/lwtunnel.h | 6 -- include/uapi/linux/Kbuild | 1 + 2 file

[net-next PATCH v0 2/6] net: netcp: Fixes hw statistics module base setting error

2015-07-23 Thread WingMan Kwok
This patch fixes error in the setting of the hw statistics module base for K2HK platform. In K2HK although there are 4 hw statistics modules, but only 2 are visible at a time. Thus when setting up the pointers to the base of the corresponding hw statistics modules, modules 0 and 2 should point to

[net-next PATCH v0 1/6] net: netcp: Fixes the use of spin_lock_bh in timer function

2015-07-23 Thread WingMan Kwok
This patch fixes a bug in which the timer routine synchronized against the ethtool-triggered statistics updates with spin_lock_bh(). A timer function is itself a bottom-half, so this should be spin_lock(). Signed-off-by: WingMan Kwok --- drivers/net/ethernet/ti/netcp_ethss.c |5 +++-- 1 file

[net-next PATCH v0 3/6] net: netcp: Fixes error in oversized memory allocation for statistics storage

2015-07-23 Thread WingMan Kwok
The CPSW driver keeps internally some, but not all, of the statistics available in the hw statistics modules. Furthermore, some of the locations in the hw statistics modules are reserved and contain no useful information. Prior to this patch, the driver allocates memory of the size of the the who

[net-next PATCH v0 6/6] net: netcp: Adds missing statistics for K2L and K2E

2015-07-23 Thread WingMan Kwok
This patch adds the missing statistics for the host and slave ports of the CPSW on K2L and K2E platforms. Signed-off-by: WingMan Kwok --- drivers/net/ethernet/ti/netcp_ethss.c | 177 - 1 file changed, 174 insertions(+), 3 deletions(-) diff --git a/drivers/net/et

[net-next PATCH v0 4/6] net: netcp: Consolidates statistics collection code

2015-07-23 Thread WingMan Kwok
Different Keystone2 platforms have different number and layouts of hw statistics modules. This patch consolidates the statistics processing of different Keystone2 platforms for easy maintenance. Signed-off-by: WingMan Kwok --- drivers/net/ethernet/ti/netcp_ethss.c | 99 ++-

[net-next PATCH v0 5/6] net: netcp: Fixes to CPSW statistics collection

2015-07-23 Thread WingMan Kwok
In certain applications it's beneficial to allow the CPSW h/w stats counters to continue to increment even while the kernel polls them. This patch implements this behavior for both 1G and 10G ethernet subsystem modules. Signed-off-by: WingMan Kwok --- drivers/net/ethernet/ti/netcp_ethss.c | 86

[net-next PATCH v0 0/6] net: netcp: Bug fixes of CPSW statistics collection

2015-07-23 Thread WingMan Kwok
This patch set contains bug fixes and enhencements of hw ethernet statistics processing on TI's Keystone2 CPSW ethernet switches. WingMan Kwok (6): net: netcp: Fixes the use of spin_lock_bh in timer function net: netcp: Fixes hw statistics module base setting error net: netcp: Fixes error in

  1   2   >