From: Peter Chen Sent: Wednesday, July 22, 2015 1:45
PM
> To: netdev@vger.kernel.org
> Cc: Andrew Lunn; Duan Fugang-B38611; David S. Miller
> Subject: A Regression between v4.2-rc2 and v4.2-rc3
>
> Hi List,
>
> I run out a kernel oops [2] for nfsroot at several imx6 boards when
> rebase to v4.2
Hi List,
I run out a kernel oops [2] for nfsroot at several imx6 boards
when rebase to v4.2-rc3, after revert below patch [1], it is ok.
This patch is just adding runtime pm for ipg clock, I am wonder
why it takes as a bug fix.
[1]
commit 6c3e921b18edca290099adfddde8a50236bf2d80
Author: Andrew Lu
On Tue, Jul 21, 2015 at 9:21 PM, Lawrence Brakmo wrote:
> This is a request for comments.
>
> TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of
> NV was presented at 2010's LPC (slides). It is a delayed based
> congestion avoidance for the data center. This version has been
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: 0b2c2a931a051e75f9df429b520bb2c2f2bb056b
commit: 01faef2cebae02685e2bcfc9bbee8416d5ec19fc [83/84] mpls: make RTA_OIF
optional
config: i386-randconfig-n1-201529 (attached as .config)
reproduce:
git checkout 01
Devices with up-to-date management FW will be able to store register dumps
on their persistent storage - in case management FW identifies a fatal
error it would gather and store such dumps, which could later be retrieved
using specific debug tools.
This patch adds the necessary part in the driver
Signed-off-by: Yuval Mintz
Signed-off-by: Ariel Elior
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
b/drivers/net/ethernet/broadcom/bnx2x/bnx2x.h
index 2fe3563..a1f9785 100644
--- a
From: Yaniv Rosner
This adds support to a new copper phy.
Signed-off-by: Yaniv Rosner
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h | 3 +
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 244 ++-
drivers/net/ethernet/broadcom/bnx2x/bn
This patch series does several things - it updates the bnx2x FW into
7.12.30 which both contains some small fixes as well as opening the door
for several new features for the device - mainly vxlan/geneve offloads
and vlan filtering offload.
It then adds a new Multi-function mode [BD] which requires
This moves bnx2x into using 7.12.30 FW. Said firmware fixes the following:
- Packets from a VF with pvid configured which were sent with a
different vlan were transmitted instead of being discarded.
- FCoE traffic might not recover after a failue while there's traffic
to another function.
This adds support to a new multi-function mode, enabling driver to
initialize such devices and correctly interacting with management FW
for fully utilizing their features.
Signed-off-by: Yuval Mintz
Signed-off-by: Ariel Elior
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x.h| 3 +
driver
bnx2x still appears as a Broadcom driver even though the devices it
utilizes belong to Qlogic for more than a year.
This patch changes the various headers and the device strings to indicate
the correct ownership of the device.
Signed-off-by: Yuval Mintz
Signed-off-by: Ariel Elior
---
drivers/n
On 7/21/15, 9:57 PM, Rami Rosen wrote:
This patch fixes setting of vinfo.flags in the br_fill_ifvlaninfo_range()
method. The
assignment of vinfo.flags &= ~BRIDGE_VLAN_INFO_RANGE_BEGIN has no effect and is
unneeded, as vinfo.flags value is overriden by the immediately following
vinfo.flags = fla
From: Roopa Prabhu
fix for:
net/mpls/mpls_iptunnel.c:73:19: sparse: incompatible types in comparison
expression (different address spaces)
remove incorrect rcu_dereference possibly left over from
earlier revisions of the code.
Reported-by: kbuild test robot
Signed-off-by: Roopa Prabhu
---
ne
From: Sriharsha Basavapatna
Add be_get_phys_port_id() function to report physical port id. The port id
should be unique across different be2net devices in the system. We use the
chip serial number along with the physical port number for this.
Signed-off-by: Sriharsha Basavapatna
---
drivers/ne
On Tue, 2015-07-21 at 21:21 -0700, Lawrence Brakmo wrote:
> Replace 2 arguments (cnt and rtt) in the congestion control modules'
> pkts_acked() function with a struct. This will allow adding more
> information without having to modify existing congestion control
> modules (tcp_nv in particular need
From: r...@tardy.usa.hp.com (Rick Jones)
Date: Tue, 21 Jul 2015 16:14:13 -0700 (PDT)
> From: Rick Jones
>
> Track success and failure of TCP PMTU probing.
>
> Signed-off-by: Rick Jones
Seems reasonable, applied, thanks Rick.
--
To unsubscribe from this list: send the line "unsubscribe netdev"
From: Sergei Shtylyov
Date: Wed, 22 Jul 2015 01:31:59 +0300
> The driver is written as if it can adapt to a low memory situation allocating
> less RX skbs and TX aligned buffers than the respective RX/TX ring sizes. In
> reality though the driver would malfunction in this case. Stop being o
From: Hariprasad Shenai
Date: Tue, 21 Jul 2015 22:39:40 +0530
> Add debugfs entry 'use_backdoor' to enable backdoor access to read sge
> context. By default, we read sge context's via firmware. In case of FW
> issues, one can enable backdoor access via debugfs to dump sge context
> for debugging
From: Dan Murphy
Date: Tue, 21 Jul 2015 12:06:45 -0500
> Fix warning: logical ‘or’ of collectively exhaustive tests is always true
>
> Change the internal delay check from an 'or' condition to an 'and'
> condition.
>
> Reported-by: David Binderman
> Signed-off-by: Dan Murphy
Applied, thanks.
From: Konstantin Khlebnikov
Date: Tue, 21 Jul 2015 19:46:29 +0300
> @@ -23,7 +23,8 @@ static inline struct cgroup_cls_state *css_cls_state(struct
> cgroup_subsys_state
>
> struct cgroup_cls_state *task_cls_state(struct task_struct *p)
> {
> - return css_cls_state(task_css(p, net_cls_cgrp
From: Roopa Prabhu
Date: Tue, 21 Jul 2015 09:16:24 -0700
> From: Roopa Prabhu
>
> If user did not specify an oif, try and get it from the via address.
> If failed to get device, return with -ENODEV.
>
> Signed-off-by: Roopa Prabhu
Applied, thanks.
--
To unsubscribe from this list: send the l
From: Chris J Arges
Date: Tue, 21 Jul 2015 12:36:33 -0500
> Some architectures like POWER can have a NUMA node_possible_map that
> contains sparse entries. This causes memory corruption with openvswitch
> since it allocates flow_cache with a multiple of num_possible_nodes() and
> assumes the node
From: Florian Westphal
Date: Tue, 21 Jul 2015 16:33:50 +0200
> Kirill A. Shutemov says:
>
> This simple test-case trigers few locking asserts in kernel:
...
> Cong Wang says:
>
> We can't hold mutex lock in a rcu callback, [..]
>
> Thomas Graf says:
>
> The socket should be dead at this poin
From: Edward Cree
Date: Tue, 21 Jul 2015 15:07:44 +0100
> Recent versions of firmware for SFC9100 adapters add support for filter
> chaining, in which packets matching multiple filters are delivered to all
> filters' recipients, rather than only the highest match-priority filter as
> was
> pr
From: Nicolas Schichan
Date: Tue, 21 Jul 2015 14:14:11 +0200
> These patches are fixing bugs in the ARM JIT and should probably find
> their way to a stable kernel. All 60 test_bpf tests in Linux 4.1 release
> are now passing OK (was 54 out of 60 before).
Series applied, thanks.
--
To unsubscrib
From: Eric Dumazet
Date: Wed, 22 Jul 2015 07:02:00 +0200
> From: Eric Dumazet
>
> Andrew Morton reported following warning on one ARM build
> with gcc-4.4 :
>
> net/ipv4/inet_hashtables.c: In function 'inet_ehash_locks_alloc':
> net/ipv4/inet_hashtables.c:617: warning: division by zero
>
> Ev
From: Eric Dumazet
Andrew Morton reported following warning on one ARM build
with gcc-4.4 :
net/ipv4/inet_hashtables.c: In function 'inet_ehash_locks_alloc':
net/ipv4/inet_hashtables.c:617: warning: division by zero
Even guarded with a test on sizeof(spinlock_t), compiler does not
like current
This patch fixes setting of vinfo.flags in the br_fill_ifvlaninfo_range()
method. The
assignment of vinfo.flags &= ~BRIDGE_VLAN_INFO_RANGE_BEGIN has no effect and is
unneeded, as vinfo.flags value is overriden by the immediately following
vinfo.flags = flags | BRIDGE_VLAN_INFO_RANGE_END assignem
On Tue, 2015-07-21 at 19:03 -0700, Cong Wang wrote:
> On Tue, Jul 21, 2015 at 1:57 PM, Eric Dumazet wrote:
> > On Tue, 2015-07-21 at 11:12 -0700, Cong Wang wrote:
> >
> >> > - kfree_skb(skb);
> >> > + INIT_LIST_HEAD(&q->new_flows);
> >> > + INIT_LIST_HEAD(&q->old_flows);
When zones were originally introduced, the expectation functions were
all extended to perform lookup using the zone. However, insertion was
not modified to check the zone. This means that two expectations which
are intended to apply for different connections that have the same tuple
but exist in di
This is a request for comments.
TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of
NV was presented at 2010's LPC (slides). It is a delayed based
congestion avoidance for the data center. This version has been tested
within a 10G rack where the HW RTTs are 20-50us.
A descrip
Replace 2 arguments (cnt and rtt) in the congestion control modules'
pkts_acked() function with a struct. This will allow adding more
information without having to modify existing congestion control
modules (tcp_nv in particular needs bytes in flight when packet
was sent).
This was proposed by Nea
Based on comments by Neal Cardwell to tcp_nv patch:
AFAICT this patch would not require an increase in the size of sk_buff
cb[] if it were to take advantage of the fact that the tcp_skb_cb
header.h4 and header.h6 fields are only used in the packet reception
code path, and this in_flight fi
This patchset adds support for NV congestion control.
The first patch replaces two arguments in the pkts_acked() function
of the congestion control modules with a struct, making it easier to
add more parameters later without modifying the existing congestion
control modules.
The second patch adds
Hello,
On Tue, 21 Jul 2015, Martin KaFai Lau wrote:
> The patch checks neigh->nud_state before acquiring the writer lock.
> Note that rt6_probe() is only used in CONFIG_IPV6_ROUTER_PREF.
Locking usage is absolutely correct.
> + if (!(neigh->nud_state & NUD_VALID) &&
During hwsim_init_netlink(), we should call genl_unregister_family()
if failed on netlink_register_notifier() since the genetlink is
already registered.
Signed-off-by: Su Kang Yin
---
drivers/net/wireless/mac80211_hwsim.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/dri
On Tue, Jul 21, 2015 at 07:00:40PM -0700, Alex Gartrell wrote:
> mov %rsp, %r1 ; r1 = rsp
> add $-8, %r1; r1 = rsp - 8
> store_q $123, -8(%rsp) ; *(u64*)r1 = 123 <- valid
> store_q $123, (%r1) ; *(u64*)r1 = 123 <- previously invalid
>
Hi,
Martin KaFai Lau wrote:
> The patch checks neigh->nud_state before acquiring the writer lock.
> Note that rt6_probe() is only used in CONFIG_IPV6_ROUTER_PREF.
You have to take "some" lock when accessing neigh->nud_state
theoretically.
>
> I also take this chance to re-arrange the code.
No,
On Tue, Jul 21, 2015 at 1:57 PM, Eric Dumazet wrote:
> On Tue, 2015-07-21 at 11:12 -0700, Cong Wang wrote:
>
>> > - kfree_skb(skb);
>> > + INIT_LIST_HEAD(&q->new_flows);
>> > + INIT_LIST_HEAD(&q->old_flows);
>> > + for (i = 0; i < q->flows_cnt; i++) {
>> > +
mov %rsp, %r1 ; r1 = rsp
add $-8, %r1; r1 = rsp - 8
store_q $123, -8(%rsp) ; *(u64*)r1 = 123 <- valid
store_q $123, (%r1) ; *(u64*)r1 = 123 <- previously invalid
mov $0, %r0
exit; Always need to exit
A
From: Lucas Stach Sent: Tuesday, July 21, 2015 11:11 PM
> To: David S. Miller
> Cc: Duan Fugang-B38611; Li Frank-B20596; netdev@vger.kernel.org;
> ker...@pengutronix.de; patchwork-...@pengutronix.de
> Subject: [PATCH v2 2/2] net: fec: introduce fec_ptp_stop and use in probe
> fail path
>
> This f
From: Lucas Stach Sent: Tuesday, July 21, 2015 11:11 PM
> To: David S. Miller
> Cc: Duan Fugang-B38611; Li Frank-B20596; netdev@vger.kernel.org;
> ker...@pengutronix.de; patchwork-...@pengutronix.de
> Subject: [PATCH v2 1/2] net: fec: use managed DMA API functions to
> allocate BD ring
>
> So it
On Wed, 2015-07-15 at 03:30 -0700, Jeff Kirsher wrote:
> On Tue, 2015-07-14 at 13:54 +1000, Michael Ellerman wrote:
> > e1000e_disable_aspm_locked() is only used in __e1000_resume() which is
> > inside CONFIG_PM. So when CONFIG_PM=n we get a "defined but not used"
> > warning for e1000e_disable_asp
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: 16040894b26af9f85d9395f072c53d76a44eba21
commit: 614732eaa12dd462c0ab274700bed14f36afea5e [200/208] openvswitch: Use
regular VXLAN net_device device
reproduce:
# apt-get install sparse
git checkout 614732ea
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: 16040894b26af9f85d9395f072c53d76a44eba21
commit: e3e4712ec0961ed586a8db340bd994c4ad7f5dba [187/208] mpls: ip tunnel
support
reproduce:
# apt-get install sparse
git checkout e3e4712ec0961ed586a8db340bd994c4a
Signed-off-by: Cong Wang
---
net/sched/sch_choke.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/net/sched/sch_choke.c b/net/sched/sch_choke.c
index 93d5742..6a783af 100644
--- a/net/sched/sch_choke.c
+++ b/net/sched/sch_choke.c
@@ -385,6 +385,19 @@ static void choke_reset(st
The patch checks neigh->nud_state before acquiring the writer lock.
Note that rt6_probe() is only used in CONFIG_IPV6_ROUTER_PREF.
I also take this chance to re-arrange the code.
40 udpflood processes and a /64 gateway route are used.
The gateway has NUD_PERMANENT. Each of them is run for 30s.
A
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: 16040894b26af9f85d9395f072c53d76a44eba21
commit: e7030878fc8448492b6e5cecd574043f63271298 [195/208] fib: Add fib rule
match on tunnel id
config: i386-randconfig-r0-201529 (attached as .config)
reproduce:
git
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: 16040894b26af9f85d9395f072c53d76a44eba21
commit: 3093fbe7ff4bc7d1571fc217dade1cf80330a714 [194/208] route: Per route IP
tunnel metadata via lightweight tunnel
config: i386-randconfig-i0-201529 (attached as .con
Otherwise the skbuff related structures are not correctly
refcount'ed.
Cc: Jamal Hadi Salim
Signed-off-by: Cong Wang
---
net/sched/sch_plug.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sched/sch_plug.c b/net/sched/sch_plug.c
index 89f8fcf..ade9445 100644
--- a/net/sched/sch_plug.c
From: Jon Maloy
Date: Tue, 21 Jul 2015 06:42:28 -0400
> In commit d999297c3dbbe7fdd832f7fa4ec84301e170b3e6
> ("tipc: reduce locking scope during packet reception") we introduced
> a new function tipc_link_proto_rcv(). This function contains a bug,
> so that it sometimes by error sends out a non-z
From: Rick Jones
Track success and failure of TCP PMTU probing.
Signed-off-by: Rick Jones
---
Tested by loading-up into an OpenStack instance and kicking the MTU
out from under it in the corresponding router namespace.
diff --git a/include/uapi/linux/snmp.h b/include/uapi/linux/snmp.h
index
From: Florian Fainelli
Date: Mon, 20 Jul 2015 17:49:54 -0700
> Changes in v5:
>
> - removed an invalid use of the link_update callback in the SF2 driver
> was appeared after merging "net: phy: fixed_phy: handle link-down case"
>
> - reworded the commit message for patch 2 to make it clear wha
From: Kalle Valo
Date: Mon, 20 Jul 2015 18:36:30 +0300
> here are few fixes for 4.2, should not have anything out of ordinary.
> Please let me know if there are any issues.
Pulled, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@
From: Erik Kline
Date: Mon, 20 Jul 2015 16:06:34 +0200
> I thought perhaps "use_oif_addr_only" was a slightly clearer sysctl name.
>
> (Maybe it should be plural, "use_oif_addrs_only"?)
I think plural would be better too, please respin with that change.
Thanks.
--
To unsubscribe from this list
From: Mathias Krause
Date: Sun, 19 Jul 2015 22:21:13 +0200
> The sk_classid member is only required when CONFIG_CGROUP_NET_CLASSID is
> enabled. #ifdefify it to reduce the size of struct sock on 32 bit
> systems, at least.
>
> Signed-off-by: Mathias Krause
> ---
> v2:
> - ensure we'll error out
The driver is written as if it can adapt to a low memory situation allocating
less RX skbs and TX aligned buffers than the respective RX/TX ring sizes. In
reality though the driver would malfunction in this case. Stop being overly
smart and just fail in such situation -- this is achieved by m
On 21.07.2015 [11:30:58 -0500], Chris J Arges wrote:
> On Tue, Jul 21, 2015 at 09:24:18AM -0700, Nishanth Aravamudan wrote:
> > On 21.07.2015 [10:32:34 -0500], Chris J Arges wrote:
> > > Some architectures like POWER can have a NUMA node_possible_map that
> > > contains sparse entries. This causes
On 21.07.2015 [12:36:33 -0500], Chris J Arges wrote:
> Some architectures like POWER can have a NUMA node_possible_map that
> contains sparse entries. This causes memory corruption with openvswitch
> since it allocates flow_cache with a multiple of num_possible_nodes() and
> assumes the node variab
On 7/21/15 3:13 AM, Alex Gartrell wrote:
But, the EINVAL errno has similarly been
abused to death
there was a thread few month ago trying to come up with
a generic solution for aliased error codes, but unfortunately
nothing concrete came out of it.
The one I liked sounded that the kernel may be
On Tue, 2015-07-21 at 11:12 -0700, Cong Wang wrote:
> > - kfree_skb(skb);
> > + INIT_LIST_HEAD(&q->new_flows);
> > + INIT_LIST_HEAD(&q->old_flows);
> > + for (i = 0; i < q->flows_cnt; i++) {
> > + struct fq_codel_flow *flow = q->flows + i;
> > +
> > +
On Wed, Apr 29, 2015 at 6:52 PM, Felix Janda wrote:
> Florian Fainelli wrote:
>> On 27/04/15 09:13, Stephen Hemminger wrote:
>> > On Sat, 25 Apr 2015 22:33:28 +0200
>> > Felix Janda wrote:
>> >
>> >> They are equivalent but the former is more common. PATH_MAX is
>> >> specified by POSIX and needs
Hi guys,
Florian Fainelli writes:
> Changes in v5:
>
> - removed an invalid use of the link_update callback in the SF2 driver
> was appeared after merging "net: phy: fixed_phy: handle link-down case"
>
> - reworded the commit message for patch 2 to make it clear what it fixes and
> why this
On Tue, Jul 21, 2015 at 4:38 PM, Sebastian Fett wrote:
> Hello!
>
> According to RFC3927 every ARP packet (reply and request) should be sent as
> link layer broadcast as long as the sender IP is a link local address. (see
> chapter 2.5).
Because broadcast replies are noisy and should be avoided.
Frank Schreuder wrote:
[ inet frag evictor crash ]
We believe we found the bug. This patch should fix it.
We cannot share list for buckets and evictor, the flag member is
subject to race conditions so flags & INET_FRAG_EVICTED test is not
reliable.
It would be great if you could confirm that
On Tue, Jul 21, 2015 at 10:36 AM, Chris J Arges
wrote:
> Some architectures like POWER can have a NUMA node_possible_map that
> contains sparse entries. This causes memory corruption with openvswitch
> since it allocates flow_cache with a multiple of num_possible_nodes() and
> assumes the node var
[+cc Alex]
On Mon, Jul 13, 2015 at 11:39:54AM -0700, Mark D Rustad wrote:
> Many multi-function devices provide shared registers in extended
> config space for accessing VPD. The behavior of these registers
> means that the state must be tracked and access locked correctly
> for accesses not to ha
On Tue, Jul 21, 2015 at 3:52 AM, Eric Dumazet wrote:
> On Tue, 2015-07-21 at 06:04 -0400, Jamal Hadi Salim wrote:
>
>> It is worrisome to fix the core code for this. The root cause seems to
>> be codel. Dont have time but in general, reset would be something like:
>>
>> struct fq_codel_sched_data
On Fri, Jul 17, 2015 at 10:27 PM, Eric Dumazet wrote:
>
> On Fri, 2015-07-17 at 14:22 -0700, Yuchung Cheng wrote:
> > If TLP was unable to send a probe, it extended the RTO to
> > now + icsk_rto. But extending the RTO makes little sense
> > if no TLP probe went out. With this commit, instead of
>
On Tue, 21 Jul 2015 16:18:36 +0300
Vadim Kochan wrote:
> From: Vadim Kochan
>
> It really partially reverts:
>
> ec4d0d8a9def35 (ss: Replace unixstat struct by new sockstat struct)
>
> but adds few fields (name & peer_name) from removed unixstat to sockstat
> struct to easy
> return orig
On 07/21/15 at 10:30am, Alexei Starovoitov wrote:
> RX:
> >+info->mode = IP_TUNNEL_INFO_RX;
> >+info->key.tun_flags = TUNNEL_KEY;
> >+info->key.tun_id = cpu_to_be64(vni >> 8);
> ...
> TX:
> >+dst_port = info->key.tp_dst ? : vxlan->dst_port;
> >+
From: Mugunthan V N
Date: Tue, 21 Jul 2015 16:00:42 +0530
> With commit c03abd84634d ("net: ethernet: cpsw: don't requests IRQs
> we don't use") common isr and napi are separated into separate tx isr
> and rx isr/napi, but still in rx napi tx events are handled. So removing
> the tx event handlin
From: Thomas Graf
Date: Tue, 21 Jul 2015 10:43:44 +0200
> This series combines the work previously posted by Roopa, Robert and
> myself. It's according to what we discussed at NFWS. The motivation
> of this series is to:
>
> * Consolidate code between OVS and the rest of the kernel and get
>
From: Eric Dumazet
Date: Tue, 21 Jul 2015 09:43:59 +0200
> From: Edward Hyunkoo Jee
>
> When ip_frag_queue() computes positions, it assumes that the passed
> sk_buff does not contain L2 headers.
>
> However, when PACKET_FANOUT_FLAG_DEFRAG is used, IP reassembly
> functions can be called on out
Some architectures like POWER can have a NUMA node_possible_map that
contains sparse entries. This causes memory corruption with openvswitch
since it allocates flow_cache with a multiple of num_possible_nodes() and
assumes the node variable returned by for_each_node will index into
flow->stats[node
On 7/21/15 1:43 AM, Thomas Graf wrote:
This prepares the VXLAN device to be steered by the routing and other
subsystems which allows to support encapsulation for a large number
of tunnel endpoints and tunnel ids through a single net_device which
improves the scalability.
+1. looks very useful.
On 21/07/15 10:06, Dan Murphy wrote:
> Fix warning: logical ‘or’ of collectively exhaustive tests is always true
>
> Change the internal delay check from an 'or' condition to an 'and'
> condition.
>
> Reported-by: David Binderman
> Signed-off-by: Dan Murphy
Acked-by: Florian Fainelli
> ---
>
Hi,
First, I apologize for posting on the netdev forum. Majordomo did not
list any other network related mailing list.
Is there a way to identify the underlying network interface from an
instance of struct sock? I realize that the socket is abstract and
shouldn't/doesn't necessarily depend on the
Fix warning: logical ‘or’ of collectively exhaustive tests is always true
Change the internal delay check from an 'or' condition to an 'and'
condition.
Reported-by: David Binderman
Signed-off-by: Dan Murphy
---
drivers/net/phy/dp83867.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
On Tue, Jul 21, 2015 at 12:38 PM, Martin Blumenstingl
wrote:
> Hi Willem,
>
> On Tue, Jul 21, 2015 at 6:28 PM, Willem de Bruijn wrote:
>> Interesting. 9c7077622dd9 only extended the check from tpacket_snd to
>> packet_snd to make the two paths equivalent. The existing check had the
>> ominous sta
In dev_queue_xmit() net_cls protected with rcu-bh.
[ 270.730026] ===
[ 270.730029] [ INFO: suspicious RCU usage. ]
[ 270.730033] 4.2.0-rc3+ #2 Not tainted
[ 270.730036] ---
[ 270.730040] include/linux/cgroup.h:353 suspicious rcu_derefere
Hi Willem,
On Tue, Jul 21, 2015 at 6:28 PM, Willem de Bruijn wrote:
> Interesting. 9c7077622dd9 only extended the check from tpacket_snd to
> packet_snd to make the two paths equivalent. The existing check had the
> ominous statement
>
> /* net device doesn't like empty head */
OK, I guess it
On Tue, Jul 21, 2015 at 09:24:18AM -0700, Nishanth Aravamudan wrote:
> On 21.07.2015 [10:32:34 -0500], Chris J Arges wrote:
> > Some architectures like POWER can have a NUMA node_possible_map that
> > contains sparse entries. This causes memory corruption with openvswitch
> > since it allocates flo
On Tue, Jul 21, 2015 at 12:14 PM, Martin Blumenstingl
wrote:
> 9c70776 added validation for the packet size in packet_snd. This change
> enforced that every packet needs a long enough header and at least one
> byte payload.
>
> However, when trying to establish a PPPoE connection the following mes
On 21.07.2015 [10:32:34 -0500], Chris J Arges wrote:
> Some architectures like POWER can have a NUMA node_possible_map that
> contains sparse entries. This causes memory corruption with openvswitch
> since it allocates flow_cache with a multiple of num_possible_nodes() and
Couldn't this also be fi
From: Roopa Prabhu
If user did not specify an oif, try and get it from the via address.
If failed to get device, return with -ENODEV.
Signed-off-by: Roopa Prabhu
---
net/mpls/af_mpls.c | 67 +++-
1 file changed, 66 insertions(+), 1 deletion(-)
9c70776 added validation for the packet size in packet_snd. This change
enforced that every packet needs a long enough header and at least one
byte payload.
However, when trying to establish a PPPoE connection the following message
is printed every time a PPPoE discovery packet is sent:
pppd: pack
Maninder Singh writes:
>>> chandef is initialized with NULL and on the very next line,
>>> we are using it to get channel, which is not correct.
>>>
>>> channel should be initialized after obtaining chandef.
>>>
>>> Signed-off-by: Maninder Singh
>
>>How did you find this bug?
>
> Static anlysis
On 7/21/15 5:16 AM, Nicolas Schichan wrote:
This serie adds support for more instructions to the ARM BPF JIT
namely skb netdevice type retrieval, skb payload offset retrieval, and
skb packet type retrieval.
This allows 35 tests to use the JIT instead of 29 before.
This serie depends on the "BPF
Some architectures like POWER can have a NUMA node_possible_map that
contains sparse entries. This causes memory corruption with openvswitch
since it allocates flow_cache with a multiple of num_possible_nodes() and
assumes the node variable returned by for_each_node will index into
flow->stats[node
So it gets freed when the device is going away.
This fixes a DMA memory leak on driver probe() fail and driver
remove().
Signed-off-by: Lucas Stach
---
v2: Fix indentation of second line to fix alignment with opening bracket.
---
drivers/net/ethernet/freescale/fec_main.c | 4 ++--
1 file changed
This function frees resources and cancels delayed work item that
have been initialized in fec_ptp_init().
Use this to do proper error handling if something goes wrong in
probe function after fec_ptp_init has been called.
Signed-off-by: Lucas Stach
---
drivers/net/ethernet/freescale/fec.h |
> There is no need to use hex_dump_to_buffer() in the cases like this:
>
> hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false); /* len
> <= 16 */
> sprintf("%s\n", outbuf);
>
> since it maybe easily converted to simple:
>
> sprintf("%*ph\n", len, buf);
>
> Note: i
> Replace a kmalloc+strcpy by an equivalent kstrdup in order to improve
> readability.
>
> Signed-off-by: Christophe JAILLET
> Acked-by: Arend van Spriel
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body o
> In routine _rtl8821ae_set_media_status(), an incorrect mask results in a test
> for AP status to always be false. Similar bugs were fixed in rtl8192cu and
> rtl8192de, but this instance was missed at that time.
>
> Reported-by: David Binderman
> Signed-off-by: Larry Finger
> Cc: Stable [3.18
On 07/20/2015 11:54 AM, Nicholas Krause wrote:
This fixes error handling in the function netcp_xgbe_serdes_config
by putting the return value of netcp_xgbe_serdes_check_lane into
the variable ret and return this value to the caller as this function
can fail when called by returning the error code
On 15/07/21 (火) 16:18, Ivan Vecera wrote:
> Network header is set with offset ETH_HLEN but it is not true for VLAN
> (multiple-)tagged and results in checksum issues in lower devices.
>
> v2: leave skb->protocol untouched (thx Vlad), comment added
>
> Signed-off-by: Ivan Vecera
> ---
> drivers
Hello!
According to RFC3927 every ARP packet (reply and request) should be sent
as link layer broadcast as long as the sender IP is a link local
address. (see chapter 2.5).
That functionality would help me a lot with a use case I have with our
application.
But it is not implemented in the ke
Kirill A. Shutemov says:
This simple test-case trigers few locking asserts in kernel:
int main(int argc, char **argv)
{
unsigned int block_size = 16 * 4096;
struct nl_mmap_req req = {
.nm_block_size = block_size,
.nm_block_nr= 6
On Mon, 2015-07-20 at 21:13 +0300, Eugene Shatokhin wrote:
> And here, the code clears EVENT_RX_KILL bit in dev->flags, which may
> execute concurrently with the above operation:
> #0 clear_bit (bitops.h:113, inlined)
> #1 usbnet_bh (usbnet.c:1475)
> /* restart RX again after disabling due
1 - 100 of 192 matches
Mail list logo
