Re: [PATCH iproute2] ss: Fix crash when dump stats from /proc with '-p'

2015-07-20 Thread Vadim Kochan
On Mon, Jul 20, 2015 at 01:43:40PM -0700, Stephen Hemminger wrote: > On Mon, 20 Jul 2015 22:46:23 +0300 > Vadim Kochan wrote: > > > + if (s->name) > > + free(s->name); > > Please don't add unnecessary conditional. > free(NULL) is defined to do nothing. OK, I will r

Re: [PATCH v2 net-next 0/2] bpf: introduce bpf_skb_vlan_push/pop() helpers

2015-07-20 Thread David Miller
From: Alexei Starovoitov Date: Mon, 20 Jul 2015 20:34:17 -0700 > Let TC+eBPF programs call skb_vlan_push/pop via helpers. > > v1->v2: > - reworded commit log to better explain correctness of re-caching > and fixed comparison of mixed endiannes (suggested by Eric) Series applied, thanks Alexei

Re: [net-next 00/14][pull request] Intel Wired LAN Driver Updates 2015-07-17

2015-07-20 Thread David Miller
From: Jeff Kirsher Date: Fri, 17 Jul 2015 07:25:09 -0700 > This series contains updates to igb, ixgbe, ixgbevf, i40e, bnx2x, > freescale, siena and dp83640. > > Jacob provides several patches to clarify the intended way to implement > both SIOCSHWTSTAMP and ethtool's get_ts_info(). It is okay t

Re: [PATCH net-next 0/6] net: bcmgenet: PHY initialization rework

2015-07-20 Thread David Miller
From: Florian Fainelli Date: Thu, 16 Jul 2015 15:51:13 -0700 > This patch series reworks how we perform PHY initialization and resets in the > GENET driver. Although this contains mostly fixes, some of the changes are a > bit too intrusive to be backported to 'net' at the moment. > > Some of the

Re: [PATCH net-next 0/8] stmmac clean up for 4.3 part1

2015-07-20 Thread David Miller
From: Joachim Eastwood Date: Fri, 17 Jul 2015 00:26:04 +0200 > This patch set continues the conversion of the dwmac glue layers > to more proper platform drivers. The first part of the patch set > cleans up stmmac_platform a bit. Refactors code from the common > probe function and exports two fun

Re: [PATCH net-next 1/1] Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver

2015-07-20 Thread David Miller
From: Date: Thu, 16 Jul 2015 22:16:05 + > +static int eee_control = -1; > +module_param(eee_control, int, 0444); > +MODULE_PARM_DESC(eee_control, "EEPROM default(-1), disable(0) & enable(1)"); Please don't add module parameters for things configurable via ethtool and other generic, standard,

Re: [PATCH] ravb: fix race updating TCCR

2015-07-20 Thread David Miller
From: Sergei Shtylyov Date: Fri, 17 Jul 2015 00:28:38 +0300 > The TCCR.TSRQn bit may get clearead after TCCR gets read, so that TCCR write > would get skipped. We don't need to check this bit before setting. > > Signed-off-by: Sergei Shtylyov Applied, thanks. -- To unsubscribe from this list:

Re: [PATCH net-next 00/13] tipc: separate link and link aggregation layer

2015-07-20 Thread David Miller
From: Jon Maloy Date: Thu, 16 Jul 2015 16:54:18 -0400 > This is the first batch of a longer series that has two main objectives: > > o Finer lock granularity during message sending and reception, > especially regarding usage of the node spinlock. > > o Better separation between the link layer

Re: [PATCH net-next] net: remove skb_frag_add_head

2015-07-20 Thread David Miller
From: Jiri Benc Date: Thu, 16 Jul 2015 21:50:50 +0200 > It's not used anywhere. > > Signed-off-by: Jiri Benc Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majord

Re: [PATCH] net: netcp: fix improper initialization in netcp_ndo_open()

2015-07-20 Thread David Miller
From: Murali Karicheri Date: Thu, 16 Jul 2015 15:32:14 -0400 > The keystone qmss will raise interrupt when packet arrive at the > receive queue. Only control available to avoid interrupt from happening > is to keep the free descriptor queue (FDQ) empty in the receive side. > So the filling of des

Re: [PATCH 0/6] BPF JIT fixes and features for ARM

2015-07-20 Thread David Miller
From: Nicolas Schichan Date: Thu, 16 Jul 2015 18:46:29 +0200 > This serie fixes issues with the ARM BPF JIT and adds support for more > instructions to the ARM BPF JIT. > > The first three patches are fixing bugs in the ARM JIT and should > probably find their way to a stable kernel. > > The la

[PATCH v2 net-next 0/2] bpf: introduce bpf_skb_vlan_push/pop() helpers

2015-07-20 Thread Alexei Starovoitov
Let TC+eBPF programs call skb_vlan_push/pop via helpers. v1->v2: - reworded commit log to better explain correctness of re-caching and fixed comparison of mixed endiannes (suggested by Eric) Alexei Starovoitov (2): bpf: introduce bpf_skb_vlan_push/pop() helpers test_bpf: add bpf_skb_vlan_pu

[PATCH v2 net-next 1/2] bpf: introduce bpf_skb_vlan_push/pop() helpers

2015-07-20 Thread Alexei Starovoitov
Allow eBPF programs attached to TC qdiscs call skb_vlan_push/pop via helper functions. These functions may change skb->data/hlen which are cached by some JITs to improve performance of ld_abs/ld_ind instructions. Therefore JITs need to recognize bpf_skb_vlan_push/pop() calls, re-compute header len

[PATCH v2 net-next 2/2] test_bpf: add bpf_skb_vlan_push/pop() tests

2015-07-20 Thread Alexei Starovoitov
improve accuracy of timing in test_bpf and add two stress tests: - {skb->data[0], get_smp_processor_id} repeated 2k times - {skb->data[0], vlan_push} x 68 followed by {skb->data[0], vlan_pop} x 68 1st test is useful to test performance of JIT implementation of BPF_LD_ABS together with BPF_CALL ins

Re: [PATCH] inet: frags: fix defragmented packet's IP header for af_packet

2015-07-20 Thread David Miller
From: Edward Jee Date: Thu, 16 Jul 2015 01:54:41 -0700 > When ip_frag_queue() computes positions, it assumes that the passed > sk_buff does not contain L2 headers. However, when > PACKET_FANOUT_FLAG_DEFRAG is used, IP defragmentation functions can be > called on outgoing packets that contain L2 h

Re: [PATCH] bonding: correct the MAC address for "follow" fail_over_mac policy

2015-07-20 Thread David Miller
From: Ding Tianhong Date: Thu, 16 Jul 2015 16:30:02 +0800 > The "follow" fail_over_mac policy is useful for multiport devices that > either become confused or incur a performance penalty when multiple > ports are programmed with the same MAC address, but the same MAC > address still may happened

Re: pull-request: can 2015-07-16

2015-07-20 Thread David Miller
From: Marc Kleine-Budde Date: Thu, 16 Jul 2015 10:33:53 +0200 > this is a pull request of 2 patches by Stefan Agner. He fixes the resume > operation in the mcp251x driver. Pulled, thanks Marc. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord

Re: [PATCH net-next v3 0/5] switchdev: avoid duplicate packet forwarding

2015-07-20 Thread David Miller
From: sfel...@gmail.com Date: Sat, 18 Jul 2015 18:24:47 -0700 > With switchdev support for offloading L2/L3 forwarding data path to a > switch device, we have a general problem where both the device and the > kernel may forward the packet, resulting in duplicate packets on the wire. > Anytime a pa

Re: [PATCH net-next] rocker: forward packets to CPU when port is joined to openvswitch

2015-07-20 Thread David Miller
From: Simon Horman Date: Thu, 16 Jul 2015 10:39:14 +0900 > Teach rocker to forward packets to CPU when a port is joined to Open vSwitch. > There is scope to later refine what is passed up as per Open vSwitch flows > on a port. > > This does not change the behaviour of rocker ports that are > not

[PATCH net v5 1/4] net: dsa: bcm_sf2: Do not override speed settings

2015-07-20 Thread Florian Fainelli
The SF2 driver currently overrides speed settings for its port configured using a fixed PHY, this is both unnecessary and incorrect, because we keep feedback to the hardware parameters that we read from the PHY device, which in the case of a fixed PHY cannot possibly change speed. This is a requir

[PATCH net v5 0/4] net: enable inband link state negotiation only when explicitly requested

2015-07-20 Thread Florian Fainelli
Hi all, Changes in v5: - removed an invalid use of the link_update callback in the SF2 driver was appeared after merging "net: phy: fixed_phy: handle link-down case" - reworded the commit message for patch 2 to make it clear what it fixes and why this is required Initial cover letter from S

[PATCH net v5 2/4] net: phy: fixed_phy: handle link-down case

2015-07-20 Thread Florian Fainelli
From: Stas Sergeev fixed_phy_register() currently hardcodes the fixed PHY link to 1, and expects to find a "speed" parameter to provide correct information towards the fixed PHY consumer. In a subsequent change, where we allow "managed" (e.g: (RS)GMII in-band status auto-negotiation) fixed PHYs,

[PATCH net v5 3/4] of_mdio: add new DT property 'managed' to specify the PHY management type

2015-07-20 Thread Florian Fainelli
From: Stas Sergeev Currently the PHY management type is selected by the MAC driver arbitrary. The decision is based on the presence of the "fixed-link" node and on a will of the driver's authors. This caused a regression recently, when mvneta driver suddenly started to use the in-band status for

[PATCH net v5 4/4] mvneta: use inband status only when explicitly enabled

2015-07-20 Thread Florian Fainelli
From: Stas Sergeev The commit 898b2970e2c9 ("mvneta: implement SGMII-based in-band link state signaling") implemented the link parameters auto-negotiation unconditionally. Unfortunately it appears that some HW that implements SGMII protocol, doesn't generate the inband status, so it is not possib

Re: [PATCH] net: fec: fix runtime PM when probing MII bus

2015-07-20 Thread David Miller
From: Andrew Lunn Date: Tue, 21 Jul 2015 01:52:24 +0200 > You emailed saying you had reverted 6c3e921b18ed, but it is still in > net-next/master. It's reverted in the 'net' tree, and that's where bug fixes go. 'net' is periodically merged into 'net-next' so even if the revert isn't there now, i

Re: [PATCH] net: fec: fix runtime PM when probing MII bus

2015-07-20 Thread Andrew Lunn
On Mon, Jul 20, 2015 at 03:48:14PM +0200, Lucas Stach wrote: > In the case where there is no "mdio" bus specified in the devicetree a plain > mdiobus_register() will be called, which tries to probe the connected PHY > by doing mdio_read() on the bus. > Since 6c3e921b18ed (net: fec: Ensure clocks ar

Re: Revert "sit: Add gro callbacks to sit_offload"

2015-07-20 Thread David Miller
From: Herbert Xu Date: Mon, 20 Jul 2015 17:55:38 +0800 > This patch reverts 19424e052fb44da2f00d1a868cbb51f3e9f4bbb5 ("sit: > Add gro callbacks to sit_offload") because it generates packets > that cannot be handled even by our own GSO. > > Reported-by: Wolfgang Walter > Signed-off-by: Herbert X

Re: [PATCH net] net: dsa: bcm_sf2: do not use indirect reads and writes for 7445E0

2015-07-20 Thread David Miller
From: Florian Fainelli Date: Wed, 15 Jul 2015 16:09:32 -0700 > 7445E0 contains an ECO which disconnected the internal SF2 pseudo-PHY which > was > known to conflict with the external pseudo-PHY of BCM53125 switches. This > motivated the need to utilize the internal SF2 MDIO controller via indire

Re: [PATCH net] bonding: correctly handle bonding type change on enslave failure

2015-07-20 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 15 Jul 2015 22:57:01 +0200 > From: Nikolay Aleksandrov > > If the bond is enslaving a device with different type it will be setup > by it, but if after being setup the enslave fails the bond doesn't > switch back its type and also keeps pointers to foreign s

Re: [PATCH net-next] bridge: mcast: fix br_multicast_dev_del warn when igmp snooping is not defined

2015-07-20 Thread David Miller
From: Nikolay Aleksandrov Date: Mon, 20 Jul 2015 23:03:45 +0200 > Fix: > net/bridge/br_if.c: In function 'br_dev_delete': >>> net/bridge/br_if.c:284:2: error: implicit declaration of function >>> 'br_multicast_dev_del' [-Werror=implicit-function-declaration] > br_multicast_dev_del(br); >

Re: [PATCH net-next] bridge: mdb: add vlan support for user entries

2015-07-20 Thread Nikolay Aleksandrov
On 07/21/2015 12:28 AM, Stephen Hemminger wrote: > On Fri, 10 Jul 2015 08:02:08 -0700 > Nikolay Aleksandrov wrote: > >> diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.h >> index eaaea6208b42..3635b7797508 100644 >> --- a/include/uapi/linux/if_bridge.h >> +++ b/include/

Re: [PATCH net-next] bridge: mdb: add vlan support for user entries

2015-07-20 Thread Stephen Hemminger
On Fri, 10 Jul 2015 08:02:08 -0700 Nikolay Aleksandrov wrote: > diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.h > index eaaea6208b42..3635b7797508 100644 > --- a/include/uapi/linux/if_bridge.h > +++ b/include/uapi/linux/if_bridge.h > @@ -182,6 +182,7 @@ struct br_mdb_

Re: Why return E2BIG from bpf map update?

2015-07-20 Thread Alexei Starovoitov
On 7/20/15 3:15 PM, Alex Gartrell wrote: The ship has probably sailed on this one, but it seems like ENOSPC makes more sense than E2BIG. Any chance of changing it so that poor ebpf library maintainers in the future don't have to wonder how their argument list got too big? sorry, too late. It's

Why return E2BIG from bpf map update?

2015-07-20 Thread Alex Gartrell
The ship has probably sailed on this one, but it seems like ENOSPC makes more sense than E2BIG. Any chance of changing it so that poor ebpf library maintainers in the future don't have to wonder how their argument list got too big? net-next/master:kernel/bpf/hashtab.c=static int htab_map_update_e

Re: [PATCH] nohz: prevent tilegx network driver interrupts

2015-07-20 Thread Chris Metcalf
On 07/20/2015 05:49 PM, Frederic Weisbecker wrote: On Mon, Jul 20, 2015 at 05:22:12PM -0400, Chris Metcalf wrote: On 07/11/2015 10:30 AM, Frederic Weisbecker wrote: On Fri, Jul 10, 2015 at 03:05:02PM -0400, Chris Metcalf wrote: The tilegx chips typically don't do cpu offlining anyway, since we

Re: [PATCH iproute2] ss: fix display of raw sockets

2015-07-20 Thread Stephen Hemminger
On Wed, 15 Jul 2015 05:50:42 -0700 Nikolay Aleksandrov wrote: > After commit 8250bc9ff4e5 ("ss: Unify inet sockets output") raw sockets > are displayed as udp because dgram_show_line() is used for both and > thus IPPROTO_UDP is used for both so proto_name() returns "udp". > Fix this by checking d

Re: [PATCH net-next iproute2] support batching of ip route get commands

2015-07-20 Thread Stephen Hemminger
On Wed, 15 Jul 2015 17:06:36 -0700 Roopa Prabhu wrote: > From: Roopa Prabhu > > This patch replaces exits with returns in > ip route get command handling. This allows batching > of ip route get commands. > > $cat route_get_batch.txt > route get 10.0.14.2 > route get 12.0.14.2 > route get 10.0.

Re: [PATCH] nohz: prevent tilegx network driver interrupts

2015-07-20 Thread Frederic Weisbecker
On Mon, Jul 20, 2015 at 05:22:12PM -0400, Chris Metcalf wrote: > On 07/11/2015 10:30 AM, Frederic Weisbecker wrote: > >On Fri, Jul 10, 2015 at 03:05:02PM -0400, Chris Metcalf wrote: > >>The tilegx chips typically don't do cpu offlining anyway, since > >>we've never really found a usecase, so whatev

Re: [PATCH v2 -next] net: fib: use fib result when zero-length prefix aliases exist

2015-07-20 Thread Julian Anastasov
Hello, On Mon, 20 Jul 2015, Florian Westphal wrote: > Could you please submit your two patches (tos fix and this one) > formally? In a day or two, I have to extend the patch and do some tests... Regards -- Julian Anastasov -- To unsubscribe from this list: send the line "unsu

Re: [PATCH] nohz: prevent tilegx network driver interrupts

2015-07-20 Thread Chris Metcalf
On 07/11/2015 10:30 AM, Frederic Weisbecker wrote: On Fri, Jul 10, 2015 at 03:05:02PM -0400, Chris Metcalf wrote: The tilegx chips typically don't do cpu offlining anyway, since we've never really found a usecase, so whatever you boot with you always have available. We do have support for a bar

[PATCH net-next] bridge: mcast: fix br_multicast_dev_del warn when igmp snooping is not defined

2015-07-20 Thread Nikolay Aleksandrov
Fix: net/bridge/br_if.c: In function 'br_dev_delete': >> net/bridge/br_if.c:284:2: error: implicit declaration of function >> 'br_multicast_dev_del' [-Werror=implicit-function-declaration] br_multicast_dev_del(br); ^ cc1: some warnings being treated as errors when igmp snooping is not

[net-next:master 104/107] net/bridge/br_if.c:284:2: error: implicit declaration of function 'br_multicast_dev_del'

2015-07-20 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: a0a9f33bdf8bf9061c31faab46d8eb46ff644622 commit: e10177abf842d0c40dfecc43bd57a0a762a2fccf [104/107] bridge: multicast: fix handling of temp and perm entries config: i386-randconfig-a0-201529 (attached as .confi

Re: [PATCH iproute2] ss: Fix crash when dump stats from /proc with '-p'

2015-07-20 Thread Stephen Hemminger
On Mon, 20 Jul 2015 22:46:23 +0300 Vadim Kochan wrote: > + if (s->name) > + free(s->name); Please don't add unnecessary conditional. free(NULL) is defined to do nothing. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messag

Re: [PATCH net-next 0/2] bridge: multicast: temp and perm entries behaviour enhancements

2015-07-20 Thread Nikolay Aleksandrov
On 07/20/2015 09:49 PM, David Miller wrote: > From: Nikolay Aleksandrov > Date: Wed, 15 Jul 2015 07:16:49 -0700 > >> Hi, >> Patch 01 adds a notify when a group is deleted via br_multicast_del_pg() >> (on expire, on device delete or on device down). >> Patch 02 changes how bridge device and bridge

Re: [PATCH net-next 0/6] net: bcmgenet: PHY initialization rework

2015-07-20 Thread Florian Fainelli
On 17/07/15 06:53, Jaedon Shin wrote: >> On Jul 17, 2015, at 7:51 AM, Florian Fainelli wrote: >> >> Hi David, Petri, Jaedon, >> >> This patch series reworks how we perform PHY initialization and resets in the >> GENET driver. Although this contains mostly fixes, some of the changes are a >> bit to

Re: [PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

2015-07-20 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 15 Jul 2015 22:55:55 +0200 > Dave please ignore this patch, I'll send a better fix. OK -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/ma

Re: [PATCH net-next] net/ipv6: update flowi6_oif in ip6_dst_lookup_flow if not set

2015-07-20 Thread David Miller
From: Phil Sutter Date: Wed, 15 Jul 2015 21:56:26 +0200 > Newly created flows don't have flowi6_oif set (at least if the > associated socket is not interface-bound). This leads to a mismatch in > __xfrm6_selector_match() for policies which specify an interface in the > selector (sel->ifindex != 0

Re: [PATCH net] bonding: fix destruction of bond with devices different from arphrd_ether

2015-07-20 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 15 Jul 2015 21:52:51 +0200 > From: Nikolay Aleksandrov > > When the bonding is being unloaded and the netdevice notifier is > unregistered it executes NETDEV_UNREGISTER for each device which should > remove the bond's proc entry but if the device enslaved is

Re: [PATCH net-next] bonding: trivial: remove unused variables

2015-07-20 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 15 Jul 2015 16:31:09 +0200 > From: Nikolay Aleksandrov > > Get rid of these: ... > Signed-off-by: Nikolay Aleksandrov Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH net-next 0/2] bridge: multicast: temp and perm entries behaviour enhancements

2015-07-20 Thread David Miller
From: Nikolay Aleksandrov Date: Wed, 15 Jul 2015 07:16:49 -0700 > Hi, > Patch 01 adds a notify when a group is deleted via br_multicast_del_pg() > (on expire, on device delete or on device down). > Patch 02 changes how bridge device and bridge port delete and down/up are > handled. Until now on b

[PATCH iproute2] ss: Fix crash when dump stats from /proc with '-p'

2015-07-20 Thread Vadim Kochan
From: Vadim Kochan It really partially reverts: ec4d0d8a9def35 (ss: Replace unixstat struct by new sockstat struct) but adds few fields (name & peer_name) from removed unixstat to sockstat struct to easy return original code. Fixes: ec4d0d8a9def35 (ss: Replace unixstat struct by new socks

Re: [PATCH] net: dsa: mv88e6xxx: fix fid_mask when leaving bridge

2015-07-20 Thread David Miller
From: Vivien Didelot Date: Wed, 15 Jul 2015 10:07:07 -0400 > The mv88e6xxx_priv_state structure contains an fid_mask, where 1 means > the FID is free to use, 0 means the FID is in use. > > This patch fixes the bit clear in mv88e6xxx_leave_bridge() when > assigning a new FID to a port. > > Examp

Re: [PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1

2015-07-20 Thread David Miller
From: "Michael S. Tsirkin" Date: Wed, 15 Jul 2015 15:26:19 +0300 > ANY_LAYOUT is a compatibility feature. It's implied > for VERSION_1 devices, and non-transitional devices > might not offer it. Change code to behave accordingly. > > Signed-off-by: Michael S. Tsirkin Applied. -- To unsubscribe

Re: [PATCH net-next 0/2] BPF update

2015-07-20 Thread David Miller
From: Daniel Borkmann Date: Wed, 15 Jul 2015 14:21:40 +0200 > This small helper allows for accessing net_cls cgroups classid. Please > see individual patches for more details. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

[PATCH,v2 net] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-20 Thread Alex Gartrell
We have an application that invokes tc to delete the root every time the config changes. As a result we stress the cleanup code and were seeing the following panic: crash> bt PID: 630839 TASK: 8823c990d280 CPU: 14 COMMAND: "tc" [... snip ...] #8 [8820ceec17a0] page_fault at ff

Re: [PATCH net-next 1/2] enic: add adaptive coalescing intr for intx and msi poll

2015-07-20 Thread David Miller
From: Govindarajulu Varadarajan <_gov...@gmx.com> Date: Wed, 15 Jul 2015 15:34:39 +0530 > Adaptive interrupt coalescing is available for msix. This patch adds the > support > for msi poll. Interface for adaptive interrupt coalescing is already added in > driver. We just did not enable it for lega

Re: [PATCH net-next 2/2] enic: allow adaptive coalesce setting for msi/legacy intr

2015-07-20 Thread David Miller
From: Govindarajulu Varadarajan <_gov...@gmx.com> Date: Wed, 15 Jul 2015 15:34:40 +0530 > * Allow setting of adaptive coalescing setting for all types of interrupt. > > * In msi & legacy intr, we use single interrupt for rx & tx. In this case > tx_coalesce_usecs is invalid. We should use only r

[PATCH net] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-20 Thread Alex Gartrell
First, vehement apologies for sending an RFC patch against such an old kernel. This is (potentially) a bug fix for a crash that we've been seeing in 3.2 and 3.10, and, AFAICT, the underlying issue has not been addressed. We have an application that invokes tc to delete the root every time the con

Re: [PATCH net-next] inet: Always increment refcount in inet_twsk_schedule

2015-07-20 Thread subashab
>> //Initialize time wait socket and setup timer >> inet_twsk_alloc() tw_refcnt = 0 >> __inet_twsk_hashdance() tw_refcnt = 3 >> inet_twsk_schedule() tw_refcnt = 4 >> inet_twsk_put() tw_refcnt = 3 >> >> //Receive packet 1 in timewait state >> tcp_timewait_state_process() -> inet_twsk_schedule tw_ref

Re: Segmentation fault in iproute2 ss -p (versions 4.0.0, 4.1.0 and 4.1.1)

2015-07-20 Thread Stephen Hemminger
Patches are always appreciated and this looks like a real bug. But before I can accept it there are a couple of small changes needed. 1. There is no need to check for NULL when calling free(). Glibc free is documented to accept NULL as a valid request and do nothing. 2. Please add a Signed-

RE: [PATCH net-next 1/1] hv_netvsc: Wait for sub-channels to be processed during probe

2015-07-20 Thread KY Srinivasan
> -Original Message- > From: Dexuan Cui > Sent: Monday, July 20, 2015 2:39 AM > To: KY Srinivasan; da...@davemloft.net; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; jasow...@redhat.com; vkuzn...@redhat.com > S

Re: [PATCH v2 1/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL

2015-07-20 Thread Marcelo Ricardo Leitner
On Thu, Jul 16, 2015 at 11:03:14AM -0300, Marcelo Ricardo Leitner wrote: > On Thu, Jul 16, 2015 at 09:50:16AM -0400, Vlad Yasevich wrote: ... > > I am not familiar enough with DLM and its history, but my question is this: > > If dlm always peels off a socket for a new associations, why is it using

Re: [PATCH] net: vnet: relocate netlink code section comment

2015-07-20 Thread Cong Wang
On Mon, Jul 20, 2015 at 10:12 AM, Baruch Siach wrote: > Hi Cong Wang, > > On Mon, Jul 20, 2015 at 10:07:00AM -0700, Cong Wang wrote: >> On Sun, Jul 19, 2015 at 12:40 AM, Baruch Siach wrote: >> > The veth_setup() routine and the VETH_FEATURES macro are also part of the >> > netlink interface (refe

Re: [RGC PATCH v3.10] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-20 Thread Cong Wang
On Sat, Jul 18, 2015 at 1:50 AM, Eric Dumazet wrote: > > HTB + fq_codel ? > > Make sure you applied Cong fix > I think only cbq actually uses ->drop(), the rest simply call ->drop() for the lower qdisc's. No? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

Re: [RGC PATCH v3.10] net: sched: validate that class is found in qdisc_tree_decrease_qlen

2015-07-20 Thread Cong Wang
On Fri, Jul 17, 2015 at 5:27 PM, Alex Gartrell wrote: > On Fri, Jul 17, 2015 at 5:10 PM, Cong Wang wrote: >> Hmm, but in htb_delete() we do reset the leaf qdisc before removing the >> class from ha >> >> if (!cl->level) { >> qlen = cl->un.leaf.q->q.qlen; >>

Several races in "usbnet" module (kernel 4.1.x)

2015-07-20 Thread Eugene Shatokhin
Hi, I have recently found several data races in "usbnet" module, checked on vanilla kernel 4.1.0 on x86_64. The races do actually happen, I have confirmed it by adding delays and using hardware breakpoints to detect the conflicting memory accesses (with RaceHound tool, https://github.com/winn

Re: [PATCH net-next v3 0/5] switchdev: avoid duplicate packet forwarding

2015-07-20 Thread Andrew Lunn
> This looks good to me, and it looks like this is also relevant for > DSA-driven switches, however I am not exactly clear on how we could > potentially use this on such switches. > > For Broadcom tags, there is a reason code forwarded along with the tag > making it to the CPU, and the "mirror" bi

Re: "ss -p" segfaults

2015-07-20 Thread Andreas Schwab
"j...@openmailbox.org" writes: > - free(p->process); > - free(p->process_ctx); > - free(p->socket_ctx); > + if (p->process) > + free(p->process); > + if (p->process_ctx)

RE: drivers/net/phy/dp83867.c:167: possible bad if ?

2015-07-20 Thread David Binderman
Hello there, > The proposed fix is logically correct. And it matches the code for > phy_interface_is_rgmii with the '&&'. As the original warning message indicates, I used compiler flag -Wlogical-op to find this problem. In order to detect this problem in

Re: [PATCH net-next v3 0/5] switchdev: avoid duplicate packet forwarding

2015-07-20 Thread Florian Fainelli
Hi Scott, On 18/07/15 18:24, sfel...@gmail.com wrote: > From: Scott Feldman > > v3: > > - Per Nicolas Dichtel review: remove errant empty union. > > v2: > > - Per davem review: in sk_buff, union fwd_mark with secmark to save space >since features appear to be mutually exclusive. > - Pe

Re: drivers/net/phy/dp83867.c:167: possible bad if ?

2015-07-20 Thread Dan Murphy
On 07/20/2015 12:40 PM, Florian Fainelli wrote: > On 20/07/15 10:37, Dan Murphy wrote: >> Florian >> >> On 07/20/2015 12:28 PM, Florian Fainelli wrote: >>> Adding Dan, >>> >>> On 20/07/15 05:37, David Binderman wrote: Hello there, drivers/net/phy/dp83867.c:167:57: warning: logical ‘o

Re: drivers/net/phy/dp83867.c:167: possible bad if ?

2015-07-20 Thread Florian Fainelli
On 20/07/15 10:37, Dan Murphy wrote: > Florian > > On 07/20/2015 12:28 PM, Florian Fainelli wrote: >> Adding Dan, >> >> On 20/07/15 05:37, David Binderman wrote: >>> Hello there, >>> >>> drivers/net/phy/dp83867.c:167:57: warning: logical ‘or’ of collectively >>> exhaustive tests is always true [-

Re: [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-20 Thread Marcelo Ricardo Leitner
On Mon, Jul 20, 2015 at 02:15:22PM -0300, Marcelo Ricardo Leitner wrote: > On Fri, Jul 17, 2015 at 02:55:33PM +0200, Thomas Graf wrote: > > [ snip ] > > > @@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev) > > netif_keep_dst(dev); ---> (a) > > dev->

Re: drivers/net/phy/dp83867.c:167: possible bad if ?

2015-07-20 Thread Dan Murphy
Florian On 07/20/2015 12:28 PM, Florian Fainelli wrote: > Adding Dan, > > On 20/07/15 05:37, David Binderman wrote: >> Hello there, >> >> drivers/net/phy/dp83867.c:167:57: warning: logical ‘or’ of collectively >> exhaustive tests is always true [-Wlogical-op] >> >> Source code is >> >> if ((p

"ss -p" segfaults

2015-07-20 Thread j...@openmailbox.org
Please find attached one simple patch for the code 4.1.0/4.1.1. Essentially all that is needed to get rid of this issue is the addition of: memset(u, 0, sizeof(*u)); after: if (!(u = malloc(sizeof(*u break; During the analysis of this issue I also found some other situ

Re: drivers/net/phy/dp83867.c:167: possible bad if ?

2015-07-20 Thread Florian Fainelli
Adding Dan, On 20/07/15 05:37, David Binderman wrote: > Hello there, > > drivers/net/phy/dp83867.c:167:57: warning: logical ‘or’ of collectively > exhaustive tests is always true [-Wlogical-op] > > Source code is > > if ((phydev->interface>= PHY_INTERFACE_MODE_RGMII_ID) || > (phyde

Re: [Xen-devel] [PATCH v2 17/20] net/xen-netfront: Make it running on 64KB page granularity

2015-07-20 Thread Julien Grall
Hi, On 09/07/15 21:42, Julien Grall wrote: > +static void xennet_make_one_txreq(unsigned long mfn, unsigned int offset, > + unsigned int *len, void *data) > +{ > + struct xennet_gnttab_make_txreq *info = data; > + > + info->tx->flags |= XEN_NETTXF_more_data; >

Re: [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-20 Thread Marcelo Ricardo Leitner
On Fri, Jul 17, 2015 at 02:55:33PM +0200, Thomas Graf wrote: [ snip ] > @@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev) > netif_keep_dst(dev); ---> (a) > dev->priv_flags |= IFF_LIVE_ADDR_CHANGE; > > + /* If in flow based mode, keep the

Re: [PATCH] net: vnet: relocate netlink code section comment

2015-07-20 Thread Baruch Siach
Hi Cong Wang, On Mon, Jul 20, 2015 at 10:07:00AM -0700, Cong Wang wrote: > On Sun, Jul 19, 2015 at 12:40 AM, Baruch Siach wrote: > > The veth_setup() routine and the VETH_FEATURES macro are also part of the > > netlink interface (referenced from struct rtnl_link_ops). Include them under > > the n

Re: [PATCH] net: vnet: relocate netlink code section comment

2015-07-20 Thread Cong Wang
On Sun, Jul 19, 2015 at 12:40 AM, Baruch Siach wrote: > The veth_setup() routine and the VETH_FEATURES macro are also part of the > netlink interface (referenced from struct rtnl_link_ops). Include them under > the netlink code section comment. > Or just remove it? I don't think comment like this

Re: [PATCH net] macvtap: fix network header pointer for VLAN tagged pkts

2015-07-20 Thread Vlad Yasevich
On 07/20/2015 11:44 AM, Ivan Vecera wrote: > Network header is set with offset ETH_HLEN but it is not true for VLAN > (multiple-)tagged and results in checksum issues in lower devices. > > Signed-off-by: Ivan Vecera > --- > drivers/net/macvtap.c | 6 ++ > 1 file changed, 6 insertions(+) > >

Re: [RFC PATCH 0/2] net: macb: Add mdio driver for accessing multiple phy devices

2015-07-20 Thread Andrew Lunn
On Mon, Jul 20, 2015 at 03:30:36PM +0200, Michal Simek wrote: > Hi Nicolas, > > have you had a time to look at this? > > Thanks, > Michal > > On 07/13/2015 06:48 AM, Punnaiah Choudary Kalluri wrote: > > This patch is to add support for the design that has multiple ethernet > > mac controllers an

[PATCH net] macvtap: fix network header pointer for VLAN tagged pkts

2015-07-20 Thread Ivan Vecera
Network header is set with offset ETH_HLEN but it is not true for VLAN (multiple-)tagged and results in checksum issues in lower devices. Signed-off-by: Ivan Vecera --- drivers/net/macvtap.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c i

pull-request: wireless-drivers 2015-07-20

2015-07-20 Thread Kalle Valo
Hi Dave, here are few fixes for 4.2, should not have anything out of ordinary. Please let me know if there are any issues. Kalle The following changes since commit 145c37084e3e6584b95f82361922965cc3af41bf: Doc: z8530book: Fix typo in API-z8530-sync-txdma-open.html (2015-07-10 23:45:31 -0700)

Re: [RFC PATCH 0/2] net: macb: Add mdio driver for accessing multiple phy devices

2015-07-20 Thread Michal Simek
Hi Nicolas, have you had a time to look at this? Thanks, Michal On 07/13/2015 06:48 AM, Punnaiah Choudary Kalluri wrote: > This patch is to add support for the design that has multiple ethernet > mac controllers and single mdio bus connected to multiple phy devices. > i.e mdio lines are connecte

Re: [PATCH v2 0/2] sctp: fix src address selection if using secondary address

2015-07-20 Thread Neil Horman
On Fri, Jul 17, 2015 at 12:34:16PM -0300, Marcelo Ricardo Leitner wrote: > This series improves the way SCTP chooses its src address so that the > choosen one will always belong to the interface being used for output. > > v1->v2: > - split out the refactoring from the fix itself > - Doing a full

Re: reproducable panic eviction work queue

2015-07-20 Thread Florian Westphal
Frank Schreuder wrote: > > On 7/18/2015 05:32 PM, Nikolay Aleksandrov wrote: > >On 07/18/2015 05:28 PM, Johan Schuijt wrote: > >>Thx for your looking into this! > >> > >>>Thank you for the report, I will try to reproduce this locally > >>>Could you please post the full crash log ? > >>Of course,

Re: [PATCH] net: fec: fix runtime PM when probing MII bus

2015-07-20 Thread Lucas Stach
Am Montag, den 20.07.2015, 15:59 +0200 schrieb Andrew Lunn: > On Mon, Jul 20, 2015 at 03:48:14PM +0200, Lucas Stach wrote: > > In the case where there is no "mdio" bus specified in the devicetree a plain > > mdiobus_register() will be called, which tries to probe the connected PHY > > by doing mdio

Re: [PATCH v2 net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

2015-07-20 Thread Marcelo Ricardo Leitner
On Mon, Jul 20, 2015 at 09:54:50AM +0200, Sowmini Varadhan wrote: > > __vxlan_find_mac invokes ether_addr_equal on the eth_addr field, > which triggers unaligned access messages, so rearrange vxlan_fdb > to avoid this in the most non-intrusive way. > > Signed-off-by: Sowmini Varadhan Reviewed-b

Re: [PATCH net-next v4] ipv6: sysctl to restrict candidate source addresses

2015-07-20 Thread Erik Kline
I thought perhaps "use_oif_addr_only" was a slightly clearer sysctl name. (Maybe it should be plural, "use_oif_addrs_only"?) On 20 July 2015 at 16:04, Erik Kline wrote: > Per RFC 6724, section 4, "Candidate Source Addresses": > > It is RECOMMENDED that the candidate source addresses be the s

Re: [PATCH] net: fec: fix runtime PM when probing MII bus

2015-07-20 Thread Andrew Lunn
On Mon, Jul 20, 2015 at 03:48:14PM +0200, Lucas Stach wrote: > In the case where there is no "mdio" bus specified in the devicetree a plain > mdiobus_register() will be called, which tries to probe the connected PHY > by doing mdio_read() on the bus. > Since 6c3e921b18ed (net: fec: Ensure clocks ar

[PATCH net-next v4] ipv6: sysctl to restrict candidate source addresses

2015-07-20 Thread Erik Kline
Per RFC 6724, section 4, "Candidate Source Addresses": It is RECOMMENDED that the candidate source addresses be the set of unicast addresses assigned to the interface that will be used to send to the destination (the "outgoing" interface). Add a sysctl to enable this behaviour. Signe

Re: reproducable panic eviction work queue

2015-07-20 Thread Nikolay Aleksandrov
On 07/20/2015 02:47 PM, Frank Schreuder wrote: > > On 7/18/2015 05:32 PM, Nikolay Aleksandrov wrote: >> On 07/18/2015 05:28 PM, Johan Schuijt wrote: >>> Thx for your looking into this! >>> Thank you for the report, I will try to reproduce this locally Could you please post the full cras

[PATCH 2/2] net: fec: introduce fec_ptp_stop and use in probe fail path

2015-07-20 Thread Lucas Stach
This function frees resources and cancels delayed work item that have been initialized in fec_ptp_init(). Use this to do proper error handling if something goes wrong in probe function after fec_ptp_init has been called. Signed-off-by: Lucas Stach --- drivers/net/ethernet/freescale/fec.h |

[PATCH 1/2] net: fec: use managed DMA API functions to allocate BD ring

2015-07-20 Thread Lucas Stach
So it gets freed when the device is going away. This fixes a DMA memory leak on driver probe() fail and driver remove(). Signed-off-by: Lucas Stach --- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec

[PATCH] net: fec: fix runtime PM when probing MII bus

2015-07-20 Thread Lucas Stach
In the case where there is no "mdio" bus specified in the devicetree a plain mdiobus_register() will be called, which tries to probe the connected PHY by doing mdio_read() on the bus. Since 6c3e921b18ed (net: fec: Ensure clocks are enabled while using mdio bus) this needs runtime PM to be available

RE: [RFC,v3,12/12] fsl/fman: Add FMan MAC driver

2015-07-20 Thread Madalin-Cristian Bucur
> -Original Message- > From: Joakim Tjernlund [mailto:joakim.tjernl...@transmode.se] > Sent: Monday, July 20, 2015 3:57 PM > To: netdev@vger.kernel.org; Liberman Igal-B31950; Bucur Madalin-Cristian- > B32716 > Cc: linuxppc-...@lists.ozlabs.org; linux-ker...@vger.kernel.org > Subject: Re: [R

Re: [PATCH v2 0/2] sctp: fix src address selection if using secondary address

2015-07-20 Thread Vlad Yasevich
On 07/17/2015 11:34 AM, Marcelo Ricardo Leitner wrote: > This series improves the way SCTP chooses its src address so that the > choosen one will always belong to the interface being used for output. > > v1->v2: > - split out the refactoring from the fix itself > - Doing a full reverse routing a

Re: reproducable panic eviction work queue

2015-07-20 Thread Frank Schreuder
On 7/18/2015 05:32 PM, Nikolay Aleksandrov wrote: On 07/18/2015 05:28 PM, Johan Schuijt wrote: Thx for your looking into this! Thank you for the report, I will try to reproduce this locally Could you please post the full crash log ? Of course, please see attached file. Also could you test

RE: [PATCH net-next] cxgb4: Add debugfs entry to enable/disable backdoor access

2015-07-20 Thread Hariprasad S
From: Sergei Shtylyov [sergei.shtyl...@cogentembedded.com] Sent: Monday, July 20, 2015 5:43 PM To: Hariprasad S; netdev@vger.kernel.org Cc: da...@davemloft.net; Casey Leedom; Nirranjan Kirubaharan Subject: Re: [PATCH net-next] cxgb4: Add debugfs entry to en

  1   2   >