Re: [PATCH] Doc: z8530book: Fix typo in API-z8530-sync-txdma-open.html

2015-07-10 Thread David Miller
From: Masanari Iida Date: Fri, 10 Jul 2015 21:20:28 +0900 > This patch fix a spelling typo found in API-z8530-sync-txdma-open.html. > It is because this file was generated from comment in source, > I have to fix comment in source. > > Signed-off-by: Masanari Iida Applied, t hanks. -- To unsubs

Re: Panic with demuxed ipv4 multicast udp sockets on 4.0.4

2015-07-10 Thread Eric Dumazet
On Fri, 2015-07-10 at 13:31 -0700, Alex Gartrell wrote: > Hey everyone, > > There's some kind of nasty condition in which sk_rx_dst points to an > apparently garbage datastructure and it's blowing up in the early > demux code because dst->ops is NULL. The packet in question was for > bit torrent

Re: Fighting out-of-order reception with RPS?

2015-07-10 Thread Eric Dumazet
On Fri, 2015-07-10 at 22:36 +0200, Oliver Hartkopp wrote: > On 07/10/2015 04:48 AM, Tom Herbert wrote: > > On Wed, Jul 8, 2015 at 10:55 PM, Oliver Hartkopp > > wrote: > >> Both drivers do not use NAPI. The just follow the way > >> > >> interrupt -> alloc_skb() -> fill skb -> netif_rx(skb) > >> >

Re: [PATCH v2] net: inet_diag: always export IPV6_V6ONLY sockopt for listening sockets

2015-07-10 Thread David Miller
From: Phil Sutter Date: Fri, 10 Jul 2015 11:39:57 +0200 > Reconsidering my commit 20462155 "net: inet_diag: export IPV6_V6ONLY > sockopt", I am not happy with the limitations it causes for socket > analysing code in userspace. Exporting the value only if it is set makes > it hard for userspace to

Re: [PATCH net-next 0/9] be2net: patch set

2015-07-10 Thread David Miller
From: Sathya Perla Date: Fri, 10 Jul 2015 05:32:42 -0400 > Hi David, the following patch set has code cleanup patches, minor enhancements > and non-critical fixes. Pls consider applying to the net-next tree. Thanks! Series applied, thanks. -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH net-next v2] ipv6: Do not iterate over all interfaces when finding source address on specific interface.

2015-07-10 Thread David Miller
From: YOSHIFUJI Hideaki/吉藤英明 Date: Fri, 10 Jul 2015 16:58:31 +0900 > If outgoing interface is specified and the candidate address is > restricted to the outgoing interface, it is enough to iterate > over that given interface only. > > Signed-off-by: YOSHIFUJI Hideaki > Acked-by: Erik Kline Ap

Re: [PATCH] net: Drop owner assignment from platform_driver

2015-07-10 Thread David Miller
From: Krzysztof Kozlowski Date: Fri, 10 Jul 2015 15:29:23 +0900 > platform_driver does not need to set an owner because > platform_driver_register() will set it. > > Signed-off-by: Krzysztof Kozlowski Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe net

Re: [PATCH] net: phy: Support setting polarity in marvell phy driver

2015-07-10 Thread David Miller
From: David Thomson Date: Fri, 10 Jul 2015 16:28:25 +1200 > Support manually setting the polarity to mdi or mdix > > Signed-off-by: David Thomson Applied to net-next. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] net: phy: Pass mdix ethtool setting through to phy driver

2015-07-10 Thread David Miller
From: David Thomson Date: Fri, 10 Jul 2015 13:56:54 +1200 > Pass the mdix setting from ethtool down to the phy driver, to allow > driver specific implementations of manually setting the polarity. > > Signed-off-by: David Thomson Applied to net-next. -- To unsubscribe from this list: send the l

Re: [PATCH net-next 4/4] gianfar: Add paged allocation and Rx S/G

2015-07-10 Thread David Miller
From: Claudiu Manoil Date: Thu, 9 Jul 2015 19:24:44 +0300 > @@ -2839,6 +2815,94 @@ static irqreturn_t gfar_transmit(int irq, void *grp_id) > return IRQ_HANDLED; > } > > +static bool gfar_add_rx_frag(struct gfar_rx_buff *rxb, unsigned int lstatus, > + struct sk_bu

Re: [PATCH net-next 2/4] gianfar: Fix and cleanup rxbd status handling

2015-07-10 Thread David Miller
From: Claudiu Manoil Date: Thu, 9 Jul 2015 19:24:42 +0300 > @@ -2921,6 +2921,7 @@ int gfar_clean_rx_ring(struct gfar_priv_rx_q *rx_queue, > int rx_work_limit) > i = rx_queue->next_to_clean; > > while (rx_work_limit--) { > + unsigned long lstatus; > > if

Re: [PATCH v2] net: dsa: mv88e6xxx: add write access to debugfs regs file

2015-07-10 Thread David Miller
From: Vivien Didelot Date: Thu, 9 Jul 2015 17:13:29 -0400 > Allow write access to the regs file in the debugfs interface, with the > following parameters: > > echo> regs > > Where "name" is the register name (as shown in the header row), "reg" is > the register address (as shown in the

Re: [PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

2015-07-10 Thread David Miller
From: Marcelo Ricardo Leitner Date: Thu, 9 Jul 2015 11:15:19 -0300 > SCTP has this operation to peel off associations from a given socket and > create a new socket using this association. We currently have two ways > to use this operation: > - via getsockopt(), on which it will also create and r

Re: [PATCH -next] Revert "ipv4: use skb coalescing in defragmentation"

2015-07-10 Thread Eric Dumazet
On Sat, 2015-07-11 at 01:37 +0200, Florian Westphal wrote: > This reverts commit 3cc4949269e01f39443d0fcfffb5bc6b47878d45. > > There is nothing wrong with coalescing during defragmentation, it > reduces truesize overhead and simplifies things for the receiving > socket (no fraglist walk needed). >

Re: [PATCHv3 net 0/2] net: fixes for device unregistration

2015-07-10 Thread David Miller
From: Julian Anastasov Date: Thu, 9 Jul 2015 09:59:08 +0300 > Test script from Eric W. Biederman can catch a problem > where packets from backlog are processed long after the last > synchronize_net call. This can be reproduced after few tests > if commit 381c759d9916 ("ipv4: Avoid crashing in ip

Re: [RFC net-next] net: Build IPv6 into kernel by default

2015-07-10 Thread David Miller
From: Tom Herbert Date: Thu, 9 Jul 2015 13:42:29 -0700 > This patch makes the default to build IPv6 into the kernel. IPv6 > now has significant traction and any remaining vestiges of IPv6 > not being provided parity with IPv4 should be swept away. IPv6 is now > core to the Internet and kernel. I

Re: [PATCH net] bridge: mdb: allow the user to delete mdb entry if there's a querier

2015-07-10 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 9 Jul 2015 04:12:45 -0700 > From: Satish Ashok > > Until now when a querier was present static entries couldn't be deleted. > Fix this and allow the user to manipulate the mdb with or without a > querier. > > Signed-off-by: Satish Ashok > Signed-off-by: N

[PATCH -next] Revert "ipv4: use skb coalescing in defragmentation"

2015-07-10 Thread Florian Westphal
This reverts commit 3cc4949269e01f39443d0fcfffb5bc6b47878d45. There is nothing wrong with coalescing during defragmentation, it reduces truesize overhead and simplifies things for the receiving socket (no fraglist walk needed). However, it also destroys geometry of the original fragments. While t

[PATCH -next 6/6] netfilter: nftables: Only run the nftables chains in the proper netns

2015-07-10 Thread Eric W. Biederman
- Register the nftables chains in the network namespace that they need to run in. - Remove the hacks that stopped chains running in the wrong network namespace. Signed-off-by: "Eric W. Biederman" --- net/netfilter/nf_tables_api.c | 6 -- net/netfilter/nf_tables_core.c | 5 - 2 fil

[PATCH -next 5/6] netfilter: Per network namespace netfilter hooks.

2015-07-10 Thread Eric W. Biederman
- Add a new set of functions for registering and unregistering per network namespace hooks. - Modify the old global namespace hook functions to use the per network namespace hooks in their implementation, so their remains a single list that needs to be walked for any hook (this is important

[PATCH net v2] net: bcmgenet: fix accounting of packet drops vs errors

2015-07-10 Thread Petri Gynther
bcmgenet driver needs to separate packet drops from packet errors. When the driver has to drop a *good* packet, due to lack of buffers or replacement skbs, increment only dev->stats.[rx|tx]_dropped. When the driver encounters a bad Rx packet or Tx error, increment only dev->stats.[rx|tx]_errors +

[PATCH -next 4/6] netfilter: Factor out the hook list selection from nf_register_hook

2015-07-10 Thread Eric W. Biederman
- Add a new function find_nf_hook_list to select the nf_hook_list - Fail nf_register_hook when asked for a per netdevice hook list when support for per netdevice hook lists is not built into the kernel. - Move the hook list head selection outside of nf_hook_mutex as nothing in the selection

[PATCH -next 3/6] netfilter: Simply the tests for enabling and disabling the ingress queue hook

2015-07-10 Thread Eric W. Biederman
Replace an overcomplicated switch statement with a simple if statement. This also removes the ingress queue enable outside of nf_hook_mutex as the protection provided by the mutex is not necessary and the code is clearer having both of the static key increments together. Signed-off-by: "Eric W.

[PATCH -next 2/6] netfilter: kill nf_hooks_active

2015-07-10 Thread Eric W. Biederman
The function obscures what is going on in nf_hook_thresh and it's existence requires computing the hook list twice. Signed-off-by: "Eric W. Biederman" --- include/linux/netfilter.h | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/include/linux/netfilter.h b/include

[PATCH -next 1/6] netfilter: nf_queue: Don't recompute the hook_list head

2015-07-10 Thread Eric W. Biederman
If someone sends packets from one of the netdevice ingress hooks to the a userspace queue, and then userspace later accepts the packet, the netfilter code can enter an infinite loop as the list head will never be found. Pass in the saved list_head to avoid this. Signed-off-by: "Eric W. Biederman

[PATCH -next 0/6] Per network namespace netfilter chains

2015-07-10 Thread Eric W. Biederman
By maintining a set of functions to register and unregister netfilter hooks both globally and per network namespace I have managed to write a compact patchset that maintain per network netfilter chains, and registers the nftables netfilter hooks per network namespace. There are lots of other poss

Re: [PATCH v2] nohz: prevent tilegx network driver interrupts

2015-07-10 Thread Josh Cartwright
On Fri, Jul 10, 2015 at 07:06:23PM -0400, Chris Metcalf wrote: > On 7/10/2015 6:45 PM, Josh Cartwright wrote: > >>+static inline const struct cpumask *housekeeping_cpumask(void) > >>>+{ > >>>+#ifdef CONFIG_NO_HZ_FULL > >>>+ if (tick_nohz_full_enabled()) > >>>+ return housekeeping_mask; >

Re: [PATCH v2] nohz: prevent tilegx network driver interrupts

2015-07-10 Thread Chris Metcalf
On 7/10/2015 6:45 PM, Josh Cartwright wrote: +static inline const struct cpumask *housekeeping_cpumask(void) >+{ >+#ifdef CONFIG_NO_HZ_FULL >+ if (tick_nohz_full_enabled()) >+ return housekeeping_mask; >+#endif Just a small comment: We can take these checks out from under a #ifdef C

RE: [PATCH] ixgbe: Remove bimodal SR-IOV disabling

2015-07-10 Thread Rose, Gregory V
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Friday, July 10, 2015 3:44 PM > To: Rose, Gregory V > Cc: intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH] ixgbe: Remo

Re: [PATCH] vhost-blk: Add vhost-blk support v6

2015-07-10 Thread Ming Lin
On Sat, Dec 1, 2012 at 5:33 PM, Asias He wrote: > vhost-blk is an in-kernel virito-blk device accelerator. > > Due to lack of proper in-kernel AIO interface, this version converts > guest's I/O request to bio and use submit_bio() to submit I/O directly. > So this version any supports raw block dev

Re: [PATCH v2] nohz: prevent tilegx network driver interrupts

2015-07-10 Thread Josh Cartwright
On Fri, Jul 10, 2015 at 03:37:25PM -0400, Chris Metcalf wrote: > Normally the tilegx networking shim sends irqs to all the cores > to distribute the load of processing incoming-packet interrupts, > so that you can get to multiple Gb's of traffic inbound. > > However, in nohz_full mode we don't wan

Re: [PATCH] ixgbe: Remove bimodal SR-IOV disabling

2015-07-10 Thread Alex Williamson
On Fri, 2015-07-10 at 21:36 +, Rose, Gregory V wrote: > > > -Original Message- > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Friday, July 10, 2015 2:32 PM > > To: intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T > > Cc: netdev@vger.kernel.org; linux-ker...

RE: [PATCH] ixgbe: Remove bimodal SR-IOV disabling

2015-07-10 Thread Rose, Gregory V
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Friday, July 10, 2015 2:32 PM > To: intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Rose, Gregory V > Subject: [PATCH] ixgbe: Remove bim

[PATCH] ixgbe: Remove bimodal SR-IOV disabling

2015-07-10 Thread Alex Williamson
When unbinding an SR-IOV device with VFs configured from ixgbe, the driver behaves in one of two ways. If max_vfs was specified, the SR-IOV state is disabled, removing the VFs. The occurs regardless of whether the VF count was later modified through sysfs. If however max_vfs is zero, such as by

Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Scott Wood
On Fri, 2015-07-10 at 15:57 -0500, Pledge Roy-R01356 wrote: > > > > On Fri, 2015-07-10 at 13:36 +0200, Paul Bolle wrote: > > > On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote: > > > > +#ifdef CONFIG_FSL_DPA_CHECKING > > > > +#define DPA_ASSERT(x) \ > > > > + do { \ > > > > + if (!(x

Re: [PATCH 1/3] fixed_phy: handle link-down case

2015-07-10 Thread Stas Sergeev
10.07.2015 23:44, Florian Fainelli пишет: On 10/07/15 09:41, Stas Sergeev wrote: Currently fixed_phy driver recognizes only the link-up state. This simple patch adds an implementation of link-down state. The actual change is 1-line, the rest is an indentation. It is not clear to me how this is

Re: [PATCH 2/3] of_mdio: add new DT property 'autoneg' for fixed-link

2015-07-10 Thread Stas Sergeev
10.07.2015 23:39, Florian Fainelli пишет: - in-band status is an implementation delail, and it is specific to a particular protocols. If you request the in-band status for some protocol that doesn't support it, perhaps you should get -EINVAL, because such a config makes no sense. With autonegotia

RE: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Roy Pledge
> > On Fri, 2015-07-10 at 13:36 +0200, Paul Bolle wrote: > > On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote: > > > +#ifdef CONFIG_FSL_DPA_CHECKING > > > +#define DPA_ASSERT(x) \ > > > + do { \ > > > + if (!(x)) { \ > > > + pr_crit("ASSERT: (%s:%d) %s\n", __FILE__,

Re: [PATCH 1/3] fixed_phy: handle link-down case

2015-07-10 Thread Florian Fainelli
On 10/07/15 09:41, Stas Sergeev wrote: > > Currently fixed_phy driver recognizes only the link-up state. > This simple patch adds an implementation of link-down state. > The actual change is 1-line, the rest is an indentation. It is not clear to me how this is useful, if you have a link_update ca

Re: [PATCH v2 0/2] net: enable inband link state negotiation only when explicitly requested

2015-07-10 Thread Stas Sergeev
10.07.2015 23:31, Florian Fainelli пишет: On 10/07/15 09:38, Stas Sergeev wrote: Hello. Currently the link status auto-negotiation is enabled for any SGMII link with fixed-link DT binding. The regression was reported: https://lkml.org/lkml/2015/7/8/865 Apparently not all HW that implements SGMI

Re: [PATCH 2/3] of_mdio: add new DT property 'autoneg' for fixed-link

2015-07-10 Thread Florian Fainelli
On 10/07/15 13:08, Stas Sergeev wrote: > 10.07.2015 21:37, Florian Fainelli пишет: >> On 10/07/15 09:43, Stas Sergeev wrote: >>> Currently for fixed-link the MAC driver decides whether to use the >>> link status auto-negotiation or not. >>> Unfortunately the auto-negotiation may not work when expec

Re: Fighting out-of-order reception with RPS?

2015-07-10 Thread Oliver Hartkopp
On 07/10/2015 04:48 AM, Tom Herbert wrote: > On Wed, Jul 8, 2015 at 10:55 PM, Oliver Hartkopp > wrote: >> Both drivers do not use NAPI. The just follow the way >> >> interrupt -> alloc_skb() -> fill skb -> netif_rx(skb) >> >> I'm usually testing with the USB adapters as the PCIe setup is not very

Re: [PATCH v2 0/2] net: enable inband link state negotiation only when explicitly requested

2015-07-10 Thread Florian Fainelli
On 10/07/15 09:38, Stas Sergeev wrote: > Hello. > > Currently the link status auto-negotiation is enabled > for any SGMII link with fixed-link DT binding. > The regression was reported: > https://lkml.org/lkml/2015/7/8/865 > Apparently not all HW that implements SGMII protocol, generates the > inb

Panic with demuxed ipv4 multicast udp sockets on 4.0.4

2015-07-10 Thread Alex Gartrell
Hey everyone, There's some kind of nasty condition in which sk_rx_dst points to an apparently garbage datastructure and it's blowing up in the early demux code because dst->ops is NULL. The packet in question was for bit torrent local peer discovery https://en.wikipedia.org/wiki/Local_Peer_Discov

Re: [PATCH 2/3] of_mdio: add new DT property 'autoneg' for fixed-link

2015-07-10 Thread Stas Sergeev
10.07.2015 21:37, Florian Fainelli пишет: On 10/07/15 09:43, Stas Sergeev wrote: Currently for fixed-link the MAC driver decides whether to use the link status auto-negotiation or not. Unfortunately the auto-negotiation may not work when expected by the MAC driver. Sebastien Rannou explains: <<

Re: [PATCH 1/2] net: dsa: mv88e6xxx: sleep in _mv88e6xxx_stats_wait

2015-07-10 Thread Guenter
Hi Vivien, On Fri, Jul 10, 2015 at 03:21:47PM -0400, Vivien Didelot wrote: > Hi Guenter, > >> I must have missed where is the benefit from spin reading 10 times this > >> register, rather than sleeping 1ms between tests. Does this busy bit > >> behaves differently from the phy, atu, scratch, or vt

[PATCH v2] nohz: prevent tilegx network driver interrupts

2015-07-10 Thread Chris Metcalf
Normally the tilegx networking shim sends irqs to all the cores to distribute the load of processing incoming-packet interrupts, so that you can get to multiple Gb's of traffic inbound. However, in nohz_full mode we don't want to interrupt the nohz_full cores by default, so we limit the set of cor

Re: [PATCH v2 08/22] fjes: net_device_ops.ndo_start_xmit

2015-07-10 Thread Yasuaki Ishimatsu
Hi Izumi-san, On Wed, 24 Jun 2015 11:55:40 +0900 Taku Izumi wrote: > This patch adds net_device_ops.ndo_start_xmit callback, > which is called when sending packets. > > Signed-off-by: Taku Izumi > --- > drivers/net/fjes/fjes.h | 1 + > drivers/net/fjes/fjes_hw.c | 58 ++

Re: [PATCH 1/2] net: dsa: mv88e6xxx: sleep in _mv88e6xxx_stats_wait

2015-07-10 Thread Vivien Didelot
Hi Guenter, On Jul 10, 2015, at 2:36 PM, Guenter Roeck li...@roeck-us.net wrote: > Hi Vivien, > > On Fri, Jul 10, 2015 at 02:20:47PM -0400, Vivien Didelot wrote: >> > >> > is this really beneficial and/or needed ? >> >> Except using existing generic code, no. >> >> > It adds at least 1ms dela

Re: [PATCH] nohz: prevent tilegx network driver interrupts

2015-07-10 Thread Chris Metcalf
On 07/10/2015 02:24 PM, Frederic Weisbecker wrote: On Fri, Jul 10, 2015 at 01:33:44PM -0400, Chris Metcalf wrote: In nohz_full mode, by default distribute networking shim interrupts across the housekeeping cores, not all the cores. I can't really tell, I have no idea what this driver does. It s

Re: [RFC net-next 11/22] dst: Metadata destinations

2015-07-10 Thread Thomas Graf
On 07/10/15 at 09:57pm, Julian Anastasov wrote: > > Hello, > > On Fri, 10 Jul 2015, Thomas Graf wrote: > > > --- a/net/ipv4/route.c > > +++ b/net/ipv4/route.c > > @@ -1691,6 +1691,8 @@ static int ip_route_input_slow(struct sk_buff *skb, > > __be32 daddr, __be32 saddr, > >by fib_lo

re: net: fec: Ensure clocks are enabled while using mdio bus

2015-07-10 Thread Tyler Baker
Hi Andrew, The kernelci.org system reported[1][2][3] new imx6 boot failures in next-20150710. I've bisected[4] these failures to 6c3e921b18ed "net: fec: Ensure clocks are enabled while using mdio bus". Reverting this commit on top of next-20150710, resolves the boot failu

Re: [RFC net-next 11/22] dst: Metadata destinations

2015-07-10 Thread Julian Anastasov
Hello, On Fri, 10 Jul 2015, Thomas Graf wrote: > --- a/net/ipv4/route.c > +++ b/net/ipv4/route.c > @@ -1691,6 +1691,8 @@ static int ip_route_input_slow(struct sk_buff *skb, > __be32 daddr, __be32 saddr, > by fib_lookup. >*/ > > + skb_dst_drop(skb); > + Th

Re: [RFC net-next 12/22] arp: Inherit metadata dst when creating ARP requests

2015-07-10 Thread Sergei Shtylyov
On 07/10/2015 05:19 PM, Thomas Graf wrote: If output device wants to see the dst, inherit the dst of the original skb and pass it on to generate the ARP request. Signed-off-by: Thomas Graf --- net/ipv4/arp.c | 71 +++--- 1 file changed,

Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Scott Wood
On Fri, 2015-07-10 at 13:29 -0500, Pledge Roy-R01356 wrote: > > return in_be32((void *)bm + offset); > > > ^ > > > [...]/drivers/soc/fsl/qbman/bman.c: In function ‘__bm_out’: > > > [...]/drivers/soc/fsl/qbman/bman.c:172:2: error: implicit declaration > > > of function ‘out_be32’ [-Werror

Re: [RFC net-next 3/6] net: Introduce VRF device driver - v2

2015-07-10 Thread David Ahern
On 7/9/15 10:56 PM, Eric W. Biederman wrote: I have given specific areas of concern, and explained myself and you are blowing me off. You have not had answered my question with any additional details or code references -- ie., a specific example. Asking you for clarification and details is no

Re: [PATCH 2/3] of_mdio: add new DT property 'autoneg' for fixed-link

2015-07-10 Thread Florian Fainelli
On 10/07/15 09:43, Stas Sergeev wrote: > > Currently for fixed-link the MAC driver decides whether to use the > link status auto-negotiation or not. > Unfortunately the auto-negotiation may not work when expected by > the MAC driver. Sebastien Rannou explains: > << Yes, I confirm that my HW does n

Re: [PATCH 1/2] net: dsa: mv88e6xxx: sleep in _mv88e6xxx_stats_wait

2015-07-10 Thread Guenter Roeck
Hi Vivien, On Fri, Jul 10, 2015 at 02:20:47PM -0400, Vivien Didelot wrote: > > > > is this really beneficial and/or needed ? > > Except using existing generic code, no. > > > It adds at least 1ms delay to a loop which did not have any delay at > > all unless the register read itself was sleepin

Re: [PATCH] nohz: prevent tilegx network driver interrupts

2015-07-10 Thread Frederic Weisbecker
On Fri, Jul 10, 2015 at 01:33:44PM -0400, Chris Metcalf wrote: > In nohz_full mode, by default distribute networking shim > interrupts across the housekeeping cores, not all the cores. I can't really tell, I have no idea what this driver does. It seems to be about networking CPUs but I have no ide

RE: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Roy Pledge
> return in_be32((void *)bm + offset); > > ^ > > [...]/drivers/soc/fsl/qbman/bman.c: In function ‘__bm_out’: > > [...]/drivers/soc/fsl/qbman/bman.c:172:2: error: implicit declaration > > of function ‘out_be32’ [-Werror=implicit-function-declaration] > > out_be32((void *)bm + offset, va

Re: [RFC PATCH net-next] sctp: fix src address selection if using secondary addresses

2015-07-10 Thread Marcelo Ricardo Leitner
On Fri, Jul 10, 2015 at 01:14:21PM -0400, Vlad Yasevich wrote: > On 07/10/2015 12:17 PM, Marcelo Ricardo Leitner wrote: > > On Fri, Jul 10, 2015 at 11:35:28AM -0400, Vlad Yasevich wrote: > >> On 07/10/2015 07:53 AM, Marcelo Ricardo Leitner wrote: > >>> On Thu, Jul 09, 2015 at 09:55:19PM +0200, Mich

Re: [PATCH 1/2] of_mdio: add new DT property 'link' for fixed-link

2015-07-10 Thread Florian Fainelli
On 10/07/15 04:20, Stas Sergeev wrote: > 10.07.2015 11:46, Sebastien Rannou пишет: >> On Fri, 10 Jul 2015, Stas Sergeev wrote: >> >>> 10.07.2015 00:15, Florian Fainelli пишет: Then, if the in-band status indication is not reliable (which really should be completely understood), >>> Agree!

Re: [PATCH 1/2] net: dsa: mv88e6xxx: sleep in _mv88e6xxx_stats_wait

2015-07-10 Thread Vivien Didelot
Hi Guenter, On Jul 10, 2015, at 1:10 PM, Guenter Roeck li...@roeck-us.net wrote: > On Fri, Jul 10, 2015 at 12:57:28PM -0400, Vivien Didelot wrote: >> The current _mv88e6xxx_stats_wait function does not sleep while testing >> the stats busy bit. Fix this by using the generic _mv88e6xxx_wait >> fun

[PATCH] ravb: kill useless initializers

2015-07-10 Thread Sergei Shtylyov
Some of the local variable intializers in the driver turned out to be pointless, kill them. Signed-off-by: Sergei Shtylyov --- The patch is against the Dave Miller's 'net-next.git' repo. Changes in version 2: - fixed typo in the subject. drivers/net/ethernet/renesas/ravb_main.c | 12 ++-

[PATCH] ravb: kill usless initializers

2015-07-10 Thread Sergei Shtylyov
Some of the local variable intializers in the driver turned out to be pointless, kill them. Signed-off-by: Sergei Shtylyov --- The patch is against the Dave Miller's 'net-next.git' repo. drivers/net/ethernet/renesas/ravb_main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(

[PATCH] nohz: prevent tilegx network driver interrupts

2015-07-10 Thread Chris Metcalf
In nohz_full mode, by default distribute networking shim interrupts across the housekeeping cores, not all the cores. Signed-off-by: Chris Metcalf --- The alternate approaches to this might be: 1. "#define housekeeping_mask cpu_online_mask" in the non-nohz_full arm in , then just unconditiona

Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Scott Wood
On Fri, 2015-07-10 at 13:36 +0200, Paul Bolle wrote: > On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote: > > +#ifdef CONFIG_FSL_DPA_CHECKING > > +#define DPA_ASSERT(x) \ > > + do { \ > > + if (!(x)) { \ > > + pr_crit("ASSERT: (%s:%d) %s\n", __FILE__, __LINE__, \ > >

Re: [PATCH 02/11] soc/fsl: Introduce DPAA BMan device management driver

2015-07-10 Thread Scott Wood
On Fri, 2015-07-10 at 10:38 +0200, Paul Bolle wrote: > On do, 2015-07-09 at 16:21 -0400, Roy Pledge wrote: > > --- /dev/null > > +++ b/drivers/soc/fsl/qbman/Kconfig > > @@ -0,0 +1,33 @@ > > +menuconfig FSL_DPA > > + bool "Freescale DPAA support" > > + depends on FSL_SOC || COMPILE_TEST > > Are

Re: [PATCH 2/2] net: dsa: mv88e6xxx: call _mv88e6xxx_stats_wait with SMI lock held

2015-07-10 Thread Guenter
On Fri, Jul 10, 2015 at 12:57:29PM -0400, Vivien Didelot wrote: > At switch setup, _mv88e6xxx_stats_wait was called without holding the > SMI mutex. Fix this by requesting the lock for this call. > > Also, return the _mv88e6xxx_stats_wait code, since it may fail. > > Signed-off-by: Vivien Didelot

Re: [RFC PATCH net-next] sctp: fix src address selection if using secondary addresses

2015-07-10 Thread Vlad Yasevich
On 07/10/2015 12:17 PM, Marcelo Ricardo Leitner wrote: > On Fri, Jul 10, 2015 at 11:35:28AM -0400, Vlad Yasevich wrote: >> On 07/10/2015 07:53 AM, Marcelo Ricardo Leitner wrote: >>> On Thu, Jul 09, 2015 at 09:55:19PM +0200, Michael Tuexen wrote: > On 09 Jul 2015, at 18:54, Marcelo Ricardo Leitn

Re: [PATCH 1/2] net: dsa: mv88e6xxx: sleep in _mv88e6xxx_stats_wait

2015-07-10 Thread Guenter
On Fri, Jul 10, 2015 at 12:57:28PM -0400, Vivien Didelot wrote: > The current _mv88e6xxx_stats_wait function does not sleep while testing > the stats busy bit. Fix this by using the generic _mv88e6xxx_wait > function. > > Note that it requires to move _mv88e6xxx_wait on top of > _mv88e6xxx_stats_w

Re: [RFC net-next 03/22] ipv4: support for fib route lwtunnel encap attributes

2015-07-10 Thread roopa
On 7/10/15, 9:54 AM, Thomas Graf wrote: On 07/10/15 at 05:36pm, Eric Dumazet wrote: On Fri, 2015-07-10 at 16:19 +0200, Thomas Graf wrote: From: Roopa Prabhu + if (oif) + dev = __dev_get_by_index(net, oif); + ret = lwtunnel_build_state(dev, encap_type, +

[PATCH 2/2] net: dsa: mv88e6xxx: call _mv88e6xxx_stats_wait with SMI lock held

2015-07-10 Thread Vivien Didelot
At switch setup, _mv88e6xxx_stats_wait was called without holding the SMI mutex. Fix this by requesting the lock for this call. Also, return the _mv88e6xxx_stats_wait code, since it may fail. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx.c | 7 +-- 1 file changed, 5 insertions

[PATCH 1/2] net: dsa: mv88e6xxx: sleep in _mv88e6xxx_stats_wait

2015-07-10 Thread Vivien Didelot
The current _mv88e6xxx_stats_wait function does not sleep while testing the stats busy bit. Fix this by using the generic _mv88e6xxx_wait function. Note that it requires to move _mv88e6xxx_wait on top of _mv88e6xxx_stats_wait to avoid undefined reference compilation error. Signed-off-by: Vivien D

Re: [RFC net-next 03/22] ipv4: support for fib route lwtunnel encap attributes

2015-07-10 Thread Thomas Graf
On 07/10/15 at 05:36pm, Eric Dumazet wrote: > On Fri, 2015-07-10 at 16:19 +0200, Thomas Graf wrote: > > From: Roopa Prabhu > > > > + if (oif) > > + dev = __dev_get_by_index(net, oif); > > + ret = lwtunnel_build_state(dev, encap_type, > > + encap, &lwtst

Re: [PATCH 03/11] soc/fsl: Introduce the DPAA BMan portal driver

2015-07-10 Thread Paul Bolle
Hi Roy, On vr, 2015-07-10 at 15:19 +, Roy Pledge wrote: > Thanks you for your valuable feedback so far. You're welcome. Please note that I just scan for, well, common build issues. Ie, stuff that requires no domain specific knowledge. > Let me try to address a general issue you mention below

[PATCH 3/3] mvneta: use inband status only when explicitly enabled

2015-07-10 Thread Stas Sergeev
The commit 898b2970e2c9 ("mvneta: implement SGMII-based in-band link state signaling") implemented the link parameters auto-negotiation unconditionally. Unfortunately it appears that some HW that implements SGMII protocol, doesn't generate the inband status, so it is not possible to auto-negotiate

[PATCH 2/3] of_mdio: add new DT property 'autoneg' for fixed-link

2015-07-10 Thread Stas Sergeev
Currently for fixed-link the MAC driver decides whether to use the link status auto-negotiation or not. Unfortunately the auto-negotiation may not work when expected by the MAC driver. Sebastien Rannou explains: << Yes, I confirm that my HW does not generate an in-band status. AFAIK, it's a PHY th

[PATCH 1/3] fixed_phy: handle link-down case

2015-07-10 Thread Stas Sergeev
Currently fixed_phy driver recognizes only the link-up state. This simple patch adds an implementation of link-down state. The actual change is 1-line, the rest is an indentation. Signed-off-by: Stas Sergeev CC: Florian Fainelli CC: netdev@vger.kernel.org CC: linux-ker...@vger.kernel.org ---

Re: Kernel Oops in __inet_twsk_kill()

2015-07-10 Thread Phani
> > > The problem has been fixed. It is introduced by a third party patch, > > which decreases the refcnt of timewait socket. > What is the fix? pl share the gerrit. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org Mo

[PATCH v2 0/2] net: enable inband link state negotiation only when explicitly requested

2015-07-10 Thread Stas Sergeev
Hello. Currently the link status auto-negotiation is enabled for any SGMII link with fixed-link DT binding. The regression was reported: https://lkml.org/lkml/2015/7/8/865 Apparently not all HW that implements SGMII protocol, generates the inband status for the auto-negotiation to work. More detai

Re: [RFC PATCH net-next] sctp: fix src address selection if using secondary addresses

2015-07-10 Thread Marcelo Ricardo Leitner
On Fri, Jul 10, 2015 at 11:35:28AM -0400, Vlad Yasevich wrote: > On 07/10/2015 07:53 AM, Marcelo Ricardo Leitner wrote: > > On Thu, Jul 09, 2015 at 09:55:19PM +0200, Michael Tuexen wrote: > >>> On 09 Jul 2015, at 18:54, Marcelo Ricardo Leitner > >>> wrote: > >>> > >>> Cc'ing Michael too. > >> I'm

Re: [RFC net-next 03/22] ipv4: support for fib route lwtunnel encap attributes

2015-07-10 Thread Eric Dumazet
On Fri, 2015-07-10 at 16:19 +0200, Thomas Graf wrote: > From: Roopa Prabhu > + if (oif) > + dev = __dev_get_by_index(net, oif); > + ret = lwtunnel_build_state(dev, encap_type, > +encap, &lwtstate); > + if (!ret) { > + lwtunnel_s

Re: [RFC PATCH net-next] sctp: fix src address selection if using secondary addresses

2015-07-10 Thread Vlad Yasevich
On 07/10/2015 07:53 AM, Marcelo Ricardo Leitner wrote: > On Thu, Jul 09, 2015 at 09:55:19PM +0200, Michael Tuexen wrote: >>> On 09 Jul 2015, at 18:54, Marcelo Ricardo Leitner >>> wrote: >>> >>> Cc'ing Michael too. >> I'm not familiar with the Linux kernel code, so I can't comment on it. >> But ma

RE: [PATCH 03/11] soc/fsl: Introduce the DPAA BMan portal driver

2015-07-10 Thread Roy Pledge
Paul, Thanks you for your valuable feedback so far. Let me try to address a general issue you mention below: unused exported APIs. The QMan and BMan drivers provide a base layer for other blocks built on top of them, for instance an Ethernet Driver, an Encrypt/Decrypt Engine, a pattern match

[PATCH net-next] bridge: mdb: add vlan support for user entries

2015-07-10 Thread Nikolay Aleksandrov
Until now all user mdb entries were added in vlan 0, this patch adds support to allow the user to specify the vlan for the entry. About the uapi change a hole in struct br_mdb_entry is used so the size and offsets are kept the same (verified with pahole and tested with older iproute2). Example: $

[RFC net-next 16/22] fib: Add fib rule match on tunnel id

2015-07-10 Thread Thomas Graf
This add the ability to select a routing table based on the tunnel id which allows to maintain separate routing tables for each virtual tunnel network. ip rule add from all tunnel-id 100 lookup 100 ip rule add from all tunnel-id 200 lookup 200 Signed-off-by: Thomas Graf --- include/net/fib_rule

[RFC net-next 19/22] openvswitch: Move dev pointer into vport itself

2015-07-10 Thread Thomas Graf
This is the first step in representing all OVS vports as regular struct net_devices. Move the net_device pointer into the vport structure itself to get rid of struct vport_netdev. Signed-off-by: Thomas Graf Signed-off-by: Pravin B Shelar --- net/openvswitch/datapath.c | 7 +-- net/op

[RFC net-next 06/22] ipv4: redirect dst output to lwtunnel output

2015-07-10 Thread Thomas Graf
From: Roopa Prabhu For input routes with tunnel encap state this patch redirects dst output functions to lwtunnel_output which later resolves to the corresponding lwtunnel output function. This has been tested to work with mpls ip tunnels. Open items: Support for tunnel mtu, pmtu, fragmentation

[RFC net-next 17/22] vxlan: Factor out device configuration

2015-07-10 Thread Thomas Graf
This factors out the device configuration out of the RTNL newlink API which allows for in-kernel creation of VXLAN net_devices. Signed-off-by: Thomas Graf --- drivers/net/vxlan.c | 332 include/net/vxlan.h | 59 ++ 2 files changed, 23

[RFC net-next 15/22] route: Per route IP tunnel metadata via lightweight tunnel

2015-07-10 Thread Thomas Graf
This introduces a new IP tunnel lightweight tunnel type which allows to specify IP tunnel instructions per route. Only IPv4 is supported at this point. Signed-off-by: Thomas Graf --- drivers/net/vxlan.c| 10 +++- include/net/dst_metadata.h | 12 - include/net/ip_tunnels.h

[RFC net-next 07/22] ipv6: rt6_info output redirect to tunnel output

2015-07-10 Thread Thomas Graf
From: Roopa Prabhu This is similar to ipv4 redirect of dst output to lwtunnel output function for encapsulation and xmit. Signed-off-by: Roopa Prabhu --- net/ipv6/route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index acfe25d..6c328bb 100644 --- a

[RFC net-next 18/22] openvswitch: Make tunnel set action attach a metadata dst

2015-07-10 Thread Thomas Graf
Utilize the new metadata dst to attach encapsulation instructions to the skb. The existing egress_tun_info via the OVS_CB() is left in place until all tunnel vports have been converted to the new method. Signed-off-by: Thomas Graf Signed-off-by: Pravin B Shelar --- net/openvswitch/actions.c

[RFC net-next 13/22] vxlan: Flow based tunneling

2015-07-10 Thread Thomas Graf
Allows putting a VXLAN device into a new flow-based mode in which it will populate a ip_tunnel_info struct for each packet received and attach it to the skb using the new metadata dst. The metadata structure will contain the outer header and tunnel header fields which have been stripped off. Layers

[RFC net-next 20/22] openvswitch: Abstract vport name through ovs_vport_name()

2015-07-10 Thread Thomas Graf
This allows to get rid of the get_name() vport ops later on. Signed-off-by: Thomas Graf --- net/openvswitch/datapath.c | 4 ++-- net/openvswitch/vport-internal_dev.c | 1 - net/openvswitch/vport-netdev.c | 6 -- net/openvswitch/vport-netdev.h | 1 - net/openvswitch/vpor

[RFC net-next 11/22] dst: Metadata destinations

2015-07-10 Thread Thomas Graf
Introduces a new dst_metadata which enables to carry per packet metadata between forwarding and processing elements via the skb->dst pointer. The structure is set up to be a union. Thus, each separate type of metadata requires its own dst instance. If demand arises to carry multiple types of metad

[RFC net-next 12/22] arp: Inherit metadata dst when creating ARP requests

2015-07-10 Thread Thomas Graf
If output device wants to see the dst, inherit the dst of the original skb and pass it on to generate the ARP request. Signed-off-by: Thomas Graf --- net/ipv4/arp.c | 71 +++--- 1 file changed, 43 insertions(+), 28 deletions(-) diff --git a/ne

[RFC net-next 21/22] openvswitch: Use regular VXLAN net_device device

2015-07-10 Thread Thomas Graf
This gets rid of all OVS specific VXLAN code in the receive and transmit path by using a VXLAN net_device to represent the vport. Only a small shim layer remains which takes care of handling the VXLAN specific OVS Netlink configuration. Unexports vxlan_sock_add(), vxlan_sock_release(), vxlan_xmit_

[RFC net-next 22/22] openvswitch: Use regular GRE net_device instead of vport

2015-07-10 Thread Thomas Graf
From: Pravin Shelar Removes all of the OVS specific GRE code and makes OVS use a GRE net_device. Signed-off-by: Pravin B Shelar --- net/core/dev.c | 5 +- net/ipv4/ip_gre.c | 165 +- net/openvswitch/Makefile | 1 - net/openvswitch/vpor

[RFC net-next 14/22] route: Extend flow representation with tunnel key

2015-07-10 Thread Thomas Graf
Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to allow routes to match on tunnel metadata. For now, the tunnel id is added to flowi_tunnel which allows for routes to be bound to specific virtual tunnels. Signed-off-by: Thomas Graf --- include/net/flow.h | 7 +++ net/ipv

  1   2   >