Re: [PATCH v2 0/1] Add PTP cross-timestamp to the PTP driver interface

2015-07-02 Thread Richard Cochran
On Thu, Jul 02, 2015 at 06:14:47PM -0700, Christopher Hall wrote: > This patch adds an additional callback getsynctime64(). Which will be called > when the driver is able to perform a more accurate, implementation specific > cross-timestamping. For example, future network devices that implement

GRO not happening in VM with VxLAN

2015-07-02 Thread Santosh R
Hi, I am testing VxLAN performance between VMs using 3.18 host kernel. For this I am using below command to bring up the VM. # qemu-system-x86_64 -m 4096 -smp 4 -boot c -device virtio-net-pci,netdev=tap0,mac=00:11:22:33:44:55 -netdev tap,id=tap0,script=no,vhost=on -drive file=/root/vdisk_rhel6

[PATCH net] cxgb4: Fix incorrect sequence numbers shown in devlog

2015-07-02 Thread Hariprasad Shenai
Part of commit 49aa284fe64c4c1 ("cxgb4: Add support for devlog") change introduced a real bug where the Device Log Sequence Numbers are no longer being converted from firmware Big-Endian to local CPU-Endian format. This patch moves all of the translation into the devlog_show() routine. The only en

Re: [RFC PATCH net-next] tcp: add NV congestion control

2015-07-02 Thread Eric Dumazet
On Thu, 2015-07-02 at 18:21 -0700, Lawrence Brakmo wrote: > This is a request for comments. > > TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of > NV was presented at 2010's LPC (slides). It is a delayed based > congestion avoidance for the data center. This version has bee

[PATCH] Logically DeadCode

2015-07-02 Thread Rahul Jain
hello, From 0c34030166a150d6d9f1ab52e7bb40a5440a68c2 Mon Sep 17 00:00:00 2001 From: Rahul Jain Date: Fri, 3 Jul 2015 10:19:12 +0530 Subject: [PATCH] Logically DeadCode Signed-off-by: Rahul Jain Signed-off-by: Amit Khatri --- net/wireless/util.c| 3 --- net/wireless/wext-compat.c | 3 -

Re: [PATCH net-next 1/3] gro: Pull headers into skb head for 1st skb in gro list

2015-07-02 Thread Eric Dumazet
On Thu, 2015-07-02 at 14:04 -0700, Tom Herbert wrote: > When setting up the first skb in a gro list we ensure that all the > headers up to skb_gro_offset have been pulled into head. In subsequent > uses of this skb (e.g. determining same_flow) it is assumed that the > headers can be accessed in the

[PATCH net-next] ipv6: sysctl to restrict candidate source addresses

2015-07-02 Thread Erik Kline
Per RFC 6724, section 4, "Candidate Source Addresses": It is RECOMMENDED that the candidate source addresses be the set of unicast addresses assigned to the interface that will be used to send to the destination (the "outgoing" interface). Add a sysctl to enable this behaviour. Signe

Re: [PATCH net-next] net: bail on sock_wfree, sock_rfree when we have a TCP_TIMEWAIT sk

2015-07-02 Thread Eric Dumazet
On Thu, 2015-07-02 at 14:18 -0700, Alex Gartrell wrote: > On Thu, Jul 2, 2015 at 1:44 AM, Julian Anastasov wrote: > > I think, your patch from January is almost > > good: > > I'll rebase it, add your other suggestions, test it, and send it in. > > > And the patch from Eric for IPVS looks

[PATCH v2] ipv6: Make MLD packets to only be processed locally

2015-07-02 Thread Hermin Anggawijaya
Before commit daad151263cf ("ipv6: Make ipv6_is_mld() inline and use it from ip6_mc_input().") MLD packets were only processed locally. After the change, a copy of MLD packet goes through ip6_mr_input, causing MRT6MSG_NOCACHE message to be generated to user space. Make MLD packet only processed lo

[RFC PATCH net-next] tcp: add NV congestion control

2015-07-02 Thread Lawrence Brakmo
This is a request for comments. TCP-NV (New Vegas) is a major update to TCP-Vegas. An earlier version of NV was presented at 2010's LPC (slides). It is a delayed based congestion avoidance for the data center. This version has been tested within a 10G rack where the HW RTTs are 20-50us. A descrip

[PATCH v2 0/1] Add PTP cross-timestamp to the PTP driver interface

2015-07-02 Thread Christopher Hall
This patch allows system and device time ("cross-timestamp") to be performed by the driver. Currently, the cross-timestamping is performed in the PTP_SYS_OFFSET ioctl. The PTP clock driver reads gettimeofday() and the gettime64() callback provided by the driver. The cross-timestamp is best effo

[PATCH v2 1/1] Added additional callback to ptp_clock_info:

2015-07-02 Thread Christopher Hall
* getsynctime64() This takes 2 arguments referring to system and device time With this callback drivers may provide both system time and device time to ensure precise correlation Modified PTP_SYS_OFFSET ioctl in PTP clock driver to use the above callback if it's available Added capability (PTP_

Searching for mentor - writing kernel-space VPN & more

2015-07-02 Thread Jason A. Donenfeld
Hi all, I'm working on a fairly advanced kernel space VPN with some interesting design choices. It's requiring me to dig pretty deep into the networking stack. Admittedly I'm a bit in over my head right now. Does anyone with deep knowledge and experience, especially inside the networking stack, ha

Re: amd-xgbe e0700000.xgmac: DMA-API: device driver tries to sync DMA memory it has not allocated

2015-07-02 Thread Tom Lendacky
On 07/02/2015 02:02 PM, Kim Phillips wrote: Hi Tom, A pristine 4.1 kernel with CONFIG_DMA_API_DEBUG=y produces this call trace on an AMD Seattle: [ 112.896576] [ cut here ] [ 112.896591] WARNING: CPU: 2 PID: 1059 at lib/dma-debug.c:1202 check_sync+0x138/0x56c() [ 112

Re: [PATCH] rtnetlink: Actually use the policy for the IFLA_VF_INFO

2015-07-02 Thread Jason Gunthorpe
On Thu, Jul 02, 2015 at 10:34:54AM +0200, Daniel Borkmann wrote: > >So, commit c02db8c6290b moved it into a nested attribute (IFLA_VF_INFO) > >where we indeed don't do further validation. Imho, we should pass the > >parsed attribute table from nla_parse_nested() down into do_setvfinfo(), > >somethi

RE: amd-xgbe e0700000.xgmac: DMA-API: device driver tries to sync DMA memory it has not allocated

2015-07-02 Thread Lendacky, Thomas
Hi Kim, Actually I took a closer look at the DMA debug code and it's an 8k boundary that is crossed. I've been able to reproduce the issue so I'll see if my fix takes care of it. Thanks, Tom -Original Message- From: Lendacky, Thomas Sent: Thursday, July 02, 2015 3:40 PM To: 'Kim Phil

Re: Bpqether broken in 4.1

2015-07-02 Thread Ralf Baechle
On Thu, Jul 02, 2015 at 04:03:07PM -0500, Eric W. Biederman wrote: > > Eric's Commit 1d5da757da860a6916adbf68b09e868062b4b3b8 (ax25: Stop using > > magic neighbour cache operations.) breaks IP traffic over the AX.25 bpqether > > driver. > > Sigh. NETIF_F_LLTX is not set so recursion does not wor

[RFC patch] sctp: sctp_generate_fwdtsn: Initialize sctp_fwdtsn_skip array, neatening

2015-07-02 Thread Joe Perches
It's not clear to me that the sctp_fwdtsn_skip array is always initialized when used. It is appropriate to initialize the array to 0? This patch initializes the array too 0 and moves the local variables into the blocks where used. It also does some miscellaneous neatening by using continue; and

Webmail ICT Help Desk

2015-07-02 Thread Web-mail Admin
Our records indicate that your E-mail® Account could not be automatically updated with our F-Secure R-HTK4S new(2015) version anti-spam/anti-virus/anti-spyware. Please provide us with the following details below to update manually Full Name:...> Email..> User ID..> Password.

Please backport 63b46242f707849 [was: Issue with LACP mode in linux bonding driver]

2015-07-02 Thread Jonathan Toppins
Please back port the following to the LTS trees v3.2, v3.4, v3.10, v3.12, v3.14, and v3.18 commit 63b46242f707849a1df10b70e026281bfa40e849 Author: Wilson Kok Date: Mon Jan 26 01:16:59 2015 -0500 bonding: fix incorrect lacp mux state when agg not active Sending this to verify the above p

Re: [PATCH net-next] net: bail on sock_wfree, sock_rfree when we have a TCP_TIMEWAIT sk

2015-07-02 Thread Alex Gartrell
On Thu, Jul 2, 2015 at 2:18 PM, Alex Gartrell wrote: > If early demux was enabled, we'd use the route from the socket Actually now that I think about it, this is probably broken, because we don't reply to the packet but instead silently drop it. -- Alex Gartrell http://vger.kernel.org/majordomo

Re: [PATCH net-next] net: bail on sock_wfree, sock_rfree when we have a TCP_TIMEWAIT sk

2015-07-02 Thread Alex Gartrell
On Thu, Jul 2, 2015 at 1:44 AM, Julian Anastasov wrote: > I think, your patch from January is almost > good: I'll rebase it, add your other suggestions, test it, and send it in. > And the patch from Eric for IPVS looks good too. Are we sure that we want to change the semantics of set_ow

Re: Bpqether broken in 4.1

2015-07-02 Thread Eric W. Biederman
Ralf Baechle writes: > Eric's Commit 1d5da757da860a6916adbf68b09e868062b4b3b8 (ax25: Stop using > magic neighbour cache operations.) breaks IP traffic over the AX.25 bpqether > driver. Sigh. NETIF_F_LLTX is not set so recursion does not work :( So we can either set NETIF_F_LLTX or just rever t

[PATCH net-next 3/3] vxlan: GRO support at tunnel layer

2015-07-02 Thread Tom Herbert
Add calls to gro_cells infrastructure to do GRO when receiving on a tunnel. Testing: Ran 200 netperf TCP_STREAM instance - With fix (GRO enabled on VXLAN interface) Verify GRO is happening. 9084 MBps tput 3.44% CPU utilization - Without fix (GRO disabled on VXLAN interface) Verified

[PATCH net-next 0/3] gro: Fixes for tunnels and GRO

2015-07-02 Thread Tom Herbert
This patch set addresses some issue related to tunneling and GRO: - Ensure headers are pull into skb->head when putting 1st packet onto GRO list - Fix remote checksum offload to properly deal with frag0 in GRO. - Add support for GRO at VXLAN tunnel (call gro_cells) Testing: Ran one netperf TCP_

[PATCH net-next 1/3] gro: Pull headers into skb head for 1st skb in gro list

2015-07-02 Thread Tom Herbert
When setting up the first skb in a gro list we ensure that all the headers up to skb_gro_offset have been pulled into head. In subsequent uses of this skb (e.g. determining same_flow) it is assumed that the headers can be accessed in the skb head. Signed-off-by: Tom Herbert --- net/core/dev.c |

[PATCH net-next 2/3] gro: Fix remcsum offload to deal with frags in GRO

2015-07-02 Thread Tom Herbert
The remote checksum offload GRO did not consider the case that frag0 might be in use. This patch fixes that by accessing headers using the skb_gro functions and not saving offsets relative to skb->head. Signed-off-by: Tom Herbert --- drivers/net/vxlan.c | 20 ++-- include/l

Re: [PATCH net-next 6/6] net_sched: act: remove spinlock in fast path

2015-07-02 Thread Eric Dumazet
On Thu, 2015-07-02 at 09:35 -0700, John Fastabend wrote: > > + if (gact->tcf_tm.lastuse != jiffies) > > + gact->tcf_tm.lastuse = jiffies; > > I'm missing the point of the if block. Is that really good enough > for the 32bit system case? I would have expected some wrapper to > handle it

Re: [PATCH v2] bonding: "primary_reselect" with "failure" is not working properly

2015-07-02 Thread Jay Vosburgh
[ added netdev to cc ] Mazhar Rana wrote: >When "primary_reselect" is set to "failure", primary interface should >not become active until current active slave is up. But if we set first I think you mean "until current active slave is down" here, not "up." >member of bond devic

RE: amd-xgbe e0700000.xgmac: DMA-API: device driver tries to sync DMA memory it has not allocated

2015-07-02 Thread Lendacky, Thomas
Hi Kim, Yup, no problem. I think I know what the issue is. I should be using dma_sync_single_range_for_cpu instead of dma_sync_single_for_cpu. The page allocations that the driver is doing have crossed a 1MB boundary causing the warning because I'm using a calculated DMA address rather than

Re: [v2,5/9] fsl/fman: Add Frame Manager support

2015-07-02 Thread Scott Wood
On Thu, 2015-07-02 at 10:32 -0500, Liberman Igal-B31950 wrote: > Hi Scott, > Thank you for your feedback, please take a look at my comments/questions. > > Regards, > Igal Liberman. > > > -Original Message- > > From: Wood Scott-B07421 > > Sent: Friday, June 26, 2015 6:55 AM > > To: Liberma

Re: [PATCH net] bridge: vlan: fix usage of vlan 0 and 4095 again

2015-07-02 Thread David Miller
From: Nikolay Aleksandrov Date: Thu, 2 Jul 2015 05:48:17 -0700 > Vlan ids 0 and 4095 were disallowed by commit: > 8adff41c3d25 ("bridge: Don't use VID 0 and 4095 in vlan filtering") > but then the check was removed when vlan ranges were introduced by: > bdced7ef7838 ("bridge: support for multipl

Re: pull request: bluetooth 2015-07-02

2015-07-02 Thread David Miller
From: Johan Hedberg Date: Thu, 2 Jul 2015 10:30:38 +0300 > A couple of regressions crept in because of a patch to use proper list > APIs rather than manually reading & writing the next/prev pointers > (commit 835a6a2f8603237a3e6cded5a6765090ecb06ea5). Turns out this was > masking a few bugs: a mi

Re: [PATCH] rionet: Don't try to corrupt skbuff assigning data pointer directly

2015-07-02 Thread David Miller
From: Alexander Sverdlin Date: Wed, 1 Jul 2015 15:01:11 +0200 > It's not allowed to assign data pointer of skbuff directly, this makes no > sense > if the assigned pointer is the very same as already existing one, or it brakes > all the pointer arithmetics in all other cases. We cannot do better

Re: [PATCH net v2] enic: fix issues in enic_poll

2015-07-02 Thread David Miller
From: Govindarajulu Varadarajan <_gov...@gmx.com> Date: Wed, 1 Jul 2015 14:21:57 +0530 > In enic_poll, we clean tx and rx queues, when low latency busy socket polling > is happening, enic_poll will only clean tx queue. After cleaning tx, it should > return total budget for re-poll. > > There is

Re: 4.1 regression in resizable hashtable tests

2015-07-02 Thread Meelis Roos
> > [ 31.898697] Running resizable hashtable tests... > > [ 31.898915] Adding 2048 keys > > [ 31.952911] Traversal complete: counted=17, nelems=2048, entries=2048 > > [ 31.953004] Test failed: Total count mismatch ^^^ > > [ 32.022676] Traversal complete: counted=17, nelems=2048, ent

amd-xgbe e0700000.xgmac: DMA-API: device driver tries to sync DMA memory it has not allocated

2015-07-02 Thread Kim Phillips
Hi Tom, A pristine 4.1 kernel with CONFIG_DMA_API_DEBUG=y produces this call trace on an AMD Seattle: [ 112.896576] [ cut here ] [ 112.896591] WARNING: CPU: 2 PID: 1059 at lib/dma-debug.c:1202 check_sync+0x138/0x56c() [ 112.896597] amd-xgbe e070.xgmac: DMA-API: dev

[PATCH net-next] hv_netvsc: Add support to set MTU reservation from guest side

2015-07-02 Thread Haiyang Zhang
When packet encapsulation is in use, the MTU needs to be reduced for headroom reservation. The existing code takes the updated MTU value only from the host side. But vSwitch extensions, such as Open vSwitch, require the flexibility to change the MTU to different values from within a guest during th

Re: [PATCH net-next] net: bail on sock_wfree, sock_rfree when we have a TCP_TIMEWAIT sk

2015-07-02 Thread Julian Anastasov
Hello, On Thu, 2 Jul 2015, Julian Anastasov wrote: > Alex, in our discussion on January I thought > we can skip calling skb_orphan for some cases but as > input and output path use different skb->destructor > we should call skb_orphan for every method, in every > case when skb->dev

Bpqether broken in 4.1

2015-07-02 Thread Ralf Baechle
Eric's Commit 1d5da757da860a6916adbf68b09e868062b4b3b8 (ax25: Stop using magic neighbour cache operations.) breaks IP traffic over the AX.25 bpqether driver. Here's how to reproduce the issue if you don't have an AX.25 setup. The arp command is there to fudge things if you don't have a peer that

Re: [PATCH] bonding: "primary_reselect" with "failure" is not working properly

2015-07-02 Thread David Miller
Emails encoded in HTML will not reach the mailing list, only plain ASCII text is accepted. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net] net_sched: gen_estimator: extend pps limit

2015-07-02 Thread Alexei Starovoitov
On 7/2/15 6:57 AM, Eric Dumazet wrote: From: Eric Dumazet rate estimators are limited to 4 Mpps, which was fine years ago, but too small with current hardware generation. Lets use 2^5 scaling instead of 2^10 to get 128 Mpps new limit. On 64bit arch, use an "unsigned long" for temp storage and

Re: [PATCH net-next 6/6] net_sched: act: remove spinlock in fast path

2015-07-02 Thread Alexei Starovoitov
On 7/2/15 6:07 AM, Eric Dumazet wrote: Final step for gact RCU operation : 1) Use percpu stats 2) update lastuse only every clock tick 3) Remove spinlock acquisition, as it is no longer needed. Since this is the last contended lock in packet RX when tc gact is used, this gives impressive gain.

Re: [PATCH net-next 3/6] net_sched: act: make tcfg_pval non zero

2015-07-02 Thread Alexei Starovoitov
On 7/2/15 6:07 AM, Eric Dumazet wrote: First step for gact RCU operation : Instead of testing if tcfg_pval is zero or not, just make it 1. No change in behavior, but slightly faster code. Signed-off-by: Eric Dumazet Nice trick! Acked-by: Alexei Starovoitov -- To unsubscribe from this list:

[PATCH] netlink: Delete an unnecessary check before the function call "module_put"

2015-07-02 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 2 Jul 2015 18:38:12 +0200 The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/net

Re: [PATCH net-next 6/6] net_sched: act: remove spinlock in fast path

2015-07-02 Thread John Fastabend
On 15-07-02 06:07 AM, Eric Dumazet wrote: > Final step for gact RCU operation : > > 1) Use percpu stats > 2) update lastuse only every clock tick > 3) Remove spinlock acquisition, as it is no longer needed. > > Since this is the last contended lock in packet RX when tc gact is used, > this gives

Re: [PATCH] rtnetlink: Actually use the policy for the IFLA_VF_INFO

2015-07-02 Thread Jason Gunthorpe
On Wed, Jul 01, 2015 at 11:36:15AM +0200, Daniel Borkmann wrote: > Hi Jason, > > On 07/01/2015 12:52 AM, Jason Gunthorpe wrote: > >It turns out the policy was defined but never actually checked, > >so lets check it. > > > >Fixes: ebc08a6f47ee ("rtnetlink: Add VF config code to rtnetlink") > > I w

[PATCH v2 v4.2-rc1] printk: make extended printk support conditional on netconsole

2015-07-02 Thread Tejun Heo
6fe29354befe ("printk: implement support for extended console drivers") implemented extended printk support for extended netconsole. The code added was miniscule but it added static 8k buffer unconditionally unnecessarily bloating the kernel for cases where extended netconsole is not used. This pa

[PATCH] net-RDS: Delete an unnecessary check before the function call "module_put"

2015-07-02 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 2 Jul 2015 17:58:21 +0200 The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/rds

Re: [PATCH net-next 5/6] net_sched: act: read tcfg_ptype once

2015-07-02 Thread John Fastabend
On 15-07-02 06:07 AM, Eric Dumazet wrote: > Third step for gact RCU operation : > > Following patch will get rid of spinlock protection, > so we need to read tcfg_ptype once. > > Signed-off-by: Eric Dumazet > Cc: Alexei Starovoitov > Cc: Jamal Hadi Salim > Cc: John Fastabend > --- > net/sche

Re: [PATCH net] bridge: vlan: fix usage of vlan 0 and 4095 again

2015-07-02 Thread Toshiaki Makita
On 15/07/02 (木) 21:48, Nikolay Aleksandrov wrote: > Vlan ids 0 and 4095 were disallowed by commit: > 8adff41c3d25 ("bridge: Don't use VID 0 and 4095 in vlan filtering") > but then the check was removed when vlan ranges were introduced by: > bdced7ef7838 ("bridge: support for multiple vlans and vlan

Re: [PATCH net-next 4/6] net_sched: act: use a separate packet counters for gact_determ()

2015-07-02 Thread John Fastabend
On 15-07-02 06:07 AM, Eric Dumazet wrote: > Second step for gact RCU operation : > > We want to get rid of the spinlock protecting gact operations. > Stats (packets/bytes) will soon be per cpu. > > gact_determ() would not work without a central packet counter, > so lets add it for this mode. > >

Re: [PATCH net-next 3/6] net_sched: act: make tcfg_pval non zero

2015-07-02 Thread John Fastabend
On 15-07-02 06:07 AM, Eric Dumazet wrote: > First step for gact RCU operation : > > Instead of testing if tcfg_pval is zero or not, just make it 1. > > No change in behavior, but slightly faster code. > > Signed-off-by: Eric Dumazet > Cc: Alexei Starovoitov > Cc: Jamal Hadi Salim > Cc: John F

RE: [v2,5/9] fsl/fman: Add Frame Manager support

2015-07-02 Thread Liberman Igal
Hi Scott, Thank you for your feedback, please take a look at my comments/questions. Regards, Igal Liberman. > -Original Message- > From: Wood Scott-B07421 > Sent: Friday, June 26, 2015 6:55 AM > To: Liberman Igal-B31950 > Cc: netdev@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Bucur Ma

Re: [PATCH net-next 2/6] net: sched: add percpu stats to actions

2015-07-02 Thread John Fastabend
On 15-07-02 06:07 AM, Eric Dumazet wrote: > Reuse existing percpu infrastructure Jonh added for qdisc. > > This patch adds a new cpustats parameter to tcf_hash_create() and all > actions pass false, meaning this patch should have no effect yet. > > Signed-off-by: Eric Dumazet > Cc: Alexei Starov

Re: [PATCH net-next 1/6] net: sched: extend percpu stats helpers

2015-07-02 Thread John Fastabend
On 15-07-02 06:07 AM, Eric Dumazet wrote: > qdisc_bstats_update_cpu() and other helpers were added to support > percpu stats for qdisc. > > We want to add percpu stats for tc action, so this patch add common > helpers. > > qdisc_bstats_update_cpu() is renamed to qdisc_bstats_cpu_update() > qdisc_

[PATCH] net-ipvs: Delete an unnecessary check before the function call "module_put"

2015-07-02 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 2 Jul 2015 17:00:14 +0200 The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/net

[PATCH] net-ipv6: Delete an unnecessary check before the function call "free_percpu"

2015-07-02 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 2 Jul 2015 16:30:24 +0200 The free_percpu() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/ip

[PATCH net] net_sched: gen_estimator: extend pps limit

2015-07-02 Thread Eric Dumazet
From: Eric Dumazet rate estimators are limited to 4 Mpps, which was fine years ago, but too small with current hardware generation. Lets use 2^5 scaling instead of 2^10 to get 128 Mpps new limit. On 64bit arch, use an "unsigned long" for temp storage and remove limit. (We do not expect 32bit ar

[PATCH net-next 6/6] net_sched: act: remove spinlock in fast path

2015-07-02 Thread Eric Dumazet
Final step for gact RCU operation : 1) Use percpu stats 2) update lastuse only every clock tick 3) Remove spinlock acquisition, as it is no longer needed. Since this is the last contended lock in packet RX when tc gact is used, this gives impressive gain. My host with 8 RX queues was handling 5

[PATCH net-next 3/6] net_sched: act: make tcfg_pval non zero

2015-07-02 Thread Eric Dumazet
First step for gact RCU operation : Instead of testing if tcfg_pval is zero or not, just make it 1. No change in behavior, but slightly faster code. Signed-off-by: Eric Dumazet Cc: Alexei Starovoitov Cc: Jamal Hadi Salim Cc: John Fastabend --- net/sched/act_gact.c | 6 +++--- 1 file changed

[PATCH net-next 4/6] net_sched: act: use a separate packet counters for gact_determ()

2015-07-02 Thread Eric Dumazet
Second step for gact RCU operation : We want to get rid of the spinlock protecting gact operations. Stats (packets/bytes) will soon be per cpu. gact_determ() would not work without a central packet counter, so lets add it for this mode. Signed-off-by: Eric Dumazet Cc: Alexei Starovoitov Cc: Ja

[PATCH net-next 5/6] net_sched: act: read tcfg_ptype once

2015-07-02 Thread Eric Dumazet
Third step for gact RCU operation : Following patch will get rid of spinlock protection, so we need to read tcfg_ptype once. Signed-off-by: Eric Dumazet Cc: Alexei Starovoitov Cc: Jamal Hadi Salim Cc: John Fastabend --- net/sched/act_gact.c | 14 +++--- 1 file changed, 7 insertions(+

[PATCH net-next 2/6] net: sched: add percpu stats to actions

2015-07-02 Thread Eric Dumazet
Reuse existing percpu infrastructure Jonh added for qdisc. This patch adds a new cpustats parameter to tcf_hash_create() and all actions pass false, meaning this patch should have no effect yet. Signed-off-by: Eric Dumazet Cc: Alexei Starovoitov Cc: Jamal Hadi Salim Cc: John Fastabend --- in

[PATCH net-next 1/6] net: sched: extend percpu stats helpers

2015-07-02 Thread Eric Dumazet
qdisc_bstats_update_cpu() and other helpers were added to support percpu stats for qdisc. We want to add percpu stats for tc action, so this patch add common helpers. qdisc_bstats_update_cpu() is renamed to qdisc_bstats_cpu_update() qdisc_qstats_drop_cpu() is renamed to qdisc_qstats_cpu_drop() S

[PATCH net-next 0/6] net_sched: act: lockless operation

2015-07-02 Thread Eric Dumazet
As mentioned by Alexei last week in Budapest, it is a bit weird to take a spinlock in order to drop a packet in a tc filter... Lets add percpu infra for tc actions and use it for gact. Before changes, my host with 8 RX queues was handling 5 Mpps, and more than 10 Mpps after. Signed-off-by: Eric

[PATCH net] bridge: vlan: fix usage of vlan 0 and 4095 again

2015-07-02 Thread Nikolay Aleksandrov
Vlan ids 0 and 4095 were disallowed by commit: 8adff41c3d25 ("bridge: Don't use VID 0 and 4095 in vlan filtering") but then the check was removed when vlan ranges were introduced by: bdced7ef7838 ("bridge: support for multiple vlans and vlan ranges in setlink and dellink requests") So reintroduce

Re: 4.1 regression in resizable hashtable tests

2015-07-02 Thread Thomas Graf
On 07/01/15 at 01:21pm, Meelis Roos wrote: > This is 4.1 on sparc64 - one of my boxes that happens to have most > runtime test left on from some debugging effort. In 4.0 it was fine, 4.1 > gives this in dmesg: > > [ 31.898697] Running resizable hashtable tests... > [ 31.898915] Adding 2048

[PATCH v2] bonding: "primary_reselect" with "failure" is not working properly

2015-07-02 Thread Mazhar Rana
When "primary_reselect" is set to "failure", primary interface should not become active until current active slave is up. But if we set first member of bond device as a "primary" interface and "primary_reselect" is set to "failure" then whenever primary interface's link get back(up) it become activ

Re: [PATCH] bonding: "primary_reselect" with "failure" is not working properly

2015-07-02 Thread Eric Dumazet
On Thu, 2015-07-02 at 15:43 +0530, Mazhar Rana wrote: > When "primary_reselect" is set to "failure", primary interface should > not become active until current active slave is up. But if we set first > member of bond device as a "primary" interface and "primary_reselect" > is set to "failure" then

[PATCH net] mlx4: TCP/UDP packets have L4 hash

2015-07-02 Thread Eric Dumazet
From: Eric Dumazet Mellanox driver has the knowledge if rxhash is a L4 hash, if it receives a non fragmented TCP or UDP frame and NETIF_F_RXCSUM is enabled on netdev. ip_summed value is CHECKSUM_UNNECESSARY in this case. Signed-off-by: Eric Dumazet Cc: Amir Vadai Cc: Ido Shamay --- drivers/

[PATCH] bonding: "primary_reselect" with "failure" is not working properly

2015-07-02 Thread Mazhar Rana
When "primary_reselect" is set to "failure", primary interface should not become active until current active slave is up. But if we set first member of bond device as a "primary" interface and "primary_reselect" is set to "failure" then whenever primary interface's link get back(up) it become activ

Re: [RFC] virtio_net: Adding tx_timeout function.

2015-07-02 Thread Michael S. Tsirkin
On Thu, Jul 02, 2015 at 03:23:56AM -0400, Pankaj Gupta wrote: > > > On Wed, Jun 24, 2015 at 10:31:09PM -0300, Julio Faracco wrote: > > > 2015-06-24 3:10 GMT-03:00 Michael S. Tsirkin : > > > > > > > > On Tue, Jun 23, 2015 at 10:44:29PM -0300, Julio Faracco wrote: > > > > > virtio_net paravirtualize

Re: [PULL] virtio/vhost: cross endian support

2015-07-02 Thread Michael S. Tsirkin
On Thu, Jul 02, 2015 at 11:12:56AM +0200, Greg Kurz wrote: > On Thu, 2 Jul 2015 08:01:28 +0200 > "Michael S. Tsirkin" wrote: > > > On Wed, Jul 01, 2015 at 12:02:50PM -0700, Linus Torvalds wrote: > > > On Wed, Jul 1, 2015 at 2:31 AM, Michael S. Tsirkin > > > wrote: > > > > virtio/vhost: cross en

Re: mlx4: "failed to allocate default counter port 1"

2015-07-02 Thread Sebastian Ott
On Wed, 1 Jul 2015, Or Gerlitz wrote: > On Wed, Jul 1, 2015 at 5:18 PM, Sebastian Ott > wrote: > > OK, using this patch it worked: > > yep, I forgot to recap err to zero. > > By "it worked" you mean the VF is live and kicking, all functionality > you had before the 4.2 merge window is back agai

Re: [PULL] virtio/vhost: cross endian support

2015-07-02 Thread Greg Kurz
On Thu, 2 Jul 2015 08:01:28 +0200 "Michael S. Tsirkin" wrote: > On Wed, Jul 01, 2015 at 12:02:50PM -0700, Linus Torvalds wrote: > > On Wed, Jul 1, 2015 at 2:31 AM, Michael S. Tsirkin wrote: > > > virtio/vhost: cross endian support > > > > Ugh. Does this really have to be dynamic? > > > > Can't

Re: [PATCH v2] add stealth mode

2015-07-02 Thread Matteo Croce
Add option to disable any reply not related to a listening socket, like RST/ACK for TCP and ICMP Port-Unreachable for UDP. Also disables ICMP replies to echo request and timestamp. The stealth mode can be enabled selectively for a single interface. Signed-off-by: Matteo Croce --- check the patch

Re: [PATCH] add stealth mode

2015-07-02 Thread Nicolas Dichtel
Le 02/07/2015 10:38, Matteo Croce a écrit : Add option to disable any reply not related to a listening socket, like RST/ACK for TCP and ICMP Port-Unreachable for UDP. Also disables ICMP replies to echo request and timestamp. The stealth mode can be enabled selectively for a single interface. Sig

Re: [PATCH net-next] net: bail on sock_wfree, sock_rfree when we have a TCP_TIMEWAIT sk

2015-07-02 Thread Julian Anastasov
Hello, On Wed, 1 Jul 2015, Alex Gartrell wrote: > On Wed, Jul 1, 2015 at 4:26 PM, Eric Dumazet wrote: > > I think you are mistaken Alex. > > Indeed, I was! Should be unsurpising. > > > > > socket early demux cannot possibly set skb->destructor to sock_rfree() > > Yeah I will admit a

Re: [PATCH] add stealth mode

2015-07-02 Thread Matteo Croce
Add option to disable any reply not related to a listening socket, like RST/ACK for TCP and ICMP Port-Unreachable for UDP. Also disables ICMP replies to echo request and timestamp. The stealth mode can be enabled selectively for a single interface. Signed-off-by: Matteo Croce --- Documentation/n

Re: [PATCH] rtnetlink: Actually use the policy for the IFLA_VF_INFO

2015-07-02 Thread Daniel Borkmann
On 07/01/2015 11:36 AM, Daniel Borkmann wrote: Hi Jason, On 07/01/2015 12:52 AM, Jason Gunthorpe wrote: It turns out the policy was defined but never actually checked, so lets check it. Fixes: ebc08a6f47ee ("rtnetlink: Add VF config code to rtnetlink") I would argue that the actual commit wo

Re: [PATCH] add stealth mode

2015-07-02 Thread Nicolas Dichtel
Le 02/07/2015 00:53, Matteo Croce a écrit : Add option to disable any reply not related to a listening socket, like RST/ACK for TCP and ICMP Dest-Unreach for UDP. Also disables ICMP replies to echo request and timestamp. The stealth mode can be enabled selectively for a single interface. --- in

Re: macb: zynq: why is SG disabled?

2015-07-02 Thread Nicolas Ferre
Le 02/07/2015 04:33, Punnaiah Choudary Kalluri a écrit : > Hi Nicolae and Cyrille, > >SG feature was not tested for Zynq using macb driver but tested it using > the > emacps Driver in Xilinx tree (this driver is deprecated recently) > > We will test and enable this feature in driver for Zyn

pull request: bluetooth 2015-07-02

2015-07-02 Thread Johan Hedberg
Hi Dave, A couple of regressions crept in because of a patch to use proper list APIs rather than manually reading & writing the next/prev pointers (commit 835a6a2f8603237a3e6cded5a6765090ecb06ea5). Turns out this was masking a few bugs: a missing INIT_LIST_HEAD() call and incorrectly using list_de

Re: [RFC] virtio_net: Adding tx_timeout function.

2015-07-02 Thread Pankaj Gupta
> On Wed, Jun 24, 2015 at 10:31:09PM -0300, Julio Faracco wrote: > > 2015-06-24 3:10 GMT-03:00 Michael S. Tsirkin : > > > > > > On Tue, Jun 23, 2015 at 10:44:29PM -0300, Julio Faracco wrote: > > > > virtio_net paravirtualized driver does not have a tx_timeout() function > > > > to > > > > guarante

Re: [PATCH] ipv6: Make MLD packets to only be processed locally.

2015-07-02 Thread David Miller
Your patch is severely corrupted by your email client, for example TAB characters have been transformed into sequences of SPACE characters. Please read Documentation/email-clients.txt, fix your setup, and then send a test patch to yourself and only when you can successfully apply that patch you r