Re: [PATCH v2 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver

2015-06-23 Thread Joe Perches
On Wed, 2015-06-24 at 11:55 +0900, Taku Izumi wrote: > This patch adds the basic code of FUJITSU Extended Socket > Network Device driver. trivial notes: > diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c [] > +static int fjes_acpi_add(struct acpi_device *device) > +{ [] >

Re: [RFC] virtio_net: Adding tx_timeout function.

2015-06-23 Thread Michael S. Tsirkin
On Tue, Jun 23, 2015 at 10:44:29PM -0300, Julio Faracco wrote: > virtio_net paravirtualized driver does not have a tx_timeout() function to > guarantee that the driver will recover properly after receiving a timeout > during a transmission of a packet. This patch add this feature and throw a > time

Re: [PATCH v7] NET: Add ezchip ethernet driver

2015-06-23 Thread Paul Gortmaker
On Tue, Jun 23, 2015 at 4:43 AM, Noam Camus wrote: > From: Noam Camus > > Simple LAN device for debug or management purposes. > Device supports interrupts for RX and TX(completion). > Device does not have DMA ability. > > Signed-off-by: Noam Camus > Signed-off-by: Tal Zilcer > Acked-by: Alexey

[PATCH v2 18/22] fjes: unshare_watch_task

2015-06-23 Thread Taku Izumi
This patch adds unshare_watch_task. Shared buffer's status can be changed into unshared. This task is used to monitor shared buffer's status. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes.h | 3 + drivers/net/fjes/fjes_main.c | 130 +++ 2 file

[PATCH v2 12/22] fjes: net_device_ops.ndo_get_stats64

2015-06-23 Thread Taku Izumi
This patch adds net_device_ops.ndo_get_stats64 callback. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes_main.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index 2e7b382..0aa289d 100644 --- a/drivers/net/fjes/

[PATCH v2 11/22] fjes: NAPI polling function

2015-06-23 Thread Taku Izumi
This patch adds NAPI polling function and receive related work. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes_hw.c | 41 +++ drivers/net/fjes/fjes_hw.h | 5 ++ drivers/net/fjes/fjes_main.c | 172 ++- 3 files changed, 216 insertions(+),

[PATCH v2 21/22] fjes: handle receive cancellation request interrupt

2015-06-23 Thread Taku Izumi
This patch adds implementation of handling IRQ of other receiver's receive cancellation request. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes_main.c | 79 1 file changed, 79 insertions(+) diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net

[PATCH v2 17/22] fjes: force_close_task

2015-06-23 Thread Taku Izumi
This patch adds force_close_task. This task is used to close network device forcibly. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes.h | 1 + drivers/net/fjes/fjes_main.c | 13 + 2 files changed, 14 insertions(+) diff --git a/drivers/net/fjes/fjes.h b/drivers/net/fjes/fje

[PATCH v2 16/22] fjes: interrupt_watch_task

2015-06-23 Thread Taku Izumi
This patch adds interrupt_watch_task. This task is used to prevent delay of interrupts. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes.h | 5 + drivers/net/fjes/fjes_main.c | 40 +++- 2 files changed, 44 insertions(+), 1 deletion(-) diff --git

[PATCH v2 22/22] fjes: ethtool support

2015-06-23 Thread Taku Izumi
This patch adds implementation for ethtool support. Signed-off-by: Taku Izumi --- drivers/net/fjes/Makefile | 2 +- drivers/net/fjes/fjes.h | 2 + drivers/net/fjes/fjes_ethtool.c | 135 drivers/net/fjes/fjes_main.c| 1 + 4 files ch

[PATCH v2 19/22] fjes: update_zone_task

2015-06-23 Thread Taku Izumi
This patch adds update_zone_task. Zoning information can be changed by user. This task is used to monitor if zoning information is changed or not. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes_hw.c | 171 +++ drivers/net/fjes/fjes_hw.h | 1 + d

[PATCH v2 15/22] fjes: net_device_ops.ndo_vlan_rx_add/kill_vid

2015-06-23 Thread Taku Izumi
This patch adds net_device_ops.ndo_vlan_rx_add_vid and net_device_ops.ndo_vlan_rx_kill_vid callback. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes_hw.c | 27 +++ drivers/net/fjes/fjes_hw.h | 2 ++ drivers/net/fjes/fjes_main.c | 40 ++

[PATCH v2 14/22] fjes: net_device_ops.ndo_tx_timeout

2015-06-23 Thread Taku Izumi
This patch adds net_device_ops.ndo_tx_timeout callback. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes_main.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index 47e5b2f..e2e69e0 100644 --- a/drivers/net/fjes/fjes_ma

[PATCH v2 13/22] fjes: net_device_ops.ndo_change_mtu

2015-06-23 Thread Taku Izumi
This patch adds net_device_ops.ndo_change_mtu. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes_main.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c index 0aa289d..47e5b2f 100644 --- a/drivers/net

[PATCH v2 20/22] fjes: epstop_task

2015-06-23 Thread Taku Izumi
This patch adds epstop_task. This task is used to process other receiver's cancellation request. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes_hw.c | 30 ++ drivers/net/fjes/fjes_hw.h | 1 + drivers/net/fjes/fjes_main.c | 1 + 3 files changed, 32 insertion

[PATCH v2 06/22] fjes: buffer address regist/unregistration routine

2015-06-23 Thread Taku Izumi
This patch adds buffer address regist/unregistration routine. This function is mainly invoked when network device's activation (open) and deactivation (close) in order to retist/unregist shared buffer address. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes_hw.c | 187 ++

[PATCH v2 04/22] fjes: platform_driver's .probe and .remove routine

2015-06-23 Thread Taku Izumi
This patch implements platform_driver's .probe and .remove routine, and also adds board specific private data structure. This driver registers net_device at platform_driver's .probe routine and unregisters net_device at its .remove routine. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes.h

[PATCH v2 07/22] fjes: net_device_ops.ndo_open and .ndo_stop

2015-06-23 Thread Taku Izumi
This patch adds net_device_ops.ndo_open and .ndo_stop callback. These function is called when network device activation and deactivation. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes.h | 1 + drivers/net/fjes/fjes_hw.c | 144 + drivers/net/fjes/fjes_hw.h

[PATCH v2 05/22] fjes: ES information acquisition routine

2015-06-23 Thread Taku Izumi
This patch adds ES information acquisition routine. ES information can be retrieved issuing information request command. ES information includes which receiver is same zone. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes_hw.c | 101 +++ drivers/net/

[PATCH v2 08/22] fjes: net_device_ops.ndo_start_xmit

2015-06-23 Thread Taku Izumi
This patch adds net_device_ops.ndo_start_xmit callback, which is called when sending packets. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes.h | 1 + drivers/net/fjes/fjes_hw.c | 58 ++ drivers/net/fjes/fjes_hw.h | 12 +++ drivers/net/fjes/fjes_main.c | 177

[PATCH v2 03/22] fjes: Hardware cleanup routine

2015-06-23 Thread Taku Izumi
This patch adds hardware cleanup routine to be invoked at driver's .remove routine. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes_hw.c | 66 ++ drivers/net/fjes/fjes_hw.h | 1 + 2 files changed, 67 insertions(+) diff --git a/drivers/net/fjes/fj

[PATCH v2 10/22] fjes: tx_stall_task

2015-06-23 Thread Taku Izumi
This patch adds tx_stall_task. When receiver's buffer is full, sender stops its tx queue. This task is used to monitor receiver's status and when receiver's buffer is avairable, it resumes tx queue. Signed-off-by: Taku Izumi --- drivers/net/fjes/fjes.h | 2 ++ drivers/net/fjes/fjes_main.c

[PATCH v2 09/22] fjes: raise_intr_rxdata_task

2015-06-23 Thread Taku Izumi
This patch add raise_intr_rxdata_task. Extended Socket Network Device is shared memory based, so someone's transmission denotes other's reception. In order to notify receivers, sender has to raise interruption of receivers. raise_intr_rxdata_task does this work. Signed-off-by: Taku Izumi --- dri

[PATCH v2 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver

2015-06-23 Thread Taku Izumi
This patch adds the basic code of FUJITSU Extended Socket Network Device driver. When "PNP0C02" is found in ACPI DSDT, it evaluates "_STR" to check if "PNP0C02" is for Extended Socket device driver and retrieves ACPI resource information. Then creates platform_device. Signed-off-by: Taku Izumi -

[PATCH v2 02/22] fjes: Hardware initialization routine

2015-06-23 Thread Taku Izumi
This patch adds hardware initialization routine to be invoked at driver's .probe routine. Signed-off-by: Taku Izumi --- drivers/net/fjes/Makefile| 2 +- drivers/net/fjes/fjes.h | 2 +- drivers/net/fjes/fjes_hw.c | 297 +++ drivers/net/fjes/f

[PATCH v2 00/22] FUJITSU Extended Socket network device driver

2015-06-23 Thread Taku Izumi
This patchsets adds FUJITSU Extended Socket network device driver. Extended Socket network device is a shared memory based high-speed network interface between Extended Partitions of PRIMEQUEST 2000 E2 series. You can get some information about Extended Partition and Extended Socket by referring t

[RFC] virtio_net: Adding tx_timeout function.

2015-06-23 Thread Julio Faracco
virtio_net paravirtualized driver does not have a tx_timeout() function to guarantee that the driver will recover properly after receiving a timeout during a transmission of a packet. This patch add this feature and throw a timeout exception after 5 HZ. Considering some tests, this is the best time

Re: [PATCH] net: dsa: add support for switchdev VLAN objects

2015-06-23 Thread Scott Feldman
On Tue, Jun 23, 2015 at 10:18 AM, Vivien Didelot wrote: > This patch adds the glue between DSA and switchdev operations to add, > delete and dump SWITCHDEV_OBJ_PORT_VLAN objects. > > This is a first step to link the "bridge vlan" command with hardware > entries for DSA compatible switch chips. > >

Re: [PATCH 2/2] sh_eth: Remove obsolete r8a779x-ether platform_device_id entries

2015-06-23 Thread Simon Horman
On Tue, Jun 23, 2015 at 03:01:02PM +0200, Geert Uytterhoeven wrote: > Since commit a483dcbfa21f919c ("ARM: shmobile: lager: Remove legacy > board support"), R-Car Gen2 SoCs are only supported in generic DT-only > ARM multi-platform builds. The driver doesn't need to match platform > devices by nam

Re: [PATCH 1/2] sh_eth: Remove obsolete r7s72100-ether platform_device_id entry

2015-06-23 Thread Simon Horman
On Tue, Jun 23, 2015 at 03:01:01PM +0200, Geert Uytterhoeven wrote: > Since commit 05104c266ae9a167 ("ARM: shmobile: r7s72100: genmai: Remove > legacy board file"), r7s72100 is only supported in generic DT-only ARM > multi-platform builds. The driver doesn't need to match platform > devices by nam

[PATCH 3/3] net: dsa: mv88e6352: add support for port_vlan_dump

2015-06-23 Thread Vivien Didelot
Add support for dumping the VLAN Table Unit entries by pointing to the port_vlan_dump function implemented for mv88e6xxx. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6352.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/mv88e6352.c b/drivers/net/dsa/mv88e6352.c in

[PATCH 2/3] net: dsa: mv88e6xxx: add support to dump VLANs

2015-06-23 Thread Vivien Didelot
This commit implements the port_vlan_dump function in the dsa_switch_driver structure for Marvell 88E6xxx compatible switches. This allows to access a switch VLAN Table Unit from standard userspace commands such as "bridge vlan show". A populated VTU can give the following output: # bridge v

[PATCH 1/3] net: dsa: mv88e6xxx: add debugfs interface for VTU

2015-06-23 Thread Vivien Didelot
Implement the Get Next operation for the VLAN Table Unit, and a "vtu" debugfs file to dump the hardware VLANs. A populated VTU can look like this: # cat /sys/kernel/debug/dsa0/vtu VID FID SID P0 P1 P2 P3 P4 P5 P6 550 562 0x x x u x t x 1000 1012 0x x t x x

[PATCH 0/3] net: dsa: mv88e6xxx: dump hardware VLANs

2015-06-23 Thread Vivien Didelot
This patchset requires "net: dsa: add support for switchdev VLAN objects" [1]. Thanks to the switchdev bindings for ports' bridge_getlink, this patchset adds support for dumping the hardware VLAN Table Unit of Marvell 88E6xxx compatible switch chips. It allows "bridge vlan" to query the hardware,

[PATCH] Add supporting Microchip's LAN78XX USB to Ethernet controller

2015-06-23 Thread Woojung.Huh
Hi, This is the first submission to kernel source tree. Welcome any advices and reviews. Thank you. - Woojung Huh Microchip's LAN78XX USB 2/3 to Ethernet 10/100/1000 controller driver. Signed-off-by: Woojung Huh --- drivers/net/usb/Kconfig | 10 + drivers/net/usb/Makefile |1 + drive

Re: [PATCH net] ip: report the original address of ICMP messages

2015-06-23 Thread Willem de Bruijn
On Tue, Jun 23, 2015 at 4:06 PM, Julian Anastasov wrote: > > Hello, > > On Tue, 23 Jun 2015, Willem de Bruijn wrote: > >> > It is using IP_RECVERR and may be relying only on >> > original address returned in msg_name from MSG_ERRQUEUE. >> >> It's not very important, in that even if

Re: [PATCH net] ip: report the original address of ICMP messages

2015-06-23 Thread Julian Anastasov
Hello, On Tue, 23 Jun 2015, Willem de Bruijn wrote: > > It is using IP_RECVERR and may be relying only on > > original address returned in msg_name from MSG_ERRQUEUE. > > It's not very important, in that even if ping does not use this > msg_name, another tool very well might. Bu

Re: [PATCH net] ip: report the original address of ICMP messages

2015-06-23 Thread Willem de Bruijn
On Tue, Jun 23, 2015 at 2:55 PM, Julian Anastasov wrote: > > Hello, > > On Tue, 23 Jun 2015, Willem de Bruijn wrote: > >> The ping utility from iputils relies on cmsg IP_RECVERR to get >> the source address on icmp errors, not on msg_name, so that >> worked for me both before and after app

Re: [PATCH net-next V11 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

2015-06-23 Thread Thomas F Herbert
On 6/23/15 2:43 PM, Sergei Shtylyov wrote: Hello. On 06/23/2015 09:26 PM, Thomas F Herbert wrote: Signed-off-by: Thomas F Herbert [...] diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 920e445..3713454 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @

Re: [PATCH net] ip: report the original address of ICMP messages

2015-06-23 Thread Julian Anastasov
Hello, On Tue, 23 Jun 2015, Willem de Bruijn wrote: > The ping utility from iputils relies on cmsg IP_RECVERR to get > the source address on icmp errors, not on msg_name, so that > worked for me both before and after applying the patch. I used > `ping -t 2 $hostname` to trigger a TTL exc

Re: [PATCH net-next V11 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

2015-06-23 Thread Sergei Shtylyov
Hello. On 06/23/2015 09:26 PM, Thomas F Herbert wrote: Signed-off-by: Thomas F Herbert [...] diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 920e445..3713454 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @@ -627,5 +627,14 @@ static inline netdev_fea

[PATCH net-next 3/3] openvswitch: 802.1AD: Flow handling, actions, and vlan parsing

2015-06-23 Thread Thomas F Herbert
Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netlink parsing and flow conversion. Uses double nested encap attributes to represent double tagged vlan. Inner TPID encoded along with ctci in nested attributes. Signed-off-by: Thomas F H

[PATCH net-next V11 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

2015-06-23 Thread Thomas F Herbert
Signed-off-by: Thomas F Herbert --- include/linux/if_vlan.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h index 920e445..3713454 100644 --- a/include/linux/if_vlan.h +++ b/include/linux/if_vlan.h @@ -627,5 +627,14 @@ static inline n

[PATCH net-next V11 1/3] openvswitch: 802.1ad uapi changes.

2015-06-23 Thread Thomas F Herbert
openvswitch: Add support for 8021.AD Change the description of the VLAN tpid field. Signed-off-by: Thomas F Herbert --- include/uapi/linux/openvswitch.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/op

[PATCH net-next V11 0/4] openvswitch: Add support for 802.1AD

2015-06-23 Thread Thomas F Herbert
V11: Add inner tpid to flow key. Fix separate inner encap attribute when parsing netlink attributes. Merge 2 patches to consolidate qinq changes. V10: Implement reviewer comments: Consolidate vlan parsing functions. Splits netlink parsing and flow conversion into a separate patch. Uses double enca

Re: [PATCH net] ip: report the original address of ICMP messages

2015-06-23 Thread Willem de Bruijn
> ICMP messages can trigger ICMP and local errors. In this case > serr->port is 0 and starting from Linux 4.0 we do not return > the original target address to the error queue readers. > Add function to define which errors provide addr_offset. > With this fix my ping command is not silent anymore.

[PATCH net-next 0/3 v7] changes to make ipv4 routing table aware of next-hop link status

2015-06-23 Thread Andy Gospodarek
This series adds the ability to have the Linux kernel track whether or not a particular route should be used based on the link-status of the interface associated with the next-hop. Before this patch any link-failure on an interface that was serving as a gateway for some systems could result in t

[PATCH net-next 1/3 v7] net: track link-status of ipv4 nexthops

2015-06-23 Thread Andy Gospodarek
Add a fib flag called RTNH_F_LINKDOWN to any ipv4 nexthops that are reachable via an interface where carrier is off. No action is taken, but additional flags are passed to userspace to indicate carrier status. This also includes a cleanup to fib_disable_ip to more clearly indicate what event made

[PATCH net-next 2/2 v7] net: ipv4 sysctl option to ignore routes when nexthop link is down

2015-06-23 Thread Andy Gospodarek
This feature is only enabled with the new per-interface or ipv4 global sysctls called 'ignore_routes_with_linkdown'. net.ipv4.conf.all.ignore_routes_with_linkdown = 0 net.ipv4.conf.default.ignore_routes_with_linkdown = 0 net.ipv4.conf.lo.ignore_routes_with_linkdown = 0 ... When the above sysctls

[PATCH net-next 3/3 v7] iproute2: add support to print 'linkdown' nexthop flag

2015-06-23 Thread Andy Gospodarek
Signed-off-by: Andy Gospodaerk Signed-off-by: Dinesh Dutt Acked-by: Scott Feldman --- ip/iproute.c | 4 1 file changed, 4 insertions(+) diff --git a/ip/iproute.c b/ip/iproute.c index 3795baf..3369c49 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -451,6 +451,8 @@ int print_route(const s

Re: displayed name changed in ip link show for bridge- and other interfaces

2015-06-23 Thread Oliver Hartkopp
On 23.06.2015 14:48, Nicolas Dichtel wrote: >> E.g. virtual CAN interfaces (vcan.c) now print this @NONE and they never have >> a (physical?) link. So you probably have to deal with different virtual >> interfaces anyway, right? > Yes, with the current code, all virtual interfaces (that define a >

Re: [PATCH net-next 2/2 v6] net: ipv4 sysctl option to ignore routes when nexthop link is down

2015-06-23 Thread Andy Gospodarek
On Tue, Jun 23, 2015 at 09:30:15AM -0700, Scott Feldman wrote: > On Tue, Jun 23, 2015 at 8:51 AM, Andy Gospodarek > wrote: > > This feature is only enabled with the new per-interface or ipv4 global > > sysctls called 'ignore_routes_with_linkdown'. > > [cut] > > checkpatch.pl says: > > WARNING:

[PATCH] net: dsa: add support for switchdev VLAN objects

2015-06-23 Thread Vivien Didelot
This patch adds the glue between DSA and switchdev operations to add, delete and dump SWITCHDEV_OBJ_PORT_VLAN objects. This is a first step to link the "bridge vlan" command with hardware entries for DSA compatible switch chips. Signed-off-by: Vivien Didelot --- include/net/dsa.h | 9 n

Re: [PATCH] net: switchdev: ignore unsupported bridge flags

2015-06-23 Thread Scott Feldman
On Tue, Jun 23, 2015 at 7:26 AM, Vivien Didelot wrote: > switchdev_port_bridge_getlink() queries SWITCHDEV_ATTR_PORT_BRIDGE_FLAGS > attributes, but a driver doesn't need to implement this in order to get > bridge link information. > > So error out only on errors different than -EOPNOTSUPP. > > (Th

Re: [PATCH net-next 2/2 v6] net: ipv4 sysctl option to ignore routes when nexthop link is down

2015-06-23 Thread Scott Feldman
On Tue, Jun 23, 2015 at 8:51 AM, Andy Gospodarek wrote: > This feature is only enabled with the new per-interface or ipv4 global > sysctls called 'ignore_routes_with_linkdown'. [cut] checkpatch.pl says: WARNING: suspect code indent for conditional statements (16, 20) #293: FILE: net/ipv4/fib_se

Re: [PATCH net] netfilter: nf_queue: Don't recompute the hook_list head

2015-06-23 Thread Eric W. Biederman
Pablo Neira Ayuso writes: > On Mon, Jun 22, 2015 at 09:56:37AM -0500, Eric W. Biederman wrote: >> Pablo Neira Ayuso writes: > [...] >> > There is no nfnetlink_queue support for the netdev family at this >> > moment, so this can't be triggered unless you use an out of tree >> > module. >> > >> >

Re: [PATCH] ethtool: changes of emac_regs structure accordingly within driver emac_regs structure.

2015-06-23 Thread Ivan Mikhaylov
On Wed, 3 Jun 2015 18:28:37 +0400 Ivan Mikhaylov wrote: > On Mon, 1 Jun 2015 22:11:00 +0400 > Ben Hutchings wrote: > > >On Mon, 2015-06-01 at 16:30 +0400, Ivan Mikhaylov wrote: > >> On Mon, 1 June 2015 12:57 +0400 > >> Ben Hutchings wrote: > >> > >> >On Thu, 2015-05-21 at 19:09 +0400, Ivan Mi

[PATCH net-next] enic: use atomic_t instead of spin_lock in busy poll

2015-06-23 Thread Govindarajulu Varadarajan
We use spinlock to access a single flag. We can achieve this by using atomic variable and atomic_cmpxchg to set the flag (idle to poll) and a simple atomic set to unlock (poll to idle). Also flush gro before unlocking napi poll, to prevent ooo packets when busy poll sockets are called. Signed-off

Re: [PATCH net] netfilter: nf_queue: Don't recompute the hook_list head

2015-06-23 Thread Pablo Neira Ayuso
On Mon, Jun 22, 2015 at 09:56:37AM -0500, Eric W. Biederman wrote: > Pablo Neira Ayuso writes: [...] > > There is no nfnetlink_queue support for the netdev family at this > > moment, so this can't be triggered unless you use an out of tree > > module. > > > > I have a patch here to add a static ke

[PATCH net-next 1/3 v6] net: track link-status of ipv4 nexthops

2015-06-23 Thread Andy Gospodarek
Add a fib flag called RTNH_F_LINKDOWN to any ipv4 nexthops that are reachable via an interface where carrier is off. No action is taken, but additional flags are passed to userspace to indicate carrier status. This also includes a cleanup to fib_disable_ip to more clearly indicate what event made

[PATCH net-next 3/3 v6] iproute2: add support to print 'linkdown' nexthop flag

2015-06-23 Thread Andy Gospodarek
Signed-off-by: Andy Gospodaerk Signed-off-by: Dinesh Dutt Acked-by: Scott Feldman --- ip/iproute.c | 4 1 file changed, 4 insertions(+) diff --git a/ip/iproute.c b/ip/iproute.c index 3795baf..3369c49 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -451,6 +451,8 @@ int print_route(const s

[PATCH net-next 2/2 v6] net: ipv4 sysctl option to ignore routes when nexthop link is down

2015-06-23 Thread Andy Gospodarek
This feature is only enabled with the new per-interface or ipv4 global sysctls called 'ignore_routes_with_linkdown'. net.ipv4.conf.all.ignore_routes_with_linkdown = 0 net.ipv4.conf.default.ignore_routes_with_linkdown = 0 net.ipv4.conf.lo.ignore_routes_with_linkdown = 0 ... When the above sysctls

[PATCH net-next 0/3 v6] changes to make ipv4 routing table aware of next-hop link status

2015-06-23 Thread Andy Gospodarek
This series adds the ability to have the Linux kernel track whether or not a particular route should be used based on the link-status of the interface associated with the next-hop. Before this patch any link-failure on an interface that was serving as a gateway for some systems could result in t

Re: [Bridge] [PATCH net-next] bridge: vlan: flush the dynamically learned entries on port vlan delete

2015-06-23 Thread Nikolay Aleksandrov
> On Jun 23, 2015, at 6:02 PM, Toshiaki Makita > wrote: > > On 15/06/23 (火) 21:28, Nikolay Aleksandrov wrote: >> Add a new argument to br_fdb_delete_by_port which allows to specify a >> vid to match when flushing entries and use it in nbp_vlan_delete() to >> flush the dynamically learned entrie

Re: [PATCH 4/6] net: ieee802154: Remove redundant spi driver bus initialization

2015-06-23 Thread Alan Ott
On 06/23/2015 10:52 AM, Antonio Borneo wrote: In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_register_driver(), so we can drop the manual assignment. Signed-off-by: Antonio Borneo To: Alan Ott To: Alexande

Re: [PATCH] net: switchdev: ignore unsupported bridge flags

2015-06-23 Thread Jiri Pirko
Tue, Jun 23, 2015 at 04:26:04PM CEST, vivien.dide...@savoirfairelinux.com wrote: >switchdev_port_bridge_getlink() queries SWITCHDEV_ATTR_PORT_BRIDGE_FLAGS >attributes, but a driver doesn't need to implement this in order to get >bridge link information. > >So error out only on errors different than

Re: [PATCH] stmmac: explicitly zero des0 & des1 on init

2015-06-23 Thread Alexey Brodkin
Hi David, On Mon, 2015-06-22 at 09:43 +0300, Alexey Brodkin wrote: > Hi David, > > On Sun, 2015-06-21 at 09:29 -0700, David Miller wrote: > > From: Alexey Brodkin > > Date: Tue, 16 Jun 2015 20:40:41 +0300 > > > > > Current implementtion of descriptor init procedure only takes > > > care > > >

Re: [PATCH 4/6] net: ieee802154: Remove redundant spi driver bus initialization

2015-06-23 Thread Varka Bhadram
Hi Antonio Borneo, On Tuesday 23 June 2015 08:22 PM, Antonio Borneo wrote: In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_register_driver(), so we can drop the manual assignment. Signed-off-by: Antonio Bor

Re: [Bridge] [PATCH net-next] bridge: vlan: flush the dynamically learned entries on port vlan delete

2015-06-23 Thread Toshiaki Makita
On 15/06/23 (火) 21:28, Nikolay Aleksandrov wrote: > Add a new argument to br_fdb_delete_by_port which allows to specify a > vid to match when flushing entries and use it in nbp_vlan_delete() to > flush the dynamically learned entries of the vlan/port pair when removing > a vlan from a port. Before

[PATCH 5/6] wireless: cw1200: Remove redundant spi driver bus initialization

2015-06-23 Thread Antonio Borneo
In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_register_driver(), so we can drop the manual assignment. Signed-off-by: Antonio Borneo To: Solomon Peachy To: Kalle Valo To: linux-wirel...@vger.kernel.org To:

[PATCH 4/6] net: ieee802154: Remove redundant spi driver bus initialization

2015-06-23 Thread Antonio Borneo
In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_register_driver(), so we can drop the manual assignment. Signed-off-by: Antonio Borneo To: Alan Ott To: Alexander Aring To: Varka Bhadram To: linux-w...@vger.

[PATCH v3] net: Cavium: Fix MAC address setting in shutdown state

2015-06-23 Thread Pavel Fedin
This bug pops up with NetworkManager on Fedora 21. NetworkManager tends to stop the interface (nicvf_stop() is called) before changing settings. In stopped state MAC cannot be sent to a PF. However, when the interface is restarted (nicvf_open() is called), we ping the PF using NIC_MBOX_MSG_READY me

[PATCH 0/6] Remove redundant spi driver bus initialization

2015-06-23 Thread Antonio Borneo
This cleanup was already completed between end 2011 and early 2012 with a patch series from Lars-Peter Clausen: https://lkml.org/lkml/2011/11/24/190 Later on new redundant initialization re-appeared here and there. Time to cleanup again. And, yes, I'm lazy! I copy-paste the exact same commit mess

[PATCH] net: switchdev: ignore unsupported bridge flags

2015-06-23 Thread Vivien Didelot
switchdev_port_bridge_getlink() queries SWITCHDEV_ATTR_PORT_BRIDGE_FLAGS attributes, but a driver doesn't need to implement this in order to get bridge link information. So error out only on errors different than -EOPNOTSUPP. (This is a follow-up patch for 7d4f8d8.) Signed-off-by: Vivien Didelot

[PATCH net-next V1 10/11] net/mlx5e: Pop cq outside mlx5e_get_cqe

2015-06-23 Thread Or Gerlitz
From: Achiad Shochat Separate between mlx5e_get_cqe() and mlx5_cqwq_pop(), this helps for better code readability and better CQ buffer management. Signed-off-by: Achiad Shochat Signed-off-by: Saeed Mahameed Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 2 +

[PATCH net-next V1 01/11] net/mlx4_en: Fix off-by-four in ethtool

2015-06-23 Thread Or Gerlitz
From: Eran Ben Elisha NUM_ALL_STATS was not updated with the new four entries, instead NUM_FLOW_STATS was updated, fix it. that caused off-by-four for all counters below pf_*_*. Fixes: b42de4d01264 ('net/mlx4_en: Show PF own statistics via ethtool') Signed-off-by: Eran Ben Elisha Signed-off-by:

[PATCH net-next V1 06/11] net/mlx5e: Avoid redundant dev_kfree_skb() upon NOP completion

2015-06-23 Thread Or Gerlitz
From: Achiad Shochat NOP completion SKBs are always NULL. Signed-off-by: Achiad Shochat Signed-off-by: Saeed Mahameed Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mell

[PATCH net-next V1 03/11] net/mlx5e: Static mapping of netdev priv resources to/from netdev TX queues

2015-06-23 Thread Or Gerlitz
From: Saeed Mahameed To save per-packet calculations, we use the following static mappings: 1) priv {channel, tc} to netdev txq (used @mlx5e_selec_queue()) 2) netdev txq to priv sq (used @mlx5e_xmit()) Thanks to these static mappings, no more need for a separate implementation of ndo_start_xmit

[PATCH net-next V1 04/11] net/mlx5e: Use skb_shinfo(skb)->gso_segs rather than counting them

2015-06-23 Thread Or Gerlitz
From: Saeed Mahameed Instead of counting number of gso fragments, we can use skb_shinfo(skb)->gso_segs. Signed-off-by: Saeed Mahameed Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/n

[PATCH net-next V1 00/11] Mellanox NIC drivers update, June 23 2015

2015-06-23 Thread Or Gerlitz
Hi Dave, This series has two fixes from Eran to his recent SRIOV counters work in mlx4 and few more updates from Saeed and Achiad to the mlx5 Ethernet code. All fixes here relate to net-next code, so no need for -stable. Or. Changes from V0: - dropped the patch that move us to poll RX complet

[PATCH net-next V1 08/11] net/mlx5e: Remove extra spaces

2015-06-23 Thread Or Gerlitz
From: Achiad Shochat Coding Style fix, remove extra spaces. Signed-off-by: Achiad Shochat Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/en_tx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c

[PATCH net-next V1 02/11] net/mlx4_en: Use HW counters for rx/tx bytes/packets in PF device

2015-06-23 Thread Or Gerlitz
From: Eran Ben Elisha Under SRIOV, the port rx/tx bytes/packets statistics should by read from the HW instead of using the PF netdevice SW accounting. This is needed in order to get the full port statistics and not just the PF own ones Signed-off-by: Eran Ben Elisha Signed-off-by: Or Gerlitz -

[PATCH net-next V1 09/11] net/mlx5e: Remove mlx5e_cq.sqrq back-pointer

2015-06-23 Thread Or Gerlitz
From: Achiad Shochat Use container_of() instead. Signed-off-by: Achiad Shochat Signed-off-by: Saeed Mahameed Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 - drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 3 --- drivers/net/ethernet/mellanox/mlx5/co

[PATCH net-next V1 05/11] net/mlx5e: Remove re-assignment of wq type in mlx5e_enable_rq()

2015-06-23 Thread Or Gerlitz
From: Achiad Shochat It is already assigned at mlx5e_build_rq_param() Signed-off-by: Achiad Shochat Signed-off-by: Saeed Mahameed Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/m

[PATCH net-next V1 11/11] net/mlx5e: Prefetch skb data on RX

2015-06-23 Thread Or Gerlitz
From: Saeed Mahameed Prefetch the 1st cache line used by the buffer pointed by the skb linear data. Signed-off-by: Saeed Mahameed Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlx

[PATCH net-next V1 07/11] net/mlx5e: Avoid TX CQE generation if more xmit packets expected

2015-06-23 Thread Or Gerlitz
From: Achiad Shochat In order to save PCI BW consumed by TX CQEs and to reduce the amount of CPU cache misses caused by TX CQE reading, we request TX CQE generation only when skb->xmit_more=0. As a consequence of the above, a single TX CQE may now indicate the transmission completion of multiple

Re: [PATCH net-next 05/12] net/mlx5e: Poll rx cq before tx cq to improve round-trip latency

2015-06-23 Thread Or Gerlitz
On 6/22/2015 4:35 PM, David Miller wrote: From: achiad shochat Date: Mon, 22 Jun 2015 00:35:37 +0300 Hello Dave, In mlx5 the RX processing is broken down into two stages: 1) Hand to kernel SKBs of completed RX packets - @mlx5e_poll_rx_cq() 2) Allocate and post to HW new RX buffers - @mlx5e_po

Re: [PATCH net-next v0 0/4] drivers: net: xgene: Fix the ACPI support for RGMII/SGMII0/XFI ethernet interfaces of APM X-Gene SoC.

2015-06-23 Thread David Miller
From: Suman Tripathi Date: Tue, 23 Jun 2015 14:47:13 +0530 > Signed-off-by: Iyappan Subramanian > Signed-off-by: Suman Tripathi Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v7] NET: Add ezchip ethernet driver

2015-06-23 Thread David Miller
From: Noam Camus Date: Tue, 23 Jun 2015 11:43:53 +0300 > From: Noam Camus > > Simple LAN device for debug or management purposes. > Device supports interrupts for RX and TX(completion). > Device does not have DMA ability. > > Signed-off-by: Noam Camus > Signed-off-by: Tal Zilcer > Acked-by:

Re: [PATCH] rocker: call correct unregister function on error

2015-06-23 Thread David Miller
From: Jiri Pirko Date: Tue, 23 Jun 2015 10:01:40 +0200 > Tue, Jun 23, 2015 at 09:52:10AM CEST, gi...@benyossef.com wrote: >>Use the correct unregister function matching the register >>function on the error path. >> >>Signed-off-by: Gilad Ben-Yossef >>CC: Gilad Ben-Yossef >>CC: Scott Feldman >>

Re: [PATCH net-next v1 1/1] net: fec: init MAC prior to mii bus probe

2015-06-23 Thread David Miller
From: Fugang Duan Date: Tue, 23 Jun 2015 15:32:51 +0800 > Below case causes mii bus probe failed: > ifconfig eth0 down -> suspend/resume with Mega/fax mix off -> ifconfig eth0 up > > In i.MX6SX/i.MX7D chip, Mega/fast mix off feature is supported that means > most of > SOC power will be off incl

Re: [PATCH v2] net: Cavium: Fix MAC address setting in shutdown state

2015-06-23 Thread David Miller
From: Pavel Fedin Date: Tue, 23 Jun 2015 10:11:03 +0300 > This bug pops up with NetworkManager on Fedora 21. NetworkManager tends to > stop the interface (nicvf_stop() is called) before changing settings. In > stopped state MAC cannot be sent to a PF. However, when the interface is > restarted (n

Re: [PATCH net] dcb : Fix incorrect documentation for struct dcb_app

2015-06-23 Thread David Miller
From: Anish Bhatt Date: Mon, 22 Jun 2015 17:44:35 -0700 > While IEEE and CEE use the same structure to store apps, the selector > and priority fields for both are different. Only the priority field is > explained, add documentation explaining how the selector field differs > for both. > > cgdcbx

Re: [PATCH net-next 0/2] switchdev; add VLAN support for port's bridge_getlink

2015-06-23 Thread David Miller
From: sfel...@gmail.com Date: Mon, 22 Jun 2015 00:27:15 -0700 > From: Scott Feldman > > One more missing piece of the puzzle. Add vlan dump support to switchdev > port's bridge_getlink. iproute2 "bridge vlan show" cmd already knows how > to show the vlans installed on the bridge and the device

Re: [RFC PATCH v2] packet: remove handling of tx_ring

2015-06-23 Thread David Miller
From: Maninder Singh Date: Mon, 22 Jun 2015 12:39:16 +0530 > Remove handling of tx_ring in prb_setup_retire_blk_timer > for TPACKET_V3 because init_prb_bdqc is called only for zero tx_ring > and thus prb_setup_retire_blk_timer for zero tx_ring only. > > And also in functon init_prb_bdqc there i

Re: [PATCH next] drivers/net: remove all references to obsolete Ethernet-HOWTO

2015-06-23 Thread David Miller
From: Paul Gortmaker Date: Sun, 21 Jun 2015 16:28:02 -0400 > This howto made sense in the 1990s when users had to manually configure > ISA cards with jumpers or vendor utilities, but with the implementation > of PCI it became increasingly less and less relevant, to the point where > it has been w

Re: [PATCH v2 0/4] net: stmmac: dwmac-rk: add support for rk3368

2015-06-23 Thread David Miller
From: Heiko Stuebner Date: Sun, 21 Jun 2015 21:52:50 +0200 > Apart from small cleanups, this series provides support for the dwmac > on the new rk3368 ARM64 soc. > > Tested on a R88 board using a RMII phy. > > Changes since v1: > - Adapt to changes resulting from patch d42202dce002 ("net: stmma

Re: [PATCH] lib: test_bpf: purge CPP register redefinitions

2015-06-23 Thread David Miller
From: Nicolai Stange Date: Mon, 22 Jun 2015 15:47:12 +0200 > Richard Weinberger writes: >> While riding the bus to my office I've materialized that idea. >> Nicolai, can you please give the attached patch a try? > W/o my test_bpf patch applied, w/ your patch applied: > - linux mainline: um comp

Re: [PATCH] lib: test_bpf: purge CPP register redefinitions

2015-06-23 Thread David Miller
From: Nicolai Stange Date: Sun, 21 Jun 2015 21:41:03 +0200 > Fix compilation failer with allmodconfig on ARCH=um: > lib/test_bpf.c:50:0: warning: "R8" redefined >#define R8 BPF_REG_8 >^ > In file included from arch/um/include/asm/ptrace-generic.h:11:0, >from arch/

Re: pull-request: can 2015-06-21

2015-06-23 Thread David Miller
From: Marc Kleine-Budde Date: Sun, 21 Jun 2015 19:04:58 +0200 > this is a, probably too late, pull request for v4.1. > > Oliver Hartkopp fixed a bug in the generic CAN frame handling code, which may > lead to loss of CAN frames. It was introduced during v4.1 development. > > Please queue via ne

  1   2   >