Le Wednesday 17 June 2015 à 03:05 +0200, Nicolai Stange a écrit :
> Fix an allmodconfig compilation failer on microblaze due to big endian
> architectures being apparently unsupported by the NetJet code:
> drivers/isdn/hisax/nj_s.c: In function 'setup_netjet_s':
> drivers/isdn/hisax/nj_s.c:265:
Wed, Jun 17, 2015 at 01:53:56AM CEST, sfel...@gmail.com wrote:
>On Tue, Jun 16, 2015 at 2:11 PM, Jiri Pirko wrote:
>> Tue, Jun 16, 2015 at 06:47:47PM CEST, sfel...@gmail.com wrote:
>>>On Mon, Jun 15, 2015 at 11:04 PM, Jiri Pirko wrote:
Tue, Jun 16, 2015 at 01:25:51AM CEST, da...@davemloft.ne
On Tue, 16 Jun 2015 14:53:36 -0700
Andrew Morton wrote:
> On Mon, 15 Jun 2015 17:52:46 +0200 Jesper Dangaard Brouer
> wrote:
>
[...]
> > + /* Invoke slow path one time, then retry fastpath
> > +* as side-effect have updated c->freelist
> > +
On Wed, Jun 17, 2015 at 10:06:01AM +0530, Maninder Singh wrote:
> Use BUG_ON(condition) instead of if(condition)/BUG() .
>
> Signed-off-by: Maninder Singh
> Reviewed-by: Akhilesh Kumar
Why not?
Acked-by: Michael S. Tsirkin
> ---
> net/packet/af_packet.c |3 +--
> 1 files changed, 1 ins
On Tue, 16 Jun 2015 14:51:09 -0700
Andrew Morton wrote:
> On Mon, 15 Jun 2015 17:52:26 +0200 Jesper Dangaard Brouer
> wrote:
>
> > The current kmem_cache/SLAB bulking API need to release all objects
> > in case the layer cannot satisfy the full request.
> >
> > If __kmem_cache_alloc_bulk() fa
On Tue, 16 Jun 2015 14:48:40 -0700
Andrew Morton wrote:
> On Mon, 15 Jun 2015 17:52:07 +0200 Jesper Dangaard Brouer
> wrote:
>
> > From: Christoph Lameter
> >
> > [NOTICE: Already in AKPM's quilt-queue]
> >
> > First piece: acceleration of retrieval of per cpu objects
> >
> > If we are all
On Tue, Jun 16, 2015 at 7:12 PM, Nicholas Krause wrote:
> This makes the function be_get_sriov_config have a return type of
> void now due to never signaling/nor its only caller the function
> be_alloc_sriov_res checking if this function has returned a
> error code to indicate this particular func
Hi David,
>> Use BUG_ON(condition) instead of if(condition)/BUG()
>>
>> Signed-off-by: Maninder Singh
>> Reviewed-by: Akhilesh Kumar
>Your email client corrupted this patch, making it unusable
I resent the patch with git send-mail , it results ok, hopefully it does not
corrupt it.
Thanks
Hi All,
I have connected my pc and TV board as below -
PC (network i/f) <> ethernet to usb dongle <---> usb port of TV board
When I power off my board, i get a kernel crash.
Please have a look at log attached here.I debug and found that
unregister_netdev() in usbnet_disconnect() clears net_
Use BUG_ON(condition) instead of if(condition)/BUG() .
Signed-off-by: Maninder Singh
Reviewed-by: Akhilesh Kumar
---
net/packet/af_packet.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index b5989c6..c91d405 100644
--
Signed-off-by: Hariprasad Shenai
---
drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h
b/drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h
index 1a9a6f3..d7ca106 100644
--- a/drivers/net/et
Fix an allmodconfig compilation failer on microblaze due to big endian
architectures being apparently unsupported by the NetJet code:
drivers/isdn/hisax/nj_s.c: In function 'setup_netjet_s':
drivers/isdn/hisax/nj_s.c:265:2:
error: #error "not running on big endian machines now"
Modify th
Following patch contains changes in liquidio Kconfig for
selecting LIBCRC32C.
Signed-off-by: Derek Chickles
Signed-off-by: Satanand Burla
Signed-off-by: Felix Manlunas
Signed-off-by: Raghu Vatsavayi
---
drivers/net/ethernet/cavium/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Wed, 2015-06-17 at 01:29 +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 06/17/2015 01:09 AM, Joe Perches wrote:
>
> >>> Append 0x to all %x in order to avoid while reading when there is other
> >>> decimal value in the log.
>
> > []
>
> >>> @@ -874,7 +874,7 @@ static inline void xenvif_grant_
On Tue, Jun 16, 2015 at 2:11 PM, Jiri Pirko wrote:
> Tue, Jun 16, 2015 at 06:47:47PM CEST, sfel...@gmail.com wrote:
>>On Mon, Jun 15, 2015 at 11:04 PM, Jiri Pirko wrote:
>>> Tue, Jun 16, 2015 at 01:25:51AM CEST, da...@davemloft.net wrote:
From: sfel...@gmail.com
Date: Sat, 13 Jun 2015 11:
Hi,
Stas Sergeev writes:
> 17.06.2015 00:44, Arnaud Ebalard пишет:
>> Hi,
>>
>> On Mirabox, the second ethernet interface is no more usable on 4.1-rc*
>> series (no packets coming out of the interface, when using dhclient for
>> instance). It works as expected on 4.0.
>>
>> Bisecting the issue,
There's no reason to perform a buffer copy for the firmware name. This
also avoids a (currently impossible with current callers) NULL dereference
if there was no matching firmware.
Signed-off-by: Kees Cook
---
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 12 ++--
1 file changed, 6 i
SCTP has this operation to peel off associations from a given socket and
create a new socket using this association. We currently have two ways
to use this operation:
- via getsockopt(), on which it will also create and return a file
descriptor for this new socket
- via sctp_do_peeloff(), which i
This patch reverts 2f2d76cc3e93 ("dlm: Do not allocate a fd for
peeloff") but also makes use of a new sockopt:
SCTP_SOCKOPT_PEELOFF_KERNEL, which avoids allocating file descriptors
while doing this operation.
By this we avoid creating a direct dependency from dlm to sctp module,
which can then be
Hi,
I'm trying to remove a direct dependency of dlm module on sctp one.
Currently dlm code is calling sctp_do_peeloff() directly and only this
call is causing the load of sctp module together with dlm. For that, we
have basically 3 options:
- Doing a module split on dlm
- which I'm avoiding beca
Hello.
On 06/17/2015 01:09 AM, Joe Perches wrote:
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
[]
@@ -874,7 +874,7 @@ static inline void xenvif_grant_handle_set(struct
xenvif_queue *queue,
if (unlikely(queue->grant_tx_handle[pe
The control !hlist_unhashed() in qfq_destroy_agg() is unnecessary
because already performed in hlist_del_init(), so remove it.
Signed-off-by: Andrea Parri
---
net/sched/sch_qfq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c
index
On Tue, 2015-06-16 at 23:07 +0300, Sergei Shtylyov wrote:
> On 06/16/2015 10:10 PM, Julien Grall wrote:
> > Append 0x to all %x in order to avoid while reading when there is other
> > decimal value in the log.
[]
> > @@ -874,7 +874,7 @@ static inline void xenvif_grant_handle_set(struct
> > xenvif_
On Mon, 15 Jun 2015 17:52:46 +0200 Jesper Dangaard Brouer
wrote:
> Call slowpath __slab_alloc() from within the bulk loop, as the
> side-effect of this call likely repopulates c->freelist.
>
> Choose to reenable local IRQs while calling slowpath.
>
> Saving some optimizations for later. E.g.
On Tue, Jun 16, 2015 at 5:07 PM, Willem de Bruijn wrote:
> From: Willem de Bruijn
>
> PACKET_FANOUT_LB computes f->rr_cur such that it is modulo
> f->num_members. It returns the old value unconditionally, but
> f->num_members may have changed since the last store. This can be
> fixed with
>
> -
On Mon, 15 Jun 2015 17:52:26 +0200 Jesper Dangaard Brouer
wrote:
> The current kmem_cache/SLAB bulking API need to release all objects
> in case the layer cannot satisfy the full request.
>
> If __kmem_cache_alloc_bulk() fails, all allocated objects in array
> should be freed, but, __kmem_cache
Hi,
On Mirabox, the second ethernet interface is no more usable on 4.1-rc*
series (no packets coming out of the interface, when using dhclient for
instance). It works as expected on 4.0.
Bisecting the issue, I ended up on 898b2970e2c9 ("mvneta: implement
SGMII-based in-band link state signaling")
On Mon, 15 Jun 2015 17:52:07 +0200 Jesper Dangaard Brouer
wrote:
> From: Christoph Lameter
>
> [NOTICE: Already in AKPM's quilt-queue]
>
> First piece: acceleration of retrieval of per cpu objects
>
> If we are allocating lots of objects then it is advantageous to disable
> interrupts and av
On Mon, 15 Jun 2015 17:51:56 +0200 Jesper Dangaard Brouer
wrote:
> +bool kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, size_t size,
> + void **p)
> +{
> + return kmem_cache_alloc_bulk(s, flags, size, p);
> +}
hm, any cal
Acked-by: Jacob Keller
Regards,
Jake
On Tue, 2015-06-16 at 11:47 -0700, Alexander Duyck wrote:
> This change pulls out the optimization that assumed that all
> fragments
> would be limited to page size. That hasn't been the case for some
> time now
> and to assume this is incorrect as the TCP
Tue, Jun 16, 2015 at 06:47:47PM CEST, sfel...@gmail.com wrote:
>On Mon, Jun 15, 2015 at 11:04 PM, Jiri Pirko wrote:
>> Tue, Jun 16, 2015 at 01:25:51AM CEST, da...@davemloft.net wrote:
>>>From: sfel...@gmail.com
>>>Date: Sat, 13 Jun 2015 11:04:26 -0700
>>>
The switchdev port driver must do two
From: Willem de Bruijn
PACKET_FANOUT_LB computes f->rr_cur such that it is modulo
f->num_members. It returns the old value unconditionally, but
f->num_members may have changed since the last store. This can be
fixed with
-return cur
+return cur < num ? : 0;
When modifying th
Pablo Neira Ayuso writes:
> On Mon, Jun 15, 2015 at 07:26:13PM -0500, Eric W. Biederman wrote:
> [...]
>> So what I am in the processes of doing is reviewing and testing
>> the combined set of patches and hopefully I will have something
>> for you soon (tomorrow?). Unless Pablo has objections.
>
On Tue, 2015-06-16 at 13:33 -0700, Jacob E Keller wrote:
> On Tue, 2015-06-16 at 17:19 +0300, Sergei Shtylyov wrote:
> > On 6/16/2015 4:47 PM, Jeff Kirsher wrote:
> >
> > > From: Jacob Keller
> >
> > > The value will never be negative, and we use the %i print format,
> > >
> > > use
> >
> >
On Tue, 2015-06-16 at 17:16 +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 6/16/2015 4:47 PM, Jeff Kirsher wrote:
>
> > From: Jacob Keller
>
> > Fix up error message style to include a colon.
>
> > Signed-off-by: Jacob Keller
> > Tested-by: Krishneil Singh
> > Signed-off-by: Jeff Kirsher
> >
On Tue, 2015-06-16 at 17:19 +0300, Sergei Shtylyov wrote:
> On 6/16/2015 4:47 PM, Jeff Kirsher wrote:
>
> > From: Jacob Keller
>
> > The value will never be negative, and we use the %i print format,
> > use
>
> "%i" is the same as "%d", AFAIR. You need "%u" for the unsigned
> variables.
>
> I am not sure filter works, and apparently some fields are not properly
> reported ? (source port for example looks wrong)
>
> (Note : you probably need to filter in user space, but ss should already
> have support for this)
Ah, good catch on the filter. It can be fixed by
- if ((err = inet_show
Hello.
On 06/16/2015 10:10 PM, Julien Grall wrote:
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
Also replace some of the hexadecimal print to decimal to uniformize the
format with netfront.
Signed-off-by: Julien Grall
Cc: Wei Liu
Cc:
Don't opencode sg_init_one()
Signed-off-by: Fabian Frederick
---
net/sunrpc/auth_gss/gss_krb5_crypto.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/net/sunrpc/auth_gss/gss_krb5_crypto.c
b/net/sunrpc/auth_gss/gss_krb5_crypto.c
index b5408e8..fee3c15 100644
--- a/ne
The lockless lookups can return entry that is unlinked.
Sometimes they get reference before last neigh_cleanup_and_release,
sometimes they do not need reference. Later, any
modification attempts may result in the following problems:
1. entry is not destroyed immediately because neigh_update
can st
On Mon, Jun 15, 2015 at 5:39 PM, Simon Horman
wrote:
> Currently output of MPLS packets on tunnel vports is not allowed by the
> datapath and, moreover, flows that match on MPLS packets and output to
> tunnel vports are rejected by the datapath. The flows are rejected
> regardless of if they also
On Tue, 2015-06-16 at 12:51 -0400, Willem de Bruijn wrote:
> From: Willem de Bruijn
>
> Destruction of the po->rollover must be delayed until there are no
> more packets in flight that can access it. The field is destroyed in
> packet_release, before synchronize_net. Delay using rcu.
>
> Fixes:
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
Also replace some of the hexadecimal print to decimal to uniformize the
format with netfront.
Signed-off-by: Julien Grall
Cc: Wei Liu
Cc: Ian Campbell
Cc: netdev@vger.kernel.org
---
Changes i
The variables old_req_cons and ring_slots_used are assigned but never
used since commit 1650d5455bd2dc6b5ee134bd6fc1a3236c266b5b "xen-netback:
always fully coalesce guest Rx packets".
Signed-off-by: Julien Grall
Acked-by: Wei Liu
Cc: Ian Campbell
Cc: netdev@vger.kernel.org
---
Changes in v
rx->status is an int16_t, print it using %d rather than %u in order to
have a meaningful value when the field is negative.
Also use %u rather than %x for rx->offset.
Signed-off-by: Julien Grall
Reviewed-by: David Vrabel
Cc: Konrad Rzeszutek Wilk
Cc: Boris Ostrovsky
Cc: netdev@vger.kernel.org
Hello David,
this is a pull request intended for net/linux-4.1.
I know it is rather late in the release cycle, but the fixes are
pretty small and they were worth being sent now.
Patch 1/2 fixes an overflow of a u32 variable that may happen while
computing the metric to select the best batman-GW i
From: Ruben Wisniewski
The gateway selection based on fast connections is using a single value
calculated from the average tq (0-255) and the download bandwidth (in
100Kibit). The formula for the first step (tq ** 2 * 1 * bandwidth)
tends to overflow a u32 with low bandwidth settings like 50
When a node running DAT receives an ARP request from the LAN for the
first time, it is likely that this node will request the ARP entry
through the distributed ARP table (DAT) in the mesh.
Once a DAT reply is received the asking node must check if the MAC
address for which the IP address has been
This change pulls out the optimization that assumed that all fragments
would be limited to page size. That hasn't been the case for some time now
and to assume this is incorrect as the TCP allocator can provide up to a
32K page fragment.
Signed-off-by: Alexander Duyck
---
drivers/net/ethernet/i
This patch also renames sg to sglist and aligns function parameters.
See Documentation/DMA-API.txt - Part Id for scatterlist details
Signed-off-by: Fabian Frederick
---
This is untested.
V2: reorder variables (suggested by David S. Miller)
net/rds/ib.h | 22 ++
1 file change
On Tue, Jun 16, 2015 at 8:22 PM, nick wrote:
>
>
> On 2015-06-16 01:16 PM, Ilya Dryomov wrote:
>> On Tue, Jun 16, 2015 at 8:07 PM, nick wrote:
>>>
>>>
>>> On 2015-06-16 12:47 PM, Ilya Dryomov wrote:
On Tue, Jun 16, 2015 at 7:18 PM, nick wrote:
> Ilya,
> That's fine I do have a unrel
On 16.06.2015 19:35, Oliver Hartkopp wrote:
ps. will apply the patch from Nicolas if it fixes the ip output.
No it didn't - I have no bridging configured in my kernel %-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
Current implementtion of descriptor init procedure only takes care about
ownership flag. While it is perfectly possible to have underlying memory
filled with garbage on boot or driver installation.
And randomly set flags in non-zeroed des0 and des1 fields may lead to
unpredictable behavior of the
On 15.06.2015 17:54, Stephen Hemminger wrote:
On Mon, 15 Jun 2015 11:13:12 +0200
Nicolas Dichtel wrote:
Theoretically, virtual interfaces should advertise an IFLA_LINK to 0.
I don't know what is the best fix:
- patching iproute2 to avoid this '@NONE'
- patching the kernel (see below).
On Tue, Jun 16, 2015 at 8:07 PM, nick wrote:
>
>
> On 2015-06-16 12:47 PM, Ilya Dryomov wrote:
>> On Tue, Jun 16, 2015 at 7:18 PM, nick wrote:
>>> Ilya,
>>> That's fine I do have a unrelated question through. I have over 90 patches
>>> lying around in terms of cleanups/
>>> fixes and need help g
On Tue, Jun 16, 2015 at 7:57 PM, nick wrote:
>
>
> On 2015-06-16 12:47 PM, Ilya Dryomov wrote:
>> On Tue, Jun 16, 2015 at 7:18 PM, nick wrote:
>>> Ilya,
>>> That's fine I do have a unrelated question through. I have over 90 patches
>>> lying around in terms of cleanups/
>>> fixes and need help g
On 6/16/15 2:19 AM, Daniel Borkmann wrote:
if you really want to, you
could go via skb->sk->sk_socket->file and then retrieve credentials
from there for egress side (you can have a look at xt_owner). You'd
need a different *_proto helper for tc in that case, which would
then map to BPF_FUNC_get_c
From: Willem de Bruijn
Destruction of the po->rollover must be delayed until there are no
more packets in flight that can access it. The field is destroyed in
packet_release, before synchronize_net. Delay using rcu.
Fixes: 0648ab70afe6 ("packet: rollover prepare: per-socket state")
Suggested-by
On Tue, 2015-06-16 at 12:02 -0400, Craig Gallek wrote:
> Use the IPv4/IPv6/TCP/UDP multicast groups of NETLINK_SOCK_DIAG
> to filter and display socket statistics as they are destroyed.
>
> Kernel support patch series: 24029a3603cfa633e8bc2b3fb3e48e76c497831d
>
> Signed-off-by: Craig Gallek
> --
> The idea is to allow SIDR request to be sorted by the GID, when we will
> have alias GIDs for IPoIB.
Please limit this series, or at least the early patches in this series, to
simply moving the de-mux out of the ib_cm and into the rdma_cm.
--
To unsubscribe from this list: send the line "unsubs
On Mon, Jun 15, 2015 at 11:04 PM, Jiri Pirko wrote:
> Tue, Jun 16, 2015 at 01:25:51AM CEST, da...@davemloft.net wrote:
>>From: sfel...@gmail.com
>>Date: Sat, 13 Jun 2015 11:04:26 -0700
>>
>>> The switchdev port driver must do two things:
>>>
>>> 1) Generate a fwd_mark for each switch port, using s
On Tue, Jun 16, 2015 at 7:18 PM, nick wrote:
> Ilya,
> That's fine I do have a unrelated question through. I have over 90 patches
> lying around in terms of cleanups/
> fixes and need help getting them merged. Should I just resend them or wait
> until the end of this merge window.
Are all of th
From: Roopa Prabhu
This patch adds NLM_F_APPEND flag to struct nlmsg_hdr->nlmsg_flags
in newroute notifications if the route add was an append.
(This is similar to how NLM_F_REPLACE is already part of new
route replace notifications today)
This helps userspace determine if the route add operatio
On 6/16/15, 9:11 AM, Roopa Prabhu wrote:
From: Roopa Prabhu
This patch adds NLM_F_APPEND flag to struct nlmsg_hdr->nlmsg_flags
in newroute notifications if the route add was an append.
(This is similar to how NLM_F_REPLACE is already part of new
route replace notifications today)
This helps us
On Tue, Jun 9, 2015 at 11:00 AM, Ilya Dryomov wrote:
> On Tue, Jun 9, 2015 at 1:51 AM, Nicholas Krause wrote:
>> This makes the function, crush_ln static now due to having
>> only one caller in its own definition and declaration file
>> of mapper.c
>>
>> Signed-off-by: Nicholas Krause
>> ---
>>
From: Roopa Prabhu
This patch adds NLM_F_APPEND flag to struct nlmsg_hdr->nlmsg_flags
in newroute notifications if the route add was an append.
(This is similar to how NLM_F_REPLACE is already part of new
route replace notifications today)
This helps userspace determine if the route add operatio
On Tue, 16 Jun 2015, Jesper Dangaard Brouer wrote:
> It is very important that everybody realizes that the save+restore
> variant is very expensive, this is key:
>
> CPU: i7-4790K CPU @ 4.00GHz
> * local_irq_{disable,enable}: 7 cycles(tsc) - 1.821 ns
> * local_irq_{save,restore} : 37 cycles(ts
Use the IPv4/IPv6/TCP/UDP multicast groups of NETLINK_SOCK_DIAG
to filter and display socket statistics as they are destroyed.
Kernel support patch series: 24029a3603cfa633e8bc2b3fb3e48e76c497831d
Signed-off-by: Craig Gallek
---
include/linux/inet_diag.h | 3 +-
include/linux/sock_diag.h | 10
On Tue, 16 Jun 2015 10:10:25 -0500 (CDT)
Christoph Lameter wrote:
> On Tue, 16 Jun 2015, Joonsoo Kim wrote:
>
> > So, in your test, most of objects may come from one or two slabs and your
> > algorithm is well optimized for this case. But, is this workload normal
> > case?
>
> It is normal if
> -Original Message-
> From: netdev-ow...@vger.kernel.org [mailto:netdev-
> ow...@vger.kernel.org] On Behalf Of Ashutosh Tripathi
> Sent: Tuesday, June 16, 2015 3:52 AM
> To: netdev@vger.kernel.org
> Subject: Setting up interfaces in loopback mode using SIOCETHTOOL
>
> Hi All,
>
> In sp
On Tue, 16 Jun 2015, Joonsoo Kim wrote:
> So, in your test, most of objects may come from one or two slabs and your
> algorithm is well optimized for this case. But, is this workload normal case?
It is normal if the objects were bulk allocated because SLUB ensures that
all objects are first alloc
On Tue, 16 Jun 2015, Joonsoo Kim wrote:
> > If adding these, then I would also need to add those on alloc path...
>
> Yes, please.
Lets fall back to the generic implementation for any of these things. We
need to focus on maximum performance in these functions. The more special
cases we have to ha
On Tue, 16 Jun 2015, Joonsoo Kim wrote:
> Now I found that we need to call slab_pre_alloc_hook() before any operation
> on kmem_cache to support kmemcg accounting. And, we need to call
> slab_post_alloc_hook() on every allocated objects to support many
> debugging features like as kasan and kmemle
From: Eric Dumazet
We need to tell compiler it must not read f->num_members multiple
times. Otherwise testing if num is not zero is flaky, and we could
attempt an invalid divide by 0 in fanout_demux_cpu()
Note bug was present in packet_rcv_fanout_hash() and
packet_rcv_fanout_lb() but final 3.1 h
From: Noam Camus
Simple LAN device for debug or management purposes.
Device supports interrupts for RX and TX(completion).
Device does not have DMA ability.
Signed-off-by: Noam Camus
Signed-off-by: Tal Zilcer
Acked-by: Alexey Brodkin
---
Change log for v5:
Basically its all based on Florian c
On 6/16/2015 4:47 PM, Jeff Kirsher wrote:
From: Jacob Keller
The value will never be negative, and we use the %i print format, use
"%i" is the same as "%d", AFAIR. You need "%u" for the unsigned variables.
unsigned int for the loop counter. Issue found using cppcheck.
Signed-off-by
On 6/16/2015 4:47 PM, Jeff Kirsher wrote:
From: Jacob Keller
This patch cleans up the use of dma_get_required_mask and uses the
simpler dma_set_mask_and_coherent function instead of doing these as
separate steps.
I removed the dma_get_required_mask call because based on some minimal
testi
Hello.
On 6/16/2015 4:47 PM, Jeff Kirsher wrote:
From: Jacob Keller
Fix up error message style to include a colon.
Signed-off-by: Jacob Keller
Tested-by: Krishneil Singh
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 2 +-
1 file changed, 1 insertion
From: Jacob Keller
During initialization, the VF counts its rings by walking the TQDLOC
registers. This works only if the TQMAP/RQMAP registers are set to map
all of the out-of-bound rings back to the first one. This allows the VF
to cleanly detect when it has run out of queues. Update the PF cod
From: Jacob Keller
Currently, we don't notify the switch at all when the PF
administratively sets a new VLAN or MAC address. This causes the old
addresses to remain valid on the switch table. Since the PF is
overriding any configuration done directly by the VF, we choose to
simply re-create the L
From: Jacob Keller
This patch simplifies the code flow for setting the IN_PROGRESS bit of
the shinfo for an skb we will be timestamping.
Reported-by: Eric Dumazet
Signed-off-by: Jacob Keller
Tested-by: Krishneil Singh
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/fm10k/fm10k_pt
From: Jacob Keller
The value will never be negative, and we use the %i print format, use
unsigned int for the loop counter. Issue found using cppcheck.
Signed-off-by: Jacob Keller
Tested-by: Krishneil Singh
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 2
From: Jacob Keller
This patch resolves a bug in the ts_tx_enqueue code responsible for a
NULL pointer dereference and invalid access of the skb list. We
incorrectly freed the actual skb we found instead of our copy. Thus the
skb queue is essentially invalidated. Resolve this by freeing our clone
From: Jacob Keller
skb_complete_tx_timestamp is intended for use by PHY drivers which
implement a different method of returning timestamps. This method is
intended to be used after a PHY driver accepts a cloned packet via its
phy_driver.txtstamp function. It is not correct to use in the standard
From: Jacob Keller
The reference to err_no was left around after a previous code refactor.
We never use the value, and it doesn't seem to be used in side a hidden
macro reference. Discovered via cppcheck.
Signed-off-by: Jacob Keller
Tested-by: Krishneil Singh
Signed-off-by: Jeff Kirsher
---
From: Jacob Keller
The SYSTIME_CFG.Adjust Direction bit is actually supposed to indicate
that the adjustment is positive. Fix the code to align correctly with
hardware and documentation.
Signed-off-by: Jacob Keller
Tested-by: Krishneil Singh
Signed-off-by: Jeff Kirsher
---
drivers/net/ethern
From: Jacob Keller
Fix up error message style to include a colon.
Signed-off-by: Jacob Keller
Tested-by: Krishneil Singh
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel
From: Jacob Keller
This patch cleans up the use of dma_get_required_mask and uses the
simpler dma_set_mask_and_coherent function instead of doing these as
separate steps.
I removed the dma_get_required_mask call because based on some minimal
testing it appears that either (a) we're not doing the
From: Jacob Keller
This patch adds the __attribute__((packed)) indicator to some structures
which are overlayed onto a TLV message. These structures must be packed
as small as possible in order to correctly align when copied into the
mailbox buffer. Without doing so, the receiving mailbox code in
From: Jacob Keller
l2_accel was checked for NULL at the top of fm10k_dfwd_del_station, and
we return if it is not defined. Due to this, we already know it can't be
null here so a separate check is meaningless. Discovered via cppcheck.
Signed-off-by: Jacob Keller
Tested-by: Krishneil Singh
Sign
From: Jacob Keller
This prevents a memory leak in fm10k_set_ringparams. The leak occurs
because we go down, change ring parameters, and then come up. However,
fm10k_down on its own is not clearing the Rx rings. Since fm10k_up
assumes the rings are clean we basically drop the buffers and leak a
bu
From: Jacob Keller
This change fixes an issue with adding an invalid multicast address
using the iproute2 tool (ip maddr add dev ). The iproute2
tool and the kernel do not validate or filter the multicast addresses
when adding them to the multicast list. Thus, when synchronizing this
list with a
From: Alexander Duyck
While reviewing the code I noticed that one of the commits added an if
statement followed by a for loop, but the if statement was missing the
braces around the loop. This change corrects the coding style error.
Signed-off-by: Alexander Duyck
Acked-by: Jacob Keller
Tested
From: Jacob Keller
When a VF issues an LPORT_STATE request to enable a port that is already
enabled, the PF will first disable the VF LPORT. Then it should
re-enable the VF again with the new requested settings. This ensures
that any switch rules are cleared by deleting the LPORT on the switch.
H
This series contains updates to fm10k only.
Alex provides two fixes for the fm10k, first folds the fm10k_pull_tail()
call into fm10k_add_rx_frag(), this way the fragment does not have to be
modified after it is added to the skb. The second fixes missing braces
to an if statement.
The remaining p
From: Alexander Duyck
This change folds the fm10k_pull_tail call into fm10k_add_rx_frag. The
advantage to doing this is that the fragment doesn't have to be modified
after it is added to the skb.
Signed-off-by: Alexander Duyck
Tested-by: Krishneil Singh
Signed-off-by: Jeff Kirsher
---
drive
On 16/06/2015 01:33, Hefty, Sean wrote:
>> -static int cma_save_net_info(struct rdma_cm_id *id, struct rdma_cm_id
>> *listen_id,
>> - struct ib_cm_event *ib_event)
>> +static u16 cma_port_from_service_id(__be64 service_id)
>> {
>> -struct cma_hdr *hdr;
>> +return be
On 16/06/2015 01:13, Hefty, Sean wrote:
>> @@ -722,6 +725,7 @@ struct ib_cm_id *ib_create_cm_id(struct ib_device
>> *device,
>> INIT_LIST_HEAD(&cm_id_priv->work_list);
>> atomic_set(&cm_id_priv->work_count, -1);
>> atomic_set(&cm_id_priv->refcount, 1);
>> +cm_id_priv->listen_shar
В письме от 16 июня 2015 12:48:41 пользователь Pablo Neira Ayuso написал:
> On Mon, Jun 15, 2015 at 10:37:31PM +0300, Roman Khimov wrote:
> > В письме от 15 июня 2015 19:06:39 пользователь Pablo Neira Ayuso написал:
> > > On Mon, Jun 15, 2015 at 12:11:58PM +0300, Roman I Khimov wrote:
> > > > Suppo
2015-06-16 17:57 GMT+09:00 Jesper Dangaard Brouer :
> On Tue, 16 Jun 2015 10:21:10 +0200
> Jesper Dangaard Brouer wrote:
>
>>
>> On Tue, 16 Jun 2015 16:28:06 +0900 Joonsoo Kim
>> wrote:
>>
>> > Is this really better than just calling __kmem_cache_free_bulk()?
>>
>> Yes, as can be seen by cover-l
1 - 100 of 128 matches
Mail list logo
