From: Weilong Chen
There's a check for ip6_null_entry, but it's not enough if the config
CONFIG_IPV6_MULTIPLE_TABLES is selected. Blackhole or prohibited entries
should also be ignored.
This path is for kernel before v3.6, as there's a commit b94f1c0
use icmpv6_notify() instead of rt6_redirect()
Thu, Jun 11, 2015 at 05:19:01PM CEST, sfel...@gmail.com wrote:
>From: Scott Feldman
>
>Fix a BUG_ON() where CONFIG_NET_SWITCHDEV is set but the driver for a
>bridged port does not support switchdev_port_attr_set op. Don't BUG_ON()
>if -EOPNOTSUPP is returned.
>
>Also change BUG_ON() to netdev_err
Code refactoring:
1. Move the common code of inet_listen() and inet_dccp_listen() to
sock_common_listen().
2. Modify and rename inet_listen() to tcp_listen().
3. Modify and rename inet_dccp_listen() to dccp_listen().
4. Add new callback pointer listen in struct proto for
tcp_listen() and dccp_li
I recently upgraded my main server to 4.0.4 from 3.19.5 and rkhunter
started reporting a hidden port on my box.
Running unhide-tcp I see this:
# unhide-tcp
Unhide-tcp 20121229
Copyright © 2012 Yago Jesus & Patrick Gouin
License GPLv3+ : GNU GPL version 3 or later
http://www.unhide-forensics.inf
I'm seeing repeated hard lockups on my Dell Latitude E6530.
Helpful info:
0) next-20150603 works, so the problem landed in linux-next in the last week.
1) All 3 times happened while I was at home, using wireless, so
the interface didn't have link and was ifconfig'ed down.
2) Remarkably similar t
On Thu, Jun 11, 2015 at 07:25:43AM -0700, Eric Dumazet wrote:
>On Thu, 2015-06-11 at 19:05 +0800, Firo Yang wrote:
>> Code refactoring:
>> 1. Move the common code of inet_listen() and inet_dccp_listen() to
>> sock_common_listen().
>> Add new state SOCK_LISTEN and SOCK_CLOSE for sock_common_listen()
On Thu, May 28, 2015 at 5:48 PM, Luis R. Rodriguez wrote:
> On Tue, May 19, 2015 at 1:22 PM, Luis R. Rodriguez
> wrote:
>> This v2 just changes "licence" to "license" as requested by Arend.
>
> Please let me know if there is anything else needed.
Just a friendly reminder.
Luis
--
To unsubscrib
From: Shaohua Li
Date: Thu, 11 Jun 2015 16:50:48 -0700
> We saw excessive direct memory compaction triggered by skb_page_frag_refill.
> This causes performance issues and add latency. Commit 5640f7685831e0
> introduces the order-3 allocation. According to the changelog, the order-3
> allocation i
From: mleit...@redhat.com
Date: Thu, 11 Jun 2015 14:49:46 -0300
> From: Marcelo Ricardo Leitner
>
> Currently, we can ask to authenticate DATA chunks and we can send DATA
> chunks on the same packet as COOKIE_ECHO, but if you try to combine
> both, the DATA chunk will be sent unauthenticated and
From: sfel...@gmail.com
Date: Thu, 11 Jun 2015 12:15:22 -0700
> +static int __vlan_vid_add(struct net_device *dev, struct net_bridge *br,
> + u16 vid, u16 flags)
> +{
> + const struct net_device_ops *ops = dev->netdev_ops;
> + struct switchdev_obj vlan_obj = {
> +
On Thu, 2015-06-11 at 16:50 -0700, Shaohua Li wrote:
> We saw excessive direct memory compaction triggered by skb_page_frag_refill.
> This causes performance issues and add latency. Commit 5640f7685831e0
> introduces the order-3 allocation. According to the changelog, the order-3
> allocation isn't
On Thu, 2015-06-11 at 16:45 -0700, David Miller wrote:
> Series applied, however long term I worry that using a u16 will not
> work with TSO'd ipv6 jumbograms.
Well, this would be very long term, as we currently limit GSO/TSO
packets to less than 64KB anyway (tcp_xmit_size_goal())
new_size_goal
We saw excessive direct memory compaction triggered by skb_page_frag_refill.
This causes performance issues and add latency. Commit 5640f7685831e0
introduces the order-3 allocation. According to the changelog, the order-3
allocation isn't a must-have but to improve performance. But direct memory
co
From: Robert Shearman
Date: Thu, 11 Jun 2015 19:58:26 +0100
> If a device is renamed and the original name is subsequently reused
> for a new device, the following warning is generated:
...
> Fix this by unregistering the previous sysctl table (registered for
> the path containing the original d
From: Eric Dumazet
Date: Thu, 11 Jun 2015 09:15:14 -0700
> We put shinfo->gso_segs in TCP_SKB_CB(skb) a while back for performance
> reasons.
>
> This was in commit cd7d8498c9a5 ("tcp: change tcp_skb_pcount() location")
>
> This patch series complete the job for gso_size and gso_type, so that
>
On Thu, 2015-06-11 at 16:32 -0700, Shaohua Li wrote:
>
> Ok, looks similar, added. Didn't trigger this one though.
Probably because you do not use af_unix with big enough messages.
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index 3cfff2a..9856c7a 100644
> --- a/net/core/skbuff.c
> +
On Thu, Jun 11, 2015 at 03:53:04PM -0700, Eric Dumazet wrote:
> On Thu, 2015-06-11 at 15:27 -0700, Shaohua Li wrote:
> > We saw excessive direct memory compaction triggered by skb_page_frag_refill.
> > This causes performance issues and add latency. Commit 5640f7685831e0
> > introduces the order-3
From: mleit...@redhat.com
Date: Thu, 11 Jun 2015 11:30:46 -0300
> Attempts to circumvent this lock invertion with RCU and/or list splicing
> were unsuccessful, as they led to more and more code to handle it
> properly.
>
> Back when Hannes started reviewing the patches, he had
From: sfel...@gmail.com
Date: Thu, 11 Jun 2015 11:20:42 -0700
> From: Scott Feldman
>
> This particular BUG_ON condition was checking for attr set err in the
> COMMIT phase, which isn't expected (it's a driver bug if PREPARE phase is
> OK but COMMIT fails). But BUG_ON() is too strong for this c
From: Dan Carpenter
Date: Thu, 11 Jun 2015 11:50:01 +0300
> We return success if mlx5e_alloc_sq_db() fails but we should return an
> error code.
>
> Fixes: f62b8bb8f2d3 ('net/mlx5: Extend mlx5_core to support ConnectX-4
> Ethernet functionality')
> Signed-off-by: Dan Carpenter
Applied, thanks
On Thu, 2015-06-11 at 18:18 -0400, Chris Mason wrote:
> But, is there any fallback to a single page allocation somewhere else?
> If this is the only way to get memory, we might want to add a single
> alloc_page path that won't trigger compaction but is at least able to
> wait for kswapd to make pr
From: Jeff Kirsher
Date: Thu, 11 Jun 2015 15:59:05 -0700
> On Thu, 2015-06-11 at 14:51 +0200, Richard Cochran wrote:
>> When programming the start of a periodic output, the code wrongly
>> places
>> the seconds value into the "low" register and the nanoseconds into the
>> "high" register. Even t
On Thu, 2015-06-11 at 14:51 +0200, Richard Cochran wrote:
> When programming the start of a periodic output, the code wrongly
> places
> the seconds value into the "low" register and the nanoseconds into the
> "high" register. Even though this is backwards, it slipped through my
> testing, because
On Thu, 2015-06-11 at 15:56 -0700, David Miller wrote:
> From: Richard Cochran
> Date: Thu, 11 Jun 2015 14:53:10 +0200
>
> > On Thu, Jun 11, 2015 at 02:51:30PM +0200, Richard Cochran wrote:
> >> This patch fixes the issue by programming the registers correctly.
> >
> > Please also consider this
From: Ivan Vecera
Date: Thu, 11 Jun 2015 15:52:12 +0200
> The patches clean the bna driver.
>
> v2: changes & comments requested by Joe
Series applied, thanks Ivan.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More ma
From: Richard Cochran
Date: Thu, 11 Jun 2015 14:53:10 +0200
> On Thu, Jun 11, 2015 at 02:51:30PM +0200, Richard Cochran wrote:
>> This patch fixes the issue by programming the registers correctly.
>
> Please also consider this for stable.
Jeff, do you want me to integrate this directly?
--
To u
On Thu, 2015-06-11 at 15:27 -0700, Shaohua Li wrote:
> We saw excessive direct memory compaction triggered by skb_page_frag_refill.
> This causes performance issues and add latency. Commit 5640f7685831e0
> introduces the order-3 allocation. According to the changelog, the order-3
> allocation isn't
From: Or Gerlitz
Date: Thu, 11 Jun 2015 14:47:26 +0300
> This series from Saeed, Achiad and Gal contains few fixes
> to the recently introduced mlx5 Ethernet functionality.
Series applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
From: Noam Camus
Date: Thu, 11 Jun 2015 11:33:49 +0300
> +#define NPS_ENET_INT_MASK(sizeof(u32) - 1)
> +#define NPS_ENET_INT_OFFSET 2
> +#define NPS_ENET_WORDS_NUM(length) ((length + NPS_ENET_INT_MASK) >> 2)
This is a bit obfuscating in my opinion.
First of all "NPS_ENET_
From: Mahesh Bandewar
Date: Wed, 10 Jun 2015 17:19:56 -0700
> Actor and Partner details can be accessed via proc-fs and sys-fs
> entries. These interfaces are world readable at this moment. The
> earlier patch-series made the LACP communication secure to avoid
> nuisance attack from within the sa
From: Fabian Frederick
Date: Wed, 10 Jun 2015 18:33:13 +0200
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message
From: Fabian Frederick
Date: Wed, 10 Jun 2015 18:33:19 +0200
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message
From: Fabian Frederick
Date: Wed, 10 Jun 2015 18:33:16 +0200
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message
From: Fabian Frederick
Date: Wed, 10 Jun 2015 18:33:26 +0200
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message
From: Fabian Frederick
Date: Wed, 10 Jun 2015 18:33:06 +0200
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message
On 06/11/2015 05:22 PM, Eric Dumazet wrote:
> On Thu, 2015-06-11 at 17:16 -0400, Chris Mason wrote:
>> On 06/11/2015 04:48 PM, Eric Dumazet wrote:
>>
>> networking is asking for 32KB, and the MM layer is doing what it can to
>> provide it. Are the gains from getting 32KB contig bigger than the co
Please stop top-posting.
Quote the relevant material you are replying to first, the add your
response commentary afterwards rather than beforehand.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at ht
On Thu, 2015-06-11 at 01:31 +0100, David Woodhouse wrote:
> On Tue, 2015-06-09 at 17:49 -0700, Eric Dumazet wrote:
> > > I've added some debugging, and it seems that when it deadlocks, glibc
> > > doesn't get *any* response to its RTM_GETADDR request. I know we'd get
> > > ENOBUFS is a *response* w
On Thu, Jun 11, 2015 at 02:56:26PM -0700, Eric Dumazet wrote:
> On Thu, 2015-06-11 at 14:45 -0700, Shaohua Li wrote:
>
> > This is exactly what the patch try to do. Atomic 32k allocation will
> > fail with memory pressure, kswapd is waken up to do compaction and we
> > fallback to 4k.
>
> Read yo
On Thu, 2015-06-11 at 14:45 -0700, Shaohua Li wrote:
> This is exactly what the patch try to do. Atomic 32k allocation will
> fail with memory pressure, kswapd is waken up to do compaction and we
> fallback to 4k.
Read your changelog, then read what you just wrote.
Your changelog said :
'compa
On Thu, Jun 11, 2015 at 02:22:13PM -0700, Eric Dumazet wrote:
> On Thu, 2015-06-11 at 17:16 -0400, Chris Mason wrote:
> > On 06/11/2015 04:48 PM, Eric Dumazet wrote:
> > > On Thu, 2015-06-11 at 13:24 -0700, Shaohua Li wrote:
> > >> We saw excessive memory compaction triggered by skb_page_frag_refil
There is no "background" it doesn't matter if this activity happens
synchronously or asynchronously, unless you're sensitive to the
latency on that single operation. If you're driving all your cpu's and
memory hard then this is work that still takes resources. If there's a
kernel thread with compac
Resend in plaintext, thanks gmail:
It's somewhat an intractable problem to know if compaction will succeed
without trying it, and you can certainly end up in a state where memory is
heavily fragmented, even with compaction running. You can't compact kernel
pages for example, so you can end up in a
On Thu, 2015-06-11 at 17:16 -0400, Chris Mason wrote:
> On 06/11/2015 04:48 PM, Eric Dumazet wrote:
> > On Thu, 2015-06-11 at 13:24 -0700, Shaohua Li wrote:
> >> We saw excessive memory compaction triggered by skb_page_frag_refill.
> >> This causes performance issues. Commit 5640f7685831e0 introduc
On 06/11/2015 04:48 PM, Eric Dumazet wrote:
> On Thu, 2015-06-11 at 13:24 -0700, Shaohua Li wrote:
>> We saw excessive memory compaction triggered by skb_page_frag_refill.
>> This causes performance issues. Commit 5640f7685831e0 introduces the
>> order-3 allocation to improve performance. But memor
On Wed, 10 Jun 2015 17:19:56 -0700
Mahesh Bandewar wrote:
> Actor and Partner details can be accessed via proc-fs and sys-fs
> entries. These interfaces are world readable at this moment. The
> earlier patch-series made the LACP communication secure to avoid
> nuisance attack from within the same
On 06/11/2015 07:11 AM, Eric Dumazet wrote:
From: Eric Dumazet
dctcp_alpha can be read by from dctcp_get_info() without
synchro, so use WRITE_ONCE() to prevent compiler from using
dctcp_alpha as a temporary variable.
Also, playing with small dctcp_shift_g (like 1), can expose
an overflow with
On Thu, 2015-06-11 at 13:24 -0700, Shaohua Li wrote:
> We saw excessive memory compaction triggered by skb_page_frag_refill.
> This causes performance issues. Commit 5640f7685831e0 introduces the
> order-3 allocation to improve performance. But memory compaction has
> high overhead. The benefit of
We saw excessive memory compaction triggered by skb_page_frag_refill.
This causes performance issues. Commit 5640f7685831e0 introduces the
order-3 allocation to improve performance. But memory compaction has
high overhead. The benefit of order-3 allocation can't compensate the
overhead of memory co
On Thu, Jun 11, 2015 at 12:39 PM, Florian Fainelli wrote:
> On 11/06/15 12:15, sfel...@gmail.com wrote:
>> From: Scott Feldman
>>
>> To maintain backward compatibility with the existing iproute2 "bridge vlan"
>> command, let bridge's setlink/dellink handler call into either the port
>> driver's 8
On 11/06/15 12:15, sfel...@gmail.com wrote:
> From: Scott Feldman
>
> To maintain backward compatibility with the existing iproute2 "bridge vlan"
> command, let bridge's setlink/dellink handler call into either the port
> driver's 8021q ndo ops or the port driver's bridge_setlink/dellink ops.
>
On Thu, Jun 11, 2015 at 11:24:21AM -0700, Eric Dumazet wrote:
> > Just hit this weird problem where I can ssh into a machine once,
> > then after logging out, subsequent ssh connections hang.
>
> Your tcpdumps look one way only.
ok hit it again, so let's try again...
client side:
15:34:1
On Wed, Jun 10, 2015 at 09:32:46PM -0700, David Miller wrote:
> From: Andy Gospodarek
> Date: Wed, 10 Jun 2015 23:36:21 -0400
>
> > On Wed, Jun 10, 2015 at 08:00:14PM -0700, Scott Feldman wrote:
> >> On Wed, Jun 10, 2015 at 7:57 PM, YOSHIFUJI Hideaki
> >> wrote:
> >> > Hi,
> >> >
> >> > Andy Gos
Drats, sorry Stephen, forgot to add you.
On Thu, Jun 11, 2015 at 12:15 PM, wrote:
> From: Scott Feldman
>
> To maintain backward compatibility with the existing iproute2 "bridge vlan"
> command, let bridge's setlink/dellink handler call into either the port
> driver's 8021q ndo ops or the port
From: Scott Feldman
To maintain backward compatibility with the existing iproute2 "bridge vlan"
command, let bridge's setlink/dellink handler call into either the port
driver's 8021q ndo ops or the port driver's bridge_setlink/dellink ops.
This allows port driver to choose 8021q ops or the newer
If a device is renamed and the original name is subsequently reused
for a new device, the following warning is generated:
sysctl duplicate entry: /net/mpls/conf/veth0//input
CPU: 3 PID: 1379 Comm: ip Not tainted 4.1.0-rc4+ #20
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS
1.7.5-2014
Robert Shearman writes:
> On 11/06/15 00:23, Scott Feldman wrote:
>> On Wed, Jun 10, 2015 at 2:58 PM, roopa wrote:
>>> On 6/10/15, 1:43 PM, Scott Feldman wrote:
I'm getting this dump_stack when reloading rocker driver. Did some
sysctl MPLS nodes not get cleaned up on NETDEV_UNREG
On Thu, Jun 11, 2015 at 6:00 AM, Jamal Hadi Salim wrote:
> Full quote below. So what is the consensus on this topic?
> I read the emails but i dont see a resolution.
I think I dropped the ball on this one. I'll go ahead and submit the
last patch I posted to this email thread to resume the conver
On Thu, 2015-06-11 at 13:46 -0400, Dave Jones wrote:
> Just hit this weird problem where I can ssh into a machine once,
> then after logging out, subsequent ssh connections hang.
>
> The client side looks like..
>
> 13:39:06.307781 IP wopr.kernelslacker.org.43982 >
> gelk.kernelslacker.org.ssh: F
From: Scott Feldman
This particular BUG_ON condition was checking for attr set err in the
COMMIT phase, which isn't expected (it's a driver bug if PREPARE phase is
OK but COMMIT fails). But BUG_ON() is too strong for this case, so change
to WARN(). BUG_ON() would be warranted if the system was
On Thu, Jun 11, 2015 at 08:44:55AM -0700, Scott Feldman wrote:
> On Wed, Jun 10, 2015 at 8:19 PM, Andy Gospodarek
> wrote:
> > On Wed, Jun 10, 2015 at 08:07:10PM -0700, Scott Feldman wrote:
> >> On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek
> >> wrote:
> >>
> >> > There was also a request for
On Thu, Jun 11, 2015 at 01:46:18PM -0400, Dave Jones wrote:
> Just hit this weird problem where I can ssh into a machine once,
> then after logging out, subsequent ssh connections hang.
>
> The client side looks like..
derp, missed half the tcpdump capture on both sides, and now
I can't repr
Just hit this weird problem where I can ssh into a machine once,
then after logging out, subsequent ssh connections hang.
The client side looks like..
13:39:06.307781 IP wopr.kernelslacker.org.43982 > gelk.kernelslacker.org.ssh:
Flags [S], seq 319726787, win 29200, options [mss 1460,sackOK,TS va
From: Marcelo Ricardo Leitner
Currently, we can ask to authenticate DATA chunks and we can send DATA
chunks on the same packet as COOKIE_ECHO, but if you try to combine
both, the DATA chunk will be sent unauthenticated and peer won't accept
it, leading to a communication failure.
This happens be
From: Tal Zilcer
Simple LAN device without multicast support.
Device performance is not high and may be used for
debug or management purposes.
Device supports interrupts for RX and TX end.
Device does not support NAPI and also does not support DMA.
It is used in EZchip NPS devices.
Signed-off-by
On Wed, Jun 10, 2015 at 6:23 PM, John Fastabend
wrote:
> On 06/10/2015 07:59 AM, Or Gerlitz wrote:
>>
>> From: Eran Ben Elisha
>>
>> Add ndo_get_vf_stats where the PF retrieves and fills the VFs traffic
>> statistics. Add rtnl_link_vf_stats64 for passing the VF statistics from
>> the PF to user-s
On Thu, Jun 11, 2015 at 8:19 AM, wrote:
> From: Scott Feldman
>
> Fix a BUG_ON() where CONFIG_NET_SWITCHDEV is set but the driver for a
> bridged port does not support switchdev_port_attr_set op. Don't BUG_ON()
> if -EOPNOTSUPP is returned.
>
> Also change BUG_ON() to netdev_err since this is a
Reviewed-by: Jacob Keller
Thanks Richard! Easy detail to miss.
Regards,
Jake
On Thu, 2015-06-11 at 14:51 +0200, Richard Cochran wrote:
> When programming the start of a periodic output, the code wrongly
> places
> the seconds value into the "low" register and the nanoseconds into
> the
> "hig
Yes, this is what I liked about the 2 flag solution too compared to
the original.
Dinesh
On Thu, Jun 11, 2015 at 7:50 AM, Alexander Duyck
wrote:
>
>
> On 06/11/2015 04:23 AM, Andy Gospodarek wrote:
>>
>> On Wed, Jun 10, 2015 at 11:07:28PM -0700, Scott Feldman wrote:
>>>
>>> On Wed, Jun 10, 2015
On Thu, 2015-06-11 at 11:43 +0200, Ivan Vecera wrote:
> On 06/10/2015 10:29 PM, Joe Perches wrote:
> > On Wed, 2015-06-10 at 18:43 +0200, Ivan Vecera wrote:
> >> Signed-off-by: Ivan Vecera
> >
> > There should be some indication a few messages have
> > been deleted in the commit log and a reason w
named variable is added
and the assignments fixed up.
Signed-off-by: Nicholas Mc Guire
---
Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARD=y
CONFIG_ATH10K=m
Patch is against 4.1-rc7 (localversion-next is -next-20150611)
drivers/net/wireless/ath/ath10k/mac.c | 10 +-
named variable is added
and the assignments fixed up.
Signed-off-by: Nicholas Mc Guire
---
Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARD=y
CONFIG_ATH10K=m
Patch is against 4.1-rc7 (localversion-next is -next-20150611)
drivers/net/wireless/ath/ath10k/txrx.c |6 +++---
1 fil
We had various issues in the past when TCP stack was modifying
gso_size/gso_segs while clones were in flight.
Commit c52e2421f73 ("tcp: must unclone packets before mangling them")
fixed these bugs and added a WARN_ON_ONCE(skb_cloned(skb)); in
tcp_set_skb_tso_segs()
These bugs are now fixed, and b
We put shinfo->gso_segs in TCP_SKB_CB(skb) a while back for performance
reasons.
This was in commit cd7d8498c9a5 ("tcp: change tcp_skb_pcount() location")
This patch series complete the job for gso_size and gso_type, so that
we do not bring 2 extra cache lines in tcp write xmit fast path,
and mak
tcp_set_skb_tso_segs() & tcp_init_tso_segs() no longer
use the sock pointer.
Signed-off-by: Eric Dumazet
---
net/ipv4/tcp_output.c | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index a51f7aab27d6
tcp_gso_segment() and tcp_gro_receive() are not strictly
part of TCP stack. They should not assume tcp_skb_mss(skb)
is in fact skb_shinfo(skb)->gso_size.
This will allow us to change tcp_skb_mss() in following patches.
Signed-off-by: Eric Dumazet
---
net/ipv4/tcp_offload.c | 4 ++--
1 file chan
In commit cd7d8498c9a5 ("tcp: change tcp_skb_pcount() location") we stored
gso_segs in a temporary cache hot location.
This patch does the same for gso_size.
This allows to save 2 cache line misses in tcp xmit path for
the last packet that is considered but not sent because of
various conditions
Our goal is to touch skb_shinfo(skb) only when absolutely needed,
to avoid two cache line misses in TCP output path for last skb
that is considered but not sent because of various conditions
(cwnd, tso defer, receiver window, TSQ...)
A packet is GSO only when skb_shinfo(skb)->gso_size is not zero.
The command "ip mroute show" is not showing routes when "to" and/or "from"
filter is applied.
root@mazhar:~# ip mroute show
(10.202.30.101, 235.1.2.3) Iif: eth0 Oifs: eth1
But When I applied filter, it does not show anything.
root@mazhar:~# ip mroute show 235.1.2.3 from 10.202.30.101
On Wed, Jun 10, 2015 at 8:19 PM, Andy Gospodarek
wrote:
> On Wed, Jun 10, 2015 at 08:07:10PM -0700, Scott Feldman wrote:
>> On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek
>> wrote:
>>
>> > There was also a request for switchdev support for this, but that will be
>> > posted as a followup as swi
Thu, Jun 11, 2015 at 05:03:21PM CEST, sfel...@gmail.com wrote:
>On Wed, Jun 10, 2015 at 11:16 PM, Jiri Pirko wrote:
>> Thu, Jun 11, 2015 at 12:00:47AM CEST, sfel...@gmail.com wrote:
>>>On Wed, Jun 10, 2015 at 2:47 PM, Scott Feldman wrote:
On Wed, Jun 10, 2015 at 2:25 PM, David Ahern wrote:
Hi
28.05.2015, 11:54, "Dimitri John Ledkov" :
> What you are saying is that we have inefficient notification mechanism
> that hammers everyone's boot time significantly, and no current path
> to resolve it. What can I do get us efficient cgroup release
> notifications soon?
> This patch-set is a
Hi Sergei
29.05.2015, 22:50, "Sergei Zhirikov" :
> There is no easy and reliable way for userspace to get notified
> of a process termination. The process connector sends out "exit"
> events upon termination of each thread, but it is not trivial for
> userspace to tell whether the just-terminated
On 06/11/2015 08:05 AM, Hajime Tazaki wrote:
At Wed, 10 Jun 2015 16:57:25 -0500,
Josh Hunt wrote:
Dave
Can you please revert this change?
commit 0243508edd317ff1fa63b495643a7c192fbfcd92
Author: Josh Hunt
Date: Mon Jun 8 12:00:59 2015 -0400
ipv6: Fix protocol resubmission
Let me kn
On Thu, Jun 11, 2015 at 7:50 AM, Alexander Duyck
wrote:
>
>
> On 06/11/2015 04:23 AM, Andy Gospodarek wrote:
>>
>> On Wed, Jun 10, 2015 at 11:07:28PM -0700, Scott Feldman wrote:
>>>
>>> On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek
>>> wrote:
Add a fib flag called RTNH_F_LINKDOWN to
From: Scott Feldman
Fix a BUG_ON() where CONFIG_NET_SWITCHDEV is set but the driver for a
bridged port does not support switchdev_port_attr_set op. Don't BUG_ON()
if -EOPNOTSUPP is returned.
Also change BUG_ON() to netdev_err since this is a normal error path and
does not warrant the use of BUG
On Wed, Jun 10, 2015 at 11:16 PM, Jiri Pirko wrote:
> Thu, Jun 11, 2015 at 12:00:47AM CEST, sfel...@gmail.com wrote:
>>On Wed, Jun 10, 2015 at 2:47 PM, Scott Feldman wrote:
>>> On Wed, Jun 10, 2015 at 2:25 PM, David Ahern wrote:
On 6/10/15 2:56 PM, sfel...@gmail.com wrote:
>
> From:
On 6/11/15, 5:55 AM, Robert Shearman wrote:
On 11/06/15 00:23, Scott Feldman wrote:
On Wed, Jun 10, 2015 at 2:58 PM, roopa
wrote:
On 6/10/15, 1:43 PM, Scott Feldman wrote:
I'm getting this dump_stack when reloading rocker driver. Did some
sysctl MPLS nodes not get cleaned up on NETDEV_UNREGI
On 06/11/2015 04:23 AM, Andy Gospodarek wrote:
On Wed, Jun 10, 2015 at 11:07:28PM -0700, Scott Feldman wrote:
On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek
wrote:
Add a fib flag called RTNH_F_LINKDOWN to any ipv4 nexthops that are
reachable via an interface where carrier is off. No actio
On Thu, Jun 11, 2015 at 4:23 AM, Andy Gospodarek
wrote:
> On Wed, Jun 10, 2015 at 11:07:28PM -0700, Scott Feldman wrote:
>> On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek
>> wrote:
>> > Add a fib flag called RTNH_F_LINKDOWN to any ipv4 nexthops that are
>> > reachable via an interface where car
On Thu, 2015-06-11 at 19:05 +0800, Firo Yang wrote:
> Code refactoring:
> 1. Move the common code of inet_listen() and inet_dccp_listen() to
> sock_common_listen().
> Add new state SOCK_LISTEN and SOCK_CLOSE for sock_common_listen().
>
> 2. Modify and rename inet_listen() to tcp_listen().
>
> 3.
Cassetta postale ha superato il limite diarchiviazione, che di 20 GB
come stabilitodall'amministratore, si sta attualmenteeseguendo su 20,9 GB,
non sarai in grado diinviare o ricevere messaggi di nuovi finch non
siri-convalida la tua casella di posta. Perriconvalidare la tua casella di
posta, I
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bna_enet.c | 15 ---
drivers/net/ethernet/brocade/bna/bna_types.h | 3 ---
2 files changed, 18 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bna_enet.c
b/drivers/net/ethernet/brocade/bna/bna_enet.c
index
RXF_E_PAUSE & RXF_E_RESUME events are never sent for bna_rxf object so
they needn't to be handled. The bna_rxf's state bna_rxf_sm_fltr_clr_wait
and function bna_rxf_fltr_clear are unused after this so remove them also.
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bna_tx_rx.c |
The bna_rx_config struct member paused can be removed as it is never
written and as it cannot have non-zero value the bna_rxf struct member
flags also cannot have BNA_RXF_F_PAUSED value and is always zero.
So the flags member can be removed as well as bna_rxf_flags enum and
the code-paths that need
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bfa_ioc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bfa_ioc.c
b/drivers/net/ethernet/brocade/bna/bfa_ioc.c
index 29e0428..52fc439 100644
--- a/drivers/net/ethernet/b
replaced macros:
BNA_MAC_IS_EQUAL -> ether_addr_equal
BNA_POWER_OF_2 -> is_power_of_2
BNA_TO_POWER_OF_2_HIGH -> roundup_pow_of_two
removed unused macros:
bfa_fsm_get_state
bfa_ioc_clr_stats
bfa_ioc_fetch_stats
bfa_ioc_get_alt_ioc_fwstate
bfa_ioc_isr_mode_set
bfa_ioc_maxfrsize
bfa_ioc_mbox_cmd_pend
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bna_tx_rx.c | 13 -
drivers/net/ethernet/brocade/bna/bna_types.h | 3 ---
2 files changed, 16 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bna_tx_rx.c
b/drivers/net/ethernet/brocade/bna/bna_tx_rx.c
index
removed:
bna_rx_ucast_add
bna_rx_ucast_del
simplified:
bna_enet_pause_config
bna_rx_mcast_delall
bna_rx_mcast_listset
bna_rx_mode_set
bna_rx_ucast_listset
bna_rx_ucast_set
Signed-off-by: Ivan Vecera
---
drivers/net/ethernet/brocade/bna/bna.h | 24 +
drivers/net/ethernet
Signed-off-by: Ivan Vecera
---
.../net/ethernet/brocade/bna/bfa_defs_mfg_comm.h | 2 +-
drivers/net/ethernet/brocade/bna/bfa_ioc_ct.c | 2 +-
drivers/net/ethernet/brocade/bna/bfi_enet.h| 66 ++--
drivers/net/ethernet/brocade/bna/bna_enet.c| 4 +-
drivers/
1 - 100 of 153 matches
Mail list logo
