From: Eric Dumazet
Date: Sat, 06 Jun 2015 21:17:57 -0700
> From: Eric Dumazet
>
> When an application needs to force a source IP on an active TCP socket
> it has to use bind(IP, port=x).
>
> As most applications do not want to deal with already used ports, x is
> often set to 0, meaning the ke
On Sun, 7 Jun 2015, Firo Yang wrote:
> On Sat, Jun 06, 2015 at 05:05:04AM -0700, Eric Dumazet wrote:
> >On Sat, 2015-06-06 at 19:35 +0800, Firo Yang wrote:
> >> A smatch warning.
> >> When kmem_cache_alloc() failed to alloc memory, a null pointer
> >> will be returned. Redeference null pointer w
On Sat, Jun 06, 2015 at 05:05:04AM -0700, Eric Dumazet wrote:
>On Sat, 2015-06-06 at 19:35 +0800, Firo Yang wrote:
>> A smatch warning.
>> When kmem_cache_alloc() failed to alloc memory, a null pointer
>> will be returned. Redeference null pointer will generate
>
>
>Dereferencing a null pointer wil
On Sat, Jun 06, 2015 at 03:39:38PM +0200, walter harms wrote:
>
>
>Am 06.06.2015 13:35, schrieb Firo Yang:
>> A smatch warning.
>> When kmem_cache_alloc() failed to alloc memory, a null pointer
>> will be returned. Redeference null pointer will generate
>> an unnecessary oops. So, use it after chec
On Sat, Jun 06, 2015 at 08:16:50PM -0700, Alexander Duyck wrote:
>On 06/06/2015 05:05 AM, Eric Dumazet wrote:
>>On Sat, 2015-06-06 at 19:35 +0800, Firo Yang wrote:
>>>A smatch warning.
>>>When kmem_cache_alloc() failed to alloc memory, a null pointer
>>>will be returned. Redeference null pointer wi
From: Eric Dumazet
When an application needs to force a source IP on an active TCP socket
it has to use bind(IP, port=x).
As most applications do not want to deal with already used ports, x is
often set to 0, meaning the kernel is in charge to find an available
port.
But kernel does not know yet
On 06/06/2015 05:05 AM, Eric Dumazet wrote:
On Sat, 2015-06-06 at 19:35 +0800, Firo Yang wrote:
A smatch warning.
When kmem_cache_alloc() failed to alloc memory, a null pointer
will be returned. Redeference null pointer will generate
Dereferencing a null pointer will crash.
an unnecessary o
On Sat, 2015-06-06 at 22:30 -0400, Neal Cardwell wrote:
> I like this a lot. This addresses a very serious gap in the sockets
> API, and should be very useful. The comment mentions that this is
> available for IPv6. From skimming the change I would have expected
> inet6_bind() would need a change
On Sat, Jun 6, 2015 at 11:53 AM, Eric Dumazet wrote:
> From: Eric Dumazet
...
> This patch adds a new SOL_IP socket option, asking kernel to ignore
> the 0 port provided by application in bind(IP, port=0) and only
> remember the given IP address.
...
> This new feature is available for both IPv4
--
MONEY GRAM SENT THE SUM OF $2900 TO YOU.REF #:9257-8487 kindly contact MR.PAUL
HOWARD FOR MORE DETAILS.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.htm
Dan Carpenter reported missing brackets which resulted in reading a
wrong crystalfreq value. I also noticed that the result of this
function is ignored.
Reported-By: Dan Carpenter
Signed-off-by: Hauke Mehrtens
---
drivers/ssb/driver_chipcommon_pmu.c | 6 +++---
1 file changed, 3 insertions(+),
I am experiencing a similar issue on another system (at91sam9n12) that
uses Redpine Signal Wireless Driver 1.1.0. I do not know the root
cause yet, but it may be related to the Redpine Signals driver. Will
update this mailing list if the problem is with the redpine driver.
thanks
On Thu, May 28
When the driver gets unregistered a call to netif_napi_del() was
missing.
Signed-off-by: Hauke Mehrtens
---
drivers/net/ethernet/broadcom/b44.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/broadcom/b44.c
b/drivers/net/ethernet/broadcom/b44.c
index 77363d6..ebb9910 10
rhashtable uses EXPORT_SYMBOL_GPL() without importing linux/export.h
directly it is only imported indirectly through some other includes.
Signed-off-by: Hauke Mehrtens
---
lib/rhashtable.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/rhashtable.c b/lib/rhashtable.c
index b28df40..1b70
Please do not top-post.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, 2015-06-06 at 18:38 +0200, Maciej Żenczykowski wrote:
> Hmm, I certainly like this.
>
> So IMHO this is indeed much better than a sysctl to select a magic
> port to ignore during a bind call (previous internal patchset),
> although it does use up one more bit per socket (and one more sysca
On Fri, Jun 5, 2015 at 1:23 PM, Kenneth Klette Jonassen
wrote:
>> nice patch. I would like to review it more thoroughly but I have some
>> quick comments.
>>
>> given that cdg didn't include hystart. it'd be nice to have a module knob to
>> enable and disable hystart for experiments.
>
> We could
Hmm, I certainly like this.
So IMHO this is indeed much better than a sysctl to select a magic
port to ignore during a bind call (previous internal patchset),
although it does use up one more bit per socket (and one more syscall
per connect).
---
Thinking about this some more, I think it might b
From: Eric Dumazet
When an application needs to force a source IP on an active TCP socket
it has to use bind(IP, port=x).
As most applications do not want to deal with already used ports, x is
often set to 0, meaning the kernel is in charge to find an available
port.
But kernel does not know yet
br_fdb_update() can be called in process context in the following way:
br_fdb_add() -> __br_fdb_add() -> br_fdb_update() (if NTF_USE flag is set)
so we need to disable softirqs because there are softirq users of the
hash_lock. One easy way to reproduce this is to modify the bridge utility
to set NT
Am 06.06.2015 13:35, schrieb Firo Yang:
> A smatch warning.
> When kmem_cache_alloc() failed to alloc memory, a null pointer
> will be returned. Redeference null pointer will generate
> an unnecessary oops. So, use it after check.
>
> Signed-off-by: Firo Yang
> ---
> net/ipv4/fib_trie.c | 3 ++
On Sat, Jun 6, 2015 at 12:24 AM, Jarod Wilson wrote:
> Its possible for users to specify their own MAC address for a bonded link,
> and this used to work, until sometime in 2013...
>
> First, commit 409cc1f8a changed a condition to set the bond's mac to a
> slave device's, dropping the is_zero_eth
On Fri, Jun 05, 2015 at 05:56:33PM -0400, Andrej Manduch wrote:
> Hi Neil,
>
> I would like to kindly ask you to always put full patch in reply when
> you are replying to Nicks patch. Because he's banned from vger and only
> people on cc are able to see his patches and this is only way for rest
On Sat, 2015-06-06 at 19:35 +0800, Firo Yang wrote:
> A smatch warning.
> When kmem_cache_alloc() failed to alloc memory, a null pointer
> will be returned. Redeference null pointer will generate
Dereferencing a null pointer will crash.
> an unnecessary oops. So, use it after check.
>
> Signed-
A smatch warning.
When kmem_cache_alloc() failed to alloc memory, a null pointer
will be returned. Redeference null pointer will generate
an unnecessary oops. So, use it after check.
Signed-off-by: Firo Yang
---
net/ipv4/fib_trie.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --
Fix:
drivers/net/wan/dscc4.c: In function 'dscc4_open':
drivers/net/wan/dscc4.c:1049:25: warning: variable 'ppriv' set but not used
[-Wunused-but-set-variable]
This has been in there unused since 1da177e4c3f (Linux-2.6.12-rc2) simply
remove it.
Signed-off-by: Nicholas Mc Guire
---
Was not able
API compliance scanning with coccinelle flagged:
./drivers/net/wan/dscc4.c:1036:1-33:
WARNING: timeout (10) seems HZ dependent
./drivers/net/wan/dscc4.c:554:2-34:
WARNING: timeout (10) seems HZ dependent
./drivers/net/wan/dscc4.c:599:2-34:
WARNING: timeout (10) seems HZ depe
Hi Vaishali,
On Sat, Jun 06, 2015 at 09:52:34AM +0530, Vaishali Thakkar wrote:
> Use mod_timer instead of del_timer followed by add_timer to update
> the expire field of the active timer.
>
> The semantic patch that performs this transformation is as follows:
>
> @change@
> expression e1, e2, e
API compliance scanning with coccinelle flagged:
./drivers/net/wan/cosa.c:520:2-18: WARNING:
timeout (30) seems HZ dependent
Numeric constants passed to schedule_timeout() make the effective
timeout HZ dependent which makes little sense in a device probe.
Fixed up by converting the consta
29 matches
Mail list logo
