Use mod_timer instead of del_timer followed by add_timer to update
the expire field of the active timer.
The semantic patch that performs this transformation is as follows:
@change@
expression e1, e2, e3, e4;
@@
- del_timer(&e1);
... when != e1 = e3
- e1.expires = e2;
... when != e1 = e4
- add_t
From: Hariprasad Shenai
Date: Fri, 5 Jun 2015 14:36:33 +0530
> The patch e85c9a7abfa4: ("cxgb4/cxgb4vf: Add code to calculate T5 BAR2
> Offsets for SGE Queue Registers") from Dec 3, 2014, leads to the
> following static checker warning:
>
> drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:535
From: Hariprasad Shenai
Date: Fri, 5 Jun 2015 14:24:46 +0530
> This patch series adds the following.
> Free VI interface during remove, flush SGE ec routine, rename
> t4_link_start to t4_link_l1cfg since it only does l1 configuration, set
> mac addr from when we can't contact firmware for debug
From: Jeff Kirsher
Date: Thu, 4 Jun 2015 20:27:01 -0700
> This series contains updates to i40e and i40evf.
>
> Anjali provides three fixes, first to resolve a Tx queue hang if mixed
> size frags are passed to the driver while using TSO. There was a corner
> case where we needed to linearize bu
On 6/5/15, 8:26 AM, Robert Shearman wrote:
It isn't clear to me what the strategy here is for dealing with tunnel
encaps that aren't bound to an interface.
Thomas, I presume you would prefer not to force the user to keep track
of changes to the output interface and nexthop corresponding to t
In big endian cases, macro cpu_to_le16 unfolds to __swab16 which
provides special case for constants. In little endian cases,
__constant_cpu_to_le16 and cpu_to_le16 expand directly to the
same expression. So, replace __constant_cpu_to_le16 with
cpu_to_le16 with the goal of getting rid of the defini
On Fri, 2015-06-05 at 17:46 -0700, Martin KaFai Lau wrote:
> The problem is caught by this WARN_ON(len > skb->len) in tcp_fragment():
>
> [] warn_slowpath_null+0x1a/0x20
> [] tcp_fragment+0x2a0/0x2b0
> [] tcp_mark_head_lost+0x196/0x230
> [] tcp_update_scoreboard+0x4d/0x80
> [] tcp_fastretrans_aler
The problem is caught by this WARN_ON(len > skb->len) in tcp_fragment():
[] warn_slowpath_null+0x1a/0x20
[] tcp_fragment+0x2a0/0x2b0
[] tcp_mark_head_lost+0x196/0x230
[] tcp_update_scoreboard+0x4d/0x80
[] tcp_fastretrans_alert+0x6ac/0xa90
[] tcp_ack+0x9d4/0x10e0
[] tcp_rcv_established+0x309/0x7e0
On Fri, 2015-06-05 at 16:02 -0700, Martin KaFai Lau wrote:
> On Fri, Jun 05, 2015 at 02:23:55PM -0700, Eric Dumazet wrote:
> > On Fri, 2015-06-05 at 11:02 -0700, Martin KaFai Lau wrote:
> >
> > > tcp_trim_head() does not take the mss_now.
> > > Is it fine to have mss_now <= tcp_skb_mss(skb)? or we
On Fri, Jun 05, 2015 at 02:23:55PM -0700, Eric Dumazet wrote:
> On Fri, 2015-06-05 at 11:02 -0700, Martin KaFai Lau wrote:
>
> > tcp_trim_head() does not take the mss_now.
> > Is it fine to have mss_now <= tcp_skb_mss(skb)? or we can depend on
> > the tcp_init_tso_segs() in the tcp_write_xmit() to
There are some defines for a few pad skew related extended registers.
Specify for which MMD Address (dev_addr) they are for.
Signed-off-by: Jaeden Amero
---
drivers/net/phy/micrel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 59cc
In v2, we add an additional cleanup commit to make an array of strings
static const and to improve const correctness generally. We also no longer
unnecessarily initialize the result variable in
ksz9031_center_flp_timing().
In v3, we remove the unnecessary result variable from ksz9031_config_init()
In a few places in this driver, we weren't using const where we could
have. Use const more.
In addition, change the arrays of strings in ksz9031_config_init() to be
not only const, but also static.
Signed-off-by: Jaeden Amero
---
drivers/net/phy/micrel.c | 29 +++--
1 fi
Link failures have been observed when using the KSZ9031 with HP 1810-8G
and HP 1910-8G network switches. Center the FLP timing at 16ms to help
avoid intermittent link failures.
>From the KSZ9031RNX and KSZ9031MNX data sheets revision 2.2, section
"Auto-Negotiation Timing":
The KSZ9031[RNX
On 06/05/2015 05:43 PM, Florian Fainelli wrote:
> On 05/06/15 15:40, Jaeden Amero wrote:
>> Link failures have been observed when using the KSZ9031 with HP 1810-8G
>> and HP 1910-8G network switches. Center the FLP timing at 16ms to help
>> avoid intermittent link failures.
>>
>> From the KSZ9031RN
On 05/06/15 15:40, Jaeden Amero wrote:
> In v2, we add an additional cleanup commit to make an array of strings
> static const and to improve const correctness generally. We also no longer
> unnecessarily initialize the result variable in
> ksz9031_center_flp_timing().
>
> In v3, we remove the unn
On 05/06/15 15:40, Jaeden Amero wrote:
> Link failures have been observed when using the KSZ9031 with HP 1810-8G
> and HP 1910-8G network switches. Center the FLP timing at 16ms to help
> avoid intermittent link failures.
>
> From the KSZ9031RNX and KSZ9031MNX data sheets revision 2.2, section
> "
In a few places in this driver, we weren't using const where we could
have. Use const more.
In addition, change the arrays of strings in ksz9031_config_init() to be
not only const, but also static.
Signed-off-by: Jaeden Amero
---
drivers/net/phy/micrel.c | 29 +++--
1 fi
In v2, we add an additional cleanup commit to make an array of strings
static const and to improve const correctness generally. We also no longer
unnecessarily initialize the result variable in
ksz9031_center_flp_timing().
In v3, we remove the unnecessary result variable from ksz9031_config_init()
Link failures have been observed when using the KSZ9031 with HP 1810-8G
and HP 1910-8G network switches. Center the FLP timing at 16ms to help
avoid intermittent link failures.
>From the KSZ9031RNX and KSZ9031MNX data sheets revision 2.2, section
"Auto-Negotiation Timing":
The KSZ9031[RNX
There are some defines for a few pad skew related extended registers.
Specify for which MMD Address (dev_addr) they are for.
Signed-off-by: Jaeden Amero
---
drivers/net/phy/micrel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 59cc
On 06/05/2015 04:09 PM, Sergei Shtylyov wrote:
>> @@ -441,6 +461,7 @@ static int ksz9031_config_init(struct phy_device
>> *phydev)
>> "txd2-skew-ps", "txd3-skew-ps"
>> };
>> static const char *control_skews[2] = {"txen-skew-ps",
>> "rxdv-skew-ps"};
>> +int result;
>
>
Its possible for users to specify their own MAC address for a bonded link,
and this used to work, until sometime in 2013...
First, commit 409cc1f8a changed a condition to set the bond's mac to a
slave device's, dropping the is_zero_ether_addr() check in favor of using
bond->dev_addr_from_first.
N
On 06/04/2015 08:57 PM, Herbert Xu wrote:
> Existing AEAD implementations should be completely unaware of
> the new interface because we recreate the old req->assoc in the
> crypto API.
Yes, assuming that one is using req->assoclen not only req->assoc ;)
>
> However, if you are creating a new AE
> On Jun 3, 2015, at 11:46 AM, Mark D Rustad wrote:
>
> Many multi-function devices provide shared registers in extended
> config space for accessing VPD. The behavior of these registers
> means that the state must be tracked and access locked correctly
> for accesses not to hang or worse. One wa
Hi Neil,
I would like to kindly ask you to always put full patch in reply when
you are replying to Nicks patch. Because he's banned from vger and only
people on cc are able to see his patches and this is only way for rest
of us to see what is in his patch.
Thanks.
On 06/05/2015 03:16 PM, Nei
On Fri, 2015-06-05 at 11:02 -0700, Martin KaFai Lau wrote:
> tcp_trim_head() does not take the mss_now.
> Is it fine to have mss_now <= tcp_skb_mss(skb)? or we can depend on
> the tcp_init_tso_segs() in the tcp_write_xmit() to take care of it?
It should be fine : packets not yet sent have tcp_skb
Hello.
On 06/05/2015 10:55 PM, Jaeden Amero wrote:
Link failures have been observed when using the KSZ9031 with HP 1810-8G
and HP 1910-8G network switches. Center the FLP timing at 16ms to help
avoid intermittent link failures.
From the KSZ9031RNX and KSZ9031MNX data sheets revision 2.2, se
Since the Tx timer function runs in softirq context the driver needs
to call disable_irq_nosync instead of a disable_irq.
Reported-by: Josh Stone
Signed-off-by: Tom Lendacky
---
drivers/net/ethernet/amd/xgbe/xgbe-drv.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
On Fri, May 29, 2015 at 01:15:03AM +0200, Daniel Borkmann wrote:
> On 05/29/2015 01:12 AM, Stephen Hemminger wrote:
> ...
> >I will go back and recreate what is missing.
> >Sorry for the confusion.
>
> Great thanks, no problem.
ping. Daniel's tc-bpf man page is still missing in iproute2 net-next.
> nice patch. I would like to review it more thoroughly but I have some
> quick comments.
>
> given that cdg didn't include hystart. it'd be nice to have a module knob to
> enable and disable hystart for experiments.
We could include a knob to disable PRR for delay backoffs as well.
Neither are/we
Link failures have been observed when using the KSZ9031 with HP 1810-8G
and HP 1910-8G network switches. Center the FLP timing at 16ms to help
avoid intermittent link failures.
>From the KSZ9031RNX and KSZ9031MNX data sheets revision 2.2, section
"Auto-Negotiation Timing":
The KSZ9031[RNX
There are some defines for a few pad skew related extended registers.
Specify for which MMD Address (dev_addr) they are for.
Signed-off-by: Jaeden Amero
---
drivers/net/phy/micrel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 59cc
In a few places in this driver, we weren't using const where we could
have. Use const more.
In addition, change the arrays of strings in ksz9031_config_init() to be
not only const, but also static.
Signed-off-by: Jaeden Amero
---
drivers/net/phy/micrel.c | 29 +++--
1 fi
In v2, we add an additional cleanup commit to make an array of strings
static const and to improve const correctness generally. We also no longer
unnecessarily initialize the result variable in
ksz9031_center_flp_timing().
Jaeden Amero (3):
net/phy: micrel: Be more const correct
net/phy: micre
Please disregard this patch set. I'll post a second version.
Cheers,
Jaeden
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jun 05, 2015 at 01:41:02PM -0400, Nicholas Krause wrote:
> This makes the function sctp_assoc_lookup_laddr bool due to it
> only returning either one or zero as its return value. Further
> more this function can we simplified to return the if statement
> as part of this function directly an
Robert Shearman writes:
> The mpls device is used in an RCU read context without a lock being
> held. As the memory is freed without waiting for the RCU grace period
> to elapse, the freed memory could still be in use.
>
> Address this by using kfree_rcu to free the memory for the mpls device
> a
On Wed, Jun 03, 2015 at 02:01:24PM -0700, Alexander Duyck wrote:
> On 06/03/2015 01:02 PM, Andy Gospodarek wrote:
[...]
> >
> >>>@@ -621,7 +623,7 @@ static int fib_check_nh(struct fib_config *cfg, struct
> >>>fib_info *fi,
> >>> /* It is not necessary, but requires a bit of think
From: Colin Ian King
The debug is printing the struct smt_header * address using
the %x format specifier. Fix it to use %p instead.
Signed-off-by: Colin Ian King
---
drivers/net/fddi/skfp/srf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/fddi/skfp/srf.c b/dr
On Fri, Jun 05, 2015 at 09:53:51AM -0700, Eric Dumazet wrote:
> Sounds good, although I would simply get rid of all this complexity in
> this very unlikely path.
>
> Would you instead try the following ?
>
> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
> index
> eeb59befaf06867b00e
Link failures have been observed when using the KSZ9031 with HP 1810-8G
and HP 1910-8G network switches. Center the FLP timing at 16ms to help
avoid intermittent link failures.
>From the KSZ9031RNX and KSZ9031MNX data sheets revision 2.2, section
"Auto-Negotiation Timing":
The KSZ9031[RNX
There are some defines for a few pad skew related extended registers.
Specify for which MMD Address (dev_addr) they are for.
Signed-off-by: Jaeden Amero
---
drivers/net/phy/micrel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index ebdc
The mpls device is used in an RCU read context without a lock being
held. As the memory is freed without waiting for the RCU grace period
to elapse, the freed memory could still be in use.
Address this by using kfree_rcu to free the memory for the mpls device
after the RCU grace period has elapsed
The memory pointed to by idev->stats.icmpv6msgdev,
idev->stats.icmpv6dev and idev->stats.ipv6 can each be used in an RCU
read context without taking a reference on idev. For example, through
IP6_*_STATS_* calls in ip6_rcv. These memory blocks are freed without
waiting for an RCU grace period to ela
On Thu, Jun 04, 2015 at 06:35:03AM -0400, Neil Horman wrote:
> On Wed, Jun 03, 2015 at 08:51:07AM -0400, Nicholas Krause wrote:
> > This makes the function sctp_assoc_lookup_laddr bool due to this
> > function only returning either one or zero as its return value.
> >
> > Signed-off-by: Nicholas K
From: Marcelo Ricardo Leitner
That's needed for the next patch, so we break the lock inversion between
netns_sctp->addr_wq_lock and socket lock on
sctp_addr_wq_timeout_handler(). With this, we can traverse addr_waitq
without taking addr_wq_lock, taking it just for the write operations.
Signed-of
use time_is_before_eq_jiffies macro for time comparison
Signed-off-by: Antonio Murdaca
---
drivers/net/ethernet/micrel/ksz884x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/micrel/ksz884x.c
b/drivers/net/ethernet/micrel/ksz884x.c
index 48d2aec..75dc4
I'll use that then and resubmit this patch
Thanks
2015-06-05 17:45 GMT+02:00 Julia Lawall :
> On Fri, 5 Jun 2015, Antonio Murdaca wrote:
>
>> use time_after_eq macro for time comparison
>>
>> Signed-off-by: Antonio Murdaca
>> ---
>> drivers/net/ethernet/micrel/ksz884x.c | 2 +-
>> 1 file change
On Fri, Jun 5, 2015 at 9:16 AM, Martin KaFai Lau wrote:
> The problem is caught by this WARN_ON(len > skb->len) in tcp_fragment():
>
> [] warn_slowpath_null+0x1a/0x20
> [] tcp_fragment+0x2a0/0x2b0
> [] tcp_mark_head_lost+0x196/0x230
> [] tcp_update_scoreboard+0x4d/0x80
> [] tcp_fastretrans_alert+0
The problem is caught by this WARN_ON(len > skb->len) in tcp_fragment():
[] warn_slowpath_null+0x1a/0x20
[] tcp_fragment+0x2a0/0x2b0
[] tcp_mark_head_lost+0x196/0x230
[] tcp_update_scoreboard+0x4d/0x80
[] tcp_fastretrans_alert+0x6ac/0xa90
[] tcp_ack+0x9d4/0x10e0
[] tcp_rcv_established+0x309/0x7e0
On Fri, 2015-06-05 at 13:34 +0100, Julien Grall wrote:
> On 04/06/15 17:25, Joe Perches wrote:
> > On Thu, 2015-06-04 at 13:52 +0100, Julien Grall wrote:
> >> On 04/06/15 13:46, David Vrabel wrote:
> >>> On 04/06/15 13:45, Julien Grall wrote:
> On 03/06/15 18:06, Joe Perches wrote:
> > On
On Fri, 5 Jun 2015, Antonio Murdaca wrote:
> use time_after_eq macro for time comparison
>
> Signed-off-by: Antonio Murdaca
> ---
> drivers/net/ethernet/micrel/ksz884x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/micrel/ksz884x.c
> b/drivers/ne
On 05/06/15 15:16, roopa wrote:
On 6/5/15, 2:14 AM, Thomas Graf wrote:
On 06/03/15 at 07:21am, Roopa Prabhu wrote:
From: Roopa Prabhu
This is still WIP and incomplete.
Posting it here because of the other discussions
happening around mpls ler in the context of Roberts
code and I happened to m
use time_after_eq macro for time comparison
Signed-off-by: Antonio Murdaca
---
drivers/net/ethernet/micrel/ksz884x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/micrel/ksz884x.c
b/drivers/net/ethernet/micrel/ksz884x.c
index 48d2aec..9bce30c 100644
--
use time_after_eq macro for time comparison
Signed-off-by: Antonio Murdaca
---
drivers/net/ethernet/micrel/ksz884x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/micrel/ksz884x.c
b/drivers/net/ethernet/micrel/ksz884x.c
index 48d2aec..9bce30c 100644
--
use time_after_eq macro for time comparison
Signed-off-by: Antonio Murdaca
---
drivers/net/ethernet/micrel/ksz884x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/micrel/ksz884x.c
b/drivers/net/ethernet/micrel/ksz884x.c
index 48d2aec..9bce30c 100644
--
On 05/06/15 10:14, Thomas Graf wrote:
As I mentioned to Robert, the new RTA_ENCAP should be a list of
Netlink attributes from the beginning to make it extendible without
ever breaking user ABI.
Just to be clear in both of our approaches, the contents of the
RTA_ENCAP data is interpreted by the
On 6/5/15, 2:14 AM, Thomas Graf wrote:
On 06/03/15 at 07:21am, Roopa Prabhu wrote:
From: Roopa Prabhu
This is still WIP and incomplete.
Posting it here because of the other discussions
happening around mpls ler in the context of Roberts
code and I happened to mention this implementation.
This
On Thu, Jun 04, 2015 at 10:27:10AM -0400, Neil Horman wrote:
> On Wed, Jun 03, 2015 at 01:54:01PM -0300, mleit...@redhat.com wrote:
> > From: Marcelo Ricardo Leitner
> >
> > That's needed for the next patch, so we break the lock inversion between
> > netns_sctp->addr_wq_lock and socket lock on
>
moxart_mac_start_xmit() doesn't care where tx_tail is, tx_head can
catch and pass tx_tail, which is bad because moxart_tx_finished()
isn't guaranteed to catch up on freeing resources from tx_tail.
Add a check in moxart_mac_start_xmit(), exit to make sure tx_head
never passes tx_tail.
Move tx_head
On 04/06/15 17:25, Joe Perches wrote:
> On Thu, 2015-06-04 at 13:52 +0100, Julien Grall wrote:
>> On 04/06/15 13:46, David Vrabel wrote:
>>> On 04/06/15 13:45, Julien Grall wrote:
On 03/06/15 18:06, Joe Perches wrote:
> On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote:
>> rx->stat
since commit d6b915e29f4adea9
("ip_fragment: don't forward defragmented DF packet") the largest
fragment size is available in the IPCB.
Therefore we no longer need to care about 'encapsulation'
overhead of stripped PPPOE/VLAN headers since ip_do_fragment
doesn't use device mtu in such cases.
Sign
There are several places in the driver (all in control paths) where
coherent dma memory is being allocated using either dma_alloc_coherent()
or the deprecated pci_alloc_consistent(). All these calls should be
changed to use dma_zalloc_coherent() to avoid uninitialized fields in
data structures back
On 06/04/15 13:11, Alexei Starovoitov wrote:
eBPF programs attached to ingress and egress qdiscs see inconsistent skb->data.
For ingress L2 header is already pulled, whereas for egress it's present.
This is known to program writers which are currently forced to use
BPF_LL_OFF workaround.
Since pr
From: Fugang Duan
The current driver adjust freq formula is:
fe * diff = ppb * pc
Note:
fe: ENET ref clock frequency in Hz
diff = inc_corr - inc: difference between default increment and correction
increment
ppb: parts per billion adjustment from base
pc: correction period (in number of
On 06/03/15 at 07:21am, Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> This is still WIP and incomplete.
> Posting it here because of the other discussions
> happening around mpls ler in the context of Roberts
> code and I happened to mention this implementation.
>
> This was in response to earlie
Remove sparse warnings:
drivers/net/ethernet/xilinx/ll_temac_main.c:65:16: warning: cast removes
address space of expression
drivers/net/ethernet/xilinx/ll_temac_main.c:70:9: warning: cast removes
address space of expression
drivers/net/ethernet/xilinx/ll_temac_main.c:127:16: warning: cast
removes
On 06/04/2015 05:49 PM, Alexei Starovoitov wrote:
> On 6/4/15 3:56 AM, Markos Chandras wrote:
>> Here are some fixes for MIPS/BPF. The first 5 patches do some cleanup
>> and lay the groundwork for the final one which introduces assembly
>> helpers
>> for MIPS and MIPS64. The goal is to speed up cer
On 06/04/2015 07:40 PM, David Miller wrote:
>
> I think your Subject meant to say "fixes for 4.2" right?
>
> Because we're currently finishing up 4.1.x and the next merge
> window will be for 4.2.x
>
Hi David,
Ralf only accepts patches for MIPS 4.2 that have been posted before
4.1-rc5. This is
From: Wilson Kok
br_fdb_update() can be called in process context in the following way:
br_fdb_add() -> __br_fdb_add() -> br_fdb_update() (if NTF_USE flag is set)
so we need to use spin_lock_bh because there are softirq users of the
hash_lock. One easy way to reproduce this is to modify the bridg
71 matches
Mail list logo
