Re: netlink: Disable insertions/removals during rehash

2015-06-04 Thread Guenter Roeck
On 06/04/2015 08:52 PM, Herbert Xu wrote: On Thu, Jun 04, 2015 at 09:27:27AM -0700, Guenter Roeck wrote: sorry for bothering you - I don't see this patch in any of your trees, and it is marked as "changes requested" in patchwork. Did I look at the wrong places, do you still plan to apply the pa

Re: [v2 PATCH 5/13] crypto: testmgr - Switch to new AEAD interface

2015-06-04 Thread Herbert Xu
On Thu, Jun 04, 2015 at 03:15:19PM -0700, Tadeusz Struk wrote: > Hi Herbert, > On 05/22/2015 01:30 AM, Herbert Xu wrote: > > This patch makes use of the new AEAD interface which uses a single > > SG list instead of separate lists for the AD and plain text. > > The fact the src and assoc point to t

Re: netlink: Disable insertions/removals during rehash

2015-06-04 Thread Herbert Xu
On Thu, Jun 04, 2015 at 09:27:27AM -0700, Guenter Roeck wrote: > > sorry for bothering you - I don't see this patch in any of your trees, > and it is marked as "changes requested" in patchwork. Did I look > at the wrong places, do you still plan to apply the patch as-is, > or do you expect some cha

[PATCH net-next] cxgb4: Fix static checker warning

2015-06-04 Thread Hariprasad Shenai
The patch e85c9a7abfa4: ("cxgb4/cxgb4vf: Add code to calculate T5 BAR2 Offsets for SGE Queue Registers") from Dec 3, 2014, leads to the following static checker warning: drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:5358 t4_bar2_sge_qregs() warn: should '(qid >> qpp_shift) <<

[PATCH net-next 4/6] cxgb4: Set mac addr from vpd, when we can't contact firmware

2015-06-04 Thread Hariprasad Shenai
Grab the Adapter MAC Address out of the VPD and use it for the "debug" network interface when either we can't contact the firmware Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 32 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 21 +++

[PATCH net-next 2/6] cxgb4: Add sge ec context flush service

2015-06-04 Thread Hariprasad Shenai
Add function to flush the sge ec context cache, and utilize this new function in the driver Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 5 + drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 2

[PATCH net-next 1/6] cxgb4: Free Virtual Interfaces in remove routine

2015-06-04 Thread Hariprasad Shenai
Free VI interfaces in remove routine. If we don't do this then the firmware will never drop the physical link to the peer. Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 3 +++ drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 5 + drivers/net/ethern

[PATCH net-next 5/6] cxgb4: program pci completion timeout

2015-06-04 Thread Hariprasad Shenai
Set pci completion timeout to 0xd. Signed-off-by: Hariprasad Shenai --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c index da65e76..efd0

[PATCH net-next 6/6] cxgb4: Use FW LDST cmd to access TP_PIO_{ADDR,DATA} register first

2015-06-04 Thread Hariprasad Shenai
The TP_PIO_{ADDR,DATA} registers are are in conflict with the firmware's use of these registers. Added a routine to access it through FW LDST cmd. Access all TP_PIO_{ADDR,DATA} register access through new routine if FW is alive. If firmware is dead, than fall back to indirect access. Signed-off-by

[PATCH net-next 0/6] Free VI, flush sge ec and some other misc. fixes

2015-06-04 Thread Hariprasad Shenai
Hi, This patch series adds the following. Free VI interface during remove, flush SGE ec routine, rename t4_link_start to t4_link_l1cfg since it only does l1 configuration, set mac addr from when we can't contact firmware for debug purpose, set pcie completion timeout and use fw interface to access

[PATCH net-next 3/6] cxgb4: Rename t4_link_start() to t4_link_l1cfg

2015-06-04 Thread Hariprasad Shenai
t4_link_start() was completely misnamed. It does _not_ start up the link. It merely does the L1 Configuration for the link. The Link Up process is started automatically by the firmware when the number of enabled Virtual Interfaces on a port goes from 0 to 1. So renaming this routine to t4_link_l1c

[net 0/3][pull request] Intel Wired LAN Driver Updates 2015-06-04

2015-06-04 Thread Jeff Kirsher
This series contains updates to i40e and i40evf. Anjali provides three fixes, first to resolve a Tx queue hang if mixed size frags are passed to the driver while using TSO. There was a corner case where we needed to linearize but we were not. Next fixes a bug in the default configuration which p

[net 3/3] i40e: Make sure to be in VEB mode if SRIOV is enabled at probe

2015-06-04 Thread Jeff Kirsher
From: Anjali Singhai Jain If SRIOV is enabled we need to be in VEB mode not VEPA mode at probe. This fixes an NPAR bug when SRIOV is enabled in the BIOS. Change-ID: Ibf006abafd9a0ca3698ec24848cd771cf345cbbc Signed-off-by: Anjali Singhai Jain Tested-by: Jim Young Signed-off-by: Jeff Kirsher --

[net 1/3] i40e/i40evf: Fix mixed size frags and linearization

2015-06-04 Thread Jeff Kirsher
From: Anjali Singhai Jain This patch fixes a bug where the i40e Tx queue will hang if this skb is passed to the driver. With mixed size fragments while using TSO there was a corner case where we needed to linearize but we were not. This was seen with iSCSI traffic and could be reproduced with a

[net 2/3] i40e: start up in VEPA mode by default

2015-06-04 Thread Jeff Kirsher
From: Anjali Singhai Jain The patch fixes a bug in the default configuration which prevented a software bridge loaded on the PF interface from working correctly because broadcast packets are incorrectly looped back. Fix the general case, by loading the driver in VEPA mode Until a VF or VMDq VSI

Re: [RFC PATCH] slub: RFC: Improving SLUB performance with 38% on NO-PREEMPT

2015-06-04 Thread Eric Dumazet
On Thu, 2015-06-04 at 12:31 +0200, Jesper Dangaard Brouer wrote: > This patch improves performance of SLUB allocator fastpath with 38% by > avoiding the call to this_cpu_cmpxchg_double() for NO-PREEMPT kernels. > > Reviewers please point out why this change is wrong, as such a large > improvement

[net-next:master 1211/1214] drivers/infiniband/hw/mlx5/main.c:118:69: sparse: incorrect type in argument 2 (different base types)

2015-06-04 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: bb62f791f922254dc1847d3d0b77c9b066d5280b commit: 1b5daf11b015123108686a9060ee6de705a03e76 [1211/1214] IB/mlx5: Avoid using the MAD_IFC command under ISSI > 0 mode reproduce: # apt-get install sparse git che

Re: [PATCH net-next v2] rocker: move netevent neigh update to processes context

2015-06-04 Thread Scott Feldman
On Thu, Jun 4, 2015 at 3:54 PM, Simon Horman wrote: > Hi Scott, > >> Simon, just focusing on this rocker->neigh_tbl_next_index++ issue at >> the moment, I think the change below would make _rocker_neigh_add() >> safe to call without needing to put neigh_update into process context. >> It works bec

[PATCH net-next] tcp: get_cookie_sock() consolidation

2015-06-04 Thread Eric Dumazet
From: Eric Dumazet IPv4 and IPv6 share same implementation of get_cookie_sock(), and there is no point inlining it. We add tcp_ prefix to the common helper name and export it. Signed-off-by: Eric Dumazet --- include/net/tcp.h |3 +++ net/ipv4/syncookies.c | 10 +- net/ipv6/s

[net-next:master 1206/1214] drivers/net/ethernet/mellanox/mlx5/core/vport.c:321:33: sparse: incorrect type in assignment (different base types)

2015-06-04 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: bb62f791f922254dc1847d3d0b77c9b066d5280b commit: 707c4602cda6624940761b66a4119f1909492385 [1206/1214] net/mlx5_core: Add new query HCA vport commands reproduce: # apt-get install sparse git checkout 707c460

Re: [PATCH net-next 2/2] tcp: add CDG congestion control

2015-06-04 Thread Yuchung Cheng
On Thu, Jun 4, 2015 at 2:01 PM, Kenneth Klette Jonassen wrote: > CAIA Delay-Gradient (CDG) is a TCP congestion control that modifies > the TCP sender in order to [1]: > > o Use the delay gradient as a congestion signal. > o Back off with an average probability that is independent of the RTT. >

Re: [PATCH net-next 00/13] mlx5: Add Interface Step Sequence ID support

2015-06-04 Thread David Miller
From: Or Gerlitz Date: Thu, 4 Jun 2015 19:30:35 +0300 > ISSI (Interface Step Sequence ID) defines the step sequence ID of the > interface between the driver to the firmware and is incremented by > steps of one. ISSI is used to enable deprecating/modifying features, > command interfaces and su

Re: [Intel-wired-lan] [PATCH] fm10k: Fix missing braces after if statement

2015-06-04 Thread Keller, Jacob E
Acked-by: Jacob Keller Thanks Alex. Regards, Jake On Wed, 2015-06-03 at 18:53 -0700, Alexander Duyck wrote: > While reviewing the code I noticed that one of the commits added an if > statement followed by a for loop, but the if statement was missing the > braces around the loop. This change co

[PATCH net-next] net: bcmgenet: improve TX timeout

2015-06-04 Thread Florian Fainelli
Dump useful ring statistics along with interrupt status, software maintained pointers and hardware registers to help troubleshoot TX queue stalls. When a timeout occurs, disable TX NAPI for the rings, dump their states while interrupts are disabled, re-enable interrupts, NAPI and queue flow contro

[PATCH] net: dsa: mv88e6xxx: Fix deadlock by double lock

2015-06-04 Thread Andrew Lunn
ethtool -S on a DSA interface can deadlock for some switches because the same lock is taken twice. Use the register read function which expects the lock to be already held. Signed-off-by: Andrew Lunn Fixes: 31888234b736 ("net: dsa: mv88e6xxx: Replace stats mutex with SMI mutex") --- drivers/net/

Re: [PATCH v6 net-next 00/11] net: Increase inputs to flow_keys hashing

2015-06-04 Thread David Miller
From: Tom Herbert Date: Thu, 4 Jun 2015 09:16:35 -0700 > This patch set adds new fields to the flow_keys structure and hashes > over these fields to get a better flow hash. In particular, these > patches now include hashing over the full IPv6 addresses in order > to defend against address spoofin

Re: [PATCH net-next v2] rocker: move netevent neigh update to processes context

2015-06-04 Thread Simon Horman
Hi Scott, > Simon, just focusing on this rocker->neigh_tbl_next_index++ issue at > the moment, I think the change below would make _rocker_neigh_add() > safe to call without needing to put neigh_update into process context. > It works because entry is stored between PREPARE and COMMIT, so once > e

Re: [PATCH net-next] openvswitch: include actions with upcall if allocation allows

2015-06-04 Thread Neil McKee
On Thu, Jun 4, 2015 at 1:13 AM, David Miller wrote: > From: Neil McKee > Date: Wed, 3 Jun 2015 15:31:07 -0700 > >> Back out the OVS_USERSPACE_ATTR_ACTIONS attribute that was >> gating the inclusion of datapath actions in the upcall. >> Instead include the actions every time, provided there is no

Re: [PATCH] atm:he - Do not initialise statics to 0.

2015-06-04 Thread David Miller
From: Shailendra Verma Date: Thu, 4 Jun 2015 20:11:00 +0530 > According to false is always '0' and > Static variables are initialised to 0 by GCC. > > Signed-off-by: Shailendra Verma Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messag

Re: [v2 PATCH 5/13] crypto: testmgr - Switch to new AEAD interface

2015-06-04 Thread Tadeusz Struk
Hi Herbert, On 05/22/2015 01:30 AM, Herbert Xu wrote: > This patch makes use of the new AEAD interface which uses a single > SG list instead of separate lists for the AD and plain text. The fact the src and assoc point to the same sgl causes some inconsistency. The input I'm getting is: req->old

Re: [PATCH net-next V10 3/4] 802.1AD: Flow handling, actions and vlan parsing

2015-06-04 Thread Thomas F Herbert
On 6/4/15 4:39 PM, Pravin Shelar wrote: On Thu, Jun 4, 2015 at 11:18 AM, Thomas F Herbert wrote: On 6/4/15 1:45 PM, Pravin Shelar wrote: On Tue, Jun 2, 2015 at 10:50 AM, Thomas F Herbert wrote: Add support for 802.1ad including the ability to push and pop double tagged vlans. Signed-off-b

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-04 Thread Vivek Venkatraman
On Thu, Jun 4, 2015 at 11:46 AM, Robert Shearman wrote: > On 03/06/15 19:43, Vivek Venkatraman wrote: >> >> On Tue, Jun 2, 2015 at 2:06 PM, Robert Shearman >> wrote: >>> >>> On 02/06/15 19:57, roopa wrote: On 6/2/15, 9:33 AM, Robert Shearman wrote: > > > On 02/06/15 17:

Re: Recurring trace from tcp_fragment()

2015-06-04 Thread Yuchung Cheng
On Thu, Jun 4, 2015 at 1:56 PM, Martin KaFai Lau wrote: > > On Thu, Jun 04, 2015 at 01:10:26PM -0700, Grant Zhang wrote: > > Hi Martin, > > > > Thank you! My net.ipv4.tcp_mtu_probing is 1. After turning it off, > > the WARN_ON stack is gone. > Thanks for confirming it. > > > Could you elaborate a

[PATCH net-next 1/2] tcp: export tcp_enter_cwr()

2015-06-04 Thread Kenneth Klette Jonassen
Upcoming tcp_cdg uses tcp_enter_cwr() to initiate PRR. Export this function so that CDG can be compiled as a module. Cc: Eric Dumazet Cc: Yuchung Cheng Cc: Stephen Hemminger Cc: Neal Cardwell Cc: David Hayes Cc: Andreas Petlund Cc: Dave Taht Cc: Nicolas Kuhn Signed-off-by: Kenneth Klette J

[PATCH net-next 2/2] tcp: add CDG congestion control

2015-06-04 Thread Kenneth Klette Jonassen
CAIA Delay-Gradient (CDG) is a TCP congestion control that modifies the TCP sender in order to [1]: o Use the delay gradient as a congestion signal. o Back off with an average probability that is independent of the RTT. o Coexist with flows that use loss-based congestion control, i.e., f

Re: netlink: Disable insertions/removals during rehash

2015-06-04 Thread Guenter Roeck
On 06/04/2015 11:59 AM, David Miller wrote: From: Guenter Roeck Date: Thu, 4 Jun 2015 09:27:27 -0700 sorry for bothering you - I don't see this patch in any of your trees, and it is marked as "changes requested" in patchwork. Did I look at the wrong places, do you still plan to apply the patch

Re: Recurring trace from tcp_fragment()

2015-06-04 Thread Martin KaFai Lau
On Thu, Jun 04, 2015 at 01:10:26PM -0700, Grant Zhang wrote: > Hi Martin, > > Thank you! My net.ipv4.tcp_mtu_probing is 1. After turning it off, > the WARN_ON stack is gone. Thanks for confirming it. > Could you elaborate a bit on why this setting relates to the WARN_ON > trace? The WARN_ON is c

please queue commit ac37e2515c1a for stable 3.12 - 3.18

2015-06-04 Thread Michal Kubecek
Hello, please queue mainline commit ac37e2515c1a ("xfrm: release dst_orig in case of error in xfrm_lookup()") for stable branches 3.12, 3.14 and 3.18. It fixes a dst_entry reference leak introduced by commit f92ee61982d6 ("xfrm: Generate blackhole routes only from route lookup functions")

Re: netlink: Disable insertions/removals during rehash

2015-06-04 Thread Eric Dumazet
On Thu, 2015-06-04 at 11:59 -0700, David Miller wrote: > From: Guenter Roeck > Date: Thu, 4 Jun 2015 09:27:27 -0700 > > > sorry for bothering you - I don't see this patch in any of your trees, > > and it is marked as "changes requested" in patchwork. Did I look > > at the wrong places, do you sti

Re: [PATCH net-next V10 3/4] 802.1AD: Flow handling, actions and vlan parsing

2015-06-04 Thread Pravin Shelar
On Thu, Jun 4, 2015 at 11:18 AM, Thomas F Herbert wrote: > On 6/4/15 1:45 PM, Pravin Shelar wrote: >> >> On Tue, Jun 2, 2015 at 10:50 AM, Thomas F Herbert >> wrote: >>> >>> Add support for 802.1ad including the ability to push and pop double >>> tagged vlans. >>> >>> Signed-off-by: Thomas F Herbe

Re: virtio-net: why not always to set avail->flags to VRING_AVAIL_F_NO_INTERRUPT

2015-06-04 Thread Rusty Russell
Linhaifeng writes: > On 2015/6/4 9:13, Rusty Russell wrote: >> Linhaifeng writes: >>> Hi, >>> >>> I'm a newbie and have a question about vring_new_virtqueue function. >>> >>> Why we set avail->flags to VRING_AVAIL_F_NO_INTERRUPT when no callbacks? >>> I think we should set avail->flags to VRING_A

Re: Recurring trace from tcp_fragment()

2015-06-04 Thread Grant Zhang
Hi Martin, Thank you! My net.ipv4.tcp_mtu_probing is 1. After turning it off, the WARN_ON stack is gone. Could you elaborate a bit on why this setting relates to the WARN_ON trace? And what are the pros/cons for disabling mtu_probing? Thanks, Grant On 6/4/15 12:38 PM, Martin KaFai Lau wro

Re: Recurring trace from tcp_fragment()

2015-06-04 Thread Martin KaFai Lau
Hi Grant, On Thu, Jun 04, 2015 at 09:35:04AM -0700, Grant Zhang wrote: > Hi Neal, > > Unfortunately with the patch we still see the same stack trace. > Attached is the TcpExtTCPSACKReneging with the patch, captured with > 60 seconds interval. Its value is incremented at an similar speed as > befor

Re: Recurring trace from tcp_fragment()

2015-06-04 Thread Neal Cardwell
On Thu, Jun 4, 2015 at 12:35 PM, Grant Zhang wrote: > Hi Neal, > > Unfortunately with the patch we still see the same stack trace. Attached is > the TcpExtTCPSACKReneging with the patch, captured with 60 seconds interval. > Its value is incremented at an similar speed as before, about 30/minute. >

Re: netlink: Disable insertions/removals during rehash

2015-06-04 Thread David Miller
From: Guenter Roeck Date: Thu, 4 Jun 2015 09:27:27 -0700 > sorry for bothering you - I don't see this patch in any of your trees, > and it is marked as "changes requested" in patchwork. Did I look > at the wrong places, do you still plan to apply the patch as-is, > or do you expect some changes ?

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-04 Thread Robert Shearman
On 03/06/15 19:43, Vivek Venkatraman wrote: On Tue, Jun 2, 2015 at 2:06 PM, Robert Shearman wrote: On 02/06/15 19:57, roopa wrote: On 6/2/15, 9:33 AM, Robert Shearman wrote: On 02/06/15 17:15, roopa wrote: On 6/1/15, 9:46 AM, Robert Shearman wrote: Allow creating an mpls device for the

Re: [PATCH net-next v2] rocker: move netevent neigh update to processes context

2015-06-04 Thread David Miller
From: Toshiaki Makita Date: Fri, 05 Jun 2015 00:34:50 +0900 > I'm thinking IRQ context does not match the prepare-commit model, and > Scott's fix is needed. There are more critical problems Scott's patch > fixes. > (I shortly explained it before, although it is not clearly stated in > the commitl

Re: [PATCH net-next] bpf: fix build due to missing tc_verd

2015-06-04 Thread David Miller
From: Alexei Starovoitov Date: Thu, 4 Jun 2015 08:33:48 -0700 > fix build error: > net/core/filter.c: In function 'bpf_clone_redirect': > net/core/filter.c:1429:18: error: 'struct sk_buff' has no member named > 'tc_verd' > if (G_TC_AT(skb2->tc_verd) & AT_INGRESS) > > Fixes: 3896d655f4d4 ("bp

Re: [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses

2015-06-04 Thread David Miller
From: Julien Grall Date: Thu, 4 Jun 2015 13:45:00 +0100 > On 03/06/15 18:06, Joe Perches wrote: >> On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote: >>> rx->status is an int16_t, print it using %d rather than %u in order to >>> have a meaningful value when the field is negative. >> [] >>> di

Re: [PATCH 0/6] MIPS/BPF fixes for 4.3

2015-06-04 Thread David Miller
I think your Subject meant to say "fixes for 4.2" right? Because we're currently finishing up 4.1.x and the next merge window will be for 4.2.x -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http:/

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-04 Thread nolan
On 06/02/2015 11:53 PM, Scott Feldman wrote: I'm talking about bridging tagged traffic. E.g.: ip link add name br0 type bridge ip link add name br1 type bridge ip link set dev sw1p1 master br0 ip link set dev sw1p2 master br0 ip link set dev sw1p3 master br1 ip link set dev sw1p4 master br1 b

Re: [PATCH net-next V10 3/4] 802.1AD: Flow handling, actions and vlan parsing

2015-06-04 Thread Thomas F Herbert
On 6/4/15 1:45 PM, Pravin Shelar wrote: On Tue, Jun 2, 2015 at 10:50 AM, Thomas F Herbert wrote: Add support for 802.1ad including the ability to push and pop double tagged vlans. Signed-off-by: Thomas F Herbert --- net/openvswitch/flow.c | 82 ++-

Re: [PATCH net-next V10 3/4] 802.1AD: Flow handling, actions and vlan parsing

2015-06-04 Thread Pravin Shelar
On Tue, Jun 2, 2015 at 10:50 AM, Thomas F Herbert wrote: > Add support for 802.1ad including the ability to push and pop double > tagged vlans. > > Signed-off-by: Thomas F Herbert > --- > net/openvswitch/flow.c | 82 > ++ > net/openvswitch/flow.h

Re: [PATCH iproute2] tipc: introduce TIPC configuration tool

2015-06-04 Thread Pavel Simerda
- Original Message - > From: "Richard Alpe" > To: "Pavel Simerda" , "Stephen Hemminger" > > Cc: netdev@vger.kernel.org, tipc-discuss...@lists.sourceforge.net > Sent: Thursday, June 4, 2015 1:40:47 PM > Subject: Re: [PATCH iproute2] tipc: introduce TIPC configuration tool > > On 2015-06-

[PATCH v2 net-next 1/2] bpf: make programs see skb->data == L2 for ingress and egress

2015-06-04 Thread Alexei Starovoitov
eBPF programs attached to ingress and egress qdiscs see inconsistent skb->data. For ingress L2 header is already pulled, whereas for egress it's present. This is known to program writers which are currently forced to use BPF_LL_OFF workaround. Since programs don't change skb internal pointers it is

[PATCH v2 net-next 2/2] bpf: allow programs to write to certain skb fields

2015-06-04 Thread Alexei Starovoitov
allow programs read/write skb->mark, tc_index fields and ((struct qdisc_skb_cb *)cb)->data. mark and tc_index are generically useful in TC. cb[0]-cb[4] are primarily used to pass arguments from one program to another called via bpf_tail_call() which can be seen in sockex3_kern.c example. All fiel

[RFC 05/10] VSOCK: add tcp_read_sock()-like vsock_read_sock() function

2015-06-04 Thread Stefan Hajnoczi
The tcp_read_sock() interface dequeues skbs and gives them to the caller's callback function for processing. This interface can avoid data copies since the caller accesses the skb instead of using its own receive buffer. This patch implements vsock_read_sock() for AF_VSOCK SOCK_STREAM sockets. T

[RFC 03/10] SUNRPC: abstract tcp_read_sock() in record fragment parser

2015-06-04 Thread Stefan Hajnoczi
Use a function pointer to abstract tcp_read_sock()-like functions. For TCP this function will be tcp_read_sock(). For AF_VSOCK it will be vsock_read_sock(). Signed-off-by: Stefan Hajnoczi --- include/linux/sunrpc/xprtsock.h | 6 ++ net/sunrpc/xprtsock.c | 8 +++- 2 files chan

Re: [PATCH 0/6] MIPS/BPF fixes for 4.3

2015-06-04 Thread Alexei Starovoitov
On 6/4/15 3:56 AM, Markos Chandras wrote: Here are some fixes for MIPS/BPF. The first 5 patches do some cleanup and lay the groundwork for the final one which introduces assembly helpers for MIPS and MIPS64. The goal is to speed up certain operations that do not need to go through the common C fu

[RFC 08/10] SUNRPC: add vsock-bc backchannel

2015-06-04 Thread Stefan Hajnoczi
Note that this is currently a hack which unconditionally replaces "tcp-bc" with "vsock-bc". Need to find a way to select the appropriate backchannel name based on the address family. Signed-off-by: Stefan Hajnoczi --- fs/nfs/callback.c| 7 +-- net/sunrpc/svcsock.c | 48

[RFC 07/10] SUNRPC: restrict backchannel svc IPPROTO_TCP check to IP

2015-06-04 Thread Stefan Hajnoczi
The IPPROTO_TCP check only applies to AF_INET and AF_INET6. Signed-off-by: Stefan Hajnoczi --- net/sunrpc/svc.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c index 78974e4..1c9c5bc 100644 --- a/net/sunrpc/svc.c +++ b/net/su

[RFC 10/10] NFS: add AF_VSOCK support to NFS client

2015-06-04 Thread Stefan Hajnoczi
This patch adds AF_VSOCK to the NFS client. Mounts can now use the "vsock" proto option and pass "vsock:" address strings, which are interpreted by sunrpc for xprt creation. Signed-off-by: Stefan Hajnoczi --- fs/nfs/client.c | 16 fs/nfs/super.c | 10 ++ 2 files change

[RFC 04/10] SUNRPC: extract xs_stream_reset_state()

2015-06-04 Thread Stefan Hajnoczi
Extract a function to reset the record fragment parser. Signed-off-by: Stefan Hajnoczi --- net/sunrpc/xprtsock.c | 33 +++-- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c index 06fde0e..9fa63f7 100644 ---

[RFC 06/10] SUNRPC: add AF_VSOCK support to xprtsock.c

2015-06-04 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- include/linux/sunrpc/xprt.h | 1 + net/sunrpc/xprtsock.c | 392 ++-- 2 files changed, 380 insertions(+), 13 deletions(-) diff --git a/include/linux/sunrpc/xprt.h b/include/linux/sunrpc/xprt.h index 8b93ef5..055a35

[RFC 01/10] SUNRPC: add AF_VSOCK support to addr.h

2015-06-04 Thread Stefan Hajnoczi
AF_VSOCK addresses are a Context ID (CID) and port number tuple. The CID is a unique address, similar to a IP address on a local subnet. Extend the addr.h functions to handle AF_VSOCK addresses. Signed-off-by: Stefan Hajnoczi --- include/linux/sunrpc/addr.h | 6 + net/sunrpc/addr.c

[RFC 02/10] SUNRPC: rename "TCP" record parser to "stream" parser

2015-06-04 Thread Stefan Hajnoczi
The TCP record parser is really a RFC 1831 record fragment parser. There is nothing TCP protocol-specific about parsing record fragments. The parser can be reused for any SOCK_STREAM socket. This patch renames functions and fields but xs_stream_data_ready() still calls tcp_read_sock(). This is ad

[RFC 00/10] NFS: add AF_VSOCK support to NFS client

2015-06-04 Thread Stefan Hajnoczi
This patch series enables AF_VSOCK address family support in the NFS client. Please use the https://github.com/stefanha/linux.git vsock-nfs branch, which contains the dependencies for this series. The AF_VSOCK address family provides dgram and stream socket communication between virtual machines a

[RFC 09/10] SUNRPC: add AF_VSOCK support to svc_xprt.c

2015-06-04 Thread Stefan Hajnoczi
Allow creation of AF_VSOCK service xprts. This is needed for the "vsock-bc" backchannel. Signed-off-by: Stefan Hajnoczi --- include/linux/sunrpc/svc_xprt.h | 12 net/sunrpc/svc_xprt.c | 13 + 2 files changed, 25 insertions(+) diff --git a/include/linux/sunrpc

Re: [PATCH v4 for-next 00/12] Add network namespace support in the RDMA-CM

2015-06-04 Thread Jason Gunthorpe
On Thu, Jun 04, 2015 at 09:24:37AM +0300, Haggai Eran wrote: > > The l2/l3 distinction in ipvlan is also very interesting. The L3 mode > > solves some of the security type issues. What do you think Haggi? > I think some issues ipvlan is trying to solve would also affect us using > the alias GUIDs

Re: Recurring trace from tcp_fragment()

2015-06-04 Thread Grant Zhang
Hi Neal, Unfortunately with the patch we still see the same stack trace. Attached is the TcpExtTCPSACKReneging with the patch, captured with 60 seconds interval. Its value is incremented at an similar speed as before, about 30/minute. If you want to collect any other data, please feel free t

[PATCH net-next 03/13] net/mlx5_core: Enable XRCs and SRQs when using ISSI > 0

2015-06-04 Thread Or Gerlitz
From: Haggai Abramonvsky When working in ISSI > 0 mode, the model exposed by the device for XRCs and SRQs is different. XRCs use XRC SRQs and plain SRQs are based on RPM (Receive Memory Pool). Add helper functions to create, modify, query, and arm XRC SRQs and RMPs. Signed-off-by: Haggai Abramo

[PATCH net-next 02/13] net/mlx5_core: Apply proper name convention to helpers

2015-06-04 Thread Or Gerlitz
From: Haggai Abramonvsky Some core helper functions were named with mlx5_ only prefix, fix that to mlx5_core_ so we're aligned with the overall scheme used for core services. Signed-off-by: Haggai Abramovsky Signed-off-by: Or Gerlitz --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c |

[PATCH net-next 06/13] net/mlx5_core: Add new query HCA vport commands

2015-06-04 Thread Or Gerlitz
From: Majd Dibbiny Added the implementation for the following commands: 1. QUERY_HCA_VPORT_GID 2. QUERY_HCA_VPORT_PKEY 3. QUERY_HCA_VPORT_CONTEXT They will be needed when we move to work with ISSI > 0 in the IB driver too. Signed-off-by: Majd Dibbiny Signed-off-by: Or Gerlitz --- drivers/ne

[PATCH net-next 04/13] net/mlx5_core: Check the return bitmask when querying ISSI

2015-06-04 Thread Or Gerlitz
From: Haggai Abramonvsky The determination of the supported ISSI versions should be conditioned on the returned mask, and not only on the return status of the query ISSI command, fix that. Signed-off-by: Haggai Abramovsky Signed-off-by: Majd Dibbiny Signed-off-by: Or Gerlitz --- drivers/net/

[PATCH net-next 07/13] net/mlx5_core: Get vendor-id using the query adapter command

2015-06-04 Thread Or Gerlitz
From: Majd Dibbiny Add two wrapper functions to the query adapter command: 1. mlx5_query_board_id -- replaces the old mlx5_cmd_query_adapter. 2. mlx5_core_query_vendor_id -- retrieves the vendor_id from the query_adapter command. Signed-off-by: Majd Dibbiny Signed-off-by: Or Gerlitz ---

[PATCH net-next 10/13] net/mlx5_core: Add more query port helpers

2015-06-04 Thread Or Gerlitz
From: Majd Dibbiny Add the following helpers: 1. mlx5_query_port_proto_oper -- queries the port speed port mask 2. mlx5_query_port_link_width_oper - queries the port link with bitmask 3. mlx5_query_port_vl_hw_cap - queries the Virtual Lanes supported on this port These helpers will be used from

[PATCH net-next 09/13] net/mlx5_core: Use port number when querying port ptys

2015-06-04 Thread Or Gerlitz
From: Majd Dibbiny Until now, mlx5_query_port_ptys always queried port number one. Added new argument in the function's prototype so we can also query the second port. This will be needed when thr helper will be invoked from the IB driver on non FPP (Function-Per-Port) devices. Signed-off-by:

[PATCH net-next 13/13] mlx5: Enable mutual support for IB and Ethernet

2015-06-04 Thread Or Gerlitz
From: Haggai Abramonvsky Ethernet functionality is only available when working in ISSI > 0 mode. Previously, the IB driver wasn't ready to work on that mode, and hence building both the IB driver and the Ethernet functionality in the core driver were disallowed by Kconfigs. Now, once we have al

[PATCH net-next 01/13] net/mlx5_en: Add missing check for memory allocation failure

2015-06-04 Thread Or Gerlitz
From: Amir Vadai The patch afb736e9330a: "net/mlx5: Ethernet resource handling files" from May 28, 2015, leads to the following static checker warning: drivers/net/ethernet/mellanox/mlx5/core/en_flow_table.c:726 mlx5e_create_main_flow_table() error: potential null dereference 'g'. (kcalloc ret

[PATCH net-next 05/13] net/mlx5_core: Make the vport helpers available for the IB driver too

2015-06-04 Thread Or Gerlitz
From: Majd Dibbiny Move the vport header file to be under include/linux/mlx5, such that the mlx5 IB can use it as well. Also add nic_ prefix to the vport NIC commands to differeniate between HCA vport commands and NIC vport commands. Signed-off-by: Majd Dibbiny Signed-off-by: Or Gerlitz ---

[PATCH net-next 11/13] IB/mlx5: Avoid using the MAD_IFC command under ISSI > 0 mode

2015-06-04 Thread Or Gerlitz
From: Majd Dibbiny In ISSI > 0 mode, most of the MAD_IFC command features are deprecated, and can't be used. Therefore, when in that mode, we replace all of them with other commands that provide the required functionality. Signed-off-by: Majd Dibbiny Signed-off-by: Or Gerlitz --- drivers/inf

[PATCH net-next 08/13] net/mlx5_core: Use port number in the query port mtu helpers

2015-06-04 Thread Or Gerlitz
From: Majd Dibbiny Extend the function prototypes for max and operational mtu to take the local port number. In the Ethernet driver is this hard coded to one, since ConnectX4 Ethernet devices are always function-per-port. The IB driver also serves older devices (ConnectIB) which isn't such, and h

[PATCH net-next 00/13] mlx5: Add Interface Step Sequence ID support

2015-06-04 Thread Or Gerlitz
ISSI (Interface Step Sequence ID) defines the step sequence ID of the interface between the driver to the firmware and is incremented by steps of one. ISSI is used to enable deprecating/modifying features, command interfaces and such, while maintaining compatibility. As the driver serves both C

[PATCH net-next 12/13] IB/mlx5: Don't create IB instance over Ethernet ports

2015-06-04 Thread Or Gerlitz
From: Majd Dibbiny Since we still don't have RoCE support in mlx5, avoid creating IB driver instance over Ethernet ports. Signed-off-by: Majd Dibbiny Signed-off-by: Or Gerlitz --- drivers/infiniband/hw/mlx5/main.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dri

Re: netlink: Disable insertions/removals during rehash

2015-06-04 Thread Guenter Roeck
On Sat, May 16, 2015 at 05:10:19PM -0400, David Miller wrote: > From: Herbert Xu > Date: Sat, 16 May 2015 21:16:28 +0800 > > > On Fri, May 15, 2015 at 01:02:57PM -0400, David Miller wrote: > >> From: Herbert Xu > >> Date: Thu, 14 May 2015 13:58:24 +0800 > >> > >> > The current rhashtable rehash

Re: [RFC PATCH net-next] tcp: add CDG congestion control

2015-06-04 Thread Dave Taht
On Thu, Jun 4, 2015 at 9:19 AM, Kenneth Klette Jonassen wrote: >> why not just call tcp_init_cwnd_reduction()? > > I deferred considering the ECN implications of doing so. The code to > start PRR was based on tcp_enter_cwr()/tcp_init_cwnd_reduction(), save > that both of these functions ensure a c

Networking microconf accepted - Last day early bird rate

2015-06-04 Thread Thomas Graf
The networking microconference has been formally accepted into the Linux Plumbers Aug 19-21 in Seattle. Tomorrow, June 5, is the last day of the early registration rate. Please register [0] if you are planning to attend. As in previous years, the conference has a maximum capacity and once reached,

Re: [Xen-devel] [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses

2015-06-04 Thread Joe Perches
On Thu, 2015-06-04 at 13:52 +0100, Julien Grall wrote: > On 04/06/15 13:46, David Vrabel wrote: > > On 04/06/15 13:45, Julien Grall wrote: > >> On 03/06/15 18:06, Joe Perches wrote: > >>> On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote: > rx->status is an int16_t, print it using %d rathe

Re: [RFC PATCH net-next] tcp: add CDG congestion control

2015-06-04 Thread Kenneth Klette Jonassen
> why not just call tcp_init_cwnd_reduction()? I deferred considering the ECN implications of doing so. The code to start PRR was based on tcp_enter_cwr()/tcp_init_cwnd_reduction(), save that both of these functions ensure a call to tcp_ecn_queue_cwr(). The upcoming patch set instead exports tcp_

[PATCH v6 net-next 07/11] net: Get rid of IPv6 hash addresses flow keys

2015-06-04 Thread Tom Herbert
We don't need to return the IPv6 address hash as part of flow keys. In general, using the IPv6 address hash is risky in a hash value since the underlying use of xor provides no entropy. If someone really needs the hash value they can get it from the full IPv6 addresses in flow keys (e.g. from flow_

[PATCH v6 net-next 06/11] net: Add keys for TIPC address

2015-06-04 Thread Tom Herbert
Add a new flow key for TIPC addresses. Signed-off-by: Tom Herbert --- include/net/flow_dissector.h | 10 ++ net/core/flow_dissector.c| 18 +- 2 files changed, 23 insertions(+), 5 deletions(-) diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h in

[PATCH v6 net-next 10/11] net: Add GRE keyid in flow_keys

2015-06-04 Thread Tom Herbert
In flow dissector if a GRE header contains a keyid this is saved in the new keyid field of flow_keys. The GRE keyid is then represented in the flow hash function input. Signed-off-by: Tom Herbert --- include/net/flow_dissector.h | 6 ++ net/core/flow_dissector.c| 24

[PATCH v6 net-next 11/11] mpls: Add MPLS entropy label in flow_keys

2015-06-04 Thread Tom Herbert
In flow dissector if an MPLS header contains an entropy label this is saved in the new keyid field of flow_keys. The entropy label is then represented in the flow hash function input. Signed-off-by: Tom Herbert --- include/net/flow_dissector.h | 1 + net/core/flow_dissector.c| 35 ++

[PATCH v6 net-next 09/11] net: Add IPv6 flow label to flow_keys

2015-06-04 Thread Tom Herbert
In flow_dissector set the flow label in flow_keys for IPv6. This also removes the shortcircuiting of flow dissection when a non-zero label is present, the flow label can be considered to provide additional entropy for a hash. Signed-off-by: Tom Herbert --- include/net/flow_dissector.h | 4 +++-

[PATCH v6 net-next 00/11] net: Increase inputs to flow_keys hashing

2015-06-04 Thread Tom Herbert
This patch set adds new fields to the flow_keys structure and hashes over these fields to get a better flow hash. In particular, these patches now include hashing over the full IPv6 addresses in order to defend against address spoofing that always results in the same hash. The new input also includ

[PATCH v6 net-next 04/11] net: Get skb hash over flow_keys structure

2015-06-04 Thread Tom Herbert
This patch changes flow hashing to use jhash2 over the flow_keys structure instead just doing jhash_3words over src, dst, and ports. This method will allow us take more input into the hashing function so that we can include full IPv6 addresses, VLAN, flow labels etc. without needing to resort to xo

[PATCH v6 net-next 03/11] net: Remove superfluous setting of key_basic

2015-06-04 Thread Tom Herbert
key_basic is set twice in __skb_flow_dissect which seems unnecessary. Remove second one. Acked-by: Jiri Pirko Signed-off-by: Tom Herbert --- net/core/flow_dissector.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index 7f69916..07

[PATCH v6 net-next 08/11] net: Add VLAN ID to flow_keys

2015-06-04 Thread Tom Herbert
In flow_dissector set vlan_id in flow_keys when VLAN is found. Signed-off-by: Tom Herbert --- include/net/flow_dissector.h | 6 ++ net/core/flow_dissector.c| 14 ++ 2 files changed, 20 insertions(+) diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h in

[PATCH v6 net-next 05/11] net: Add full IPv6 addresses to flow_keys

2015-06-04 Thread Tom Herbert
This patch adds full IPv6 addresses into flow_keys and uses them as input to the flow hash function. The implementation supports either IPv4 or IPv6 addresses in a union, and selector is used to determine how may words to input to jhash2. We also add flow_get_u32_dst and flow_get_u32_src functions

[PATCH v6 net-next 01/11] net: Simplify GRE case in flow_dissector

2015-06-04 Thread Tom Herbert
Do break when we see routing flag or a non-zero version number in GRE header. Acked-by: Jiri Pirko Signed-off-by: Tom Herbert --- net/core/flow_dissector.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/net/core/flow_dissector.

  1   2   >