Re: [net-next v2] ipv4: inet_bind: check the addr_len first

2015-06-02 Thread Denis Kirjanov
On 6/3/15, Hannes Frederic Sowa wrote: > > > On Tue, Jun 2, 2015, at 17:13, Denis Kirjanov wrote: >> On 6/2/15, Hannes Frederic Sowa wrote: >> > Hello, >> > >> > On Tue, Jun 2, 2015, at 14:21, Denis Kirjanov wrote: >> >> Perform the address length check first, before calling >> >> the proto speci

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-02 Thread Scott Feldman
On Tue, Jun 2, 2015 at 3:31 PM, nolan wrote: > On 06/02/2015 12:44 AM, Scott Feldman wrote: >> >> That brings up an interesting point about having multiple bridges with >> the same vlan configured. I struggled with that problem with rocker >> also and I don't have an answer other than "don't do t

virtio-net: why not always to set avail->flags to VRING_AVAIL_F_NO_INTERRUPT

2015-06-02 Thread Linhaifeng
Hi, I'm a newbie and have a question about vring_new_virtqueue function. Why we set avail->flags to VRING_AVAIL_F_NO_INTERRUPT when no callbacks? I think we should set avail->flags to VRING_AVAIL_F_NO_INTERRUPT even if no callbacks. -- To unsubscribe from this list: send the line "unsubscribe n

Re: [PATCH net-next] bridge: skip fdb add if the port shouldn't learn

2015-06-02 Thread Scott Feldman
On Tue, Jun 2, 2015 at 10:14 AM, roopa wrote: > On 5/27/15, 9:01 AM, Scott Feldman wrote: >> >> On Wed, May 27, 2015 at 1:35 AM, Nikolay Aleksandrov >> wrote: >>> >>> On Wed, May 27, 2015 at 9:59 AM, Scott Feldman wrote: On Wed, May 27, 2015 at 12:05 AM, Nikolay Aleksandrov wrote

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-02 Thread Scott Feldman
On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek wrote: > This patch adds the ability to have the Linux kernel track whether or > not a particular route should be used based on the link-status of the > interface associated with the next-hop. > > Before this patch any link-failure on an interface th

Re: [RFC 7/9] net: dsa: mv88e6352: lock CPU port from learning addresses

2015-06-02 Thread Guenter Roeck
On 06/02/2015 07:31 PM, Chris Healy wrote: Guenter, That's a very valid concern. I have a configuration with a 6352 controlled by a low end ARM core with a 100mbps connection on the CPU port. This switch needs to support passing multicast streams that are more than 100mbps on GigE links. (

[PATCH net-next v2] rocker: move netevent neigh update to processes context

2015-06-02 Thread sfeldma
From: Scott Feldman v2: Changes based on review: - David Miller raise problem with system_wq not preserving queue order to execution order. To fix, use driver-private ordered workqueue to preserve ordering of queued work. - Jiri Pirko small change on kfree of work queue item. v1: In r

[PATCH net-next] net: change fib behavior based on interface link status

2015-06-02 Thread Andy Gospodarek
This patch adds the ability to have the Linux kernel track whether or not a particular route should be used based on the link-status of the interface associated with the next-hop. Before this patch any link-failure on an interface that was serving as a gateway for some systems could result in thos

[PATCH] e1000e: Cleanup qos request in error handling of e1000_open

2015-06-02 Thread Jia-Ju Bai
The driver lacks pm_qos_remove_request in error handling (err_req_irq) of e1000_open, and qos request inserted by pm_qos_add_request is not removed. This patch add pm_qos_remove_request in error handling to fix it. Signed-off-by: Jia-Ju Bai --- drivers/net/ethernet/intel/e1000e/netdev.c |1 +

Re: [Intel-wired-lan] [PATCH V2 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-06-02 Thread Alexander Duyck
On 06/02/2015 05:10 PM, Mark D Rustad wrote: Add a dev_flags bit, PCI_DEV_FLAGS_VPD_REF_F0, to access VPD through function 0 to provide VPD access on other functions. This solves concurrent access problems on many devices without changing the attributes exposed in sysfs. Never set this bit on fun

Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring

2015-06-02 Thread Guenter Roeck
On Tue, Jun 02, 2015 at 09:12:30PM -0400, Vivien Didelot wrote: > Hi Guenter, Andrew, > > On Jun 2, 2015, at 10:53 AM, Andrew Lunn and...@lunn.ch wrote: > On Tue, Jun 02, 2015 at 07:16:10AM -0700, Guenter Roeck wrote: > >> On 06/01/2015 06:27 PM, Vivien Didelot wrote: > >> >Disable the mirroring p

Re: [RFC 7/9] net: dsa: mv88e6352: lock CPU port from learning addresses

2015-06-02 Thread Guenter Roeck
On Tue, Jun 02, 2015 at 09:06:15PM -0400, Vivien Didelot wrote: > Hi Guenter, > > On Jun 2, 2015, at 10:24 AM, Guenter Roeck li...@roeck-us.net wrote: > On 06/01/2015 06:27 PM, Vivien Didelot wrote: > >> This commit disables SA learning and refreshing for the CPU port. > >> > > > > Hi Vivien, > >

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-02 Thread Guenter Roeck
On Tue, Jun 02, 2015 at 09:39:50PM -0400, Vivien Didelot wrote: > Guenter, > > On Jun 2, 2015, at 2:50 AM, Guenter Roeck li...@roeck-us.net wrote: > > On 06/01/2015 06:27 PM, Vivien Didelot wrote: > >> +/* Bringing an interface up adds it to the VLAN 0. Ignore this. */ > >> +if (!vid) > >>

Re: [RFC 6/9] net: dsa: mv88e6352: allow egress of unknown multicast

2015-06-02 Thread Vivien Didelot
Hi Guenter, On Jun 2, 2015, at 10:20 AM, Guenter Roeck li...@roeck-us.net wrote: > On 06/01/2015 06:27 PM, Vivien Didelot wrote: >> This patch disables egress of unknown unicast destination addresses. >> > > Hi Vivien, > > seems to me this patch is unrelated to the rest of the series. > > Not s

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-02 Thread Vivien Didelot
Guenter, On Jun 2, 2015, at 2:50 AM, Guenter Roeck li...@roeck-us.net wrote: > On 06/01/2015 06:27 PM, Vivien Didelot wrote: >> +/* Bringing an interface up adds it to the VLAN 0. Ignore this. */ >> +if (!vid) >> +return 0; >> + > > Me puzzled ;-). I brought this and the fid quest

Re: [PATCH net iproute2 v4] mpls: always set type RTN_UNICAST and scope RT_SCOPE_UNIVERSE for route add/deletes

2015-06-02 Thread Eric W. Biederman
Roopa Prabhu writes: > From: Roopa Prabhu > > This patch fixes incorrect -EINVAL errors due to invalid > scope and type during mpls route deletes. > > $ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev swp1 > > $ip -f mpls route show > 100 as to 200 via inet 10.1.1.2 dev swp1 > > $ip -f mpls

Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring

2015-06-02 Thread Vivien Didelot
Hi Guenter, Andrew, On Jun 2, 2015, at 10:53 AM, Andrew Lunn and...@lunn.ch wrote: On Tue, Jun 02, 2015 at 07:16:10AM -0700, Guenter Roeck wrote: >> On 06/01/2015 06:27 PM, Vivien Didelot wrote: >> >Disable the mirroring policy in the monitor control register, since this >> >feature is not needed.

Re: [PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-06-02 Thread Simon Horman
On Mon, Jun 01, 2015 at 02:56:25PM -0700, David Miller wrote: > From: Eric Dumazet > Date: Mon, 01 Jun 2015 07:12:37 -0700 > > > Can we ensure offload_base contains a sensible order of expected > > types ? > > This seemed easy enough to kill, so I pushed the following into net-next: > > ===

Re: [RFC 7/9] net: dsa: mv88e6352: lock CPU port from learning addresses

2015-06-02 Thread Vivien Didelot
Hi Guenter, On Jun 2, 2015, at 10:24 AM, Guenter Roeck li...@roeck-us.net wrote: On 06/01/2015 06:27 PM, Vivien Didelot wrote: >> This commit disables SA learning and refreshing for the CPU port. >> > > Hi Vivien, > > This patch also seems to be unrelated to the rest of the series. > > Can you

Re: How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Andy Lutomirski
On Tue, Jun 2, 2015 at 5:33 PM, Hannes Frederic Sowa wrote: > On Wed, Jun 3, 2015, at 02:03, Andy Lutomirski wrote: >> On Tue, Jun 2, 2015 at 2:50 PM, Hannes Frederic Sowa >> wrote: >> >> My proposal would be to make the error conversion lazy: >> >> >> >> Keeping duplicate data is not a good idea

Re: [RFC 2/9] net: dsa: add basic support for VLAN operations

2015-06-02 Thread Vivien Didelot
Hi Guenter, On Jun 2, 2015, at 10:42 AM, Guenter Roeck li...@roeck-us.net wrote: On 06/01/2015 06:27 PM, Vivien Didelot wrote: >> This patch adds the glue between DSA and switchdev to add and delete >> SWITCHDEV_OBJ_PORT_VLAN objects. >> >> This will allow the DSA switch drivers implementing the p

[PATCH net iproute2 v4] mpls: always set type RTN_UNICAST and scope RT_SCOPE_UNIVERSE for route add/deletes

2015-06-02 Thread Roopa Prabhu
From: Roopa Prabhu This patch fixes incorrect -EINVAL errors due to invalid scope and type during mpls route deletes. $ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route show 100 as to 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route del 100 as 200 via inet 10.1.1.2 d

Re: How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Hannes Frederic Sowa
On Wed, Jun 3, 2015, at 02:03, Andy Lutomirski wrote: > On Tue, Jun 2, 2015 at 2:50 PM, Hannes Frederic Sowa > wrote: > >> My proposal would be to make the error conversion lazy: > >> > >> Keeping duplicate data is not a good idea in general: So we shouldn't > >> use sk->sk_err if IP_RECVERR is se

[PATCH V2 2/2] pci: Add VPD quirk for Intel Ethernet devices

2015-06-02 Thread Mark D Rustad
This quirk sets the PCI_DEV_FLAGS_VPD_REF_F0 flag on all Intel Ethernet device functions other than function 0. Signed-off-by: Mark Rustad --- drivers/pci/quirks.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index c6dc1dfd25d5..9ddf

[PATCH V2 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-06-02 Thread Mark D Rustad
Add a dev_flags bit, PCI_DEV_FLAGS_VPD_REF_F0, to access VPD through function 0 to provide VPD access on other functions. This solves concurrent access problems on many devices without changing the attributes exposed in sysfs. Never set this bit on function 0 or there will be an infinite recursion.

[PATCH V2 0/2] pci: Provide a flag to access VPD through function 0

2015-06-02 Thread Mark D Rustad
Many multi-function devices provide shared registers in extended config space for accessing VPD. The behavior of these registers means that the state must be tracked and access locked correctly for accesses not to hang or worse. One way to meet these needs is to always perform the accesses through

Re: How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Andy Lutomirski
On Tue, Jun 2, 2015 at 2:50 PM, Hannes Frederic Sowa wrote: > On Tue, Jun 2, 2015, at 23:42, Hannes Frederic Sowa wrote: >> On Tue, Jun 2, 2015, at 23:33, Andy Lutomirski wrote: >> > On Tue, Jun 2, 2015 at 2:17 PM, Hannes Frederic Sowa >> > wrote: >> > > On Tue, Jun 2, 2015, at 21:40, Andy Lutomi

Re: [RFC 8/9] net: dsa: mv88e6352: set port 802.1Q mode to Secure

2015-06-02 Thread Vivien Didelot
Hi Guenter, On Jun 2, 2015, at 10:31 AM, Guenter Roeck li...@roeck-us.net wrote: On 06/01/2015 06:27 PM, Vivien Didelot wrote: >> This commit changes the 802.1Q mode of each port from Disabled to >> Secure. This enables the VLAN support, by checking the VTU entries on >> ingress. >> >> Signed-off-

Re: [RFC 8/9] net: dsa: mv88e6352: set port 802.1Q mode to Secure

2015-06-02 Thread Guenter Roeck
On 06/01/2015 06:27 PM, Vivien Didelot wrote: This commit changes the 802.1Q mode of each port from Disabled to Secure. This enables the VLAN support, by checking the VTU entries on ingress. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx.c | 14 +++--- drivers/net/dsa/mv

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread Eric W. Biederman
Thomas Graf writes: > On 06/02/15 at 01:26pm, Eric W. Biederman wrote: >> What we really want here is xfrm-lite. By lite I mean the tunnel >> selection criteria is simple enough that it fits into the normal >> routing table instead of having to do weird flow based magic that >> is rarely needed.

Re: [RFC 0/3] DSA and Marvell 88E6352 802.1q support

2015-06-02 Thread Vivien Didelot
Hi Scott, On Jun 2, 2015, at 2:18 AM, Scott Feldman sfel...@gmail.com wrote: > On Mon, Jun 1, 2015 at 5:18 PM, Vivien Didelot > wrote: >> >> On May 29, 2015, at 1:02 AM, Scott Feldman sfel...@gmail.com wrote: >>> On Thu, May 28, 2015 at 2:37 PM, Vivien Didelot >>> wrote: This RFC is based o

Re: [PATCH net v3 2/2] mpls: fix mpls route deletes to not check for route scope

2015-06-02 Thread Eric W. Biederman
roopa writes: > On 6/2/15, 2:13 PM, Eric W. Biederman wrote: >> So I just stopped and looked at what is happening. When you originally >> reported this you said (or at least I understood) that rtm_scope was not >> being set in iproute. I assumed that meant it was not being touched >> and it was

[PATCH net-next] bpf: introduce bpf_clone_redirect() helper

2015-06-02 Thread Alexei Starovoitov
Allow eBPF programs attached to classifier/actions to call bpf_clone_redirect(skb, ifindex, flags) helper which will mirror or redirect the packet by dynamic ifindex selection from within the program to a target device either at ingress or at egress. Can be used for various scenarios, for example,

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Eric W. Biederman
Robert Shearman writes: > On 02/06/15 22:10, Eric W. Biederman wrote: >> Robert Shearman writes: >> >>> On 02/06/15 19:11, Eric W. Biederman wrote: Robert Shearman writes: > In order to be able to function as a Label Edge Router in an MPLS > network, it is necessary to be able

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread Eric W. Biederman
Thomas Graf writes: > On 06/02/15 at 01:26pm, Eric W. Biederman wrote: >> What we really want here is xfrm-lite. By lite I mean the tunnel >> selection criteria is simple enough that it fits into the normal >> routing table instead of having to do weird flow based magic that >> is rarely needed.

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-02 Thread nolan
On 06/02/2015 12:44 AM, Scott Feldman wrote: That brings up an interesting point about having multiple bridges with the same vlan configured. I struggled with that problem with rocker also and I don't have an answer other than "don't do that". Or, better put, if you have multiple bridge on the

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Robert Shearman
On 02/06/15 22:10, Eric W. Biederman wrote: Robert Shearman writes: On 02/06/15 19:11, Eric W. Biederman wrote: Robert Shearman writes: In order to be able to function as a Label Edge Router in an MPLS network, it is necessary to be able to take IP packets and impose an MPLS encap and forw

Re: [PATCH net v3 2/2] mpls: fix mpls route deletes to not check for route scope

2015-06-02 Thread roopa
On 6/2/15, 2:13 PM, Eric W. Biederman wrote: So I just stopped and looked at what is happening. When you originally reported this you said (or at least I understood) that rtm_scope was not being set in iproute. I assumed that meant it was not being touched and it was taking a default value of z

Re: How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Hannes Frederic Sowa
On Tue, Jun 2, 2015, at 23:42, Hannes Frederic Sowa wrote: > On Tue, Jun 2, 2015, at 23:33, Andy Lutomirski wrote: > > On Tue, Jun 2, 2015 at 2:17 PM, Hannes Frederic Sowa > > wrote: > > > On Tue, Jun 2, 2015, at 21:40, Andy Lutomirski wrote: > > > > [...] > > > > I do this already, which makes me

Re: How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Andy Lutomirski
On Tue, Jun 2, 2015 at 2:42 PM, Hannes Frederic Sowa wrote: > On Tue, Jun 2, 2015, at 23:33, Andy Lutomirski wrote: >> On Tue, Jun 2, 2015 at 2:17 PM, Hannes Frederic Sowa >> wrote: >> > On Tue, Jun 2, 2015, at 21:40, Andy Lutomirski wrote: >> >> As far as I can tell, enabling IP_RECVERR causes t

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Thomas Graf
On 06/02/15 at 02:28pm, Robert Shearman wrote: > Nesting attributes inside the RTA_ENCAP blob should be supported by the > patch series today. Something like this: Sure. I'm not seeing such a construct for the MPLS case yet. I'm happy to rebase my patches on top of your nexthop implementation. It

Re: How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Hannes Frederic Sowa
On Tue, Jun 2, 2015, at 23:33, Andy Lutomirski wrote: > On Tue, Jun 2, 2015 at 2:17 PM, Hannes Frederic Sowa > wrote: > > On Tue, Jun 2, 2015, at 21:40, Andy Lutomirski wrote: > >> As far as I can tell, enabling IP_RECVERR causes the presence of a > >> queued error to cause recvmsg, etc to return

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread Thomas Graf
On 06/02/15 at 01:26pm, Eric W. Biederman wrote: > What we really want here is xfrm-lite. By lite I mean the tunnel > selection criteria is simple enough that it fits into the normal > routing table instead of having to do weird flow based magic that > is rarely needed. > > I believe what we want

[PATCH iproute2 -next] tc: {f,m}_bpf: allow to retrieve uds path from env

2015-06-02 Thread Daniel Borkmann
Allow to retrieve uds path from the environment, facilitates also dealing with export a bit. Signed-off-by: Daniel Borkmann --- tc/f_bpf.c | 6 -- tc/m_bpf.c | 6 -- tc/tc_bpf.h | 2 ++ 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/tc/f_bpf.c b/tc/f_bpf.c index 597ef6

Re: How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Andy Lutomirski
On Tue, Jun 2, 2015 at 2:17 PM, Hannes Frederic Sowa wrote: > On Tue, Jun 2, 2015, at 21:40, Andy Lutomirski wrote: >> As far as I can tell, enabling IP_RECVERR causes the presence of a >> queued error to cause recvmsg, etc to return an error (once). It's >> worse, though: a new error can be queu

Re: [net-next v2] ipv4: inet_bind: check the addr_len first

2015-06-02 Thread Hannes Frederic Sowa
On Tue, Jun 2, 2015, at 17:13, Denis Kirjanov wrote: > On 6/2/15, Hannes Frederic Sowa wrote: > > Hello, > > > > On Tue, Jun 2, 2015, at 14:21, Denis Kirjanov wrote: > >> Perform the address length check first, before calling > >> the proto specific bind() function > > > > Can you give more deta

Re: [PATCH net iproute2 v3 1/2] mpls: always set type as RTN_UNICAST for route add/deletes

2015-06-02 Thread Eric W. Biederman
Roopa Prabhu writes: > From: Roopa Prabhu > > Kernel expects type RTN_UNICAST for mpls route/dels There almost a bug in this patch. You test req.r.rtm_family just before the default case of AF_UNSPEC is set to AF_INET. Which should not affect anything in this case but is down right confusing

Re: [PATCH net v3 2/2] mpls: fix mpls route deletes to not check for route scope

2015-06-02 Thread Eric W. Biederman
Roopa Prabhu writes: > From: Roopa Prabhu > > Ignore scope for route del messages So I just stopped and looked at what is happening. When you originally reported this you said (or at least I understood) that rtm_scope was not being set in iproute. I assumed that meant it was not being touched

Re: How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Hannes Frederic Sowa
On Tue, Jun 2, 2015, at 21:40, Andy Lutomirski wrote: > As far as I can tell, enabling IP_RECVERR causes the presence of a > queued error to cause recvmsg, etc to return an error (once). It's > worse, though: a new error can be queued asynchronously at any time, > this setting sk_err to a nonzero

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Eric W. Biederman
Robert Shearman writes: > On 02/06/15 19:11, Eric W. Biederman wrote: >> Robert Shearman writes: >> >>> In order to be able to function as a Label Edge Router in an MPLS >>> network, it is necessary to be able to take IP packets and impose an >>> MPLS encap and forward them out. The traditional

[PATCH net-next 3/3] net/mlx4_core: fix typo in mlx4_set_vf_mac

2015-06-02 Thread clsoto
From: Carol Soto fix typo in mlx4_set_vf_mac Acked-by: Or Gerlitz Signed-off-by: Carol L Soto --- drivers/net/ethernet/mellanox/mlx4/cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/cmd.c b/drivers/net/ethernet/mellanox/mlx4/cmd.c i

[PATCH net-next 2/3] net/mlx4_core: need to call close fw if alloc icm is called twice

2015-06-02 Thread clsoto
From: Carol Soto If mlx4_enable_sriov is called by adapter without this feature MLX4_DEV_CAP_FLAG2_SYS_EQS then during this path the function alloc icm is called twice without freeing the structures from the first time. Acked-by: Or Gerlitz Signed-off-by: Carol L Soto --- drivers/net/ethernet

[PATCH net-next 1/3] net/mlx4_core: double free of dev_vfs

2015-06-02 Thread clsoto
From: Carol L Soto If user loads mlx4_core with num_vfs greater than supported then variable dev->dev_vfs is freed 2 times after unloading the driver. Acked-by: Or Gerlitz Signed-off-by: Carol L Soto --- drivers/net/ethernet/mellanox/mlx4/main.c | 1 + 1 file changed, 1 insertion(+) diff --g

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread Robert Shearman
On 02/06/15 19:57, roopa wrote: On 6/2/15, 9:33 AM, Robert Shearman wrote: On 02/06/15 17:15, roopa wrote: On 6/1/15, 9:46 AM, Robert Shearman wrote: Allow creating an mpls device for the purposes of encapsulating IP packets with: ip link add type ipmpls This device defines its per-nextho

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Robert Shearman
On 02/06/15 19:11, Eric W. Biederman wrote: Robert Shearman writes: In order to be able to function as a Label Edge Router in an MPLS network, it is necessary to be able to take IP packets and impose an MPLS encap and forward them out. The traditional approach of setting up an interface for ea

[PATCH v5 2/2] Renesas Ethernet AVB PTP clock driver

2015-06-02 Thread Sergei Shtylyov
Ethernet AVB device includes the gPTP timer, so we can implement a PTP clock driver. We're doing that in a separate file, with the main Ethernet driver calling the PTP driver's [de]initialization and interrupt handler functions. Unfortunately, the clock seems tightly coupled with the AVB-DMAC, s

[PATCH v5 1/2] Renesas Ethernet AVB driver proper

2015-06-02 Thread Sergei Shtylyov
Ethernet AVB includes an Gigabit Ethernet controller (E-MAC) that is basically compatible with SuperH Gigabit Ethernet E-MAC. Ethernet AVB has a dedicated direct memory access controller (AVB-DMAC) that is a new design compared to the SuperH E-DMAC. The AVB-DMAC is compliant with 3 standards for

Re: ray_cs: Change 1 to true for bool type variable.

2015-06-02 Thread Kalle Valo
> The variable translate is bool type. So assigning true instead of 1. > > Signed-off-by: Shailendra Verma Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH net-next v3 00/15] sfc: ndo_get_phys_port_id, vadaptor stats and PF unload when Vf's assigned to guest

2015-06-02 Thread David Miller
From: Shradha Shah Date: Tue, 2 Jun 2015 11:36:00 +0100 > This is the third and last instalment of SRIOV for EF10 patches. > > This patch set includes implementation of ndo_get_phys_port_id > and changes to the MAC statistics code in order to support > vadaptor statistics. > > It also includes

Re: [PATCH 00/10] net: thunderx: fix problems reported by static check tools

2015-06-02 Thread David Miller
From: Aleksey Makarov Date: Tue, 2 Jun 2015 11:00:17 -0700 > These are fixes for the problems that were reported by static check tools. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordom

How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Andy Lutomirski
As far as I can tell, enabling IP_RECVERR causes the presence of a queued error to cause recvmsg, etc to return an error (once). It's worse, though: a new error can be queued asynchronously at any time, this setting sk_err to a nonzero value. How do I sensibly distinguish recvmsg failures to to g

Re: [PATCH v4 00/25] Convert the posix_clock_operations and k_clock structure to ready for 2038

2015-06-02 Thread Thomas Gleixner
On Mon, 1 Jun 2015, Baolin Wang wrote: You failed to thread the patch series again -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 00/25] Convert the posix_clock_operations and k_clock structure to ready for 2038

2015-06-02 Thread Thomas Gleixner
On Mon, 1 Jun 2015, Baolin Wang wrote: > This patch series changes the 32-bit time types (timespec/itimerspec) to > the 64-bit types (timespec64/itimerspec64), since 32-bit time types will > break in the year 2038. That's only true for 32bit systems. All in all the patch series looks rather reas

[PATCH] drivers/net/ethernet/dec/tulip/uli526x.c: fix misleading indentation in uli526x_timer

2015-06-02 Thread David Malcolm
This code in drivers/net/ethernet/dec/tulip/uli526x.c function "uli526x_timer": 1086 } else 1087 if ((tmp_cr12 & 0x3) && db->link_failed) { [...snip...] 1109 } 1110 else if(!(tmp_cr12 & 0x3) && db->link_failed)

Re: [net-next RFC 00/14] Convert OVS tunnel vports to use regular net_devices

2015-06-02 Thread Eric W. Biederman
Thomas Graf writes: > This is the first series in a greater effort to bring the scalability > and programmability advantages of OVS to the rest of the network > stack and to get rid of as much OVS specific code as possible. > > This first series focuses on getting rid of OVS tunnel vports and use

Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-02 Thread Scott Feldman
On Tue, Jun 2, 2015 at 9:58 AM, roopa wrote: > On 6/2/15, 7:30 AM, Scott Feldman wrote: >> >> On Tue, Jun 2, 2015 at 4:43 AM, Jamal Hadi Salim wrote: >>> >>> On 06/02/15 03:10, Scott Feldman wrote: >>> >>> Actually, we're now consistent with bridge man page which says master is the defa

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread roopa
On 6/2/15, 9:33 AM, Robert Shearman wrote: On 02/06/15 17:15, roopa wrote: On 6/1/15, 9:46 AM, Robert Shearman wrote: Allow creating an mpls device for the purposes of encapsulating IP packets with: ip link add type ipmpls This device defines its per-nexthop encapsulation data as a stack o

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread roopa
On 6/2/15, 11:30 AM, Eric W. Biederman wrote: roopa writes: On 6/1/15, 9:46 AM, Robert Shearman wrote: In order to be able to function as a Label Edge Router in an MPLS network, it is necessary to be able to take IP packets and impose an MPLS encap and forward them out. The traditional approa

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Eric W. Biederman
roopa writes: > On 6/1/15, 9:46 AM, Robert Shearman wrote: >> In order to be able to function as a Label Edge Router in an MPLS >> network, it is necessary to be able to take IP packets and impose an >> MPLS encap and forward them out. The traditional approach of setting >> up an interface for ea

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread Eric W. Biederman
Robert Shearman writes: > Allow creating an mpls device for the purposes of encapsulating IP > packets with: > > ip link add type ipmpls > > This device defines its per-nexthop encapsulation data as a stack of > labels, in the same format as for RTA_NEWST. It uses the encap data > which will ha

Re: [RFC net-next 1/3] net: infra for per-nexthop encap data

2015-06-02 Thread Eric W. Biederman
Robert Shearman writes: > Having to add a new interface to apply encap onto a packet is a > mechanism that works well today, allowing the setup of the encap to be > done separately from the routes out of them, meaning that routing > protocols and other user-space apps don't need to do anything sp

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Eric W. Biederman
Robert Shearman writes: > In order to be able to function as a Label Edge Router in an MPLS > network, it is necessary to be able to take IP packets and impose an > MPLS encap and forward them out. The traditional approach of setting > up an interface for each "tunnel" endpoint doesn't scale for

Re: [Intel-wired-lan] [PATCH 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-06-02 Thread Rustad, Mark D
> On Jun 2, 2015, at 10:48 AM, Alexander Duyck > wrote: > > I'm pretty sure these could cause some serious errors if you direct assign > the device into a VM since you then end up with multiple devices sharing a > bus. Also it would likely have side-effects on a LOM (Lan On Motherboard) as >

[PATCH 01/10] net: thunderx: Cleanup duplicate NODE_ID macros, add nic_get_node_id()

2015-06-02 Thread Aleksey Makarov
From: Robert Richter There are duplicate NODE_ID macro definitions. Move all of them to nic.h for usage in nic and bgx driver and introduce nic_get_node_id() helper function. This patch also fixes 64bit mask which should have been ULL by reworking the node calculation. Signed-off-by: Robert Ric

[PATCH 02/10] net: thunderx: fix constants

2015-06-02 Thread Aleksey Makarov
This fixes sparse messages like this: drivers/net/ethernet/cavium/thunder/thunder_bgx.c:897:24: sparse: constant 0x3000 is so big it is long Reported-by: kbuild test robot Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 10 +- 1 file change

[PATCH 06/10] net: thunderx: add static

2015-06-02 Thread Aleksey Makarov
This fixes sparse messages like this: drivers/net/ethernet/cavium/thunder/nicvf_main.c:1141:26: sparse: symbol 'nicvf_get_stats64' was not declared. Should it be static? Also remove unused declarations Reported-by: kbuild test robot Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/cavi

[PATCH 09/10] net: thunderx: check if memory allocation was successful

2015-06-02 Thread Aleksey Makarov
This fixes a coccinelle warning: coccinelle warnings: (new ones prefixed by >>) >> drivers/net/ethernet/cavium/thunder/nicvf_queues.c:360:1-11: alloc >> with no test, possible model on line 367 vim +360 drivers/net/ethernet/cavium/thunder/nicvf_queues.c 354 err = nicvf_alloc_q_desc_

[PATCH 10/10] net: thunderx: use GFP_KERNEL in thread context

2015-06-02 Thread Aleksey Makarov
GFP_KERNEL should be used in the thread context Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c b/drivers/net/ethernet/cavium/thunder/nicv

[PATCH 08/10] net: thunderx: remove unneeded type conversions

2015-06-02 Thread Aleksey Makarov
No need to cast void* to u8*: pointer arithmetics works same way for both. Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c b/drivers/net

[PATCH 05/10] net: thunderx: delete unused variables

2015-06-02 Thread Aleksey Makarov
They were left from development stage Reported-by: kbuild test robot Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c b/drivers/net/ethe

[PATCH 04/10] net: thunderx: rework mac address handling

2015-06-02 Thread Aleksey Makarov
This fixes sparse message: drivers/net/ethernet/cavium/thunder/nicvf_main.c:385:40: sparse: cast to restricted __le64 Reported-by: kbuild test robot Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/cavium/thunder/nic.h | 4 ++-- drivers/net/ethernet/cavium/thunder/nic_main.c

[PATCH 07/10] net: thunderx: fix nicvf_set_rxfh()

2015-06-02 Thread Aleksey Makarov
This fixes a copypaste bug that was discovered by a static analysis tool: The patch 4863dea3fab0: "net: Adding support for Cavium ThunderX network controller" from May 26, 2015, leads to the following static checker warning: drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c:517 nicvf_se

[PATCH 03/10] net: thunderx: introduce a function for mailbox access

2015-06-02 Thread Aleksey Makarov
This fixes sparse message: drivers/net/ethernet/cavium/thunder/nicvf_main.c:153:25: sparse: cast to restricted __le64 Reported-by: kbuild test robot Signed-off-by: Aleksey Makarov --- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 27 +++- 1 file changed, 17 insertions(

[PATCH 00/10] net: thunderx: fix problems reported by static check tools

2015-06-02 Thread Aleksey Makarov
These are fixes for the problems that were reported by static check tools. Aleksey Makarov (9): net: thunderx: fix constants net: thunderx: introduce a function for mailbox access net: thunderx: rework mac address handling net: thunderx: delete unused variables net: thunderx: add static

[PATCH net-next V10 1/4] openvswitch: 802.1ad uapi changes.

2015-06-02 Thread Thomas F Herbert
openvswitch: Add support for 8021.AD Change the description of the VLAN tpid field. Signed-off-by: Thomas F Herbert --- include/uapi/linux/openvswitch.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/op

Re: [ovs-dev] [net-next RFC 00/14] Convert OVS tunnel vports to use regular net_devices

2015-06-02 Thread Flavio Leitner
It seems patch 01 didn't make it to ovs dev mailing list, but it is available on netdev mailing list. fbl -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH net-next V10 3/4] 802.1AD: Flow handling, actions and vlan parsing

2015-06-02 Thread Thomas F Herbert
Add support for 802.1ad including the ability to push and pop double tagged vlans. Signed-off-by: Thomas F Herbert --- net/openvswitch/flow.c | 82 ++ net/openvswitch/flow.h | 3 ++ 2 files changed, 73 insertions(+), 12 deletions(-) diff --git a/

[PATCH net-next V10 0/4] openvswitch: Add support for 802.1AD

2015-06-02 Thread Thomas F Herbert
Add support for 802.1AD to the openvswitch kernel module. V10: Implement reviewer comments: Consolidate vlan parsing functions. Splits netlink parsing and flow conversion into a separate patch. Uses double encap attribute encapsulation for 802.1ad. Netlink attributes now look like this: eth_

[PATCH net-next V10 2/4] General check for vlan ethernet types

2015-06-02 Thread Thomas F Herbert
This patch adds a function to check for vlan ethernet types. There is a use case in openvswitch and it should be useful elsewhere. Signed-off-by: Thomas F Herbert --- include/linux/if_vlan.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/if_vlan.h b/include/linux/if_v

[PATCH net-next V10 4/4] 8021AD: Flow key parsing and netlink attributes.

2015-06-02 Thread Thomas F Herbert
Add support for 802.1ad to netlink parsing and flow conversation. Uses double nested encap attributes to represent double tagged vlan. Signed-off-by: Thomas F Herbert --- net/openvswitch/flow_netlink.c | 186 ++--- 1 file changed, 157 insertions(+), 29 deletio

Re: [Intel-wired-lan] [PATCH 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-06-02 Thread Alexander Duyck
On 06/02/2015 10:04 AM, Mark D Rustad wrote: Add a dev_flags bit, PCI_DEV_FLAGS_VPD_REF_F0, to access VPD through function 0 to provide VPD access on other functions. This solves concurrent access problems on many devices without changing the attributes exposed in sysfs. Never set this bit on fun

Re: [PATCH net-next] bridge: skip fdb add if the port shouldn't learn

2015-06-02 Thread roopa
On 5/27/15, 9:01 AM, Scott Feldman wrote: On Wed, May 27, 2015 at 1:35 AM, Nikolay Aleksandrov wrote: On Wed, May 27, 2015 at 9:59 AM, Scott Feldman wrote: On Wed, May 27, 2015 at 12:05 AM, Nikolay Aleksandrov wrote: On Tue, May 26, 2015 at 7:28 PM, Stephen Hemminger wrote: On Thu, 21 May

BOOKING=============

2015-06-02 Thread Mr David Brink
I am writing you this email to make reservations for my family at your hotel. Arrival day : 15/06/2015 Departure day: 30/06/2015 Number Of Gusts: 4 Adult Kindly send the total quotation so as to forward my card for the full payment only. Thanks Mr David Brink -- To unsubscribe from this list: se

[PATCH 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-06-02 Thread Mark D Rustad
Add a dev_flags bit, PCI_DEV_FLAGS_VPD_REF_F0, to access VPD through function 0 to provide VPD access on other functions. This solves concurrent access problems on many devices without changing the attributes exposed in sysfs. Never set this bit on funciton 0 or there will be an infinite recursion.

[PATCH 0/2] pci: Provide a flag to access VPD through function 0

2015-06-02 Thread Mark D Rustad
Many multi-function devices provide shared registers in extended config space for accessing VPD. The behavior of these registers means that the state must be tracked and access locked correctly for accesses not to hang or worse. One way to meet these needs is to always perform the accesses through

[PATCH 2/2] pci: Add VPD quirk for Intel Ethernet devices

2015-06-02 Thread Mark D Rustad
This quirk sets the PCI_DEV_FLAGS_VPD_REF_F0 flag on all Intel Ethernet device functions other than function 0. Signed-off-by: Mark Rustad --- drivers/pci/quirks.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index c6dc1dfd25d5..9ddf

Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-02 Thread roopa
On 6/2/15, 7:30 AM, Scott Feldman wrote: On Tue, Jun 2, 2015 at 4:43 AM, Jamal Hadi Salim wrote: On 06/02/15 03:10, Scott Feldman wrote: Actually, we're now consistent with bridge man page which says master is the default. Want we want, I believe, is to adjust what the man page says (and th

Re: [RFC net-next 2/3] ipv4: storing and retrieval of per-nexthop encap

2015-06-02 Thread Robert Shearman
On 02/06/15 17:01, roopa wrote: On 6/1/15, 9:46 AM, Robert Shearman wrote: Parse RTA_ENCAP attribute for one path and multipath routes. The encap length is stored in a newly added field to fib_nh, nh_encap_len, although this is added to a padding hole in the structure so that it doesn't increase

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread Robert Shearman
On 02/06/15 17:15, roopa wrote: On 6/1/15, 9:46 AM, Robert Shearman wrote: Allow creating an mpls device for the purposes of encapsulating IP packets with: ip link add type ipmpls This device defines its per-nexthop encapsulation data as a stack of labels, in the same format as for RTA_NEWS

Re: [Xen-devel] "tcp: refine TSO autosizing" causes performance regression on Xen

2015-06-02 Thread Eric Dumazet
On Tue, 2015-06-02 at 10:52 +0100, Wei Liu wrote: > Hi Eric > > Sorry for coming late to the discussion. > > On Thu, Apr 16, 2015 at 05:42:16AM -0700, Eric Dumazet wrote: > > On Thu, 2015-04-16 at 11:01 +0100, George Dunlap wrote: > > > > > He suggested that after he'd been prodded by 4 more e-m

  1   2   >