Re: [PATCH v3 net-next 3/4] rocker: do not make neighbour entry changes when preparing transactions

2015-05-19 Thread Jiri Pirko
Wed, May 20, 2015 at 07:48:21AM CEST, simon.hor...@netronome.com wrote: >rocker_port_ipv4_nh() and in turn rocker_port_ipv4_neigh() may be >be called with trans == SWITCHDEV_TRANS_PREPARE and then >trans == SWITCHDEV_TRANS_COMMIT from switchdev_port_obj_set() via >fib_table_insert(). > >The first t

Re: [PATCH v3 net-next 2/4] rocker: do not modify fdb table in rocker_port_fdb() when preparing transactions

2015-05-19 Thread Jiri Pirko
Wed, May 20, 2015 at 07:48:20AM CEST, simon.hor...@netronome.com wrote: >rocker_port_fdb_flush() may be called be called with >trans == SWITCHDEV_TRANS_PREPARE and then trans == SWITCHDEV_TRANS_COMMIT from >switchdev_port_attr_set() via switchdev_port_obj_add(). > >Adding the new entry to the FDB t

[PATCH v3 net-next 0/4] rocker: transaction fixes

2015-05-19 Thread Simon Horman
Hi, this series addresses what appear to be errors in the handling of prepare and then commit transactions in the rocker driver. In all cases the problem is that data structures visible outside of the transaction are modified during the prepare phase. In the case of the first two patches this re

Re: [PATCH v2] net: fix a double free issue for neighbour entry

2015-05-19 Thread Eric Dumazet
On Wed, 2015-05-20 at 09:25 +0800, Ying Xue wrote: > Calling __ipv4_neigh_lookup_noref() inside rcu_read_lock_bh() can > guarantee that its searched neighbour entry is not freed before RCU > grace period, but it cannot ensure that its obtained neighbour will > be freed shortly. Exactly saying, it c

Re: iptables: ensure number of counters is >0 in do_replace()

2015-05-19 Thread David Miller
From: Dave Jones Date: Tue, 19 May 2015 19:42:52 -0400 > What's the preferred format, 8 separate patches, or 1 all-in-one > diff for all instances of this bug ? Personally, I think you could do this in one patch. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

RE: [PATCH v3 for-next 05/13] IB/cm: Reference count ib_cm_ids

2015-05-19 Thread Hefty, Sean
> I find Haggai's argument compelling, it is a very small amount of code > and data to add a sharing count, and a very large amount to duplicate > the whole service id map into cma.c. I get wanting to share the listen list, but we end up with this: > drivers/infiniband/core/cm.c

Re: [Intel-wired-lan] [PATCH] pci: Limit VPD reads for all Intel Ethernet devices

2015-05-19 Thread Rustad, Mark D
> On May 19, 2015, at 2:17 PM, Alexander Duyck > wrote: > > Any chance you could point me toward the software in question? Just > wondering because it seems like what you are fixing with this is an > implementation issue in the application since you really shouldn't be > accessing areas outs

Re: [PATCH v4 for-next 05/12] IB/cm: Share listening CM IDs

2015-05-19 Thread Jason Gunthorpe
On Tue, May 19, 2015 at 12:35:45PM -0600, Jason Gunthorpe wrote: > On Sun, May 17, 2015 at 08:51:01AM +0300, Haggai Eran wrote: > > @@ -212,6 +212,8 @@ struct cm_id_private { > > spinlock_t lock;/* Do not acquire inside cm.lock */ > > struct completion comp; > > atomic_t refcoun

Re: [PATCH net-next 3/4] rocker: do not make neighbour entry changes when preparing transactions

2015-05-19 Thread Simon Horman
On Tue, May 19, 2015 at 09:11:29AM -0700, Scott Feldman wrote: > On Mon, May 18, 2015 at 11:24 PM, Simon Horman > wrote: > > rocker_port_ipv4_nh() and in turn rocker_port_ipv4_neigh() may be > > be called with trans == SWITCHDEV_TRANS_PREPARE and then > > trans == SWITCHDEV_TRANS_COMMIT from switc

Re: Kernel crash while using tc script

2015-05-19 Thread Daniel Borkmann
On 05/19/2015 10:11 PM, Vijay Subramanian wrote: Hi, It seems latest net-next kernel crashes while unloading modules. Please see simple script below to reproduce the crash. === #!/bin/bash while true; do # modules will be loaded automatically tc qdisc add dev eth

Re: [PATCH] ip: remove unused function prototype

2015-05-19 Thread David Miller
From: Andy Zhou Date: Tue, 19 May 2015 12:41:47 -0700 > ip_do_nat() function was removed prior to kernel 3.4. Remove the > unnecessary function prototype as well. > > Reported-by: Florian Westphal > Signed-off-by: Andy Zhou Applied, thank you. -- To unsubscribe from this list: send the line "

Re: [PATCH net-next v3] tcp: add rfc3168, section 6.1.1.1. fallback

2015-05-19 Thread David Miller
From: Daniel Borkmann Date: Tue, 19 May 2015 21:33:42 +0200 > This work as a follow-up of commit f7b3bec6f516 ("net: allow setting ecn > via routing table") and adds RFC3168 section 6.1.1.1. fallback for outgoing > ECN connections. In other words, this work adds a retry with a non-ECN > setup SYN

Re: [PATCH net-next 0/4] sfc: add MCDI tracing

2015-05-19 Thread David Miller
From: Edward Cree Date: Tue, 19 May 2015 18:33:55 +0100 > This patchset adds support for logging Management-Controller-to-Driver > Interface interactions between the sfc driver and a bound device, to aid in > debugging. > Solarflare has a tool to decode the resulting traces and will look to >

Re: [PATCH net v3 2/2] ipv6: fix ECMP route replacement

2015-05-19 Thread David Miller
From: Michal Kubecek Date: Mon, 18 May 2015 20:54:00 +0200 (CEST) > When replacing an IPv6 multipath route with "ip route replace", i.e. > NLM_F_CREATE | NLM_F_REPLACE, fib6_add_rt2node() replaces only first > matching route without fixing its siblings, resulting in corrupted > siblings linked li

Re: Default XPS settings in mlx4 driver

2015-05-19 Thread David Miller
From: Tom Herbert Date: Tue, 19 May 2015 13:38:35 -0700 > Looks like there's a few other drivers that are setting XPS, they > might have similar issue. We really need generic infrastructure for such configuration attempts so that the default policy across all such drivers is consistent. -- To un

Re: [PATCHv2 net-next 0/2] Remove dead code and replace byte-oder functions

2015-05-19 Thread David Miller
From: Hariprasad Shenai Date: Tue, 19 May 2015 18:20:42 +0530 > This series removes dead fn t4_read_edc and t4_read_mc, also replaces > ntoh{s,l} and hton{s,l} calls with the generic byteorder. > > PATCH 2/2 was sent as a single PATCH, but had some byte-ordering issues > in t4_read_edc and t4_re

Re: [PATCH] irda: irda-usb: use msecs_to_jiffies for conversions

2015-05-19 Thread David Miller
From: Joe Perches Date: Tue, 19 May 2015 07:32:15 -0700 > On Tue, 2015-05-19 at 12:51 +0200, Nicholas Mc Guire wrote: >> Converting milliseconds to jiffies by "val * HZ / 1000" is technically >> is not a clean solution as it does not handle all corner cases correctly. >> By changing the conversio

Re: pull-request: mac80211 2015-05-19

2015-05-19 Thread David Miller
From: Johannes Berg Date: Tue, 19 May 2015 09:22:34 +0200 > And one more - for the current cycle (and stable as well). > > Let me know if there's any problem. Also pulled, thanks Johannes. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...

Re: pull-request: mac80211-next 2015-05-19

2015-05-19 Thread David Miller
From: Johannes Berg Date: Tue, 19 May 2015 09:20:39 +0200 > Hi Dave, > My last pull request introduced two bugs, and we found two more that > were present earlier, so I have four bug fixes now. > > Please pull. Pulled, thanks Johannes. -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH] be2net: make hwmon interface optional

2015-05-19 Thread David Miller
From: Arnd Bergmann Date: Mon, 18 May 2015 23:06:45 +0200 > The hwmon interface in the be2net driver causes a link error when > be2net is built-in while the hwmon subsystem is a loadable module: > > drivers/built-in.o: In function `be_probe': > drivers/net/ethernet/emulex/benet/be_main.c:5761: u

Default XPS settings in mlx4 driver

2015-05-19 Thread Tom Herbert
Hi Ido, I'm looking at your patch "net/mlx4_en: Configure the XPS queue mapping on driver load". We're testing a 40 CPU system and it looks like XPS is being configured by default with forty queues 0-39 where each xps_cpus is (1 << i). The problem is that this does not easily align with RX queues

Re: [PATCH net 2/2] tcp: don't over-send F-RTO probes

2015-05-19 Thread David Miller
From: Yuchung Cheng Date: Mon, 18 May 2015 12:31:45 -0700 > After sending the new data packets to probe (step 2), F-RTO may > incorrectly send more probes if the next ACK advances SND_UNA and > does not sack new packet. However F-RTO RFC 5682 probes at most > once. This bug may cause sender to al

Re: [PATCH net 1/2] tcp: only undo on partial ACKs in CA_Loss

2015-05-19 Thread David Miller
From: Yuchung Cheng Date: Mon, 18 May 2015 12:31:44 -0700 > Undo based on TCP timestamps should only happen on ACKs that advance > SND_UNA, according to the Eifel algorithm in RFC 3522: > > Section 3.2: > > (4) If the value of the Timestamp Echo Reply field of the > acceptable ACK's Tim

Re: [PATCH] net/ipv6/udp: Fix ipv6 multicast socket filter regression

2015-05-19 Thread David Miller
From: Henning Rogge Date: Mon, 18 May 2015 21:08:49 +0200 > Commit <5cf3d46192fc> ("udp: Simplify__udp*_lib_mcast_deliver") > simplified the filter for incoming IPv6 multicast but removed > the check of the local socket address and the UDP destination > address. > > This patch restores the filte

Re: [PATCH net-next] tcp: Return error instead of partial read for saved syn headers

2015-05-19 Thread David Miller
From: Eric B Munson Date: Mon, 18 May 2015 14:35:58 -0400 > Currently the getsockopt() requesting the cached contents of the syn > packet headers will fail silently if the caller uses a buffer that is > too small to contain the requested data. Rather than fail silently and > discard the headers,

Re: [PATCH] net-next: ethtool: Added port speed macros.

2015-05-19 Thread David Miller
From: David Miller Date: Tue, 19 May 2015 14:52:02 -0400 (EDT) > Given that I should probably accept this patch set as well, hopefully > we won't get very many more of these any time soon. And that's what I've just done. Applied to net-next, thanks. -- To unsubscribe from this list: send the li

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-19 Thread David Miller
From: Andy Gospodarek Date: Tue, 19 May 2015 15:47:32 -0400 > Are you actually saying that if users complain loudly enough about > the current behavior (not the change Roopa has proposed) that you > would be open to considering a change the current behavior? I am saying that we have a contract w

Re: [PATCH] net-next: ethtool: Added port speed macros.

2015-05-19 Thread David Miller
From: Ben Hutchings Date: Tue, 19 May 2015 18:00:35 +0100 > On Mon, 2015-05-18 at 11:46 -0400, David Miller wrote: >> From: Parav Pandit >> Date: Mon, 18 May 2015 16:31:47 +0530 >> >> > Signed-off-by: Parav Pandit >> >> I thought we had decided that we weren't going to keep adding >> convenie

Re: [Intel-wired-lan] [PATCH] pci: Limit VPD reads for all Intel Ethernet devices

2015-05-19 Thread Rustad, Mark D
> On May 19, 2015, at 10:50 AM, Alexander Duyck > wrote: > > These two patches are very much related. They are only related because I saw an opportunity to do this while working on the other issue. That is the only relationship. >>> Artificially limiting the size of the VPD does nothing but

Re: [PATCH v4 1/2] Renesas Ethernet AVB driver proper

2015-05-19 Thread David Miller
From: Sergei Shtylyov Date: Sun, 17 May 2015 23:52:42 +0300 > +/* Packet transmit function for Ethernet AVB */ > +static netdev_tx_t ravb_start_xmit(struct sk_buff *skb, struct net_device > *ndev) > +{ ... > + spin_lock_irqsave(&priv->lock, flags); > + if (priv->cur_tx[q] - priv->dirty_

Re: [Intel-wired-lan] [PATCH] pci: Use a bus-global mutex to protect VPD operations

2015-05-19 Thread Alexander Duyck
On 05/18/2015 05:00 PM, Mark D Rustad wrote: Some devices have a problem with concurrent VPD access to different functions of the same physical device, so move the protecting mutex from the pci_vpd structure to the pci_bus structure. There are a number of reports on support sites for a variety

[PATCH net-next 4/4] sfc: Initialise MCDI buffers to 0 on declaration.

2015-05-19 Thread Edward Cree
From: Jon Cooper Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/ef10.c | 24 +--- drivers/net/ethernet/sfc/mcdi.c | 8 drivers/net/ethernet/sfc/mcdi.h | 8 +--- drivers/net/ethernet/sfc/ptp.c | 6 +++--- 4 files changed, 25 insertions(+), 21 deletio

Re: [PATCH net-next V4 00/12] net/mlx5: ConnectX-4 100G Ethernet driver

2015-05-19 Thread David Miller
From: Amir Vadai Date: Tue, 19 May 2015 12:25:12 +0300 > On Sun, May 17, 2015 at 8:05 PM, David Miller wrote: >> From: Amir Vadai >> Date: Sun, 17 May 2015 16:02:11 +0300 >> >>> We didn't get a response yet regarding your comment about the irq >>> renaming [3]. >> >> Well then, please hold off

Re: [PATCH net v2] switchdev: don't abort hardware ipv4 fib offload on failure to program fib entry in hardware

2015-05-19 Thread David Miller
From: roopa Date: Mon, 18 May 2015 22:58:54 -0700 > from where I see, with the limitations on these boxes, this requires > every app, every `ip route` cmd running on the box to explicitly > specify offload when running on this hardware. Users know what they are doing, and will ask for a policy c

Re: [PATCH] net-next: ethtool: Added port speed macros.

2015-05-19 Thread David Miller
From: Parav Pandit Date: Tue, 19 May 2015 10:15:49 +0530 > On Mon, May 18, 2015 at 9:16 PM, David Miller wrote: >> From: Parav Pandit >> Date: Mon, 18 May 2015 16:31:47 +0530 >> >>> Signed-off-by: Parav Pandit >> >> I thought we had decided that we weren't going to keep adding >> convenience m

Re: [PATCH net-next 4/4] rocker: make rocker_port_internal_vlan_id_{get,put}() non-transactional

2015-05-19 Thread Scott Feldman
On Mon, May 18, 2015 at 11:24 PM, Simon Horman wrote: > The motivation for this is that rocker_port_internal_vlan_id_{get,put} appear > to only partially implement the transaction model: memory allocation > and freeing is transactional, but hash and bitmap manipulation is not. > > The latter could

Re: [RFC PATCH 06/13] xen-netback: copy buffer on xenvif_start_xmit()

2015-05-19 Thread Wei Liu
On Tue, May 12, 2015 at 07:18:30PM +0200, Joao Martins wrote: > By introducing persistent grants we speed up the RX thread with the > decreased copy cost, that leads to a throughput decrease of 20%. > It is observed that the rx_queue stays mostly at 10% of its capacity, > as opposed to full capacit

Re: [RFC PATCH 02/13] xen-netback: xenbus feature persistent support

2015-05-19 Thread Wei Liu
On Tue, May 12, 2015 at 07:18:26PM +0200, Joao Martins wrote: > Checks for "feature-persistent" that indicates persistent grants > support. Adds max_persistent_grants module param that specifies the max > number of persistent grants, which if set to zero disables persistent > grants. > > Signed-of

Re: [Xen-devel] [RFC 12/23] xen: Extend page_to_mfn to take an offset in the page

2015-05-19 Thread Julien Grall
Hi David, On 19/05/15 14:57, David Vrabel wrote: > On 14/05/15 18:00, Julien Grall wrote: >> With 64KB page granularity support in Linux, a page will be split accross >> multiple MFN (Xen is using 4KB page granularity). Thoses MFNs may not be >> contiguous. >> >> With the offset in the page, the h

Re: [PATCH V6 05/10] audit: log creation and deletion of namespace instances

2015-05-19 Thread Richard Guy Briggs
On 15/05/16, Paul Moore wrote: > On Sat, May 16, 2015 at 10:46 AM, Eric W. Biederman > wrote: > > Paul Moore writes: > >> On Sat, May 16, 2015 at 5:46 AM, Daniel J Walsh wrote: > >>> On 05/15/2015 05:05 PM, Paul Moore wrote: > On Thursday, May 14, 2015 11:23:09 PM Andy Lutomirski wrote: > >

Re: [PATCH] vhost: support upto 509 memory regions

2015-05-19 Thread Igor Mammedov
On Mon, 18 May 2015 19:22:34 +0300 Andrey Korolyov wrote: > On Wed, Feb 18, 2015 at 7:27 AM, Michael S. Tsirkin wrote: > > On Tue, Feb 17, 2015 at 04:53:45PM -0800, Eric Northup wrote: > >> On Tue, Feb 17, 2015 at 4:32 AM, Michael S. Tsirkin > >> wrote: > >> > On Tue, Feb 17, 2015 at 11:59:48A

Re: [Xen-devel] [RFC PATCH 12/13] xen-netfront: implement TX persistent grants

2015-05-19 Thread Joao Martins
On 18 May 2015, at 17:55, David Vrabel wrote: > On 12/05/15 18:18, Joao Martins wrote: >> Instead of grant/revoking the buffer related to the skb, it will use >> an already granted page and memcpy to it. The grants will be mapped >> by xen-netback and reused overtime, but only unmapped when the

Re: [PATCH] Experimental new bonding driver mode=batman

2015-05-19 Thread Michal Kubecek
On Tue, May 19, 2015 at 02:09:43AM -0400, Patrick Simmons wrote: > > I've written a new mode for the kernel bonding driver. It's similar to > the round-robin mode, but it keeps statistics on TCP resends so as to > favor slave devices with more bandwidth when choosing where to send > packets. I'v

pull-request: mac80211 2015-05-19

2015-05-19 Thread Johannes Berg
Hi Dave, And one more - for the current cycle (and stable as well). Let me know if there's any problem. johannes The following changes since commit ff419b3f95ab7a97c5f72876b53f12a249dacc2a: mac80211: fix 90 kernel-doc warnings (2015-05-04 12:56:13 +0200) are available in the git repository