Re: rhashtable: Add cap on number of elements in hash table

From: Herbert Xu Date: Fri, 15 May 2015 14:30:57 +0800 > On Thu, May 14, 2015 at 11:46:15PM -0400, David Miller wrote: >> >> We wouldn't fail these inserts in any other hash table in the kernel. >> >> Would we stop making new TCP sockets if the TCP ehash chains are 3 >> entries deep? 4? 5? T

Re: [v2 PATCH] rhashtable: Add cap on number of elements in hash table

From: Herbert Xu Date: Fri, 15 May 2015 11:30:47 +0800 > We currently have no limit on the number of elements in a hash table. > This is a problem because some users (tipc) set a ceiling on the > maximum table size and when that is reached the hash table may > degenerate. Others may encounter OO

Re: [PATCH net-next] sfc: nicer log message on Siena SR-IOV probe fail

From: Edward Cree Date: Fri, 15 May 2015 20:56:35 +0100 > We expect that MC_CMD_SRIOV will fail if the card has no VFs configured. > So output a readable message instead of a cryptic MCDI error. Please resubmit this patch with a proper "Signed-off-by: " tag. Thank you. -- To unsubscribe from th

Re: [PATCH 1/3] ipv6: make inet6addr_chain blocking and always call with rtnl locked

From: Konstantin Khlebnikov Date: Thu, 14 May 2015 16:56:18 +0300 > Unlike to inetaddr_chain inet6addr_chain is atomic and called from bh > context without rtnl when ipv6 receives router advertisement packet. > > Several drivers don't know about that: ipvlan thinks that it has rtnl > here, ocrdm

Re: [PATCH net v2 2/2] ipv6: fix ECMP route replacement

From: Michal Kubecek Date: Fri, 15 May 2015 19:41:56 +0200 > The semantics I suggested in my previous mail might be a reasonable > approximation. Ok, then let's try for that. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.or

Re: [PATCH] net: phy: Make sure PHY_RESUMING state change is always processed

From: Florian Fainelli Date: Fri, 15 May 2015 14:25:49 -0700 > On 12/05/15 18:55, Tim Beale wrote: >> If phy_start_aneg() was called while the phydev is in the PHY_RESUMING >> state, then its state would immediately transition to PHY_AN (or >> PHY_FORCING). This meant the phy_state_machine() neve

Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id

From: Bjorn Helgaas Date: Sat, 16 May 2015 09:49:40 -0500 > Hi Aleksey, > > On Fri, May 15, 2015 at 10:36 PM, Aleksey Makarov > wrote: >> Signed-off-by: Aleksey Makarov >> --- >> include/linux/pci_ids.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/include/linux/pci_ids.h b/in

Re: [net PATCH] ip_vti/ip6_vti: Clear skb->mark when resetting skb->dev in receive path

From: Herbert Xu Date: Sat, 16 May 2015 20:34:58 +0800 > On Fri, May 15, 2015 at 12:14:43PM -0700, Alexander Duyck wrote: >> >> >Yeah, this mark handling via tunnel->parms.o_key looks not so good. >> >> So is there any recommendations for an alternative to make it so >> that the ipsec endpoint i

Re: netlink: Disable insertions/removals during rehash

From: Herbert Xu Date: Sat, 16 May 2015 21:16:28 +0800 > On Fri, May 15, 2015 at 01:02:57PM -0400, David Miller wrote: >> From: Herbert Xu >> Date: Thu, 14 May 2015 13:58:24 +0800 >> >> > The current rhashtable rehash code is buggy and can't deal with >> > parallel insertions/removals without c

Re: [net] netlink: Reset portid after netlink_insert failure

From: Herbert Xu Date: Sat, 16 May 2015 21:50:28 +0800 > The commit c5adde9468b0714a051eac7f9666f23eb10b61f7 ("netlink: > eliminate nl_sk_hash_lock") breaks the autobind retry mechanism > because it doesn't reset portid after a failed netlink_insert. > > This means that should autobind fail the

Re: [net] netlink: Make autobind rover an atomic_t

From: Herbert Xu Date: Sat, 16 May 2015 21:40:07 +0800 > The commit 21e4902aea80ef35afc00ee8d2abdea4f519b7f7 ("netlink: > Lockless lookup with RCU grace period in socket release") removed > the locks around the autobind rover without making the rover itself > safe for use by multiple threads. >

Re: netlink: Kill bogus lock_sock in netlink_insert

From: Eric Dumazet Date: Sat, 16 May 2015 09:50:11 -0700 > Maybe the difference between 3.15 and 4.1 is not coming from > rhashtable/netlink but other core stuff, like mutex code. > > The workload is largely dominated by mutex acquisition anyway. Hmmm, the only commit that sticks out for me in

Re: [PATCH net-next v2] net: phy: Add state machine state transitions debug prints

From: Florian Fainelli Date: Sat, 16 May 2015 10:17:56 -0700 > It can be useful to debug the PHY state machine, add dynamic debug > prints of the old and new PHY devices state under a friendly format. > > Signed-off-by: Florian Fainelli Applied, thanks Florian. -- To unsubscribe from this list

Re: [PATCH 0/4] Netfilter fixes for net

From: Pablo Neira Ayuso Date: Sat, 16 May 2015 20:47:14 +0200 > The following patchset contains Netfilter fixes for your net tree, they are: > > 1) Fix a leak in IPVS, the sysctl table is not released accordingly when >destroying a netns, patch from Tommi Rantala. > > 2) Fix a build error w

[PATCH 4/4] netfilter: nf_tables: fix bogus warning in nft_data_uninit()

From: Mirek Kratochvil The values 0x-0xfeff are reserved for userspace datatype. When, deleting set elements with maps, a bogus warning is triggered. WARNING: CPU: 0 PID: 11133 at net/netfilter/nf_tables_api.c:4481 nft_data_uninit+0x35/0x40 [nf_tables]() This fixes the check accord

Re: [PATCH net-next v3 1/2] pci: Add Cavium PCI vendor id

Hi Aleksey, On Fri, May 15, 2015 at 10:36 PM, Aleksey Makarov wrote: > Signed-off-by: Aleksey Makarov > --- > include/linux/pci_ids.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index e63c02a..3633cc6 100644 > --- a/include/linu

Re: [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency

On Fri, May 15, 2015 at 4:23 PM, Suravee Suthikulpanit wrote: > This patch refactors of_pci_dma_configure() into a more generic > pci_dma_configure(), which can be reused by non-OF code. > Then, it adds support for setting up PCI device DMA coherency from > ACPI _CCA object that should normally be