Re: [PATCH net-next v2] be2net: log link status

2015-04-22 Thread Ivan Vecera
On 04/23/2015 08:31 AM, Sathya Perla wrote: -Original Message- From: Ivan Vecera [mailto:ivec...@redhat.com] The driver unlike other drivers does not log link state changes. v2: added current link speed to log message Ivan, I disagree with the v2 change. I think your original intentio

RE: [PATCH net-next v2] be2net: log link status

2015-04-22 Thread Sathya Perla
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > > On Wed, 2015-04-22 at 15:43 +0200, Ivan Vecera wrote: > > The driver unlike other drivers does not log link state changes. > ... > > Question for the emulex folk: > > Is the dom argument to link_status_query necessar

RE: [PATCH net-next v2] be2net: log link status

2015-04-22 Thread Sathya Perla
> -Original Message- > From: Ivan Vecera [mailto:ivec...@redhat.com] > > The driver unlike other drivers does not log link state changes. > > v2: added current link speed to log message > Ivan, I disagree with the v2 change. I think your original intention was just to log a message when

RE: [PATCH] net/phy: refactor RTL8211F initialization

2015-04-22 Thread shengzhou....@freescale.com
> -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Thursday, April 23, 2015 12:39 PM > To: Liu Shengzhou-B36685; netdev@vger.kernel.org; joe.hershber...@gmail.com > Subject: Re: [PATCH] net/phy: refactor RTL8211F initialization > > Le 22/04/2015 20:53, shen

[PATCHv2] ibmveth: Fix off-by-one error in ibmveth_change_mtu()

2015-04-22 Thread David Gibson
AFAIK the PAPR document which defines the virtual device interface used by the ibmveth driver doesn't specify a specific maximum MTU. So, in the ibmveth driver, the maximum allowed MTU is determined by the maximum allocated buffer size of 64k (corresponding to one page in the common case) minus th

Re: [PATCH] net/phy: refactor RTL8211F initialization

2015-04-22 Thread Florian Fainelli
Le 22/04/2015 20:53, shengzhou@freescale.com a écrit : >> -Original Message- >> From: Florian Fainelli [mailto:f.faine...@gmail.com] >> Sent: Thursday, April 23, 2015 12:57 AM >> To: Liu Shengzhou-B36685; netdev@vger.kernel.org; joe.hershber...@gmail.com >> Subject: Re: [PATCH] net/phy:

RE: [PATCH] net/phy: refactor RTL8211F initialization

2015-04-22 Thread shengzhou....@freescale.com
> -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Thursday, April 23, 2015 12:57 AM > To: Liu Shengzhou-B36685; netdev@vger.kernel.org; joe.hershber...@gmail.com > Subject: Re: [PATCH] net/phy: refactor RTL8211F initialization > > On 22/04/15 03:22, Shengz

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Alexander Duyck
On 04/22/2015 04:23 PM, Cong Wang wrote: > On Wed, Apr 22, 2015 at 3:34 PM, Alexander Duyck > wrote: >> On 04/22/2015 02:56 PM, Cong Wang wrote: >>> On Wed, Apr 22, 2015 at 2:42 PM, Alexander Duyck >>> wrote: On 04/22/2015 01:33 PM, Cong Wang wrote: > First, make sure you don't miss the

Re: CCM/GCM implementation defect

2015-04-22 Thread David Miller
From: Herbert Xu Date: Thu, 23 Apr 2015 11:26:20 +0800 > In order to fix this without breaking backwards compatibility, > my plan is to introduce new templates such as rfc4106v2 which > implement the RFC correctly. The existing templates will be > retained so that current users aren't broken by

CCM/GCM implementation defect

2015-04-22 Thread Herbert Xu
Hi: It looks like our IPsec implementations of CCM and GCM are buggy in that they don't include the IV in the authentication calculation. This definitely breaks interoperability with anyone who implements them correctly. The fact that there have been no reports on this probably means that nobody

[PATCH] xfrm: fix the return code when xfrm_*_register_afinfo failed

2015-04-22 Thread roy . qing . li
From: Li RongQing If xfrm_*_register_afinfo failed since xfrm_*_afinfo[afinfo->family] had the value, return the -EEXIST, not -ENOBUFS Signed-off-by: Li RongQing --- net/xfrm/xfrm_input.c | 2 +- net/xfrm/xfrm_policy.c | 2 +- net/xfrm/xfrm_state.c | 2 +- 3 files changed, 3 insertions(+), 3

Re: [RFC 2/3] tc: deprecate TC_ACT_QUEUED

2015-04-22 Thread Alexei Starovoitov
On 4/22/15 4:39 PM, Cong Wang wrote: On Wed, Apr 22, 2015 at 3:22 PM, Alexei Starovoitov wrote: On 4/21/15 10:02 PM, Cong Wang wrote: On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov wrote: TC_ACT_QUEUED was always an alias of TC_ACT_STOLEN. Get rid of redundant checks in all qdiscs. I

Re: [RFC 2/3] tc: deprecate TC_ACT_QUEUED

2015-04-22 Thread Cong Wang
On Wed, Apr 22, 2015 at 3:22 PM, Alexei Starovoitov wrote: > On 4/21/15 10:02 PM, Cong Wang wrote: >> >> On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov >> wrote: >>> >>> TC_ACT_QUEUED was always an alias of TC_ACT_STOLEN. >>> Get rid of redundant checks in all qdiscs. >>> Instead do it once

Re: [RFC 3/3] tc: cleanup tc_classify

2015-04-22 Thread Cong Wang
On Wed, Apr 22, 2015 at 3:27 PM, Alexei Starovoitov wrote: > On 4/21/15 10:05 PM, Cong Wang wrote: >> >> On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov >> wrote: >>> >>> introduce tc_classify_act() and qdisc_drop_bypass() helper functions to >>> reduce >>> copy-paste among different qdiscs

Re: [RFC 1/3] tc: fix return values of ingress qdisc

2015-04-22 Thread Cong Wang
On Wed, Apr 22, 2015 at 3:04 PM, Alexei Starovoitov wrote: > On 4/21/15 9:59 PM, Cong Wang wrote: >> >> On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov >> wrote: >>> >>> ingress qdisc should return NET_XMIT_* values just like all other qdiscs. >>> >> >> XMIT already means egress... > > > may

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread Florian Fainelli
On 14/04/15 14:37, Sergei Shtylyov wrote: > >>> +/* Wait for stopping the hardware TX process */ >>> +ravb_wait(ndev, TCCR, TCCR_TSRQ0 | TCCR_TSRQ1 | TCCR_TSRQ2 | >>> TCCR_TSRQ3, >>> + 0); >>> + >>> +ravb_wait(ndev, CSR, CSR_TPO0 | CSR_TPO1 | CSR_TPO2 | CSR_TPO3, 0); >>> + >>>

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Cong Wang
On Wed, Apr 22, 2015 at 3:34 PM, Alexander Duyck wrote: > On 04/22/2015 02:56 PM, Cong Wang wrote: >> On Wed, Apr 22, 2015 at 2:42 PM, Alexander Duyck >> wrote: >>> On 04/22/2015 01:33 PM, Cong Wang wrote: First, make sure you don't miss the TSIP case right above: The frag starting

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread Sergei Shtylyov
On 04/23/2015 01:41 AM, David Miller wrote: Sigh... I'm seeing no way out of that then, only copying. :-( What exactly is the device's restriction? The frame data must be aligned on 32-bit boundary. Any reasonable modern chip allows one of two things. Either it allows arbitrary

Re: [PATCH][net-next] vxlan: remove the unnecessary codes

2015-04-22 Thread David Miller
From: roy.qing...@gmail.com Date: Wed, 22 Apr 2015 15:49:10 +0800 > From: Li RongQing > > The return value of vxlan_fdb_replace always is greater than or equal to 0 > > Signed-off-by: Li RongQing Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

Re: [PATCH net-next v2] be2net: log link status

2015-04-22 Thread David Miller
From: Joe Perches Date: Wed, 22 Apr 2015 07:07:54 -0700 > On Wed, 2015-04-22 at 15:43 +0200, Ivan Vecera wrote: >> @@ -658,10 +659,18 @@ void be_link_status_update(struct be_adapter *adapter, >> u8 link_status) >> adapter->flags |= BE_FLAGS_LINK_STATUS_INIT; >> } >> >> -i

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread David Miller
From: Sergei Shtylyov Date: Thu, 23 Apr 2015 01:34:32 +0300 >Sigh... I'm seeing no way out of that then, only copying. :-( What exactly is the device's restriction? Any reasonable modern chip allows one of two things. Either it allows arbitrary alignment of the start of the TX frame when D

Need help: Firmware(RT2870.bin) loading failed on "backports/stable/v3.14" - (Firmware copied at /lib/firmware)

2015-04-22 Thread s prasad
Hi All, I am working on a project, in which need to enable wireless support. My system have following configuration: ARMv7 Processor(DLINK 868L router) Linux-2.6 Have taken package from "https://www.kernel.org/pub/linux/kernel/projects/backports/stable/v3.14/";. Am able to compile and load module

Re: [PATCH] net/macb: Factor out one-time assignment from loop

2015-04-22 Thread David Miller
From: Ben Shelton Date: Wed, 22 Apr 2015 17:28:54 -0500 > In 02c958dd3 (net/macb: add TX multiqueue support for gem), the > initialization of tx_head and tx_tail in macb_init_rings() was moved > inside the loop that iterates over each element in the ring. Since > tx_head and tx_tail only need to

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread Sergei Shtylyov
On 04/23/2015 01:18 AM, David Miller wrote: Hmm, I've been digging in the net core, and was unable to see where TX skb's get their NET_IP_ALIGN bytes reserved. Have I missed something? Probably need to print out skb's fields... NET_IP_ALIGN is for receive, not transmit.

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Alexander Duyck
On 04/22/2015 02:56 PM, Cong Wang wrote: > On Wed, Apr 22, 2015 at 2:42 PM, Alexander Duyck > wrote: >> On 04/22/2015 01:33 PM, Cong Wang wrote: >>> First, make sure you don't miss the TSIP case right above: >>> >>> The frag starting pointer and its size are advanced by: >>> >>> skb_frag_size_sub(

[PATCH] net/macb: Factor out one-time assignment from loop

2015-04-22 Thread Ben Shelton
In 02c958dd3 (net/macb: add TX multiqueue support for gem), the initialization of tx_head and tx_tail in macb_init_rings() was moved inside the loop that iterates over each element in the ring. Since tx_head and tx_tail only need to be assigned once, move them back out of the loop. Signed-off-by:

Re: [RFC 3/3] tc: cleanup tc_classify

2015-04-22 Thread Alexei Starovoitov
On 4/21/15 10:05 PM, Cong Wang wrote: On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov wrote: introduce tc_classify_act() and qdisc_drop_bypass() helper functions to reduce copy-paste among different qdiscs I don't think qdisc_drop_bypass() is more readable than without it, maybe you nee

Re: [RFC 2/3] tc: deprecate TC_ACT_QUEUED

2015-04-22 Thread Alexei Starovoitov
On 4/21/15 10:02 PM, Cong Wang wrote: On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov wrote: TC_ACT_QUEUED was always an alias of TC_ACT_STOLEN. Get rid of redundant checks in all qdiscs. Instead do it once. The current code can be easily extended, while your code not. I don't see the ne

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread David Miller
From: Sergei Shtylyov Date: Thu, 23 Apr 2015 00:38:56 +0300 > On 04/22/2015 11:42 PM, David Miller wrote: > >>> Hmm, I've been digging in the net core, and was unable to see where TX >>> skb's get their NET_IP_ALIGN bytes reserved. Have I missed something? >>> Probably need to print

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread David Miller
From: Sergei Shtylyov Date: Wed, 22 Apr 2015 23:46:52 +0300 > Hello. > > On 04/22/2015 11:42 PM, David Miller wrote: > >>> Hmm, I've been digging in the net core, and was unable to see where TX >>> skb's get their NET_IP_ALIGN bytes reserved. Have I missed something? >>> Probably ne

Re: [RFC 1/3] tc: fix return values of ingress qdisc

2015-04-22 Thread Alexei Starovoitov
On 4/21/15 9:59 PM, Cong Wang wrote: On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov wrote: ingress qdisc should return NET_XMIT_* values just like all other qdiscs. XMIT already means egress... may be then it should be renamed as well. from include/linux/netdevice.h: /* qdisc ->enque

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Cong Wang
On Wed, Apr 22, 2015 at 2:42 PM, Alexander Duyck wrote: > On 04/22/2015 01:33 PM, Cong Wang wrote: >> First, make sure you don't miss the TSIP case right above: >> >> The frag starting pointer and its size are advanced by: >> >> skb_frag_size_sub(frag, IGB_TS_HDR_LEN); >> ... >> va += IGB_TS_HDR_L

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Alexander Duyck
On 04/22/2015 01:33 PM, Cong Wang wrote: > On Wed, Apr 22, 2015 at 1:21 PM, Alexander Duyck > wrote: >> On 04/22/2015 01:14 PM, Cong Wang wrote: >>> On Wed, Apr 22, 2015 at 12:43 PM, Alexander Duyck >>> wrote: On 04/22/2015 10:45 AM, Cong Wang wrote: > The second parameter of eth_get_hea

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread Sergei Shtylyov
On 04/22/2015 11:42 PM, David Miller wrote: Hmm, I've been digging in the net core, and was unable to see where TX skb's get their NET_IP_ALIGN bytes reserved. Have I missed something? Probably need to print out skb's fields... NET_IP_ALIGN is for receive, not transmit. But w

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread Sergei Shtylyov
Hello. On 04/22/2015 11:42 PM, David Miller wrote: Hmm, I've been digging in the net core, and was unable to see where TX skb's get their NET_IP_ALIGN bytes reserved. Have I missed something? Probably need to print out skb's fields... NET_IP_ALIGN is for receive, not transmit.

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread David Miller
From: Sergei Shtylyov Date: Wed, 22 Apr 2015 23:30:02 +0300 >Hmm, I've been digging in the net core, and was unable to see where TX >skb's get their NET_IP_ALIGN bytes reserved. Have I missed something? >Probably need to print out skb's fields... NET_IP_ALIGN is for receive, not tran

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Cong Wang
On Wed, Apr 22, 2015 at 1:21 PM, Alexander Duyck wrote: > On 04/22/2015 01:14 PM, Cong Wang wrote: >> On Wed, Apr 22, 2015 at 12:43 PM, Alexander Duyck >> wrote: >>> On 04/22/2015 10:45 AM, Cong Wang wrote: The second parameter of eth_get_headlen() is the length of the frame buffer, not

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread Sergei Shtylyov
Hello. On 04/22/2015 06:36 PM, David Miller wrote: + if (!ravb_tx_free(ndev, q)) { + netif_warn(priv, tx_queued, ndev, "TX FD exhausted.\n"); + netif_stop_queue(ndev); + spin_unlock_irqrestore(&priv->lock, flags); +

Re: [PATCH net] net: do not deplete pfmemalloc reserve

2015-04-22 Thread David Miller
From: Eric Dumazet Date: Wed, 22 Apr 2015 13:20:48 -0700 > On Wed, 2015-04-22 at 15:35 -0400, David Miller wrote: >> From: Eric Dumazet >> Date: Wed, 22 Apr 2015 07:33:36 -0700 >> >> > Also, we must refrain using high order pages from the pfmemalloc >> > reserve, so __page_frag_refill() must al

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Alexander Duyck
On 04/22/2015 01:14 PM, Cong Wang wrote: > On Wed, Apr 22, 2015 at 12:43 PM, Alexander Duyck > wrote: >> On 04/22/2015 10:45 AM, Cong Wang wrote: >>> The second parameter of eth_get_headlen() is the length of >>> the frame buffer, not the header length of skb. >>> >>> Cc: Jeff Kirsher >>> Signed-

Re: [PATCH net] net: do not deplete pfmemalloc reserve

2015-04-22 Thread Eric Dumazet
On Wed, 2015-04-22 at 15:35 -0400, David Miller wrote: > From: Eric Dumazet > Date: Wed, 22 Apr 2015 07:33:36 -0700 > > > Also, we must refrain using high order pages from the pfmemalloc > > reserve, so __page_frag_refill() must also use __GFP_NOMEMALLOC for > > them. Under memory pressure, using

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Cong Wang
On Wed, Apr 22, 2015 at 12:43 PM, Alexander Duyck wrote: > On 04/22/2015 10:45 AM, Cong Wang wrote: >> The second parameter of eth_get_headlen() is the length of >> the frame buffer, not the header length of skb. >> >> Cc: Jeff Kirsher >> Signed-off-by: Cong Wang >> --- >> drivers/net/ethernet/

Re: [Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Alexander Duyck
On 04/22/2015 10:45 AM, Cong Wang wrote: > The second parameter of eth_get_headlen() is the length of > the frame buffer, not the header length of skb. > > Cc: Jeff Kirsher > Signed-off-by: Cong Wang > --- > drivers/net/ethernet/intel/igb/igb_main.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [PATCH] ip6_gre: use netdev_alloc_pcpu_stats()

2015-04-22 Thread David Miller
From: Johannes Berg Date: Wed, 22 Apr 2015 16:56:16 +0200 > From: Johannes Berg > > The code there just open-codes the same, so use the provided macro instead. > > Signed-off-by: Johannes Berg Applied, thanks Johannes. -- To unsubscribe from this list: send the line "unsubscribe netdev" in t

Re: [PATCH net] net: do not deplete pfmemalloc reserve

2015-04-22 Thread David Miller
From: Eric Dumazet Date: Wed, 22 Apr 2015 07:33:36 -0700 > Also, we must refrain using high order pages from the pfmemalloc > reserve, so __page_frag_refill() must also use __GFP_NOMEMALLOC for > them. Under memory pressure, using order-0 pages is probably the best > strategy. ... > @@ -348,7 +3

Re: [PATCH net] tcp: fix possible deadlock in tcp_send_fin()

2015-04-22 Thread David Miller
From: Eric Dumazet Date: Wed, 22 Apr 2015 12:12:20 -0700 > On Wed, 2015-04-22 at 14:50 -0400, David Miller wrote: >> From: Eric Dumazet >> Date: Wed, 22 Apr 2015 11:39:27 -0700 >> >> > Note that in the unlikely case skb can not be allocated, >> > if an already transmitted packet is in the write

Re: [PATCH net] tcp: fix possible deadlock in tcp_send_fin()

2015-04-22 Thread Eric Dumazet
On Wed, 2015-04-22 at 14:50 -0400, David Miller wrote: > From: Eric Dumazet > Date: Wed, 22 Apr 2015 11:39:27 -0700 > > > Note that in the unlikely case skb can not be allocated, > > if an already transmitted packet is in the write queue, we also can OR > > the FIN flag on it, and rely on normal

Re: [PATCH net] tcp: fix possible deadlock in tcp_send_fin()

2015-04-22 Thread David Miller
From: Eric Dumazet Date: Wed, 22 Apr 2015 11:39:27 -0700 > Note that in the unlikely case skb can not be allocated, > if an already transmitted packet is in the write queue, we also can OR > the FIN flag on it, and rely on normal rtx to deliver this FIN later. > > I'll cook a patch when net-next

Re: [PATCH net] tcp: fix possible deadlock in tcp_send_fin()

2015-04-22 Thread Eric Dumazet
On Wed, 2015-04-22 at 14:15 -0400, David Miller wrote: > Wrt. longer term solutions, I would even be OK at this point aborting > the connection altogether if the skb allocation fails period. Not > just if TIF_MEMDIE is set. That endless loop has been nothing but > trouble. Agreed. Note that in

Re: [PATCH v2 0/3] mpls: ABI changes for security and correctness

2015-04-22 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Wed, 22 Apr 2015 11:47:10 -0500 > Robert Shearman writes: > >> V2: >> - don't treat loopback interfaces specially by enabling mpls by >>default >> >> These changes make mpls not be enabled by default on all >> interfaces when in use for

Re: [PATCH net] bnx2x: Prevent inner-reload while VFs exist

2015-04-22 Thread David Miller
From: Yuval Mintz Date: Wed, 22 Apr 2015 12:47:32 +0300 > On some feature changes, driver employes an inner-reload flow where it > resets the function and re-configures it with the new required set of > parameters. > > Such a flow proves fatal to any VF since those were not intended to be used >

Re: [PATCH net 0/2 v2] rhashtable rehashing fixes

2015-04-22 Thread David Miller
From: Thomas Graf Date: Wed, 22 Apr 2015 09:41:44 +0200 > Some rhashtable rehashing bugs found while testing with the > next rhashtable self-test queued up for the next devel cycle: > > https://github.com/tgraf/net-next/commits/rht > > v2: > - Moved schedule_work() call into rhashtable_insert_

Re: [PATCH net] tcp: fix possible deadlock in tcp_send_fin()

2015-04-22 Thread David Miller
From: Eric Dumazet Date: Tue, 21 Apr 2015 18:32:24 -0700 > From: Eric Dumazet > > Using sk_stream_alloc_skb() in tcp_send_fin() is dangerous in > case a huge process is killed by OOM, and tcp_mem[2] is hit. > > To be able to free memory we need to make progress, so this > patch allows FIN pack

[Patch net] ixgbe: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Cong Wang
The second parameter of eth_get_headlen() is the length of the frame buffer, not the header length of skb. Cc: Jeff Kirsher Signed-off-by: Cong Wang --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/inte

[Patch net] igb: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Cong Wang
The second parameter of eth_get_headlen() is the length of the frame buffer, not the header length of skb. Cc: Jeff Kirsher Signed-off-by: Cong Wang --- drivers/net/ethernet/intel/igb/igb_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ig

[Patch net] fm10k: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Cong Wang
The second parameter of eth_get_headlen() is the length of the frame buffer, not the header length of skb. Cc: Jeff Kirsher Signed-off-by: Cong Wang --- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/inte

[Patch net] ixgbevf: pass the correct maxlen for eth_get_headlen()

2015-04-22 Thread Cong Wang
The second parameter of eth_get_headlen() is the length of the frame buffer, not the header length of skb. Cc: Jeff Kirsher Signed-off-by: Cong Wang --- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/

Re: [PATCH v2 01/11] RDMA/CMA: Mark IPv4 addresses correctly when the listener is IPv6

2015-04-22 Thread Jason Gunthorpe
On Tue, Apr 21, 2015 at 01:15:11PM +0300, Haggai Eran wrote: > That's correct. We didn't address it because it was part of the existing > code. Anyway, in a later patch in this series we move this code from the > CMA to the CM module. Just so we are all on the same page in the future: - Don't ha

[PATCH] net: mdio-gpio: support access that may sleep

2015-04-22 Thread Vivien Didelot
Some systems using mdio-gpio may use gpio on message based busses, which require sleeping (e.g. gpio from an I2C I/O expander). Since this driver does not use IRQ handler, it is safe to use the _cansleep suffixed gpio accessors. Signed-off-by: Vivien Didelot --- drivers/net/phy/mdio-gpio.c | 14

Re: [PATCH] net/phy: refactor RTL8211F initialization

2015-04-22 Thread Florian Fainelli
On 22/04/15 03:22, Shengzhou Liu wrote: > RTL8211F needs to enalbe TXDLY for RGMII during > phy initialization, so move it to rtl8211f_config > for early initialization. > > Signed-off-by: Shengzhou Liu > cc: Joe Hershberger > --- > drivers/net/phy/realtek.c | 25 + > 1

Re: [PATCH v2 0/3] mpls: ABI changes for security and correctness

2015-04-22 Thread Eric W. Biederman
Robert Shearman writes: > V2: > - don't treat loopback interfaces specially by enabling mpls by >default > > These changes make mpls not be enabled by default on all > interfaces when in use for security, along with ensuring that a label > not valid as an outgoing label can be added in mpls

Re: [RFC PATCH 0/3] Enable connecting DSA-based switch to the USB RMII interface.

2015-04-22 Thread Andrew Lunn
On Wed, Apr 22, 2015 at 04:14:33PM +, Jan Kaisrlik wrote: > 2015-04-21 17:51 GMT+00:00 Florian Fainelli : > > On 21/04/15 10:39, Andrew Lunn wrote: > I would however say that sysfs is the wrong API. The linux network > stack uses netlink for most configuration activities. So i would >

Re: [PATCH v2 3/3] mpls: Prevent use of implicit NULL label as outgoing label

2015-04-22 Thread Eric W. Biederman
Robert Shearman writes: > The reserved implicit-NULL label isn't allowed to appear in the label > stack for packets, so make it an error for the control plane to > specify it as an outgoing label. Reviewed-by: "Eric W. Biederman" > > Suggested-by: "Eric W. Biederman" > Signed-off-by: Robert S

Re: [PATCH v2 2/3] mpls: Per-device enabling of packet input

2015-04-22 Thread Eric W. Biederman
Robert Shearman writes: > An MPLS network is a single trust domain where the edges must be in > control of what labels make their way into the core. The simplest way > of ensuring this is for the edge device to always impose the labels, > and not allow forward labeled traffic from untrusted neigh

Re: [RFC PATCH 0/3] Enable connecting DSA-based switch to the USB RMII interface.

2015-04-22 Thread Jan Kaisrlik
2015-04-21 17:51 GMT+00:00 Florian Fainelli : > On 21/04/15 10:39, Andrew Lunn wrote: I would however say that sysfs is the wrong API. The linux network stack uses netlink for most configuration activities. So i would suggest adding a netlink binding to DSA, and place the code in >>>

Re: [PATCH 0/6] crypto: Make all AEAD users include aead.h

2015-04-22 Thread David Miller
From: Herbert Xu Date: Wed, 22 Apr 2015 15:04:55 +0800 > This series adds inclusions of aead.h to all AEAD users including > AEAD implementors (where it's internal/aead.h). This is necessary > because I'll be adding an updated AEAD interface and that will live > in aead.h instead of crypto.h. >

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Arnd Bergmann
On Wednesday 22 April 2015 17:14:47 Luc Van Oostenryck wrote: > On Wed, Apr 22, 2015 at 03:50:45PM +0200, Arnd Bergmann wrote: > > On Wednesday 22 April 2015 13:07:44 Arnd Bergmann wrote: > ... > > select, old_selct, pselect6: deprecated > > Small, copy&paste error here for pselect6. > Right, th

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Arnd Bergmann
On Wednesday 22 April 2015 16:54:32 Richard Cochran wrote: > On Wed, Apr 22, 2015 at 03:50:45PM +0200, Arnd Bergmann wrote: > > time, stime, gettimeofday, settimeofday, adjtimex, nanosleep, > > getitimer, setitimer: > > all deprecated => wontfix > > If adjtimex is deprecated, what will replace it

Re: [PATCH v3] Renesas Ethernet AVB driver

2015-04-22 Thread David Miller
From: MITSUHIRO KIMURA Date: Wed, 22 Apr 2015 05:04:13 + > Hello Sergei. > > (2015/04/15 6:37:28), Sergei Shtylyov wrote: >> >> + if (!ravb_tx_free(ndev, q)) { >> >> + netif_warn(priv, tx_queued, ndev, "TX FD exhausted.\n"); >> >> + netif_stop_queue(n

Re: [PATCH v2 1/3] mpls: Per-device MPLS state

2015-04-22 Thread Eric W. Biederman
Robert Shearman writes: > Add per-device MPLS state to supported interfaces. Use the presence of > this state in mpls_route_add to determine that this is a supported > interface. > > Use the presence of mpls_dev to drop packets that arrived on an > unsupported interface - previously they were all

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Luc Van Oostenryck
On Wed, Apr 22, 2015 at 03:50:45PM +0200, Arnd Bergmann wrote: > On Wednesday 22 April 2015 13:07:44 Arnd Bergmann wrote: ... > select, old_selct, pselect6: deprecated Small, copy&paste error here for pselect6. Luc -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body

[PATCH] ip6_gre: use netdev_alloc_pcpu_stats()

2015-04-22 Thread Johannes Berg
From: Johannes Berg The code there just open-codes the same, so use the provided macro instead. Signed-off-by: Johannes Berg --- net/ipv6/ip6_gre.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/net/ipv6/ip6_gre.c b/net/ipv6/ip6_gre.c index b5e6cc1d4a73..a38d3ac0f1

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Richard Cochran
On Wed, Apr 22, 2015 at 03:50:45PM +0200, Arnd Bergmann wrote: > time, stime, gettimeofday, settimeofday, adjtimex, nanosleep, > getitimer, setitimer: > all deprecated => wontfix If adjtimex is deprecated, what will replace it? It is really important for ntp. Thanks, Richard -- To unsubscribe

[PATCH net] net: do not deplete pfmemalloc reserve

2015-04-22 Thread Eric Dumazet
From: Eric Dumazet build_skb() should look at the page pfmemalloc status. If set, this means page allocator allocated this page in the expectation it would help to free other pages. Networking stack can do that only if skb->pfmemalloc is also set. Also, we must refrain using high order pages fro

Re: [PATCH] tcp: set SOCK_NOSPACE under memory presure

2015-04-22 Thread Jason Baron
On 04/21/2015 05:33 PM, David Miller wrote: > From: Jason Baron > Date: Mon, 20 Apr 2015 20:05:13 + (GMT) > >> Under tcp memory pressure, calling epoll_wait() in edge triggered >> mode after -EAGAIN, can result in an indefinite hang in epoll_wait(), >> even when there is suffcient memory avail

Re: [PATCH net-next v2] be2net: log link status

2015-04-22 Thread Ivan Vecera
On 04/22/2015 04:07 PM, Joe Perches wrote: On Wed, 2015-04-22 at 15:43 +0200, Ivan Vecera wrote: >The driver unlike other drivers does not log link state changes. Why add all the speed stuff, why not add a query instead? I think it'd be simpler to add a line like: status = be_cmd_link_

Re: [PATCH net-next v2] be2net: log link status

2015-04-22 Thread Joe Perches
On Wed, 2015-04-22 at 15:43 +0200, Ivan Vecera wrote: > The driver unlike other drivers does not log link state changes. Why add all the speed stuff, why not add a query instead? I think it'd be simpler to add a line like: status = be_cmd_link_status_query(adapter, &speed, &status, 0); be

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Arnd Bergmann
On Wednesday 22 April 2015 13:07:44 Arnd Bergmann wrote: > > I've started a list of affected syscalls at > https://docs.google.com/spreadsheets/d/1HCYwHXxs48TsTb6IGUduNjQnmfRvMPzCN6T_0YiQwis/edit?usp=sharing > > Still adding more calls and description, let me know if you want edit > permissions.

[PATCH net-next v2] be2net: log link status

2015-04-22 Thread Ivan Vecera
The driver unlike other drivers does not log link state changes. v2: added current link speed to log message Cc: Sathya Perla Cc: Subbu Seetharaman Cc: Ajit Khaparde Signed-off-by: Ivan Vecera --- drivers/net/ethernet/emulex/benet/be.h | 3 ++- drivers/net/ethernet/emulex/benet/be_c

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Thomas Gleixner
On Wed, 22 Apr 2015, Arnd Bergmann wrote: > On Wednesday 22 April 2015 10:45:23 Thomas Gleixner wrote: > > On Tue, 21 Apr 2015, Thomas Gleixner wrote: > > > So we could save one translation step if we implement new syscalls > > which have a scalar nsec interface instead of the timespec/timeval > >

[PATCH v2] altera tse: add support for fixed-links.

2015-04-22 Thread Andreas Oetken
From: Andreas Oetken Add support for fixed-links in configurations without PHY. (e.g. connection to a switch, SGMII point to point, SFPs) Check: Documentation/devicetree/bindings/net/fixed-link.txt. Signed-off-by: Andreas Oetken --- drivers/net/ethernet/altera/altera_tse_main.c | 36 ++

Re: [PATCH net-next] be2net: log link status

2015-04-22 Thread Ivan Vecera
On 04/22/2015 03:10 PM, Joe Perches wrote: On Wed, 2015-04-22 at 14:56 +0200, Ivan Vecera wrote: The driver unlike other drivers does not log link state changes. [] diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c [] @@ -662,6 +662,8 @@

Re: [PATCH net-next] be2net: log link status

2015-04-22 Thread Joe Perches
On Wed, 2015-04-22 at 14:56 +0200, Ivan Vecera wrote: > The driver unlike other drivers does not log link state changes. [] > diff --git a/drivers/net/ethernet/emulex/benet/be_main.c > b/drivers/net/ethernet/emulex/benet/be_main.c [] > @@ -662,6 +662,8 @@ void be_link_status_update(struct be_adapt

[PATCH net-next] be2net: log link status

2015-04-22 Thread Ivan Vecera
The driver unlike other drivers does not log link state changes. Cc: Sathya Perla Cc: Subbu Seetharaman Cc: Ajit Khaparde Signed-off-by: Ivan Vecera --- drivers/net/ethernet/emulex/benet/be_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/emulex/benet/be_main.

Re: [PATCH] neighbour.c: Avoid GC directly after state change

2015-04-22 Thread Ulf Samuelsson
On 04/22/2015 12:46 PM, YOSHIFUJI Hideaki wrote: Ulf Samuelsson wrote: On 04/21/2015 05:58 AM, YOSHIFUJI Hideaki wrote: Ulf Samuelsson wrote: How many neighbors do you want to maintain? I guess you have to increase the number of gc_thresh1. The current use cases have up to 2048 entries. This

nice to write you

2015-04-22 Thread Meli Tiziana
Hello dear, how are you today hope fine , well i just saw your email today and,i am mariyeh by name i really want us to become friend and you can also send me mail here in my email address so that we can know each other well and i can then send you my pictures and introduction about my sel

Re: [PATCH v2 01/11] RDMA/CMA: Mark IPv4 addresses correctly when the listener is IPv6

2015-04-22 Thread Haggai Eran
On Tuesday, April 21, 2015 1:15 PM, Haggai Eran wrote: > On 20/04/2015 23:01, Jason Gunthorpe wrote: >> This should take care of it, testing, and figuring the fixes tag is >> left as an exercise to the reader.. > > Fixes: e51060f08a61 ("IB: IP address based RDMA connection manager") > Tested-by:

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Arnd Bergmann
On Wednesday 22 April 2015 10:45:23 Thomas Gleixner wrote: > On Tue, 21 Apr 2015, Thomas Gleixner wrote: > So we could save one translation step if we implement new syscalls > which have a scalar nsec interface instead of the timespec/timeval > cruft and let user space do the translation to whatev

Re: [PATCH] neighbour.c: Avoid GC directly after state change

2015-04-22 Thread YOSHIFUJI Hideaki
Ulf Samuelsson wrote: > > On 04/21/2015 05:58 AM, YOSHIFUJI Hideaki wrote: >> Ulf Samuelsson wrote: How many neighbors do you want to maintain? I guess you have to increase the number of gc_thresh1. >>> The current use cases have up to 2048 entries. >>> This is expected to grow in the fu

RE: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread David Laight
From: Thomas Gleixner > Sent: 22 April 2015 09:45 > On Tue, 21 Apr 2015, Thomas Gleixner wrote: > > On Tue, 21 Apr 2015, Arnd Bergmann wrote: > > > I know there are concerns about this, in particular because C11 and > > > POSIX both require tv_nsec to be 'long', unlike timeval->tv_usec, > > > which

[PATCH] net/phy: refactor RTL8211F initialization

2015-04-22 Thread Shengzhou Liu
RTL8211F needs to enalbe TXDLY for RGMII during phy initialization, so move it to rtl8211f_config for early initialization. Signed-off-by: Shengzhou Liu cc: Joe Hershberger --- drivers/net/phy/realtek.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git

[PATCH v2 2/3] mpls: Per-device enabling of packet input

2015-04-22 Thread Robert Shearman
An MPLS network is a single trust domain where the edges must be in control of what labels make their way into the core. The simplest way of ensuring this is for the edge device to always impose the labels, and not allow forward labeled traffic from untrusted neighbours. This is achieved by allowin

[PATCH v2 3/3] mpls: Prevent use of implicit NULL label as outgoing label

2015-04-22 Thread Robert Shearman
The reserved implicit-NULL label isn't allowed to appear in the label stack for packets, so make it an error for the control plane to specify it as an outgoing label. Suggested-by: "Eric W. Biederman" Signed-off-by: Robert Shearman --- net/mpls/af_mpls.c | 9 + 1 file changed, 9 inserti

[PATCH v2 0/3] mpls: ABI changes for security and correctness

2015-04-22 Thread Robert Shearman
V2: - don't treat loopback interfaces specially by enabling mpls by default These changes make mpls not be enabled by default on all interfaces when in use for security, along with ensuring that a label not valid as an outgoing label can be added in mpls routes. This series contains three ABI

[PATCH v2 1/3] mpls: Per-device MPLS state

2015-04-22 Thread Robert Shearman
Add per-device MPLS state to supported interfaces. Use the presence of this state in mpls_route_add to determine that this is a supported interface. Use the presence of mpls_dev to drop packets that arrived on an unsupported interface - previously they were allowed through. Cc: "Eric W. Biederman

Re: [Y2038] [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure

2015-04-22 Thread Richard Cochran
On Wed, Apr 22, 2015 at 10:45:23AM +0200, Thomas Gleixner wrote: > So we could save one translation step if we implement new syscalls > which have a scalar nsec interface instead of the timespec/timeval > cruft and let user space do the translation to whatever it wants. +1 > I personally would we

Re: [PATCH 0/3] mpls: ABI changes for security and correctness

2015-04-22 Thread Robert Shearman
On 22/04/15 01:29, Eric W. Biederman wrote: Robert Shearman writes: These changes make mpls not be enabled by default on all interfaces when in use for security, along with ensuring that a label not valid as an outgoing label can be added in mpls routes. This series contains three ABI/behavio

[PATCH net] bnx2x: Prevent inner-reload while VFs exist

2015-04-22 Thread Yuval Mintz
On some feature changes, driver employes an inner-reload flow where it resets the function and re-configures it with the new required set of parameters. Such a flow proves fatal to any VF since those were not intended to be used while HW is being reset underneath, causing them [at best] to lose al

Re: [PATCH][net-next][v2] xfrm: optimise the use of walk list header in xfrm_policy/state_walk

2015-04-22 Thread Herbert Xu
On Wed, Apr 22, 2015 at 05:09:54PM +0800, roy.qing...@gmail.com wrote: > From: Li RongQing > > The walk from input is the list header, and marked as dead, and will > be skipped in loop. > > list_first_entry() can be used to return the true usable value from > walk if walk is not empty > > Signe

[PATCH][net-next][v2] xfrm: optimise the use of walk list header in xfrm_policy/state_walk

2015-04-22 Thread roy . qing . li
From: Li RongQing The walk from input is the list header, and marked as dead, and will be skipped in loop. list_first_entry() can be used to return the true usable value from walk if walk is not empty Signed-off-by: Li RongQing --- net/xfrm/xfrm_policy.c | 4 +++- net/xfrm/xfrm_state.c | 2 +

  1   2   >