Re: [RFC][PATCH] net: stmmac: use msleep instead of udelay for gpio reset

2015-04-18 Thread Fabio Estevam
On Sat, Apr 18, 2015 at 12:02 PM, Michael Trimarchi wrote: > reset_gpio = data->reset_gpio; > - active_low = data->active_low; > + active_low = !!data->active_low; This is an unrelated change. -- To unsubscribe from this list: send the line "unsubscrib

[RFC][PATCH] net: stmmac: use msleep instead of udelay for gpio reset

2015-04-18 Thread Michael Trimarchi
Reset delay values are expressed in microsecond but most of the time the delay is more then 2ms and up to 100ms. Use udelay is wrong for large sleep period. This function is not used in interrupt context according to the documentation. Signed-off-by: Michael Trimarchi --- drivers/net/ethernet/st

Re: [PATCHSET] printk, netconsole: implement reliable netconsole

2015-04-18 Thread Tetsuo Handa
Tejun Heo wrote: > > If we can assume that scheduler is working, adding a kernel thread that > > does > > > > while (1) { > > read messages with metadata from /dev/kmsg > > send them using UDP network > > } > > > > might be easier than modifying netconsole module. > > But, I mean

Re: [PATCH] mac802154: llsec: fix return value check in llsec_key_alloc()

2015-04-18 Thread Alexander Aring
On Thu, Apr 16, 2015 at 08:16:34PM +0800, weiyj...@163.com wrote: > From: Wei Yongjun > > In case of error, the functions crypto_alloc_aead() and > crypto_alloc_blkcipher() > returns ERR_PTR() and never returns NULL. The NULL test in the return value > check > should be replaced with IS_ERR().

[PATCH v2 net-next] ip: Add color output option

2015-04-18 Thread Mathias Nyman
It is hard to quickly find what you are looking for in the output of the ip command. Color helps. This patch adds a '-c' flag to highlight these with individual colors: - interface name - ip address - mac address - up/down state Signed-off-by: Mathias Nyman --- include/color.h | 17 +++

Re: [PATCH net-next] ip: Add color output option

2015-04-18 Thread Mathias Nyman
On 2015-04-17 19:26+0200, Daniel Borkmann wrote: On 04/17/2015 06:44 PM, Alexei Starovoitov wrote: On Fri, Apr 17, 2015 at 04:02:02PM +0300, Mathias Nyman wrote: It is hard to quickly find what you are looking for in the output of the ip command. Color helps. This patch adds a '-c' flag to hig

[PATCH v2] pppoe: Lacks DST MAC address check

2015-04-18 Thread Joakim Tjernlund
A pppoe session is identified by its session ID and MAC address. Currently pppoe does not check if the received pkg has the correct MAC address. This is a problem when the eth I/F is in promisc mode as then any DST MAC address is accepted. --- v2 - The MAC address check should encompass all pppoe