Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-26 Thread Jarek Poplawski
James Chapman wrote, On 02/26/2008 01:14 PM: ... > Luckily, I'm in the lab where my two borrowed servers are today so I > have access to their consoles. Hopefully I'll be able to find out why > there are hanging. Btw, they don't hang if I disable irqs around the > ppp_input() call. Maybe you've

[RFC/PATCH] ipg: add jumbo frame support kconfig option

2008-02-26 Thread Pekka J Enberg
[ Sorry for the duplicate. I typoed Francois' email address. ] From: Pekka Enberg <[EMAIL PROTECTED]> Convert the internal JUMBO_FRAME #ifdef to CONFIG_IP1000_JUMBO_FRAME proper and fix compilation errors. Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Hu

[RFC/PATCH] ipg: add jumbo frame support kconfig option

2008-02-26 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> Convert the internal JUMBO_FRAME #ifdef to CONFIG_IP1000_JUMBO_FRAME proper and fix compilation errors. Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Huang <[EMAIL PROTECTED]> Signed-off-by: Pekka Enberg <[EMAIL PROT

Re: [Bluez-devel] forcing SCO connection patch

2008-02-26 Thread Marcel Holtmann
Hi Loius, --- linux-2.6.23/net/bluetooth/hci_event.c.orig 2008-02-25 17:17:11.0 +0900 +++ linux-2.6.23/net/bluetooth/hci_event.c 2008-02-25 17:30:23.0 +0900 @@ -1313,8 +1313,17 @@ hci_dev_lock(hdev); conn = hci_conn_hash_lookup_ba(hdev, ev->link_type, &ev->bdaddr); - if (!conn)

Re: problems with e1000 and flow control

2008-02-26 Thread Kok, Auke
Brandeburg, Jesse wrote: > Wolfgang Walter wrote: >> it seems that e1000 enables flow-control (rx pause frames) even if >> the switch does not advertise flow control. This seems to get a >> problem as (at least some) switches then forward pause frames >> directed to the card from other hosts. We th

Re: problems with e1000 and flow control

2008-02-26 Thread Kok, Auke
Wolfgang Walter wrote: > Hello, > > it seems that e1000 enables flow-control (rx pause frames) even if the switch > does not advertise flow control. This seems to get a problem as (at least > some) switches then forward pause frames directed to the card from other > hosts. We think there are ho

Re: [patch 0/6] pasemi_mac updates for 2.6.26

2008-02-26 Thread Olof Johansson
On Tue, Feb 26, 2008 at 01:21:00PM -0500, Jeff Garzik wrote: > Olof Johansson wrote: > > On Tue, Feb 26, 2008 at 08:49:58PM +1100, Paul Mackerras wrote: > >> What route do you think these should take upstream? I'm happy to take > >> them if Jeff is OK with that. > > > > I've sent them through Je

RE: problems with e1000 and flow control

2008-02-26 Thread Brandeburg, Jesse
Wolfgang Walter wrote: > it seems that e1000 enables flow-control (rx pause frames) even if > the switch does not advertise flow control. This seems to get a > problem as (at least some) switches then forward pause frames > directed to the card from other hosts. We think there are hosts which > ind

Re: [patch 0/6] pasemi_mac updates for 2.6.26

2008-02-26 Thread Jeff Garzik
Olof Johansson wrote: On Tue, Feb 26, 2008 at 08:49:58PM +1100, Paul Mackerras wrote: Olof Johansson writes: Here's a set of updates for pasemi_mac for 2.6.26. Some of them touch the dma_lib in the platform code as well, but it's easier if it's all merged through netdev to avoid dependencies.

Re: [PATCH 00/28] Swap over NFS -v16

2008-02-26 Thread Andrew Morton
On Tue, 26 Feb 2008 11:50:42 +0100 Peter Zijlstra <[EMAIL PROTECTED]> wrote: > On Tue, 2008-02-26 at 17:03 +1100, Neil Brown wrote: > > On Saturday February 23, [EMAIL PROTECTED] wrote: > > > > What is the NFS and net people's take on all of this? > > > > Well I'm only vaguely an NFS person, ba

Re: [PATCH 00/28] Swap over NFS -v16

2008-02-26 Thread Miklos Szeredi
> > > > mm-page_file_methods.patch > > > > > > > > This makes page_offset and others more expensive by adding a > > > > conditional jump to a function call that is not usually made. > > > > > > > > Why do swap pages have a different index to everyone else? > > > > > > Because the pag

Re: [PATCH 00/28] Swap over NFS -v16

2008-02-26 Thread Peter Zijlstra
On Tue, 2008-02-26 at 16:29 +0100, Miklos Szeredi wrote: > > > mm-page_file_methods.patch > > > > > > This makes page_offset and others more expensive by adding a > > > conditional jump to a function call that is not usually made. > > > > > > Why do swap pages have a different index

Re: [PATCH 00/28] Swap over NFS -v16

2008-02-26 Thread Peter Zijlstra
On Tue, 2008-02-26 at 16:29 +0100, Miklos Szeredi wrote: > > > mm-page_file_methods.patch > > > > > > This makes page_offset and others more expensive by adding a > > > conditional jump to a function call that is not usually made. > > > > > > Why do swap pages have a different index

Re: [PATCH] Can not send icmp netunreach packet

2008-02-26 Thread Stephen Hemminger
On Tue, 26 Feb 2008 18:59:08 +0900 Wei Yongjun <[EMAIL PROTECTED]> wrote: > Jarek Poplawski wrote: > > Maybe ip_error() does not handle the ESRCH error. In this place ESRCH eq > to ENETUNREACH? > > static int ip_error(struct sk_buff *skb) > { > struct rtable *rt = (struct rtable*)skb->dst

Re: [PATCH 00/28] Swap over NFS -v16

2008-02-26 Thread Miklos Szeredi
> > mm-page_file_methods.patch > > > > This makes page_offset and others more expensive by adding a > > conditional jump to a function call that is not usually made. > > > > Why do swap pages have a different index to everyone else? > > Because the page->index of an anonymous page is

[PATCH][EBTABLES] Fix alignment checks in ebt_among.ko module.

2008-02-26 Thread Pavel Emelyanov
When trying to do # ebtables -A FORWARD --among-src 0:12:34:56:78:9a=192.168.0.10 -j ACCEPT on x86_64 box the ebt_among->check() callback warns me that ebtables: among: wrong size: 1060 against expected 1056, rounded to 1056 Checking the ebtables sources, I found that the align

Re: [patch 0/6] pasemi_mac updates for 2.6.26

2008-02-26 Thread Olof Johansson
On Tue, Feb 26, 2008 at 08:49:58PM +1100, Paul Mackerras wrote: > Olof Johansson writes: > > > Here's a set of updates for pasemi_mac for 2.6.26. Some of them touch > > the dma_lib in the platform code as well, but it's easier if it's all > > merged through netdev to avoid dependencies. > > > > M

Re: [patch 1/6] pasemi_mac: Move RX/TX section enablement to dma_lib

2008-02-26 Thread Olof Johansson
Hi, On Tue, Feb 26, 2008 at 10:46:06PM +1100, Michael Ellerman wrote: > On Wed, 2008-02-20 at 20:57 -0600, Olof Johansson wrote: > > + i = 1000; > > + pasemi_write_dma_reg(PAS_DMA_COM_RXCMD, 0); > > + while ((i > 0) && (pasemi_read_dma_reg(PAS_DMA_COM_RXSTA) & 1)) > > + i--; > > +

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-26 Thread Miklos Szeredi
Starting review in the middle, because this is the part I'm most familiar with. > New addres_space_operations methods are added: > int swapfile(struct address_space *, int); Separate ->swapon() and ->swapoff() methods would be so much cleaner IMO. Also is there a reason why 'struct file *' can

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-26 Thread Jarek Poplawski
On Tue, Feb 26, 2008 at 01:03:34PM +, Jarek Poplawski wrote: > On Tue, Feb 26, 2008 at 12:14:26PM +, James Chapman wrote: ... > > there are hanging. Btw, they don't hang if I disable irqs around the > > ppp_input() call. > > ...and disabling bh instead isn't enough, BTW? I guess not: th

The natural ecological beauty in Taiwan

2008-02-26 Thread 『Taiwan News Express』
-- Powered by PHPlist, www.phplist.com -- -- T

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-26 Thread Jarek Poplawski
On Tue, Feb 26, 2008 at 12:14:26PM +, James Chapman wrote: > Jarek Poplawski wrote: >> Jarek Poplawski wrote, On 02/25/2008 02:39 PM: >> ... >>> Hmm... Wait a minute! But on the other hand David has written about >>> his cons here, and it looks reasonable: this place would be fixed, >>> but som

Re: [PATCH 22/28] mm: add support for non block device backed swap files

2008-02-26 Thread Peter Zijlstra
On Tue, 2008-02-26 at 13:45 +0100, Miklos Szeredi wrote: > Starting review in the middle, because this is the part I'm most > familiar with. > > > New addres_space_operations methods are added: > > int swapfile(struct address_space *, int); > > Separate ->swapon() and ->swapoff() methods would

Re: [PATCH][PPPOL2TP]: Fix SMP oops in pppol2tp driver

2008-02-26 Thread James Chapman
Jarek Poplawski wrote: Jarek Poplawski wrote, On 02/25/2008 02:39 PM: ... Hmm... Wait a minute! But on the other hand David has written about his cons here, and it looks reasonable: this place would be fixed, but some others can start reports like this. Maybe, it's better to analyze yet if it's

Re: [PATCH 00/28] Swap over NFS -v16

2008-02-26 Thread Peter Zijlstra
On Tue, 2008-02-26 at 11:50 +0100, Peter Zijlstra wrote: > > mm-reserve.patch > > > >I'm confused by __mem_reserve_add. > > > > + reserve = mem_reserve_root.pages; > > + __calc_reserve(res, pages, 0); > > + reserve = mem_reserve_root.pages - reserve; > > > >__calc_reserve will al

Re: [Netem] Fixed delay patch for netem

2008-02-26 Thread Julio Kriger
Hi Stephen, Answering your question: there is no diffence if (and only if) there is no gap reordering. If there is gap reordering then packets will get a delay of 0ms or 80ms +/- 15ms. With the patch I sent, packets will get a delay of 50ms or 80ms +/- 15ms. I have read about other network emulato

Re: [patch 1/6] pasemi_mac: Move RX/TX section enablement to dma_lib

2008-02-26 Thread Michael Ellerman
On Wed, 2008-02-20 at 20:57 -0600, Olof Johansson wrote: > plain text document attachment (in-progress) > Also stop both rx and tx sections before changing the configuration of > the dma device during init. > > Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> > > Index: k.org/arch/powerpc/platfo

[PATCH] changes required to flush all routing table entries in side kernel

2008-02-26 Thread dur...@it.iitb.ac.in phani
Problem : Need to clean up routing table entries in side the Linux kernel. But kernel is not providing single command to clear all routing table entries at once. Modified the kernel to take of the changesDefined new net link message under NETLINK_ROUTE family RTM_FLUSHROUTE. At

Re: [PATCH] Can not send icmp netunreach packet

2008-02-26 Thread Jarek Poplawski
On Tue, Feb 26, 2008 at 06:59:08PM +0900, Wei Yongjun wrote: > Jarek Poplawski wrote: > > Maybe ip_error() does not handle the ESRCH error. In this place ESRCH eq > to ENETUNREACH? It doesn't handle ESRCH for sure... Current solution seems to expect it is changed earlier to ENETUNREACH. It looks

Re: [PATCH 00/28] Swap over NFS -v16

2008-02-26 Thread Peter Zijlstra
Hi Neil, On Tue, 2008-02-26 at 17:03 +1100, Neil Brown wrote: > On Saturday February 23, [EMAIL PROTECTED] wrote: > > What is the NFS and net people's take on all of this? > > Well I'm only vaguely an NFS person, barely a net person, sporadically > an mm person, but I've had a look and it seem

Re: [PATCH] Can not send icmp netunreach packet

2008-02-26 Thread Wei Yongjun
Jarek Poplawski wrote: Maybe ip_error() does not handle the ESRCH error. In this place ESRCH eq to ENETUNREACH? static int ip_error(struct sk_buff *skb) { struct rtable *rt = (struct rtable*)skb->dst; unsigned long now; int code; switch (rt->u.dst.error) {

Re: [patch 0/6] pasemi_mac updates for 2.6.26

2008-02-26 Thread Paul Mackerras
Olof Johansson writes: > Here's a set of updates for pasemi_mac for 2.6.26. Some of them touch > the dma_lib in the platform code as well, but it's easier if it's all > merged through netdev to avoid dependencies. > > Major highlights are jumbo frame support and ethtool basics, the rest > is most

Re: include/linux/pcounter.h

2008-02-26 Thread Ingo Molnar
* David Miller <[EMAIL PROTECTED]> wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Sat, 16 Feb 2008 11:26:18 -0800 > > > On Sat, 16 Feb 2008 13:03:54 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > > > > > Yes, per connection basis. Some workloads want to open/close more > > > than 10