[PATCH][XFRM]: Fix statistics.

2008-01-30 Thread Masahide NAKAMURA
Hello, I found some XFRM statistics updates which should be applied. This patch change user-public header defines introduced at net-2.6.25 and I hope to make it to be applied to linux 2.6.25. [PATCH][XFRM]: Fix statistics. o Outbound sequence number overflow error status is counted as XfrmOut

[PATCH] [VLAN] vlan_dev: Initialize dev pointer only when it is being used

2008-01-30 Thread Benjamin Li
Signed-off-by: Benjamin Li <[EMAIL PROTECTED]> --- net/8021q/vlan_dev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c index 8059fa4..2fa5d68 100644 --- a/net/8021q/vlan_dev.c +++ b/net/8021q/vlan_dev.c @@ -49,7 +49,7 @@ */

Re: [PATCH] [1/1] Deprecate tcp_tw_{reuse,recycle}

2008-01-30 Thread Andi Kleen
> I believe the problem was that all of my ports were used up with > TIME_WAIT sockets and so it couldn't create more. My test > case was similar to this: Ah that's simple to solve then :- use more IP addresses and bind to them in RR in your user program. Arguably the Linux TCP code should be

Re: [PATCH] [1/1] Deprecate tcp_tw_{reuse,recycle}

2008-01-30 Thread Ben Greear
Andi Kleen wrote: On Wednesday 30 January 2008 20:22, Ben Greear wrote: We use these features to enable creating very high numbers of short-lived TCP connections, primarily used as a test tool for other network devices. Hopefully these other network devices don't do any NAT then or do

Re: net-2.6.25 is no more...

2008-01-30 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Thu, 31 Jan 2008 01:09:21 -0500 > David Miller wrote: > > The latter. > > So... what to do about changes which are not bug fixes? Such changes > should not go upstream immediately, because that's the standard rule for > merge windows. > > And queue

Re: net-2.6.25 is no more...

2008-01-30 Thread Jeff Garzik
David Miller wrote: From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Wed, 30 Jan 2008 10:03:09 +0100 David Miller wrote: Now that the bulk has been merged over and we are actively working alongside Linus's tree I have moved all current patch applying to net-2.6 instead of net-2.6.25, so the curr

Re: ipcomp regression in 2.6.24

2008-01-30 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 31 Jan 2008 16:32:21 +1100 > [IPCOMP]: Fix reception of incompressible packets > > I made a silly typo by entering IPPROTO_IP (== 0) instead of > IPPROTO_IPIP (== 4). This broke the reception of incompressible > packets. > > Signed-off-by: Herbert

RE: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Brandeburg, Jesse
Bruce Allen wrote: > Hi Jesse, > > It's good to be talking directly to one of the e1000 developers and > maintainers. Although at this point I am starting to think that the > issue may be TCP stack related and nothing to do with the NIC. Am I > correct that these are quite distinct parts of the

Re: ipcomp regression in 2.6.24

2008-01-30 Thread Herbert Xu
On Wed, Jan 30, 2008 at 10:14:46AM +0100, Marco Berizzi wrote: > > Sorry for bother you again. > I have applied to 2.6.24, but ipcomp doesn't work anyway. > I have patched a clean 2.6.24 tree and I did a complete > rebuild. > With tcpdump I see both the esp packets going in/out but > I don't see th

Re: [git patches] net driver fixes

2008-01-30 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 11:47:11PM +0100, Francois Romieu wrote: > Sam Ravnborg <[EMAIL PROTECTED]> : > [...] > > > -static struct pci_device_id sis190_pci_tbl[] __devinitdata = { > > > +static struct pci_device_id sis190_pci_tbl[] = { > > > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 }, > >

RE: Mostly revert "e1000/e1000e: Move PCI-Express device IDs over to e1000e"

2008-01-30 Thread Brandeburg, Jesse
Frans Pop wrote: > There is one thing I don't understand, but that may well be just me... > > From Linus' original patch: >> +++ b/drivers/net/e1000/e1000_main.c >> + INTEL_E1000_ETHERNET_DEVICE(0x108C), > > So, apparently support for 8086:108c was removed from the e1000 > driver. When it w

Re: [PACTH 1/1] drivers/net/usb: AX88178 100Mbps problem

2008-01-30 Thread David Hollis
On Mon, 2008-01-28 at 22:32 +0900, Reinin Oyama wrote: > Asix 88178 does not work under 100Mbps connection. > This patch correct the problem. > kernel version: 2.6.24 Please don't post the patch as a .gz, it's very small so just post it as text. Otherwise: Acked-by: David Hollis <[EMAIL PROTECT

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure (was: Re: fixed phy support (warning related to FIXED_MII_100_FDX))

2008-01-30 Thread Kumar Gala
From: Anton Vorontsov <[EMAIL PROTECTED]> Subject: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure This patch converts cpmac to the new Fixed PHY infrastructure, though it doesn't fix all the problems with that driver. I didn't even bother to test this patch to compile, because cp

Re: [NET]: should explicitely initialize atomic_t field in struct dst_ops

2008-01-30 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Thu, 24 Jan 2008 16:11:17 +0100 > All but one struct dst_ops static initializations miss explicit > initialization of entries field. > > As this field is atomic_t, we should use ATOMIC_INIT(0), and not > rely on atomic_t implementation. > > Signed-off

Re: [PATCH net-2.6.25][NETNS]: Fix race between put_net() and netlink_kernel_create().

2008-01-30 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 24 Jan 2008 16:15:13 +0300 > The comment about "race free view of the set of network > namespaces" was a bit hasty. Look (there even can be only > one CPU, as discovered by Alexey Dobriyan and Denis Lunev): ... > Instead, I propose to crate t

Re: [XFRM]: constify 'struct xfrm_type'

2008-01-30 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Thu, 24 Jan 2008 12:26:21 +0100 > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> Applied, thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vg

Re: [PATCH 1/1][NETNS] Add missing initialization of nl_info.nl_net in rtm_to_fib6_config()

2008-01-30 Thread David Miller
From: Benjamin Thery <[EMAIL PROTECTED]> Date: Thu, 24 Jan 2008 11:32:21 +0100 > Add missing initialization of the new nl_info.nl_net field in > rtm_to_fib6_config(). This will be needed the store network namespace > associated to the fib6_config struct. > > Signed-off-by: Benjamin Thery <[EMAIL

Re: [resend][PATCH] Introducing socket mark socket option

2008-01-30 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 24 Jan 2008 10:43:48 +0100 > Laszlo Attila Toth wrote: > > A userspace program may wish to set the mark for each packets its send > > without using the netfilter MARK target. Changing the mark can be used > > for mark based routing without netfi

Re: [PATCH] [AF_RXRPC]: constify function pointer tables

2008-01-30 Thread David Miller
From: Jan Engelhardt <[EMAIL PROTECTED]> Date: Tue, 22 Jan 2008 20:47:51 +0100 (CET) > Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] [1/1] Deprecate tcp_tw_{reuse,recycle}

2008-01-30 Thread Andi Kleen
On Wednesday 30 January 2008 20:22, Ben Greear wrote: > We use these features to enable creating very high numbers of short-lived > TCP connections, primarily used as a test tool for other network > devices. Hopefully these other network devices don't do any NAT then or don't otherwise violate th

Re: [PATCH retry] bluetooth : add conn add/del workqueues to avoid connection fail

2008-01-30 Thread Dave Young
On Jan 30, 2008 6:21 PM, Marcel Holtmann <[EMAIL PROTECTED]> wrote: > Hi Dave, > > > > The bluetooth hci_conn sysfs add/del executed in the default workqueue. > > > If the del_conn is executed after the new add_conn with same target, > > > add_conn will failed with warning of "same kobject name". >

Re: Mostly revert "e1000/e1000e: Move PCI-Express device IDs over to e1000e"

2008-01-30 Thread Frans Pop
Adrian Bunk wrote: >> Jeff, Auke, would something like this be acceptable? It makes it very >> obvious in the driver table which entries are for the PCIE versions that >> would be handled by the E1000E driver if it is enabled.. > > I don't like it: > We should aim at having exactly one driver for

Re: net-2.6.25 is no more...

2008-01-30 Thread David Miller
From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Wed, 30 Jan 2008 18:38:53 +0100 > David Miller wrote: > > From: Daniel Lezcano <[EMAIL PROTECTED]> > > Date: Wed, 30 Jan 2008 10:03:09 +0100 > > > >> David Miller wrote: > >>> Now that the bulk has been merged over and we are > >>> actively working a

Re: [PATCH] Optimize cxgb3 xmit path (a bit)

2008-01-30 Thread Divy Le Ray
Krishna Kumar wrote: Changes: 1. Add common code for stopping queue. 2. No need to call netif_stop_queue followed by netif_wake_queue (and infact a netif_start_queue could have been used instead), instead call stop_queue if required, and remove code under USE

[PATCHv2] PHYLIB: Add BCM5482 PHY support

2008-01-30 Thread Nate Case
This Broadcom PHY is similar to other bcm54xx devices. Signed-off-by: Nate Case <[EMAIL PROTECTED]> --- Note: This is a re-submission, correcting the bad indentation in the first patch drivers/net/phy/broadcom.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff

Re: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread SANGTAE HA
Hi Bruce, On Jan 30, 2008 5:25 PM, Bruce Allen <[EMAIL PROTECTED]> wrote: > > In our application (cluster computing) we use a very tightly coupled > high-speed low-latency network. There is no 'wide area traffic'. So it's > hard for me to understand why any networking components or software laye

Re: Mostly revert "e1000/e1000e: Move PCI-Express device IDs over to e1000e"

2008-01-30 Thread Adrian Bunk
On Wed, Jan 30, 2008 at 04:51:04PM +1100, Linus Torvalds wrote: > > > On Tue, 29 Jan 2008, Randy Dunlap wrote: > > > > Andrew was concerned about this when the driver was in -mm. > > He asked for a patch that would set E1000E to same value as E1000 > > and I supplied that. Auke acked it IIRC.

Re: [PATCH] PHYLIB: Add BCM5482 PHY support

2008-01-30 Thread Nate Case
On Wed, 2008-01-30 at 09:51 +, Maciej W. Rozycki wrote: > > +static struct phy_driver bcm5482_driver = { > > +.phy_id= 0x0143bcb0, > > + .phy_id_mask= 0xfff0, > > Please check formatting above and also I am a bit curious as to why the > ID is so different from t

Re: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Bruce Allen
Hi Stephen, Indeed, we are not asking to see 1000 Mb/s. We'd be happy to see 900 Mb/s. Netperf is trasmitting a large buffer in MTU-sized packets (min 1500 bytes). Since the acks are only about 60 bytes in size, they should be around 4% of the total traffic. Hence we would not expect to see

Re: [PATCH] net: NEWEMAC: Remove "rgmii-interface" from rgmii matching table

2008-01-30 Thread Benjamin Herrenschmidt
On Wed, 2008-01-30 at 07:16 +0100, Stefan Roese wrote: > On Wednesday 16 January 2008, Josh Boyer wrote: > > On Wed, 16 Jan 2008 20:53:59 +1100 > > > > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > > On Wed, 2008-01-16 at 10:37 +0100, Stefan Roese wrote: > > > > With the removal the the "r

Re: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Bruce Allen
Hi Rick, First off, thanks for netperf. I've used it a lot and find it an extremely useful tool. As asked in LKML thread, please post the exact netperf command used to start the client/server, whether or not you're using irqbalanced (aka irqbalance) and what cat /proc/interrupts looks like (y

RE: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Bruce Allen
Hi Jesse, It's good to be talking directly to one of the e1000 developers and maintainers. Although at this point I am starting to think that the issue may be TCP stack related and nothing to do with the NIC. Am I correct that these are quite distinct parts of the kernel? The 82573L (a cl

Re: [git patches] net driver fixes

2008-01-30 Thread Francois Romieu
Sam Ravnborg <[EMAIL PROTECTED]> : [...] > > -static struct pci_device_id sis190_pci_tbl[] __devinitdata = { > > +static struct pci_device_id sis190_pci_tbl[] = { > > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 }, > > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 }, > > { 0, }, >

Re: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Stephen Hemminger
On Wed, 30 Jan 2008 16:25:12 -0600 (CST) Bruce Allen <[EMAIL PROTECTED]> wrote: > Hi Stephen, > > Thanks for your helpful reply and especially for the literature pointers. > > >> Indeed, we are not asking to see 1000 Mb/s. We'd be happy to see 900 > >> Mb/s. > >> > >> Netperf is trasmitting a l

Re: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Bruce Allen
Hi Ben, Thank you for the suggestions and questions. We've connected a pair of modern high-performance boxes with integrated copper Gb/s Intel NICS, with an ethernet crossover cable, and have run some netperf full duplex TCP tests. The transfer rates are well below wire speed. We're reporti

Re: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Bruce Allen
Hi Stephen, Thanks for your helpful reply and especially for the literature pointers. Indeed, we are not asking to see 1000 Mb/s. We'd be happy to see 900 Mb/s. Netperf is trasmitting a large buffer in MTU-sized packets (min 1500 bytes). Since the acks are only about 60 bytes in size, they s

Re: [2.6 patch] make e1000_dump_eeprom() static

2008-01-30 Thread Kok, Auke
Adrian Bunk wrote: > This patch makes the needlessly global e1000_dump_eeprom() static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> yes, thanks, I'll push it to Jeff. Auke > > --- > b5fd924a1388d4aaa94cf05e42e317c2b1fb5748 > diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e10

Re: [2.6 patch] e1000e/ethtool.c: make a function static

2008-01-30 Thread Kok, Auke
Adrian Bunk wrote: > This patch makes the needlessly global reg_pattern_test_array() static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> stephen hemminger already pointed this out to me... I'll certainly push this upstream, thanks Adrian! Auke > > --- > ed72e457f06311390d9a9e51a00c9049

Re: [PATCH] Add another Prism2 card to hostap

2008-01-30 Thread Pavel Roskin
On Tue, 2008-01-29 at 09:42 +0100, Marcin Juszkiewicz wrote: > From: Marcin Juszkiewicz <[EMAIL PROTECTED]> > > Card reported by Ångström user: > http://bugs.openembedded.net/show_bug.cgi?id=3236 > > Socket 1: >product info: "Wireless LAN", "11Mbps PC Card", "Version 01.02", "" >manfid:

Re: [2.6 patch] unexport sysctl_tcp_tso_win_divisor

2008-01-30 Thread Ilpo Järvinen
On Wed, 30 Jan 2008, Adrian Bunk wrote: > This patch removes the no longer used > EXPORT_SYMBOL(sysctl_tcp_tso_win_divisor). > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > 4884e7997ba5f63f2efeaeead21ed2768fb3f4de > diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c > index

Re: [PATCH net-2.6.25 4/7][ATM]: [br2864] routed support

2008-01-30 Thread chas williams - CONTRACTOR
In message <[EMAIL PROTECTED]>,"Chung- Chi Lo" writes: >> + } else { /* vc-mux */ >> + if (brdev->payload == p_routed) { > >add line > > skb->protocol = __constant_htons(ETH_P_IP); > >here just like LLC did? > >> + skb_reset_network_he

Re: Compex FreedomLine 32 PnP-PCI2 broken with de2104x

2008-01-30 Thread Ondrej Zary
On Saturday 26 January 2008 21:58:10 Ondrej Zary wrote: > Hello, > I was having problems with these FreedomLine cards with Linux before but > tested it thoroughly today. This card uses DEC 21041 chip and has TP and > BNC connectors: > > 00:12.0 Ethernet controller [0200]: Digital Equipment Corporat

rtl8150: use default MTU of 1500

2008-01-30 Thread Lennert Buytenhek
The RTL8150 driver uses an MTU of 1540 by default, which causes a bunch of problems -- it prevents booting from NFS root, for one. Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> Cc: Petko Manolov <[EMAIL PROTECTED]> --- linux-2.6.24-git7.orig/drivers/net/usb/rtl8150.c2008-01-24 23:58:3

Re: [2.6 patch] rtnetlink.c: #if 0 no longer used functions

2008-01-30 Thread Patrick McHardy
Adrian Bunk wrote: This patch #if 0's the following no longer used functions: - rtattr_parse() - rtattr_strlcpy() - __rtattr_parse_nested_compat() Please remove them instead. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] Mo

Re: [2.6 patch] make nf_ct_path[] static

2008-01-30 Thread Patrick McHardy
Adrian Bunk wrote: This patch makes the needlessly global nf_ct_path[] static. I already have this queued. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[2.6 patch] net/sunqe.c section fix

2008-01-30 Thread Adrian Bunk
This patch fixes the following section mismatch: <-- snip --> ... WARNING: drivers/net/sunqe.o(.devinit.text+0x4): Section mismatch in reference from the function qec_sbus_probe() to the function .init.text:qec_ether_init() ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> -

[2.6 patch] make s2io.c:init_tti() static

2008-01-30 Thread Adrian Bunk
This patch makes the needlessly global init_tti() static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 1e8c2b07be955b181814e4c24366517a66557908 diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c index 5fab7d7..bc94e84 100644 --- a/drivers/net/s2io.c +++ b/drivers/net/s2io.c @@ -1088,7 +1

[2.6 patch] drivers/net/sunvnet.c:print_version() must be __devinit

2008-01-30 Thread Adrian Bunk
This patch fixes the following section mismatches: <-- snip --> ... WARNING: drivers/net/sunvnet.o(.text+0x220): Section mismatch in reference from the function print_version() to the variable .devinit.data:version WARNING: drivers/net/sunvnet.o(.text+0x228): Section mismatch in reference from

[2.6 patch] net/sunbmac.c section fix

2008-01-30 Thread Adrian Bunk
This patch fixes the following section mismatch: <-- snip --> ... WARNING: drivers/net/sunbmac.o(.devinit.text+0x24): Section mismatch in reference from the function bigmac_sbus_probe() to the function .init.text:bigmac_ether_init() ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL PROT

[2.6 patch] make net/802/tr.c:sysctl_tr_rif_timeout static

2008-01-30 Thread Adrian Bunk
sysctl_tr_rif_timeout can now become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- e5accd81b924224d40a3f38204c08cf6896ed79b diff --git a/net/802/tr.c b/net/802/tr.c index 3f16b17..18c6647 100644 --- a/net/802/tr.c +++ b/net/802/tr.c @@ -76,7 +76,7 @@ static DEFINE_SPINLOCK(rif_lock)

[2.6 patch] make nf_ct_path[] static

2008-01-30 Thread Adrian Bunk
This patch makes the needlessly global nf_ct_path[] static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 6396fbcebe3eb61f7e6eb1a671920a515912b005 diff --git a/net/netfilter/nf_conntrack_standalone.c b/net/netfilter/nf_conntrack_standalone.c index 696074a..5bd38a6 100644 --- a/net/netfilte

[2.6 patch] rtnetlink.c: #if 0 no longer used functions

2008-01-30 Thread Adrian Bunk
This patch #if 0's the following no longer used functions: - rtattr_parse() - rtattr_strlcpy() - __rtattr_parse_nested_compat() Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- include/linux/rtnetlink.h | 12 net/core/rtnetlink.c |9 ++--- 2 files changed, 6 insert

[2.6 patch] make struct ipv4_devconf static

2008-01-30 Thread Adrian Bunk
struct ipv4_devconf can now become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- include/linux/inetdevice.h |2 -- net/ipv4/devinet.c |2 +- 2 files changed, 1 insertion(+), 3 deletions(-) 20262a3317069b1bdbf2b37f4002fa5322445914 diff --git a/include/linux/inetdev

[2.6 patch] make e1000_dump_eeprom() static

2008-01-30 Thread Adrian Bunk
This patch makes the needlessly global e1000_dump_eeprom() static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- b5fd924a1388d4aaa94cf05e42e317c2b1fb5748 diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index 7f5b2ae..8a6645b 100644 --- a/drivers/net/e1000/e1000_

[2.6 patch] e1000e/ethtool.c: make a function static

2008-01-30 Thread Adrian Bunk
This patch makes the needlessly global reg_pattern_test_array() static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- ed72e457f06311390d9a9e51a00c904939466aff diff --git a/drivers/net/e1000e/ethtool.c b/drivers/net/e1000e/ethtool.c index 6d9c27f..a2034cf 100644 --- a/drivers/net/e1000e/etht

[2.6 patch] unexport ip6_find_1stfragopt

2008-01-30 Thread Adrian Bunk
This patch removes the no longer used EXPORT_SYMBOL_GPL(ip6_find_1stfragopt). Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 961bcbf7370019e35920a75d2d34c91b71708dfe diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 15c4f6c..ca707c0 100644 --- a/net/ipv6/ip6_output.c +++ b/ne

[2.6 patch] IBMLANA no longer has to depend on MCA_LEGACY

2008-01-30 Thread Adrian Bunk
This patch removes the no longer required dependency of IBMLANA on MCA_LEGACY. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- d83989118e59f403200ea9c71d2293337b49df01 diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index af40ff4..578ae2c 100644 --- a/drivers/net/Kconfig +++ b/drivers/

[2.6 patch] net/xfrm/: remove unused exports

2008-01-30 Thread Adrian Bunk
This patch removes the following no longer used EXPORT_SYMBOL's: - xfrm_input.c: xfrm_parse_spi - xfrm_state.c: xfrm_replay_check - xfrm_state.c: xfrm_replay_advance Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- net/xfrm/xfrm_input.c |1 - net/xfrm/xfrm_state.c |2 -- 2 files chang

[2.6 patch] unexport sysctl_tcp_tso_win_divisor

2008-01-30 Thread Adrian Bunk
This patch removes the no longer used EXPORT_SYMBOL(sysctl_tcp_tso_win_divisor). Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 4884e7997ba5f63f2efeaeead21ed2768fb3f4de diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 89f0188..ed750f9 100644 --- a/net/ipv4/tcp_output.c +++ b

[2.6 patch] ibmlana_init_one() must be __devinit

2008-01-30 Thread Adrian Bunk
This patch fixes the following section mismatch: <-- snip --> ... WARNING: drivers/net/built-in.o(.text+0x1148a5): Section mismatch in reference from the function ibmlana_init_one() to the variable .init.data:ibmlana_adapter_names ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL PROTEC

[2.6 patch] ibmlana_adapter_names[] must be __devinitdata

2008-01-30 Thread Adrian Bunk
This patch fixes the following section mismatch: <-- snip --> ... WARNING: drivers/net/built-in.o(.devinit.text+0x1baa4): Section mismatch in reference from the function ibmlana_init_one() to the variable .init.data:ibmlana_adapter_names ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL

[2.6 patch] via-rhine.c:rhine_hw_init() must be __devinit

2008-01-30 Thread Adrian Bunk
Thie patch fixes the following section mismatch: <-- snip --> ... WARNING: drivers/net/built-in.o(.text+0xdd840): Section mismatch in reference from the function rhine_hw_init() to the function .devinit.text:rhine_reload_eeprom() ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL PROTECT

[2.6 patch] olympic_open() must be __devinit

2008-01-30 Thread Adrian Bunk
This patch fixes the following section mismatch: <-- snip --> ... WARNING: drivers/net/built-in.o(.text+0x155573): Section mismatch in reference from the function olympic_open() to the function .devinit.text:olympic_init() ... <-- snip --> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --

Re: [PATCH] [1/1] Deprecate tcp_tw_{reuse,recycle}

2008-01-30 Thread Ben Greear
Andi Kleen wrote: We've recently had a long discussion about the CVE-2005-0356 time stamp denial-of-service attack. It turned out that Linux is only vunerable to this problem when tcp_tw_recycle is enabled (which it is not by default). In general these two options are not really usable in toda

Re: net-2.6.25 is no more...

2008-01-30 Thread Daniel Lezcano
Arnaldo Carvalho de Melo wrote: Em Wed, Jan 30, 2008 at 06:38:53PM +0100, Daniel Lezcano escreveu: David Miller wrote: From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Wed, 30 Jan 2008 10:03:09 +0100 David Miller wrote: Now that the bulk has been merged over and we are actively working alongsi

Re: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Ben Greear
Bruce Allen wrote: (Pádraig Brady has suggested that I post this to Netdev. It was originally posted to LKML here: http://lkml.org/lkml/2008/1/30/141 ) Dear NetDev, We've connected a pair of modern high-performance boxes with integrated copper Gb/s Intel NICS, with an ethernet crossover cab

Re: [drivers/net/bnx2.c] ADVERTISE_1000XPSE_ASYM

2008-01-30 Thread Michael Chan
On Wed, 2008-01-30 at 15:07 +0100, Roel Kluin wrote: > In drivers/net/bnx2.c:1285: it reads in function bnx2_setup_remote_phy(): > > if (pause_adv & (ADVERTISE_1000XPSE_ASYM | ADVERTISE_1000XPSE_ASYM)) > > Note that the two are the same and this is therefore equivalent to > > if (pause_adv & ADV

Re: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Rick Jones
As asked in LKML thread, please post the exact netperf command used to start the client/server, whether or not you're using irqbalanced (aka irqbalance) and what cat /proc/interrupts looks like (you ARE using MSI, right?) In particular, it would be good to know if you are doing two concurrent s

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure

2008-01-30 Thread Kumar Gala
Is this going through netdev or do you want me to pick it via the powerpc route? Based on your comments I sorta assumed it was most convenient to lump in with the rest of the powerpc changes... That's fine. I'll push it via the powerpc trees. - k -- To unsubscribe from this list: send the

Re: net-2.6.25 is no more...

2008-01-30 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 30, 2008 at 06:38:53PM +0100, Daniel Lezcano escreveu: > David Miller wrote: >> From: Daniel Lezcano <[EMAIL PROTECTED]> >> Date: Wed, 30 Jan 2008 10:03:09 +0100 >> >>> David Miller wrote: Now that the bulk has been merged over and we are actively working alongside Linus's tre

Re: b44 compile failure

2008-01-30 Thread maximilian attems
On Wed, 30 Jan 2008, John W. Linville wrote: > On Wed, Jan 30, 2008 at 11:59:26AM +0100, maximilian attems wrote: > > drivers/net/b44.c: In function 'b44_remove_one': > > drivers/net/b44.c:2231: error: implicit declaration of function > > 'ssb_pcihost_set_power_state' > > > > compiles fine on

Strange commit 42a73808ed4f30b739eb52bcbb33a02fe62ceef5

2008-01-30 Thread Adrian Bunk
Commit 42a73808ed4f30b739eb52bcbb33a02fe62ceef5 ("[RAW]: Consolidate proc interface.") did not only change raw6_seq_ops (including adding 3 EXPORT_SYMBOL_GPL's to net/ipv4/raw.c for accessing functions from there), it also removed the only user of raw6_seq_ops... cu Adrian -- "Is there

Re: net-2.6.25 is no more...

2008-01-30 Thread Daniel Lezcano
David Miller wrote: From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Wed, 30 Jan 2008 10:03:09 +0100 David Miller wrote: Now that the bulk has been merged over and we are actively working alongside Linus's tree I have moved all current patch applying to net-2.6 instead of net-2.6.25, so the curr

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure

2008-01-30 Thread Jeff Garzik
Kumar Gala wrote: On Jan 30, 2008, at 11:09 AM, Jeff Garzik wrote: Anton Vorontsov wrote: On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote: Anton, it looks like the "TI AR7 CPMAC Ethernet support" uses FIXED_PHY and was selecting FIXED_MII_100_FDX which is gone. Can you look i

RE: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Brandeburg, Jesse
Bruce Allen wrote: > Details: > Kernel version: 2.6.23.12 > ethernet NIC: Intel 82573L > ethernet driver: e1000 version 7.3.20-k2 > motherboard: Supermicro PDSML-LN2+ (one quad core Intel Xeon X3220, > Intel 3000 chipset, 8GB memory) Hi Bruce, The 82573L (a client NIC, regardless of the class of m

Re: [PATCH] [1/2] Skip empty hash buckets faster in /proc/net/tcp

2008-01-30 Thread Andi Kleen
On Wed, Jan 30, 2008 at 09:03:16AM -0800, Roland Dreier wrote: > > On a 2GB Core2 system here I see a time cat /proc/net/tcp > /dev/null > > constently dropping from 0.44s to 0.4-0.8s system time with this change. > > Seems like there must be a typo in either the before or after times > you repo

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure

2008-01-30 Thread Kumar Gala
On Jan 30, 2008, at 11:09 AM, Jeff Garzik wrote: Anton Vorontsov wrote: On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote: Anton, it looks like the "TI AR7 CPMAC Ethernet support" uses FIXED_PHY and was selecting FIXED_MII_100_FDX which is gone. Can you look into this. I get t

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure

2008-01-30 Thread Jeff Garzik
Anton Vorontsov wrote: On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote: Anton, it looks like the "TI AR7 CPMAC Ethernet support" uses FIXED_PHY and was selecting FIXED_MII_100_FDX which is gone. Can you look into this. I get the following warning now: scripts/kconfig/conf -s ar

Re: [BUILD FAILURE] 2.6.24-git7 section type conflict at various drivers on powerpc

2008-01-30 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 09:49:59PM +0530, Kamalesh Babulal wrote: > Hi, > > Following are the different build failure with 2.6.24-git7 kernel on the > powerpc > > drivers/net/typhoon.c:181: error: typhoon_card_info causes a section type > conflict > make[2]: *** [drivers/net/typhoon.o] Error 1

Re: [PATCH] [1/2] Skip empty hash buckets faster in /proc/net/tcp

2008-01-30 Thread Roland Dreier
> On a 2GB Core2 system here I see a time cat /proc/net/tcp > /dev/null > constently dropping from 0.44s to 0.4-0.8s system time with this change. Seems like there must be a typo in either the before or after times you report here? -- To unsubscribe from this list: send the line "unsubscribe net

Re: e1000 performance issue in 4 simultaneous links

2008-01-30 Thread Kok, Auke
Denys Fedoryshchenko wrote: > Sorry. that i interfere in this subject. > > Do you recommend CONFIG_IRQBALANCE to be enabled? I certainly do not. Manual tweaking and pinning the irq's to the correct CPU will give the best performance (for specific loads). The userspace irqbalance daemon tries ve

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure (was: Re: fixed phy support (warning related to FIXED_MII_100_FDX))

2008-01-30 Thread Kumar Gala
On Jan 21, 2008, at 2:49 PM, Anton Vorontsov wrote: On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote: Anton, it looks like the "TI AR7 CPMAC Ethernet support" uses FIXED_PHY and was selecting FIXED_MII_100_FDX which is gone. Can you look into this. I get the following warning now:

Re: [RFC/PATCH] e100 driver didn't support any MII-less PHYs...

2008-01-30 Thread Kok, Auke
Andreas Mohr wrote: > Hi, > > On Tue, Jan 29, 2008 at 03:09:25PM -0800, Kok, Auke wrote: >> Andreas Mohr wrote: >>> Perhaps it's useful to file a bug/patch >>> on http://sourceforge.net/projects/e1000/ ? Perhaps -mm testing? >> I wanted to push this though our testing labs first which has not happ

[BUILD FAILURE] 2.6.24-git7 section type conflict at various drivers on powerpc

2008-01-30 Thread Kamalesh Babulal
Hi, Following are the different build failure with 2.6.24-git7 kernel on the powerpc drivers/net/typhoon.c:181: error: typhoon_card_info causes a section type conflict make[2]: *** [drivers/net/typhoon.o] Error 1 drivers/net/natsemi.c:259: error: natsemi_pci_info causes a section type conflict

Re: b44 compile failure

2008-01-30 Thread John W. Linville
On Wed, Jan 30, 2008 at 11:59:26AM +0100, maximilian attems wrote: > drivers/net/b44.c: In function 'b44_remove_one': > drivers/net/b44.c:2231: error: implicit declaration of function > 'ssb_pcihost_set_power_state' > > compiles fine on 64 bit x86, but not on 32, see log: > > http://stats.bu

Re: Mostly revert "e1000/e1000e: Move PCI-Express device IDs over to e1000e"

2008-01-30 Thread Kok, Auke
Jeff Garzik wrote: > Linus Torvalds wrote: >> >> On Tue, 29 Jan 2008, Randy Dunlap wrote: >>> Andrew was concerned about this when the driver was in -mm. >>> He asked for a patch that would set E1000E to same value as E1000 >>> and I supplied that. Auke acked it IIRC. Other people vetoed it. :(

Re: [PATCH] NET: constify data and function pointer tables

2008-01-30 Thread John W. Linville
On Wed, Jan 30, 2008 at 04:25:17AM -0500, Jeff Garzik wrote: > Jan Engelhardt wrote: >> Signed-off-by: Jan Engelhardt <[EMAIL PROTECTED]> >> --- >> drivers/net/bonding/bond_main.c |2 +- >> drivers/net/hamradio/bpqether.c |2 +- >> drivers/net/hamradio/scc.c |

Re: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Stephen Hemminger
On Wed, 30 Jan 2008 08:01:46 -0600 (CST) Bruce Allen <[EMAIL PROTECTED]> wrote: > Hi David, > > Thanks for your note. > > >> (The performance of a full duplex stream should be close to 1Gb/s in > >> both directions.) > > > > This is not a reasonable expectation. > > > > ACKs take up space on the

Re: [PATCH 3/3] netns netfilter: create per-netns /proc/net/*_tables_*

2008-01-30 Thread Patrick McHardy
Alexey Dobriyan wrote: Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- include/linux/netfilter/x_tables.h |4 ++-- net/ipv4/netfilter/arp_tables.c| 21 ++--- net/ipv4/netfilter/ip_tables.c | 21 ++--- net/ipv6/netfilter/ip6_tables.c|

Re: [PATCH 1/3] netns netfilter: semi-rewrite of /proc/net/foo_tables_*

2008-01-30 Thread Patrick McHardy
Alexey Dobriyan wrote: Argh, there are many small but still wrong things with /proc/net/*_tables_* so I decided to do overhaul simultaneously making it more suitable for per-netns /proc/net/*_tables_* implementation. Fix a) xt_get_idx() duplicating now standard seq_list_start/seq_list_next it

Re: [PATCH 2/3] netns netfilter: netns propagation for /proc/net/*_tables_names

2008-01-30 Thread Patrick McHardy
Alexey Dobriyan wrote: Propagate netns together with AF down to ->start/->next/->stop iterators. Choose table based on netns and AF for showing. Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at h

[PATCH][net/sched/sch_teql.c] duplicate IFF_BROADCAST in FMASK, remove 2nd

2008-01-30 Thread Roel Kluin
Untested patch below, please confirm it's the right fix (should it be some other IFF_*?) -- duplicate IFF_BROADCAST, remove 2nd Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/net/sched/sch_teql.c b/net/sched/sch_teql.c index c0ed06d..a53acf4 100644 --- a/net/sched/sch_teql.c +++ b/

[drivers/net/bnx2.c] ADVERTISE_1000XPSE_ASYM

2008-01-30 Thread Roel Kluin
In drivers/net/bnx2.c:1285: it reads in function bnx2_setup_remote_phy(): if (pause_adv & (ADVERTISE_1000XPSE_ASYM | ADVERTISE_1000XPSE_ASYM)) Note that the two are the same and this is therefore equivalent to if (pause_adv & ADVERTISE_1000XPSE_ASYM) This appears to be incorrect, was maybe '| A

Re: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Bruce Allen
Hi David, Thanks for your note. (The performance of a full duplex stream should be close to 1Gb/s in both directions.) This is not a reasonable expectation. ACKs take up space on the link in the opposite direction of the transfer. So the link usage in the opposite direction of the transfer

Re: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread David Miller
From: Bruce Allen <[EMAIL PROTECTED]> Date: Wed, 30 Jan 2008 03:51:51 -0600 (CST) [ netdev@vger.kernel.org added to CC: list, that is where kernel networking issues are discussed. ] > (The performance of a full duplex stream should be close to 1Gb/s in > both directions.) This is not a reasona

Re: net-2.6.25 is no more...

2008-01-30 Thread David Miller
From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Wed, 30 Jan 2008 10:03:09 +0100 > David Miller wrote: > > Now that the bulk has been merged over and we are > > actively working alongside Linus's tree I have moved > > all current patch applying to net-2.6 instead of net-2.6.25, > > so the current tr

Re: [PATCH] [2/2] Remove some unnecessary gotos in established_get_first()

2008-01-30 Thread David Miller
From: Oliver Neukum <[EMAIL PROTECTED]> Date: Wed, 30 Jan 2008 09:25:12 +0100 > Now suppose somebody needs to change locking. He'll have to convert > it back. IMHO a conditional return is worse than "goto clearly_named_label" I totally agree. -- To unsubscribe from this list: send the line "unsub

[PATCH] [SIS190] Use __devinitconst for const devinit data

2008-01-30 Thread Jonas Bonn
Mixing const and __section was previously not allowed. New __devinitconst tag allows this. This fixes a gcc "section type mismatch" build error. --- drivers/net/sis190.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

2008-01-30 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 02:31:05PM +0100, Jan Engelhardt wrote: > > On Jan 30 2008 12:25, Sam Ravnborg wrote: > > > >We have just introduced __initconst, __cpuinitconst, __meminitconst > >for const data. > >So the patch is wrong. > > Oh joy, more tags. Is it actually possible to combine const > w

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

2008-01-30 Thread Jan Engelhardt
On Jan 30 2008 12:25, Sam Ravnborg wrote: > >We have just introduced __initconst, __cpuinitconst, __meminitconst >for const data. >So the patch is wrong. Oh joy, more tags. Is it actually possible to combine const with __devinitconst now? static const uint16_t foo[] __devinitconst = { ... }; --

  1   2   >