Re: [PATCH] Add Linksys WCF11 to hostap driver

2007-12-28 Thread Pavel Roskin
Hello! On Fri, 2007-12-28 at 14:16 +0100, Marcin Juszkiewicz wrote: > + PCMCIA_DEVICE_PROD_ID1234( > + "The Linksys Group, Inc.", "Wireless Network CF Card", > "ISL37300P", > + "RevA", > + 0xa5f472c2, 0x9c05598d, 0xc9049a39, 0x57a66194), I would p

Fwd: skbuff data pointer alignment requirement

2007-12-28 Thread Keyur Chudgar
-- Forwarded message -- From: Keyur Chudgar <[EMAIL PROTECTED]> Date: Dec 28, 2007 4:53 PM Subject: Re: skbuff data pointer alignment requirement To: Jarek Poplawski <[EMAIL PROTECTED]> Hi Jarek, > Do you mean hardware requirements of an architecture or a specific driver? I meant

Re: [PATCH] Make FC, FDDI, HIPPI and TR tristate

2007-12-28 Thread Adrian Bunk
On Sat, Dec 29, 2007 at 01:41:23AM +0100, Jan Engelhardt wrote: > > On Dec 29 2007 02:09, Adrian Bunk wrote: > >On Sat, Dec 29, 2007 at 12:45:12AM +0100, Jan Engelhardt wrote: > >> Turn CONFIG_FC, CONFIG_FDDI, CONFIG_HIPPI and CONFIG_TR into tristate > >> so they can be built as modules. This will

Re: [PATCH] Make FC, FDDI, HIPPI and TR tristate

2007-12-28 Thread Jan Engelhardt
On Dec 29 2007 02:09, Adrian Bunk wrote: >On Sat, Dec 29, 2007 at 12:45:12AM +0100, Jan Engelhardt wrote: >> Turn CONFIG_FC, CONFIG_FDDI, CONFIG_HIPPI and CONFIG_TR into tristate >> so they can be built as modules. This will allow CONFIG_LLC to be >> built as a module too, overall reducing the cor

Re: [PATCH] Make FC, FDDI, HIPPI and TR tristate

2007-12-28 Thread Adrian Bunk
On Sat, Dec 29, 2007 at 12:45:12AM +0100, Jan Engelhardt wrote: > Turn CONFIG_FC, CONFIG_FDDI, CONFIG_HIPPI and CONFIG_TR into tristate > so they can be built as modules. This will allow CONFIG_LLC to be > built as a module too, overall reducing the core kernel image size. >... Just an example of

[RFC/PATCH] e100 driver didn't support any MII-less PHYs...

2007-12-28 Thread Andreas Mohr
Hi all, I was mildly annoyed when rebooting my _headless_ internet gateway after a hotplug -> udev migration and witnessing it not coming up again, which turned out to be due to an eepro100 / e100 loading conflict since eepro100 supported both of my Intel-based network cards, whereas e100 only sup

[PATCH] Make FC, FDDI, HIPPI and TR tristate

2007-12-28 Thread Jan Engelhardt
Turn CONFIG_FC, CONFIG_FDDI, CONFIG_HIPPI and CONFIG_TR into tristate so they can be built as modules. This will allow CONFIG_LLC to be built as a module too, overall reducing the core kernel image size. $ size vmlinux.previous vmlinux textdata bss dec hex filename 2805040

Re: 2.6.24-rc6-mm1

2007-12-28 Thread Andrew Morton
On Fri, 28 Dec 2007 23:53:49 +0100 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: > On Dec 23, 2007 5:27 PM, Torsten Kaiser <[EMAIL PROTECTED]> wrote: > > On Dec 23, 2007 8:30 AM, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24

[PATCH][ROSE][AX25] af_ax25: possible circular locking

2007-12-28 Thread Jarek Poplawski
On Fri, Dec 28, 2007 at 09:43:07PM +0100, Pidoux wrote: ... > After a few days of observation and a number of reboot for test purpose, I > confirm that your patch is doing very well. > I have no more problems rebooting and the AX25 applications are running > fine. > > I hope this patch, with or w

Re: [ROSE] [AX25] possible circular locking

2007-12-28 Thread Pidoux
Jarek Poplawski wrote : On Mon, Dec 17, 2007 at 11:06:04AM +0100, Bernard Pidoux F6BVP wrote: Hi, When I killall kissattach I can see the following message. This happens on kernel 2.6.24-rc5 already patched with the 6 previously patches I sent recently. ==

Re: [PATCH 0/2] netem: trace enhancement: kernel

2007-12-28 Thread Ariane Keller
Thanks for your comments! Patrick McHardy wrote: Ariane Keller wrote: +/* must be divisible by 4 (=#pkts)*/ +#define DATA_PACKAGE 4000 Its not obvious that this refers to a size, please rename to something more approriate. And why is it hardcoded to 4000? Shouldn't it be related to NLMSG_GO

Re: [PATCH] via-velocity big-endian support

2007-12-28 Thread Al Viro
On Wed, Dec 26, 2007 at 12:21:35AM +0100, Francois Romieu wrote: > -> some descriptor bits are now declared with an explicit endianness >while others are not (whence "u16 rsr" where "__le16 rsr" whould >have fit). Both are fine but it would not hurt to stick with one >convention in a gi

[PATCH][v2] phylib: add module owner to the mii_bus structure

2007-12-28 Thread Ionut Nicu
Prevent unloading mii bus driver module when other modules have references to some phydevs on that bus. Added a new member (module owner) to struct mii_bus and added code to increment the mii bus owner module usage count on phy_connect and decrement it on phy_disconnect Set the module owner in

Re: [PATCH 0/2] netem: trace enhancement: kernel

2007-12-28 Thread Patrick McHardy
Ariane Keller wrote: +struct tc_netem_stats +{ +int packetcount; +int packetok; +int normaldelay; +int drops; +int dupl; +int corrupt; +int novaliddata; +int reloadbuffer; These should be unsigned int or __u32. diff -uprN -X linux-2.6.23.8/Documentation/dontdi

[PATCH net-2.6.25] [NEIGH] Remove unused method from include/net/neighbour.h

2007-12-28 Thread Rami Rosen
Hello, It seems to me that neigh_is_valid() inline method from include/net/neighbour.h can be removed since it is not used. Though it can be considered as an API for future use, and indeed we have neigh_is_connected() method in this same header (which is BTW used only in one place, drivers/net/cxg

Re: [PATCH] net/ipv4/netfilter/ip_tables.c: remove some inlines

2007-12-28 Thread Patrick McHardy
Denys Vlasenko wrote: On Monday 17 December 2007 14:47, Patrick McHardy wrote: This clashes with my pending patches, which I'll push upstream today. I also spent some time resyncing ip_tables and ip6_tables so a diff of both (with some sed'ing) shows only the actual differences, so please upd

[PATCH net-2.6.25] [IPv4] Remove unused define in include/net/arp.h (HAVE_ARP_CREATE)

2007-12-28 Thread Rami Rosen
Hello, It seems to me that the HAVE_ARP_CREATE (empty) definition, from include/net/arp.h, can be removed, since it is not used anywhere in the kernel. Regards, Rami Rosen http://www.linux-foundation.org/en/Net:Network_Overview Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/include/

Re: testing crazy stuff with iproute2

2007-12-28 Thread Denys Fedoryshchenko
Prio is limited. I can have on PPPoE up to 500-600 customers, and i need to create for each in ifb device class/qdisc. So prio will not fit. On Fri, 28 Dec 2007 11:18:27 +0100, Jarek Poplawski wrote > On Fri, Dec 28, 2007 at 01:44:17AM +0200, Denys Fedoryshchenko wrote: > > > For bandwidth s

[PATCH] Add Linksys WCF11 to hostap driver

2007-12-28 Thread Marcin Juszkiewicz
From: Marcin Juszkiewicz <[EMAIL PROTECTED]> Linksys WCF11 submitted by Ångström user. "The Linksys Group, Inc.", "Wireless Network CF Card", "ISL37300P", "RevA", 0xa5f472c2, 0x9c05598d, 0xc9049a39, 0x57a66194 manfid: 0x0274, 0x3301 Signed-off-by: Marcin Juszkiewicz <[EMAIL PROTECTED]> --- d

Re: testing crazy stuff with iproute2

2007-12-28 Thread Jarek Poplawski
On Fri, Dec 28, 2007 at 01:44:17AM +0200, Denys Fedoryshchenko wrote: ... > For bandwidth sharing it is perfect, but i want just to make things, which i > did with TBF - some time bursty speed, and then slow down to lower speed if > customer is using too much. In theory it has to work like this,

Re: [PATCH net-2.6.25] CAN: Fix plain integer definitions in userspace header & new CAN version 20071227

2007-12-28 Thread Oliver Hartkopp
Oliver Hartkopp wrote: David Miller wrote: The types are exactly the same size regardless of anything. There is no reason to make such a big fuss about this, changing the CAN version etc. Btw. you are perfectly right with your remark. I'll revert the CAN version in the SocketCAN SVN back to

Re: [PATCH net-2.6.25] CAN: Fix plain integer definitions in userspace header & new CAN version 20071227

2007-12-28 Thread Oliver Hartkopp
David Miller wrote: From: Oliver Hartkopp <[EMAIL PROTECTED]> Date: Thu, 27 Dec 2007 21:14:57 +0100 This patch fixes the use of plain integers instead of __u32 in a struct that is visible from kernel space and user space. As this change is user visible this patch also updates the CAN versio

Re: [PATCH net-2.6.25] CAN: Fix plain integer definitions in userspace header & new CAN version 20071227

2007-12-28 Thread Oliver Hartkopp
David Miller wrote: From: Oliver Hartkopp <[EMAIL PROTECTED]> Date: Thu, 27 Dec 2007 21:14:57 +0100 diff -uprN -X net-2.6.25/Documentation/dontdiff net-2.6.25/include/linux/can/bcm.h export/net2625-2007-12-27/include/linux/can/bcm.h --- net-2.6.25/include/linux/can/bcm.h 2007-12-15 19:33:

Re: fib6_del_route has redundant code

2007-12-28 Thread Gui Jianfeng
> From: Gui Jianfeng <[EMAIL PROTECTED]> > Date: Fri, 28 Dec 2007 13:58:21 +0800 > I think the following code in fib6_del_route in the latest kernel is useless. 1125 if (fn->leaf == NULL && fn->fn_flags&RTN_TL_ROOT) 1126 fn->leaf = &ip6_null_entry;

Re: fib6_del_route has redundant code

2007-12-28 Thread David Miller
From: Gui Jianfeng <[EMAIL PROTECTED]> Date: Fri, 28 Dec 2007 13:58:21 +0800 > >> I think the following code in fib6_del_route in the latest kernel is > >> useless. > >> 1125 if (fn->leaf == NULL && fn->fn_flags&RTN_TL_ROOT) > >> 1126 fn->leaf = &ip6_null_entry; > >> > >>