Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-27 Thread Andreas Mohr
Hi, On Fri, Dec 28, 2007 at 09:22:01AM +0300, Alexey Dobriyan wrote: > On Thu, Dec 27, 2007 at 11:17:28PM +0100, Andreas Mohr wrote: > > And this is the state that my 2.6.24-rc_six_-mm1 tree is in already. > > OK. > > > So either it didn't help here or it broke again by some later change or > >

[PATCH] remove useless code from fib6_del_route

2007-12-27 Thread Gui Jianfeng
Hi Dave, There are useless codes in fib6_del_route(). The following patch has been tested, every thing looks fine, as usual. Signed-off-by: Gui Jianfeng<[EMAIL PROTECTED]> --- net/ipv6/ip6_fib.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/net/ipv6/ip6_fib.c b/net/i

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-27 Thread Alexey Dobriyan
gt; > > > > > > > > > > > Yes. Denis and Eric are tossing around competing patches but afaik > > > > nobody > > > > is happy with any of them. Guys, could we get this sorted soonish > > > > please? > > > > > &g

Re: fib6_del_route has redundant code

2007-12-27 Thread Gui Jianfeng
>> I think the following code in fib6_del_route in the latest kernel is useless. >> 1125 if (fn->leaf == NULL && fn->fn_flags&RTN_TL_ROOT) >> 1126 fn->leaf = &ip6_null_entry; >> >> ip6_null_entry will never be unlinked from fn->leaf now, that is, >> fn->leaf == NULL will nev

[no subject]

2007-12-27 Thread Li Yewang
subscribe netdev -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: fib6_del_route has redundant code

2007-12-27 Thread David Miller
From: Gui Jianfeng <[EMAIL PROTECTED]> Date: Thu, 27 Dec 2007 15:26:46 +0800 > I think the following code in fib6_del_route in the latest kernel is useless. > 1125 if (fn->leaf == NULL && fn->fn_flags&RTN_TL_ROOT) > 1126 fn->leaf = &ip6_null_entry; > > ip6_null_entry will

Re: [PATCH net-2.6.25] CAN: Add missing Kbuild entries

2007-12-27 Thread David Miller
From: Oliver Hartkopp <[EMAIL PROTECTED]> Date: Thu, 27 Dec 2007 21:14:53 +0100 > This patch adds the missing Kbuild entries and the missing Kbuild file > in include/linux/can for the CAN subsystem. > > It applies on the current net-2.6.25 tree. > > Tnx & best regards, > Oliver > > Signed-off-

Re: [PATCH net-2.6.25] CAN: Fix plain integer definitions in userspace header & new CAN version 20071227

2007-12-27 Thread David Miller
From: Oliver Hartkopp <[EMAIL PROTECTED]> Date: Thu, 27 Dec 2007 21:14:57 +0100 > diff -uprN -X net-2.6.25/Documentation/dontdiff > net-2.6.25/include/linux/can/bcm.h > export/net2625-2007-12-27/include/linux/can/bcm.h > --- net-2.6.25/include/linux/can/bcm.h2007-12-15 19:33:20.0

Re: [PATCH net-2.6.25] CAN: Fix plain integer definitions in userspace header & new CAN version 20071227

2007-12-27 Thread David Miller
From: Oliver Hartkopp <[EMAIL PROTECTED]> Date: Thu, 27 Dec 2007 21:14:57 +0100 > This patch fixes the use of plain integers instead of __u32 in a struct > that is visible from kernel space and user space. As this change is user > visible this patch also updates the CAN vers

Re: [PATCH 2.6.25] compilation fix for drivers/net/wireless/libertas/debugfs.c

2007-12-27 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Thu, 27 Dec 2007 13:24:54 +0300 > Compilation fix. MAC_FMT is required for > drivers/net/wireless/libertas/debugfs.c Putting this public macro back into a header file just for one driver's debug handling is just rediculious. I've checked in the fo

Re: netlink_proto_init and sock_init

2007-12-27 Thread David Miller
From: Octavian Purdila <[EMAIL PROTECTED]> Date: Thu, 27 Dec 2007 14:48:56 +0200 > I've noticed that with some exotic build setups (e.g. mingw) > netlink_proto_init is called before sock_init and subsequently sock_alloc > runs into a NULL sock_mnt. The following patch seems to fix the problem, b

Re: testing crazy stuff with iproute2

2007-12-27 Thread Denys Fedoryshchenko
On Thu, 27 Dec 2007 23:54:55 +0100, Jarek Poplawski wrote > On Thu, Dec 27, 2007 at 11:25:53PM +0200, Denys Fedoryshchenko wrote: > > I will try to talk in lartc, about HTB i wrote another mail... > > It is not acting as TBF with burst, it is even acting weird. Probably it is > > bug, when traffi

Re: testing crazy stuff with iproute2

2007-12-27 Thread Jarek Poplawski
On Thu, Dec 27, 2007 at 11:25:53PM +0200, Denys Fedoryshchenko wrote: > I will try to talk in lartc, about HTB i wrote another mail... > It is not acting as TBF with burst, it is even acting weird. Probably it is > bug, when traffic get "blocked" cause of burst. HTB was probably projected to be s

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-27 Thread Andreas Mohr
afaik nobody > > > is happy with any of them. Guys, could we get this sorted soonish please? > > > > "Soonish" being rather earlier than 20071227? > > 'cause it's still throwing a fit for me on 2.6.24-rc6-mm1(!) (plus hotfix), > >

Re: testing crazy stuff with iproute2

2007-12-27 Thread Denys Fedoryshchenko
I will try to talk in lartc, about HTB i wrote another mail... It is not acting as TBF with burst, it is even acting weird. Probably it is bug, when traffic get "blocked" cause of burst. I will try to use lartc, if it is better to not "spam" my stuff here :-) I didn't try yet PSPacer yet, as ESF

Re: testing crazy stuff with iproute2

2007-12-27 Thread Jarek Poplawski
Denys Fedoryshchenko wrote, On 12/26/2007 05:57 AM: ... > But i got few times in dmesg, during tests (probably when i set sfq instead > pfifo, or etc). > > [2090816.116000] htb: class 10003 isn't work conserving ?! > > Is it a bug? And does it worth to do such "shaper"? It's not a bug - htb si

[PATCH net-2.6.25] CAN: Fix plain integer definitions in userspace header & new CAN version 20071227

2007-12-27 Thread Oliver Hartkopp
This patch fixes the use of plain integers instead of __u32 in a struct that is visible from kernel space and user space. As this change is user visible this patch also updates the CAN version to 20071227. Thanks to Sam Ravnborg for pointing out the wrong plain int usage. It applies on the

[PATCH net-2.6.25] CAN: Add missing Kbuild entries

2007-12-27 Thread Oliver Hartkopp
This patch adds the missing Kbuild entries and the missing Kbuild file in include/linux/can for the CAN subsystem. It applies on the current net-2.6.25 tree. Tnx & best regards, Oliver Signed-off-by: Oliver Hartkopp <[EMAIL PROTECTED]> Acked-by: Sam Ravnborg <[EMAIL PROTECTED]> --- diff -uprN

Re: [RFC] skge csum problems

2007-12-27 Thread Stephen Hemminger
On Mon, 24 Dec 2007 19:45:23 + Al Viro <[EMAIL PROTECTED]> wrote: > On Mon, Dec 24, 2007 at 11:36:38AM -0800, Stephen Hemminger wrote: > > > you will get the same behaviour on big- and little-endian boxen, even > > > though > > > the intermediate integer values will be of course different. >

[PATCH] [NET] Fixed a small typo in the loopback driver

2007-12-27 Thread Emil Medve
This is probably a result of the changes from commit 854d836 - [NET]: Dynamically allocate the loopback device, part 2 Signed-off-by: Emil Medve <[EMAIL PROTECTED]> --- linux-2.6> scripts/checkpatch.pl 0001-NET-Fixed-a-small-typo-in-the-loopback-driver.patch total: 0 errors, 0 warnings, 8 lines

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-27 Thread Alexey Dobriyan
> > > always appears empty now, whatever's supposed to be mounted there. > > > > > > > Yes. Denis and Eric are tossing around competing patches but afaik nobody > > is happy with any of them. Guys, could we get this sorted soonish please? > > &qu

Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage

2007-12-27 Thread Andreas Mohr
re. > > > > Yes. Denis and Eric are tossing around competing patches but afaik nobody > is happy with any of them. Guys, could we get this sorted soonish please? "Soonish" being rather earlier than 20071227? 'cause it's still throwing a fit for me on 2.6.24-

netlink_proto_init and sock_init

2007-12-27 Thread Octavian Purdila
Hi, I've noticed that with some exotic build setups (e.g. mingw) netlink_proto_init is called before sock_init and subsequently sock_alloc runs into a NULL sock_mnt. The following patch seems to fix the problem, but I'm not sure if this is the right thing to do, as there are no _initcall_sync

Re: [git patches] net driver fixes

2007-12-27 Thread Jeff Garzik
Meelis Roos wrote: JG> A couple [minorly] notable wireless bug fixes, and plenty of viro fixes JG> for obscure issues :) What about the tulip NAPI fix from Stephen Hemminger? Without this, my tulip is hosed easily. The thread where I reported it was "Badness at net/core/dev.c:2199", around D

Re: [git patches] net driver fixes

2007-12-27 Thread Meelis Roos
JG> A couple [minorly] notable wireless bug fixes, and plenty of viro fixes JG> for obscure issues :) What about the tulip NAPI fix from Stephen Hemminger? Without this, my tulip is hosed easily. The thread where I reported it was "Badness at net/core/dev.c:2199", around Dec 16. -- Meelis Roo

[PATCH 2.6.25] compilation fix for drivers/net/wireless/libertas/debugfs.c

2007-12-27 Thread Denis V. Lunev
Compilation fix. MAC_FMT is required for drivers/net/wireless/libertas/debugfs.c The problem has been introduced by the commit 4b326fa2167d4ee2d722bff4e241fae299e32442 Author: Michael Chan <[EMAIL PROTECTED]> Date: Mon Dec 24 21:28:09 2007 -0800 diff --git a/include/linux/if_ether.h b/include/l

[PATCH 2.6.25] compilation fix for drivers/net/wireless/libertas/debugfs.c (fixed signed-off)

2007-12-27 Thread Denis V. Lunev
Compilation fix. MAC_FMT is required for drivers/net/wireless/libertas/debugfs.c The problem has been introduced by the commit 4b326fa2167d4ee2d722bff4e241fae299e32442 Author: Michael Chan <[EMAIL PROTECTED]> Date: Mon Dec 24 21:28:09 2007 -0800 Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>

Re: Strange Panic (Deadlock)

2007-12-27 Thread Badalian Vyacheslav
Jarek Poplawski пишет: > On 26-12-2007 19:58, Jarek Poplawski wrote: > >> ... >> > > And here is one more: this place needs more advanced debugging, but > let's check something simple at the beginning... (and just like before > - could be tested with or without these earlier patches). > > J

sunhme x86 SMP issues

2007-12-27 Thread Costa Tsaousis
Merry Christams, I would like to report incompatibilities of the sunhme driver with x86 SMP. My configuration: Tyan S2466 motherboard with 2x Athlon MP 2400+ Kernel: 2.6.23-gentoo-r3 lscpi: 00:00.0 Host bridge: Advanced Micro Devices [AMD] AMD-760 MP [IGD4-2P] System Controller (rev 20) 00:01.

Re: : Emit event stream compat iw_point objects correctly.

2007-12-27 Thread David Miller
From: Masakazu Mokuno <[EMAIL PROTECTED]> Date: Thu, 27 Dec 2007 18:24:40 +0900 > On ppc64 (PS3), IW_EV_LCP_LEN is 8, not 4. > > include/linux/wireless.h: > > #define IW_EV_LCP_LEN (sizeof(struct iw_event) - sizeof(union iwreq_data)) > > where sizeof(struct iw_event) == 24, sizeof(union iwreq

Re: : Emit event stream compat iw_point objects correctly.

2007-12-27 Thread Masakazu Mokuno
On Thu, 27 Dec 2007 00:57:25 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Masakazu Mokuno <[EMAIL PROTECTED]> > Date: Thu, 27 Dec 2007 17:51:49 +0900 > > > Hi > > > > On Fri, 21 Dec 2007 20:58:08 -0800 (PST) > > David Miller <[EMAIL PROTECTED]> wrote: > > > > > @@ -520,7 +53

Re: : Emit event stream compat iw_point objects correctly.

2007-12-27 Thread David Miller
From: Masakazu Mokuno <[EMAIL PROTECTED]> Date: Thu, 27 Dec 2007 17:51:49 +0900 > Hi > > On Fri, 21 Dec 2007 20:58:08 -0800 (PST) > David Miller <[EMAIL PROTECTED]> wrote: > > > @@ -520,7 +530,7 @@ iwe_stream_add_point(char * stream, /* > > Stream of events */ > >

Re: : Emit event stream compat iw_point objects correctly.

2007-12-27 Thread Masakazu Mokuno
Hi On Fri, 21 Dec 2007 20:58:08 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > @@ -520,7 +530,7 @@ iwe_stream_add_point(char * stream, /* > Stream of events */ > memcpy(stream + IW_EV_LCP_LEN, > ((char *) iwe) + IW_EV_LCP_LEN + IW_E