fib6_del_route has redundant code

2007-12-26 Thread Gui Jianfeng
Hi all, I think the following code in fib6_del_route in the latest kernel is useless. 1125 if (fn->leaf == NULL && fn->fn_flags&RTN_TL_ROOT) 1126 fn->leaf = &ip6_null_entry; ip6_null_entry will never be unlinked from fn->leaf now, that is, fn->leaf == NULL will never meet.

Re: Strange Panic (Deadlock)

2007-12-26 Thread Jarek Poplawski
On 26-12-2007 19:58, Jarek Poplawski wrote: > ... And here is one more: this place needs more advanced debugging, but let's check something simple at the beginning... (and just like before - could be tested with or without these earlier patches). Jarek P. [PATCH 4/3] (for testing only) --- dif

Re: [PATCH] net/ipv4/netfilter/ip_tables.c: remove some inlines

2007-12-26 Thread Denys Vlasenko
On Monday 17 December 2007 14:47, Patrick McHardy wrote: > Please CC netfilter-devel on netfilter patches. > > Denys Vlasenko wrote: > > Hi Patrick, Harald, > > > > I was working on unrelated problem and noticed that ip_tables.c > > seem to abuse inline. I prepared a patch which removes inlines > >

Re : [RFC] old stuff - Kernel Bug Tracker Bug 7398

2007-12-26 Thread Pierre Ynard
> While looking over the old remaining bugs reported against iproute in > Debian I came across http://bugs.debian.org/394780 which has also been > reported as http://bugzilla.kernel.org/show_bug.cgi?id=7398 (please > see the old comments here). > [...] > The bugs last comment was from Pierre asking

Re: [patch 7/7] netxen: fix byte-swapping in tx and rx

2007-12-26 Thread Al Viro
On Wed, Dec 26, 2007 at 03:29:22PM -0800, Dhananjay Phadke wrote: > I agree for tx desc, the compiler would optimize. > > But for rx (status) desc, I didn't like multiple le64_to_cpu() > for extracting various fields out of same status dword. Fair enough; AFAICS, on rx side you don't mess with c

[PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation

2007-12-26 Thread Sreenivasa Honnur
Multiqueue netwrok device support implementation. - Added a loadable parameter "multiq" to enable/disable multiqueue support, by default it is disabled. - skb->queue_mapping is not used for queue/fifo selection. FIFO iselection is based on IP-TOS value, 0x0-0xF TOS values are mapped to 8 FIFOs.

Re: [PATCH 0/4] Pull request for 'sis190' branch

2007-12-26 Thread Francois Romieu
Jeff Garzik <[EMAIL PROTECTED]> : [...] >> Shortlog >> >> >> Francois Romieu (4): >> sis190: add cmos ram access code for the SiS19x/968 chipset pair >> sis190: remove duplicate INIT_WORK >> sis190: mdio operation failure is not correctly detected >> sis190: schedul

Re: [patch 7/7] netxen: fix byte-swapping in tx and rx

2007-12-26 Thread Dhananjay Phadke
I agree for tx desc, the compiler would optimize. But for rx (status) desc, I didn't like multiple le64_to_cpu() for extracting various fields out of same status dword. -Dhananjay On Wed, 26 Dec 2007, Al Viro wrote: > On Wed, Dec 26, 2007 at 10:23:59AM -0800, [EMAIL PROTECTED] wrote: > > This

Re: [patch 7/7] netxen: fix byte-swapping in tx and rx

2007-12-26 Thread Al Viro
On Wed, Dec 26, 2007 at 10:23:59AM -0800, [EMAIL PROTECTED] wrote: > This cleans up some unnecessary byte-swapping while setting up tx and > interpreting rx desc. The 64 bit rx status data should be converted > to host endian format only once and the macros just need to extract > bitfields. > -

Re: Strange Panic (Deadlock)

2007-12-26 Thread Jarek Poplawski
On Wed, Dec 26, 2007 at 07:56:42PM +0100, Jarek Poplawski wrote: ... [PATCH 3/3] (for testing only) --- diff -Nurp linux-2.6.23.12-/net/sched/sch_api.c linux-2.6.23.12+/net/sched/sch_api.c --- linux-2.6.23.12-/net/sched/sch_api.c2007-12-21 22:26:15.0 +0100 +++ linux-2.6.23.12+/n

Re: Strange Panic (Deadlock)

2007-12-26 Thread Jarek Poplawski
On Wed, Dec 26, 2007 at 07:54:11PM +0100, Jarek Poplawski wrote: ... [PATCH 2/3] (for testing only) --- diff -Nurp linux-2.6.23.12-/net/sched/sch_sfq.c linux-2.6.23.12+/net/sched/sch_sfq.c --- linux-2.6.23.12-/net/sched/sch_sfq.c2007-10-09 22:31:38.0 +0200 +++ linux-2.6.23.12+/n

Re: Strange Panic (Deadlock)

2007-12-26 Thread Jarek Poplawski
On Tue, Dec 25, 2007 at 12:11:50PM +0300, Badalian Vyacheslav wrote: ... > I have 4 machine. All platforms different. All machine do 1 time in > hour rebuild TC and IPTABLES rules. > After it do > echo START >> log.txt > iptables-restore < xxx.txt > tc qdisc del dev eth0 root > tc qdisc del dev e

[patch 6/7] netxen: optimize tx handling

2007-12-26 Thread dhananjay
netxen driver allows limited number of threads simultaneously posting skb's in tx ring. If transmit slot is unavailable, driver calls schedule() or loops in xmit_frame(). This patch returns TX_BUSY and lets the stack reschedule the packet if transmit slot is unavailable. Also removes unnecessary c

[patch 4/7] netxen: stop second phy correctly

2007-12-26 Thread dhananjay
This patch fixes bug that doesn't quiesce second port when interface is brought down, which could lead to unwarranted interrupt during rmmod / ifdown. Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]> Index: upstream/drivers/net/netxen/netxen_nic_niu.c =

[patch 5/7] netxen: fix race in interrupt / napi

2007-12-26 Thread dhananjay
This patch simplifies netxen ISR and poll() routine. Interrupts are not unmasked in interrupt routine based on a racy has_work() checks, but left to the napi poll function to enable them. This also fixes crash in netif_rx_action(), when work_done == budget. Signed-off-by: Dhananjay Phadke <[EMAI

[patch 3/7] netxen: improve MSI interrupt handling

2007-12-26 Thread dhananjay
Recent netxen firmware has new scheme of generating MSI interrupts, it raises interrupt and blocks itself, waiting for driver to unmask. This reduces chance of spurious interrupts. The driver will be able to deal with older firmware as well. Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]> In

[patch 7/7] netxen: fix byte-swapping in tx and rx

2007-12-26 Thread dhananjay
This cleans up some unnecessary byte-swapping while setting up tx and interpreting rx desc. The 64 bit rx status data should be converted to host endian format only once and the macros just need to extract bitfields. This saves a spate of interrupts on pseries blades caused by buggy (non) process

[patch 2/7] netxen: update driver version

2007-12-26 Thread dhananjay
Bumping up driver version to 3.4.18, several fixes have gone in since version 3.4.2. Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]> Index: upstream/drivers/net/netxen/netxen_nic.h === --- upstream.orig/drivers/net/netxen/netxen_

[patch 1/7] netxen: update MAINTAINERS

2007-12-26 Thread dhananjay
Changing MAINTAINERS for netxen nic driver. Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]> Index: upstream/MAINTAINERS === --- upstream.orig/MAINTAINERS +++ upstream/MAINTAINERS @@ -2738,8 +2738,8 @@ T:git kernel.org:/pu

[patch 0/7] netxen bug fixes

2007-12-26 Thread dhananjay
Resending recent patch set with an additional patch to fix byte ordering in tx desc besides the original bug fixes and some enhancements in tx and rx. Recreated these patches from a fresh cloned tree. Thanks, Dhananjay -- MAINTAINERS |4 +- drivers/net/

[4/4] DST: Algorithms used in distributed storage.

2007-12-26 Thread Evgeniy Polyakov
Algorithms used in distributed storage. Mirror and linear mapping code. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/drivers/block/dst/alg_linear.c b/drivers/block/dst/alg_linear.c new file mode 100644 index 000..2f9ed65 --- /dev/null +++ b/drivers/block/dst/alg_linear.c

[3/4] DST: Network state machine.

2007-12-26 Thread Evgeniy Polyakov
Network state machine. Includes network async processing state machine and related tasks. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/drivers/block/dst/kst.c b/drivers/block/dst/kst.c new file mode 100644 index 000..6d92014 --- /dev/null +++ b/drivers/block/dst/kst.c @

[1/4] DST: Distributed storage documentation.

2007-12-26 Thread Evgeniy Polyakov
Distributed storage documentation. Algorithms used in the system, userspace interfaces (sysfs dirs and files), design and implementation details are described here. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/Documentation/dst/algorithms.txt b/Documentation/dst/algorithms.

[2/4] DST: Core distributed storage files.

2007-12-26 Thread Evgeniy Polyakov
Core distributed storage files. Include userspace interfaces, initialization, block layer bindings and other core functionality. Signed-off-by: Evgeniy Polyakov <[EMAIL PROTECTED]> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index b4c8319..ca6592d 100644 --- a/drivers/block/Kconf

[0/4] DST: Distributed storage: Groundhogs strike back: no New Year for humans

2007-12-26 Thread Evgeniy Polyakov
Distributed storage: Groundhogs strike back: no New Year for humans I'm pleased to announce the 13'th release of the distributed storage subsystem (DST). DST allows to form a storage on top of local and remote nodes and combine them into linear or mirroring setup, which in turn can be exported t

Re: [PATCH] [IPROUTE2] Compatibility with iptables 1.4.0

2007-12-26 Thread Pablo Neira Ayuso
Hi Jamal, jamal wrote: > Pablo, below looks an oversight. > I think there are some libraries like the mark target need also to be > backward compatible. Shouldn't "mark" be in capital letters? >> lilsol:~# export IPTABLES_LIB_DIR=/root/iptables-1.4.0/extensions/ >> lilsol:~# tc actions add actio