Re: [git patches] net driver fixes

2007-12-22 Thread Al Viro
On Sun, Dec 23, 2007 at 01:42:14AM -0500, Jeff Garzik wrote: > I applied it to #upstream (2.6.25) since forcedeth is not on any > big-endian platforms AFAIK. All right, then... I hadn't been sure if it's onboard-only, that's all. > I have an epic100 card too if you need it (though it sounds li

Re: [git patches] net driver fixes

2007-12-22 Thread Jeff Garzik
Al Viro wrote: On Sun, Dec 23, 2007 at 12:33:14AM -0500, Jeff Garzik wrote: A couple [minorly] notable wireless bug fixes, and plenty of viro fixes for obscure issues :) Heh... FWIW, forcedeth patch (sent your way about two weeks ago) also belongs in the same set. If you need a resend - tell

Re: [git patches] net driver fixes

2007-12-22 Thread Al Viro
On Sun, Dec 23, 2007 at 12:33:14AM -0500, Jeff Garzik wrote: > > A couple [minorly] notable wireless bug fixes, and plenty of viro fixes > for obscure issues :) Heh... FWIW, forcedeth patch (sent your way about two weeks ago) also belongs in the same set. If you need a resend - tell... There's

Re: [patch 3/6] netxen: improve MSI interrupt handling

2007-12-22 Thread Jeff Garzik
Patch does not apply to 2.6.24-rc. Was this "bug fix" series meant for 2.6.25? Jeff -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: delay via-rhine irq initialisation.

2007-12-22 Thread Jeff Garzik
Dave Jones wrote: With CONFIG_DEBUG_SHIRQ set, via-rhine complains during init. (See https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=377721 for a report). Does this diff look right? (I don't have a via-rhine handy to test with) We may be able to get away with moving the request_irq to just

Re: [PATCH] dm9000 - fix spinlock issue, updated

2007-12-22 Thread Ben Dooks
On Wed, Nov 21, 2007 at 04:47:53PM +0300, dmitry pervushin wrote: > The patch below fixes the problem with dm9000_timeout function: it calls > dm9000_init under the spin_lock db->lock, which was going to be acquired > again in dm9000_hash_table. From the other hand, dm9000_hash_table has > to be ca

Re: [PATCH] Reduce locking in TX path of forcedth driver

2007-12-22 Thread Jeff Garzik
Tom Herbert wrote: (Tom, you failed to CC the maintainer at NVIDIA, please fix...) Jeff, Please pardon my naivety, but how would determine who the maintainer at NVDIA is? The MAINTAINERS file lists an Nvidia maintainer only for the framebuffer driver, and I don't see this specified i

Re: [PATCH 0/8] RFC: Wireless Extensions for rndis_host

2007-12-22 Thread David Brownell
> From: Bjorge Dijkstra <[EMAIL PROTECTED]> > Subject: [PATCH 0/8] RFC: Wireless Extensions for rndis_host > Date: Sat, 22 Dec 2007 22:51:26 +0100 > > Hello all, > > I have here a patchset that needs some review. > This patchset adds wireless extensions for rndis_host to > enable support for RNDIS

Re: [PATCH 8/8] [PATCH] Use wlan device name for RNDIS wireless devices

2007-12-22 Thread David Brownell
> From: Bjorge Dijkstra <[EMAIL PROTECTED]> > Subject: [PATCH 8/8] [PATCH] Use wlan device name for RNDIS wireless devices > Date: Sat, 22 Dec 2007 22:51:34 +0100 > > From: Jussi Kivilinna <[EMAIL PROTECTED]> > > Use wlan device name for RNDIS wireless devices. > > Signed-off-by: Jussi Kivilinna <[

Re: [PATCH 7/8] Add Wireless Extensions to rndis_host

2007-12-22 Thread David Brownell
> From: Bjorge Dijkstra <[EMAIL PROTECTED]> > Subject: [PATCH 7/8] Add Wireless Extensions to rndis_host > Date: Sat, 22 Dec 2007 22:51:33 +0100 > > The bulk of this patch is the addition of a new file that > implements the wireless extensions for RNDIS devices. > The rest are some smaller changes

Re: [PATCH 6/8] [PATCH] Split up rndis_host.c

2007-12-22 Thread David Brownell
> From: Bjorge Dijkstra <[EMAIL PROTECTED]> > Subject: [PATCH 6/8] [PATCH] Split up rndis_host.c > Date: Sat, 22 Dec 2007 22:51:32 +0100 > > Split up rndis_host.c into rndis_host.h and rndis_base.c and > change Makefile accordingly. This is done so we can add extra > source files to the rndis_host

Re: [PATCH 5/8] Fix rndis packet filter flags.

2007-12-22 Thread David Brownell
> From [EMAIL PROTECTED] Sat Dec 22 13:53:12 2007 > From: Bjorge Dijkstra <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > Cc: netdev@vger.kernel.org, [EMAIL PROTECTED], > Jussi Kivilinna <[EMAIL PROTECTED]> > Subject: [PATCH 5/8] Fix rndis packet filter flags. > Date: Sat, 22 Dec 2007 22:51:31

Re: [PATCH 4/8] [PATCH] Halt device if rndis_bind fails.

2007-12-22 Thread David Brownell
> From [EMAIL PROTECTED] Sat Dec 22 13:53:07 2007 > From: Bjorge Dijkstra <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > Cc: netdev@vger.kernel.org, [EMAIL PROTECTED], > Jussi Kivilinna <[EMAIL PROTECTED]> > Subject: [PATCH 4/8] [PATCH] Halt device if rndis_bind fails. > Date: Sat, 22 Dec 200

Re: [PATCH 3/8] [PATCH] Use 1KB buffer in rndis_unbind

2007-12-22 Thread David Brownell
> From [EMAIL PROTECTED] Sat Dec 22 13:53:03 2007 > From: Bjorge Dijkstra <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > Cc: netdev@vger.kernel.org, [EMAIL PROTECTED], > Jussi Kivilinna <[EMAIL PROTECTED]> > Subject: [PATCH 3/8] [PATCH] Use 1KB buffer in rndis_unbind > Date: Sat, 22 Dec 2007

Re: [PATCH 2/8] [PATCH] Hardwire CDC descriptors when missing

2007-12-22 Thread David Brownell
> From [EMAIL PROTECTED] Sat Dec 22 13:53:00 2007 > X-SourceIP: 213.93.131.145 > From: Bjorge Dijkstra <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > Cc: netdev@vger.kernel.org, [EMAIL PROTECTED] > Subject: [PATCH 2/8] [PATCH] Hardwire CDC descriptors when missing > Date: Sat, 22 Dec 2007 22:51:28

Re: [PATCH 1/8] Fix sparse warning: returning void-valued expression

2007-12-22 Thread David Brownell
> From [EMAIL PROTECTED] Sat Dec 22 13:52:53 2007 > From: Bjorge Dijkstra <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > Cc: netdev@vger.kernel.org, [EMAIL PROTECTED] > Subject: [PATCH 1/8] Fix sparse warning: returning void-valued expression > Date: Sat, 22 Dec 2007 22:51:27 +0100 > > rndis_unbind

[PATCH 0/8] RFC: Wireless Extensions for rndis_host

2007-12-22 Thread Bjorge Dijkstra
Hello all, I have here a patchset that needs some review. This patchset adds wireless extensions for rndis_host to enable support for RNDIS based USB wireless LAN adapters (e.g. Linksys WUSB54GS, Belkin F05D7051). In this patchset: 1. Fix sparse warning: returning void valued expression 2. Ha

[PATCH 3/8] [PATCH] Use 1KB buffer in rndis_unbind

2007-12-22 Thread Bjorge Dijkstra
From: Jussi Kivilinna <[EMAIL PROTECTED]> rndis_command requires the caller to pass in a buffer of at least 1KB. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c |2 +- 1 files changed, 1 insertions(+), 1 d

[PATCH 6/8] [PATCH] Split up rndis_host.c

2007-12-22 Thread Bjorge Dijkstra
Split up rndis_host.c into rndis_host.h and rndis_base.c and change Makefile accordingly. This is done so we can add extra source files to the rndis_host module later on. Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> --- drivers/net/usb/Makefile |1 + drivers/net/usb/rndis_base.c |

[PATCH 8/8] [PATCH] Use wlan device name for RNDIS wireless devices

2007-12-22 Thread Bjorge Dijkstra
From: Jussi Kivilinna <[EMAIL PROTECTED]> Use wlan device name for RNDIS wireless devices. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_wext.c |2 +- drivers/net/usb/usbnet.c |3 +++ drivers/net/usb/us

[PATCH 2/8] [PATCH] Hardwire CDC descriptors when missing

2007-12-22 Thread Bjorge Dijkstra
Just as ActiveSync devices, some regular RNDIS devices also lack the CDC descriptors (e.g. devices based on BCM4320 WLAN chip). This patch hardwires the CDC descriptors for all RNDIS style devices when they are missing. Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> --- drivers/net/usb/cdc_et

[PATCH 4/8] [PATCH] Halt device if rndis_bind fails.

2007-12-22 Thread Bjorge Dijkstra
From: Jussi Kivilinna <[EMAIL PROTECTED]> When bind fails after device was initialized, shutdown device properly by sending RNDIS_MSG_HALT. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c | 12 +---

[PATCH 1/8] Fix sparse warning: returning void-valued expression

2007-12-22 Thread Bjorge Dijkstra
rndis_unbind and usbnet_cdc_unbind don't return anything. Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/usb/rndis_host.c b/drivers/net/usb/rndis_host.c index 1ebe325..96ef6a

[PATCH 5/8] Fix rndis packet filter flags.

2007-12-22 Thread Bjorge Dijkstra
From: Jussi Kivilinna <[EMAIL PROTECTED]> RNDIS packet filter flags are not exactly the same as CDC flags so we cannot reuse them. Signed-off-by: Jussi Kivilinna <[EMAIL PROTECTED]> Signed-off-by: Bjorge Dijkstra <[EMAIL PROTECTED]> --- drivers/net/usb/rndis_host.c | 23 ++-

[PATCH] Documentation: add a guideline for hard_start_xmit method not to modify SKB

2007-12-22 Thread Matti Linnanvuori
From: Matti Linnanvuori <[EMAIL PROTECTED]> Add a guideline for hard_start_xmit method not to modify SKB. Signed-off-by: Matti Linnanvuori <[EMAIL PROTECTED]> --- --- a/Documentation/networking/driver.txt 2007-12-22 18:50:28.062169500 +0200 +++ b/Documentation/networking/driver.txt

Re: [RFC PATCH v9 06/18] LSM: Add inet_sys_snd_skb() LSM hook (fwd)

2007-12-22 Thread Paul Moore
On Friday 21 December 2007 7:51:26 pm James Morris wrote: > This is part of a large patchset which finally "fixes" labeled networking, > which we're hoping to get into 2.6.25. > > Thread @ http://thread.gmane.org/gmane.linux.kernel.lsm/4894 > > The patch below is the only one which is not self-cont

Re: skbuff data pointer alignment requirement

2007-12-22 Thread Jarek Poplawski
Keyur Chudgar wrote, On 12/21/2007 02:12 AM: ... > If some hardware requirements, for example is, they need to have 256 > bytes aligned address for them to do the DMA, no matter what the > packet size is. In this kind of cases, can you guide me what should I > do? Is there any way already in Linux

Re: hard_start_xmit struct sk_buff read-only?

2007-12-22 Thread Matti Linnanvuori
--- Jeff Garzik <[EMAIL PROTECTED]> schrieb: > This begs the question, what are you trying to do? > ;-) I have seen network drivers whose hard_start_xmit function calls skb_push or skb_put to extend the used data area of the struct skb_buff passed to the function. That avoids allocating a new b

Re: [PATCH] MAINTAINERS: remove Adam Fritzler, update his email address in other sources

2007-12-22 Thread Joe Perches
On Sat, 2007-12-22 at 03:53 -0500, Jeff Garzik wrote: > > What was the rationale for removing Adam from MAINTAINERS? I sent him a patch to that address and it bounced. I sent him a note asking if he was still a maintainer to his new address and he replied: http://www.gossamer-threads.com/lists/li

Re: [PATCH] MAINTAINERS: remove Adam Fritzler, update his email address in other sources

2007-12-22 Thread Jeff Garzik
Andrew Morton wrote: On Mon, 17 Dec 2007 20:48:03 -0800 Joe Perches <[EMAIL PROTECTED]> wrote: Back to Adam Fritzler... ... diff --git a/CREDITS b/CREDITS index ee909f2..449ec7f 100644 --- a/CREDITS +++ b/CREDITS @@ -1124,6 +1124,9 @@ S: 1150 Ringwood Court S: San Jose, California 95131 S:

Re: hard_start_xmit struct sk_buff read-only?

2007-12-22 Thread Jeff Garzik
Matti Linnanvuori wrote: An old article about Linux's network drivers mentioned that the struct sk_buff whose pointer is passed to a driver's hard_start_xmit function is read-only to the function. Is that still so? If it is, there is no mention about it in the kernel tree as far as I know. This

Re: [PATCH] MAINTAINERS: remove Adam Fritzler, update his email address in other sources

2007-12-22 Thread Andrew Morton
On Mon, 17 Dec 2007 20:48:03 -0800 Joe Perches <[EMAIL PROTECTED]> wrote: > Back to Adam Fritzler... > > ... > > diff --git a/CREDITS b/CREDITS > index ee909f2..449ec7f 100644 > --- a/CREDITS > +++ b/CREDITS > @@ -1124,6 +1124,9 @@ S: 1150 Ringwood Court > S: San Jose, California 95131 > S: US