Re: [WEXT 3/12]: Extract standard call iw_point handling into seperate function.

On Fri, 2007-12-21 at 20:54 -0800, David Miller wrote: > [WEXT]: Extract standard call iw_point handling into seperate function. This potentially does copy_from_user twice, first to the stack, second to a kmalloc'ed area. Perhaps it's better to kmalloc first and copy once? -- To unsubscribe fro

Re: [ETH]: Combine format_addr() with print_mac().

On Fri, 2007-12-21 at 19:58 -0800, Michael Chan wrote: > The dev_addr is declared as unsigned char* in struct net_device. To be > consistent, can we change print_mac() and MAC_BUF to use unsigned char*? > They are really the same. That's fine by me. I like consistency. I don't remember why it wa

hard_start_xmit struct sk_buff read-only?

An old article about Linux's network drivers mentioned that the struct sk_buff whose pointer is passed to a driver's hard_start_xmit function is read-only to the function. Is that still so? If it is, there is no mention about it in the kernel tree as far as I know. Heute schon einen Blick i

[WEXT 12/12]: Emit event stream compat iw_point objects correctly.

[WEXT]: Emit event stream compat iw_point objects correctly. Three major portions to this change: 1) Add IW_EV_COMPAT_POINT_LEN helper define. 2) Add iw_request_info argument to iwe_stream_add_point() and iwe_stream_check_add_point(), and use it to size the event and pointer lengths corre

[WEXT 11/12]: Create IW_REQUEST_FLAG_COMPAT and set it as needed.

[WEXT]: Create IW_REQUEST_FLAG_COMPAT and set it as needed. Now low-level WEXT ioctl handlers can do compat handling when necessary. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- include/net/iw_handler.h |2 +- net/wireless/wext.c | 73 +--

[WEXT 10/12]: Remove compat handling from fs/compat_ioctl.c

[WEXT]: Remove compat handling from fs/compat_ioctl.c No longer used. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- fs/compat_ioctl.c | 107 + 1 files changed, 1 insertions(+), 106 deletions(-) diff --git a/fs/compat_ioctl.c b/fs/co

[WEXT 9/12]: Dispatch and handle compat ioctls entirely in net/wireless/wext.c

[WEXT]: Dispatch and handle compat ioctls entirely in net/wireless/wext.c Next we can kill the hacks in fs/compat_ioctl.c and also dispatch compat ioctls down into the driver and 80211 protocol helper layers in order to handle iw_point objects embedded in stream replies which need to be translate

[WEXT 8/12]: Pull top-level ioctl dispatch logic into helper function.

[WEXT]: Pull top-level ioctl dispatch logic into helper function. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- net/wireless/wext.c | 26 -- 1 files changed, 20 insertions(+), 6 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index 18fa13c.

[WEXT 7/12]: Pass iwreq pointer down into standard/private handlers.

[WEXT]: Pass iwreq pointer down into standard/private handlers. They have no need to see the object as an ifreq. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- net/wireless/wext.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/net/wireless/wext.

[WEXT 6/12]: Parameterize the standard/private handlers.

[WEXT]: Parameterize the standard/private handlers. The WEXT standard and private handlers to use are now arguments to wireless_process_ioctl(). Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- net/wireless/wext.c | 24 1 files changed, 16 insertions(+), 8 delet

[WEXT 4/12]: Extract private call iw_point handling into seperate functions.

[WEXT]: Extract private call iw_point handling into seperate functions. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- net/wireless/wext.c | 141 +++ 1 files changed, 74 insertions(+), 67 deletions(-) diff --git a/net/wireless/wext.c b/ne

[WEXT 5/12]: Pull ioctl permission checking out into helper function.

[WEXT]: Pull ioctl permission checking out into helper function. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- net/wireless/wext.c | 22 +++--- 1 files changed, 15 insertions(+), 7 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index 9c3d83f..f183

[WEXT 2/12]: Make adjust_priv_size() take a "struct iw_point *".

[WEXT]: Make adjust_priv_size() take a "struct iw_point *". Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- net/wireless/wext.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/wext.c index 677be28..3ca9c3a 100644 --- a/net/w

[WEXT 3/12]: Extract standard call iw_point handling into seperate function.

[WEXT]: Extract standard call iw_point handling into seperate function. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- net/wireless/wext.c | 258 ++ 1 files changed, 134 insertions(+), 124 deletions(-) diff --git a/net/wireless/wext.c b/n

[WEXT 1/12]: Remove inline from get_priv_size() and adjust_priv_size().

[WEXT]: Remove inline from get_priv_size() and adjust_priv_size(). The compiler inlines when appropriate. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- net/wireless/wext.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/net/wireless/wext.c b/net/wireless/we

[WEXT 0/12]: Un-crapify compat handling.

This set of 12 patches pulls all of the existing compat handling for WEXT ioctls out of fs/compat_ioctl.c and allows implementations down in the driver layers to handle compat issues properly when necessary. In particular it fixes the bug where iw_point objects were not being size translated prop

Re: [PATCH] Reduce locking in TX path of forcedth driver

(Stephen, your mailer is snipping CC's, please fix) (Tom, you failed to CC the maintainer at NVIDIA, please fix...) Stephen Hemminger wrote: On Fri, 21 Dec 2007 17:41:34 -0800 (PST) [EMAIL PROTECTED] (Tom Herbert) wrote: Reduce the amount of locking in the TX path. Instead of using both

Re: [ETH]: Combine format_addr() with print_mac().

On Fri, 2007-12-21 at 14:36 -0800, Joe Perches wrote: > On Fri, 2007-12-21 at 14:05 -0800, Michael Chan wrote: > > diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c > > index 6b2e454..f760d41 100644 > > --- a/net/ethernet/eth.c > > +++ b/net/ethernet/eth.c > > @@ -359,10 +359,33 @@ struct net_de

Re: [PATCH] Reduce locking in TX path of forcedth driver

On Fri, 21 Dec 2007 17:41:34 -0800 (PST) [EMAIL PROTECTED] (Tom Herbert) wrote: > Reduce the amount of locking in the TX path. Instead of using both > netif_tx_lock and dev->priv->lock on transmitting, a single private lock > (dev->priv->tx_lock) is used. This method is similar to that of the

[no subject]

Subject: [XFRM] Documentaion: Fix error example at XFRMOUTSTATEMODEERROR. (Re: [XFRM]: Fix outbound statistics.) Hello, On Fri, 21 Dec 2007 23:11:11 +0800 Herbert Xu <[EMAIL PROTECTED]> wrote: > On Fri, Dec 21, 2007 at 11:25:00PM +0900, Masahide NAKAMURA wrote: > > > > do { > >

[PATCH] Reduce locking in TX path of forcedth driver

Reduce the amount of locking in the TX path. Instead of using both netif_tx_lock and dev->priv->lock on transmitting, a single private lock (dev->priv->tx_lock) is used. This method is similar to that of the e1000 driver, including the logic to stop the queue in the start xmit functions, and

[RFC PATCH v9 06/18] LSM: Add inet_sys_snd_skb() LSM hook (fwd)

This is part of a large patchset which finally "fixes" labeled networking, which we're hoping to get into 2.6.25. Thread @ http://thread.gmane.org/gmane.linux.kernel.lsm/4894 The patch below is the only one which is not self-contained & impacts on core networking code. If anyone has any object

Re: [PATCH 2/2] phylib: add module owner to the mii_bus structure

On Fri, 21 Dec 2007 15:57:31 +0200 Ionut Nicu <[EMAIL PROTECTED]> wrote: > Prevent unloading mii bus driver module when other modules have references to > some > phydevs on that bus. Added a new member (module owner) to struct mii_bus and > added > code to increment the mii bus owner module usag

Re: [PATCH 2/4] [CORE]: datagram: basic memory accounting functions

David Miller wrote: > From: Hideo AOKI <[EMAIL PROTECTED]> > Date: Thu, 20 Dec 2007 23:18:54 -0500 > >>> Also, the memory accounting is done at different parts in >>> the socket code paths for stream vs. datagram. This is why >>> everything is inconsistent, and, a mess. >> Could you tell me more

Re: BNX2 warning

From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 10:34:15 -0800 > [BNX2]: Fix compiler warning. > > Change bnx2_init_napi() to void. > > Warning was noted by DaveM. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied, thanks! -- To unsubscribe from this list: send the li

Re: [PATCH 2/2] XFRM: Drop packets when replay counter would overflow

From: Paul Moore <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 09:15:00 -0500 > According to RFC4303, section 3.3.3 we need to drop outgoing packets which > cause the replay counter to overflow: > >3.3.3. Sequence Number Generation > >The sender's counter is initialized to 0 when an SA is

Re: [PATCH 1/2] XFRM: RFC4303 compliant auditing

From: Paul Moore <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 09:14:55 -0500 > This patch adds a number of new IPsec audit events to meet the auditing > requirements of RFC4303. This includes audit hooks for the following events: > > * Could not find a valid SA [sections 2.1, 3.4.2] >. xfrm_a

Re: [ETH]: Combine format_addr() with print_mac().

On Fri, 2007-12-21 at 14:05 -0800, Michael Chan wrote: > [ETH]: Combine format_addr() with print_mac(). > print_mac() used by most net drivers and format_addr() used by > net-sysfs.c are very similar and they can be integrated. > format_addr() is also identically redefined in the qla4xxx iscsi > dr

[ETH]: Combine format_addr() with print_mac().

[ETH]: Combine format_addr() with print_mac(). print_mac() used by most net drivers and format_addr() used by net-sysfs.c are very similar and they can be integrated. format_addr() is also identically redefined in the qla4xxx iscsi driver. Export a new function format_mac_addr() to be used by ne

RE: [PATCH 2/2] phylib: add module owner to the mii_bus structure

Tested-by: Emil Medve <[EMAIL PROTECTED]> > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Nicu Ioan Petru > Sent: Friday, December 21, 2007 7:58 AM > To: netdev@vger.kernel.org > Cc: Nicu Ioan Petru > Subject: [PATCH 2/2] phylib: add module owner t

RE: [PATCH 1/2] ucc_geth: split ucc_geth into two modules

Tested-by: Emil Medve <[EMAIL PROTECTED]> > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Nicu Ioan Petru > Sent: Friday, December 21, 2007 7:57 AM > To: netdev@vger.kernel.org > Cc: Nicu Ioan Petru > Subject: [PATCH 1/2] ucc_geth: split ucc_geth i

Re: [PATCH] [TCP]: Force TSO splits to MSS boundaries

On Fri, 21 Dec 2007, Ilpo Järvinen wrote: > How about this, I had to use another approach due to reasons > outlined in the commit message: > > -- > [PATCH] [TCP]: Force TSO splits to MSS boundaries > > If snd_wnd - snd_nxt wasn't multiple of MSS, skb was split on > odd boundary by the callers of

Re: TSO trimming question

On Fri, 21 Dec 2007, Ilpo Järvinen wrote: > On Fri, 21 Dec 2007, Bill Fink wrote: > > > On Fri, 21 Dec 2007, Bill Fink wrote: > > > > > Or perhaps even: > > > > > > /* Ok, it looks like it is advisable to defer. */ > > > tp->tso_deferred = jiffies; > > > > > > /* need to return a non-ze

Re: TSO trimming question

On Fri, 21 Dec 2007, Bill Fink wrote: > On Fri, 21 Dec 2007, Bill Fink wrote: > > > Or perhaps even: > > > > /* Ok, it looks like it is advisable to defer. */ > > tp->tso_deferred = jiffies; > > > > /* need to return a non-zero value to defer, which means won't > > * defer if

[PATCH] [TCP]: Force TSO splits to MSS boundaries

On Thu, 20 Dec 2007, David Miller wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Thu, 20 Dec 2007 22:00:12 +0800 > > > On Thu, Dec 20, 2007 at 04:00:37AM -0800, David Miller wrote: > > > > > > In the most ideal sense, tcp_window_allows() should probably > > > be changed to only return MSS

Re: TSO trimming question

On Fri, 21 Dec 2007, Bill Fink wrote: > Or perhaps even: > > /* Ok, it looks like it is advisable to defer. */ > tp->tso_deferred = jiffies; > > /* need to return a non-zero value to defer, which means won't >* defer if jiffies == 0 but it's only a 1 in 4 billion event

Re: [PATCH] New driver "sfc" for Solarstorm SFC4000 controller - 3nd try

Randy Dunlap wrote: > On Fri, 21 Dec 2007 16:53:40 + Robert Stonehouse wrote: > > > This is a resubmission of a new driver for Solarflare network controllers. > > The last two patches were marked with RFC but I now think that this driver > > is ready (withstanding any further review comments)

[PATCH] net: santize headers for iproute2

iproute2 source uses headers that result from "make headers_install". The header files net/tcp_states.h and net/veth.h are both being used but are not processed. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- This patch is not "urgent" but it would be good to get it in 2.6.24. --- a/i

Re: [PATCH] New driver "sfc" for Solarstorm SFC4000 controller - 3nd try

On Fri, 21 Dec 2007 16:53:40 + Robert Stonehouse wrote: > This is a resubmission of a new driver for Solarflare network controllers. > > The driver supports several types of PHY (10Gbase-T, XFP, CX4) on six > different 10G and 1G boards. > > The previous thread was: > [PATCH] [RFC] New dri

Re: [PATCH net-2.6.25 3/3] Uninline the inet_twsk_put function

Hi David, David Miller schrieb: > "inet_timewait_sock" begins with a "struct sock_common" > which is where the atomic_t is, and: > > #define tw_refcnt __tw_common.skc_refcnt > > So you would have to change struct sock_common over to kref, and thus > the entire networking, in order to

Re: BNX2 warning

On Thu, 2007-12-20 at 20:39 -0800, David Miller wrote: > Michael, please fix this, thanks :-) > > drivers/net/bnx2.c: In function 'bnx2_init_napi': > drivers/net/bnx2.c:7329: warning: no return statement in function returning > non-void > [BNX2]: Fix compiler warning. Change bnx2_init_napi()

Re: [PATCH 2/2] Module for ip utility to support veth device

On Tue, 18 Dec 2007 15:15:38 +0300 Vitaliy Gusev <[EMAIL PROTECTED]> wrote: > > module link_veth > > Signed-off-by: Vitaliy Gusev <[EMAIL PROTECTED]> > > --- > Applied both patches, and moved veth.h from ip/veth.h to include/net/veth.h so that the header file will be correctly updated if ABI

Re: [PATCH] Fix lost export-dynamic

On Mon, 17 Dec 2007 16:06:38 +0300 Vitaliy Gusev <[EMAIL PROTECTED]> wrote: > get_link_kind() fails for statically linked modules (vlan, veth, etc.) if > "ip" > was linked without "export-dynamic". > > Signed-off-by: Vitaliy Gusev <[EMAIL PROTECTED]> > applied thanks -- Stephen Hemminger <[

Re: [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly

On Fri, 21 Dec 2007 22:58:04 +0900 (JST) YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> wrote: > In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 22:49:59 +0900), "Satoru > SATOH" <[EMAIL PROTECTED]> says: > > > I agree. > > > > I mistakenly thought hz in that context must be larger than 1000.

[PATCH] New driver "sfc" for Solarstorm SFC4000 controller - 3nd try

This is a resubmission of a new driver for Solarflare network controllers. The driver supports several types of PHY (10Gbase-T, XFP, CX4) on six different 10G and 1G boards. The previous thread was: [PATCH] [RFC] New driver "sfc" for Solarstorm SFC4000 controller http://marc.info/?l=linux-net

Re: Top 10 kernel oopses/warnings for the week of December 21st 2007

> in this case this is really all the version information available ;( > it seems to be a patched kernel without patched EXTRAVERSION. > But in the future if I have more specific information (eg it's only 1 > kernel version) I'll mention it in more detail. > It gets unwieldy if there's 500 reports

Re: [XFRM]: Fix outbound statistics.

On Fri, Dec 21, 2007 at 11:25:00PM +0900, Masahide NAKAMURA wrote: > > do { > err = xfrm_state_check_space(x, skb); > - if (err) > + if (err) { > + XFRM_INC_STATS(LINUX_MIB_XFRMOUTERROR); > goto error_nolock; > +

[PATCH 2/2] phylib: add module owner to the mii_bus structure

Prevent unloading mii bus driver module when other modules have references to some phydevs on that bus. Added a new member (module owner) to struct mii_bus and added code to increment the mii bus owner module usage count on phy_connect and decrement it on phy_disconnect Set the module owner in

[patch net-2.6.25 0/2][NETNS] prepare the neigh subsys to handle network namespaces v2

These two patches are coming from Eric Biederman patchset to make the neighbouring aware of the namespaces. The description in the patch headers is big enough to add more comments here :) Changelog: v2 : fixed bad coding style v1 : initial post -- -- To unsubscribe from thi

[patch net-2.6.25 2/2][NETNS] net: Add a helper function neigh_param_default_alloc

In the presence of multiple network namespaces the logic needed to allocate the a default parameter table is just barely non-trivial. So add a function to automate it to make everyone's life easier. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> Signed-off-by: Daniel Lezcano <[EMAIL PROTECTE

[patch net-2.6.25 1/2][NETNS] net: Modify the neighbour table code so it handles multiple network namespaces

I'm actually surprised at how much was involved. At first glance it appears that the neighbour table data structures are already split by network device so all that should be needed is to modify the user interface commands to filter the set of neighbours by the network namespace of their devices.

[SOCK] Avoid divides in sk_stream_pages() and __sk_stream_mem_reclaim()

Hi David This is the last one of this boring patch suite. I prefered to not change sk_forward_alloc type, I prefer to wait 18 months more before taking this responsibility :) Merry Christmas everybody Eric [SOCK] Avoid divides in sk_stream_pages() and __sk_stream_mem_reclaim() sk_forward_all

Re: Top 10 kernel oopses/warnings for the week of December 21st 2007

Andi Kleen wrote: Arjan van de Ven <[EMAIL PROTECTED]> writes: Rank 8: __change_page_attr BUG at arch/x86/mm/pageattr_64.c:176 Reported 2 times Reported this week for 2.6.24-rc5; history goes back to 2.6.15 There is no BUG on this line on 2.6.24-rc5. Since t

[PATCH 1/2] XFRM: RFC4303 compliant auditing

This patch adds a number of new IPsec audit events to meet the auditing requirements of RFC4303. This includes audit hooks for the following events: * Could not find a valid SA [sections 2.1, 3.4.2] . xfrm_audit_state_notfound() . xfrm_audit_state_notfound_simple() * Sequence number over

[PATCH 0/2] XFRM auditing patch rebased

Based on the net-2.6.25 tree from about an hour ago. The first patch was dropped because it is already applied. -- paul moore linux security @ hp -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vge

[PATCH 2/2] XFRM: Drop packets when replay counter would overflow

According to RFC4303, section 3.3.3 we need to drop outgoing packets which cause the replay counter to overflow: 3.3.3. Sequence Number Generation The sender's counter is initialized to 0 when an SA is established. The sender increments the sequence number (or ESN) counter for this S

[XFRM]: Fix outbound statistics.

Hello David, I'm sorry, the previous mail contains wrong code: > David, I failed to include this statistics codes since I didn't notice > the conflict with the latest Herbert XFRM fix. > > Please apply this, too. > > Signed-off-by: Masahide NAKAMURA <[EMAIL PROTECTED]> > --- [snip] > >

Re: [PATCH 2/3] XFRM: RFC4303 compliant auditing

On Friday 21 December 2007 9:02:41 am David Miller wrote: > From: Paul Moore <[EMAIL PROTECTED]> > Date: Fri, 21 Dec 2007 08:51:22 -0500 > > > Ah, looks like I may not be crazy after all! It looks like the XFRM > > patches from Masahide NAKAMURA were pulled into net-2.6.25 just before > > mine las

[PATCH] [TCP]: Remove seq_rtt ptr from clean_rtx_queue args

While checking Gavin's patch I noticed that the returned seq_rtt is not used by the caller. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- I think it shouldn't introduce new conflicts between net-2.6.25 and net-2.6 (tested with git-am -3 to both). net/ipv4/tcp_input.c |7 ++- 1 f

[XFRM]: Fix outbound statistics.

David, I failed to include this statistics codes since I didn't notice the conflict with the latest Herbert XFRM fix. Please apply this, too. Signed-off-by: Masahide NAKAMURA <[EMAIL PROTECTED]> --- net/xfrm/xfrm_output.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) dif

Re: [TCP]: Convert several length variable to unsigned.

On Fri, 2007-12-21 at 16:48 +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c > index 93980c3..3b4169c 100644 > --- a/net/ipv6/tcp_ipv6.c > +++ b/net/ipv6/tcp_ipv6.c > @@ -985,7 +985,7 @@ static void tcp_v6_send_reset(struct sock *sk, struct > sk_buff

Re: Top 10 kernel oopses/warnings for the week of December 21st 2007

> Rank 2: uart_flush_buffer > Warning at drivers/serial/serial_core.c:544 in uart_flush_buffer() > Reported 16 times > No specific version information reported; bug present in 2.6.24-rc5 > Caused by a bug in the Bluetooth line discipline/tty code > Rank 7: uart_write >

Re: [PATCH/RFC] [v2] TCP: use non-delayed ACK for congestion control RTT

On Fri, 21 Dec 2007, Ilpo Järvinen wrote: > On Fri, 21 Dec 2007, Gavin McCullagh wrote: > > > I'm just checking through the existing CA modules. I don't see the rtt > > used for RTO anywhere. This is what I gather they're each using rtt for. > > I meant more timeout like fashion (e.g., to "tim

Re: [TCP] Avoid two divides in __tcp_grow_window()

From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 15:05:51 +0100 > tcp_win_from_space() being signed, compiler might emit an integer divide > to compute tcp_win_from_space()/2 . > > Using right shifts is OK here and less expensive. > > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]>

[TCP] Avoid two divides in __tcp_grow_window()

tcp_win_from_space() being signed, compiler might emit an integer divide to compute tcp_win_from_space()/2 . Using right shifts is OK here and less expensive. Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 6931946..145b51a 100644 --

Re: [PATCH/RFC] [v2] TCP: use non-delayed ACK for congestion control RTT

On Fri, 21 Dec 2007, Gavin McCullagh wrote: > On Fri, 21 Dec 2007, David Miller wrote: > > > When Gavin respins the patch I'll look at in the context of submitting > > it as a bug fix. So Gavin please generate the patch against Linus's > > vanilla GIT tree or net-2.6, your choise. > > The exist

Re: [PATCH/RFC] [v2] TCP: use non-delayed ACK for congestion control RTT

From: Gavin McCullagh <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 13:31:06 + > On Fri, 21 Dec 2007, David Miller wrote: > > > When Gavin respins the patch I'll look at in the context of submitting > > it as a bug fix. So Gavin please generate the patch against Linus's > > vanilla GIT tree or

Re: [PATCH] IPv4: Fix a typo in tcp_v4_do_calc_md5_hash() which prevents compilation

From: Paul Moore <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 08:47:13 -0500 > It's spelled "unsigned". > > Signed-off-by: Paul Moore <[EMAIL PROTECTED]> Applied, thanks. I swore I did an allmodconfig test build with that change added, looks like I didn't :-/ -- To unsubscribe from this list: sen

Re: [PATCH 2/3] XFRM: RFC4303 compliant auditing

From: Paul Moore <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 08:51:22 -0500 > Ah, looks like I may not be crazy after all! It looks like the XFRM patches > from Masahide NAKAMURA were pulled into net-2.6.25 just before mine last > night which caused my patches to conflict ... Sorry. I had doub

Re: [TCP] Avoid a divide in tcp_mtu_probing()

From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 14:32:41 +0100 > tcp_mtu_to_mss() being signed, compiler might emit an integer divide > to compute tcp_mtu_to_mss()/2 . > > Using a right shift is OK here and less expensive. > > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> Applie

[PATCH] IPv4: Fix a typo in tcp_v4_do_calc_md5_hash() which prevents compilation

It's spelled "unsigned". Signed-off-by: Paul Moore <[EMAIL PROTECTED]> --- net/ipv4/tcp_ipv4.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index 9cb92b8..9aea88b 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c @@

[PATCH 1/2] ucc_geth: split ucc_geth into two modules

Split ucc_geth_driver into 2 modules: - one module for the mii bus (phy devices register to this bus). - one module for the ethernet driver (uses phy_connect to get a phydev from the mii bus) Updated Makefile, Kconfig files and defconfigs (mpc836x, mpc832x_mds, mpc832x_rdb). Sig

Re: Top 10 kernel oopses/warnings for the week of December 21st 2007

Arjan van de Ven <[EMAIL PROTECTED]> writes: > > Rank 8: __change_page_attr > BUG at arch/x86/mm/pageattr_64.c:176 > Reported 2 times > Reported this week for 2.6.24-rc5; history goes back to 2.6.15 There is no BUG on this line on 2.6.24-rc5. Since there are many BUG_ON

Re: [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly

In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 22:49:59 +0900), "Satoru SATOH" <[EMAIL PROTECTED]> says: > I agree. > > I mistakenly thought hz in that context must be larger than 1000.. > As it's uncertain, your's looks much simpler and better. > > (btw, the lines "else div = 1" is n

Re: After many hours all outbound connections get stuck in SYN_SENT

> Huh? Do you mean a PIX blade in a Cisco switch-router chassis? It > would be very useful if you could be less vague about the > equipment in use. Right it's a PIX blade in Cisco chassis. The PIX is running ASA version 7.0(6) > That depends more on your customers' networking attributes > the

Re: [PATCH 2/3] XFRM: RFC4303 compliant auditing

On Friday 21 December 2007 8:27:23 am Paul Moore wrote: > On Friday 21 December 2007 4:43:10 am David Miller wrote: > > From: Paul Moore <[EMAIL PROTECTED]> > > Date: Thu, 20 Dec 2007 16:42:25 -0500 > > > > > This patch adds a number of new IPsec audit events to meet the auditing > > > requirements

Re: [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly

I agree. I mistakenly thought hz in that context must be larger than 1000.. As it's uncertain, your's looks much simpler and better. (btw, the lines "else div = 1" is not needed, is it?) Thanks, Satoru SATOH 2007/12/21, YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]>: (snip) > Why don't you s

[TCP] Avoid a divide in tcp_mtu_probing()

tcp_mtu_to_mss() being signed, compiler might emit an integer divide to compute tcp_mtu_to_mss()/2 . Using a right shift is OK here and less expensive. Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c index ea111e9..ea85bc0 100644 --- a/net

Re: [PATCH/RFC] [v2] TCP: use non-delayed ACK for congestion control RTT

On Fri, 21 Dec 2007, David Miller wrote: > When Gavin respins the patch I'll look at in the context of submitting > it as a bug fix. So Gavin please generate the patch against Linus's > vanilla GIT tree or net-2.6, your choise. The existing patch was against Linus' linux-2.6.git from a few days

Re: [PATCH 2/3] XFRM: RFC4303 compliant auditing

On Friday 21 December 2007 4:43:10 am David Miller wrote: > From: Paul Moore <[EMAIL PROTECTED]> > Date: Thu, 20 Dec 2007 16:42:25 -0500 > > > This patch adds a number of new IPsec audit events to meet the auditing > > requirements of RFC4303. This includes audit hooks for the following > > events

Re: [TCP] tcp_write_timeout.c cleanup

Em Fri, Dec 21, 2007 at 04:30:26AM -0800, David Miller escreveu: > From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> > Date: Fri, 21 Dec 2007 10:23:16 -0200 > > > Em Fri, Dec 21, 2007 at 06:56:17AM +0100, Eric Dumazet escreveu: > > > +static void tcp_mtu_probing(struct inet_connection_sock *icsk,

Re: [PATCH 0/10] sysfs network namespace support

Greg KH <[EMAIL PROTECTED]> writes: > On Sat, Dec 01, 2007 at 02:06:58AM -0700, Eric W. Biederman wrote: >> >> Now that we have network namespace support merged it is time to >> revisit the sysfs support so we can remove the dependency on !SYSFS. > > > > Oops, I forgot to apply this to my tree.

Re: [SOCK] Avoid integer divides where not necessary in include/net/sock.h

David Miller <[EMAIL PROTECTED]> wrote: > > When I was playing with this crap a long time ago I > think I remember that sk->sk_forward_alloc can become > negative in some circumstances. > > Or maybe that was just a bug :-) Yeah we had a few bugs there in the early days of TSO but it's been quiet

Re: [TCP] tcp_write_timeout.c cleanup

From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 10:23:16 -0200 > Em Fri, Dec 21, 2007 at 06:56:17AM +0100, Eric Dumazet escreveu: > > +static void tcp_mtu_probing(struct inet_connection_sock *icsk, struct sock > > *sk) > > +{ > > + int mss; > - int mss; >

Re: [TCP] tcp_write_timeout.c cleanup

Em Fri, Dec 21, 2007 at 06:56:17AM +0100, Eric Dumazet escreveu: > Before submiting a patch to change a divide to a right shift, I felt > necessary to create a helper function tcp_mtu_probing() to reduce length of > lines exceeding 100 chars in tcp_write_timeout(). > > Signed-off-by: Eric Dumazet

Re: [TCP] IPV6 : Change a divide into a right shift in tcp_v6_send_ack()

David Miller wrote: From: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 06:26:48 -0500 YOSHIFUJI Hideaki / 吉藤英明 wrote: In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 07:03:58 +0100), Eric Dumazet <[EMAIL PROTECTED]> says: Because tot_len is signed in tcp_v6_send_ack(), tot_len

Re: [TCP] IPV6 : Change a divide into a right shift in tcp_v6_send_ack()

From: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 06:26:48 -0500 > YOSHIFUJI Hideaki / 吉藤英明 wrote: > > In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 07:03:58 +0100), Eric > > Dumazet <[EMAIL PROTECTED]> says: > > > >> Because tot_len is signed in tcp_v6_send_ack(), tot_len/4 for

Top 10 kernel oopses/warnings for the week of December 21st 2007

The http://www.kerneloops.org website collects kernel oops and warning reports from various mailing lists and bugzillas as well as with a client users can install to auto-submit oopses. Below is a top 10 list of the oopses collected in the last 7 days. (Reports prior to 2.6.23 have been omitted in

Re: [TCP] IPV6 : Change a divide into a right shift in tcp_v6_send_ack()

YOSHIFUJI Hideaki / 吉藤英明 wrote: In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 07:03:58 +0100), Eric Dumazet <[EMAIL PROTECTED]> says: Because tot_len is signed in tcp_v6_send_ack(), tot_len/4 forces compiler to emit an integer divide, while we can help it to use a right shift, less expen

Re: [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly

On Fri, 21 Dec 2007, YOSHIFUJI Hideaki wrote: > In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 11:24:54 +0900), "Satoru > SATOH" <[EMAIL PROTECTED]> says: > > > 2007/12/21, Jarek Poplawski <[EMAIL PROTECTED]>: > > > Jarek Poplawski wrote, On 12/20/2007 09:24 PM: > > > ... > > > > > > > but

Re: [PATCH/RFC] [v2] TCP: use non-delayed ACK for congestion control RTT

From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Wed, 19 Dec 2007 15:30:03 +0200 (EET) > On Wed, 19 Dec 2007, Gavin McCullagh wrote: > > > Will do. I gather I should use the latest net- tree in future when > > submitting patches. > > Doh, I owe you apology as I was probably too hasty to point y

Re: [SOCK] Avoid integer divides where not necessary in include/net/sock.h

From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 11:40:51 +0100 > On Fri, 21 Dec 2007 01:55:43 -0800 (PST) > David Miller <[EMAIL PROTECTED]> wrote: > > Please tell me if you are OK with this solution, or if you prefer > I change sk_forward_alloc to be unsigned :) When I was playing

Re: TSO trimming question

On Fri, 21 Dec 2007, David Miller wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Fri, 21 Dec 2007 17:29:27 +0800 > > > On Fri, Dec 21, 2007 at 01:27:20AM -0800, David Miller wrote: > > > > > > It's two shifts, and this gets scheduled along with the other > > > instructions on many cpus so

Re: [SOCK] Avoid integer divides where not necessary in include/net/sock.h

On Fri, 21 Dec 2007 01:55:43 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Eric Dumazet <[EMAIL PROTECTED]> > Date: Fri, 21 Dec 2007 07:18:40 +0100 > > > Because sk_wmem_queued, sk_sndbuf are signed, a divide per two > > forces compiler to use an integer divide. We can instead use >

Re: Evgeniy Polyakov

From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 13:34:12 +0300 > Yep, I saw him couple of times and will try to contact. :-) > Do not unsubscribe me :) Ok! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More m

Re: Evgeniy Polyakov

On Thu, Dec 20, 2007 at 08:34:59PM -0800, David Miller ([EMAIL PROTECTED]) wrote: > > If someone has a way other than email to contact Evgeniy, could > you please let him know that his email is bouncing in strange > ways. Yep, I saw him couple of times and will try to contact. > I'll have to un

[DCCP] [Patch 1/1] [Bug-Fix]: Need to ignore Ack Vectors on request sockets

[ACKVEC]: Need to ignore Ack Vectors on request sockets This fixes an oversight (mine) from an earlier patch and is in principle a bug-fix, although the bug will with the current code not become visible. The issue is that Ack Vectors must not be parsed on request sockets, since the Ack Vector fe

Re: [PATCH] OOPS with NETLINK_FIB_LOOKUP netlink socket

From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 12:39:36 +0300 > David Miller wrote: > > What introduced this bug? This code didn't have this > > problem previously. > > commit cd40b7d3983c708aabe3d3008ec64ffce56d33b0 > Author: Denis V. Lunev <[EMAIL PROTECTED]> > Date: Wed O

Re: [SOCK] Avoid integer divides where not necessary in include/net/sock.h

From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 07:18:40 +0100 > Because sk_wmem_queued, sk_sndbuf are signed, a divide per two > forces compiler to use an integer divide. We can instead use > a right shift. > > SK_STREAM_MEM_QUANTUM deserves to be declared as an unsigned > quantity

Re: [TCP] tcp_write_timeout.c cleanup

From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 06:56:17 +0100 > Before submiting a patch to change a divide to a right shift, I felt > necessary to create a helper function tcp_mtu_probing() to reduce length of > lines exceeding 100 chars in tcp_write_timeout(). > > Signed-off-by:

  1   2   >