Re: [TCP] IPV6 : Change a divide into a right shift in tcp_v6_send_ack()

2007-12-20 Thread Eric Dumazet
YOSHIFUJI Hideaki / 吉藤英明 a écrit : In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 08:39:24 +0100), Eric Dumazet <[EMAIL PROTECTED]> says: Okay, anyway, I'll convert them to unsigned int, which is more appropriate. I didnt chose this path, because David was against changing some fields fro

[TCP]: Convert several length variable to unsigned.

2007-12-20 Thread YOSHIFUJI Hideaki / 吉藤英明
Several length variables cannot be negative, so convert int to unsigned int. This also allows us to do sane shift operations on those variables. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> -- diff --git a/include/net/tcp.h b/include/net/tcp.h index cb5b033..f663a85 100644 --- a/include/

Re: [TCP] IPV6 : Change a divide into a right shift in tcp_v6_send_ack()

2007-12-20 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 08:39:24 +0100), Eric Dumazet <[EMAIL PROTECTED]> says: > > Okay, anyway, I'll convert them to unsigned int, which is more > > appropriate. > > I didnt chose this path, because David was against changing some fields from > 'int' to 'unsigned'.

Re: [TCP] IPV6 : Change a divide into a right shift in tcp_v6_send_ack()

2007-12-20 Thread Eric Dumazet
YOSHIFUJI Hideaki / 吉藤英明 a écrit : In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 08:06:32 +0100), Eric Dumazet <[EMAIL PROTECTED]> says: YOSHIFUJI Hideaki / 吉藤英明 a écrit : In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 07:03:58 +0100), Eric Dumazet <[EMAIL PROTECTED]> says: Beca

Re: [TCP] IPV6 : Change a divide into a right shift in tcp_v6_send_ack()

2007-12-20 Thread Ilpo Järvinen
On Fri, 21 Dec 2007, Eric Dumazet wrote: Because tot_len is signed in tcp_v6_send_ack(), tot_len/4 forces compiler to emit an integer divide, while we can help it to use a right shift, less expensive. Can't you just change tot_len to unsigned here? It's just sizeof and some positive constants

Re: [TCP] IPV6 : Change a divide into a right shift in tcp_v6_send_ack()

2007-12-20 Thread Eric Dumazet
YOSHIFUJI Hideaki / 吉藤英明 a écrit : In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 07:03:58 +0100), Eric Dumazet <[EMAIL PROTECTED]> says: Because tot_len is signed in tcp_v6_send_ack(), tot_len/4 forces compiler to emit an integer divide, while we can help it to use a right shift, less ex

Re: [TCP] IPV6 : Change a divide into a right shift in tcp_v6_send_ack()

2007-12-20 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 21 Dec 2007 07:03:58 +0100), Eric Dumazet <[EMAIL PROTECTED]> says: > Because tot_len is signed in tcp_v6_send_ack(), tot_len/4 forces compiler > to emit an integer divide, while we can help it to use a right shift, > less expensive. Are you really sure? A

[SOCK] Avoid integer divides where not necessary in include/net/sock.h

2007-12-20 Thread Eric Dumazet
Because sk_wmem_queued, sk_sndbuf are signed, a divide per two forces compiler to use an integer divide. We can instead use a right shift. SK_STREAM_MEM_QUANTUM deserves to be declared as an unsigned quantity, so that sk_stream_pages() and __sk_stream_mem_reclaim() can use right shifts instead of

Re: [PATCH] PS3: gelic: Add wireless support for PS3

2007-12-20 Thread Masakazu Mokuno
Hi Jouni, On Fri, 14 Dec 2007 17:42:44 -0800 Jouni Malinen <[EMAIL PROTECTED]> wrote: > However, there is a part that you are not going to like.. This is likely > using a private ioctl for some parts of the association requests, i.e., > no -Dwext.. I would assume that this could be cleane

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-20 Thread Jan Engelhardt
On Dec 20 2007 23:05, Ilpo Järvinen wrote: >> >> Given the fact that I've had this problem for so long, over a variety >> of networking hardware vendors and colo-facilities, this really sounds >> good to me. It will be challenging for me to justify a kernel core >> dump, but a simple patch to du

[TCP] IPV6 : Change a divide into a right shift in tcp_v6_send_ack()

2007-12-20 Thread Eric Dumazet
Because tot_len is signed in tcp_v6_send_ack(), tot_len/4 forces compiler to emit an integer divide, while we can help it to use a right shift, less expensive. Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index 0268e11..92f0fda 100644 ---

[TCP] tcp_write_timeout.c cleanup

2007-12-20 Thread Eric Dumazet
Before submiting a patch to change a divide to a right shift, I felt necessary to create a helper function tcp_mtu_probing() to reduce length of lines exceeding 100 chars in tcp_write_timeout(). Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_ti

Re: [TCP] Avoid two divides in tcp_output.c

2007-12-20 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 06:34:28 +0100 > Because 'free_space' variable in __tcp_select_window() is signed, > expression (free_space / 2) forces compiler to emit an integer divide. > > This can be changed to a plain right shift, less expensive. > > Signed-off

[TCP] Avoid two divides in tcp_output.c

2007-12-20 Thread Eric Dumazet
Because 'free_space' variable in __tcp_select_window() is signed, expression (free_space / 2) forces compiler to emit an integer divide. This can be changed to a plain right shift, less expensive. Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_o

Re: (usagi-core 34097) Re: [PATCH] [XFRM] IPv6: Fix dst/routing check at transformation.

2007-12-20 Thread Masahide NAKAMURA
Friday 21 December 2007 14:06, Masahide NAKAMURA wrote: > Thanks, I'll resend by hand this time. > Mayby I use your e-mail address without name > by current git-send-email. Ah, they are already applied. I don't need resend anymore. I'll be careful this next time. Regards, -- Masahide NAKAMURA -

Re: [PATCH] [XFRM] IPv6: Fix dst/routing check at transformation.

2007-12-20 Thread Masahide NAKAMURA
Friday 21 December 2007 12:50, David Miller wrote: > From: Masahide NAKAMURA <[EMAIL PROTECTED]> > Date: Fri, 21 Dec 2007 12:48:31 +0900 > > > My 5 patches for XFRM sent to netdev should be TOed to David, but it is not. > > > > It does not seems that the command works for me. > > git-send-email -

Re: After many hours all outbound connections get stuck in SYN_SENT

2007-12-20 Thread Glen Turner
> I do have TCP Sequence # Randomization enabled on my router. Huh? Do you mean a PIX blade in a Cisco switch-router chassis? It would be very useful if you could be less vague about the equipment in use. > However, > if this was causing an issue, wouldn't it always occur and cause > connectio

Re: [PATCH 1/3] XFRM: Assorted IPsec fixups

2007-12-20 Thread David Miller
From: James Morris <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 09:25:38 +1100 (EST) > On Thu, 20 Dec 2007, Paul Moore wrote: > > > This patch fixes a number of small but potentially troublesome things in the > > XFRM/IPsec code: > > > > * Use the 'audit_enabled' variable already in include/linux

Re: [PATCH 3/3] [XFRM]: Add packet processing statistics option.

2007-12-20 Thread David Miller
From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 12:42:04 +0900 > Signed-off-by: Masahide NAKAMURA <[EMAIL PROTECTED]> Applied, thanks again. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 2/3] [XFRM]: Support to increment packet dropping statistics.

2007-12-20 Thread David Miller
From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 12:41:59 +0900 > Signed-off-by: Masahide NAKAMURA <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.

Re: [PATCH] [XFRM] MIPv6: Fix to input RO state correctly.

2007-12-20 Thread David Miller
From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 12:40:48 +0900 > Disable spin_lock during xfrm_type.input() function. > Follow design as IPsec inbound does. > > Signed-off-by: Masahide NAKAMURA <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsub

Re: [PATCH 1/3] [XFRM]: Define packet dropping statistics.

2007-12-20 Thread David Miller
From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 12:41:53 +0900 > This statistics is shown factor dropped by transformation > at /proc/net/xfrm_stat for developer. > It is a counter designed from current transformation source code > and defined as linux private MIB. > > See Docu

Re: [PATCH] [XFRM] IPv6: Fix dst/routing check at transformation.

2007-12-20 Thread David Miller
From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 12:40:39 +0900 > IPv6 specific thing is wrongly removed from transformation at net-2.6.25. > This patch recovers it with current design. > > o Update "path" of xfrm_dst since IPv6 transformation should > care about routing chang

BNX2 warning

2007-12-20 Thread David Miller
[ misspelled netdev list first time, retrying... ] Michael, please fix this, thanks :-) drivers/net/bnx2.c: In function 'bnx2_init_napi': drivers/net/bnx2.c:7329: warning: no return statement in function returning non-void -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: TSO trimming question

2007-12-20 Thread David Miller
From: John Heffner <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 11:02:21 -0500 > David Miller wrote: > > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > > Date: Thu, 20 Dec 2007 13:40:51 +0200 (EET) > > > >> [PATCH] [TCP]: Fix TSO deferring > >> > >> I'd say that most of what tcp_tso_should_defer had i

Evgeniy Polyakov

2007-12-20 Thread David Miller
If someone has a way other than email to contact Evgeniy, could you please let him know that his email is bouncing in strange ways. I'll have to unsubscribe him if this goes on much longer, which I don't want to do. Thanks. Here is some example bounce text: 451 4.0.0 readqf: cannot open ./dflB

Re: [PATCH 2/4] [CORE]: datagram: basic memory accounting functions

2007-12-20 Thread David Miller
From: Hideo AOKI <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 23:18:54 -0500 > > Also, the memory accounting is done at different parts in > > the socket code paths for stream vs. datagram. This is why > > everything is inconsistent, and, a mess. > > Could you tell me more detailed information? I

Re: [PATCH 2/4] [CORE]: datagram: basic memory accounting functions

2007-12-20 Thread Hideo AOKI
Hello, Thank you so much for your comments. David Miller wrote: > All of these other functions are identical copies of the stream > counterparts, they should all be consolidated. > > I still see a lot of special casing, instead of large pieces of common > code. > > There should be one core set

Re: [PATCH 8/8] tg3: Update version to 3.87

2007-12-20 Thread David Miller
From: "Matt Carlson" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 15:00:11 -0800 > This patch updates the version number to 3.87. > > Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH 7/8] tg3: Fix supporting flowctrl code

2007-12-20 Thread David Miller
From: "Matt Carlson" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 15:00:08 -0800 > This patch does three things. It modifies tg3_setup_flow_control() to > use the administrator requested flow control settings if > autonegotiation is turned off. It slightly modifies the > tg3_setup_fiber_mii_phy()

[PATCH 2/3] [XFRM]: Support to increment packet dropping statistics.

2007-12-20 Thread Masahide NAKAMURA
Signed-off-by: Masahide NAKAMURA <[EMAIL PROTECTED]> --- net/ipv6/xfrm6_input.c |3 ++ net/xfrm/xfrm_input.c | 41 +++--- net/xfrm/xfrm_output.c |6 - net/xfrm/xfrm_policy.c | 63 ++- 4 files changed, 90 insertion

Re: [PATCH 6/8] tg3: Correct sw autoneg flow control advertisements

2007-12-20 Thread David Miller
From: "Matt Carlson" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 15:00:05 -0800 > This patch modifies the software autoneg code to use the administrator > specified flow control parameters. Since the autonegotiation code uses > alternative flow control enumerations, the 1000-BaseX utility function

[PATCH] [XFRM] MIPv6: Fix to input RO state correctly.

2007-12-20 Thread Masahide NAKAMURA
Disable spin_lock during xfrm_type.input() function. Follow design as IPsec inbound does. Signed-off-by: Masahide NAKAMURA <[EMAIL PROTECTED]> --- net/ipv6/xfrm6_input.c | 54 +-- 1 files changed, 29 insertions(+), 25 deletions(-) diff --git a/net/ip

[PATCH 1/3] [XFRM]: Define packet dropping statistics.

2007-12-20 Thread Masahide NAKAMURA
This statistics is shown factor dropped by transformation at /proc/net/xfrm_stat for developer. It is a counter designed from current transformation source code and defined as linux private MIB. See Documentation/networking/xfrm_proc.txt for the detail. Signed-off-by: Masahide NAKAMURA <[EMAIL PR

[PATCH 3/3] [XFRM]: Add packet processing statistics option.

2007-12-20 Thread Masahide NAKAMURA
Signed-off-by: Masahide NAKAMURA <[EMAIL PROTECTED]> --- net/xfrm/Kconfig | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig index 577a4f8..6b5b50f 100644 --- a/net/xfrm/Kconfig +++ b/net/xfrm/Kconfig @@ -35,6 +35,16 @@ config XFR

[PATCH] [XFRM] IPv6: Fix dst/routing check at transformation.

2007-12-20 Thread Masahide NAKAMURA
IPv6 specific thing is wrongly removed from transformation at net-2.6.25. This patch recovers it with current design. o Update "path" of xfrm_dst since IPv6 transformation should care about routing changes. It is required by MIPv6 and off-link destined IPsec. o Rename nfheader_len which is for

Re: [PATCH 4/8] tg3: Replace some magic 5704S constants

2007-12-20 Thread David Miller
From: "Matt Carlson" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 14:59:59 -0800 > This patch replaces magic values with preprocessor definitions for > the sg_dig_ctrl and sg_dig_status registers. This is preparatory work > for the next patch. > > Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> >

Re: [PATCH 5/8] tg3: Correct 5704S flowctrl advertisements

2007-12-20 Thread David Miller
From: "Matt Carlson" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 15:00:02 -0800 > This patch modifies the 5704S hardware autoneg code to use the > administrator specified flow control parameters. Since the 5704S uses > device specific flow control enumerations, the 1000-BaseX utility > functions a

Re: [PATCH 3/8] tg3: Add 1000T & 1000X flowctl adv helpers

2007-12-20 Thread David Miller
From: "Matt Carlson" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 14:59:56 -0800 > This patch adds two functions designed to convert abstract TX & RX > flow control parameters to 1000-BaseT and 1000-BaseX autonegotiation > advertisements. Code that uses standard definitions which statically > adver

Re: [PATCH 2/8] tg3: Add 1000T & 1000X flowctrl resolvers

2007-12-20 Thread David Miller
From: "Matt Carlson" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 14:59:53 -0800 > This patch adds two new utility functions to resolve flow control. One > function resolves flow control based on 1000-BaseT register definitions. > The other resolves flow control based on 1000-Base X register > defi

Re: [PATCH 1/8] tg3: Separate requested and actual flow control parameters

2007-12-20 Thread David Miller
From: "Matt Carlson" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 14:59:49 -0800 > This patch removes the TX and RX flow control flags from tg3_flags and > adds two new flow control variables, flowctrl and active_flowctrl. > > Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> > Signed-off-by: Michael

Re: Please pull 'upstream-davem' branch of wireless-2.6

2007-12-20 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 17:38:50 -0500 > On Thu, Dec 20, 2007 at 10:53:21AM -0500, John W. Linville wrote: > > > These are destined for 2.6.25. The patches fall mostly into two > > categories: a new rate control algorithm for mac80211, and some > > cfg

Re: [PATCH 9/9][BNX2]: Update version to 1.7.1.

2007-12-20 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 12:33:49 -0800 > [BNX2]: Update version to 1.7.1. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More m

Re: [PATCH 8/9][BNX2]: Enable new tx ring.

2007-12-20 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 12:33:35 -0800 > [BNX2]: Enable new tx ring. > > Enable new tx ring and add new MSIX handler and NAPI poll function > for the new tx ring. Enable MSIX when the hardware supports it. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED

Re: [PATCH 7/9][BNX2]: Add support for a new tx ring.

2007-12-20 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 12:33:00 -0800 > [BNX2]: Add support for a new tx ring. > > To separate TX IRQs into a different MSIX vector, we need to > support a new tx ring. The original tx ring will still be used > when not using MSIX. > > Signed-off-by: Mic

Re: [PATCH 4/4] [UDP]: memory accounting in IPv4

2007-12-20 Thread Hideo AOKI
David Miller wrote: > From: Hideo AOKI <[EMAIL PROTECTED]> > Date: Mon, 17 Dec 2007 21:38:47 -0500 > >> This patch adds UDP memory usage accounting in IPv4. >> > We can't accept these changes, even once the other issues > are fixed, until IPV6 is supported as well. > > It's pointless to support p

Re: [PATCH 6/9][BNX2]: Support multiple MSIX IRQs.

2007-12-20 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 12:32:47 -0800 > [BNX2]: Support multiple MSIX IRQs. > > Change bnx2_napi struct into an array and add code to manage multiple > IRQs. MSIX hardware structures and new registers are also added. > > Signed-off-by: Michael Chan <[EMA

Re: [PATCH 5/9][BNX2]: Move rx indexes into bnx2_napi struct.

2007-12-20 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 12:32:25 -0800 > [BNX2]: Move rx indexes into bnx2_napi struct. > > Rx related fields used in NAPI polling are moved from the main > bnx2 struct to the bnx2_napi struct. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied.

Re: [PATCH 4/9][BNX2]: Move tx indexes into bnx2_napi struct.

2007-12-20 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 12:32:10 -0800 > [BNX2]: Move tx indexes into bnx2_napi struct. > > Tx related fields used in NAPI polling are moved from the main > bnx2 struct to the bnx2_napi struct. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied.

Re: [PATCH 3/9][BNX2]: Introduce new bnx2_napi structure.

2007-12-20 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 12:31:44 -0800 > [BNX2]: Introduce new bnx2_napi structure. > > Introduce a bnx2_napi structure that will hold a napi_struct and > other fields to handle NAPI polling for the napi_struct. Various tx > and rx indexes and status block

Re: [PATCH 2/9][BNX2]: Restructure IRQ datastructures.

2007-12-20 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 12:31:28 -0800 > [BNX2]: Restructure IRQ datastructures. > > Add a table to keep track of multiple IRQs and restructure the IRQ > request and free functions so that they can be easily expanded to > handle multiple IRQs. > > Signed-o

Re: [PATCH 1/9][BNX2]: Add function to fetch hardware tx index.

2007-12-20 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 12:31:07 -0800 > [BNX2]: Add function to fetch hardware tx index. > > This makes the code cleaner and easier to support different tx rings. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this li

Re: [PATCH] [XFRM] IPv6: Fix dst/routing check at transformation.

2007-12-20 Thread Herbert Xu
On Fri, Dec 21, 2007 at 12:40:39PM +0900, Masahide NAKAMURA wrote: > IPv6 specific thing is wrongly removed from transformation at net-2.6.25. > This patch recovers it with current design. > > o Update "path" of xfrm_dst since IPv6 transformation should > care about routing changes. It is requir

Re: [PATCH] [XFRM] IPv6: Fix dst/routing check at transformation.

2007-12-20 Thread David Miller
From: Masahide NAKAMURA <[EMAIL PROTECTED]> Date: Fri, 21 Dec 2007 12:48:31 +0900 > My 5 patches for XFRM sent to netdev should be TOed to David, but it is not. > > It does not seems that the command works for me. > git-send-email --to "David S. Miller <[EMAIL PROTECTED]>" --to [EMAIL > PROTECTE

Re: [PATCH 1/4] [UDP]: fix send buffer check

2007-12-20 Thread Hideo AOKI
Hello, David Miller wrote: >> diff -pruN net-2.6/net/ipv4/ip_output.c >> net-2.6-udp-take11a1-p1/net/ipv4/ip_output.c >> --- net-2.6/net/ipv4/ip_output.c 2007-12-11 10:54:55.0 -0500 >> +++ net-2.6-udp-take11a1-p1/net/ipv4/ip_output.c 2007-12-17 >> 14:42:31.0 -0500 >> @@

Re: [PATCH 0/10] sysfs network namespace support

2007-12-20 Thread Greg KH
On Sat, Dec 01, 2007 at 02:06:58AM -0700, Eric W. Biederman wrote: > > Now that we have network namespace support merged it is time to > revisit the sysfs support so we can remove the dependency on !SYSFS. Oops, I forgot to apply this to my tree. Eric, you still want this submitted, right? th

[patch 4/6] netxen: stop second phy correctly

2007-12-20 Thread dhananjay
This patch fixes bug that doesn't quiesce second port when interface is brought down, which could lead to unwarranted interrupt during rmmod/ifdown. Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]> Index: netdev-2.6/drivers/net/netxen/netxen_nic_niu.c ==

[patch 3/6] netxen: improve MSI interrupt handling

2007-12-20 Thread dhananjay
Recent netxen firmware has new scheme of generating MSI interrupts, it raises interrupt and blocks itself, waiting for driver to unmask. This reduces chance of spurious interrupts. The driver will be able to deal with older firmware as well. Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]> In

[patch 6/6] netxen: optimize tx handling

2007-12-20 Thread dhananjay
netxen driver allows limited number of threads simultaneously posting skb's in tx ring. If transmit slot is unavailable, driver calls schedule() or loops in xmit_frame(). This patch returns TX_BUSY and lets the stack reschedule the packet if transmit slot is unavailable. Also removes unnecessary c

[patch 5/6] netxen: fix race in interrupt / napi

2007-12-20 Thread dhananjay
This patch simplifies netxen ISR and poll() routine. Interrupts are not unmasked in interrupt routine based on a racy has_work() checks, but left to the poll function to enable them. Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]> Index: netdev-2.6/drivers/net/netxen/netxen_nic_main.c ==

[patch 2/6] netxen: update driver version

2007-12-20 Thread dhananjay
Bumping up driver version to 3.4.18, several fixes have gone in since version 3.4.2. Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]> Index: netdev-2.6/drivers/net/netxen/netxen_nic.h === --- netdev-2.6.orig/drivers/net/netxen/ne

[patch 1/6] netxen: Update MAINTAINERS

2007-12-20 Thread dhananjay
Changing MAINTAINERS for netxen nic driver. Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]> Index: netdev-2.6/MAINTAINERS === --- netdev-2.6.orig/MAINTAINERS +++ netdev-2.6/MAINTAINERS @@ -2738,8 +2738,8 @@ T:git kernel.o

[patch 0/6] netxen bug fixes

2007-12-20 Thread dhananjay
Sending out 4 bugfixes and some improvements for the netxen nic driver. Also updating driver version and maintainer. The patches are generated against upstream branch. MAINTAINERS |4 +- drivers/net/netxen/netxen_nic.h | 10 +- drivers/net/netxen/netxe

Re: [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly

2007-12-20 Thread Satoru SATOH
2007/12/21, Jarek Poplawski <[EMAIL PROTECTED]>: > Jarek Poplawski wrote, On 12/20/2007 09:24 PM: > ... > > > but since it's your patch, I hope you do some additional checking > > if it's always like this... > > > ...or maybe only changing this all a little bit will make it look safer! > > Jarek P.

Re: Update ip command line processing

2007-12-20 Thread Simon Horman
On Thu, Dec 20, 2007 at 03:21:21PM -0800, David Miller wrote: > From: Simon Horman <[EMAIL PROTECTED]> > Date: Tue, 18 Dec 2007 17:57:32 +0900 > > > @@ -1414,9 +1414,16 @@ late_initcall(ip_auto_config); > > */ > > static int __init ic_proto_name(char *name) > > { > > + if (!name) { > > +

Re: [PATCH][NETDEV]: remove netif_running() check from myri10ge_poll()

2007-12-20 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 16:05:18 -0800 > On Wed, 12 Dec 2007 11:02:43 -0800 (PST) > David Miller <[EMAIL PROTECTED]> wrote: > > > From: Andrew Gallatin <[EMAIL PROTECTED]> > > Date: Wed, 12 Dec 2007 13:38:34 -0500 > > > > > Remove the bogus netif_running()

Re: [PATCH net-2.6.25 3/3] Uninline the inet_twsk_put function

2007-12-20 Thread David Miller
From: Ingo Oeser <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 19:32:45 +0100 > static inline inet_twsk_put(struct inet_timewait_sock *tw) > { > kref_put(&tw->kref, inet_twsk_release); > } > > David, can you see any reason (e.g. some crazy lock stuff) NOT to do this? Look at how this datastru

Re: [PATCH][NETDEV]: remove netif_running() check from myri10ge_poll()

2007-12-20 Thread Andrew Morton
On Wed, 12 Dec 2007 11:02:43 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Andrew Gallatin <[EMAIL PROTECTED]> > Date: Wed, 12 Dec 2007 13:38:34 -0500 > > > Remove the bogus netif_running() check from myri10ge_poll(). > > > > This eliminates any chance that myri10ge_poll() can trig

Re: TSO trimming question

2007-12-20 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 22:00:12 +0800 > On Thu, Dec 20, 2007 at 04:00:37AM -0800, David Miller wrote: > > > > In the most ideal sense, tcp_window_allows() should probably > > be changed to only return MSS multiples. > > > > Unfortunately this would add an expe

Re: [PATCH net-2.6.25][NEIGH] Make neigh_add_timer symmetrical to neigh_del_timer

2007-12-20 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 12:50:37 +0300 > The neigh_del_timer() looks sane - it removes the timer and > (conditionally) puts the neighbor. I expected, that the > neigh_add_timer() is symmetrical to the del one - i.e. it > holds the neighbor and arms the time

Re: [PATCH net-2.6.25 1/19] [NETNS] Add netns parameter to fib_rules_(un)register.

2007-12-20 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Wed, 19 Dec 2007 18:24:31 +0300 > @@ -101,14 +101,12 @@ static inline u32 frh_get_table(struct fib_rule_hdr > *frh, struct nlattr **nla) > return frh->table; > } > > -extern int fib_rules_register(struct fib_rules_ops *);

Re: [patch 1/2][NETNS] net: Modify the neighbour table code so it handles multiple network namespaces

2007-12-20 Thread David Miller
From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Wed, 19 Dec 2007 15:55:45 +0100 > -struct neigh_seq_state { > +struct neigh_seq_state > +{ Please don't make coding style change like this. The accepted convention is: struct NAME { ... }; I know the other structs in that header file use t

Re: [PATCH net-2.6.25 2/3] Uninline the __inet_lookup_established function

2007-12-20 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Wed, 19 Dec 2007 13:53:40 +0300 > This is -700 bytes from the net/ipv4/built-in.o > > add/remove: 1/0 grow/shrink: 1/3 up/down: 340/-1040 (-700) > function old new delta > __inet_lookup_established

Re: [PATCH net-2.6.25 3/3] Uninline the inet_twsk_put function

2007-12-20 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Wed, 19 Dec 2007 13:56:13 +0300 > This one is not that big, but is widely used: saves 1200 bytes > from net/ipv4/built-in.o > > add/remove: 1/0 grow/shrink: 1/12 up/down: 97/-1300 (-1203) > function old new

Re: [PATCH net-2.6.25 (resend) 1/3] Uninline the __inet_hash function

2007-12-20 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 20 Dec 2007 12:46:07 +0300 > This one is used in quite many places in the networking code and > seems to big to be inline. > > After the patch net/ipv4/build-in.o loses ~650 bytes: > add/remove: 2/0 grow/shrink: 0/5 up/down: 461/-1114 (-653) >

Re: [PATCH] drivers/net/niu: Support for Marvell PHY

2007-12-20 Thread David Miller
From: Mirko Lindner <[EMAIL PROTECTED]> Date: Tue, 18 Dec 2007 17:03:58 +0100 > +static int xcvr_init_10g_mrvl88x2011(struct niu *np) > +{ > + int err; > + > + /* Set LED functions */ > + mrvl88x2011_led_blink_rate(np, 2); > + mrvl88x2011_act_led(np, 0); /* led activity */ > +

Re: [PATCH 2/2] net: neighbor timer power saving

2007-12-20 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 19 Dec 2007 08:23:43 +0100 > We are going to convert 99% timers to deferrable. > > Maybe the right move should be to have the reverse attribute, to > mark a timer as non deferrable... I think we are still in a learning process about what exactly

Re: Update ip command line processing

2007-12-20 Thread David Miller
From: Simon Horman <[EMAIL PROTECTED]> Date: Tue, 18 Dec 2007 17:57:32 +0900 > @@ -1414,9 +1414,16 @@ late_initcall(ip_auto_config); > */ > static int __init ic_proto_name(char *name) > { > + if (!name) { > + return 1; > + } I do not see any circumstance under which this p

[PATCH 6/8] tg3: Correct sw autoneg flow control advertisements

2007-12-20 Thread Matt Carlson
This patch modifies the software autoneg code to use the administrator specified flow control parameters. Since the autonegotiation code uses alternative flow control enumerations, the 1000-BaseX utility functions are used and code was added to convert the definitions to and from the alternate enu

[PATCH 8/8] tg3: Update version to 3.87

2007-12-20 Thread Matt Carlson
This patch updates the version number to 3.87. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index dd9229c..6264454 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -64,8 +64,8 @@ #def

[PATCH 5/8] tg3: Correct 5704S flowctrl advertisements

2007-12-20 Thread Matt Carlson
This patch modifies the 5704S hardware autoneg code to use the administrator specified flow control parameters. Since the 5704S uses device specific flow control enumerations, the 1000-BaseX utility functions are used and code was added to convert the definitions to and from the proprietary enumer

[PATCH 3/8] tg3: Add 1000T & 1000X flowctl adv helpers

2007-12-20 Thread Matt Carlson
This patch adds two functions designed to convert abstract TX & RX flow control parameters to 1000-BaseT and 1000-BaseX autonegotiation advertisements. Code that uses standard definitions which statically advertises TX & RX flow control has been replaced with code that configures the advertisement

[PATCH 7/8] tg3: Fix supporting flowctrl code

2007-12-20 Thread Matt Carlson
This patch does three things. It modifies tg3_setup_flow_control() to use the administrator requested flow control settings if autonegotiation is turned off. It slightly modifies the tg3_setup_fiber_mii_phy() function to account for this new use case. And finally, it does the same for tg3_setup_c

[PATCH 1/8] tg3: Separate requested and actual flow control parameters

2007-12-20 Thread Matt Carlson
This patch removes the TX and RX flow control flags from tg3_flags and adds two new flow control variables, flowctrl and active_flowctrl. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 4942f7

[PATCH 2/8] tg3: Add 1000T & 1000X flowctrl resolvers

2007-12-20 Thread Matt Carlson
This patch adds two new utility functions to resolve flow control. One function resolves flow control based on 1000-BaseT register definitions. The other resolves flow control based on 1000-Base X register definitions. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[

[PATCH 4/8] tg3: Replace some magic 5704S constants

2007-12-20 Thread Matt Carlson
This patch replaces magic values with preprocessor definitions for the sg_dig_ctrl and sg_dig_status registers. This is preparatory work for the next patch. Signed-off-by: Matt Carlson <[EMAIL PROTECTED]> Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/tg3.c b/drivers/ne

[PATCH 0/8] tg3: Flow Control Modifications

2007-12-20 Thread Matt Carlson
This patchset modifies the driver to accept changes in flow control settings via ethtool. -- Matt Carlson 5300 California Ave Senior Software EngineerIr

Re: Please pull 'upstream-davem' branch of wireless-2.6

2007-12-20 Thread John W. Linville
On Thu, Dec 20, 2007 at 10:53:21AM -0500, John W. Linville wrote: > These are destined for 2.6.25. The patches fall mostly into two > categories: a new rate control algorithm for mac80211, and some > cfg80211 enhancements (including mac80211 patches to use them). > mac80211: make PID rate

Re: [PATCH] NET: Fix function put_cmsg() which may cause usr application memory overflow

2007-12-20 Thread David Miller
From: Wei Yongjun <[EMAIL PROTECTED]> Date: Tue, 18 Dec 2007 15:19:09 +0900 > When used function put_cmsg() to copy kernel information to user > application memory, if the memory length given by user application is > not enough, by the bad length calculate of msg.msg_controllen, > put_cmsg() fu

Re: [PATCH 3/3] XFRM: Drop packets when replay counter would overflow

2007-12-20 Thread James Morris
On Thu, 20 Dec 2007, Paul Moore wrote: > According to RFC4303, section 3.3.3 we need to drop outgoing packets which > cause the replay counter to overflow: > >3.3.3. Sequence Number Generation > >The sender's counter is initialized to 0 when an SA is established. >The sender increme

Re: [PATCH 2/3] XFRM: RFC4303 compliant auditing

2007-12-20 Thread James Morris
On Thu, 20 Dec 2007, Paul Moore wrote: > This patch adds a number of new IPsec audit events to meet the auditing > requirements of RFC4303. This includes audit hooks for the following events: > > * Could not find a valid SA [sections 2.1, 3.4.2] >. xfrm_audit_state_notfound() >. xfrm_au

Re: [PATCH 1/3] XFRM: Assorted IPsec fixups

2007-12-20 Thread James Morris
On Thu, 20 Dec 2007, Paul Moore wrote: > This patch fixes a number of small but potentially troublesome things in the > XFRM/IPsec code: > > * Use the 'audit_enabled' variable already in include/linux/audit.h >Removed the need for extern declarations local to each XFRM audit fuction > > *

Re: [RFC PATCH] LSM: Add inet_sys_snd_skb() LSM hook

2007-12-20 Thread James Morris
On Wed, 19 Dec 2007, Paul Moore wrote: > Add an inet_sys_snd_skb() LSM hook to allow the LSM to provide packet level > access control for all outbound packets. Using the existing postroute_last > netfilter hook turns out to be problematic as it is can be invoked multiple > times for a single pack

Re: [PATCH 2.6.25 8/9] SCTP: Implement ADD-IP special case processing for ABORT chunk

2007-12-20 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Mon, 17 Dec 2007 16:32:48 -0500 > ADD-IP spec has a special case for processing ABORTs: > F4) ... One special consideration is that ABORT > Chunks arriving destined to the IP address being deleted MUST be > ignored (see Section 5.3.

Re: [PATCH 2.6.25 9/9] SCTP: Follow Add-IP security consideratiosn wrt INIT/INIT-ACK

2007-12-20 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Mon, 17 Dec 2007 16:32:49 -0500 > The Security Considerations section of RFC 5061 has the following > text: > >If an SCTP endpoint that supports this extension receives an INIT >that indicates that the peer supports the ASCONF extension but do

Re: [PATCH 2.6.25 6/9] SCTP: Update ASCONF processing to conform to spec.

2007-12-20 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Mon, 17 Dec 2007 16:32:46 -0500 > The processing of the ASCONF chunks has changed a lot in the > spec. New items are: > 1. A list of ASCONF-ACK chunks is now cached > 2. The source of the packet is used in response. > 3. New handling for u

Re: [PATCH 2.6.25 4/9] SCTP: Update association lookup to look at ASCONF chunks as well

2007-12-20 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Mon, 17 Dec 2007 16:32:44 -0500 > ADD-IP draft section 5.2 specifies that if an association can not > be found using the source and destination of the IP packet, > then, if the packet contains ASCONF chunks, the Address Parameter > TLV should be used t

Re: [PATCH 2.6.25 5/9] SCTP: ADD-IP updates the states where ASCONFs can be sent

2007-12-20 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Mon, 17 Dec 2007 16:32:45 -0500 >C4) Both ASCONF and ASCONF-ACK Chunks MUST NOT be sent in any SCTP > state except ESTABLISHED, SHUTDOWN-PENDING, SHUTDOWN-RECEIVED, > and SHUTDOWN-SENT. > > Signed-off-by: Vlad Yasevich <[EMAIL PRO

Re: [PATCH 2.6.25 3/9] SCTP: Add the handling of "Set Primary IP Address" parameter to INIT

2007-12-20 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Mon, 17 Dec 2007 16:32:43 -0500 > The ADD-IP "Set Primary IP Address" parameter is allowed in the > INIT/INIT-ACK exchange. Allow processing of this parameter during > the INIT/INIT-ACK. > > Signed-off-by: Vlad Yasevich <[EMAIL PROTECTED]> Applied.

Re: [PATCH 2.6.25 2/9] SCTP: Handle the wildcard ADD-IP Address parameter

2007-12-20 Thread David Miller
From: Vlad Yasevich <[EMAIL PROTECTED]> Date: Mon, 17 Dec 2007 16:32:42 -0500 > The Address Parameter in the parameter list of the ASCONF chunk > may be a wildcard address. In this case special processing > is required. For the 'add' case, the source IP of the packet is > added. In the 'del' ca

  1   2   3   >