From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 20 Dec 2007 11:26:18 +0800
> Ilpo J??rvinen <[EMAIL PROTECTED]> wrote:
> >
> >> is the limitting factor? For latter IMHO this would be necessary:
> >>
> >> if (skb->len > limit)
> >> limit -= limit
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Wed, 19 Dec 2007 23:46:33 +0200 (EET)
> I'm not fully sure what's purpose of this code in tcp_write_xmit:
>
>if (skb->len < limit) {
>unsigned int trim = skb->len % mss_now;
>
>
On 20-12-2007 05:29, Herbert Xu wrote:
> Hi Dave:
>
> I had wanted to fix this for ages but kept putting it off and then
> forgetting about it :) So before I forget again,
>
> [IPSEC]: Avoid undefined shift operation when testing algorithm ID
>
> The aalgos/ealgos fields are only 32 bits wide.
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Thu, 20 Dec 2007 12:29:37 +0800
> [IPSEC]: Avoid undefined shift operation when testing algorithm ID
>
> The aalgos/ealgos fields are only 32 bits wide. However, af_key tries
> to test them with the expression 1 << id where id can be as large as
> 253.
From: "Mark Ryden" <[EMAIL PROTECTED]>
Date: Thu, 20 Dec 2007 09:29:47 +0200
> In arp_process() (net/ipv4/arp.c), there is unused code: definition
> and assignment of tha (target hw address ).
Patch applied, thanks.
> Signed-off-by:
> [EMAIL PROTECTED]
Please format your signed off line corre
Hello,
In arp_process() (net/ipv4/arp.c), there is unused code: definition
and assignment of tha (target hw address ).
Signed-off-by:
[EMAIL PROTECTED]
diff --git a/a/net/ipv4/arp.c b/b/net/ipv4/arp.c
index 14dec92..6f26cfe 100644
--- a/a/net/ipv4/arp.c
+++ b/b/net/ipv4/arp.c
@@ -706,7 +706,7 @
Hi Dave:
I had wanted to fix this for ages but kept putting it off and then
forgetting about it :) So before I forget again,
[IPSEC]: Avoid undefined shift operation when testing algorithm ID
The aalgos/ealgos fields are only 32 bits wide. However, af_key tries
to test them with the expression
"ip route show" does not print correct value when larger rto_min is
set (e.g. 3sec).
This problem is because of overflow in print_route() and
the patch below is a workaround fix for that.
[root test]# ./iproute2.git.org/ip/ip route show dev eth1
192.168.140.0/24 proto kernel scope link src 192
Ilpo J??rvinen <[EMAIL PROTECTED]> wrote:
>
>> is the limitting factor? For latter IMHO this would be necessary:
>>
>> if (skb->len > limit)
>> limit -= limit % mss_now;
Good catch! But how about putting this logic into tcp_window_allows
since t
Parag Warudkar wrote:
> On Dec 19, 2007 4:38 PM, Kok, Auke <[EMAIL PROTECTED]> wrote:
>> Parag Warudkar wrote:
>>> On 12/19/07, Kok, Auke <[EMAIL PROTECTED]> wrote:
>> why would this patch reduce wakeups even more than round_jiffies()? Does it
>> make
>> our ~2 second update interval not reliable?
On Dec 19, 2007 4:38 PM, Kok, Auke <[EMAIL PROTECTED]> wrote:
> Parag Warudkar wrote:
> > On 12/19/07, Kok, Auke <[EMAIL PROTECTED]> wrote:
>
> why would this patch reduce wakeups even more than round_jiffies()? Does it
> make
> our ~2 second update interval not reliable? can you quantify "shows i
Currently LSMs need to use a netfilter post routing hook to catch outbound
packets and subject them to access control. This works reasonably well but
has always been a bit awkward when IPsec or similar mechanisms were used
because the same packet would end up going through the same LSM hook multip
Add an inet_sys_snd_skb() LSM hook to allow the LSM to provide packet level
access control for all outbound packets. Using the existing postroute_last
netfilter hook turns out to be problematic as it is can be invoked multiple
times for a single packet, e.g. individual IPsec transforms, adding unw
Peter Zijlstra wrote:
Hi,
Another posting of the full swap over NFS series.
Andrew/Linus, could we start thinking of sticking this in -mm?
Two questions:
1 - what is the memory use impact on the system which don't do swap over
NFS, such as embedded systems, and
2 - what is the advantage o
On Wed, 19 Dec 2007, Ilpo Järvinen wrote:
> I'm not fully sure what's purpose of this code in tcp_write_xmit:
>
>if (skb->len < limit) {
>unsigned int trim = skb->len % mss_now;
>
>if (trim)
>
Hi all,
I'm not fully sure what's purpose of this code in tcp_write_xmit:
if (skb->len < limit) {
unsigned int trim = skb->len % mss_now;
if (trim)
limit = skb->len - trim;
Parag Warudkar wrote:
> On 12/19/07, Kok, Auke <[EMAIL PROTECTED]> wrote:
> [snip]
>
>> I can't possibly see any benefit from this other than that you just add up
>> to a
>> whole second to the initialization cycle, which is bad.
>>
> Well, Ok but it can't be bad - I've been using this patch some
On Wed, 19 Dec 2007, Eric Dumazet wrote:
> James Nichols a écrit :
> > On 12/19/07, Eric Dumazet <[EMAIL PROTECTED]> wrote:
> > > James Nichols a écrit :
> > > > > So you see outgoing SYN packets, but no SYN replies coming from the
> > > > > remote
> > > > > peer ? (you mention ACKS, but the firs
Hi David
Vlad Yasevich wrote:
> The following is a set of patches that updates the SCTP ADD-IP implementation
> to conform to the recently published RFC.
>
> ADD-IP is a SCTP Dynamic Address Configuration extensions, whereby
> the two end systems can dynamically modify the address lists for a giv
device_type property is bogus, better use proper compatible property.
Also change compatible to "fsl,ucc-mdio".
Per http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048388.html
Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/mpc832x_mds.dts |3 +--
arch/po
On 12/19/07, Kok, Auke <[EMAIL PROTECTED]> wrote:
[snip]
> I can't possibly see any benefit from this other than that you just add up to
> a
> whole second to the initialization cycle, which is bad.
>
Well, Ok but it can't be bad - I've been using this patch sometime and
haven't seen any problem
The following patch is backed against David's net-2.6 tree and is pretty
trivial. I know we're late in the 2.6.24 cycle but I think this is worth
merging, if you guys don't feel that way let me know and I'll resubmit it
for 2.6.25.
As a side note, I'm unable to actually test the patch because I c
In several places the arguments to the xfrm_audit_start() function are in the
wrong order resulting in incorrect user information being reported. This
patch corrects this by pacing the arguments in the correct order.
Signed-off-by: Paul Moore <[EMAIL PROTECTED]>
---
net/xfrm/xfrm_policy.c |
>
> We would still have to check np->mcast_oif is set in the link-local case
> since we shouldn't be getting here with a zero.
Actually, that's one of the things I wanted to look into. I'm not
sure if there's a path through here with (even non-linklocal) multicasts
that end up without a
Parag Warudkar wrote:
>
> Use deferrable timer for watchdog. Reduces wakeups from idle per second.
no, we don't want this. We already allow the re-scheduling of the watchdog to be
round_jiffies() modified so that it coincides with other interrupts.
but at load time we don't want the timer to be
David Stevens wrote:
Brian Haley <[EMAIL PROTECTED]> wrote on 12/19/2007 07:35:46 AM:
...
if (usin->sin6_scope_id)
sk->sk_bound_dev_if = usin->sin6_scope_id;
if (!sk->sk_bound_dev_if &&
(addr_type & IPV6_ADDR_MULTICAST)
David Stevens wrote:
Vlad Yasevich <[EMAIL PROTECTED]> wrote on 12/19/2007 07:20:53 AM:
But this still requires either a SO_BINDTODEVICE or sin6_scope_id. This
means the an application can call BINDTODEVICE(eth0), MULTICAST_IF(eth1)
issue a connect on a UDP socket an succeed? Seems wrong to m
Parag Warudkar wrote:
>
> Reduce wakeups from idle per second.
>
> Signed-off-by: Parag Warudkar <[EMAIL PROTECTED]>
>
> --- linux-2.6/drivers/net/e1000e/netdev.c2007-12-07
> 10:04:39.0 -0500
> +++ linux-2.6-work/drivers/net/e1000e/netdev.c2007-12-18
> 20:45:59.0 -0500
>
David Stevens wrote:
> Vlad Yasevich <[EMAIL PROTECTED]> wrote on 12/19/2007 07:20:53 AM:
>
>> But this still requires either a SO_BINDTODEVICE or sin6_scope_id. This
>> means the an application can call BINDTODEVICE(eth0), MULTICAST_IF(eth1)
>> issue a connect on a UDP socket an succeed? Seems
Brian Haley <[EMAIL PROTECTED]> wrote on 12/19/2007 07:35:46 AM:
...
> > if (usin->sin6_scope_id)
> > sk->sk_bound_dev_if = usin->sin6_scope_id;
> > if (!sk->sk_bound_dev_if &&
> > (addr_type & IPV6_ADDR_MULTICAST))
> >
On Wed, 19 Dec 2007, James Nichols wrote:
> > > And the problem almost instanteaously resolved itself and outbound
> > > connection attempts were succesful.
> >
> > New or the pending ones?
>
> I'm fairly sure that sockets that were already open in SYN_SENT state
> when I turned tcp_sack off star
Vlad Yasevich <[EMAIL PROTECTED]> wrote on 12/19/2007 07:20:53 AM:
> But this still requires either a SO_BINDTODEVICE or sin6_scope_id. This
> means the an application can call BINDTODEVICE(eth0), MULTICAST_IF(eth1)
> issue a connect on a UDP socket an succeed? Seems wrong to me.
>
> Can you ch
> The router could be sooo crappy that it drops all packets from
> TCP streams that have SACK enabled and the client has opened
> 200+ SACK connections previously... something like that?
I don't know, maybe. My router is a fairly new model Cisco and is
pretty major (i.e. pretty expensive), so it'
From: Timo Teras <[EMAIL PROTECTED]>
mac_header update in ipgre_recv() was incorrectly changed to
skb_reset_mac_header() when it was introduced.
Signed-off-by: Timo Teras <[EMAIL PROTECTED]>
---
This replaces my earlier patch titled "ip_gre: use skb->{mac,
network}_header consistently". Apparentl
James Nichols a écrit :
On 12/19/07, Eric Dumazet <[EMAIL PROTECTED]> wrote:
James Nichols a écrit :
So you see outgoing SYN packets, but no SYN replies coming from the remote
peer ? (you mention ACKS, but the first packet received from the remote
peer should be a SYN+ACK),
Right, I meant to
On Dec 19 2007 12:43, James Nichols wrote:
>On 12/19/07, Eric Dumazet <[EMAIL PROTECTED]> wrote:
>> James Nichols a écrit :
>> >> So you see outgoing SYN packets, but no SYN replies coming from the remote
>> >> peer ? (you mention ACKS, but the first packet received from the remote
>> >> peer sh
On 12/19/07, Eric Dumazet <[EMAIL PROTECTED]> wrote:
> James Nichols a écrit :
> >> So you see outgoing SYN packets, but no SYN replies coming from the remote
> >> peer ? (you mention ACKS, but the first packet received from the remote
> >> peer should be a SYN+ACK),
> >
> > Right, I meant to say
> > When I stop and start the Java application, all the new outbound
> > connections still get stuck in SYN_SENT state.
>
> Is it so that they don't timeout at all? You can collect some of their
> state from /proc/net/tcp (shows at least timers and attempt counters)
The outbound connections to
On Wed, Dec 19, 2007 at 01:42:36PM +0100, Thomas Bogendoerfer wrote:
> - Use inline functions for dma_sync_* instead of macros
> - added Kconfig change to make selection for similair SGI boxes easier
>
> Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]>
Acked-by: Ralf Baechle <[EMAIL PROTE
From: Gregory CLEMENT <[EMAIL PROTECTED]>
Initially transmit buffer pointers were only reset. But buffer
descriptors were possibly still set as ready, and buffer in upper
layer was not freed. This caused driver hang under big load. Now
reset clean properly the buffer descriptor and freed upper la
Pavel Emelyanov a écrit :
Eric Dumazet wrote:
Pavel Emelyanov a écrit :
Eric Dumazet wrote:
If you un-inline this (good idea), I am not sure we still need listen_possible
argument.
It was usefull only to help compiler to zap dead code (since it was known at
compile time), now it only adds s
> So you see outgoing SYN packets, but no SYN replies coming from the remote
> peer ? (you mention ACKS, but the first packet received from the remote
> peer should be a SYN+ACK),
Right, I meant to say SYN+ACK. I don't see them coming back.
> When the problem comes, instead of restarting the
James Nichols a écrit :
So you see outgoing SYN packets, but no SYN replies coming from the remote
peer ? (you mention ACKS, but the first packet received from the remote
peer should be a SYN+ACK),
Right, I meant to say SYN+ACK. I don't see them coming back.
So... Really unlikely a linux p
Eric Dumazet wrote:
> Pavel Emelyanov a écrit :
>> Eric Dumazet wrote:
>>> Pavel Emelyanov a écrit :
This one is used in quite many places in the networking code and
seems to big to be inline.
After the patch net/ipv4/build-in.o loses 725 bytes:
add/remove: 1/0 grow/shrink:
Pavel Emelyanov a écrit :
Eric Dumazet wrote:
Pavel Emelyanov a écrit :
This one is used in quite many places in the networking code and
seems to big to be inline.
After the patch net/ipv4/build-in.o loses 725 bytes:
add/remove: 1/0 grow/shrink: 0/5 up/down: 374/-1099 (-725)
function
Hi, David!
This set adds namespace support for routing tables & rules manipulation
in the different namespaces. So, one could create a namespace and
setup IPv4 routing there how he wants.
After this patch user will have the ability to configure and
observe its own isolated set of routing rules/ta
Hi David,
David Stevens wrote:
OK, I see what you're trying to fix now.
I think the scope_id checks are not quite right-- they
should be something like this:
if (addr_type&IPV6_ADDR_LINKLOCAL) {
if (addr_len >= sizeof(struct sockaddr_in6)) {
if (sk->sk_bound_dev_if && u
Move static rules_ops & rules_mod_lock to the struct net, register the
pernet subsys to init them and enjoy the fact that the core rules
infrastructure works in the namespace.
Real IPv4 fib rules virtualization requires fib tables support in the
namespace and will be done seriously later in the pa
This adds netns parameter to fib_proc_init/exit and replaces __init specifier
with __net_init. After this, we will not yet have these proc files show info
from the specific namespace - this will be done when these tables become
namespaced.
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-by
nl_info is used to track the end-user destination of routing change
notification. This is a natural object to hold a namespace on. Place it
there and utilize the context in the appropriate places.
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
i
The preparatory work has been done. All we need is to substitute
fib_table_hash with net->ipv4.fib_table_hash. Netns context is available when
required.
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
include/net/ip_fib.h |7 ++-
incl
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
net/ipv4/fib_frontend.c | 24
1 files changed, 4 insertions(+), 20 deletions(-)
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
index a5c47fc..a5e2fb3 10064
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
net/ipv4/fib_frontend.c | 27 ++-
1 files changed, 14 insertions(+), 13 deletions(-)
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
index abe9f43..cecb660 1
This is the second part (for the CONFIG_IP_FIB_TRIE case) of the patch #4,
where we have created proc files in namespaces.
Now we can dump correct info in them.
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
net/ipv4/fib_trie.c | 44 +
This adds error paths into both versions of fib4_rules_init (with/without
CONFIG_IP_MULTIPLE_TABLES) and returns error code to the caller.
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
include/net/ip_fib.h|2 +-
net/ipv4/fib_frontend.c
The final trick for rules: place fib4_rules_ops into struct net and modify
initialization path for this.
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
include/net/netns/ipv4.h |5 +
net/ipv4/fib_rules.c | 44 ++
I.e. remove the net != &init_net checks from the places, that now can handle
other-than-init net namespace.
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
net/ipv4/fib_frontend.c | 24
1 files changed, 4 insertions(+),
Currently the code is only called in the initial namespace, but
this is not so as soon as the code being called can handle it.
So collect the calls to all needed fib initialization functions
in one place and register it as a pernet subsys.
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-b
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]>
---
drivers/s390/net/qeth_main.c |2 +-
include/net/route.h |4 ++--
net/atm/clip.c|2 +-
net/ipv4/af_inet.c|2 +-
net/ipv4/arp.c
This provides a ground for further fib rules operations virtualization.
Currently pass the init_net into them.
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
include/net/fib_rules.h | 16 +++-
net/core/fib_rules.c|4 ++--
n
This is the second part (for the CONFIG_IP_FIB_HASH case) of the patch #4,
where we have created proc files in namespaces.
Now we can dump correct info in them.
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
net/ipv4/fib_hash.c | 17 +
This is a central entry point to the fib storage after the previous patch.
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
include/net/ip_fib.h| 16
net/ipv4/fib_frontend.c | 24
net/ipv4/fib_hash
Replace the direct pointers to local and main tables with
calls to fib_get_table() with appropriate argument.
This doesn't introduce additional dereferences, but makes the access to fib
tables uniform in any (CONFIG_IP_MULTIPLE_TABLES) case.
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off
fib_rules_ops contains operations and the list of configured rules. ops will
become per/namespace soon, so we need them to be known in the default_pref
callback.
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
include/net/fib_rules.h |2 +-
n
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
include/net/netns/ipv4.h |2 ++
net/ipv4/fib_frontend.c | 26 ++
2 files changed, 20 insertions(+), 8 deletions(-)
diff --git a/include/net/netns/ipv4.h b/include/net/
... up to rtentry_to_fib_config
Acked-by: Benjamin Thery <[EMAIL PROTECTED]>
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
include/net/route.h |2 +-
net/ipv4/af_inet.c |2 +-
net/ipv4/fib_frontend.c |8
net/ipv4/ipconfig.c |2 +-
4 files changed, 7 i
Daven
David Stevens wrote:
> Brian,
>
> OK, I see what you're trying to fix now.
>
> I think the scope_id checks are not quite right-- they
> should be something like this:
>
> if (addr_type&IPV6_ADDR_LINKLOCAL) {
> if (addr_len >= sizeof(struct sockaddr_in6)) {
> if (sk
In the presence of multiple network namespaces the logic needed
to allocate the a default parameter table is just barely non-trivial.
So add a function to automate it to make everyone's life easier.
Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]>
Signed-off-by: Daniel Lezcano <[EMAIL PROTECTE
I'm actually surprised at how much was involved. At first glance it appears
that the neighbour table data structures are already split by network device
so all that should be needed is to modify the user interface commands
to filter the set of neighbours by the network namespace of their devices.
These two patches are coming from Eric Biederman patchset
to make the neighbouring to be aware of the namespaces.
The description in the patch headers is big enough to add
more comments here :)
--
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [E
On Tue, Dec 18, 2007 at 08:53:39PM +0100, Krzysztof Oledzki wrote:
>
>
> On Fri, 14 Dec 2007, Andy Gospodarek wrote:
>
> >On Fri, Dec 14, 2007 at 07:57:42PM +0100, Krzysztof Oledzki wrote:
> >>
> >>
> >>On Fri, 14 Dec 2007, Andy Gospodarek wrote:
> >>
> >>>On Fri, Dec 14, 2007 at 05:14:57PM +010
This removes code clearing Ack Vector state when it is acknowledged via an
Ack Vector by the peer. That code is redundant, since
* the receiver always puts the full acknowledgment window (groups 2,3 in
11.4.2)
into the Ack Vectors it sends; hence the HC-receiver is only interested in
the
h
This patch updates the fields used by the Ack Vector structures:
* buf_tail was missing and has been added as struct member (support for
updating this field follows in subsequent patches);
* the buf_nonce is now an array, each element covering up to 253 bytes of
buffer state - this simpli
This patch
* simplifies the dccp_ackvec_insert_avr() routine: the BUG_ON was redundant,
since the list is automatically arranged in descending order of ack_no;
* separates Ack Vector housekeeping code from option-specific code;
* shifts option-specific code into options.c.
Signed-off-by: Ger
This provides inlines for Ack Vector run length and state, which allow to wrap
several instances of the same code into function calls.
The unused function dccp_ackvec_print() (which also relied on the older
constants), has been removed.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
---
net/dc
This adds missing bits to complete the implementation of a circular buffer for
Ack Vector information, with the following changes:
(a) An `overflow' flag to deal with the case of overflow. As before, dynamic
growth of the buffer will not be supported; but code will be added to deal
more
This patch removes redundant bits, implementing the same functionality with
less code.
The details are:
* The INIT_LIST_HEAD in dccp_ackvec_record_new was redundant, since the list
pointers
were later overwritten when the node was added via list_add().
* dccp_ackvec_record_new() was cal
This replaces 3 #defines with an enum containing all possible
Ack Vector states as per RFC 4340, 11.4. This helps to reduce
the length of several expressions.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
---
net/dccp/ackvec.c |7 +++
net/dccp/ackvec.h | 10 ++
net/
This patch updates the code which registers new packets as received, using the
new circular buffer interface, it now
* supports both tail/head pointers and buffer wrap-around,
* deals with overflow (head/tail move in lock-step), and
* uses dynamic buffer-length computation.
The length of the circular Ack Vector buffer is now determined dynamically,
as the span between head to tail.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
---
net/dccp/ackvec.c | 21 +
net/dccp/ackvec.h |7 +++
net/dccp/options.c |7 ---
3 files changed
This decouples the use of Elapsed Time options from the use of Ack Vectors, so
that Elapsed Time options are no longer added automatically to each Ack Vector.
There are three reasons for this:
1. The Elapsed Time information is nowhere used in the code.
2. DCCP does not implement rate-based pac
CCID2 feedback only considers Ack/DataAck packets, but Ack Vectors can appear
on other packets, too. In RFC 4340, 11.4 the only restriction is that they must
not appear on Data or Request packets.
A possible case is for instance a Sync packet used for feature-negotiation
(as used e.g in section 6
This implements an algorithm to consistently update the buffer state when
the peer acknowledges receipt of Ack Vectors; updating state in the list of
Ack Vectors as well as in the circular buffer.
The algorithm
* deals with HC-sender acknowledging to HC-receiver and vice versa,
* keeps track of
This set of patches adds functionality to the existing DCCP Ack Vector
implementation, extends it to a full circular buffer, and fixes two
previously undiscovered problems which otherwise result in a corrupted
buffer state.
It is important that Ack Vectors run reliably since otherwise problems in
This removes
* functions for which updates have been provided in the preceding patches and
* the @av_vec_len field - it is no longer necessary since the buffer length is
now always computed dynamically;
* conditional debugging code (CONFIG_IP_DCCP_ACKVEC).
The reason for removing the latter
This aggregates Ack Vector processing (handling input and clearing old state)
into one function, for the following reasons and benefits:
* duplicated code is removed;
* all Ack Vector-specific processing is now in one place;
* sanity: from an Ack Vector point of view, it is better to clear the o
Hi
The pneigh_lookup/delete silently concerns, that the
key_len of the table is more that 4 bytes. Look:
u32 hash_val = *(u32 *)(pkey + key_len - 4);
The hash_val for the proxy neighbor entry is four last bytes
from the pkey.
But the dn_neigh_tables' key_len is sizeof(__le16), that is
* Herbert Xu <[EMAIL PROTECTED]> wrote:
> On Wed, Dec 19, 2007 at 12:31:52PM +0100, Ingo Molnar wrote:
> >
> > > So I'm wondering if it would be reasonable to make it out-of-line
> > > when TRACE_IRQFLAGS is off. This may make a difference because
> > > the networking stack is a frequent user
On Wed, 19 Dec 2007, Gavin McCullagh wrote:
> On Wed, 19 Dec 2007, Ilpo Järvinen wrote:
>
> > Isn't it also much better this way in a case where ACK losses happened,
> > taking the longest RTT in that case is clearly questionable as it
> > may over-estimate considerably.
>
> Quite so.
>
> > Howe
David Miller wrote:
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 19 Dec 2007 14:12:10 +0800
[IPSEC]: Do xfrm_state_check_space before encapsulation
While merging the IPsec output path I moved the encapsulation output
operation to the top of the loop so that it sits outside of the locked
sec
Eric Dumazet wrote:
> Pavel Emelyanov a écrit :
>> This one is used in quite many places in the networking code and
>> seems to big to be inline.
>>
>> After the patch net/ipv4/build-in.o loses 725 bytes:
>> add/remove: 1/0 grow/shrink: 0/5 up/down: 374/-1099 (-725)
>> function
On Dec 18, 2007 9:58 PM, Zhu Yi <[EMAIL PROTECTED]> wrote:
>
> On Tue, 2007-12-18 at 15:57 +0100, Johannes Berg wrote:
> > Thanks. This is a bug in iwlwifi.
> >
> > The problem is actually another case where my workqueue debugging with
> > lockdep is triggering a warning :))
> >
> > Here's the thin
On Sun, 16 Dec 2007, James Nichols wrote:
> I have a Java application that makes a large number of outbound
> webservice calls over HTTP/TCP. The hosts contacted are a fixed set
> of about 2000 hosts and a web service call is made to each of them
> approximately every 5 mintues by a pool of 200 J
- Use inline functions for dma_sync_* instead of macros
- added Kconfig change to make selection for similair SGI boxes easier
Signed-off-by: Thomas Bogendoerfer <[EMAIL PROTECTED]>
---
drivers/net/Kconfig |2 +-
drivers/net/sgiseeq.c | 64 ++-
Marco Berizzi <[EMAIL PROTECTED]> wrote:
>
> Is this bug recently introduced? I'm using this
> config since 2.6.16/openswan 2.4.4 (two years).
> I haven't never noticed: now I must restart openswan
> once a day :-(
No it's been there forever but I haven't worked out exactly
what triggers it yet or
Pavel Emelyanov a écrit :
This one is used in quite many places in the networking code and
seems to big to be inline.
After the patch net/ipv4/build-in.o loses 725 bytes:
add/remove: 1/0 grow/shrink: 0/5 up/down: 374/-1099 (-725)
function old new delta
_
On Wed, Dec 19, 2007 at 12:31:52PM +0100, Ingo Molnar wrote:
>
> > So I'm wondering if it would be reasonable to make it out-of-line when
> > TRACE_IRQFLAGS is off. This may make a difference because the
> > networking stack is a frequent user of local_bh_disable and
> > local_bh_enable.
>
> d
* Herbert Xu <[EMAIL PROTECTED]> wrote:
> Hi Ingo:
>
> I noticed that local_bh_disable is now always out-of-line. The change
> was made when TRACE_IRQFLAGS was added. However, with TRACE_IRQFLAGS
> off, local_bh_disable does exactly the same work as before. In
> particular, it does pretty
Hi,
On Wed, 19 Dec 2007, Ilpo Järvinen wrote:
> Isn't it also much better this way in a case where ACK losses happened,
> taking the longest RTT in that case is clearly questionable as it
> may over-estimate considerably.
Quite so.
> However, another thing to consider is the possibility of this
On Tue, 18 Dec 2007, Gavin McCullagh wrote:
> The last attempt didn't take account of the situation where a timestamp
> wasn't available and tcp_clean_rtx_queue() has to feed both the RTO and the
> congestion avoidance. This updated patch stores both RTTs, making the
> delayed one available for t
1 - 100 of 106 matches
Mail list logo
