[GIT PULL] [NET]: Use {hton{s,l},cpu_to_be{16,32}}() where appropriate.

2007-12-13 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. Please consider pulling the following changes from the branch net-2.6-dev-20071214 available at which is on top of your net-2.6-devel tree. Regards, --- HEADLINES - [BRIDGE]: Use cpu_to_be16() where appropriate. [DECNET]: Use htons() where appropriate.

Re: [PATCH 2/2] ucc_geth: use rx-clock-name and tx-clock-name device tree properties

2007-12-13 Thread Kumar Gala
On Dec 3, 2007, at 3:17 PM, Timur Tabi wrote: Updates the ucc_geth device driver to check the new rx-clock-name and tx-clock-name properties first. If present, it uses the new function qe_clock_source() to obtain the clock source. Otherwise, it checks the deprecated rx-clock and tx-clock p

Re: 2.6.24-rc4-mm1 - BUG in tcp_fragment

2007-12-13 Thread Cedric Le Goater
Ilpo Järvinen wrote: > On Thu, 13 Dec 2007, Cedric Le Goater wrote: > >> I got this one while compiling on NFS. >> >> C. >> >> kernel BUG at /home/legoater/linux/2.6.24-rc4-mm1/include/net/tcp.h:1480! > > I'm not exactly sure what patches you have applied and which patches are > not, with rc4-mm

Re: [PATCH] PS3: gelic: Add wireless support for PS3

2007-12-13 Thread David Woodhouse
--- linux-2.6.23.ppc64/drivers/net/ps3_gelic_net.c~ 2007-12-14 01:31:50.0 -0500 +++ linux-2.6.23.ppc64/drivers/net/ps3_gelic_net.c 2007-12-14 01:39:25.0 -0500 @@ -1139,7 +1139,7 @@ static irqreturn_t gelic_card_interrupt( * * see Documentation/networking/netconsole.tx

Re: [PATCH 2/2] ucc_geth: use rx-clock-name and tx-clock-name device tree properties

2007-12-13 Thread Jeff Garzik
Kumar Gala wrote: On Dec 3, 2007, at 3:17 PM, Timur Tabi wrote: Updates the ucc_geth device driver to check the new rx-clock-name and tx-clock-name properties first. If present, it uses the new function qe_clock_source() to obtain the clock source. Otherwise, it checks the deprecated rx-cloc

Re: [3/4] DST: Network state machine.

2007-12-13 Thread Evgeniy Polyakov
On Thu, Dec 13, 2007 at 11:43:43PM +0300, Dmitry Monakhov ([EMAIL PROTECTED]) wrote: > On 14:47 Mon 10 Dec , Evgeniy Polyakov wrote: > > > > Network state machine. > > > > Includes network async processing state machine and related tasks. > Hi, I've tried to play a little bit with DST and di

Re: What was the reason for 2.6.22 SMP kernels to change how sendmsg is called?

2007-12-13 Thread Evgeniy Polyakov
Hi Kevin. On Thu, Dec 13, 2007 at 04:00:02PM -0600, Kevin Wilson ([EMAIL PROTECTED]) wrote: > I see your point but it just so happens it is a GPL'd driver, as is all of > our Linux code we produce for our hardware. Granted it is out of tree, and > after you saw it you would want it to stay that

[BUG] Kernel Bugzilla: networking bugs

2007-12-13 Thread Natalie Protasevich
Hello, Here are few networking bugs from bugzilla.kernel.org. Could someone take a look please? Thanks! (net forcedeth) frequent network ups and downs http://bugzilla.kernel.org/show_bug.cgi?id=9200 Kernel: 2.6.23 00:07.0 Bridge: nVidia Corporation MCP61 Ethernet (rev a2) rtl8187 very unreliable

Re: [RFC] mac80211: clean up frame receive handling

2007-12-13 Thread Jouni Malinen
On Wed, Dec 12, 2007 at 07:24:04PM +0100, Johannes Berg wrote: > This cleans up the frame receive handling. After this patch > * EAPOL frames addressed to us or the EAPOL group address are >always accepted regardless of whether they are encrypted or not > * other frames from a station are dr

Re: [PATCH] PS3: gelic: Add wireless support for PS3

2007-12-13 Thread Masakazu Mokuno
On Thu, 13 Dec 2007 10:33:22 -0500 Dan Williams <[EMAIL PROTECTED]> wrote: > You'll need to emit more NULL IWAP events on association failure. For > example, gelic_wl_assoc_worker() should probably send one right before > both instances of 'goto scan_lock_out' in that function (the first where >

Re: [PATCH 2/2] ucc_geth: use rx-clock-name and tx-clock-name device tree properties

2007-12-13 Thread Kumar Gala
On Dec 3, 2007, at 3:17 PM, Timur Tabi wrote: Updates the ucc_geth device driver to check the new rx-clock-name and tx-clock-name properties first. If present, it uses the new function qe_clock_source() to obtain the clock source. Otherwise, it checks the deprecated rx-clock and tx-clock p

Re: [PATCH] PS3: gelic: Add wireless support for PS3

2007-12-13 Thread Masakazu Mokuno
On Thu, 13 Dec 2007 16:13:38 -0500 Dan Williams <[EMAIL PROTECTED]> wrote: > One more question; does the driver work with wpa_supplicant for WPA, or > does the firmware capture the EAPOL frames and handle the 4 way > handshake internally? Ideally the firmware would have the ability to > pass tho

Re: [PATCH 1/7] [NETDEV]: e1000 Fix possible causing oops of net_rx_action

2007-12-13 Thread Joonwoo Park
2007/12/13, David Miller <[EMAIL PROTECTED]>: > From: "Joonwoo Park" <[EMAIL PROTECTED]> > Date: Thu, 13 Dec 2007 19:18:56 +0900 > > > Just blowing netif_running up is not best solution I think, it makes > > ifconfig down hang at least for e1000. > > It hangs because the packet receive rate is so h

Re: 2.6.24-rc5-mm1

2007-12-13 Thread Herbert Xu
On Thu, Dec 13, 2007 at 09:45:54AM -0800, David Miller wrote: > From: Benjamin Thery <[EMAIL PROTECTED]> > Date: Thu, 13 Dec 2007 16:01:34 +0100 > > > The problem comes from the new macro UDPX_INC_STATS_BH introduced > > by Herbert, which was a nice addition to increment the correct > > UDP MIB d

Re: [RFC] net: napi fix

2007-12-13 Thread Joonwoo Park
2007/12/13, Andrew Gallatin <[EMAIL PROTECTED]>: > > If the netif_running() check is indeed required to make a device break > out of napi polling and respond to an ifconfig down, then I think the > netif_running() check should be moved up into net_rx_action() to avoid > potential for driver complex

Regression: Wireshark sees no packets in 2.6.24-rc3

2007-12-13 Thread Ray Lee
tshark -i eth0, eth1, lo are all empty. Works under 2.6.23.0 just fine. A quick scan of the log between 2.6.24-rc3 and current tip (-rc5) doesn't show any obvious fixes, but then again, what do I know. I'll check current tip on the weekend when I'll have the luxury to have my main system down long

[PATCH 1/3] [DCCP]: Documentation for CCID operations

2007-12-13 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker <[EMAIL PROTECTED]> This adds documentation for the ccid_operations structure. Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]> Signed-off-by: Ian McDonald <[EMAIL PROTECTED]> Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> --- net/dccp/ccid.h | 35 +

[PATCHES 0/3]: DCCP patches for 2.6.25

2007-12-13 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25 Best Regards, - Arnaldo net/dccp/ccid.c|8 net/dccp/ccid.h| 37 ++--- net/dccp/ccids/ccid2.c |2 +- net/dccp/ccids/cci

[PATCH 2/3] [CCID]: More informative registration

2007-12-13 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker <[EMAIL PROTECTED]> The patch makes the registration messages of CCID 2/3 a bit more informative: instead of repeating the CCID number as currently done, "CCID: Registered CCID 2 (ccid2)" or "CCID: Registered CCID 3 (ccid3)", the descriptive names of the CCID

[PATCH 3/3] [DCCP]: Introducing CCMPS

2007-12-13 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker <[EMAIL PROTECTED]> This introduces a CCMPS field for setting a CCID-specific upper bound on the application payload size, as is defined in RFC 4340, section 14. Only the TX CCID is considered in setting this limit, since the RX CCID generates comparatively small (DCCP-Ack)

Re: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread Andrew Morton
On Thu, 13 Dec 2007 16:53:58 -0800 "Ed Swierk" <[EMAIL PROTECTED]> wrote: > On 12/13/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > Does this patch actually fix any observeable problem? > > Without the patch, ifconfig down leaves the physical link up, which > confuses datacenter users who expec

RE: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread Brandeburg, Jesse
Andrew Morton wrote: > On Thu, 13 Dec 2007 16:11:55 -0800 > "Ayaz Abdulla" <[EMAIL PROTECTED]> wrote: > >> I would not include this patch until further testing is performed. >> NVIDIA MCP chips use 3rd party PHY vendors. By powering down the >> phy, it could have adverse affects on certain phys. >

Re: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread Ed Swierk
On 12/13/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > Does this patch actually fix any observeable problem? Without the patch, ifconfig down leaves the physical link up, which confuses datacenter users who expect the link lights both on the NIC and the switch to go out when they bring an interfa

RE: What was the reason for 2.6.22 SMP kernels to change how sendmsg is called?

2007-12-13 Thread Brandeburg, Jesse
Kevin Wilson wrote: > Nonetheless, a somewhat recent change in your tree, that I could not > pinpoint on my own, caused the driver to stop functioning properly. > So after much searching in git/google/sources with no luck, I decided > to ask for a little assistance, maybe just a hint as to where th

Re: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread Andrew Morton
On Thu, 13 Dec 2007 16:11:55 -0800 "Ayaz Abdulla" <[EMAIL PROTECTED]> wrote: > I would not include this patch until further testing is performed. > NVIDIA MCP chips use 3rd party PHY vendors. By powering down the phy, it > could have adverse affects on certain phys. > > Ayaz > > > -Original

RE: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread Ayaz Abdulla
I would not include this patch until further testing is performed. NVIDIA MCP chips use 3rd party PHY vendors. By powering down the phy, it could have adverse affects on certain phys. Ayaz -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, December 13,

[patch 07/10] e100: free IRQ to remove warning when rebooting

2007-12-13 Thread akpm
From: Ian Wienand <[EMAIL PROTECTED]> When rebooting today I got Will now restart. ACPI: PCI interrupt for device :00:03.0 disabled GSI 20 (level, low) -> CPU 1 (0x0100) vector 53 unregistered Destroying IRQ53 without calling free_irq WARNING: at /home/insecure/ianw/programs/git-kernel/linux

[patch 09/10] bnx2x depends on ZLIB_INFLATE

2007-12-13 Thread akpm
From: Lee Schermerhorn <[EMAIL PROTECTED]> The bnx2x module depends on the zlib_inflate functions. The build will fail if ZLIB_INFLATE has not been selected manually or by building another module that automatically selects it. Modify BNX2X config option to 'select ZLIB_INFLATE' like BNX2 and oth

[patch 05/10] pcmcia net: use roundup_pow_of_two() macro instead of grotesque loop

2007-12-13 Thread akpm
From: "Robert P. J. Day" <[EMAIL PROTECTED]> Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Dominik Brodowski <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/pcmcia/pcnet_cs.c |4 ++-- 1 file changed, 2 inserti

[patch 06/10] Net: ibm_newemac, remove SPIN_LOCK_UNLOCKED

2007-12-13 Thread akpm
From: Jiri Slaby <[EMAIL PROTECTED]> SPIN_LOCK_UNLOCKED is deprecated, use DEFINE_SPINLOCK instead Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/debug.c |2 +- 1 file changed, 1

[patch 08/10] net: smc911x: shut up compiler warnings

2007-12-13 Thread akpm
From: Paul Mundt <[EMAIL PROTECTED]> Trivial fix to shut up gcc. Signed-off-by: Paul Mundt <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/smc911x.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drive

[patch 04/10] ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes

2007-12-13 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> Cc: "David S. Miller" <[EMAIL PROTECTED]> Cc: Emil Medve <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Kumar Gala <[EMAIL PROTECTED]> Cc: Li Yang <[EMAIL PROTECTED]> Cc: Paul Mackerras <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PR

[patch 10/10] PLIP driver: convert killed_timer_sem to completion

2007-12-13 Thread akpm
From: Matthias Kaehlcke <[EMAIL PROTECTED]> PLIP driver: convert the semaphore killed_timer_sem to a completion Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/plip.c | 10 +- 1 f

[patch 03/10] forcedeth: fix MAC address detection on network card (regression in 2.6.23)

2007-12-13 Thread akpm
From: Michael Pyne <[EMAIL PROTECTED]> Partially revert a change to mac address detection introduced to the forcedeth driver. The change was intended to correct mac address detection for newer nVidia chipsets where the mac address was stored in reverse order. One of those chipsets appears to sti

[patch 01/10] e1000e: make E1000E default to the same kconfig setting as E1000

2007-12-13 Thread akpm
From: Randy Dunlap <[EMAIL PROTECTED]> Make E1000E default to the same kconfig setting as E1000. So people's machiens don't stop working when they use oldconfig. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Auke Kok <[EMAIL PROTECTED]> Signed-off-by: An

[patch 3/4] tipc: fix semaphore handling

2007-12-13 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> As noted by Kevin, tipc's release() does down_interruptible() and ignores the return value. So if signal_pending() we'll end up doing up() on a non-downed semaphore. Fix. Cc: Kevin Winchester <[EMAIL PROTECTED]> Cc: Per Liden <[EMAIL PROTECTED]> Cc: Jon M

[patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread akpm
From: "Ed Swierk" <[EMAIL PROTECTED]> Bring the physical link down when the interface is down by placing the PHY in power-down state, unless WOL is enabled. This mirrors the behavior of other drivers including e1000 and tg3. Signed-off-by: Ed Swierk <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PR

[patch 1/4] Updates to nfsroot documentation

2007-12-13 Thread akpm
From: Amos Waterland <[EMAIL PROTECTED]> The difference between ip=off and ip=::off has been a cause of much confusion. Document how each behaves, and do not contradict ourselves by saying that "off" is the default when in fact "any" is the default and is descibed as being so lower in the fil

[patch 4/4] PPP synchronous tty: convert dead_sem to completion

2007-12-13 Thread akpm
From: Matthias Kaehlcke <[EMAIL PROTECTED]> PPP synchronous tty channel driver: convert the semaphore dead_sem to a completion Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]> Cc: Paul Mackerras <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- drivers/net/ppp_synctty

[patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL()

2007-12-13 Thread akpm
From: Andrew Morton <[EMAIL PROTECTED]> ASSERT_RTNL() uses mutex_trylock(), but it's better to use mutex_is_locked(). Make that change, and remove rtnl_trylock() altogether. (not tested yet!) Cc: "David S. Miller" <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> --- driver

[PATCH net-2.6.25 7/8] drivers/infiniband: Use ipv4_is_

2007-12-13 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/infiniband/core/addr.c |4 ++-- drivers/infiniband/core/cma.c |5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c index 5381c80..0802b79 100644

[PATCH net-2.6.25 8/8] Remove unused IPV4TYPE macros

2007-12-13 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- include/linux/in.h | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git a/include/linux/in.h b/include/linux/in.h index f8d6073..27d8a5a 100644 --- a/include/linux/in.h +++ b/include/linux/in.h @@ -272,12 +272,6 @@

[PATCH net-2.6.25 4/8] net/ipv4: Use ipv4_is_

2007-12-13 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/ipv4/arp.c |2 +- net/ipv4/datagram.c |2 +- net/ipv4/devinet.c |4 +- net/ipv4/fib_frontend.c |6 ++-- net/ipv4/igmp.c | 12 +- net/ipv4/ip_gre.c | 23 +++- net/ipv4

[PATCH net-2.6.25 5/8] net/netfilter: Use ipv4_is_

2007-12-13 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/netfilter/xt_pkttype.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/netfilter/xt_pkttype.c b/net/netfilter/xt_pkttype.c index c598bbe..2762449 100644 --- a/net/netfilter/xt_pkttype.c +++ b/net/netfilter/xt_pkt

[PATCH net-2.6.25 6/8] sctp: Use ipv4_is_

2007-12-13 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- include/net/sctp/constants.h | 36 ++-- net/sctp/protocol.c | 12 +++- 2 files changed, 13 insertions(+), 35 deletions(-) diff --git a/include/net/sctp/constants.h b/include/net/sctp/constants

[PATCH net-2.6.25 2/8] include/net: Use ipv4_is_

2007-12-13 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- include/net/addrconf.h | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/net/addrconf.h b/include/net/addrconf.h index c56827d..1c3a560 100644 --- a/include/net/addrconf.h +++ b/include/net/addrconf.h @@ -2

[PATCH net-2.6.25 1/8] Create ipv4_is_(__be32 addr) functions

2007-12-13 Thread Joe Perches
Change IPV4 specific macros LOOPBACK MULTICAST LOCAL_MCAST BADCLASS and ZERONET macros to inline functions ipv4_is_(__be32 addr) Adds type safety and arguably some readability. Changes since last submission: Removed ipv4_addr_octets function Used hex constants Converted recently added rfc3330 ma

[PATCH net-2.6.25 3/8] net/core: Use ipv4_is_

2007-12-13 Thread Joe Perches
Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- net/core/netpoll.c |3 ++- net/core/pktgen.c |8 +--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index b1d5acd..6faa128 100644 --- a/net/core/netpoll.c +++ b/net/core/netpol

Re: 2.6.24-rc4-mm1 - BUG in tcp_fragment

2007-12-13 Thread Ilpo Järvinen
On Thu, 13 Dec 2007, Cedric Le Goater wrote: > I got this one while compiling on NFS. > > C. > > kernel BUG at /home/legoater/linux/2.6.24-rc4-mm1/include/net/tcp.h:1480! I'm not exactly sure what patches you have applied and which patches are not, with rc4-mm1 there are two patches (first one

Re: [RFC] net: napi fix

2007-12-13 Thread Jarek Poplawski
David Miller wrote, On 12/13/2007 11:34 PM: > From: Jarek Poplawski <[EMAIL PROTECTED]> > Date: Thu, 13 Dec 2007 23:28:41 +0100 > >> ...I'm afraid I can't understand: I mean doing the same but without >> passing this info with 'work == weight': if driver sends this info, >> why it can't instead c

Re: [RFC] net: napi fix

2007-12-13 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 23:28:41 +0100 > ...I'm afraid I can't understand: I mean doing the same but without > passing this info with 'work == weight': if driver sends this info, > why it can't instead call something like napi_continue() with > this list_mo

Re: [RFC] net: napi fix

2007-12-13 Thread Jarek Poplawski
David Miller wrote, On 12/13/2007 09:37 PM: ... > For example, if we export the list handling widget into the ->poll() > routines, god help the person who wants to change how the poll list is > managed in net_rx_action() :-/ ...I'm afraid I can't understand: I mean doing the same but without pass

RE: What was the reason for 2.6.22 SMP kernels to change how sendmsg is called?

2007-12-13 Thread Kevin Wilson
I see your point but it just so happens it is a GPL'd driver, as is all of our Linux code we produce for our hardware. Granted it is out of tree, and after you saw it you would want it to stay that way. However, I would have sent you the whole thing if that is a pre-req to cordial exchanges on t

Re: [RFC] net: napi fix

2007-12-13 Thread Jarek Poplawski
Stephen Hemminger wrote, On 12/13/2007 09:41 PM: > David Miller wrote: >> From: Jarek Poplawski <[EMAIL PROTECTED]> >> Date: Thu, 13 Dec 2007 21:16:12 +0100 >> >> >>> I see in a nearby thread you would prefer to save some work to drivers >>> (like this netif_running() check), but I think this a

Re: [RFC] mac80211: clean up frame receive handling

2007-12-13 Thread John W. Linville
On Wed, Dec 12, 2007 at 07:24:04PM +0100, Johannes Berg wrote: > @@ -1014,6 +992,24 @@ ieee80211_drop_unencrypted(struct ieee80 > return 0; > } > > +static bool ieee80211_frame_allowed(struct ieee80211_txrx_data *rx) > +{ > + static const u8 pae_group_addr[ETH_ALEN] > + =

Re: What was the reason for 2.6.22 SMP kernels to change how sendmsg is called?

2007-12-13 Thread David Miller
From: "Kevin Wilson" <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 14:54:31 -0600 > The 2nd method fixes the kernel oops I reported. Thanks to all those > that assisted me (0) with my first post to this list (see below) > ... uh, oh yeah, did I mention that number would tally up to ZERO > people. ;-}

What was the reason for 2.6.22 SMP kernels to change how sendmsg is called?

2007-12-13 Thread Kevin Wilson
In SMP kernels 2.6.21 and prior you could use a SOCK's sendmsg() call via the PROTO structure directly. e.g., sock->sk_prot->sendmsg(). Now in 2.6.22 and later kernels you must use the higher level SOCKET to make a call to PROTO_OPS then to sendmsg(). e.g., socket->ops->sendmsg(). Would someone

Re: [3/4] DST: Network state machine.

2007-12-13 Thread Dmitry Monakhov
On 14:47 Mon 10 Dec , Evgeniy Polyakov wrote: > > Network state machine. > > Includes network async processing state machine and related tasks. Hi, I've tried to play a little bit with DST and discover huge memory leak. Every read request from remote node result in bio + bio's pages leak. Da

Re: [RFC] net: napi fix

2007-12-13 Thread Stephen Hemminger
David Miller wrote: From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 21:16:12 +0100 I see in a nearby thread you would prefer to save some work to drivers (like this netif_running() check), but I think this all is at the cost of flexibility, and there will probably appear new

Re: [RFC] net: napi fix

2007-12-13 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 11:35:07 -0800 > How about allowing a return value of -1 from napi_poll and letting > device check itself. It doesn't avoid the code duplication in the ->poll() fast paths. I don't care, on the other hand, if crap accumulates in

Re: [RFC] net: napi fix

2007-12-13 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 21:16:12 +0100 > I see in a nearby thread you would prefer to save some work to drivers > (like this netif_running() check), but I think this all is at the cost > of flexibility, and there will probably appear new problems, when a >

Re: [RFC] net: napi fix

2007-12-13 Thread Jarek Poplawski
David Miller wrote, On 12/13/2007 02:50 PM: > From: Jarek Poplawski <[EMAIL PROTECTED]> > Date: Thu, 13 Dec 2007 14:49:53 +0100 > >> As a matter of fact, since it's "unlikely()" in net_rx_action() anyway, >> I wonder what is the main reason or gain of leaving such a tricky >> exception, instead o

Re: 2.6.24-rc5-mm1 regression - kernel warning on tcp_fastretrans_alert()

2007-12-13 Thread Andrew Morton
On Thu, 13 Dec 2007 20:26:21 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > Hi Andrew, Hi. Please do try to cc netdev@vger.kernel.org on net-related problems. Doing so will often save multiple hours latency and will optimise away one entire email (ie: this one). > Following call trace is

Re: [RFC] net: napi fix

2007-12-13 Thread Stephen Hemminger
David Miller wrote: From: Andrew Gallatin <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 14:02:25 -0500 Or perhaps we should just leave things as is. We should probably add a "disabling" state bit to the napi struct flags, this will be set by napi_disable() before it loops trying to set t

[PATCH] [RFC] New driver "sfc" for Solarstorm SFC4000 controller - 2nd try

2007-12-13 Thread Robert Stonehouse
This is a resubmission of a new driver for Solarflare network controllers. The driver supports many types of PHY (10Gbase-T, XFP, CX4) on five different 10G reference designs and one 1G NIC ref design. The previous thread was: "[PATCH] [RFC] New driver "sfc" for Solarstorm SFC4000 controller"

Re: reading the tcp headers within the write queue

2007-12-13 Thread David Miller
From: Gavin McCullagh <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 19:08:59 + > Thought that might be it. I presume there isn't any other residue of the > tcp options elsewhere, that one could look at when the packet gets > acknowledged? I'm particularly interested in the timestamp. Every time

Re: [RFC] net: napi fix

2007-12-13 Thread Andrew Gallatin
Stephen Hemminger wrote: On Thu, 13 Dec 2007 06:19:38 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: From: Andrew Gallatin <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 09:13:54 -0500 If the netif_running() check is indeed required to make a device break out of napi polling and respond to a

Re: reading the tcp headers within the write queue

2007-12-13 Thread Gavin McCullagh
Hi, thanks for the swift reply. On Thu, 13 Dec 2007, David Miller wrote: > > I'm trying to hack together something which will run through the > > retransmit queue looking at the tcp headers. > > The packets in the retransmit queue are headerless, the > header only gets added to clones of the re

Re: [RFC] net: napi fix

2007-12-13 Thread David Miller
From: Andrew Gallatin <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 14:02:25 -0500 > Or perhaps we should just leave things as is. We should probably add a "disabling" state bit to the napi struct flags, this will be set by napi_disable() before it loops trying to set the sched bit. net_rx_action()

Re: reading the tcp headers within the write queue

2007-12-13 Thread David Miller
From: Gavin McCullagh <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 18:56:26 + > I'm trying to hack together something which will run through the > retransmit queue looking at the tcp headers. The packets in the retransmit queue are headerless, the header only gets added to clones of the retrans

Re: [kvm-devel] [PATCH resent] virtio_net: Fix stalled inbound trafficon early packets

2007-12-13 Thread Christian Borntraeger
Am Donnerstag, 13. Dezember 2007 schrieb Dor Laor: > You're right I got confused somehow. > So in that case setting the driver status field on open in addition to > your enable will do the trick. > On DRIVER_OPEN the host will trigger an interrupt if the queue is not > empty.. > Thanks, > Dor Af

Re: [RFC] net: napi fix

2007-12-13 Thread Stephen Hemminger
On Thu, 13 Dec 2007 06:19:38 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Andrew Gallatin <[EMAIL PROTECTED]> > Date: Thu, 13 Dec 2007 09:13:54 -0500 > > > If the netif_running() check is indeed required to make a device break > > out of napi polling and respond to an ifconfig down

Re: 2.6.24-rc5-mm1

2007-12-13 Thread Adrian Bunk
On Thu, Dec 13, 2007 at 05:07:44PM +0100, Borislav Petkov wrote: > On Thu, Dec 13, 2007 at 04:01:34PM +0100, Benjamin Thery wrote: > > The problem comes from the new macro UDPX_INC_STATS_BH introduced > > by Herbert, which was a nice addition to increment the correct > > UDP MIB depending on the s

Re: [PATCH 2.6.25] [IPV4] Thresholds in fib_trie.c are used as consts, so make them const.

2007-12-13 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 11:06:18 +0300 > [IPV4] Thresholds in fib_trie.c are used as consts, so make them const. > > There are several thresholds for trie fib hash management. They are used > in the code as a constants. Make them constants from the compil

Re: [patch 2/2] ipv6/sit: Rebinding of SIT tunnels to other interfaces

2007-12-13 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 13 Dec 2007 14:37:50 +0100 > This is similar to the change already done for IPIP tunnels. > > Once created, a SIT tunnel can't be bound to another device. > To reproduce: > > # create a tunnel: > ip tunnel add tunneltest0 mode sit remote 10.0.0.1 dev eth0 > # t

Re: [patch 1/2] ip_gre: Rebinding of GRE tunnels to other interfaces

2007-12-13 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 13 Dec 2007 14:37:49 +0100 > This is similar to the change already done for IPIP tunnels. > > Once created, a GRE tunnel can't be bound to another device. > To reproduce: > > # create a tunnel: > ip tunnel add tunneltest0 mode gre remote 10.0.0.1 dev eth0 > # t

Re: 2.6.24-rc5-mm1

2007-12-13 Thread David Miller
From: Benjamin Thery <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 16:01:34 +0100 > The problem comes from the new macro UDPX_INC_STATS_BH introduced > by Herbert, which was a nice addition to increment the correct > UDP MIB depending on the socket family, but unfortunately > the use of this macro

Re: [PATCH 2.6.25] [IPV6] Always pass a valid nl_info to inet6_rt_notify.

2007-12-13 Thread David Miller
From: "Denis V. Lunev" <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 16:58:54 +0300 > [IPV6] Always pass a valid nl_info to inet6_rt_notify. > > This makes the code in the inet6_rt_notify more straightforward and provides > groud for namespace passing. > > Signed-off-by: Denis V. Lunev <[EMAIL PROT

Re: [PATCHES 0/12]: DCCP patches for 2.6.25

2007-12-13 Thread David Miller
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Thu, 13 Dec 2007 13:05:53 -0200 > Please consider pulling from: > > master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25 Looks good, pulled and pushed back out to net-2.6.25 Thanks! -- To unsubscribe from this list: send the

Re: 2.6.24-rc4-mm1 - BUG in tcp_fragment

2007-12-13 Thread Cedric Le Goater
Andrew Morton wrote: > Temporarily at > > http://userweb.kernel.org/~akpm/2.6.24-rc4-mm1/ > > Will appear later at > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc4/2.6.24-rc4-mm1/ I got this one while compiling on NFS. C. kernel BUG at /home/legoater/linux/2

tcp_sacktag_one() WARNING (was Re: 2.6.24-rc4-mm1)

2007-12-13 Thread Cedric Le Goater
Cedric Le Goater wrote: > Ilpo Järvinen wrote: >> On Wed, 5 Dec 2007, Andrew Morton wrote: >> >>> On Thu, 06 Dec 2007 17:59:37 +1100 Reuben Farrelly <[EMAIL PROTECTED]> >>> wrote: >>> This non fatal oops which I have just noticed may be related to this change then - certainly look

[PATCH 1/2] tulip: napi full quantum bug

2007-12-13 Thread Stephen Hemminger
This should fix the kernel warn/oops reported while routing. The tulip driver has a fencepost bug with new NAPI in 2.6.24 It has an off by one bug if a full quantum is reached. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/drivers/net/tulip/interrupt.c 2007-12-13 09:20:27.0

[PATCH 2/2] tulip: hardware mitigation simplify

2007-12-13 Thread Stephen Hemminger
The hardware mitigation in tulip can be simpified. 1. The budget with new NAPI will always be less than RX_RING_SIZE because RX_RING_SIZE is 128 and weight is 16. 2. The received counter is redundunt, just use the work_done value. 3. Only one value is used from the mit_table[] Signed-off-by: St

[PATCH] e1000: remove no longer used code for pci read/write cfg

2007-12-13 Thread Auke Kok
From: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_hw.h |2 -- drivers/net/e1000/e1000_main.c | 16 2 files changed, 0 insertions(+), 18 deletions(-) diff --git a/d

Re: [IPSEC]: Fix zero return value in xfrm_lookup on error

2007-12-13 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 14 Dec 2007 00:44:48 +0800 > [IPSEC]: Fix zero return value in xfrm_lookup on error > > Further testing shows that my ICMP relookup patch can cause xfrm_lookup > to return zero on error which isn't very nice since it leads to the caller > dying on n

Re: kernel 2.6.23.8: KERNEL: assertion in net/ipv4/tcp_input.c

2007-12-13 Thread Wolfgang Walter
Hello Ilpo, it happened again with your patch applied: WARNING: at net/ipv4/tcp_input.c:1018 tcp_sacktag_write_queue() Call Trace: [] tcp_sacktag_write_queue+0x7d0/0xa60 [] add_partial+0x19/0x60 [] tcp_ack+0x5a4/0x1d70 [] tcp_rcv_established+0x485/0x7b0 [] tcp_v4_do_rcv+0xed/0x3e0 [] tcp_v4_rc

Re: [RFC] net: napi fix

2007-12-13 Thread Kok, Auke
David Miller wrote: > From: Andrew Gallatin <[EMAIL PROTECTED]> > Date: Thu, 13 Dec 2007 09:13:54 -0500 > >> If the netif_running() check is indeed required to make a device break >> out of napi polling and respond to an ifconfig down, then I think the >> netif_running() check should be moved up i

[IPSEC]: Fix zero return value in xfrm_lookup on error

2007-12-13 Thread Herbert Xu
Hi Dave: Found another silly bug in my ICMP relookup patch. [IPSEC]: Fix zero return value in xfrm_lookup on error Further testing shows that my ICMP relookup patch can cause xfrm_lookup to return zero on error which isn't very nice since it leads to the caller dying on null pointer dereference.

Re: 2.6.24-rc5-mm1

2007-12-13 Thread Borislav Petkov
On Thu, Dec 13, 2007 at 04:01:34PM +0100, Benjamin Thery wrote: > The problem comes from the new macro UDPX_INC_STATS_BH introduced > by Herbert, which was a nice addition to increment the correct > UDP MIB depending on the socket family, but unfortunately > the use of this macro from kernel code

Re: [Devel] [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h.

2007-12-13 Thread Alexey Dobriyan
On Thu, Dec 13, 2007 at 05:18:42PM +0300, Denis V. Lunev wrote: > There are to many spaces between type and function name in the declaration > of fib rules manipulation routines. Eat them and save a couple of lines. If this patch is going in, it would be nice to get rid of "extern" as well.

[PATCH 10/12] [DCCP]: Remove unused and redundant validation functions

2007-12-13 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker <[EMAIL PROTECTED]> This removes two inlines which were both called in a single function only: 1) dccp_feat_change() is always called with either DCCPO_CHANGE_L or DCCPO_CHANGE_R as argument * from dccp_set_socktopt_change() via do_dccp_setsockopt() with DCCP_SOCKOPT_CH

[PATCH 12/12] [DCCP]: Ignore feature negotiation on Data packets

2007-12-13 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker <[EMAIL PROTECTED]> This implements [RFC 4340, p. 32]: "any feature negotiation options received on DCCP-Data packets MUST be ignored". Also added a FIXME for further processing, since the code currently (wrongly) classifies empty Confirm options as invalid - this needs to be

[PATCH 08/12] [DCCP]: Handle timestamps on Request/Response exchange separately

2007-12-13 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker <[EMAIL PROTECTED]> In DCCP, timestamps can occur on packets anytime, CCID3 uses a timestamp(/echo) on the Request/Response exchange. This patch addresses the following situation: * timestamps are recorded on the listening socket; * Responses are sent from dccp

[PATCH 11/12] [DCCP]: Make code assumptions explicit

2007-12-13 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker <[EMAIL PROTECTED]> This removes several `XXX' references which indicate a missing support for non-1-byte feature values: this is unnecessary, as all currently known (standardised) SP feature values are 1-byte quantities. Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]> Signed

[PATCH 09/12] [DCCP]: Support inserting options during the 3-way handshake

2007-12-13 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker <[EMAIL PROTECTED]> This provides a separate routine to insert options during the initial handshake. The main purpose is to conduct feature negotiation, for the moment the only user is the timestamp echo needed for the (CCID3) handshake RTT sample. Padding of options has been

[PATCH 07/12] [DCCP]: Add (missing) option parsing to request_sock processing

2007-12-13 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker <[EMAIL PROTECTED]> This adds option-parsing code to processing of Acks in the listening state on request_socks on the server, serving two purposes (i) resolves a FIXME (removed); (ii) paves the way for feature-negotiation during connection-setup. There is an intended subtl

[PATCH 06/12] [DCCP]: Allow to parse options on Request Sockets

2007-12-13 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker <[EMAIL PROTECTED]> The option parsing code currently only parses on full sk's. This causes a problem for options sent during the initial handshake (in particular timestamps and feature-negotiation options). Therefore, this patch extends the option parsing code with an addit

[PATCHES 0/12]: DCCP patches for 2.6.25

2007-12-13 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25 Best Regards, - Arnaldo Documentation/networking/dccp.txt |6 + include/linux/dccp.h | 24 ++- net/dccp/dccp.h | 10 ++- net/dccp/feat.c

[PATCH 02/12] [DCCP]: Shift the retransmit timer for active-close into output.c

2007-12-13 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker <[EMAIL PROTECTED]> When performing active close, RFC 4340, 8.3. requires to retransmit the Close/CloseReq with a backoff-retransmit timer starting at intially 2 RTTs. This patch shifts the existing code for active-close retransmit timer into output.c, so that the retransmit t

[PATCH 05/12] [DCCP]: Collapse repeated `len' statements into one

2007-12-13 Thread Arnaldo Carvalho de Melo
From: Gerrit Renker <[EMAIL PROTECTED]> This replaces 4 individual assignments for `len' with a single one, placed where the control flow of those 4 leads to. Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]> Signed-off-by: Ian McDonald <[EMAIL PROTECTED]> Signed-off-by: Arnaldo Carvalho de Melo <

  1   2   >