Re: [PATCH 3/3] Fix use of skb after netif_rx

2007-12-09 Thread Wang Chen
Julia Lawall said the following on 2007-12-10 15:18: >> Julia, seems that your semantic patch misses following place. >> >> drivers/s390/net/qeth_main.c:2733 >> ... >> #endif >> rxrc = netif_rx(skb); >> card->dev->last_rx = jiffies; >> card->stats.rx_p

Re: all is not right with the world...

2007-12-09 Thread David Miller
From: David Stevens <[EMAIL PROTECTED]> Date: Sun, 9 Dec 2007 16:19:12 -0800 > I don't know if you've fixed it already, but I was writing some > UDPv6 tests in 2.6.23.9 and was getting EDESTADDRREQ unexpectedly. When > I looked at the kernel code, I found: > > gerrit/wscott 1.115

Re: IPsec replay sequence number overflow behavior? (RFC4303 section 3.3.3)

2007-12-09 Thread Herbert Xu
On Mon, Dec 10, 2007 at 04:16:36AM +0100, Patrick McHardy wrote: > > Won't this break with manually installed SAs (without a keying > daemon)? Well what's being suggested here will already break that anyway :) Alternatively we can take the interpretation that it's the KM's responsibility to set t

Re: IPsec replay sequence number overflow behavior? (RFC4303 section 3.3.3)

2007-12-09 Thread Patrick McHardy
Herbert Xu wrote: On Sun, Dec 09, 2007 at 09:37:56AM -0500, Paul Moore wrote: Thanks for clearing that up, I'll send a patch this week; complete with an unlikely (similar to the RFC quality IPsec audit patch I sent on Friday) and a decrement to the sequence counter in case of rollover.

Re: IPsec replay sequence number overflow behavior? (RFC4303 section 3.3.3)

2007-12-09 Thread Herbert Xu
On Sun, Dec 09, 2007 at 09:37:56AM -0500, Paul Moore wrote: > > Thanks for clearing that up, I'll send a patch this week; complete with an > unlikely (similar to the RFC quality IPsec audit patch I sent on Friday) and > a decrement to the sequence counter in case of rollover. Actually I think we

Re: all is not right with the world...

2007-12-09 Thread David Stevens
Never mind... Though I hate the "TCP" in the name (maybe overload UDP_CONNECTED?), I see datagram sockets are in fact setting it, and my EDESTADDRREQ was a bug in my test program. :-) +-DLS [EMAIL PROTECTED] wrote on 12/09/2007 04:19:12 PM: >

all is not right with the world...

2007-12-09 Thread David Stevens
I don't know if you've fixed it already, but I was writing some UDPv6 tests in 2.6.23.9 and was getting EDESTADDRREQ unexpectedly. When I looked at the kernel code, I found: gerrit/wscott 1.115 | int udpv6_sendmsg(struct kiocb *iocb, struct sock *sk, shemminger1.57

Re: SIS190 Ethernet Driver check for ISA bridge on "SiS968" MotherBoards...

2007-12-09 Thread Francois Romieu
Arliton Rocha <[EMAIL PROTECTED]> : [...] > Please, can you made sis190 ethernet driver check for isa bridge on > "sis968" motherboards? > SiS(R) 191 Gigabit Ethernet > > Similar > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=8eb7ad68bd10d858066ca51713ca5645996e77a5

Re: tcp assertion failures in 2.6.24-rc4-mm1

2007-12-09 Thread Ilpo Järvinen
On Sun, 9 Dec 2007, Andrew Morton wrote: > > This is a mac g5. It is being used as a distcc server across the LAN > when... > > windfarm: CPUs control loops started. > EXT3-fs: INFO: recovery required on readonly filesystem. > EXT3-fs: write access will be enabled during recovery. > kjournald s

[PATCH 3/3][BNX2]: Update version to 1.6.9.

2007-12-09 Thread Michael Chan
[BNX2]: Update version to 1.6.9. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index f9eea6e..4e7b46e 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -56,8 +56,8 @@ #define DRV_MODULE_NAME"bnx2" #define PFX DRV

[PATCH 2/3][BNX2]: Fix RX packet rot.

2007-12-09 Thread Michael Chan
[BNX2]: Fix RX packet rot. Packets can be left in the RX ring if the NAPI budget is reached. This is caused by storing the latest rx index at the beginning of bnx2_rx_int(). We may not process all the work up to this index if the budget is reached and so some packets in the RX ring may rot when w

[PATCH 1/3][BNX2]: Add PHY_DIS_EARLY_DAC workaround.

2007-12-09 Thread Michael Chan
[BNX2]: Add PHY_DIS_EARLY_DAC workaround. 5709 Ax and Bx chips all need this workaround. Signed-off-by: Michael Chan <[EMAIL PROTECTED]> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index da767d3..a4f3832 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -6685,8 +6685,9 @@ bnx2

Re: [PATCH] iproute2: support dotted-quad netmask notation.

2007-12-09 Thread Andreas Henriksson
On lör, 2007-12-08 at 00:41 +0100, Andreas Henriksson wrote: > On tor, 2007-12-06 at 11:53 -0800, Stephen Hemminger wrote: > > On Tue, 4 Dec 2007 14:58:18 +0100 > > Andreas Henriksson <[EMAIL PROTECTED]> wrote: > > > > > Suggested patch for allowing netmask to be specified in dotted quad > > > f

Re: [PATCH net-2.6.25] Add packet filtering based on process'ssecurity context.

2007-12-09 Thread Samir Bellabes
Tetsuo Handa <[EMAIL PROTECTED]> writes: > Hello, Samir. > > Did you receive the following messages? > Since these messages were dropped at vger.kernel.org , > I'm worrying that you couldn't receive the following messages. Yes, I got it. I will take time to investigate your example. -- To unsubsc

Re: IPsec replay sequence number overflow behavior? (RFC4303 section 3.3.3)

2007-12-09 Thread Paul Moore
On Saturday 08 December 2007 9:13:48 pm Herbert Xu wrote: > Paul Moore <[EMAIL PROTECTED]> wrote: > > If it is a bug, I think the basic fix should be pretty simple, changing > > the above xfrm_output() code to the following: > > > > if (x->type->flags & XFRM_TYPE_REPLAY_PROT) { > > XFRM

[RFC] Connection Oriented Routing Protocol

2007-12-09 Thread Michael Blizek
Hi! I'm programming a new layer 3+4 protocol. It does not have a routing table for every destination. Instead the end node established a connection through every router to the destination. This allows some pretty interesting optimisations. See http://michaelblizek.homelinux.net/projects/cor/index

Re: Bogus commit 70eba18b ("make bnx2x select ZLIB_INFLATE")?

2007-12-09 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Sat, 08 Dec 2007 19:07:22 -0800 > Commit 70eba18b ("make bnx2x select ZLIB_INFLATE") in Linus's tree > seems bogus. As far as I can tell, bnx2x is not upstream yet, and the > commit in question actually adds "select ZLIB_INFLATE" to the TEHUTI > confi

Re: [PATCHES 0/3]: DCCP patches for 2.6.25

2007-12-09 Thread David Miller
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Sat, 8 Dec 2007 16:52:10 -0200 > Hi David, > > Please consider pulling from: > > master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25 Pulled, thanks a lot. -- To unsubscribe from this list: send the line "unsubscribe netdev"

Re: [PATCH][NET]: Finish removing unused "mibalign" argument for snmp_mib_init().

2007-12-09 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Sat, 08 Dec 2007 10:13:54 -0800 (PST) > Hello. > > In article <[EMAIL PROTECTED]> (at Sat, 8 Dec 2007 15:55:34 -0200), Arnaldo > Carvalho de Melo <[EMAIL PROTECTED]> says: > > > Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>

tcp assertion failures in 2.6.24-rc4-mm1

2007-12-09 Thread Andrew Morton
This is a mac g5. It is being used as a distcc server across the LAN when... windfarm: CPUs control loops started. EXT3-fs: INFO: recovery required on readonly filesystem. EXT3-fs: write access will be enabled during recovery. kjournald starting. Commit interval 5 seconds EXT3-fs: recovery comp

Re: [PATCH net-2.6.25] Add packet filtering based on process'ssecurity context.

2007-12-09 Thread Tetsuo Handa
Hello, Samir. Did you receive the following messages? Since these messages were dropped at vger.kernel.org , I'm worrying that you couldn't receive the following messages. Tetsuo Handa wrote: > Hello. > > Samir Bellabes wrote: > > >> what differences between you approach and netfilter in this c