Re: [PATCH] [IPv4] Reply net unreachable ICMP message

2007-12-05 Thread Jarek Poplawski
On 06-12-2007 07:31, Mitsuru Chinen wrote: > IPv4 stack doesn't reply any ICMP destination unreachable message > with net unreachable code when IP detagrams are being discarded > because of no route could be found in the forwarding path. > Incidentally, IPv6 stack replies such ICMPv6 message in the

Re: 2.6.24-rc4-mm1

2007-12-05 Thread Andrew Morton
On Thu, 06 Dec 2007 17:59:37 +1100 Reuben Farrelly <[EMAIL PROTECTED]> wrote: > On 5/12/2007 4:17 PM, Andrew Morton wrote: > > Temporarily at > > > > http://userweb.kernel.org/~akpm/2.6.24-rc4-mm1/ > > > > Will appear later at > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/p

Re: 2.6.24-rc4-mm1

2007-12-05 Thread David Miller
From: Reuben Farrelly <[EMAIL PROTECTED]> Date: Thu, 06 Dec 2007 17:59:37 +1100 > On 5/12/2007 4:17 PM, Andrew Morton wrote: > > - Lots of device IDs have been removed from the e1000 driver and moved over > > to e1000e. So if your e1000 stops working, you forgot to set > > CONFIG_E1000E. > >

Re: 2.6.24-rc4-mm1

2007-12-05 Thread Reuben Farrelly
On 5/12/2007 4:17 PM, Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.24-rc4-mm1/ Will appear later at ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc4/2.6.24-rc4-mm1/ - Lots of device IDs have been removed from the e1000 driver and moved

Re: [PATCH] [IPv4] Reply net unreachable ICMP message

2007-12-05 Thread David Miller
From: Mitsuru Chinen <[EMAIL PROTECTED]> Date: Thu, 6 Dec 2007 15:31:05 +0900 > IPv4 stack doesn't reply any ICMP destination unreachable message > with net unreachable code when IP detagrams are being discarded > because of no route could be found in the forwarding path. > Incidentally, IPv6 stac

Re: [PATCH] [IPv6] SNMP: Increment OutNoRoutes when connecting to unreachable network

2007-12-05 Thread David Miller
From: Mitsuru Chinen <[EMAIL PROTECTED]> Date: Thu, 6 Dec 2007 15:29:48 +0900 > IPv6 stack doesn't increment OutNoRoutes counter when IP datagrams > is being discarded because no route could be found to transmit them > to their destination. IPv6 stack should increment the counter. > Incidentally,

[PATCH] [IPv4] Reply net unreachable ICMP message

2007-12-05 Thread Mitsuru Chinen
IPv4 stack doesn't reply any ICMP destination unreachable message with net unreachable code when IP detagrams are being discarded because of no route could be found in the forwarding path. Incidentally, IPv6 stack replies such ICMPv6 message in the similar situation. Signed-off-by: Mitsuru Chinen

[PATCH] [IPv6] SNMP: Increment OutNoRoutes when connecting to unreachable network

2007-12-05 Thread Mitsuru Chinen
IPv6 stack doesn't increment OutNoRoutes counter when IP datagrams is being discarded because no route could be found to transmit them to their destination. IPv6 stack should increment the counter. Incidentally, IPv4 stack increments that counter in such situation. Signed-off-by: Mitsuru Chinen <[

[PATCH] fix br_fdb_fini() section mismatch

2007-12-05 Thread Harald Welte
When compiling a kernel (current linus git or 2.6.24-rc4) with built-in CONFIG_BRIDGE, I get the following error: LD .tmp_vmlinux1 `br_fdb_fini' referenced in section `.init.text' of net/built-in.o: defined in discarded section `.exit.text' of net/built-in.o make: *** [.tmp_vmlinux1] Error

Re: [BRIDGE] warning message when add an interface to bridge

2007-12-05 Thread Eric W. Biederman
Stephen Hemminger <[EMAIL PROTECTED]> writes: > On Wed, 5 Dec 2007 10:44:17 +0800 > "Chung-Chi Lo" <[EMAIL PROTECTED]> wrote: > >> My kernel is Linxu 2.6.22.1. SYSFS is off. >> When adding an interface to bridge, console will show WARNING message. >> If turn SYSFS to on, then the WARNING message i

Re: [PATCH net-2.6.25 10/11][INET] Eliminate difference in actions of sysctl and proc handler for conf.all.forwarding

2007-12-05 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 06 Dec 2007 11:13:39 +1100 > David Miller <[EMAIL PROTECTED]> wrote: > > > > The user is pretty much screwed in one way or the other. > > For example: > > > > 1) If 'default' propagates to all devices, any specific > > setting for a device is lost

Re: [PATCH] fix br_fdb_fini() section mismatch

2007-12-05 Thread David Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Thu, 6 Dec 2007 10:56:58 +0530 > When compiling a kernel (current linus git or 2.6.24-rc4) with built-in > CONFIG_BRIDGE, I get the following error: > > LD .tmp_vmlinux1 > `br_fdb_fini' referenced in section `.init.text' of net/built-in.o: defin

Re: [PATCH] [TCP]: Make invariant check complain about invalid sacked_out

2007-12-05 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Wed, 5 Dec 2007 21:36:37 +0200 (EET) > On Wed, 5 Dec 2007, Ilpo Järvinen wrote: > > > > > Earlier resolution for NewReno's sacked_out should now keep > > it small enough for this to become invariant-like check. > > > > Signed-off-by: Ilpo Järvinen

Re: [PATCH net-2.6.25 3/3][ARP] Consolidate some code in arp_req_set/delete_publc

2007-12-05 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Wed, 05 Dec 2007 20:18:44 +0300 > The PROXY_ARP is set on devconfigs in a similar way in > both calls. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Also applied, thanks a lot. -- To unsubscribe from this list: send the line "unsubscribe n

Re: [PATCH net-2.6.25 2/3][ARP] Minus one level of ndentation in arp_req_delete

2007-12-05 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Wed, 05 Dec 2007 20:16:48 +0300 > The same cleanup for deletion requests. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTEC

Re: [PATCH net-2.6.25 1/3][ARP] Minus one level of indentation in arp_req_set

2007-12-05 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Wed, 05 Dec 2007 20:15:02 +0300 > The ATF_PUBL requests are handled completely separate from > the others. Emphasize it with a separate function. This also > reduces the indentation level. > > The same issue exists with the arp_delete_request, but >

Re: [PATCH net-2.6.25 2/3][ROUTE] Clean up proc files creation

2007-12-05 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Wed, 05 Dec 2007 20:06:39 +0300 > The rt_cache, stats/rt_cache and rt_acct(optional) files > creation looks a bit messy. Clean this out and join them > to other proc-related functions under the proper ifdef. > > The struct net * argument in a new fu

Re: [PATCH net-2.6.25 3/3][ROUTE] Convert rt_hash_lock_init() macro into function

2007-12-05 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Wed, 05 Dec 2007 20:09:27 +0300 > There's no need in having this function exist in a form > of macro. Properly formatted function looks much better. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Also applied, thanks. -- To unsubscribe from

Re: [PATCH net-2.6.25 1/3][ROUTE] Collect proc-related functions together

2007-12-05 Thread David Miller
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Wed, 05 Dec 2007 20:04:16 +0300 > The net/ipv4/route.c file declares some entries for proc > to dump some routing info. The reading functions are > scattered over this file - collect them together. > > Besides, remove a useless IP_RT_ACCT_CPU macro

Re: TCP event tracking via netlink...

2007-12-05 Thread David Miller
From: Evgeniy Polyakov <[EMAIL PROTECTED]> Date: Wed, 5 Dec 2007 17:48:43 +0300 > On Wed, Dec 05, 2007 at 09:11:01AM -0500, John Heffner ([EMAIL PROTECTED]) > wrote: > > >Maybe if we want to get really fancy we can have some more-expensive > > >debug mode where detailed specific events get genera

Re: TCP event tracking via netlink...

2007-12-05 Thread David Miller
From: John Heffner <[EMAIL PROTECTED]> Date: Wed, 05 Dec 2007 09:11:01 -0500 > FWIW, sounds similar to what these guys are doing with SIFTR for FreeBSD: > http://caia.swin.edu.au/urp/newtcp/tools.html > http://caia.swin.edu.au/reports/070824A/CAIA-TR-070824A.pdf Yes, my proposal is very similar t

[PATCH 2.6.24 1/1]S2io: Check for register initialization completion before accesing device registers

2007-12-05 Thread Sreenivasa Honnur
- Making sure register initialisation is complete before proceeding further. The driver must wait until initialization is complete before attempting to access any other device registers. Signed-off-by: Surjit Reang <[EMAIL PROTECTED]> Signed-off-by: Sreenivasa Honnur <[EMAIL PROTECTED]> --- d

Re: [PATCH net-2.6 0/3]: Three TCP fixes

2007-12-05 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Wed, 5 Dec 2007 13:30:32 +0200 (EET) > On Wed, 5 Dec 2007, David Miller wrote: > > > Anyways, someone please enlighten me and please also cook > > up a patch to add the descriptive comment :-) > > Not sure if a too simple patch here is correct thin

Re: [PATCH 4/4] udp: memory accounting in IPv4

2007-12-05 Thread Hideo AOKI
Herbert Xu wrote: > On Mon, Dec 03, 2007 at 07:14:26PM -0500, Hideo AOKI wrote: >> Let me try to use sk_forward_alloc at first, while percpu storage >> is an interesting idea. > > Actually I don't think sk_forward_alloc would work for UDP because > it runs lockless (unlike TCP which is run under a

Re: TCP event tracking via netlink...

2007-12-05 Thread Stephen Hemminger
On Thu, 6 Dec 2007 00:15:49 +0200 (EET) "Ilpo Järvinen" <[EMAIL PROTECTED]> wrote: > On Wed, 5 Dec 2007, Stephen Hemminger wrote: > > > On Wed, 05 Dec 2007 08:53:07 -0800 > > Joe Perches <[EMAIL PROTECTED]> wrote: > > > > > > it occurred to me that we might want to do something > > > > like a st

Re: [BRIDGE] warning message when add an interface to bridge

2007-12-05 Thread Stephen Hemminger
On Wed, 5 Dec 2007 10:44:17 +0800 "Chung-Chi Lo" <[EMAIL PROTECTED]> wrote: > My kernel is Linxu 2.6.22.1. SYSFS is off. > When adding an interface to bridge, console will show WARNING message. > If turn SYSFS to on, then the WARNING message is gone. > Any suggestion how to debug this problem? Tha

Re: [PATCH] sky2: RX lockup fix

2007-12-05 Thread Stephen Hemminger
On Wed, 05 Dec 2007 18:18:46 -0600 Peter Tyser <[EMAIL PROTECTED]> wrote: > On Wed, 2007-12-05 at 16:40 -0500, Stephen Hemminger wrote: > > > I looked over Marvell's most recent sk98lin driver and it looks like > > > they had a "workaround" for the Yukon XL that the sky2 doesn't have yet. > > > Th

[patch-RFC 6/7] LTTng instrumentation net

2007-12-05 Thread Mathieu Desnoyers
Network core events. Signed-off-by: Mathieu Desnoyers <[EMAIL PROTECTED]> CC: netdev@vger.kernel.org --- net/core/dev.c |5 + net/ipv4/devinet.c |5 + net/socket.c | 18 ++ 3 files changed, 28 insertions(+) Index: linux-2.6-lttng/net/core/dev.c ===

Re: sockets affected by IPsec always block (2.6.23)

2007-12-05 Thread David Miller
From: Stefan Rompf <[EMAIL PROTECTED]> Date: Wed, 5 Dec 2007 19:39:07 +0100 > I'd strongly suggest doing so. AFAIK, behaviour of connect() on nonblocking > sockets is quite well defined in POSIX. You are entitled to your opinion. POSIX says nothing about the semantics of route resolution. Non-b

Re: Reproducible data corruption with sendfile+vsftp - splice regression?

2007-12-05 Thread Francois Romieu
Francois Romieu <[EMAIL PROTECTED]> : > Holger Hoffstaette <[EMAIL PROTECTED]> : > [...] > > Should I file this in bugzilla? > > Yes. 5326 5585327 5585328 5585329 5585330 5585331 5585332 5585333 5585334 5585335 558 5336 5585337 5585338 5585339 5585340 5585341 5585342 5585343 5589440 5589441 558

Re: [PATCH] sky2: RX lockup fix

2007-12-05 Thread Peter Tyser
On Wed, 2007-12-05 at 16:40 -0500, Stephen Hemminger wrote: > > I looked over Marvell's most recent sk98lin driver and it looks like > > they had a "workaround" for the Yukon XL that the sky2 doesn't have yet. > > The sk98lin driver disables the RX MAC FIFO flush feature for all > > revisions of th

Re: [PATCH net-2.6.25 10/11][INET] Eliminate difference in actions of sysctl and proc handler for conf.all.forwarding

2007-12-05 Thread Herbert Xu
David Miller <[EMAIL PROTECTED]> wrote: > > The user is pretty much screwed in one way or the other. > For example: > > 1) If 'default' propagates to all devices, any specific > setting for a device is lost. > > 2) If 'default' does not propagate, there is no way to > have 'default' influence

Re: bonding sysfs output

2007-12-05 Thread Jean Delvare
Hi Wagner, On Mon, 26 Nov 2007 09:29:40 +0100, Wagner Ferenc wrote: > On the policy side: some files are not applicable to some types of > bonds, and return a single linefeed in that case. Except for one > single case, which returns 'NA\n'. The patch changes these cases into > emtpy files. IMHO

Re: TCP event tracking via netlink...

2007-12-05 Thread Ilpo Järvinen
On Wed, 5 Dec 2007, David Miller wrote: > Ilpo, I was pondering the kind of debugging one does to find > congestion control issues and even SACK bugs and it's currently too > painful because there is no standard way to track state changes. That's definately true. > I assume you're using somethin

Re: Reproducible data corruption with sendfile+vsftp - splice regression?

2007-12-05 Thread Francois Romieu
Holger Hoffstaette <[EMAIL PROTECTED]> : [...] > Should I file this in bugzilla? Yes. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: TCP event tracking via netlink...

2007-12-05 Thread Ilpo Järvinen
On Wed, 5 Dec 2007, Stephen Hemminger wrote: > On Wed, 05 Dec 2007 08:53:07 -0800 > Joe Perches <[EMAIL PROTECTED]> wrote: > > > > it occurred to me that we might want to do something > > > like a state change event generator. > > > > This could be a basis for an interesting TCP > > performance

Re: Pull request for 'ipg' branch

2007-12-05 Thread Francois Romieu
Joe Perches <[EMAIL PROTECTED]> : [...] > > - if ((sp->LED_Mode & 0x01) == 1) > > + if ((sp->led_mode & 0x01) == 1) > > I think the use of hex and decimal constants is odd. > I think "if (sp->led_mode & 0x01)" is better. Yes, the whole context of this code in the driver is a bit special. [..

Re: [PATCH] sky2: RX lockup fix

2007-12-05 Thread Stephen Hemminger
On Wed, 05 Dec 2007 12:51:03 -0600 Peter Tyser <[EMAIL PROTECTED]> wrote: > Hello, > I'm using a Marvell 88E8062 on a custom PPC64 blade and ran into RX > lockups while validating the sky2 driver. The receive MAC FIFO would > become stuck during testing with high traffic. One port of the 88E8062

Re: TCP event tracking via netlink...

2007-12-05 Thread Stephen Hemminger
On Wed, 05 Dec 2007 08:53:07 -0800 Joe Perches <[EMAIL PROTECTED]> wrote: > > it occurred to me that we might want to do something > > like a state change event generator. > > This could be a basis for an interesting TCP > performance tester. That is what tcpprobe does but it isn't detailed enou

[PATCH 2/2] e100: cleanup unneeded math

2007-12-05 Thread Auke Kok
No need to convert to bytes and back - cleanup unneeded code. Adapted from fix from 'Roel Kluin <[EMAIL PROTECTED]>' Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e100.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/e100.c b/drivers/net/

[PATCH 1/2] e1000: fix memcpy in e1000_get_strings

2007-12-05 Thread Auke Kok
From: Roel Kluin <[EMAIL PROTECTED]> drivers/net/e1000/e1000_ethtool.c:113: #define E1000_TEST_LEN sizeof(e1000_gstrings_test) / ETH_GSTRING_LEN drivers/net/e1000e/ethtool.c:106: #define E1000_TEST_LEN sizeof(e1000_gstrings_test) / ETH_GSTRING_LEN E1000_TEST_LEN*ETH_GSTRING_LEN will expand to si

[PATCH] sky2: RX lockup fix

2007-12-05 Thread Peter Tyser
Hello, I'm using a Marvell 88E8062 on a custom PPC64 blade and ran into RX lockups while validating the sky2 driver. The receive MAC FIFO would become stuck during testing with high traffic. One port of the 88E8062 would lockup, while the other port remained functional. Re-inserting the sky2 mod

Re: [PATCH] [TCP]: Make invariant check complain about invalid sacked_out

2007-12-05 Thread Ilpo Järvinen
On Wed, 5 Dec 2007, Ilpo Järvinen wrote: > > Earlier resolution for NewReno's sacked_out should now keep > it small enough for this to become invariant-like check. > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> Forgot to modify it to the subject, this one to net-2.6.25 please. -- i.

[PATCH] [TCP]: Make invariant check complain about invalid sacked_out

2007-12-05 Thread Ilpo Järvinen
Earlier resolution for NewReno's sacked_out should now keep it small enough for this to become invariant-like check. Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- net/ipv4/tcp_input.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/i

Re: sockets affected by IPsec always block (2.6.23)

2007-12-05 Thread Stefan Rompf
Am Mittwoch, 5. Dezember 2007 07:51 schrieb Herbert Xu: > > If he sets this sysctl to "1" as I detailed in my reply, he'll > > get the behavior he wants. > > Does anybody actually need the 0 setting? What would we break if > the default became 1? I'd strongly suggest doing so. AFAIK, behaviour of

Re: sockets affected by IPsec always block (2.6.23)

2007-12-05 Thread Stefan Rompf
Am Mittwoch, 5. Dezember 2007 08:12 schrieb David Miller: > Actually, consider even a case like DNS. Let's say the timeout > is set to 2 seconds or something and you have 3 DNS servers > listed, on different IPSEC destinations, in your resolv.conf > > Each IPSEC route that isn't currently resolve

[PATCH 2/2] cxgb3 - Parity initialization for T3C adapters

2007-12-05 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Add parity initialization for T3C adapters. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h |1 drivers/net/cxgb3/cxgb3_main.c| 82 drivers/net/cxgb3/cxgb3_offload.c | 15 ++ drivers/net/cxgb3/r

[PATCH 1/2] cxgb3 - T3C support update

2007-12-05 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Update GPIO mapping for T3C. Update xgmac for T3C support. Fix typo in mtu table. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/regs.h | 27 ++- drivers/net/cxgb3/t3_hw.c |6 +++--- drivers/net/cxgb3/xgm

[PATCH 0/2] cxgb3 - driver update

2007-12-05 Thread Divy Le Ray
Jeff, I'm submitting a patch series for inclusion in 2.6.25. The patches are built against netdev#upstream. Here is a brief description: - Update GPIO pinning and MAC support for T3C adapters - Enable parity error detection. Cheers, Divy -- To unsubscribe from this list: send the line "unsubsc

Re: cassini driver skb->truesize bug

2007-12-05 Thread KOVACS Krisztian
Hi, On Wed, Dec 05, 2007 at 11:23:46AM +0100, Balazs Scheidler wrote: > Some more investigation revealed that the cassini driver leaks the data > portion of all RXed packets, this makes the driver completely unusable. > > We've tested the following combinations: > * 2.6.17 (patched, but no cassi

[PATCH net-2.6.25 3/3][ARP] Consolidate some code in arp_req_set/delete_publc

2007-12-05 Thread Pavel Emelyanov
The PROXY_ARP is set on devconfigs in a similar way in both calls. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c index 0a3f00c..ccd36fa 100644 --- a/net/ipv4/arp.c +++ b/net/ipv4/arp.c @@ -953,6 +953,19 @@ out_of_mem: * Set (create) an

[PATCH net-2.6.25 2/3][ARP] Minus one level of ndentation in arp_req_delete

2007-12-05 Thread Pavel Emelyanov
The same cleanup for deletion requests. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c index d628e6e..0a3f00c 100644 --- a/net/ipv4/arp.c +++ b/net/ipv4/arp.c @@ -1075,32 +1075,39 @@ static int arp_req_get(struct arpreq *r, struct net_device

[PATCH net-2.6.25 1/3][ARP] Minus one level of indentation in arp_req_set

2007-12-05 Thread Pavel Emelyanov
The ATF_PUBL requests are handled completely separate from the others. Emphasize it with a separate function. This also reduces the indentation level. The same issue exists with the arp_delete_request, but when I tried to make it in one patch diff produced completely unreadable patch. So I split i

[PATCH net-2.6.25 3/3][ROUTE] Convert rt_hash_lock_init() macro into function

2007-12-05 Thread Pavel Emelyanov
There's no need in having this function exist in a form of macro. Properly formatted function looks much better. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 3b9c430..6714bbc 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@

[PATCH net-2.6.25 2/3][ROUTE] Clean up proc files creation

2007-12-05 Thread Pavel Emelyanov
The rt_cache, stats/rt_cache and rt_acct(optional) files creation looks a bit messy. Clean this out and join them to other proc-related functions under the proper ifdef. The struct net * argument in a new function will help net namespaces patches look nicer. Signed-off-by: Pavel Emelyanov <[EMAI

[PATCH net-2.6.25 1/3][ROUTE] Collect proc-related functions together

2007-12-05 Thread Pavel Emelyanov
The net/ipv4/route.c file declares some entries for proc to dump some routing info. The reading functions are scattered over this file - collect them together. Besides, remove a useless IP_RT_ACCT_CPU macro. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/ipv4/route.c b

Re: TCP event tracking via netlink...

2007-12-05 Thread Joe Perches
> it occurred to me that we might want to do something > like a state change event generator. This could be a basis for an interesting TCP performance tester. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH v2 0/3][BUG-FIX]: Test tree updates and bug fixes

2007-12-05 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 05, 2007 at 02:53:09PM +, Gerrit Renker escreveu: > | Thanks, I folded this into the reorganized RX history handling patch, > | together with reverting ccid3_hc_rx_packet_recv to very close to your > | original patch, with this changes: > | > | 1. no need to calculate the payload s

Re: TCP event tracking via netlink...

2007-12-05 Thread Samir Bellabes
Evgeniy Polyakov <[EMAIL PROTECTED]> writes: > Hi. > > On Wed, Dec 05, 2007 at 09:11:01AM -0500, John Heffner ([EMAIL PROTECTED]) > wrote: >> >Maybe if we want to get really fancy we can have some more-expensive >> >debug mode where detailed specific events get generated via some >> >macros we ca

Re: [PATCH v2 0/3][BUG-FIX]: Test tree updates and bug fixes

2007-12-05 Thread Gerrit Renker
| Thanks, I folded this into the reorganized RX history handling patch, | together with reverting ccid3_hc_rx_packet_recv to very close to your | original patch, with this changes: | | 1. no need to calculate the payload size for non data packets as this |value won't be used. | 2. Initialize h

Re: [PATCH] correct typo in __xfrm4_bundle_create()

2007-12-05 Thread David Miller
From: "Ian Brown" <[EMAIL PROTECTED]> Date: Wed, 5 Dec 2007 16:33:56 +0200 > Hello, > Sorry, but I had tried several times from 3 machines (without > iptables/SELinux) and git-clone > gives "Connection refused" error. > > git-clone git://kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.25.git

Re: TCP event tracking via netlink...

2007-12-05 Thread Evgeniy Polyakov
Hi. On Wed, Dec 05, 2007 at 09:11:01AM -0500, John Heffner ([EMAIL PROTECTED]) wrote: > >Maybe if we want to get really fancy we can have some more-expensive > >debug mode where detailed specific events get generated via some > >macros we can scatter all over the place. This won't be useful > >f

Re: [PATCH] correct typo in __xfrm4_bundle_create()

2007-12-05 Thread Ian Brown
Hello, Sorry, but I had tried several times from 3 machines (without iptables/SELinux) and git-clone gives "Connection refused" error. git-clone git://kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.25.git 2.6.25 Initialized empty Git repository in /work/src/2.6.25/.git/ fatal: unable to conne

Re: [PATCH v2 0/3][BUG-FIX]: Test tree updates and bug fixes

2007-12-05 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 05, 2007 at 01:55:11PM +, Gerrit Renker escreveu: > | > @@ -788,8 +782,8 @@ static void ccid3_hc_rx_packet_recv(stru > | > if (unlikely(hcrx->ccid3hcrx_state == TFRC_RSTATE_NO_DATA)) { > | > if (is_data_packet) { > | > do_feedback = FBACK_INITIAL; > | >

Re: [patch resend build-breakage] make bnx2x select ZLIB_INFLATE

2007-12-05 Thread David Miller
From: "Eliezer Tamir" <[EMAIL PROTECTED]> Date: Wed, 05 Dec 2007 16:12:39 +0200 > The bnx2x module depends on the zlib_inflate functions. The > build will fail if ZLIB_INFLATE has not been selected manually > or by building another module that automatically selects it. > > Modify BNX2X config op

Re: [PATCH v2 0/3][BUG-FIX]: Test tree updates and bug fixes

2007-12-05 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 05, 2007 at 11:19:44AM +, Gerrit Renker escreveu: > This revision fixes a bug present in the per-socket allocation of RX history > entries; identification of this bug is thanks to Arnaldo Carvalho de Melo. > > The bug was in not deallocating history entries when the allocation of

[patch resend build-breakage] make bnx2x select ZLIB_INFLATE

2007-12-05 Thread Eliezer Tamir
The bnx2x module depends on the zlib_inflate functions. The build will fail if ZLIB_INFLATE has not been selected manually or by building another module that automatically selects it. Modify BNX2X config option to 'select ZLIB_INFLATE' like BNX2 and others. This seems to fix it. Signed-off-by:

Re: TCP event tracking via netlink...

2007-12-05 Thread John Heffner
David Miller wrote: Ilpo, I was pondering the kind of debugging one does to find congestion control issues and even SACK bugs and it's currently too painful because there is no standard way to track state changes. I assume you're using something like carefully crafted printk's, kprobes, or even

Re: [PATCH v2 0/3][BUG-FIX]: Test tree updates and bug fixes

2007-12-05 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 05, 2007 at 11:19:45AM +, Gerrit Renker escreveu: > This fixes a problem in the initial revision of the patch: The loss interval > history was not de-allocated when the initialisation of the packet history > failed. The identification of this problem is also thanks due to Arnaldo.

Re: [PATCH v2 0/3][BUG-FIX]: Test tree updates and bug fixes

2007-12-05 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 05, 2007 at 11:19:46AM +, Gerrit Renker escreveu: > This patch removes the following redundancies: > * ccid3_hc_rx_update_s() is only called for data packets (that is what it > should be called for); > * each call to ccid3_hc_rx_update_s() is wrapped inside a "if > (is_data_pa

Re: [PATCH] correct typo in __xfrm4_bundle_create()

2007-12-05 Thread David Miller
From: "Ian Brown" <[EMAIL PROTECTED]> Date: Wed, 5 Dec 2007 15:59:52 +0200 > Hello, > Sorry ; but is this tree can be fetched ? it requires a password. > > I try: > git-clone kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.25.git net-2.6.25 > and get: > [EMAIL PROTECTED]'s password: Use the g

Re: [PATCH] correct typo in __xfrm4_bundle_create()

2007-12-05 Thread Ian Brown
Hello, Sorry ; but is this tree can be fetched ? it requires a password. I try: git-clone kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.25.git net-2.6.25 and get: [EMAIL PROTECTED]'s password: Ian On Dec 5, 2007 3:47 PM, David Miller <[EMAIL PROTECTED]> wrote: > From: "Ian Brown" <[EMAIL PR

Re: [PATCH v2 0/3][BUG-FIX]: Test tree updates and bug fixes

2007-12-05 Thread Gerrit Renker
| > @@ -788,8 +782,8 @@ static void ccid3_hc_rx_packet_recv(stru | > if (unlikely(hcrx->ccid3hcrx_state == TFRC_RSTATE_NO_DATA)) { | > if (is_data_packet) { | > do_feedback = FBACK_INITIAL; | > + hcrx->ccid3hcrx_s = payload_size; | >

Re: [Fwd: PATCH 2.6.24-rc3-mm2 - build breakage - bnx2x depends on ZLIB_INFLATE]

2007-12-05 Thread Eliezer Tamir
I will resend it in a moment. Thanks, Eliezer On Wed, 2007-12-05 at 05:44 -0800, David Miller wrote: > From: "Eliezer Tamir" <[EMAIL PROTECTED]> > Date: Wed, 05 Dec 2007 15:40:15 +0200 > > > Dave, > > > > Lee Schermerhorn sent this patch while you were away, > > please apply. > > I can't becau

Re: [PATCH] correct typo in __xfrm4_bundle_create()

2007-12-05 Thread David Miller
From: "Ian Brown" <[EMAIL PROTECTED]> Date: Wed, 5 Dec 2007 15:41:37 +0200 > Hello, > Sorry; I was not aware of it; I am sending here the patch as an attachment. > It is a typo correction in __xfrm4_bundle_create() in net/ipv4/xfrm4_policy.c; > it should be "Copy neighbour" instead "Copy neighbo

Re: [RFC][PATCHES 0/7]: Reorganization of RX history patches

2007-12-05 Thread Gerrit Renker
| > Patch #3: | > - | > Renames s/tfrc_tx_hist/tfrc_tx_hist_slab/g; no problems. | | This was for consistency with the other slabs in DCCP: | | [EMAIL PROTECTED] net-2.6.25]$ find net/dccp/ -name "*.c" | xargs grep 'struct kmem_cache' Thanks, I will put the same naming scheme also in

Re: [Fwd: PATCH 2.6.24-rc3-mm2 - build breakage - bnx2x depends on ZLIB_INFLATE]

2007-12-05 Thread David Miller
From: "Eliezer Tamir" <[EMAIL PROTECTED]> Date: Wed, 05 Dec 2007 15:40:15 +0200 > Dave, > > Lee Schermerhorn sent this patch while you were away, > please apply. I can't because the patch is corrupted by line breaks and tabs --> space corruption caused by his mail client. -- To unsubscribe from

Re: [PATCH] correct typo in __xfrm4_bundle_create()

2007-12-05 Thread Ian Brown
Hello, Sorry; I was not aware of it; I am sending here the patch as an attachment. It is a typo correction in __xfrm4_bundle_create() in net/ipv4/xfrm4_policy.c; it should be "Copy neighbour" instead "Copy neighbout" Ian On Dec 5, 2007 3:20 PM, David Miller <[EMAIL PROTECTED]> wrote: > From: "I

[Fwd: PATCH 2.6.24-rc3-mm2 - build breakage - bnx2x depends on ZLIB_INFLATE]

2007-12-05 Thread Eliezer Tamir
Dave, Lee Schermerhorn sent this patch while you were away, please apply. Thanks, Eliezer Forwarded Message From: Lee Schermerhorn <[EMAIL PROTECTED]> To: Andrew Morton <[EMAIL PROTECTED]>, netdev@vger.kernel.org, linux-kernel <[EMAIL PROTECTED]> Subject: PATCH 2.6.24-rc3-mm2 -

Re: [PATCH 7/7] [TFRC] New rx history code

2007-12-05 Thread Gerrit Renker
| > In the end this went back to the same questions and issues that were tackled between | > February and March this year. I wish we could have had this dicussion then; it would | > have made this email unnecessary. | | That is why it is important that the changeset comment collects these | scat

TCP event tracking via netlink...

2007-12-05 Thread David Miller
Ilpo, I was pondering the kind of debugging one does to find congestion control issues and even SACK bugs and it's currently too painful because there is no standard way to track state changes. I assume you're using something like carefully crafted printk's, kprobes, or even ad-hoc statistic coun

Re: [PATCH v2 0/3][BUG-FIX]: Test tree updates and bug fixes

2007-12-05 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 05, 2007 at 11:19:46AM +, Gerrit Renker escreveu: > This patch removes the following redundancies: > * ccid3_hc_rx_update_s() is only called for data packets (that is what it > should be called for); > * each call to ccid3_hc_rx_update_s() is wrapped inside a "if > (is_data_pa

Re: [PATCH] correct typo in __xfrm4_bundle_create()

2007-12-05 Thread David Miller
From: "Ian Brown" <[EMAIL PROTECTED]> Date: Wed, 5 Dec 2007 12:49:52 +0200 > This is a typo correction in net/ipv4/xfrm4_policy.c; it should be > "Copy neighbour" instead "Copy neighbout", Your email client has corrupted the patch by adding newlines among other things. This happens often for gm

Re: [PATCH] BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit

2007-12-05 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 05 Dec 2007 13:41:24 +0100 > Building last net-2.6.25 git tree gave me this warning : > > WARNING: vmlinux.o(.init.text+0x2a957): Section mismatch: reference to > .exit.text:br_fdb_fini (between 'br_init' and 'br_fdb_init') > > This is because b

Re: [PATCH 0/2] netem: trace enhancement

2007-12-05 Thread Patrick McHardy
Ariane Keller wrote: Thanks for your comments! Patrick McHardy wrote: But with this we would need the tcm_handle, tcm_parent arguments etc. which are not known in q_netem.c Therefore we would have to change the parse_qopt() function prototype in order to pass the whole "req" and not only the

Re: [PATCH 0/2] netem: trace enhancement

2007-12-05 Thread Ariane Keller
Thanks for your comments! Patrick McHardy wrote: Ariane Keller wrote: That sounds like it would also be possible using rtnetlink. You could send out a notification whenever you switch the active buffer and have userspace listen to these and replace the inactive one. I guess using rtnetlink

Re: [PATCH] BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit

2007-12-05 Thread Stephen Hemminger
On Wed, 05 Dec 2007 13:41:24 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > Hi David > > Building last net-2.6.25 git tree gave me this warning : > > WARNING: vmlinux.o(.init.text+0x2a957): Section mismatch: reference to > .exit.text:br_fdb_fini (between 'br_init' and 'br_fdb_init') > > This

[PATCH] BRIDGE : br_fdb_fini() should be __exit_refok instead of __exit

2007-12-05 Thread Eric Dumazet
Hi David Building last net-2.6.25 git tree gave me this warning : WARNING: vmlinux.o(.init.text+0x2a957): Section mismatch: reference to .exit.text:br_fdb_fini (between 'br_init' and 'br_fdb_init') This is because br_init() (marked __init) can call br_fdb_fini() (marked __exit). I am not su

Re: [PATCH 7/7] [TFRC] New rx history code

2007-12-05 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 05, 2007 at 09:35:30AM +, Gerrit Renker escreveu: > Quoting Arnaldo: > | Em Tue, Dec 04, 2007 at 06:55:17AM +, Gerrit Renker escreveu: > | > NAK. You have changed the control flow of the algorithm and the underlying > | > data structure. Originally it had been an array of pointe

Re: [RFC][PATCHES 0/7]: Reorganization of RX history patches

2007-12-05 Thread Arnaldo Carvalho de Melo
Note: removed Ingo from the CC list, I had added it first just because he advocated reducing the number of mailing lists, so I wanted him to know that we're trying to do that. Em Wed, Dec 05, 2007 at 10:27:36AM +, Gerrit Renker escreveu: > Today being Wednesday, below is some feedback after wo

Re: [PATCH 3/3] [TCP]: NAGLE_PUSH seems to be a wrong way around

2007-12-05 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Wed, 5 Dec 2007 13:18:14 +0200 (EET) > ...If I understood the very old history correctly, this bug was introduced > in 2.4.0-test12 which inverted !tail incorrectly to nonagle==1. > > You can check include/net/tcp.h diffs from this commit: > http:/

Re: [NETLINK]: Mark attribute construction exception unlikely

2007-12-05 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 05 Dec 2007 12:19:17 +0100 > [NETLINK]: Mark attribute construction exception unlikely > > Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> Applied to net-2.6.25, thanks Patrick. -- To unsubscribe from this list: send the line "unsubscribe n

Re: [PATCH net-2.6 0/3]: Three TCP fixes

2007-12-05 Thread Ilpo Järvinen
On Wed, 5 Dec 2007, David Miller wrote: > From: John Heffner <[EMAIL PROTECTED]> > Date: Tue, 04 Dec 2007 13:42:41 -0500 > > > Ilpo Järvinen wrote: > > > ...I'm still to figure out why tcp_cwnd_down uses snd_ssthresh/2 > > > as lower bound even though the ssthresh was already halved, > > > so sn

[PATCH v2 0/3][BUG-FIX]: Test tree updates and bug fixes

2007-12-05 Thread Gerrit Renker
This revision fixes a bug present in the per-socket allocation of RX history entries; identification of this bug is thanks to Arnaldo Carvalho de Melo. The bug was in not deallocating history entries when the allocation of one array element failed. The solution in this revised patch set is the o

[PATCH v2 0/3][BUG-FIX]: Test tree updates and bug fixes

2007-12-05 Thread Gerrit Renker
This fixes a problem in the initial revision of the patch: The loss interval history was not de-allocated when the initialisation of the packet history failed. The identification of this problem is also thanks due to Arnaldo. The interdiff to the previous revision is: --- b/net/dccp/ccid

[PATCH v2 0/3][BUG-FIX]: Test tree updates and bug fixes

2007-12-05 Thread Gerrit Renker
This patch removes the following redundancies: * ccid3_hc_rx_update_s() is only called for data packets (that is what it should be called for); * each call to ccid3_hc_rx_update_s() is wrapped inside a "if (is_data_packet)" test'; * therefore testing each time if "len > 0" is redundant (poi

[PATCH v2 0/3][BUG-FIX]: Test tree updates and bug fixes

2007-12-05 Thread Gerrit Renker
Orthogonal to the ongoing discussion of patches, here are updates of existing ones. This is mainly to keep the test tree in synch; I'd like to upload the new test tree since -rc4 is out. Arnaldo has actually pointed out more bugs than I have given him credit for, these are contained in this patch

[NETLINK]: Mark attribute construction exception unlikely

2007-12-05 Thread Patrick McHardy
[NETLINK]: Mark attribute construction exception unlikely Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 9fce717f589c67137fbfc3b202d3d107dd613ad7 tree efc61e4abeeb2a89cad629c719e528364fb8dcdd parent d426bc47b4c14d6d60b35d1b79c7d598704bbf04 author Patrick McHardy <[EMAIL PROTECTED]

Re: [PATCH 3/3] [TCP]: NAGLE_PUSH seems to be a wrong way around

2007-12-05 Thread Ilpo Järvinen
On Wed, 5 Dec 2007, David Miller wrote: > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > Date: Tue, 4 Dec 2007 18:48:50 +0200 > > > The comment in tcp_nagle_test suggests that. This bug is very > > very old, even 2.4.0 seems to have it. > > > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> > >

Re: [PATCH net-2.6 0/3]: Three TCP fixes

2007-12-05 Thread Alexey Kuznetsov
Hello! > My theory is that it could relate to tcp_cwnd_restart and > tcp_cwnd_application_limited using it and the others are just then > accidently changed as well. Perhaps I'll have to dig once again to > changelog history to see if there's some clue (unless Alexey shed > some light to this)

  1   2   >