Re: [PATCH 2.6.24 1/1]S2io: Fixed memory leak by freeing MSI-X local entry memories when vector allocation fails

2007-11-23 Thread Jeff Garzik
Ramkrishna Vepa wrote: Jeff, We got an ACK back last week from Dave Miller that the following 2 patches were already applied - reply follows. whoops sorry, I see that now. yep, they are applied. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body o

Re: wireless vs. alignment requirements

2007-11-23 Thread Herbert Xu
Johannes Berg <[EMAIL PROTECTED]> wrote: > > Now, the IP stack actually assumes that its header is four-byte aligned > (see comment at NET_IP_ALIGN, although it is not said explicitly that > the alignment requirement for an IP header is four) so that is actually > something for the hardware/firmwar

Re: [RFC/PATCH] SO_NO_CHECK for IPv6

2007-11-23 Thread Herbert Xu
David Schwartz <[EMAIL PROTECTED]> wrote: > >> Regardless of whatever verifications your application is doing >> on the data, it is not checksumming the ports and that's what >> the pseudo-header is helping with. > > So what? We are in the case where the data has already gotten to him. If it > go

RE: [PATCH 2.6.24 1/1]S2io: Fixed memory leak by freeing MSI-X local entry memories when vector allocation fails

2007-11-23 Thread Ramkrishna Vepa
Jeff, We got an ACK back last week from Dave Miller that the following 2 patches were already applied - reply follows. " > [Ram] The version numbers are different for the 2 patches. Was the > MSI-X leak bug fix applied prior to resubmission (we had swapped the > version numbers on the patches f

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-23 Thread Rusty Russell
On Saturday 24 November 2007 06:53:30 Andi Kleen wrote: > This serves as a documentation > on what is considered internal. And if some obscure module (in or > out of tree) wants to use an internal interface they first have > to send the module maintainer a patch and get some review this way. So,

Re: [PATCH] NET: dmfe: don't access configuration space in D3 state

2007-11-23 Thread Maxim Levitsky
On Saturday 24 November 2007 05:10:37 Jeff Garzik wrote: > Maxim Levitsky wrote: > >>From 7e24227257f315e52fe0b494dc1253d2a0ce5dff Mon Sep 17 00:00:00 2001 > > From: Maxim Levitsky <[EMAIL PROTECTED]> > > Date: Fri, 23 Nov 2007 01:15:36 +0200 > > Subject: [PATCH] NET: dmfe: don't access configurati

Re: [PATCH] Add VLAN (802.1q) support to sis900 driver

2007-11-23 Thread Jeff Garzik
Daniele Venzano wrote: The attached patch adds support for VLANs to the sis900 driver and bumps the version number. It is based on an old (2003) patch for the 2.4 series by Hamid Hashemi Golpayegani. It applies on top of 2.6.16(.5). I have one report that it works and behaves as intended. Please

Re: [PATCH 1/2] Blackfin SMC91x Driver: punt CONFIG_BFIN -- we already have CONFIG_BLACKFIN

2007-11-23 Thread Jeff Garzik
Bryan Wu wrote: From: Mike Frysinger <[EMAIL PROTECTED]> Signed-off-by: Mike Frysinger <[EMAIL PROTECTED]> Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> --- drivers/net/Kconfig |2 +- drivers/net/smc91x.h |2 +- applied 1-2 to #upstream-fixes - To unsubscribe from this list: send the

Re: [PATCH] NET: dmfe: don't access configuration space in D3 state

2007-11-23 Thread Jeff Garzik
Maxim Levitsky wrote: From 7e24227257f315e52fe0b494dc1253d2a0ce5dff Mon Sep 17 00:00:00 2001 From: Maxim Levitsky <[EMAIL PROTECTED]> Date: Fri, 23 Nov 2007 01:15:36 +0200 Subject: [PATCH] NET: dmfe: don't access configuration space in D3 state Accidently I reversed the order of pci_save_state

Re: [PATCH] sky2: disable rx checksum on Yukon XL

2007-11-23 Thread Jeff Garzik
Stephen Hemminger wrote: The Marvell Yukon XL chipset appears to have a hardware glitch where it will repeat the checksum of the last packet. Of course, this is timing sensitive and only happens sometimes... More info: http://bugzilla.kernel.org/show_bug.cgi?id=9381 As a workaround just disable

Re: [PATCH 1/2][2.6.24] ehea: Improve tx packets counting

2007-11-23 Thread Jeff Garzik
Thomas Klein wrote: Using own tx_packets counter instead of firmware counters. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c |9 +++-- 2 files changed, 8 insertions(+), 3 deletions(-) applies 1-2 to #upstream-

Re: [PATCH] smc911x: Fix undefined CONFIG_ symbol warning

2007-11-23 Thread Jeff Garzik
Peter Korsgaard wrote: elif defined(CONFIG_*) should be used instead of elif CONFIG_* so GCC doesn't give warnings about undefined symbols when the config option is disabled. --- drivers/net/smc911x.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/smc911x.h

Re: [PATCH] amd8111e: don't call napi_enable if configured w/o NAPI

2007-11-23 Thread Jeff Garzik
Jiri Bohac wrote: The amd8111e network driver was broken by bea3348eef27e6044b6161fd04c3152215f96411, which makes the driver call napi_enable() and napi_disable() even if the driver had been configured without CONFIG_AMD8111E_NAPI, and thus netif_napi_add() had not been called on initialization

Re: [PATCH 2.6.24 2/2]S2io: Fix to aggregate vlan tagged packets

2007-11-23 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Fix to aggregate vlan packets. IP offset is incremented by 4 bytes if the packet contains vlan header. Signed-off-by: Santoshkumar Rastapur <[EMAIL PROTECTED]> Signed-off-by: Ramkrishna Vepa <[EMAIL PROTECTED]> --- ACK but cannot apply due to dropped patches - To

Re: [PATCH 2.6.24 1/2]S2io: Strip the vlan tag if the vlan group is not NULL

2007-11-23 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Updated the vlan tag stripping code as per Dave Johnson's patch <[EMAIL PROTECTED]> Below is the driver behaviour for vlan_tag_strip loadable paramter, vlan_tag_strip - 0: Don't strip the vlan tag vlan_tag_strip - 1: Always strip the vlan tag vlan_tag

Re: [PATCH 2.6.24 1/1]S2io: Fixed memory leak by freeing MSI-X local entry memories when vector allocation fails

2007-11-23 Thread Jeff Garzik
Sreenivasa Honnur wrote: - Fixed memory leak by freeing MSI-X local entry memories when vector allocation fails in s2io_add_isr. - Added two utility functions remove_msix_isr and remove_inta_isr to eliminate code duplication. - Incorporated following review comments from Jeff - Removed re

Re: [PATCH 2.6.24 1/1]S2io: Support for add/delete/store/restore ethernet addresses

2007-11-23 Thread Jeff Garzik
Sreenivasa Honnur wrote: - Support to add/delete/store/restore 64 and 128 Ethernet addresses for Xframe I and Xframe II respectively. - (Resubmit third time) patch does not apply to linux upstream (2.6.24-rc) nor netdev-2.6#upstream - To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH 1/9] cxgb3 - fix MSI-X failure path

2007-11-23 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Return error code when msi-x settings fail. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) applied 1-9 to #upstream, then trimmed all trai

Re: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources

2007-11-23 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: The e1000 driver stores the content of the PCI resources into unsigned long's before ioremapping. This breaks on 32 bits platforms that support 64 bits MMIO resources such as ppc 44x. This fixes it by removing those temporary variables and passing directly the resul

Re: [PATCH net-2.6.25] Add packet filtering based on process'ssecurity context.

2007-11-23 Thread Tetsuo Handa
Hello. James Morris wrote: > From memory, one approach under discussion was to add netfilter hooks to > the transport layer, which could be invoked correctly by each type of > protocol when the target process is selected. > > If this is done for netfilter, then an LSM hook is probably not neede

Re: [patch 3/8] ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes

2007-11-23 Thread Andrew Morton
On Fri, 23 Nov 2007 20:58:51 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > [EMAIL PROTECTED] wrote: > > From: Andrew Morton <[EMAIL PROTECTED]> > > > > Cc: "David S. Miller" <[EMAIL PROTECTED]> > > Cc: Emil Medve <[EMAIL PROTECTED]> > > Cc: Jeff Garzik <[EMAIL PROTECTED]> > > Cc: Kumar Gala <[EM

Re: [PATCH] dm9601: Consolidate common parts of dm_write_*_async

2007-11-23 Thread Jeff Garzik
Peter Korsgaard wrote: dm_write_async and dm_write_reg_async are almost identical. Move common functionality to dm_write_async_helper (saves ~256b). Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/net/usb/dm9601.c | 53 +++-- 1 files chan

Re: [PATCH] dm9601: Fix printk

2007-11-23 Thread Jeff Garzik
Peter Korsgaard wrote: A printk in the error handling code of dm9601.c was missing a newline. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/net/usb/dm9601.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm96

Re: [PATCH] 3c501: Bring into compliance with the coding style

2007-11-23 Thread Jeff Garzik
Alan Cox wrote: 3c501 leads the way... 8) Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied #upstream please send stuff to netdev@vger.kernel.org, linux-net is pretty much dead - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED

Re: [patch 8/8] forcedeth boot delay fix

2007-11-23 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Ayaz Abdulla <[EMAIL PROTECTED]> Fix a long boot delay in the forcedeth driver. During initialization, the timeout for the handshake between mgmt unit and driver can be very long. The patch reduces the timeout by eliminating a extra loop around the timeout logic

Re: [patch 3/8] ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes

2007-11-23 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Andrew Morton <[EMAIL PROTECTED]> Cc: "David S. Miller" <[EMAIL PROTECTED]> Cc: Emil Medve <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Cc: Kumar Gala <[EMAIL PROTECTED]> Cc: Li Yang <[EMAIL PROTECTED]> Cc: Paul Mackerras <[EMAIL PROTECTED]> Signed-off-b

Re: [PATCH 29/59] drivers/net/chelsio: Add missing "space"

2007-11-23 Thread Jeff Garzik
Joe Perches wrote: Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- drivers/net/chelsio/cxgb2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) appied 29-36 to netdev#upstream - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

Re: [PATCH] ethtool: Fix coalesce settings copy+paste typo

2007-11-23 Thread Jeff Garzik
Auke Kok wrote: Coalesce setting errors use the same error messages as the descriptor ring errors. applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ethtool: add support for supporting 10000baseT

2007-11-23 Thread Jeff Garzik
Auke Kok wrote: From: Jesse Brandeburg <[EMAIL PROTECTED]> there is missing support in ethtool for reporting 1baseT as SUPPORTED_1baseT_Full. The code seems to be half implemented because the "advertising" field has the implementation. this patch just adds it for supported reporting.

Re: [PATCH 1/2] forcedeth new mcp79 device ids

2007-11-23 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch adds new device ids for mcp79 devices. Signed-off-by: Ayaz Abdulla <[EMAIL PROTECTED]> applied 1-2 to #upstream-fixes, after combining into a single patch - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PRO

Re: [PATCH] ibm_newemac: Fix possible lockup on close

2007-11-23 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: It's a bad idea to call flush_scheduled_work from within a netdev->stop because the linkwatch will occasionally take the rtnl lock from a workqueue context, and thus that can deadlock. This reworks things a bit in that area to avoid the problem. Signed-off-by: Benj

netdev-2.6 rebased

2007-11-23 Thread Jeff Garzik
I pulled all the patches collected by DaveM in davem/netdev-2.6.git a few days ago into jgarzik/netdev-2.6.git#upstream. As of a few minutes ago, jgarzik/netdev-2.6.git was rebased to the latest 2.6.24-rc (torvalds/linux-2.6.git). Jeff - To unsubscribe from this list: send the line

Re: [PATCH 0/8] ibm_newemac: Candidate patches for 2.6.25

2007-11-23 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: Here are the patches I have pending for EMAC. With some non-released patches from Hugh Blemings, I get a taishan (440GX) booting now, in addition to Ebony (440GP) and various 405GP boards. This is 2.6.25 material except for patch #1 which has already been posted sep

Re: [patch 22/22] NET: DM9000: Show the MAC address source after printing MAC

2007-11-23 Thread Jeff Garzik
ACK patches 16-22 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 15/22] NET: DM9000: Use netif_msg to enable debugging options

2007-11-23 Thread Jeff Garzik
ah, you took care of my comment regarding an earlier patch. consider that comment rescinded - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 14/22] NET: DM9000: Remove unnecessary changelog in header comment

2007-11-23 Thread Jeff Garzik
ACK patches 8-14 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 07/22] NET: DM9000: Use msleep() instead of udelay()

2007-11-23 Thread Jeff Garzik
are you sure you cannot sleep during suspend? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 06/22] NET: DM9000: Use kthread to probe MII status when device open

2007-11-23 Thread Jeff Garzik
seems like a delayed workqueue would be most appropriate for this. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 05/22] NET: DM9000: Do not sleep with spinlock and IRQs held

2007-11-23 Thread Jeff Garzik
ACK - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 04/22] NET: DM9000: Add initial ethtool support

2007-11-23 Thread Jeff Garzik
if ETHTOOL_GDRVINFO bus info is not PCI, you must add a prefix a la 3c59x.c or eepro.c - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 03/22] NET: DM9000: Pass IRQ flags via platform data

2007-11-23 Thread Jeff Garzik
ACK - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 02/22] NET: DM9000 update debugging macros to use debug level

2007-11-23 Thread Jeff Garzik
you really should consider adding msg_enable support (grep for that in other net drivers, and for netif_msg in netdevice.h) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-

Re: [patch 01/22] NET: DM9000 use dev_xxx() instead of printk for output.

2007-11-23 Thread Jeff Garzik
ACK - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] PowerPC: ibm_newemac minor fixes.

2007-11-23 Thread Benjamin Herrenschmidt
On Fri, 2007-11-23 at 20:20 -0500, Jeff Garzik wrote: > Benjamin Herrenschmidt wrote: > > On Fri, 2007-11-23 at 22:07 +0300, Valentine Barshak wrote: > > > >> These patches have some minor ibm_newemac fixes. > > > > All 3 patches look good, thanks. I'll sign them off and forward them > > to Jeff

Re: [PATCH 0/3] PowerPC: ibm_newemac minor fixes.

2007-11-23 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: On Fri, 2007-11-23 at 22:07 +0300, Valentine Barshak wrote: These patches have some minor ibm_newemac fixes. All 3 patches look good, thanks. I'll sign them off and forward them to Jeff in my next batch. Jeff, did you already pick up my previous drop of EMAC pat

Re: [PATCH 0/3] PowerPC: ibm_newemac minor fixes.

2007-11-23 Thread Benjamin Herrenschmidt
On Fri, 2007-11-23 at 22:07 +0300, Valentine Barshak wrote: > These patches have some minor ibm_newemac fixes. All 3 patches look good, thanks. I'll sign them off and forward them to Jeff in my next batch. Jeff, did you already pick up my previous drop of EMAC patches from last week for .25 or

cqe, cqe_skb: return when both or when either NULL?

2007-11-23 Thread Roel Kluin
In function ehea_poll() drivers/net/ehea/ehea_main.c:667, in a loop cqe and cqe_skb - both struct ehea_cqe pointers - are assigned: -- cqe = ehea_poll_rq1(pr->qp, &wqe_index); cqe_skb = ehea_poll_cq(pr->send_cq); if (!cqe && !cqe_skb) return rx; -- Is it intended that only when both are NU

wireless vs. alignment requirements

2007-11-23 Thread Johannes Berg
> David Miller found a problem in a wireless driver where I was using > compare_ether_addr() on potentially unaligned data. Document that > compare_ether_addr() is not safe for use everywhere, and add an equivalent > function that works regardless of alignment. FWIW, as I've said in the other thr

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 10:54:11PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 01:41:39PM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > Here's another thought: move all this logic into the networking core, > > unify it with current softirq zapper, then allow it to be called fro

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 10:54:10PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > On Fri, Nov 23, 2007 at 01:41:39PM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > Here's another thought: move all this logic into the networking core, > > unify it with current softirq zapper, then allo

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 01:41:39PM -0600, Matt Mackall ([EMAIL PROTECTED]) wrote: > Here's another thought: move all this logic into the networking core, > unify it with current softirq zapper, then allow it to be called from > various other places (like atomic allocators). Then it'll all be in >

Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro.

2007-11-23 Thread Andi Kleen
On Fri, Nov 23, 2007 at 02:35:05PM +1100, Rusty Russell wrote: > On Friday 23 November 2007 12:36:22 Andi Kleen wrote: > > On Friday 23 November 2007 01:25, Rusty Russell wrote: > > > That's my point. If there's a whole class of modules which can use a > > > symbol, why are we ruling out external

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 10:32:22PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 01:11:20PM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > On Fri, Nov 23, 2007 at 09:59:06PM +0300, Evgeniy Polyakov wrote: > > > On Fri, Nov 23, 2007 at 09:51:01PM +0300, Evgeniy Polyakov ([EMAIL >

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 01:11:20PM -0600, Matt Mackall ([EMAIL PROTECTED]) wrote: > On Fri, Nov 23, 2007 at 09:59:06PM +0300, Evgeniy Polyakov wrote: > > On Fri, Nov 23, 2007 at 09:51:01PM +0300, Evgeniy Polyakov ([EMAIL > > PROTECTED]) wrote: > > > On Fri, Nov 23, 2007 at 09:48:51PM +0300, Evgen

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 10:15:24PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 12:59:43PM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > So I'd be surprised if that was a problem. But I can imagine having > > problems for skbs without destructors which run into one of these in >

[PATCH 3/3] PowerPC: ibm_newemac call dev_set_drvdata() before tah_reset()

2007-11-23 Thread Valentine Barshak
The patch moves dev_set_drvdata(&ofdev->dev, dev) up before tah_reset(ofdev) is called to avoid a NULL pointer dereference, since tah_reset uses drvdata. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/tah.c |3 ++- 1 files changed, 2 insertions(+), 1 deletion

[PATCH 2/3] PowerPC: ibm_newemac tah_ph typo fix

2007-11-23 Thread Valentine Barshak
This patch fixes a typo in ibm_newemac/core.c (tah_port should be used instead of tah_ph) Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -pruN linux-2.6.orig/drivers/net/ibm_newemac/core.c li

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 09:59:06PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 09:51:01PM +0300, Evgeniy Polyakov ([EMAIL > PROTECTED]) wrote: > > On Fri, Nov 23, 2007 at 09:48:51PM +0300, Evgeniy Polyakov ([EMAIL > > PROTECTED]) wrote: > > > Stop, we are trying to free skb without d

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 12:59:43PM -0600, Matt Mackall ([EMAIL PROTECTED]) wrote: > So I'd be surprised if that was a problem. But I can imagine having > problems for skbs without destructors which run into one of these in > __kfree_skb: > > dst_release > secpath_put > nf_conntrack_put > nf_connt

[PATCH 1/3] PowerPC: ibm_newemac correct opb_bus_freq value

2007-11-23 Thread Valentine Barshak
The EMAC4_MR1_OBCI(freq) macro expects freg in MHz, while opb_bus_freq is kept in Hz. Correct this. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -pruN linux-2.6.orig/drivers/net/ibm_newemac/

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 08:57:57PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 11:07:56AM -0600, Matt Mackall ([EMAIL PROTECTED]) > wrote: > > On Fri, Nov 23, 2007 at 01:55:19PM +0300, Evgeniy Polyakov wrote: > > > On Fri, Nov 23, 2007 at 12:21:57AM -0800, Andrew Morton ([EMAIL > > >

[PATCH 0/3] PowerPC: ibm_newemac minor fixes.

2007-11-23 Thread Valentine Barshak
These patches have some minor ibm_newemac fixes. Thanks, Valentine. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 09:51:01PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > On Fri, Nov 23, 2007 at 09:48:51PM +0300, Evgeniy Polyakov ([EMAIL > PROTECTED]) wrote: > > Stop, we are trying to free skb without destructor and catch connection > > tracking, so it is not a solution. To fix

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 09:48:51PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > Stop, we are trying to free skb without destructor and catch connection > tracking, so it is not a solution. To fix the problem we need to check > if it is not netfilter related, kind of this (not tested), Simo

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 08:57:57PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > > My memory here is hazy, but I think this exists to rescue netconsole > > in low-memory situations. This bit originated with Ingo, so maybe he > > can recall. > > > > Netpoll can process an arbitrary number o

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 11:07:56AM -0600, Matt Mackall ([EMAIL PROTECTED]) wrote: > On Fri, Nov 23, 2007 at 01:55:19PM +0300, Evgeniy Polyakov wrote: > > On Fri, Nov 23, 2007 at 12:21:57AM -0800, Andrew Morton ([EMAIL PROTECTED]) > > wrote: > > > > [2059664.615816] __iptables__: init4 IN=ppp0 OUT

Re: [Bugme-new] [Bug 9443] New: RFC4193 IPv6 addresses seem not to be completly supported : default gateway not set

2007-11-23 Thread Andrew Morton
On Fri, 23 Nov 2007 05:42:35 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9443 > >Summary: RFC4193 IPv6 addresses seem not to be completly > supported : default gateway not set >Product: Networking >Versi

[PATCH] [RFC] New driver "sfc" for Solarstorm SFC4000 controller

2007-11-23 Thread Ben Hutchings
This is a net driver (and MTD driver, sfc_mtd) for our SFC4000 10G Ethernet controller, branded "Solarstorm", with various PHYs. It is intended to support our NIC reference designs SFE4001 (10GBASE-T), SFE4002 (XFP), SFE4003 (10GBASE-CX4), OEM designs based on them, and some development boards. W

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Matt Mackall
On Fri, Nov 23, 2007 at 01:55:19PM +0300, Evgeniy Polyakov wrote: > On Fri, Nov 23, 2007 at 12:21:57AM -0800, Andrew Morton ([EMAIL PROTECTED]) > wrote: > > > [2059664.615816] __iptables__: init4 IN=ppp0 OUT=ppp0 WARNING: at > > > kernel/softirq.c:139 local_bh_enable() > > > [2059664.620535] [<8

[PATCH] Fix memory leak in inet_hashtables.h when NUMA is on

2007-11-23 Thread Pavel Emelyanov
The inet_ehash_locks_alloc() looks like this: #ifdef CONFIG_NUMA if (size > PAGE_SIZE) x = vmalloc(...); else #endif x = kmalloc(...); Unlike it, the inet_ehash_locks_alloc() looks like this: #ifdef CONFIG_NUMA if (size > PAGE_SIZE)

Does tc-prio really work as advertised?

2007-11-23 Thread Joerg Pommnitz
Hello all, I might make a fool out of me, but I think the prio qdisc doesn't work as advertised in any document I could lay my hands on. My problem was that the link quality reported by the olsr.org olsrd degraded depending on the amount of payload traffic transferred through an adhoc/mesh inte

Re: [PATCH net-2.6.25] [TCP]: Move FRTO checks out from write queue abstraction funcs

2007-11-23 Thread Herbert Xu
On Fri, Nov 23, 2007 at 04:14:03PM +0200, Ilpo Järvinen wrote: > > The purpose of the tcp_advance_send_head & friends was/is to abstract > the write queue from the TCP worker code. RB-tree wq can then be put in > place more easily (and I'm hopefully coming to that soon). There are some > other simi

Re: [PATCH net-2.6.25] [TCP]: Move FRTO checks out from write queue abstraction funcs

2007-11-23 Thread Ilpo Järvinen
On Fri, 23 Nov 2007, Herbert Xu wrote: > On Fri, Nov 23, 2007 at 02:25:08PM +0200, Ilpo Järvinen wrote: > > > > Better place exists in update_send_head (other non-queue related > > adjustments are done there as well) which is the only caller of > > tcp_advance_send_head (now that the bogus call f

[PATCH net-2.6.25] Make macro to specify the ptype_base size

2007-11-23 Thread Pavel Emelyanov
Currently this size is 16, but as the comment says this is so only because all the chains (except one) has the length 1. I think, that some day this may change, so growing this hash will be much easier. Besides, symbolic names are read better than magic constants. Signed-off-by: Pavel Emelyanov

[PATCH net-2.6.25] Name magic constants in sock_wake_async()

2007-11-23 Thread Pavel Emelyanov
The sock_wake_async() performs a bit different actions depending on "how" argument. Unfortunately this argument ony has numerical magic values. I propose to give names to their constants to help people reading this function callers understand what's going on without looking into this function

Re: [PATCHv6 iptables]Interface group match

2007-11-23 Thread Lutz Jaenicke
On Tue, Nov 20, 2007 at 02:14:28PM +0100, Laszlo Attila Toth wrote: > Interface group values can be checked on both input and output interfaces > with optional mask. > Index: extensions/libxt_ifgroup.c > === > --- extensions/libxt_ifg

Re: [PATCH][UNIX] Move the unix sock iterators in to proper place

2007-11-23 Thread Herbert Xu
On Fri, Nov 23, 2007 at 04:10:08PM +0300, Pavel Emelyanov wrote: > > I'm afraid to become importunate, but is the net-2.6 (not 25) > tree is currently the David's tree (unlike net-2.6.25, which > has temporary switched to your one)? I'm about to do a push soon which will create net-2.6 in the same

Re: [PATCH net-2.6.25] [TCP]: Move FRTO checks out from write queue abstraction funcs

2007-11-23 Thread Herbert Xu
On Fri, Nov 23, 2007 at 02:25:08PM +0200, Ilpo Järvinen wrote: > > Better place exists in update_send_head (other non-queue related > adjustments are done there as well) which is the only caller of > tcp_advance_send_head (now that the bogus call from mtu_probe is > gone). > > Signed-off-by: Ilpo

Re: [PATCH][IPv6] Correct the comment concerning inetsw6 table

2007-11-23 Thread Herbert Xu
On Fri, Nov 23, 2007 at 11:57:54AM +0300, Pavel Emelyanov wrote: > It seems that net/ipv6/af_inet6.c was copied from net/ipv4/af_inet.c, > but one comment was not fixed. > > Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Applied. Oh and congratulations for advancing in the Order of Pedantry

Re: [PATCH] add compare_ether_addr_unaligned

2007-11-23 Thread Herbert Xu
On Fri, Nov 23, 2007 at 12:09:22AM +, Daniel Drake wrote: > David Miller found a problem in a wireless driver where I was using > compare_ether_addr() on potentially unaligned data. Document that > compare_ether_addr() is not safe for use everywhere, and add an equivalent > function that works

Re: [PATCHv6 iproute 2/2] Interface group as new ip link option

2007-11-23 Thread Lutz Jaenicke
On Tue, Nov 20, 2007 at 02:14:30PM +0100, Laszlo Attila Toth wrote: > Interfaces can be grouped and each group has an unique positive integer ID. > It can be set via ip link. Symbolic names can be specified in > /etc/iproute2/rt_ifgroup. > diff --git a/include/rt_names.h b/include/rt_names.h > in

Re: [PATCHv6 2/3] Interface group: core (netlink) part

2007-11-23 Thread Lutz Jaenicke
On Tue, Nov 20, 2007 at 02:14:26PM +0100, Laszlo Attila Toth wrote: > Interface groups let handle different interfaces together. > Modified net device structure and netlink interface. > > Signed-off-by: Laszlo Attila Toth <[EMAIL PROTECTED]> > --- > include/linux/if_link.h |2 ++ > include/

Re: [PATCH][UNIX] Move the unix sock iterators in to proper place

2007-11-23 Thread Pavel Emelyanov
Herbert Xu wrote: > On Thu, Nov 22, 2007 at 04:22:30PM +0300, Pavel Emelyanov wrote: >> The first_unix_socket() and next_unix_sockets() are now used >> in proc file and in forall_unix_socets macro only. >> >> The forall_unix_sockets is not used in this file at all so >> remove it. After this move t

Re: [PATCH][UNIX] Move the unix sock iterators in to proper place

2007-11-23 Thread Herbert Xu
On Thu, Nov 22, 2007 at 04:22:30PM +0300, Pavel Emelyanov wrote: > The first_unix_socket() and next_unix_sockets() are now used > in proc file and in forall_unix_socets macro only. > > The forall_unix_sockets is not used in this file at all so > remove it. After this move the helpers to where they

[PATCH net-2.6.25] [TCP]: Move FRTO checks out from write queue abstraction funcs

2007-11-23 Thread Ilpo Järvinen
Better place exists in update_send_head (other non-queue related adjustments are done there as well) which is the only caller of tcp_advance_send_head (now that the bogus call from mtu_probe is gone). Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- include/net/tcp.h |5 - net/i

Re: ZD1211RW unaligned accesses...

2007-11-23 Thread Johannes Berg
> The problem is > drivers/net/wireless/zd1211/zd_mac.c:update_qual_rssi(). > Specifically the compare_ether_addr() call I don't believe this is true. Shaddy seems to back that up by the patch not helping. > Wireless folks, I would suggest we do some auditing of the > compare_ether_addr() calls a

[PATCH] [NET]: Fix TX bug VLAN in VLAN

2007-11-23 Thread Joonwoo Park
This patch fixes http://bugzilla.kernel.org/show_bug.cgi?id=8766 Is it possible? BUG((veth->h_vlan_proto != htons(ETH_P_8021Q)) && !(VLAN_DEV_INFO(dev)->flags & VLAN_FLAG_REORDER_HDR)) I'm afraid, queued packet before vconfig set_flag would do that. Thanks. Joonwoo [NET]: Fix TX bug VLAN in V

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Evgeniy Polyakov
On Fri, Nov 23, 2007 at 12:21:57AM -0800, Andrew Morton ([EMAIL PROTECTED]) wrote: > > [2059664.615816] __iptables__: init4 IN=ppp0 OUT=ppp0 WARNING: at > > kernel/softirq.c:139 local_bh_enable() > > [2059664.620535] [<80120364>] local_bh_enable+0x3c/0x97 > > [2059664.620657] [<8011c205>] __ca

Re: [Bugme-new] [Bug 9440] New: Problem in joinning a socket to ipv6 multicast address in specific scenario

2007-11-23 Thread Evgeniy Polyakov
On Thu, Nov 22, 2007 at 05:23:42PM -0800, Andrew Morton ([EMAIL PROTECTED]) wrote: > > 3. Now i am running a program i wrote in c that opens a dgram socket > > (sock_fd[i] = socket(test_data->protocol, SOCK_DGRAM, 0);) and join it to > > multicast ipv6 address. > > if i am running this program a

cassini driver hw checksum errors with vlans

2007-11-23 Thread Laszlo Attila Toth
Hello, When we use cassini driver without VLANs, it works as expected but when about 100 VLANs are configured on this interface, the hardware checksum fails. What is its reason or how can we debug it? -- Attila - To unsubscribe from this list: send the line "unsubscribe netdev" in the body o

[PATCH 2/2] Blackfin EMAC driver: fix bug - NAT doesn't work with bfin_mac driver

2007-11-23 Thread Bryan Wu
From: Vitja Makarov <[EMAIL PROTECTED]> https://blackfin.uclinux.org/gf/project/uclinux-dist/forum/?action=ForumBrowse&forum_id=39&thread_id=23114&_forum_action=ForumMessageBrowse Today I was dealing with the same problem, on my custom bf537 board, and bfin_mac driver. I found that the problem is

[PATCH 1/2] Blackfin SMC91x Driver: punt CONFIG_BFIN -- we already have CONFIG_BLACKFIN

2007-11-23 Thread Bryan Wu
From: Mike Frysinger <[EMAIL PROTECTED]> Signed-off-by: Mike Frysinger <[EMAIL PROTECTED]> Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> --- drivers/net/Kconfig |2 +- drivers/net/smc91x.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/Kconfig b/drivers/n

[no subject]

2007-11-23 Thread Bryan Wu
- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH][IPv6] Correct the comment concerning inetsw6 table

2007-11-23 Thread Pavel Emelyanov
It seems that net/ipv6/af_inet6.c was copied from net/ipv4/af_inet.c, but one comment was not fixed. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c index 85178f7..64135e2 100644 --- a/net/ipv6/af_inet6.c +++ b/net/ipv6/af_inet6.c @@

Re: 2.6.23 WARNING: at kernel/softirq.c:139 local_bh_enable()

2007-11-23 Thread Andrew Morton
On Thu, 22 Nov 2007 19:47:35 + Simon Arlott <[EMAIL PROTECTED]> wrote: > WARN during log message being output to ttyS0 and netconsole: > > [2059664.615816] __iptables__: init4 IN=ppp0 OUT=ppp0 WARNING: at > kernel/softirq.c:139 local_bh_enable() > [2059664.620535] [<80120364>] local_bh_enab

[PATCH 7/8] ipg: naming convention fixes

2007-11-23 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> This changes some camel-case names to follow proper kernel naming convention. Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Huang <[EMAIL PROTECTED]> Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- drivers/net/i

[PATCH 8/8] ipg: fix checkpatch reported errors

2007-11-23 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Huang <[EMAIL PROTECTED]> Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- drivers/net/ipg.c | 48 +--- drivers/net/ipg.h

[PATCH 6/8] ipg: remove some internal comments

2007-11-23 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> This removes some now useless comments that were added when the driver was developed out-of-tree. Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Huang <[EMAIL PROTECTED]> Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]

[PATCH 5/8] ipg: remove commented out code

2007-11-23 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Huang <[EMAIL PROTECTED]> Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- drivers/net/ipg.c | 34 ++ drivers/net/ipg.h |4 +---

[PATCH 4/8] ipg: remove driver version

2007-11-23 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> The driver is in mainline now so there's no need to maintain a separate version number. Cc: Francois Romieu <[EMAIL PROTECTED]> Cc: Sorbica Shieh <[EMAIL PROTECTED]> Cc: Jesse Huang <[EMAIL PROTECTED]> Signed-off-by: Pekka Enberg <[EMAIL PROTECTED]> --- dri

  1   2   >