On Wednesday 14 November 2007 00:27, Adrian Bunk wrote:
> You missed the following in my email:
> "we slowly scare them away due to the many bug reports without any
> reaction."
>
> The problem is that bug reports take time. If you go away from easy
> things like compile errors then even things li
Hi Dave,
David Miller <[EMAIL PROTECTED]> wrote on 11/14/2007 11:44:39 AM:
> > You could optimize this by getting HARD_TX_LOCK after the check. I
> > assume that netif_stop_subqueue (from another CPU) would always be
> > called by the driver xmit, and that is not possible since we hold
> > the __
Hi David
Please find this patch against net-2.6.25
Thank you
[PATCH] NET : move Qdisc_class_ops and Qdisc_ops in appropriate sections
Qdisc_class_ops are const, and Qdisc_ops are mostly read.
Using "const" and "__read_mostly" qualifiers helps to reduce false sharing.
Signed-off-by: Eric Dum
David,
Please consider pulling from
inet6-2.6.25
branch at
which contains the following commits on top of your net-2.6.25 tree.
Regards,
--
HEADLINES
-
[IPV6] ADDRCONF: Rename ipv6_saddr_label() to ipv6_addr_label().
[IPV6] ADDRCONF: Allow address selection pol
Hi Dave:
[IPSEC]: Fix ip_local_out when NETFILTER is off
Thanks for testing with NETFILTER off because I obviously didn't :)
The code for ip_local_out/ip6_local_out is completely broken in
that case.
This patch fixes and also makes the IPsec path use the correct
local_out function so that the lo
On Tue, Nov 13, 2007 at 05:39:45PM -0700, Denys Vlasenko wrote:
> On Tuesday 13 November 2007 10:56, Adrian Bunk wrote:
> > On Tue, Nov 13, 2007 at 12:13:56PM -0500, Theodore Tso wrote:
> > > On Tue, Nov 13, 2007 at 04:52:32PM +0100, Benoit Boissinot wrote:
> > > > Btw, I used to test every -mm ker
Eric Dumazet said the following on 2007-11-14 13:48:
>> diff -Nurp linux-2.6.24-rc2.org/net/ipv6/raw.c
>> linux-2.6.24-rc2/net/ipv6/raw.c
>> --- linux-2.6.24-rc2.org/net/ipv6/raw.c2007-11-09
>> 16:38:05.0 +0800
>> +++ linux-2.6.24-rc2/net/ipv6/raw.c2007-11-14 09:46:54.0
>> +
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 14 Nov 2007 14:41:54 +0800
> On Tue, Nov 13, 2007 at 10:38:03PM -0800, David Miller wrote:
> >
> > We need to fix something else up first :-)
> >
> > net/ipv4/xfrm4_input.c: In function 'xfrm4_transport_finish':
> > net/ipv4/xfrm4_input.c:65: error
On Tue, Nov 13, 2007 at 10:38:03PM -0800, David Miller wrote:
>
> We need to fix something else up first :-)
>
> net/ipv4/xfrm4_input.c: In function 'xfrm4_transport_finish':
> net/ipv4/xfrm4_input.c:65: error: implicit declaration of function
> 'xfrm4_rcv_encap_finish'
> net/ipv4/xfrm4_input.c:
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 14 Nov 2007 14:36:58 +0800
> On Tue, Nov 13, 2007 at 10:33:56PM -0800, David Miller wrote:
> >
> > Also applied to net-2.6.25, thanks.
> >
> > I'll work on integrating Patrick's NF_INET_* patch next.
>
> Thanks! With that you would be able to remov
From: Nick Piggin <[EMAIL PROTECTED]>
Date: Wed, 14 Nov 2007 05:14:27 +1100
> On Wednesday 14 November 2007 17:12, David Miller wrote:
> > Is your test system using HIGHMEM?
> >
> > That's one thing the page vector in the sk_buff can do a lot,
> > kmaps.
>
> No, it's an x86-64, so no highmem.
Ok
On Tue, Nov 13, 2007 at 10:33:56PM -0800, David Miller wrote:
>
> Also applied to net-2.6.25, thanks.
>
> I'll work on integrating Patrick's NF_INET_* patch next.
Thanks! With that you would be able to remove the nf_post_routing
field from xfrm_state_afinfo.
Cheers,
--
Visit Openswan at http://
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 14 Nov 2007 14:28:34 +0800
> [IPSEC]: Add async resume support on input
>
> This patch adds support for async resumptions on input. To do so, the
> transform would return -EINPROGRESS and subsequently invoke the function
> xfrm_input_resume to resu
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 14 Nov 2007 14:27:58 +0800
> [IPSEC]: Remove nhoff from xfrm_input
>
> The nhoff field isn't actually necessary in xfrm_input. For tunnel mode
> transforms we now throw away the output IP header so it makes no sense to
> fill in the nexthdr field.
On Tue, Nov 13, 2007 at 09:46:09PM -0800, David Miller wrote:
>
> Applied to net-2.6.25
Thanks for merging Dave!
It looks like I forgot to post the last 2 patches of the series
that complete the async support for the input path. So here
they are.
[IPSEC]: Remove nhoff from xfrm_input
The nhoff
[IPSEC]: Add async resume support on input
This patch adds support for async resumptions on input. To do so, the
transform would return -EINPROGRESS and subsequently invoke the function
xfrm_input_resume to resume processing.
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
---
include/net/xfrm.h
On Wednesday 14 November 2007 17:12, David Miller wrote:
> From: Nick Piggin <[EMAIL PROTECTED]>
> Date: Wed, 14 Nov 2007 04:36:24 +1100
>
> > On Wednesday 14 November 2007 12:58, David Miller wrote:
> > > I suspect the issue is about having a huge skb->data linear area for
> > > TCP sends over loo
> > I'll work e1000e too :-)
>
> awesome, looking forward to that.
>
BTW, It seems to need Patrick's unicast patch for e1000e first.
I'll looking forward to that too.
Thanks
Joonwoo
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
M
From: Krishna Kumar <[EMAIL PROTECTED]>
Date: Wed, 14 Nov 2007 11:34:12 +0530
> Hi Peter,
>
> Peter wrote on 11/13/2007 11:14:50 PM:
> > @@ -134,7 +134,7 @@ static inline int qdisc_restart(struct net_device *dev)
> > {
> > struct Qdisc *q = dev->qdisc;
> > struct sk_buff *skb;
> > - in
From: Sam Ravnborg <[EMAIL PROTECTED]>
Date: Wed, 14 Nov 2007 06:56:06 +0100
> >
> > > If so, MANITAINERS claims that it is subscribers-only. That would cause
> > > some bug reporters to give up and go away.
> >
> > Find some other mailing list; I'm not hosting *nor* am I willing to run a
> > n
From: Nick Piggin <[EMAIL PROTECTED]>
Date: Wed, 14 Nov 2007 04:36:24 +1100
> On Wednesday 14 November 2007 12:58, David Miller wrote:
> > I suspect the issue is about having a huge skb->data linear area for
> > TCP sends over loopback. We're likely getting a much smaller
> > skb->data linear dat
Wang Chen a écrit :
Eric Dumazet said the following on 2007-11-13 19:11:
Wang Chen a écrit :
Add raw drops counter for IPv4 in /proc/net/raw .
+atomic_tsk_drops;
This doesnt need an atomic_t , just an 'unsigned int' is OK, since
sock_queue_rcv_skb() is called on a locked socket
Hi Peter,
Peter wrote on 11/13/2007 11:14:50 PM:
> @@ -134,7 +134,7 @@ static inline int qdisc_restart(struct net_device *dev)
> {
> struct Qdisc *q = dev->qdisc;
> struct sk_buff *skb;
> - int ret;
> + int ret = NETDEV_TX_BUSY;
>
> /* Dequeue packet */
> if (unlikely((skb =
On Wed, Nov 14, 2007 at 06:56:06AM +0100, Sam Ravnborg wrote:
> >
> > > If so, MANITAINERS claims that it is subscribers-only. That would cause
> > > some bug reporters to give up and go away.
> >
> > Find some other mailing list; I'm not hosting *nor* am I willing to run a
> > non-subscribers o
>
> > If so, MANITAINERS claims that it is subscribers-only. That would cause
> > some bug reporters to give up and go away.
>
> Find some other mailing list; I'm not hosting *nor* am I willing to run a
> non-subscribers only mailing list. Period. Not negotiable, so don't even
> try to change
Wang Chen a écrit :
Add raw drops counter for IPv6 in /proc/net/raw6 .
Signed-off-by: Wang Chen <[EMAIL PROTECTED]>
---
raw.c | 15 ---
1 files changed, 8 insertions(+), 7 deletions(-)
diff -Nurp linux-2.6.24-rc2.org/net/ipv6/raw.c linux-2.6.24-rc2/net/ipv6/raw.c
--- linux-2.6.24
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 19:51:19 +0800
> On Tue, Nov 13, 2007 at 03:33:48AM -0800, David Miller wrote:
> >
> > Make 'lastused' an 'unsigned long' (that's all that get_seconds()
> > gives to us anyways), fix up the nla_total_size(x->lastused) thing in
> > net/xfr
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:41 +0800
> [IPSEC]: Move state lock into x->type->input
>
> This patch releases the lock on the state before calling x->type->input.
> It also adds the lock to the spots where they're currently needed.
>
> Most of those places (al
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:40 +0800
> [IPSEC]: Move integrity stat collection into xfrm_input
>
> Similar to the moving out of the replay processing on the output,
> this patch moves the integrity stat collectin from x->type->input
> into xfrm_input.
>
> Th
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:39 +0800
> [IPSEC]: Store xfrm states in security path directly
>
> As it is xfrm_input first collects a list of xfrm states on the stack
> before storing them in the packet's security path just before it returns.
> For async crypt
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:36 +0800
> [IPSEC]: Merge most of the output path
>
> As part of the work on asynchrnous cryptographic operations, we need to
> be able to resume from the spot where they occur. As such, it helps if
> we isolate them to one spot.
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:37 +0800
> [IPSEC]: Add async resume support on output
>
> This patch adds support for async resumptions on output. To do so, the
> transform would return -EINPROGRESS and subsequently invoke the function
> xfrm_output_resume to r
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:38 +0800
> [IPSEC]: Merge most of the input path
>
> As part of the work on asynchrnous cryptographic operations, we need to
> be able to resume from the spot where they occur. As such, it helps if
> we isolate them to one spot.
>
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:33 +0800
> [IPV4]: Add ip_local_out
>
> Most callers of the LOCAL_OUT chain will set the IP packet length
> and header checksum before doing so. They also share the same output
> function dst_output.
>
> This patch creates a new
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:34 +0800
> [IPV6]: Add ip6_local_out
>
> Most callers of the LOCAL_OUT chain will set the IP packet length
> before doing so. They also share the same output function dst_output.
>
> This patch creates a new function called ip6_l
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:32 +0800
> [IPSEC]: Separate inner/outer mode processing on input
>
> With inter-family transforms the inner mode differs from the outer mode.
> Attempting to handle both sides from the same function means that it
> needs to handle
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:30 +0800
> [INET]: Give outer DSCP directly to ip*_copy_dscp
>
> This patch changes the prototype of ipv4_copy_dscp and ipv6_copy_dscp so
> that they directly take the outer DSCP rather than the outer IP header.
> This will help us
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:31 +0800
> [IPSEC]: Separate inner/outer mode processing on output
>
> With inter-family transforms the inner mode differs from the outer mode.
> Attempting to handle both sides from the same function means that it
> needs to handl
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:29 +0800
> [IPSEC]: Move x->outer_mode->output out of locked section
>
> RO mode is the only one that requires a locked output function. So it's
> easier to move the lock into that function rather than requiring everyone
> else to
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:28 +0800
> [IPSEC]: Forbid BEET + ipcomp for now
>
> While BEET can theoretically work with IPComp the current code can't do that
> because it tries to construct a BEET mode tunnel type which doesn't (and
> cannot) exist. In fact
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:26 +0800
> [IPSEC]: Move flow construction into xfrm_dst_lookup
>
> This patch moves the flow construction from the callers of xfrm_dst_lookup
> into that function. It also changes xfrm_dst_lookup so that it takes an
> xfrm state
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:27 +0800
> [IPSEC]: Merge common code into xfrm_bundle_create
>
> Half of the code in xfrm4_bundle_create and xfrm6_bundle_create are common.
> This patch extracts that logic and puts it into xfrm_bundle_create. The
> rest of it a
On Wednesday 14 November 2007 12:58, David Miller wrote:
> From: Nick Piggin <[EMAIL PROTECTED]>
> Date: Tue, 13 Nov 2007 22:41:58 +1100
>
> > On Tuesday 13 November 2007 06:44, Christoph Lameter wrote:
> > > On Sat, 10 Nov 2007, Nick Piggin wrote:
> > > > BTW. your size-2048 kmalloc cache is order
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:25 +0800
> [IPSEC]: Replace x->type->{local,remote}_addr with flags
>
> The functions local_addr and remote_addr are more than what they're needed
> for. The same thing can be done easily with flags on the type object.
> This patc
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:24 +0800
> [IPSEC]: Make sure idev is consistent with dev in xfrm_dst
>
> Previously we took the device from the bottom route and idev from the top
> route. This is bad because idev may well point to a different device.
> This pat
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:23 +0800
> [IPSEC]: Set dst->input to dst_discard
>
> The input function should never be invoked on IPsec dst objects. This is
> because we don't apply IPsec on input until after we've made the routing
> decision.
>
> Signed-off-
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:21 +0800
> [NET]: Remove unnecessary inclusion of dst.h
>
> The file net/netevent.h only refers to struct dst_entry * so it doesn't
> need to include dst.h. I've replaced it with a forward declaration.
>
> Signed-off-by: Herbert
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:22 +0800
> [IPSEC]: Only set neighbour on top xfrm dst
>
> The neighbour field is only used by dst_confirm which only ever happens on
> the top-most xfrm dst. So it's a waste to duplicate for every other xfrm
> dst. This patch mo
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:20 +0800
> [NET]: Eliminate duplicate copies of dst_discard
>
> We have a number of copies of dst_discard scattered around the place which
> all do the same thing, namely free a packet on the input or output paths.
>
> This patch
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:19 +0800
> [IPV6]: Move nfheader_len into rt6_info
>
> The dst member nfheader_len is only used by IPv6. It's also currently
> creating a rather ugly alignment hole in struct dst. Therefore this patch
> moves it from there into s
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:18 +0800
> [IPSEC]: Use dst->header_len when resizing on output
>
> Currently we use x->props.header_len when resizing on output. However,
> if we're resizing at all we might as well go the whole hog and do it
> for the whole dst.
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Wed, 07 Nov 2007 22:08:16 +0800
> [IPV6]: Only set nfheader_len for top xfrm dst
>
> We only need to set nfheader_len in the top xfrm dst. This is because
> we only ever read the nfheader_len from the top xfrm dst.
>
> It is also easier to count nfhead
(plesae respond via emailed reply-to-all)
On Tue, 13 Nov 2007 20:48:44 -0800 (PST) [EMAIL PROTECTED] wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=9375
>
>Summary: divide error: [#1] with VIA Velocity when unplugged
>Product: Other
>Version: 2.5
>
From: Jay Vosburgh <[EMAIL PROTECTED]>
Date: Mon, 12 Nov 2007 18:15:36 -0800
> Fix bond_destroy and bond_free_all to not reference the
> struct net_device after calling unregister_netdevice.
>
> Bug and offending change reported by Moni Shoua <[EMAIL PROTECTED]>
>
> Signed-off-by: Ja
From: Olof Johansson <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 01:23:13 -0600
> As seen when booting ppc64_defconfig:
>
> sysctl table check failed: /net/token-ring .3.14 procname does not match
> binary path procname
>
>
> Signed-off-by: Olof Johansson <[EMAIL PROTECTED]>
Patch applied, tha
From: "Arnaldo Carvalho de Melo" <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 11:43:40 -0200
> Em Tue, Nov 13, 2007 at 05:34:21AM -0800, David Miller escreveu:
> > From: Pavel Emelyanov <[EMAIL PROTECTED]>
> > Date: Tue, 13 Nov 2007 16:10:03 +0300
> >
> > > Many-many code in the kernel initialized
From: Eric Dumazet <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 14:41:19 +0100
> I discovered one other incorrect use of .tv64 (coming from me, I must
> confess)
>
> I guess this patch is needed for 2.6.24 and stable (2.6.22 & 2.6.23)
...
> [NET] random : secure_tcp_sequence_number should not as
Joonwoo Park wrote:
> 2007/11/14, Kok, Auke <[EMAIL PROTECTED]>:
>> Patrick McHardy wrote:
>>> Kok, Auke wrote:
Patrick McHardy wrote:
> I already posted a patch for this, not sure what happened to it.
> Auke, any news on merging the secondary unicast address support?
I dropp
From: Zhu Yi <[EMAIL PROTECTED]>
Date: Wed, 14 Nov 2007 09:30:54 +0800
>
> On Tue, 2007-11-13 at 19:26 +0100, Oliver Neukum wrote:
> > It makes no sense to enable interrupts if a device has been unplugged.
> > In addition if in doubt IRQ_HANDLED should be returned.
> >
> > Signed-off-by: Oliver
David Miller wrote:
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 12:53:12 -0800
On Fri, 09 Nov 2007 16:35:59 -0800
osprey67 <[EMAIL PROTECTED]> wrote:
From: Fred L. Templin <[EMAIL PROTECTED]>
This message attaches the combined diffs from
messages 01/05 through
From: Jochen Friedrich <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 19:32:08 +0100
> If fs_enet is build as module, on PPC_CPM_NEW_BINDING platforms
> mii-fec/mii-bitbang should be build as module, as well. On other
> platforms, mii-fec/mii-bitbang must be included into the main module.
> Otherwise
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 12:53:12 -0800
> On Fri, 09 Nov 2007 16:35:59 -0800
> osprey67 <[EMAIL PROTECTED]> wrote:
>
> > From: Fred L. Templin <[EMAIL PROTECTED]>
> >
> > This message attaches the combined diffs from
> > messages 01/05 through 04/05. Thi
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 23:35:39 +0200 (EET)
> [PATCH] [TCP] FRTO: Plug potential LOST-bit leak
>
> It might be possible that, in some extreme scenario that
> I just cannot now construct in my mind, end_seq <=
> frto_highmark check does not match causing t
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Wed, 14 Nov 2007 00:08:18 +0200 (EET)
>
> Otherwise TCP might violate packet ordering principles that FRTO
> is based on. If conventional recovery path is chosen, this won't
> be significant at all. In practice, any small enough value will
> be suff
From: Auke Kok <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 15:11:38 -0800
> From: Jesse Brandeburg <[EMAIL PROTECTED]>
>
> mii-tool can cause the driver to call msleep during nway reset,
> bugzilla.kernel.org bug 8430. Fix by simply calling reinit_locked
> outside of the spinlock, which is safe f
From: Auke Kok <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 15:11:33 -0800
> From: Patrick McHardy <[EMAIL PROTECTED]>
>
> Add support for configuring secondary unicast addresses. Unicast
> addresses take precendece over multicast addresses when filling
> the exact address filters to avoid going to
From: Auke Kok <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 15:11:28 -0800
> From: Joe Perches <[EMAIL PROTECTED]>
>
> Add functions for reg_pattern_test and reg_set_and check
> Changed macros to use these functions
>
> Compiled x86, untested
>
> Size decreased ~2K
>
> old:
>
> $ size drivers/n
David Miller said the following on 2007-11-14 12:31:
> From: Wang Chen <[EMAIL PROTECTED]>
> Date: Wed, 14 Nov 2007 11:15:57 +0800
>
>> Add raw drops counter for IPv6 in /proc/net/raw6 .
>>
>> Signed-off-by: Wang Chen <[EMAIL PROTECTED]>
>
> Applied to net-2.6.25, but again more whitespace proble
From: Auke Kok <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 15:11:23 -0800
> Minimal macro to function conversion in e1000_ethtool.c
>
> Adds functions reg_pattern_test and reg_set_and_check
> Changes REG_PATTERN_TEST and REG_SET_AND_CHECK macros
> to call these functions.
>
> Saves ~2.5KB
>
> Co
From: Auke Kok <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 15:11:17 -0800
> formerly e1000/e1000e only updated traffic counters once every
> 2 seconds with the register values of bytes/packets. With newer
> code however in the interrupt and polling code we can real-time
> fill in these values in th
From: Auke Kok <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 15:11:10 -0800
> formerly e1000/e1000e only updated traffic counters once every
> 2 seconds with the register values of bytes/packets. With newer
> code however in the interrupt and polling code we can real-time
> fill in these values in th
2007/11/14, Kok, Auke <[EMAIL PROTECTED]>:
> Patrick McHardy wrote:
> > Kok, Auke wrote:
> >> Patrick McHardy wrote:
> >>
> >>> I already posted a patch for this, not sure what happened to it.
> >>> Auke, any news on merging the secondary unicast address support?
> >>
> >> I dropped the ball on tha
From: PJ Waskiewicz <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 09:44:50 -0800
> The only qdiscs that check subqueue state before dequeue'ing are PRIO
> and RR. The other qdiscs, including the default pfifo_fast qdisc, will
> allow traffic bound for subqueue 0 through to hard_start_xmit. The chec
From: Hideo AOKI <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 21:39:18 -0500
> I updated UDP memory accounting and limitation patch set.
I'm dropping this for now, please resubmit after the expensive
divide is fixed.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of
From: Wang Chen <[EMAIL PROTECTED]>
Date: Wed, 14 Nov 2007 11:15:57 +0800
> Add raw drops counter for IPv6 in /proc/net/raw6 .
>
> Signed-off-by: Wang Chen <[EMAIL PROTECTED]>
Applied to net-2.6.25, but again more whitespace problems:
Adds trailing whitespace.
diff:9: atomic_inc(&sk->sk
From: Wang Chen <[EMAIL PROTECTED]>
Date: Wed, 14 Nov 2007 11:12:18 +0800
> Add raw drops counter for IPv4 in /proc/net/raw .
>
> Signed-off-by: Wang Chen <[EMAIL PROTECTED]>
Applied to net-2.6.25, but your patch a lot of whitespace
problems:
Adds trailing whitespace.
diff:9: * @sk_flags:
From: Andy Gospodarek <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 22:22:56 -0500
> On Tue, Nov 13, 2007 at 06:58:53PM -0800, Jay Vosburgh wrote:
> >
> > Update the bonding documentation: more discussion on
> > initialization and configuration, changes to discussion of packet
> > reordering in
Starting now I am going to be very strict about patches
for 2.6.24
This means:
1) No cleanups
2) No symbol report removals
3) No bug fixes with cleanups attached
4) No code refactoring
5) No code consolidation
6) No whitespace removals
And I really mean it.
It has to fix a bug and it has to do
From: Hideo AOKI <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 22:27:13 -0500
> Herbert Xu wrote:
> > On Mon, Oct 29, 2007 at 05:23:10PM -0400, Hideo AOKI wrote:
> >>
> >> +#define SK_DATAGRAM_MEM_QUANTUM ((int)PAGE_SIZE)
> >> +
> >> +static inline int sk_datagram_pages(int amt)
> >> +{
> >> + ret
From: Andrew Morton <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 18:27:00 -0800
> Let me just say - I'm astonished at how little spam gets though the vger
> lists. Considering how many times those email addresses must have been
> added to spam databases.
>
> It must be a lot of work, and whoever i
On Tue, Nov 13, 2007 at 10:27:13PM -0500, Hideo AOKI wrote:
>
> Herbert Xu wrote:
> >>
> >>+#define SK_DATAGRAM_MEM_QUANTUM ((int)PAGE_SIZE)
> >>+
> >>+static inline int sk_datagram_pages(int amt)
> >>+{
> >>+ return DIV_ROUND_UP(amt, SK_DATAGRAM_MEM_QUANTUM);
> >>+}
> >
> >Does this really hav
On Tue, Nov 13, 2007 at 06:58:53PM -0800, Jay Vosburgh wrote:
>
> Update the bonding documentation: more discussion on
> initialization and configuration, changes to discussion of packet
> reordering in balance-rr, update some out of date information.
>
> Based in part on input from R
Hello,
Herbert Xu wrote:
On Mon, Oct 29, 2007 at 05:23:10PM -0400, Hideo AOKI wrote:
+#define SK_DATAGRAM_MEM_QUANTUM ((int)PAGE_SIZE)
+
+static inline int sk_datagram_pages(int amt)
+{
+ return DIV_ROUND_UP(amt, SK_DATAGRAM_MEM_QUANTUM);
+}
Does this really have to be int? Unsigned w
Hello,
I'm sorry that my response is always late.
Herbert Xu wrote:
On Mon, Oct 29, 2007 at 05:22:53PM -0400, Hideo AOKI wrote:
This patch introduces sndbuf size check before memory allocation for
send buffer.
Looks good, what about IPv6?
I'm going to develop IPv6 part if IPv4 patch set is
Add raw drops counter for IPv6 in /proc/net/raw6 .
Signed-off-by: Wang Chen <[EMAIL PROTECTED]>
---
raw.c | 15 ---
1 files changed, 8 insertions(+), 7 deletions(-)
diff -Nurp linux-2.6.24-rc2.org/net/ipv6/raw.c linux-2.6.24-rc2/net/ipv6/raw.c
--- linux-2.6.24-rc2.org/net/ipv6/raw.
This panic happens (almost?) immediately after starting TCP traffic between
the cxgb nic on this system and another. We also got at least one crash
on a custom/tainted 2.6.20.12 kernel, but it would run for at least
a few minutes at ~1Gbps first.
I think my serial console chomped some of this..b
Add raw drops counter for IPv4 in /proc/net/raw .
Signed-off-by: Wang Chen <[EMAIL PROTECTED]>
---
include/net/sock.h | 11 ---
net/core/sock.c|1 +
net/ipv4/raw.c | 17 ++---
3 files changed, 19 insertions(+), 10 deletions(-)
diff -Nurp linux-2.6.24-rc2.org/i
Update the bonding documentation: more discussion on
initialization and configuration, changes to discussion of packet
reordering in balance-rr, update some out of date information.
Based in part on input from Rick Jones <[EMAIL PROTECTED]> and
Andy Gospodarek <[EMAIL PROTECTED]>.
This patch introduces memory limitation for UDP.
signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]>
signed-off-by: Hideo Aoki <[EMAIL PROTECTED]>
---
Documentation/networking/ip-sysctl.txt |6
include/net/udp.h |3 ++
net/ipv4/af_inet.c |
This patch added /proc/sys/net/ipv4/udp_rmem_min and
/proc/sys/net/ipv4/udp_rmem_min. Each UDP packet is drooped when the
number of pages for socket buffer is beyond the limit and the socket
already consumes minimum buffer.
Cc: Satoshi Oshima <[EMAIL PROTECTED]>
signed-off-by: Hideo Aoki <[EMAIL
This patch introduces global variable for UDP memory accounting.
The unit is page.
signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]>
signed-off-by: Hideo Aoki <[EMAIL PROTECTED]>
---
include/net/sock.h |7 +++
include/net/udp.h |2 ++
net/ipv4/proc.c|3 ++-
net/ipv4/udp.c
This patch adds UDP memory usage accounting in IPv4.
signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]>
signed-off-by: Hideo Aoki <[EMAIL PROTECTED]>
---
af_inet.c | 30 +-
ip_output.c | 25 ++---
udp.c |9 +
3 files changed
This patch introduces sndbuf size check before memory allocation for
send buffer.
signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]>
signed-off-by: Hideo Aoki <[EMAIL PROTECTED]>
---
ip_output.c |5 +
1 file changed, 5 insertions(+)
diff -pruN net-2.6/net/ipv4/ip_output.c net-2.6-udp-p1
Hello,
I updated UDP memory accounting and limitation patch set.
According to comments against previous take, I renamed udp_[rw]mem to
udp_[rw]mem_min. This patch set is for net-2.6.
Changelog take 6 -> take 7:
* renamed /proc/sys/net/ipv4/udp_rmem to
/proc/sys/net/ipv4/udp_rmem_min
* ren
On Tue, 13 Nov 2007 17:55:51 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote:
> I've created [EMAIL PROTECTED]
Let me just say - I'm astonished at how little spam gets though the vger
lists. Considering how many times those email addresses must have been
added to spam databases.
It must be a
On Tue, 2007-11-13 at 18:04 -0800, Joe Perches wrote:
> Remove defconfig ptr comparison to 0
>
> Remove sparse warning: Using plain integer as NULL pointer
>
> Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
>
Acked-by: Michael Chan <[EMAIL PROTECTED]>
Thanks.
-
To unsubscribe from this list:
On Tue, 13 Nov 2007 17:11:36 -0800 Stephen Hemminger <[EMAIL PROTECTED]> wrote:
> On Tue, 13 Nov 2007 19:52:17 -0500
> Chuck Ebbert <[EMAIL PROTECTED]> wrote:
>
> > On 11/13/2007 04:12 PM, Alan Cox wrote:
> > >> Bug fixing is not about finding someone to blame, it's about getting the
> > >> bug
Remove defconfig ptr comparison to 0
Remove sparse warning: Using plain integer as NULL pointer
Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
---
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index 76be83e..1600df2 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -157,7 +157,7 @@
Remove defconfig ptr comparison to 0
Remove sparse warning: Using plain integer as NULL pointer
Signed-off-by: Joe Perches <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index da767d3..cec3cb4 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -2495,7 +249
From: Nick Piggin <[EMAIL PROTECTED]>
Date: Tue, 13 Nov 2007 22:41:58 +1100
> On Tuesday 13 November 2007 06:44, Christoph Lameter wrote:
> > On Sat, 10 Nov 2007, Nick Piggin wrote:
> > > BTW. your size-2048 kmalloc cache is order-1 in the default setup,
> > > wheras kmalloc(1024) or kmalloc(4096)
1 - 100 of 318 matches
Mail list logo
