Re: [2.6 patch] net/ipv4/ipvs/: remove unused exports

2007-11-11 Thread Adrian Bunk
On Sun, Nov 11, 2007 at 04:09:40PM +0900, Simon Horman wrote: > On Sun, Nov 11, 2007 at 07:48:40AM +0100, Adrian Bunk wrote: > > This patch removes the following unused EXPORT_SYMBOL's: > > - ip_vs_try_bind_dest > > - ip_vs_find_dest > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > Look

[PATCH] - in.h - IP4_ADDR

2007-11-11 Thread Joe Perches
Add inline functions to in.h that make the IP4 address tests a bit easier to read and also add some type safety. gcc optimizes IP4_ADDR to a constant (O2 or Os) Signed-off-by: Joe Perches <[EMAIL PROTECTED] --- include/linux/in.h | 75 --- 1 fi

[PATCH] Fix memory leak in discard case of sctp_sf_abort_violation()

2007-11-11 Thread Jesper Juhl
From: Jesper Juhl <[EMAIL PROTECTED]> In net/sctp/sm_statefuns.c::sctp_sf_abort_violation() we may leak the storage allocated for 'abort' by returning from the function without using or freeing it. This happens in case "sctp_auth_recv_cid(SCTP_CID_ABORT, asoc)" is true and we jump to the 'disc

Re : Oops preceded by WARNING: at net/ipv4/tcp_input.c:1571 tcp_remove_reno_sacks()

2007-11-11 Thread Ilpo Järvinen
On Sun, 11 Nov 2007, Chazarain Guillaume wrote: > > Do you have GSO enabled? > > According to ethtool -k, no. Ok, thanks, it excludes lot of possibilities... > > Is this reproducable? > > Unfortunately not, I saw it only once. The messages you had in the other mail are very likely symptom of th

Re: [PATCH] NET: Add the helper kernel_sock_shutdown()

2007-11-11 Thread Mark Fasheh
On Sun, Nov 11, 2007 at 01:40:14PM -0500, Trond Myklebust wrote: > > On Sun, 2007-11-11 at 10:03 -0800, Mark Fasheh wrote: > > That looks pretty good - any objection to naming the enum and using that > > name in the prototype for kernel_sock_shutdown() so it's even more obvious > > what type of sh

Re: [Bugme-new] [Bug 9349] New: RTNLGRP_ND_USEROPT does not report ifindex

2007-11-11 Thread Andrew Morton
On Sun, 11 Nov 2007 10:52:41 -0800 (PST) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9349 > >Summary: RTNLGRP_ND_USEROPT does not report ifindex >Product: Networking >Version: 2.5 > KernelVersion: 2.6.24-rc > Platform: A

Re: [PATCH] NET: Add the helper kernel_sock_shutdown()

2007-11-11 Thread Trond Myklebust
On Sun, 2007-11-11 at 10:03 -0800, Mark Fasheh wrote: > On Thu, Nov 08, 2007 at 07:01:36PM -0500, Trond Myklebust wrote: > > From: Trond Myklebust <[EMAIL PROTECTED]> > > > > ...and fix a couple of bugs in the NBD, CIFS and OCFS2 socket handlers. > > > > Looking at the sock->op->shutdown() handl

Re: [PATCH] NET: Add the helper kernel_sock_shutdown()

2007-11-11 Thread Mark Fasheh
On Thu, Nov 08, 2007 at 07:01:36PM -0500, Trond Myklebust wrote: > From: Trond Myklebust <[EMAIL PROTECTED]> > > ...and fix a couple of bugs in the NBD, CIFS and OCFS2 socket handlers. > > Looking at the sock->op->shutdown() handlers, it looks as if all of them > take a SHUT_RD/SHUT_WR/SHUT_RDWR

DaveM collecting netdev patches this week

2007-11-11 Thread Jeff Garzik
I'm about to disappear (virtually) through Friday for vacation. David Miller has agreed to collect net driver bug fix patches in my absence, with Stephen and Francois (and others, hopefully) helping out with patch review. David -- note that my 2.6.25 was opened a little while ago. If you fee

Re : Oops preceded by WARNING: at net/ipv4/tcp_input.c:1571 tcp_remove_reno_sacks()

2007-11-11 Thread Chazarain Guillaume
Hi, > I'm currently running bittorrent with all of this, I just saw this (for the first time ever), > but otherwise it works fine: > > WARNING: at net/ipv4/tcp_output.c:1807 tcp_simple_retransmit() > [] show_trace_log_lvl+0x1a/0x2f > [] show_trace+0x12/0x14 > [] dump_stack+0x15/0x17 > [] tcp

Re: drivers/net/ax88796.c compile error on sh64

2007-11-11 Thread Paul Mundt
On Sun, Nov 11, 2007 at 10:06:21AM +0100, Adrian Bunk wrote: > Commit 8687991a734a67f1638782c968f46fff0f94bb1f causes the following > compile error on sh64: > > <-- snip --> > > ... > CC [M] drivers/net/ax88796.o > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/ax88796.c: In function

drivers/net/ax88796.c compile error on sh64

2007-11-11 Thread Adrian Bunk
Commit 8687991a734a67f1638782c968f46fff0f94bb1f causes the following compile error on sh64: <-- snip --> ... CC [M] drivers/net/ax88796.o /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/ax88796.c: In function 'ax_get_8390_hdr': /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/ax

Re: [2.6 patch] net/ipv4/ipvs/: remove unused exports

2007-11-11 Thread Simon Horman
On Sun, Nov 11, 2007 at 07:48:40AM +0100, Adrian Bunk wrote: > This patch removes the following unused EXPORT_SYMBOL's: > - ip_vs_try_bind_dest > - ip_vs_find_dest > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Looks fine to me. Should Dave Miller put this in his tree, or do you want to hand