Hello netdev,
Andrew McDonald kindly fixed the description of IPV6_ROUTER_ALERT in the
ipv7.7 man page. As long as we're on the topic, I'll point out that the
following IPV6 options (and possibly others) are still not documented on
that page:
IPV6_CHECKSUM
IPV6_JOIN_ANYCAST
IPV6_LEAVE_ANYCAST
IP
Hello Andrew,
> I discovered that the current description of the IPV6_ROUTER_ALERT
> sockopt in ipv6.7 is significantly wrong. A patch to fix the
> description is below. I sent a version of this earlier in the year to
> [EMAIL PROTECTED], but nothing happened with it at the time.
Hmmm -- somehow
Herbert Xu wrote:
On Sun, Sep 30, 2007 at 05:38:28PM +0200, Patrick McHardy wrote:
>From a quick look it seems at least IPv4 and IPv6 don't need to
change the skb anywhere else. It seems to be necessary for
bridging though to unshare the skb. OTOH br_netfilter.c already
unshares the skb for IPv4
Took off linux-man from cc:,
On Sun, 14 Oct 2007, Andrew McDonald wrote:
+The tapped packets are not forwarded by the kernel, it is the
+user's responsibility to send them out again.
This is probably incompliant (and from users' perspective,
unacceptible) behaviour that IMHO should be fixed.
On Mon, Oct 15, 2007 at 12:57:23PM +0800, Herbert Xu wrote:
>
> However, the fact that you're triggering this code at all tells
> us that there is another bug further up the chain that's causing
> us to generate partial checksums even though the NIC doesn't
> support it. Can you please give me th
the OPEN_MAX define was removed from the kernel's limits.h during the 2.6.23
development cycle, so switching to using the dynamic sysconf() func should be
done
-mike
signature.asc
Description: This is a digitally signed message part.
the OPEN_MAX define has been removed in newer kernel headers
On Sun, Oct 14, 2007 at 08:20:37PM +, Guillaume Chazarain wrote:
>
> Just another data point, it seems that running the standard Bittorrent
> client helps triggering the bug.
Doh! It was my patch a month ago which added code to update
csum_start if the headroom changed that broke this.
We'll
Hi,
>> Mon, 15 Oct 2007 11:45:10 +0900
>> [Subject: Re: [2.6 patch] __inet6_csk_dst_store(): fix check-after-use]
>> Masahide NAKAMURA <[EMAIL PROTECTED]> wrote...
>
> On Sun, 14 Oct 2007 19:52:12 +0200
> Adrian Bunk <[EMAIL PROTECTED]> wrote:
>
> > The Coverity checker spotted that we have alr
On Sun, 14 Oct 2007 19:52:12 +0200
Adrian Bunk <[EMAIL PROTECTED]> wrote:
> The Coverity checker spotted that we have already oops'ed if "dst"
> was NULL.
>
> Since "dst" being NULL doesn't seem to be possible at this point this
> patch removes the NULL check.
>
> Signed-off-by: Adrian Bunk <[
This will convert remaining non-obvious or naive calculations of array
sizes to use ARRAY_SIZE() macro.
Signed-off-by: Alejandro Martinez Ruiz <[EMAIL PROTECTED]>
---
drivers/net/cassini.c |2 +-
drivers/net/irda/donauboe.c |2 +-
drivers/net/ne-h8300.c |4 ++--
drivers/ne
On Sun, 2007-10-14 at 16:15 -0700, Yinghai Lu wrote:
> On 10/14/07, Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
> >
> > On Sun, 2007-10-14 at 09:15 +0200, Manfred Spraul wrote:
> > > Yinghai Lu wrote:
> > > > On 10/13/07, Manfred Spraul <[EMAIL PROTECTED]> wrote:
> > > >
> > > >> Someone aro
On 10/14/07, Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
>
> On Sun, 2007-10-14 at 09:15 +0200, Manfred Spraul wrote:
> > Yinghai Lu wrote:
> > > On 10/13/07, Manfred Spraul <[EMAIL PROTECTED]> wrote:
> > >
> > >> Someone around with a MSI capable board? The forcedeth driver does
> > >> d
Jesper Juhl <[EMAIL PROTECTED]> writes:
> From: Jesper Juhl <[EMAIL PROTECTED]>
> Subject: Don't leak 'listeners' in netlink_kernel_create()
>
> The Coverity checker spotted that we'll leak the storage allocated
> to 'listeners' in netlink_kernel_create() when the
> if (!nl_table[unit].register
On 10/14/07, Domen Puncer <[EMAIL PROTECTED]> wrote:
> PHY part of the driver for mpc5200(b) ethernet.
Assuming I understand correctly, this comment is not correct and this
patch just adds an MDIO bus driver. PHY drivers are in phylib and
data transfer is setup via the core driver, correct?
It i
On Sun, 2007-10-14 at 09:15 +0200, Manfred Spraul wrote:
> Yinghai Lu wrote:
> > On 10/13/07, Manfred Spraul <[EMAIL PROTECTED]> wrote:
> >
> >> Someone around with a MSI capable board? The forcedeth driver does
> >> dev->irq = pci_dev->irq
> >> in nv_probe(), especially before pci_enable_m
On 10/14/07, Domen Puncer <[EMAIL PROTECTED]> wrote:
> Driver for ethernet on mpc5200/mpc5200b SoCs (FEC).
>
>
> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
Looks quite good to me. Comments below...
>
> ---
> drivers/net/Kconfig |1
> drivers/net/Makefile |1
Le Sun, 14 Oct 2007 19:26:40 +0200,
Guillaume Chazarain <[EMAIL PROTECTED]> a écrit :
> #0 0xc02c9d5e in skb_checksum_help (skb=0xe218dcb0) at net/core/dev.c:1372
> 1372BUG_ON(offset > (int)skb->len);
Just another data point, it seems that running the standard Bittorrent
client helps
On 10/14/07, Manfred Spraul <[EMAIL PROTECTED]> wrote:
> Yinghai Lu wrote:
> > On 10/13/07, Manfred Spraul <[EMAIL PROTECTED]> wrote:
> >
> >> Someone around with a MSI capable board? The forcedeth driver does
> >> dev->irq = pci_dev->irq
> >> in nv_probe(), especially before pci_enable_msi().
The Coverity checker spotted that we have already oops'ed if "dst"
was NULL.
Since "dst" being NULL doesn't seem to be possible at this point this
patch removes the NULL check.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
eeb6009cf3ef5f6993ced359330d877680617a70
diff --git a/net/ipv6/ine
You want to check for the value, not for the address.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
--- a/drivers/net/e1000e/ethtool.c
+++ b/drivers/net/e1000e/ethtool.c
@@ -1451,11 +1451,11 @@ static int e1000_loopback_test(struct e1000_adapter
*adapter, u
The Coverity checker spotted the following in drivers/net/niu.c:
<-- snip -->
...
static int __devinit niu_pci_probe_sprom(struct niu *np)
{
...
val = nr64(ESPC_MOD_STR_LEN);
niudbg(PROBE, "SPROM: MOD_STR_LEN[%llu]\n",
(unsigned long long) val);
if (val >
On Sun, 14 Oct 2007 15:35:55 +0900, Yoichi Yuasa <[EMAIL PROTECTED]> wrote:
> Remove redefinition of lp in tc35815.c.
>
> drivers/net/tc35815.c: In function 'tc35815_interrupt':
> drivers/net/tc35815.c:1464: error: redefinition of 'lp'
> drivers/net/tc35815.c:1443: error: previous definition of 'l
New version which uses less locking and drops old API
Signed-off-by: Matteo Croce <[EMAIL PROTECTED]>
Signed-off-by: Eugene Konev <[EMAIL PROTECTED]>
Signed-off-by: Felix Fietkau <[EMAIL PROTECTED]>
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index e412582..5ab5d5b 100644
--- a/drivers
Roland Dreier wrote:
> > It happens only when ib interfaces are slaves of a bonding device.
> > I thought before that the stuck is in napi_disable() but it's almost right.
> > I put prints before and after call to napi_disable and see that it is
> called twice.
> > I'll try to investigate in t
Herbert,
I really appreciate this work.
Thank you!
--yoshfuji
In article <[EMAIL PROTECTED]> (at Sun, 14 Oct 2007 22:49:05 +0800), Herbert Xu
<[EMAIL PROTECTED]> says:
> [IPV6]: Replace sk_buff ** with sk_buff * in input handlers
>
> With all the users of the double pointers removed from the
[IPV6]: Replace sk_buff ** with sk_buff * in input handlers
With all the users of the double pointers removed from the IPv6 input path,
this patch converts all occurances of sk_buff ** to sk_buff * in IPv6 input
handlers.
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
---
include/net/ipv6.h
[IPV6]: Make ipv6_frag_rcv return the same packet
This patch implements the same change taht was done to ip_defrag. It
makes ipv6_frag_rcv return the last packet received of a train of fragments
rather than the head of that sequence.
This allows us to get rid of the sk_buff ** argument later.
S
[IPV6]: Avoid skb_copy/pskb_copy/skb_realloc_headroom on input
This patch replaces unnecessary uses of skb_copy by pskb_expand_head
on the IPv6 input path.
This allows us to remove the double pointers later.
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
---
net/ipv6/exthdrs.c | 23 +-
On Sun, Oct 14, 2007 at 05:55:41PM +0800, Herbert Xu wrote:
>
> [NETFILTER]: Replace sk_buff ** with sk_buff *
Following on from that work, I've done the same thing to the
IPv6 input path.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home
Hi,
I discovered that the current description of the IPV6_ROUTER_ALERT
sockopt in ipv6.7 is significantly wrong. A patch to fix the
description is below. I sent a version of this earlier in the year to
[EMAIL PROTECTED], but nothing happened with it at the time.
The correction is based on reading
Bill Fink wrote:
> I believe the user wanted to bond an eth1394 interface with a normal
> Ethernet interface, and I don't think that will work even with the
> IPoIB bonding changes, since bonding of different fundamental types
> of network interfaces still won't be supported, and I'm pretty sure
>
On Sat, 13 Oct 2007, Ismail Dönmez wrote:
> input: Microsoft Microsoft? Wireless Notebook Presenter Mouse 8000 as
> /devices/pci:00/:00:1d.1/usb3/3-1/3-1.3/3-1.3:1.0/input/input12
> input: USB HID v1.11 Mouse [Microsoft Microsoft? Wireless Notebook
> Presenter Mouse 8000] on usb-:00
On Sun, 2007-14-10 at 12:27 +0800, Herbert Xu wrote:
> [NET]: Avoid unnecessary cloning for ingress filtering
>
> As it is we always invoke pt_prev before ing_filter, even if there are no
> ingress filters attached. This can cause unnecessary cloning in pt_prev.
>
> This patch changes it so that
Ilpo Järvinen wrote:
> Willy Tarreau wrote:
> > I agree with this. The impression I got from the description of the two
> > patches I merged was that the problems they fix were quite annoying. But
> > maybe I should take that with a grain of salt.
>
> No, it's not a grain of salt. I would say its u
On Sun, 2007-14-10 at 12:27 +0800, Herbert Xu wrote:
> In fact the tc_verd stuff is almost certainly a bug since it's treated
> differently in skb_clone compared to the callers of copy_skb_header
> (skb_copy/pskb_copy/skb_copy_expand).
>
> I've kept that difference in tact with a comment added a
Jean Delvare <[EMAIL PROTECTED]> wrote:
>
>> inet_diag is the preferred interface.
>
> How does it work? Is there some documentation available? I see
> net/ipv4/inet_diag.c but I have no idea how to use it.
Have a look at the iproute package. It contains the ss command
which provides a command-l
Hi Herbert,
On Sat, 13 Oct 2007 20:49:56 +0800, Herbert Xu wrote:
> Jean Delvare <[EMAIL PROTECTED]> wrote:
> >
> > I didn't know that, sorry. What is the new interface to access the
> > TCP information?
>
> inet_diag is the preferred interface.
How does it work? Is there some documentation avai
Hi David,
On Sunday 14 October 2007, David Miller wrote:
> From: KOVACS Krisztian <[EMAIL PROTECTED]>
> Date: Sat, 13 Oct 2007 19:28:57 +0200
>
> > This is the fifth round of transparent proxying patches following
> > recent discussion on netfilter-devel [1,2].
> >
> > The aim of the patchset is t
> -Original Message-
> From: Florin Malita [mailto:[EMAIL PROTECTED]
>
> If pci_enable_device fails, bdx_probe returns without freeing the
> allocated pci_nic structure.
>
> Coverity CID 1908.
>
> Signed-off-by: Florin Malita <[EMAIL PROTECTED]>
Looks fine to me.
Acked-by: Alexander In
Driver for ethernet on mpc5200/mpc5200b SoCs (FEC).
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
---
drivers/net/Kconfig |1
drivers/net/Makefile |1
drivers/net/fec_mpc52xx/Kconfig | 15
drivers/net/fec_mpc52xx/Makefile |2
drivers/net/fec_mpc52xx
Add masks and fix existing ones to match mpc5200b user's manual.
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
---
arch/powerpc/sysdev/bestcomm/fec.h | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
Index: linux.git/arch/powerpc/sysdev/bestcomm/fec.h
=
Add device tree entries for lite5200b's FEC's PHY.
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/lite5200b.dts | 18 +-
1 files changed, 17 insertions(+), 1 deletion(-)
Index: linux.git/arch/powerpc/boot/dts/lite5200b.dts
==
PHY part of the driver for mpc5200(b) ethernet.
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
---
drivers/net/fec_mpc52xx/Kconfig | 13 ++
drivers/net/fec_mpc52xx/Makefile |5
drivers/net/fec_mpc52xx/fec.c | 11 ++
drivers/net/fec_mpc52xx/fec.h |2
drivers/net/fec_mpc
Hello!
If there are no objections, I would like to get this merged
when bestcomm goes in (any time now?).
It's split into four parts:
1 - device tree
2 - small bestcomm change
3 - the actual driver
4 - phy part of the driver
Domen
--
Domen Puncer | Research & Development
.
Yinghai Lu wrote:
On 10/13/07, Manfred Spraul <[EMAIL PROTECTED]> wrote:
Someone around with a MSI capable board? The forcedeth driver does
dev->irq = pci_dev->irq
in nv_probe(), especially before pci_enable_msi().
Does pci_enable_msi() change pci_dev->irq? Then we would disable the
wrong
45 matches
Mail list logo
