[PATCH 5/5] net core: fix kernel-doc for new function parameters

2007-10-12 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix networking code kernel-doc for newly added parameters. Warning(linux-2.6.23-git2//net/core/sock.c:879): No description found for parameter 'net' Warning(linux-2.6.23-git2//net/core/dev.c:570): No description found for parameter 'net' Warning(linux-2.6.

Re: e100 problems in .23rc8 ?

2007-10-12 Thread Herbert Xu
David Mack <[EMAIL PROTECTED]> wrote: > If I understand the message Dave Jones sent yesterday, the patch you > mention *was* applied to the e100 driver in 2.6.23-6.fc8? Nope, he applied a different one which doesn't have the crucial part to disable NAPI polls before registration. Cheers, -- Visi

Re: 2.6.23-mm1 thread exit_group issue

2007-10-12 Thread Andrew Morton
On Fri, 12 Oct 2007 15:47:59 -0400 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > Hi Andrew, > > I noticed a regression between 2.6.23-rc8-mm2 and 2.6.23-mm1 (with your > hotfixes). User space threads seems to receive a ERESTART_RESTARTBLOCK > as soon as a thread does a pthread_join on them. The

Issue in __vlan_put_tag?

2007-10-12 Thread Justin Pettit
The function __vlan_put_tag modifies adds a VLAN tag to an existing Ethernet packet. In the process, the front of the packet is extended by four bytes to accommodate the tag. This function correctly adjusts the mac_header offset, but I think this line is problematic: skb->network_

Re: [irda-users] [PATCH]race between open and disconnect in irda-usb

2007-10-12 Thread Samuel Ortiz
Hi Oliver, On Fri, Oct 12, 2007 at 10:53:55AM +0200, Oliver Neukum wrote: > Hi, > > it seems to me that irda_usb_net_open() must set self->netopen > under spinlock or disconnect() may fail to kill all URBs, if it is called > while an interface is opened. Makes sense, yes. I will push it upstream

[PATCH] [POWERPC] ucc_geth: Fix build break introduced by commit 09f75cd7bf13720738e6a196cc0107ce9a5bd5a0

2007-10-12 Thread Emil Medve
CC drivers/net/ucc_geth.o drivers/net/ucc_geth.c: In function 'ucc_geth_startup': drivers/net/ucc_geth.c:2614: warning: assignment makes integer from pointer without a cast drivers/net/ucc_geth.c:2651: warning: assignment makes integer from pointer without a cast drivers/net/ucc_geth.c: In

Re: [PATCH] Update function names in /proc/net/tcp documentation

2007-10-12 Thread Rick Jones
Jean Delvare wrote: Update function name references to match the current code. Signed-off-by: Jean Delvare <[EMAIL PROTECTED]> --- Documentation/networking/proc_net_tcp.txt |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.23.orig/Documentation/networking/proc_net_tcp.

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-12 Thread Patrick McHardy
Al Boldi wrote: Patrick McHardy wrote: The netlink based iptables successor I'm currently working on allows to dynamically create tables with user-specified priorities and "built-in" chains. The only built-in tables will be those that need extra processing (mangle/nat). So it should be possib

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-12 Thread Al Boldi
Patrick McHardy wrote: > Jan Engelhardt wrote: > > On Oct 12 2007 16:30, Al Boldi wrote: > With the existence of the mangle table, how useful is the filter > table? > >>> > >>>A similar discussion was back in March 2007. > >>>http://marc.info/?l=netfilter-devel&m=117394977210823&w=2 > >>>h

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-12 Thread Al Boldi
Patrick McHardy wrote: > Al Boldi wrote: > > But can you see how forcing people into splitting > > their rules across tables adds complexity. And without ipt_REJECT > > patch, they can't even use REJECT in prerouting, which forces them to do > > some strange hacks. > > > > IMHO, we should make thi

Re: [PATCH 12/12] Drop bogus reference to tc-filters and add lartc.org link to manpage.

2007-10-12 Thread Patrick McHardy
Stephen Hemminger wrote: Applied 1,2,5,6,7,8,9,11,12 and provided alternative patch for 3. Any reason for not using the patch I sent in reply to patch 3? Your alternative doesn't cover the ioctl patch and doesn't include the other bugfix from my patch .. - To unsubscribe from this list: send

Re: [PATCH 12/12] Drop bogus reference to tc-filters and add lartc.org link to manpage.

2007-10-12 Thread Stephen Hemminger
Applied 1,2,5,6,7,8,9,11,12 and provided alternative patch for 3. -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH][BNX2X] round three

2007-10-12 Thread David Miller
From: Andi Kleen <[EMAIL PROTECTED]> Date: Fri, 12 Oct 2007 16:47:28 +0200 > "Eliezer Tamir" <[EMAIL PROTECTED]> writes: > > > > * For now depend on x86 or x86_64, will add more architectures ASAP. > > Why is that? Linux drivers normally should not be architecture specific. I totally agree, an

Re: [PATCH 10/12] Fix off-by-one in print of wrandom algo.

2007-10-12 Thread Stephen Hemminger
On Fri, 12 Oct 2007 10:56:45 +0200 Andreas Henriksson <[EMAIL PROTECTED]> wrote: > From: Norbert Buchmuller <[EMAIL PROTECTED]> > > The 'wrandom' multipath algo is recognised when adding the route, but > not resolved when it is printed (prints 'unknown'): > > ianus:~# ip ro add 1.2.3.4 mpath wra

[PATCH] Update function names in /proc/net/tcp documentation

2007-10-12 Thread Jean Delvare
Update function name references to match the current code. Signed-off-by: Jean Delvare <[EMAIL PROTECTED]> --- Documentation/networking/proc_net_tcp.txt |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.23.orig/Documentation/networking/proc_net_tcp.txt 2007-02-04 19:44:

Re: IPUtils and uClibc

2007-10-12 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 30 Jul 2007 00:50:39 +0200), Rafał Bilski <[EMAIL PROTECTED]> says: > Today I was trying to update my router based on Gentoo and uClibc. > Unfortunatly build fails because of b* functions. Linker can't > find them later. At first gcc is complaining that b

Re: [PATCH] IPROUTE2: Support IPv4/IPv6 Tunnel

2007-10-12 Thread Stephen Hemminger
On Fri, 12 Oct 2007 16:51:22 +0900 (JST) YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> wrote: > Based on patch from Yasuyuki KOZAKAI <[EMAIL PROTECTED]>. > > Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> > applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the

Re: 2.6.23-mm1 thread exit_group issue

2007-10-12 Thread Andrew Morton
On Fri, 12 Oct 2007 15:47:59 -0400 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: > I noticed a regression between 2.6.23-rc8-mm2 and 2.6.23-mm1 (with your > hotfixes). User space threads seems to receive a ERESTART_RESTARTBLOCK > as soon as a thread does a pthread_join on them. The previous behavio

Re: 2.6.23-mm1

2007-10-12 Thread Al Viro
On Fri, Oct 12, 2007 at 12:13:25AM -0700, Andrew Morton wrote: > I always forget to test uml. But a quick test build seems to work until > it hits this: > > arch/um/drivers/slip_kern.c: In function 'slip_init': > arch/um/drivers/slip_kern.c:34: error: 'struct net_device' has no member > named 'h

Re: [PATCH] gianfar: Cleanup compile warning caused by 0795af57

2007-10-12 Thread Kumar Gala
On Oct 12, 2007, at 8:53 AM, Li Yang wrote: Signed-off-by: Li Yang <[EMAIL PROTECTED]> Acked-by: Kumar Gala <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/maj

Re: [PATCH] gianfar: Fix compile regression caused by 09f75cd7

2007-10-12 Thread Kumar Gala
On Oct 12, 2007, at 8:53 AM, Li Yang wrote: Signed-off-by: Li Yang <[EMAIL PROTECTED]> Acked-by: Kumar Gala <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/ma

Re: [PATCH] gianfar: Fix compile regression caused by bea3348e

2007-10-12 Thread Kumar Gala
On Oct 12, 2007, at 8:53 AM, Li Yang wrote: Signed-off-by: Li Yang <[EMAIL PROTECTED]> Acked-by: Kumar Gala <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/maj

[TG3]: Fix performance regression on 5705.

2007-10-12 Thread Michael Chan
[TG3]: Fix performance regression on 5705. A performance regression was introduced by the following commit: commit ee6a99b539a50b4e9398938a0a6d37f8bf911550 Author: Michael Chan <[EMAIL PROTECTED]> Date: Wed Jul 18 21:49:10 2007 -0700 [TG3]: Fix msi issue with kexec/kdump. In m

Re: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use batching

2007-10-12 Thread Andi Kleen
> Use RCU? or write a generic version and get it reviewed. You really > want someone with knowledge of all the possible barrier impacts to > review it. I guess he was thinking of using cmpxchg; but we don't support this in portable code. RCU is not really suitable for this because it assume writ

Re: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use batching

2007-10-12 Thread Andi Kleen
> related to this comment, does Linux have a lockless (using atomics) > singly linked list element? That would be very useful in a driver hot > path. No; it doesn't. At least not a portable one. Besides they tend to be not faster anyways because e.g. cmpxchg tends to be as slow as an explicit spi

[PATCH net-2.6] uml: hard_header fix

2007-10-12 Thread Stephen Hemminger
Fix hard_header for net-2.6 (2.6.23-mm1). Please test this patch, unfortunately the tree it came from won't build UML, so it isn't possible to give it a proper check. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- a/arch/um/drivers/slip_kern.c 2007-10-11 13:16:07.0 -0700

Re: [PATCH 03/12] Prevent renaming interfaces to empty string.

2007-10-12 Thread Andreas Henriksson
On fre, 2007-10-12 at 10:07 -0700, Stephen Hemminger wrote: > > if (newname && strcmp(dev, newname)) { > > + if (strlen(newname) == 0) { > > + printf("\"\" is not valid device identifier\n"); > > + return -1; > > + } > > if (do_chang

Re: [PATCH 04/12] Fix up various problems in netbug script.

2007-10-12 Thread Andreas Henriksson
On fre, 2007-10-12 at 10:14 -0700, Stephen Hemminger wrote: > Does anyone ever use this script? Maybe it should just be pulled? Looks like something more closely related to reporting bugs directly to you upstream guys rather then any distribution would use, so if you don't have a need for it then

Re: Kernel panic (network stack)

2007-10-12 Thread Stephen Hemminger
On Fri, 12 Oct 2007 16:35:40 +0400 [EMAIL PROTECTED] wrote: > > -- Пересланное сообщение -- > > Тема: Kernel panic (network stack) > Дата: 12 октября 2007 > Отправитель: [EMAIL PROTECTED] > получатель: [EMAIL PROTECTED] > > Hello! > I develop network driver. > It works fine w

Re: "ping6 -M do" fragments packets

2007-10-12 Thread Patrick McHardy
Chuck Anderson wrote: > On Fri, Oct 12, 2007 at 06:00:12PM +0200, Patrick McHardy wrote: > ping6 -M do -s 65527 www.kame.net >>> >>>Sure enough, wireshark reports fragments: >>> >>>No. TimeSourceDestination Protocol Info >>> 1 0.002001:468:616

Re: [PATCH 04/12] Fix up various problems in netbug script.

2007-10-12 Thread Stephen Hemminger
On Fri, 12 Oct 2007 10:56:39 +0200 Andreas Henriksson <[EMAIL PROTECTED]> wrote: > From: Javier Fernández-Sanguino Peña <[EMAIL PROTECTED]> > > Fix race conditions and temporary file symlink attacks. > See http://bugs.debian.org/289541 > > Additional improvements by Allard Hoeve <[EMAIL PROTEC

Re: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use batching

2007-10-12 Thread Stephen Hemminger
On Fri, 12 Oct 2007 09:08:58 -0700 "Brandeburg, Jesse" <[EMAIL PROTECTED]> wrote: > Andi Kleen wrote: > >> When the hw TX queue gains space, the driver self-batches packets > >> from the sw queue to the hw queue. > > > > I don't really see the advantage over the qdisc in that scheme. > > It's cer

Re: [PATCH 03/12] Prevent renaming interfaces to empty string.

2007-10-12 Thread Stephen Hemminger
On Fri, 12 Oct 2007 10:56:38 +0200 Andreas Henriksson <[EMAIL PROTECTED]> wrote: > From: Alexander Wirt <[EMAIL PROTECTED]> > > > Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]> > --- > ip/iplink.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/ip/iplink

Re: e100 problems in .23rc8 ?

2007-10-12 Thread Kok, Auke
Herbert Xu wrote: > On Fri, Oct 12, 2007 at 07:54:33AM -0700, David Mack wrote: >> Still no joy here. See attached capture. What's really weird is that it >> shows *two* kernel panics, one in e100_poll and one in _list_add. > > Yes that's the symptom one would expect from that bug. We really > n

Re: [Bugme-new] [Bug 9149] New: accept() doesn't wake with error when socket descriptor closed

2007-10-12 Thread Andrew Morton
On Fri, 12 Oct 2007 07:42:06 -0700 (PDT) [EMAIL PROTECTED] wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9149 > >Summary: accept() doesn't wake with error when socket descriptor > closed >Product: Networking >Version: 2.5 > Kernel

Re: [PATCH] tg3: add PCI error recovery support

2007-10-12 Thread Michael Chan
On Fri, 2007-10-12 at 11:38 -0500, [EMAIL PROTECTED] wrote: > Hi, > > On Thu, Aug 02, 2007 at 05:13:39PM -0700, Michael Chan wrote: > > On Thu, 2007-08-02 at 18:12 -0500, [EMAIL PROTECTED] wrote: > > > On Thu, Jul 26, 2007 at 06:12:00PM -0700, Michael Chan wrote: > > > > On Thu, 2007-07-26 at 17:5

Re: [PATCH] tg3: add PCI error recovery support

2007-10-12 Thread Linas Vepstas
Hi, On Thu, Aug 02, 2007 at 05:13:39PM -0700, Michael Chan wrote: > On Thu, 2007-08-02 at 18:12 -0500, [EMAIL PROTECTED] wrote: > > On Thu, Jul 26, 2007 at 06:12:00PM -0700, Michael Chan wrote: > > > On Thu, 2007-07-26 at 17:57 -0500, [EMAIL PROTECTED] wrote: > > > > [... PCI error recovery patche

Re: "ping6 -M do" fragments packets

2007-10-12 Thread Chuck Anderson
On Fri, Oct 12, 2007 at 06:00:12PM +0200, Patrick McHardy wrote: > >>ping6 -M do -s 65527 www.kame.net > > > > Sure enough, wireshark reports fragments: > > > > No. TimeSourceDestination Protocol > > Info > > 1 0.002001:468:616:8c9:213:72ff:fe7

RE: e100 problems in .23rc8 ?

2007-10-12 Thread David Mack
Still no joy here. See attached capture. What's really weird is that it shows *two* kernel panics, one in e100_poll and one in _list_add. Dave > -Original Message- > From: Dave Jones [mailto:[EMAIL PROTECTED] > Sent: Thursday, October 11, 2007 10:26 AM > To: Kok, Auke > Cc: Herbert Xu;

RE: [ofa-general] Re: [PATCH 2/3][NET_BATCH] net core use batching

2007-10-12 Thread Brandeburg, Jesse
Andi Kleen wrote: >> When the hw TX queue gains space, the driver self-batches packets >> from the sw queue to the hw queue. > > I don't really see the advantage over the qdisc in that scheme. > It's certainly not simpler and probably more code and would likely > also not require less locks (e.g.

Re: [PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

2007-10-12 Thread Brian Haley
Hi Aurelien, Comments in-line. Aurélien Charbon wrote: Here is a second missing part of the IPv6 support in NFS server code concerning knfd syscall interface. -struct sockaddr_in *sin; +struct sockaddr_in6 *sin, sin6_storage; Nit, should call this sin6 now. @@ -228,9 +228,20 @@ s

Re: [PATCH 1/2] NFS: change the ip_map cache code to handle IPv6 addresses

2007-10-12 Thread Brian Haley
Hi Aurelien, There were some of my comments you haven't addressed yet, comments in-line. Aurélien Charbon wrote: Here is a patch for the ip_map caching code part in nfs server. +for (i = 0; i < ncp->cl_naddr; i++) { +/* Mapping address */ +ipv6_addr_v4map(ncp->cl_addrlist

Re: [NET] MIPSsim: General cleanup

2007-10-12 Thread Ilpo Järvinen
On Fri, 12 Oct 2007, Ralf Baechle wrote: > General cleanups mostly as suggested by checkpatch plus getting rid of > homebrew version of offsetof(). > > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> > --- > > drivers/net/mipsnet.c | 63 ++--- > drivers/net/mip

Re: "ping6 -M do" fragments packets

2007-10-12 Thread Patrick McHardy
Chuck Anderson wrote: > I'm not subscribed, so please Cc: me on any responses. Thanks. > > According to the man page, ping6 should support the "-M do" option so > never fragment packets, which I'd like to use for testing the MTU of a > path. This option works fine for IPv4 ping, but doesn't wo

"ping6 -M do" fragments packets

2007-10-12 Thread Chuck Anderson
I'm not subscribed, so please Cc: me on any responses. Thanks. According to the man page, ping6 should support the "-M do" option so never fragment packets, which I'd like to use for testing the MTU of a path. This option works fine for IPv4 ping, but doesn't work with IPv6 ping6. I can guar

RE: e100 problems in .23rc8 ?

2007-10-12 Thread David Mack
If I understand the message Dave Jones sent yesterday, the patch you mention *was* applied to the e100 driver in 2.6.23-6.fc8? Dave > -Original Message- > From: Herbert Xu [mailto:[EMAIL PROTECTED] > Sent: Friday, October 12, 2007 8:36 AM > To: David Mack > Cc: Dave Jones; Kok, Auke; ne

Re: e100 problems in .23rc8 ?

2007-10-12 Thread Herbert Xu
On Fri, Oct 12, 2007 at 07:54:33AM -0700, David Mack wrote: > Still no joy here. See attached capture. What's really weird is that it > shows *two* kernel panics, one in e100_poll and one in _list_add. Yes that's the symptom one would expect from that bug. We really need to apply the same fix th

Re: [PATCH][BNX2X] round three

2007-10-12 Thread Andi Kleen
"Eliezer Tamir" <[EMAIL PROTECTED]> writes: > * For now depend on x86 or x86_64, will add more architectures ASAP. Why is that? Linux drivers normally should not be architecture specific. -Andi - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAI

Re: [PATCH] NEW EMAC Fix RGMII build error: use of_device_is_compatible

2007-10-12 Thread Josh Boyer
On Fri, 2007-10-12 at 17:04 +0400, Valentine Barshak wrote: > Fix build RGMII error: use of_device_is_compatible() > insteadof now deprecated device_is_compatible() function. > > Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> Acked-by: Josh Boyer <[EMAIL PROTECTED]> Jeff, this should go in

Re: 2.6.23-rc8-mm2 BUG: register_netdevice() issue as (ab)used by ISDN

2007-10-12 Thread Karsten Keil
Hi Dave, a follow up to the previous patch for net-2.6.24. On Mon, Oct 08, 2007 at 08:37:33PM -0700, David Miller wrote: > > > > You could try following patch with 2.6.23-rc8-mm2, it change I4L to use > > alloc_netdev(). > > > > Signed-off-by: Karsten Keil <[EMAIL PROTECTED]> > > I've added th

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-12 Thread Patrick McHardy
Jan Engelhardt wrote: > On Oct 12 2007 15:48, Patrick McHardy wrote: > >>The netlink based iptables successor I'm currently working on allows to >>dynamically create tables with user-specified priorities and "built-in" >>chains. The only built-in tables will be those that need extra >>processing (

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-12 Thread Jan Engelhardt
On Oct 12 2007 15:48, Patrick McHardy wrote: > >The netlink based iptables successor I'm currently working on allows to >dynamically create tables with user-specified priorities and "built-in" >chains. The only built-in tables will be those that need extra >processing (mangle/nat). So it should be

[PATCH] [TCP]: high_seq parameter removed (all callers use tp->high_seq)

2007-10-12 Thread Ilpo Järvinen
Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> --- Compile tested with 2.6.23 as current Linus' tree provides an hilarious building failure to our net-2.6 sandbox... :-) net/ipv4/tcp_input.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/net/ipv4/tcp_input.

tc_verd vs. skb_clone

2007-10-12 Thread Herbert Xu
Hi Jamal: I was wondering why we're not copying tc_verd as is in skb_clone. In particular, this makes pskb_copy behave differently compared to skb_clone and I can't find a justificatino for it. Any ideas? Also we don't seem to copy iif in copy_skb_header. Thanks, -- Visit Openswan at http://ww

[NET] MIPSsim: General cleanup

2007-10-12 Thread Ralf Baechle
General cleanups mostly as suggested by checkpatch plus getting rid of homebrew version of offsetof(). Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> --- drivers/net/mipsnet.c | 63 ++--- drivers/net/mipsnet.h | 83 ++--

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-12 Thread Patrick McHardy
Jan Engelhardt wrote: > On Oct 12 2007 16:30, Al Boldi wrote: With the existence of the mangle table, how useful is the filter table? >>> >>>A similar discussion was back in March 2007. >>>http://marc.info/?l=netfilter-devel&m=117394977210823&w=2 >>>http://marc.info/?l=netfilter-devel&m=11

[PATCH] gianfar: Cleanup compile warning caused by 0795af57

2007-10-12 Thread Li Yang
Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- drivers/net/gianfar.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index 6d1456a..c15fb1f 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -168,7 +168,6 @@ stat

[PATCH] gianfar: Fix compile regression caused by 09f75cd7

2007-10-12 Thread Li Yang
Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- drivers/net/gianfar.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index 2b758fa..6d1456a 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -1228,8 +1228,6

[PATCH] gianfar: Fix compile regression caused by bea3348e

2007-10-12 Thread Li Yang
Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- drivers/net/gianfar.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index 0db5e6f..2b758fa 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -261,7 +261,9 @@ st

[PATCH] NEW EMAC Fix RGMII build error: use of_device_is_compatible

2007-10-12 Thread Valentine Barshak
Fix build RGMII error: use of_device_is_compatible() insteadof now deprecated device_is_compatible() function. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/rgmii.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -pruN linux-2.6.orig/drivers/net/

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-12 Thread Jan Engelhardt
On Oct 12 2007 16:30, Al Boldi wrote: >Jan Engelhardt wrote: >> On Oct 12 2007 00:31, Al Boldi wrote: >> >With the existence of the mangle table, how useful is the filter table? >> >> A similar discussion was back in March 2007. >> http://marc.info/?l=netfilter-devel&m=117394977210823&w=2 >> http:

[PATCH 9/9] Consolidate the xxx_put

2007-10-12 Thread Pavel Emelyanov
These ones use the generic data types too, so move them in one place. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/include/net/inet_frag.h b/include/net/inet_frag.h index cf583cf..911c2cd 100644 --- a/include/net/inet_frag.h +++ b/include/net/inet_frag.h @@ -51,4 +51,10 @@

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-12 Thread Al Boldi
Jan Engelhardt wrote: > On Oct 12 2007 00:31, Al Boldi wrote: > >With the existence of the mangle table, how useful is the filter table? > > A similar discussion was back in March 2007. > http://marc.info/?l=netfilter-devel&m=117394977210823&w=2 > http://marc.info/?l=netfilter-devel&m=1174000639077

[PATCH 8/9] Small cleanup for xxx_put after evictor consolidation

2007-10-12 Thread Pavel Emelyanov
After the evictor code is consolidated there is no need in passing the extra pointer to the xxx_put() functions. The only place when it made sense was the evictor code itself. Maybe this change must got with the previous (or with the next) patch, but I try to make them shorter as much as possi

[PATCH 7/9] Consolidate the xxx_evictor

2007-10-12 Thread Pavel Emelyanov
The evictors collect some statistics for ipv4 and ipv6, so make it return the number of evicted queues and account them all at once in the caller. The XXX_ADD_STATS_BH() macros are just for this case, but maybe there are places in code, that can make use of them as well. Signed-off-by: Pavel E

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-12 Thread Patrick McHardy
Al Boldi wrote: > Patrick McHardy wrote: > >>Al Boldi wrote: >> >>>Well, for example to stop any transient packets being forwarded. You >>>could probably hack around this using mark's, but you can't stop the >>>implied route lookup, unless you stop it in prerouting. >> >>This also works fine in F

[PATCH 6/9] Consolidate the xxx_frag_destroy

2007-10-12 Thread Pavel Emelyanov
To make in possible we need to know the exact frag queue size for inet_frags->mem management and two callbacks: * to destoy the skb (optional, used in conntracks only) * to free the queue itself (mandatory, but later I plan to move the allocation and the destruction of frag_queues into t

[PATCH 5/9] Consolidate xxx_the secret_rebuild

2007-10-12 Thread Pavel Emelyanov
This code works with the generic data types as well, so move this into inet_fragment.c This move makes it possible to hide the secret_timer management and the secret_rebuild routine completely in the inet_fragment.c Introduce the ->hashfn() callback in inet_frags() to get the hashfun for a given

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-12 Thread Al Boldi
Patrick McHardy wrote: > Al Boldi wrote: > >>>The problem is that people think they are safe with the filter table, > >>>when in fact they need the prerouting chain to seal things. Right now > >>>this is only possible in the mangle table. > >> > >>Why do they need PREROUTING? > > > > Well, for exa

Re: Non-linear SKBs

2007-10-12 Thread kristrev
> If the underlying device can do scatter-gather and checksumming, > the TCP code builds outgoing packets by copying user date into > full system pages, and then attaching those pages into the SKB. > The protocol headers sit under the skb->data linear area, and > the user data mostly sits in the u

[PATCH 4/9] Consolidate the xxx_frag_kill

2007-10-12 Thread Pavel Emelyanov
Since now all the xxx_frag_kill functions now work with the generic inet_frag_queue data type, this can be moved into a common place. The xxx_unlink() code is moved as well. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- diff --git a/include/net/inet_frag.h b/include/net/inet_frag.h ind

[PATCH 3/9] Collect common sysctl variables together

2007-10-12 Thread Pavel Emelyanov
Some sysctl variables are used to tune the frag queues management and it will be useful to work with them in a common way in the future, so move them into one structure, moreover they are the same for all the frag management codes. I don't place them in the existing inet_frags object, introduced i

[PATCH 2/9] Collect frag queues management objects together

2007-10-12 Thread Pavel Emelyanov
There are some objects that are common in all the places which are used to keep track of frag queues, they are: * hash table * LRU list * rw lock * rnd number for hash function * the number of queues * the amount of memory occupied by queues * secret timer Move all this stuff into one stru

[PATCH 1/9] Move common fields from frag_queues in one place

2007-10-12 Thread Pavel Emelyanov
Introduce the struct inet_frag_queue in include/net/inet_frag.h file and place there all the common fields from three structs: * struct ipq in ipv4/ip_fragment.c * struct nf_ct_frag6_queue in nf_conntrack_reasm.c * struct frag_queue in ipv6/reassembly.c After this, replace these fields on appr

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-12 Thread Jan Engelhardt
On Oct 12 2007 00:31, Al Boldi wrote: > >With the existence of the mangle table, how useful is the filter table? A similar discussion was back in March 2007. http://marc.info/?l=netfilter-devel&m=117394977210823&w=2 http://marc.info/?l=netfilter-devel&m=117400063907706&w=2 in the end, my proposa

[PATCH 0/9] Consolidate IP fragment management

2007-10-12 Thread Pavel Emelyanov
Patrick recently pointed out, that there are three places that perform IP fragments management. In ipv4, ipv6 and in ip6 conntracks. Looks like these places can be a bit consolidated. The proposal is to create a common structure inet_frag_queue to put common fields like list heads, refcounts et

[PATCH] Also do tc_core_time2big argument (long->unsigned).

2007-10-12 Thread Andreas Henriksson
tc_core_time2big only used in tc/q_netem.c where it gets passed an unsigned. Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]> --- tc/tc_core.c |2 +- tc/tc_core.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tc/tc_core.c b/tc/tc_core.c index 8c3a2ac..1365e08

Kernel panic (network stack)

2007-10-12 Thread xeb
-- Пересланное сообщение -- Тема: Kernel panic (network stack) Дата: 12 октября 2007 Отправитель: [EMAIL PROTECTED] получатель: [EMAIL PROTECTED] Hello! I develop network driver. It works fine while less then 100 network interfaces exists. Then i give kernel panic. What could

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-12 Thread Patrick McHardy
Al Boldi wrote: >>>The problem is that people think they are safe with the filter table, >>>when in fact they need the prerouting chain to seal things. Right now >>>this is only possible in the mangle table. >> >>Why do they need PREROUTING? > > > Well, for example to stop any transient packets

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-12 Thread Al Boldi
Patrick McHardy wrote: > Al Boldi wrote: > > Patrick McHardy wrote: > >>Please send mails discussing netfilter to netfilter-devel. > > > > Ok. I just found out this changed to vger. But > > [EMAIL PROTECTED] is bouncing me. > > Seems to work, I got your mail on netfilter-devel. Looks like it wor

[PATCH 4/4] UDP memory accounting and limitation(take 5): memory limitation

2007-10-12 Thread Satoshi OSHIMA
This patch introduces memory limitation for UDP. signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]> signed-off-by: Hideo Aoki <[EMAIL PROTECTED]> Index: 2.6.23-udp_limit/include/net/udp.h === --- 2.6.23-udp_limit.orig/include/net/udp

[PATCH 3/4] UDP memory accounting and limitation(take 5): memory accounting

2007-10-12 Thread Satoshi OSHIMA
This patch introduces memory usage accounting for UDP. signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]> signed-off-by: Hideo Aoki <[EMAIL PROTECTED]> Index: 2.6.23-udp_limit/net/ipv4/ip_output.c === --- 2.6.23-udp_limit.orig/net/ip

[PATCH 2/4] UDP memory accounting and limitation(take 5): accounting unit and variable

2007-10-12 Thread Satoshi OSHIMA
This patch introduces global variable for UDP memory accounting. The unit is page. signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]> signed-off-by: Hideo Aoki <[EMAIL PROTECTED]> Index: 2.6.23-udp_limit/include/net/sock.h === --- 2.

Re: [PATCH] Also do tc_core_time2big argument (long->unsigned).

2007-10-12 Thread Patrick McHardy
Andreas Henriksson wrote: > tc_core_time2big only used in tc/q_netem.c where it gets passed an unsigned. > > Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]> > --- > tc/tc_core.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Seems to be missing a tc_core.h update. - To unsu

Re: [PATCH 03/12] Prevent renaming interfaces to empty string.

2007-10-12 Thread Patrick McHardy
Andreas Henriksson wrote: > From: Alexander Wirt <[EMAIL PROTECTED]> > > > Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]> > --- > ip/iplink.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/ip/iplink.c b/ip/iplink.c > index 4060845..da1f64e 100644 > --- a

[PATCH 1/4] UDP memory accounting and limitation(take 5): fix send buffer check

2007-10-12 Thread Satoshi OSHIMA
This patch introduces sndbuf size check before memory allcation for send buffer. signed-off-by: Satoshi Oshima <[EMAIL PROTECTED]> signed-off-by: Hideo Aoki <[EMAIL PROTECTED]> Index: 2.6.23-rc7-udp_limit/net/ipv4/ip_output.c === --

[PATCH 0/4]UDP memory accounting and limitation(take 5)

2007-10-12 Thread Satoshi OSHIMA
Hi, I revised a patch set of UDP memory accounting and limitation. This patch set is for kernel 2.6.23. The differences from take 4 are * removing unnessesary EXPORT_SYMBOLs * adding minimal limit of /proc/sys/net/udp_mem * bugfix of UDP limit affecting protocol other than UDP * introducing __

[PATCH] Also do tc_core_time2big argument (long->unsigned).

2007-10-12 Thread Andreas Henriksson
tc_core_time2big only used in tc/q_netem.c where it gets passed an unsigned. Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]> --- tc/tc_core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tc/tc_core.c b/tc/tc_core.c index 8c3a2ac..1365e08 100644 --- a/tc/tc_core.

Re: [RFC/PATCH 4/4] UDP memory usage accounting (take 4): memory limitation

2007-10-12 Thread Satoshi OSHIMA
Hi Stephen, > On Thu, 11 Oct 2007 21:51:14 +0900 > Satoshi OSHIMA <[EMAIL PROTECTED]> wrote: > >> Hi Stephen, >> >> Thank you for your comment. >> { + .ctl_name = NET_UDP_MEM, + .procname = "udp_mem", + .data = &sysctl_udp_me

[PATCH] Switch helpers tc_core_{time2ktime,ktime2time} from long to unsigned as well.

2007-10-12 Thread Andreas Henriksson
Follow up patch to "Fix overflow in time2tick / tick2time." which switches the remaining two helper functions from long to unsigned as well. These functions are only used in "tc/q_hfsc.c" where both the passed argument and the place the return value is stored are unsigned/u32 variables, so this cha

Re: [RFD] iptables: mangle table obsoletes filter table

2007-10-12 Thread Patrick McHardy
Al Boldi wrote: > Patrick McHardy wrote: > >>Please send mails discussing netfilter to netfilter-devel. > > > Ok. I just found out this changed to vger. But > [EMAIL PROTECTED] is bouncing me. Seems to work, I got your mail on netfilter-devel. >>Al Boldi wrote: >> >>>With the existence of t

Re: Regression in net-2.6.24?

2007-10-12 Thread David Miller
From: TAKANO Ryousei <[EMAIL PROTECTED]> Date: Fri, 12 Oct 2007 19:22:00 +0900 (JST) > I am sorry for late reply. > I confirmed this patch fixes the kernel panic that I reported. > Thanks David and others. Thank you for testing. - To unsubscribe from this list: send the line "unsubscribe netdev"

Re: Regression in net-2.6.24?

2007-10-12 Thread TAKANO Ryousei
From: David Miller <[EMAIL PROTECTED]> Subject: Re: Regression in net-2.6.24? Date: Thu, 11 Oct 2007 18:14:49 -0700 (PDT) > > Here is what I'm checking into net-2.6 for now: > > commit 6f535763165331bb91277d7519b507fed22034e5 > Author: David S. Miller <[EMAIL PROTECTED]> > Date: Thu Oct 11 18:

Re: authenc compile warnings in current net-2.6.24

2007-10-12 Thread Herbert Xu
On Fri, Oct 12, 2007 at 08:15:01AM +0200, Oliver Hartkopp wrote: > Hi Dave, > > this compile fix seems not to be applied (maybe my compiler is the only > one who complains ;-) That's because the patch is in my cryptodev-2.6 tree :) Thanks, -- Visit Openswan at http://www.openswan.org/ Email: H

[PATCH 2/2] NFS: handle IPv6 addresses in nfs ctl

2007-10-12 Thread Aurélien Charbon
Here is a second missing part of the IPv6 support in NFS server code concerning knfd syscall interface. It updates write_getfd and write_getfd to accept IPv6 addresses. Applies on a kernel including ip_map cache modifications Tests: tested with only IPv4 network and basic nfs ops (mount, file c

[PATCH 1/2] NFS: change the ip_map cache code to handle IPv6 addresses

2007-10-12 Thread Aurélien Charbon
Here is a patch for the ip_map caching code part in nfs server. I have updated the code to use Brian Haley's ipv6_addr_v4mapped function, and corrected pointed out mistakes. So the first patch in attachment must be applied on a vanilla kernel before to include IPv4 mapping functions that are use

[TC]: Add NAT action

2007-10-12 Thread Herbert Xu
Hi Stephen: Here's a patch to add support for the nat action which is now in the kernel. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH 12/12] Drop bogus reference to tc-filters and add lartc.org link to manpage.

2007-10-12 Thread Andreas Henriksson
From: Alexander Wirt <[EMAIL PROTECTED]> Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]> --- man/man8/ip.8 |2 ++ man/man8/tc.8 |3 ++- 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/man/man8/ip.8 b/man/man8/ip.8 index 153123a..8fd6d52 100644 --- a/man/man8/ip.8 +++

[PATCH 11/12] Fix overflow in time2tick / tick2time.

2007-10-12 Thread Andreas Henriksson
The helper functions gets passed an unsigned int, which gets cast to long and overflows. See http://bugs.debian.org/175462 Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]> --- tc/tc_core.c |4 ++-- tc/tc_core.h |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/t

[PATCH 01/12] Fix various typos and nitpicks

2007-10-12 Thread Andreas Henriksson
From: Alexander Wirt <[EMAIL PROTECTED]> Fix typo in ss manpage. Make the backslash visible in ip manpage (http://bugs.debian.org/285507). Strict syntax for ip addr advice in error message. Fix typo in libnetlink(3) manpage (writen -> written). Fix typos in tc-prio(8) manpage. Fix typo in tc-htb(8

  1   2   >