This code is broken from the very beginning.
iris den # cat /proc/sys/net/ipv4/ip_local_port_range
32768 61000
iris den # echo 32768 32 >/proc/sys/net/ipv4/ip_local_port_range
iris den # cat /proc/sys/net/ipv4/ip_local_port_range
32768 32
iris den # echo 32768 61000 >/proc/sys/net/ipv4/ip_loca
YOSHIFUJI Hideaki / <[EMAIL PROTECTED]> wrote:
>
> We'd really like to do our best to avoid such random failures
> even if it may/can not be perfect.
OK I see your point of view but there's got to be a better way
than this.
As it is your tests will fail randomly anyway if you do it
Hello.
In article <[EMAIL PROTECTED]> (at Wed, 10 Oct 2007 09:32:35 +0800), Herbert Xu
<[EMAIL PROTECTED]> says:
> Mitsuru Chinen <[EMAIL PROTECTED]> wrote:
> > To judge the timing for DAD, netif_carrier_ok() is used. However,
> > there is a possibility that dev->qdisc stays noop_qdisc even if
>
Update the "don't change MAC of slaves" functionality added in
previous changes to be a generic option, rather than something tied to
IB devices, as it's occasionally useful for regular ethernet devices as
well.
Adds "fail_over_mac" option (which is automatically enabled for IB
sl
Signed-off-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
Documentation/networking/bonding.txt | 33 +++
drivers/net/bonding/bond_main.c | 57 +
drivers/net/bonding/bond_sysfs.c | 49 +
drivers/net/bonding/bonding
From: Moni Shoua <[EMAIL PROTECTED]>
When bonding enslaves non Ethernet devices it takes pointers to functions
in the module that owns the slaves. In this case it becomes unsafe
to keep the bonding master registered after last slave was unenslaved
because we don't know if the pointers are still va
From: Moni Shoua <[EMAIL PROTECTED]>
Allow to enslave devices when the bonding device is not up. Over the discussion
held at the previous post this seemed to be the most clean way to go, where it
is not expected to cause instabilities.
Normally, the bonding driver is UP before any enslavement tak
From: Moni Shoua <[EMAIL PROTECTED]>
bonding sometimes uses Ethernet constants (such as MTU and address length) which
are not good when it enslaves non Ethernet devices (such as InfiniBand).
Signed-off-by: Moni Shoua
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_main.c
From: Moni Shoua <[EMAIL PROTECTED]>
Delay sending a gratuitous_arp when LINK_STATE_LINKWATCH_PENDING bit
in dev->state field is on. This improves the chances for the arp packet to
be transmitted.
Signed-off-by: Moni Shoua
Acked-by: Jay Vosburgh <[EMAIL PROTECTED]>
---
drivers/net/bonding/bond_
From: Moni Shoua <[EMAIL PROTECTED]>
This patch changes some of the bond netdevice attributes and functions
to be that of the active slave for the case of the enslaved device not being
of ARPHRD_ETHER type. Basically it overrides those setting done by
ether_setup(),
which are netdevice **type** d
From: Moni Shoua <[EMAIL PROTECTED]>
This patch allows for enslaving netdevices which do not support
the set_mac_address() function. In that case the bond mac address is the one
of the active slave, where remote peers are notified on the mac address
(neighbour) change by Gratuitous ARP sent by bon
From: Moni Shoua <[EMAIL PROTECTED]>
IPoIB uses a two layer neighboring scheme, such that for each struct neighbour
whose device is an ipoib one, there is a struct ipoib_neigh buddy which is
created on demand at the tx flow by an ipoib_neigh_alloc(skb->dst->neighbour)
call.
When using the bonding
From: Moni Shoua <[EMAIL PROTECTED]>
When the bonding device senses a carrier loss of its active slave it replaces
that slave with a new one. In between the times when the carrier of an IPoIB
device goes down and ipoib_neigh is destroyed, it is possible that the
bonding driver will send a packet o
9 patch series providing IPoIB support for bonding
This should correct the compile errors from the last posting; it
builds ok for me against netdev-2.6 upstream pulled about an hour ago.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED]
-
To uns
Jeff Garzik <[EMAIL PROTECTED]> wrote:
>
> One side effect of this patch: might_sleep() is now called unconditionally.
That would be seem to be a good thing :)
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~he
Mitsuru Chinen <[EMAIL PROTECTED]> wrote:
> To judge the timing for DAD, netif_carrier_ok() is used. However,
> there is a possibility that dev->qdisc stays noop_qdisc even if
> netif_carrier_ok() returns true. In that case, DAD NS is not sent out.
> We need to defer the IPv6 device initialization
David Miller <[EMAIL PROTECTED]> wrote:
>From: Jeff Garzik <[EMAIL PROTECTED]>
>Date: Tue, 09 Oct 2007 20:56:35 -0400
>
>> Jeff Garzik wrote:
>> > applied patches 1-9
>> >
>> > the only thing that was a hiccup during submission is that your email
>> > subject lines did not contain a notion of or
Keep tx and rx elements separate on different cachelines to prevent
bouncing.
Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
Cc: Stephen Hemminger <[EMAIL PROTECTED]>
Cc: Christoph Hellwig <[EMAIL PROTECTED]>
---
drivers/net/xen-netfront.c | 37 ++---
1
This patch removes some residual dead code left over from removing the
"flip" receive mode. This patch doesn't change the generated output
at all, since gcc already realized it was dead.
This resolves the "regression" reported by Adrian.
Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
Cc:
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 20:56:35 -0400
> Jeff Garzik wrote:
> > applied patches 1-9
> >
> > the only thing that was a hiccup during submission is that your email
> > subject lines did not contain a notion of ordering "[PATCH 1/9] ...".
> > But other than tha
From: "John W. Linville" <[EMAIL PROTECTED]>
Date: Tue, 9 Oct 2007 20:21:45 -0400
> Jeff & Dave,
>
> A last round of patches, hopefully in time for 2.6.24.
Pulled and pushed back out, thanks John!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EM
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue, 9 Oct 2007 21:03:26 -0400
>
> Please pull from the 'upstream-davem' branch of
> master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
> upstream-davem
>
> to receive these changes:
Pulled and pushed back out, thanks Jeff!
-
To unsub
Jeff Garzik wrote:
> ACK but does not apply to jgarzik/netdev-2.6.git#upstream nor
> davem/net-2.6.24.git
OK, looks like you don't have the other two patches. Will post in a sec.
J
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECT
Jeff Garzik wrote:
> Jeremy Fitzhardinge wrote:
>> Keep tx and rx elements separate on different cachelines to prevent
>> bouncing.
>>
>> Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
>> Cc: Stephen Hemminger <[EMAIL PROTECTED]>
>> Cc: Christoph Hellwig <[EMAIL PROTECTED]>
>>
>> ---
>> dr
Please pull from the 'upstream-davem' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
upstream-davem
to receive these changes:
Auke Kok (2):
e1000e: Simple optimizations in e1000_xmit_frame
e1000e: restore flow control settings properly
Jan-Bernd Theman
Jeff Garzik wrote:
applied patches 1-9
the only thing that was a hiccup during submission is that your email
subject lines did not contain a notion of ordering "[PATCH 1/9] ...".
But other than that, the git-send-email went flawlessly.
unfortunately it does not seem to build flawlessly:
dr
From: Andi Kleen <[EMAIL PROTECTED]>
Date: Wed, 10 Oct 2007 02:37:16 +0200
> On Tue, Oct 09, 2007 at 05:04:35PM -0700, David Miller wrote:
> > We have to keep in mind, however, that the sw queue right now is 1000
> > packets. I heavily discourage any driver author to try and use any
> > single TX
On Tue, Oct 09, 2007 at 01:33:07PM -0700, David Miller wrote:
>
> I would be more careful with the changelog description for
> something like this in the future. It sounds like this
> patch will cause us to touch userspace with locks held,
> which obviously only works in very limited scenerios
> a
Roland Dreier wrote:
The conversion to use netdevice internal stats left an unused variable
in ipoib_neigh_free(), since there's no longer any reason to get
netdev_priv() in order to increment dropped packets. Delete the
unused priv variable.
Signed-off-by: Roland Dreier <[EMAIL PROTECTED]>
---
Mark Brown wrote:
Unless we have failed to fill the RX ring the timer used by the natsemi
driver is not particularly urgent and can use round_jiffies() to allow
grouping with other timers.
Signed-off-by: Mark Brown <[EMAIL PROTECTED]>
---
drivers/net/natsemi.c | 10 +++---
1 files changed
Mark Brown wrote:
The natsemi driver has a define NATSEMI_TIMER_FREQ which looks like it
controls the normal frequency of the chip poll timer but in fact only
takes effect for the first run of the timer. Adjust the value of the
define to match that used by the timer and use the define consistent
Jeremy Fitzhardinge wrote:
Keep tx and rx elements separate on different cachelines to prevent
bouncing.
Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
Cc: Stephen Hemminger <[EMAIL PROTECTED]>
Cc: Christoph Hellwig <[EMAIL PROTECTED]>
---
drivers/net/xen-netfront.c | 37
Stephen Hemminger wrote:
Fix warnings from sparse related to shadowed variables and routines
that should be declared static.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PRO
Stephen Hemminger wrote:
Fix problems detected by sparse:
1. whole chunk of MAC code was for defined and never used
2. hook for running ext intr in workqueue wasn't being used
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubs
Jan-Bernd Themann wrote:
eHEA recovery and DLPAR functions are called seldomly. The eHEA workqueues
are replaced by the kernel event queue.
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
---
The patch has been built against upstream git
drivers/net/ehea/ehea.h |3 +--
drivers/n
Stephen Hemminger wrote:
Fix some of the easy warnings in network device drivers.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
drivers/net/acenic.c | 37 +++--
drivers/net/atl1/atl1_main.c |5 +++--
drivers/net/dl2k.c |8 +
Auke Kok wrote:
From: Krishna Kumar <[EMAIL PROTECTED]>
Some simple optimizations in e1000_xmit_frame.
Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>
---
drivers/net/e1000/e1000_main.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
applied 1-2
-
To unsubscribe from t
Jeff & Dave,
A last round of patches, hopefully in time for 2.6.24.
Thanks!
John
---
The following changes since commit 7b4cd20628fe5c4e145c383fcd8d954d38f7be61:
Benjamin Thery (1):
[IPv6]: use container_of() macro in fib6_clean_node()
are available in the git repository at:
git:
On Tue, Oct 09, 2007 at 05:04:35PM -0700, David Miller wrote:
> We have to keep in mind, however, that the sw queue right now is 1000
> packets. I heavily discourage any driver author to try and use any
> single TX queue of that size.
Why would you discourage them?
If 1000 is ok for a softwar
David Miller wrote:
From: Roland Dreier <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 15:46:13 -0700
The conversion to use netdevice internal stats left an unused variable
in ipoib_neigh_free(), since there's no longer any reason to get
netdev_priv() in order to increment dropped packets. Delete
From: jamal <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 17:56:46 -0400
> if the h/ware queues are full because of link pressure etc, you drop. We
> drop today when the s/ware queues are full. The driver txmit lock takes
> place of the qdisc queue lock etc. I am assuming there is still need for
> th
From: Roland Dreier <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 15:46:13 -0700
> The conversion to use netdevice internal stats left an unused variable
> in ipoib_neigh_free(), since there's no longer any reason to get
> netdev_priv() in order to increment dropped packets. Delete the
> unused priv
Sorry... wrong subject here; it should have been "ibm_newemac: ..."
- R.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Commit da3dedd9 ("[NET]: Make NAPI polling independent of struct
net_device objects.") changed the interface to NAPI polling. Fix up
the ibm_newemac driver so that it works with this new interface. This
is actually a nice cleanup because ibm_newemac is one of the drivers
that wants to have multip
The conversion to use netdevice internal stats left an unused variable
in ipoib_neigh_free(), since there's no longer any reason to get
netdev_priv() in order to increment dropped packets. Delete the
unused priv variable.
Signed-off-by: Roland Dreier <[EMAIL PROTECTED]>
---
drivers/infiniband/ul
Commit da3dedd9 ("[NET]: Make NAPI polling independent of struct
net_device objects.") changed the interface to NAPI polling. Fix up
the ibm_emac driver so that it works with this new interface. This is
actually a nice cleanup because ibm_emac is one of the drivers that
wants to have multiple NAP
Signed-off-by: Roland Dreier <[EMAIL PROTECTED]>
---
drivers/net/ibm_newemac/core.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
index ce127b9..8ea5009 100644
--- a/drivers/net/ibm_newemac/core.c
+++ b/driv
Unless we have failed to fill the RX ring the timer used by the natsemi
driver is not particularly urgent and can use round_jiffies() to allow
grouping with other timers.
Signed-off-by: Mark Brown <[EMAIL PROTECTED]>
---
drivers/net/natsemi.c | 10 +++---
1 files changed, 7 insertions(+), 3
> Before you add new entries to your list, how is that ibm driver NAPI
> conversion coming along? :-)
OK, thanks for the kick in the pants, I have a couple of patches for
net-2.6.24 coming (including an unrelated trivial warning fix for
IPoIB).
- R.
-
To unsubscribe from this list: send the li
The natsemi driver has a define NATSEMI_TIMER_FREQ which looks like it
controls the normal frequency of the chip poll timer but in fact only
takes effect for the first run of the timer. Adjust the value of the
define to match that used by the timer and use the define consistently.
Signed-off-by:
I updated this doc to match the latest patch.
cheers,
jamal
Here's the beginning of a howto for driver authors.
The intended audience for this howto is people already
familiar with netdevices.
1.0 Netdevice Prerequisites
--
For hardware-based netdevices, you must h
On Tue, 2007-09-10 at 18:07 -0400, jamal wrote:
> Please provide feedback on the code and/or architecture.
> They are now updated to work with the latest rebased net-2.6.24
> from a few hours ago.
I should have added i have tested this with just the batching changes
and it is within the performan
On Tue, 2007-09-10 at 09:02 -0700, Kok, Auke wrote:
>
> if we're going to remove LLTX from e1000 I prefer to do that at a much later
> time.
> Let's focus on e1000e instead - while it is still moving ;)
I think you may be in luck ;-> I just saw a patch posted by jgarzik
which touched both e1000/
This patch removes dev->gso_skb as it is no longer necessary with
batching code.
cheers,
jamal
[NET_BATCH] kill dev->gso_skb
The batching code does what gso used to batch at the drivers.
There is no more need for gso_skb. If for whatever reason the
requeueing is a bad idea we are going to leave p
This patch adds the usage of batching within the core.
cheers,
jamal
[NET_BATCH] net core use batching
This patch adds the usage of batching within the core.
Performance results demonstrating improvement are provided separately.
I have #if-0ed some of the old functions so the patch is more reada
This patch introduces the netdevice interface for batching.
cheers,
jamal
[NET_BATCH] Introduce batching interface
This patch introduces the netdevice interface for batching.
BACKGROUND
-
A driver dev->hard_start_xmit() has 4 typical parts:
a) packet formating (example vlan, mss, descri
Please provide feedback on the code and/or architecture.
They are now updated to work with the latest rebased net-2.6.24
from a few hours ago.
I am on travel mode so wont have time to do more testing for the next
few days - i do consider this to be stable at this point based on
what i have been t
On Tue, 2007-09-10 at 14:22 -0700, David Miller wrote:
> Even if the device has "huge queues" I still think we need a software
> queue for when the hardware one backs up.
It should be fine to just "pretend" the qdisc exists despite it sitting
in the driver and not have s/ware queues at all to av
> Before you add new entries to your list, how is that ibm driver NAPI
> conversion coming along? :-)
I still haven't done much. OK, I will try to get my board booting
again this week.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECT
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 16:20:14 -0400
> David Miller wrote:
> > If you unconditionally take those locks in the transmit function,
> > there is probably an ABBA deadlock elsewhere in the driver now, most
> > likely in the TX reclaim processing, and you therefor
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Tue, 9 Oct 2007 13:53:40 -0700
> I was thinking why not have a default transmit queue len of 0 like
> the virtual devices.
I'm not so sure.
Even if the device has "huge queues" I still think we need a software
queue for when the hardware one back
From: Urs Thuermann <[EMAIL PROTECTED]>
Date: 09 Oct 2007 23:13:42 +0200
> Last week I have sent another version of our patch series for PF_CAN.
> The changes after the last review feedback were only cosmetics.
>
> Do you have any plans with that code for this or the next release?
I think PF_CAN
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Tue, 09 Oct 2007 15:00:10 -0600
> Regardless it is early yet and there is plenty of time to revisit this
> after we solved the easier and less controversial problems.
Ok.
I would encourage you to learn how the SNMP mibs work, and whether
they ass
Hallo Dave,
> 9.1MB, 739 changesets, keep those patches flowing!
Last week I have sent another version of our patch series for PF_CAN.
The changes after the last review feedback were only cosmetics.
Do you have any plans with that code for this or the next release?
Regards,
urs
-
To unsubscribe
David Miller <[EMAIL PROTECTED]> writes:
> From: [EMAIL PROTECTED] (Eric W. Biederman)
> Date: Tue, 09 Oct 2007 11:43:58 -0600
>
>> David Stevens <[EMAIL PROTECTED]> writes:
>>
>> > Sorry if this is a dumb question, but what is the model you intend for
>> > SNMP? Do you want each namespace to be
On Tue, 09 Oct 2007 13:43:31 -0700 (PDT)
David Miller <[EMAIL PROTECTED]> wrote:
> From: Andi Kleen <[EMAIL PROTECTED]>
> Date: 09 Oct 2007 18:51:51 +0200
>
> > Hopefully that new qdisc will just use the TX rings of the hardware
> > directly. They are typically large enough these days. That might
From: Roland Dreier <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 13:22:44 -0700
> I can definitely kill LLTX for IPoIB by 2.6.25 and I just added it to
> my TODO list so I don't forget.
>
> In fact if 2.6.23 drags on long enough I may do it for 2.6.24
Before you add new entries to your list, h
From: Andi Kleen <[EMAIL PROTECTED]>
Date: 09 Oct 2007 18:51:51 +0200
> Hopefully that new qdisc will just use the TX rings of the hardware
> directly. They are typically large enough these days. That might avoid
> some locking in this critical path.
Indeed, I also realized last night that for th
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 22:36:37 +0800
> [IPSEC]: Move state lock into x->type->output
>
> This patch releases the lock on the state before calling x->type->output.
> It also adds the lock to the spots where they're currently needed.
>
> Most of those places (
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 22:36:36 +0800
> [IPSEC]: Lock state when copying non-atomic fields to user-space
>
> This patch adds locking so that when we're copying non-atomic fields such as
> life-time or coaddr to user-space we don't get a partial result.
>
> Fo
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 22:36:35 +0800
> [XFRM] user: Move attribute copying code into copy_to_user_state_extra
>
> Here's a good example of code duplication leading to code rot. The
> notification patch did its own netlink message creation for xfrm states.
>
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 22:36:34 +0800
> [IPSEC]: Move common code into xfrm_alloc_spi
>
> This patch moves some common code that conceptually belongs to the xfrm core
> from af_key/xfrm_user into xfrm_alloc_spi.
>
> In particular, the spin lock on the state i
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 22:36:33 +0800
> [IPSEC]: Remove gratuitous km wake-up events on ACQUIRE
>
> There is no point in waking people up when creating/updating larval states
> because they'll just go back to sleep again as larval states by definition
> cannot
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 22:36:32 +0800
> [IPSEC]: Store IPv6 nh pointer in mac_header on output
>
> Current the x->mode->output functions store the IPv6 nh pointer in the
> skb network header. This is inconvenient because the network header then
> has to be fi
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 22:36:31 +0800
> [IPSEC]: Remove bogus ref count in xfrm_secpath_reject
>
> Constructs of the form
>
> xfrm_state_hold(x);
> foo(x);
> xfrm_state_put(x);
>
> tend to be broken because foo is either synchronous where t
> I'd say we can probably try to get rid of it in 2.6.25, this is
> assuming we get driver authors to cooperate and do the conversions
> or alternatively some other motivated person.
>
> I can just threaten to do them all and that should get the driver
> maintainers going :-)
I can definite
David Miller wrote:
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 08:44:25 -0400
David Miller wrote:
From: Krishna Kumar2 <[EMAIL PROTECTED]>
Date: Tue, 9 Oct 2007 16:51:14 +0530
David Miller <[EMAIL PROTECTED]> wrote on 10/09/2007 04:32:55 PM:
Ignore LLTX, it sucks, it was
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 08:44:25 -0400
> David Miller wrote:
> > From: Krishna Kumar2 <[EMAIL PROTECTED]>
> > Date: Tue, 9 Oct 2007 16:51:14 +0530
> >
> >> David Miller <[EMAIL PROTECTED]> wrote on 10/09/2007 04:32:55 PM:
> >>
> >>> Ignore LLTX, it sucks, it w
From: David Stevens <[EMAIL PROTECTED]>
Date: Tue, 9 Oct 2007 09:18:25 -0700
> Ifindex's have to uniquely identify the interface (virtual or
> otherwise) to remote queriers (not just local applications), so
> unless you pay the price of separating all the SNMP MIBs per
> namespace too, it seems yo
From: Pavel Emelyanov <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 16:19:25 +0400
> Currently indexes for netdevices come sequentially one by
> one, and the same stays true even for devices that are
> created for namespaces.
>
> Side effects of this are:
> * lo device has not 1 index in a namespa
From: [EMAIL PROTECTED] (Eric W. Biederman)
Date: Tue, 09 Oct 2007 11:43:58 -0600
> David Stevens <[EMAIL PROTECTED]> writes:
>
> > Sorry if this is a dumb question, but what is the model you intend for
> > SNMP? Do you want each namespace to be its own virtual machine with
> > its own, separate
From: Pavel Emelyanov <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 15:48:19 +0400
> The newly created net namespace is set to 0 with memset()
> in setup_net(). The setup_net() is also called for the
> init_net_ns(), which is zeroed naturally as a global var.
>
> So remove this memset and allocate n
> A misunderstanding, I think.
>
> To my brain, DaveM's item #2 seemed to assume/require the NIC
> hardware to balance fairly across hw TX rings, which seemed
> to preclude the
> 8139cp/tg3 style of strict-prio hardware. That's what I was
> responding to.
>
> As long as there is some modular
Hi,
On Mon, Oct 08, 2007 at 05:58:36PM +0200, Karsten Keil wrote:
> You could try following patch with 2.6.23-rc8-mm2, it change I4L to use
> alloc_netdev().
I just did the horribly unthinkable:
I rebooted the production internet gateway *remotely*, and:
[EMAIL PROTECTED]:/home/andi# uname -a
Li
Waskiewicz Jr, Peter P wrote:
IMO the net driver really should provide a hint as to what it wants.
8139cp and tg3 would probably prefer multiple TX queue
behavior to match silicon behavior -- strict prio.
If I understand what you just said, I disagree. If your hardware is
running strict prio
> IMO the net driver really should provide a hint as to what it wants.
>
> 8139cp and tg3 would probably prefer multiple TX queue
> behavior to match silicon behavior -- strict prio.
If I understand what you just said, I disagree. If your hardware is
running strict prio, you don't want to enfor
Keep tx and rx elements separate on different cachelines to prevent
bouncing.
Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
Cc: Stephen Hemminger <[EMAIL PROTECTED]>
Cc: Christoph Hellwig <[EMAIL PROTECTED]>
---
drivers/net/xen-netfront.c | 37 ++---
1
> I wonder about the whole idea of queueing in general at such high speeds.
> Given the normal bi-modal distribution of packets, and the predominance
> of 1500 byte MTU; does it make sense to even have any queueing in software
> at all?
Yes that is my point -- it should just pass it through direct
On 09 Oct 2007 18:51:51 +0200
Andi Kleen <[EMAIL PROTECTED]> wrote:
> David Miller <[EMAIL PROTECTED]> writes:
> >
> > 2) Switch the default qdisc away from pfifo_fast to a new DRR fifo
> >with load balancing using the code in #1. I think this is kind
> >of in the territory of what Peter
David Stevens <[EMAIL PROTECTED]> writes:
> Sorry if this is a dumb question, but what is the model you intend for
> SNMP? Do you want each namespace to be its own virtual machine with
> its own, separate MIB?
Each network namespace appears to user space as a completely separate
network stack. S
Pavel Emelyanov <[EMAIL PROTECTED]> writes:
> Currently indexes for netdevices come sequentially one by
> one, and the same stays true even for devices that are
> created for namespaces.
>
> Side effects of this are:
> * lo device has not 1 index in a namespace. This may break
>some userspac
David Miller <[EMAIL PROTECTED]> writes:
>
> 2) Switch the default qdisc away from pfifo_fast to a new DRR fifo
>with load balancing using the code in #1. I think this is kind
>of in the territory of what Peter said he is working on.
Hopefully that new qdisc will just use the TX rings of
Sorry if this is a dumb question, but what is the model you intend for
SNMP? Do you want each namespace to be its own virtual machine with
its own, separate MIB?
Ifindex's have to uniquely identify the interface (virtual or otherwise)
to remote
queriers (not just local applications), so unless yo
On Mon, 2007-10-08 at 21:29 -0700, David Miller wrote:
> From: "Eliezer Tamir" <[EMAIL PROTECTED]>
> Date: Tue, 09 Oct 2007 06:13:23 +0200
>
> > Due to the size of the patch I can not post it to the list.
>
> Understood
>
> > Here is an FTP link.
> > ftp://[EMAIL PROTECTED]/bnx2x-0.40.10-net-2.6
Just switch to the consolidated code.
Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
Cc: Neil Brown <[EMAIL PROTECTED]>
---
diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
index ebe344f..8e05557 100644
--- a/net/sunrpc/cache.c
+++ b/net/sunrpc/cache.c
@@ -1218,23 +1218,15 @@ static cons
Just switch to the consolidated code
Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
Cc: Samuel Ortiz <[EMAIL PROTECTED]>
---
diff --git a/net/irda/irlap.c b/net/irda/irlap.c
index 3d76aaf..f3236ac 100644
--- a/net/irda/irlap.c
+++ b/net/irda/irlap.c
@@ -1219,29 +1219,11 @@ static const struc
Just switch to the consolidated code.
Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
Cc: Patrick Caulfield <[EMAIL PROTECTED]>
---
diff --git a/net/decnet/dn_neigh.c b/net/decnet/dn_neigh.c
index b66e3be..e851b14 100644
--- a/net/decnet/dn_neigh.c
+++ b/net/decnet/dn_neigh.c
@@ -580,24 +580,
jamal wrote:
> On Mon, 2007-08-10 at 15:40 -0700, Kok, Auke wrote:
>
>> My biggest problem with the patch as you sent it that it's a tonload of
>> changes
>> and no implicit benefit immediately as I can see.
>
> The patch looks scary but is pretty tame when you apply it and stare at
> it.
>
>>
This concerns the ipv4 and ipv6 code mostly, but also the netlink
and unix sockets.
The netlink code is an example of how to use the __seq_open_private()
call - it saves the net namespace on this private.
Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
---
diff --git a/net/ipv4/arp.c b/net/i
Just switch to the consolidated calls.
ipt_recent() has to initialize the private, so use
the __seq_open_private() helper.
Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]>
Cc: Patrick McHardy <[EMAIL PROTECTED]>
---
diff --git a/net/ipv4/netfilter/ipt_recent.c b/net/ipv4/netfilter/ipt_recent.
1 - 100 of 152 matches
Mail list logo
