Fix inconsistency of terms:
1) D-SACK
2) F-RTO
Signed-off-by: Ryousei Takano <[EMAIL PROTECTED]>
---
Documentation/networking/ip-sysctl.txt |6 +++---
net/ipv4/tcp_input.c | 16
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/Documentatio
From: "Ilpo Järvinen" <[EMAIL PROTECTED]>
Subject: Re: [RFC][PATCH 1/2] TCP: fix lost retransmit detection
Date: Mon, 8 Oct 2007 14:11:55 +0300 (EEST)
> On Sun, 7 Oct 2007, TAKANO Ryousei wrote:
>
> > From: "Ilpo Järvinen" <[EMAIL PROTECTED]>
> > Subject: Re: [RFC][PATCH 1/2] TCP: fix lost retran
> -Original Message-
> From: Herbert Xu [mailto:[EMAIL PROTECTED]
> Sent: den 9 oktober 2007 05:17
> To: [EMAIL PROTECTED]
> Cc: netdev@vger.kernel.org
> Subject: Re: raw PF_PACKET protocol selection
>
> Joakim Tjernlund <[EMAIL PROTECTED]> wrote:
> >
> > I trying to open my own raw P
> -Original Message-
> From: Jeff Garzik [mailto:[EMAIL PROTECTED]
> Sent: den 9 oktober 2007 01:57
> To: David Miller
> Cc: [EMAIL PROTECTED]; netdev@vger.kernel.org
> Subject: Re: Fixed PHY regression
>
> David Miller wrote:
> > From: "Joakim Tjernlund" <[EMAIL PROTECTED]>
> > Date:
On Mon, Oct 08, 2007 at 05:28:21PM -0700, David Miller ([EMAIL PROTECTED])
wrote:
> From: Evgeniy Polyakov <[EMAIL PROTECTED]>
> Date: Mon, 8 Oct 2007 16:20:40 +0400
>
> > Dave, is there any chance it can be accepted for upcoming release?
>
> Does a Russian drink vodka? :-)
I strongly feel ther
From: "Eliezer Tamir" <[EMAIL PROTECTED]>
Date: Tue, 09 Oct 2007 06:13:23 +0200
> Due to the size of the patch I can not post it to the list.
Understood
> Here is an FTP link.
> ftp://[EMAIL PROTECTED]/bnx2x-0.40.10-net-2.6.24-one.patch.txt
>
> Or if you prefer, I can post it gzipped.
I took a
David Miller wrote:
From: "Eliezer Tamir" <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 18:15:17 +0200
Add bnx2x to Kconfig and Makefile
In a patch submission, the tree should build on every step along the
way in applying your patches, with any given configuration.
Here, the user (or something
On Wed, Sep 19, 2007 at 10:43:03PM -0400, jamal wrote:
>
> [NET_SCHED] explict hold dev tx lock
>
> For N cpus, with full throttle traffic on all N CPUs, funneling traffic
> to the same ethernet device, the devices queue lock is contended by all
> N CPUs constantly. The TX lock is only contended b
From: Benjamin Thery <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 18:33:16 +0200
> In ip6_fib.c, fib6_clean_node() casts a fib6_walker_t pointer to
> a fib6_cleaner_t pointer assuming a struct fib6_walker_t (field 'w')
> is the first field in struct fib6_walker_t.
>
> To prevent any future problems
From: Pavel Emelyanov <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 17:20:01 +0400
> With the net namespaces many code leaved the __init section,
> thus making the kernel occupy more memory than it did before.
> Since we have a config option that prohibits the namespace
> creation, the functions that
From: Karsten Keil <[EMAIL PROTECTED]>
Date: Mon, 8 Oct 2007 17:58:36 +0200
> On Sun, Oct 07, 2007 at 07:20:37PM +0200, Andreas Mohr wrote:
> > Hi,
> >
> > On Sun, Oct 07, 2007 at 03:17:24PM +0200, Andreas Mohr wrote:
> > > I thus decided to now try plain 2.6.23-rc8 whether it's "corrupted", too.
From: Ursula Braun <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 17:05:05 +0200
> From: Ursula Braun <[EMAIL PROTECTED]>
>
> A net_device struct provides field dev_id. It is used for
> unique ipv6 generation in case of shared network cards
> (as for the OSA network cards of IBM System z).
> If VLAN
Joakim Tjernlund <[EMAIL PROTECTED]> wrote:
>
> I trying to open my own raw PF_PACKET socket to receive
> pkgs sent to this socket. I can only make ETH_P_ALL protocol
> work, but then I receive all pkgs and I want pkgs with a specific
> protocol type. I have tried lots of ETH_P types and none of
J Hadi Salim <[EMAIL PROTECTED]> wrote on 10/08/2007 06:47:24 PM:
> two, there should _never_ be any requeueing even if LLTX in the previous
> patches when i supported them; if there is, it is a bug. This is because
> we dont send more than what the driver asked for via xmit_win. So if it
> asked
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 9 Oct 2007 10:16:20 +0800
> On Mon, Oct 08, 2007 at 10:14:30PM -0400, jamal wrote:
> >
> > You forgot QDISC_RUNNING Dave;-> the above cant happen.
> > Essentially at any one point in time, we are guaranteed that we can have
> > multiple cpus enqueue
On Mon, Oct 08, 2007 at 07:43:43PM -0700, David Miller wrote:
>
> Right, that's Jamal's recent patch. It looked funny to me too.
Hang on Dave. It was too early in the morning for me :)
I'd forgotten about the QDISC_RUNNING bit which did what the
queue lock did without actually holding the queu
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 22:12:03 -0400
> I'm interested in working on a load balancer function that approximates
>
> skb->queue_mapping = smp_processor_id()
>
> I'd be happy to code and test in that direction, based on your lib.
It's the second algorit
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 9 Oct 2007 10:04:42 +0800
> On Tue, Oct 09, 2007 at 10:03:18AM +0800, Herbert Xu wrote:
> > On Tue, Oct 09, 2007 at 10:01:15AM +0800, Herbert Xu wrote:
> > > On Mon, Oct 08, 2007 at 06:41:26PM -0700, David Miller wrote:
> > > >
> > > > I also want to
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 9 Oct 2007 10:03:18 +0800
> On Tue, Oct 09, 2007 at 10:01:15AM +0800, Herbert Xu wrote:
> > On Mon, Oct 08, 2007 at 06:41:26PM -0700, David Miller wrote:
> > >
> > > I also want to point out another issue. Any argument wrt. reordering
> > > is speci
On Mon, Oct 08, 2007 at 10:19:02PM -0400, jamal wrote:
> On Tue, 2007-09-10 at 10:16 +0800, Herbert Xu wrote:
>
> >
> > No it doesn't. I'd forgotten about the QDISC_RUNNING bit :)
>
> You should not better, you wrote it and ive been going insane trying to
> break for at least a year now ;->
We
On Tue, 2007-09-10 at 10:16 +0800, Herbert Xu wrote:
>
> No it doesn't. I'd forgotten about the QDISC_RUNNING bit :)
You should not better, you wrote it and ive been going insane trying to
break for at least a year now ;->
cheers,
jamal
-
To unsubscribe from this list: send the line "unsubscr
On Mon, Oct 08, 2007 at 10:15:49PM -0400, jamal wrote:
> On Tue, 2007-09-10 at 10:04 +0800, Herbert Xu wrote:
>
> > Please revert
> >
> > commit 41843197b17bdfb1f97af0a87c06d24c1620ba90
> > Author: Jamal Hadi Salim <[EMAIL PROTECTED]>
> > Date: Tue Sep 25 19:27:13 2007 -0700
> >
> > [NET_S
On Mon, Oct 08, 2007 at 10:14:30PM -0400, jamal wrote:
>
> You forgot QDISC_RUNNING Dave;-> the above cant happen.
> Essentially at any one point in time, we are guaranteed that we can have
> multiple cpus enqueueing but only can be dequeueing (the one that
> managed to grab QDISC_RUNNING) i.e mul
On Tue, 2007-09-10 at 10:04 +0800, Herbert Xu wrote:
> Please revert
>
> commit 41843197b17bdfb1f97af0a87c06d24c1620ba90
> Author: Jamal Hadi Salim <[EMAIL PROTECTED]>
> Date: Tue Sep 25 19:27:13 2007 -0700
>
> [NET_SCHED]: explict hold dev tx lock
>
> As this change introduces potential
On Mon, 2007-08-10 at 18:41 -0700, David Miller wrote:
> I also want to point out another issue. Any argument wrt. reordering
> is specious at best because right now reordering from qdisc to device
> happens anyways.
>
> And that's because we drop the qdisc lock first, then we grab the
> transmit
David Miller wrote:
1) A library for transmit load balancing functions, with an interface
that can be made visible to userspace. I can write this and test
it on real multiqueue hardware.
The whole purpose of this library is to set skb->queue_mapping
based upon the load balancing fun
On Tue, Oct 09, 2007 at 10:03:18AM +0800, Herbert Xu wrote:
> On Tue, Oct 09, 2007 at 10:01:15AM +0800, Herbert Xu wrote:
> > On Mon, Oct 08, 2007 at 06:41:26PM -0700, David Miller wrote:
> > >
> > > I also want to point out another issue. Any argument wrt. reordering
> > > is specious at best bec
On Mon, Oct 08, 2007 at 06:41:26PM -0700, David Miller wrote:
>
> I also want to point out another issue. Any argument wrt. reordering
> is specious at best because right now reordering from qdisc to device
> happens anyways.
This is not true.
If your device has a qdisc at all, then you will end
On Tue, Oct 09, 2007 at 10:01:15AM +0800, Herbert Xu wrote:
> On Mon, Oct 08, 2007 at 06:41:26PM -0700, David Miller wrote:
> >
> > I also want to point out another issue. Any argument wrt. reordering
> > is specious at best because right now reordering from qdisc to device
> > happens anyways.
>
David Miller wrote:
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 10:22:28 -0400
In terms of overall parallelization, both for TX as well as RX, my gut
feeling is that we want to move towards an MSI-X, multi-core friendly
model where packets are LIKELY to be sent and received by
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 21:13:59 -0400
> If you assume a scheduler implementation where each prio band is mapped
> to a separate CPU, you can certainly see where some CPUs could be
> substantially idle while others are overloaded, largely depending on the
>
jamal wrote:
The challenge to deal with is that netdevices, filters, the queues and
scheduler are closely inter-twined. So it is not just the scheduling
region and QDISC_RUNNING. For example, lets pick just the filters
because they are simple to see: You need to attach them to something -
whateve
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Tue, 9 Oct 2007 09:02:57 +0800
> On Mon, Oct 08, 2007 at 05:17:17PM -0700, David Miller wrote:
> >
> > Could you submit a 2.6.23 version of just the ipv4 fix?
> > It might be interesting to determine why it was omitted,
> > perhaps it was an oversight, a
jamal wrote:
Ok, so the "concurency" aspect is what worries me. What i am saying is
that sooner or later you have to serialize (which is anti-concurency)
For example, consider CPU0 running a high prio queue and CPU1 running
the low prio queue of the same netdevice.
Assume CPU0 is getting a lot of
On Mon, Oct 08, 2007 at 05:17:17PM -0700, David Miller wrote:
>
> Could you submit a 2.6.23 version of just the ipv4 fix?
> It might be interesting to determine why it was omitted,
> perhaps it was an oversight, and it probably predates the
> addition of skb_reset_*().
OK I double-checked and it
From: "Eliezer Tamir" <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 18:15:17 +0200
> Add bnx2x to Kconfig and Makefile
In a patch submission, the tree should build on every step along the
way in applying your patches, with any given configuration.
Here, the user (or something automated like "make a
From: Evgeniy Polyakov <[EMAIL PROTECTED]>
Date: Mon, 8 Oct 2007 16:20:40 +0400
> Dave, is there any chance it can be accepted for upcoming release?
Does a Russian drink vodka? :-)
I'm certainly willing to entertain the idea.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 19:29:44 +0800
> [IPSEC]: Move RO-specific output code into xfrm6_mode_ro.c
>
> The lastused update check in xfrm_output can be done just as well in
> the mode output function which is specific to RO.
>
> Signed-off-by: Herbert Xu <[EMA
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 19:29:43 +0800
> [IPSEC]: Unexport xfrm_replay_notify
>
> Now that the only callers of xfrm_replay_notify are in xfrm, we can remove
> the export.
>
> This patch also removes xfrm_aevent_doreplay since it's now called in just
> one spot
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 19:29:42 +0800
> [IPSEC]: Move output replay code into xfrm_output
>
> The replay counter is one of only two remaining things in the output code
> that requires a lock on the xfrm state (the other being the crypto). This
> patch moves i
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 19:29:41 +0800
> [IPSEC]: Move xfrm_state_check into xfrm_output.c
>
> The functions xfrm_state_check and xfrm_state_check_space are only used by
> the output code in xfrm_output.c so we can move them over.
>
> Signed-off-by: Herbert Xu
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 19:29:39 +0800
> [IPSEC]: Move common output code to xfrm_output
>
> Most of the code in xfrm4_output_one and xfrm6_output_one are identical so
> this patch moves them into a common xfrm_output function which will live
> in net/xfrm.
>
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 19:29:38 +0800
> [IPSEC] ah: Remove keys from ah_data structure
>
> The keys are only used during initialisation so we don't need to carry them
> in esp_data. Since we don't have to allocate them again, there is no need
> to place a lim
From: Herbert Xu <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 19:29:37 +0800
> [IPSEC] esp: Remove keys from esp_data structure
>
> The keys are only used during initialisation so we don't need to carry them
> in esp_data. Since we don't have to allocate them again, there is no need
> to place a l
David Miller wrote:
From: "Joakim Tjernlund" <[EMAIL PROTECTED]>
Date: Mon, 8 Oct 2007 20:17:33 +0200
David, any chance the second item, Oops while modprobing phy fixed module, in
http://marc.info/?l=linux-kernel&m=119178673421891&w=2
will make it into 2.6.23?
The fix is now in your tree,
ht
On Mon, 2007-08-10 at 15:33 -0700, David Miller wrote:
> Multiply whatever effect you think you might be able to measure due to
> that on your 2 or 4 way system, and multiple it up to 64 cpus or so
> for machines I am using. This is where machines are going, and is
> going to become the norm.
Ye
On Mon, 2007-08-10 at 15:33 -0700, Waskiewicz Jr, Peter P wrote:
> Addressing your note/issue with different rings being services
> concurrently: I'd like to remove the QDISC_RUNNING bit from the global
The challenge to deal with is that netdevices, filters, the queues and
scheduler are closely
Fix warnings from sparse related to shadowed variables and routines
that should be declared static.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
---
CHECK drivers/net/cxgb3/cxgb3_main.c
drivers/net/cxgb3/cxgb3_main.c:1773:20: warning: symbol 'pi' shadows an earlier
one
drivers/net/cx
Fix problems detected by sparse:
1. whole chunk of MAC code was for defined and never used
2. hook for running ext intr in workqueue wasn't being used
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
--- a/drivers/net/chelsio/Makefile 2007-10-04 09:33:28.0 -0700
+++ b/drivers/ne
From: Oliver Hartkopp <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 18:01:20 +0200
> David Miller wrote:
> > +
> > +static int link_status_1g(struct niu *np, int *link_up_p)
...
> Should *link_up_p be set to any value before returning?
...
> > +out:
> > + spin_unlock_irqrestore(&np->lock, flags);
From: Steve Wise <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 17:46:26 -0500
> We're talking about just for pktgen...eh?
My bad, I'm happy to review a patch that uses the
skb->destructor in pktgen to achieve this.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a
David Miller wrote:
From: Ben Greear <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 14:57:13 -0700
This skb recycling can certainly work and has been done several
times before. It never gets into the kernel though.
Because it doesn't work.
A socket can hang onto a receive packet essentially f
jamal wrote:
> Ok, here you go; the explanation is below. This is from net-2.6.24 of
> early this AM. I saw a patch you posted that is derived from Krishna;
> although it hasnt showed up in the tree - i have considered those
> changes and this patch adds a little more optimization in case of
> erro
> If net_device_subqueue is visible from both driver and core
> scheduler area (couldnt tell from looking at whats in there
> already), then that'll do it.
Yes, I use the net_device_subqueue structs (the state variable in there)
in the prio and rr qdiscs right now. It's an indexed list at the
> Multiply whatever effect you think you might be able to
> measure due to that on your 2 or 4 way system, and multiple
> it up to 64 cpus or so for machines I am using. This is
> where machines are going, and is going to become the norm.
That along with speeds going to 10 GbE with multiple Tx
On Mon, 2007-08-10 at 14:26 -0700, David Miller wrote:
> Add xmit_win to struct net_device_subqueue, problem solved.
If net_device_subqueue is visible from both driver and core scheduler
area (couldnt tell from looking at whats in there already), then that'll
do it.
cheers,
jamal
-
To unsubscr
> true, that needs some resolution. Heres a hand-waving thought:
> Assuming all packets of a specific map end up in the same
> qdiscn queue, it seems feasible to ask the qdisc scheduler to
> give us enough packages (ive seen people use that terms to
> refer to packets) for each hardware ring's a
From: jamal <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 18:30:18 -0400
> Very quickly there are no more packets for it to dequeue from the
> qdisc or the driver is stoped and it has to get out of there. If you
> dont have any interupt tied to a specific cpu then you can have many
> cpus enter and l
On Mon, 2007-08-10 at 14:11 -0700, David Miller wrote:
> The problem is that the packet schedulers want global guarantees
> on packet ordering, not flow centric ones.
>
> That is the issue Jamal is concerned about.
indeed, thank you for giving it better wording.
> The more I think about it, th
From: Ben Greear <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 14:57:13 -0700
> This skb recycling can certainly work and has been done several
> times before. It never gets into the kernel though.
Because it doesn't work.
A socket can hang onto a receive packet essentially forever.
You cannot th
Steve Wise wrote:
Ben Greear wrote:
Rick Jones wrote:
Perf-wise, you could clone the skbs up front, then deliver them to
the nic in a tight loop. This would mitigate the added overhead
introduced by calling skb_clone() in the loop doing transmits...
That only works if you are sending a sm
David Miller wrote:
From: Sean Hefty <[EMAIL PROTECTED]>
Date: Thu, 09 Aug 2007 14:40:16 -0700
Steve Wise wrote:
Any more comments?
Does anyone have ideas on how to reserve the port space without using a
struct socket?
How about we just remove the RDMA stack altogether? I am not at all
k
Ben Greear wrote:
Rick Jones wrote:
Perf-wise, you could clone the skbs up front, then deliver them to
the nic in a tight loop. This would mitigate the added overhead
introduced by calling skb_clone() in the loop doing transmits...
That only works if you are sending a small number of skbs.
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Mon, 8 Oct 2007 14:03:01 -0700
> On Mon, 08 Oct 2007 14:40:22 -0700
> "Michael Chan" <[EMAIL PROTECTED]> wrote:
>
> > On Mon, 2007-10-08 at 12:08 -0700, Stephen Hemminger wrote:
> > > On Mon, 08 Oct 2007 20:34:41 +0200
> > > "Eliezer" <[EMAIL PROT
From: jamal <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 16:48:50 -0400
> On Mon, 2007-08-10 at 12:46 -0700, Waskiewicz Jr, Peter P wrote:
>
> > I still have concerns how this will work with Tx multiqueue.
> > The way the batching code looks right now, you will probably send a
> > batch of skb'
From: "Joakim Tjernlund" <[EMAIL PROTECTED]>
Date: Mon, 8 Oct 2007 20:17:33 +0200
>
> David, any chance the second item, Oops while modprobing phy fixed module, in
> http://marc.info/?l=linux-kernel&m=119178673421891&w=2
> will make it into 2.6.23?
>
> The fix is now in your tree,
> http://git.
From: Jeff Garzik <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 10:22:28 -0400
> In terms of overall parallelization, both for TX as well as RX, my gut
> feeling is that we want to move towards an MSI-X, multi-core friendly
> model where packets are LIKELY to be sent and received by the same set
>
From: jamal <[EMAIL PROTECTED]>
Date: Mon, 08 Oct 2007 09:34:50 -0400
> The brain-block i am having is the parallelization aspect of it.
> Whatever scheme it is - it needs to ensure the scheduler works as
> expected. For example, if it was a strict prio scheduler i would expect
> that whatever goe
On Mon, 08 Oct 2007 14:40:22 -0700
"Michael Chan" <[EMAIL PROTECTED]> wrote:
> On Mon, 2007-10-08 at 12:08 -0700, Stephen Hemminger wrote:
> > On Mon, 08 Oct 2007 20:34:41 +0200
> > "Eliezer" <[EMAIL PROTECTED]> wrote:
> >
> > > > * The MACRO's for 64 bit stats look like they could be done with
On Mon, 2007-08-10 at 12:46 -0700, Waskiewicz Jr, Peter P wrote:
> I still have concerns how this will work with Tx multiqueue.
> The way the batching code looks right now, you will probably send a
> batch of skb's from multiple bands from PRIO or RR to the driver. For
> non-Tx multiqueue d
On Mon, 2007-10-08 at 12:08 -0700, Stephen Hemminger wrote:
> On Mon, 08 Oct 2007 20:34:41 +0200
> "Eliezer" <[EMAIL PROTECTED]> wrote:
>
> > > * The MACRO's for 64 bit stats look like they could be done with
> > > u64 and/or turned into inline's.
> >
> > The MACRO's modify some of their argum
Ive attached a small pdf with results. This adds on top of results I
posted yesterday (although i didnt see them reflected on netdev).
1) "batch-ntlst" is the patches posted today that remove the temporary
list in qdisc restart and is derived from this AM net-2.6.24
2) "batch-kern" is result of b
> -Original Message-
> From: J Hadi Salim [mailto:[EMAIL PROTECTED] On Behalf Of jamal
> Sent: Monday, October 08, 2007 11:27 AM
> To: David Miller
> Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED];
> [EMAIL PROTECTED]; [EMAIL PROTECTED];
> [EMAIL PROTECTED]; [EMAIL PROTECTED];
> [EMAIL PROTECT
On Mon, 2007-10-08 at 12:08 -0700, Stephen Hemminger wrote:
> On Mon, 08 Oct 2007 20:34:41 +0200
> "Eliezer" <[EMAIL PROTECTED]> wrote:
>
> > On Mon, 2007-10-08 at 10:29 -0700, Stephen Hemminger wrote:
> >
> > >
> > > Looks good. Some minor stuff:
> > > * You can use network device stats in net
On Mon, 08 Oct 2007 20:34:41 +0200
"Eliezer" <[EMAIL PROTECTED]> wrote:
> On Mon, 2007-10-08 at 10:29 -0700, Stephen Hemminger wrote:
>
> >
> > Looks good. Some minor stuff:
> > * You can use network device stats in network device structure and
> > no longer need the copy in bp
>
> We can't
Here are FTP links.
All the parts in a zipped tar.
ftp://[EMAIL PROTECTED]/bnx2x-0.40.10-net-2.6.24.tgz
One big patch.
ftp://[EMAIL PROTECTED]/bnx2x-0.40.10-net-2.6.24-one.patch.txt
I noticed that the big microcode files did not seem to get through to netdev,
so here they are:
ftp://[EMAIL PROT
Hi List
I trying to open my own raw PF_PACKET socket to receive
pkgs sent to this socket. I can only make ETH_P_ALL protocol
work, but then I receive all pkgs and I want pkgs with a specific
protocol type. I have tried lots of ETH_P types and none of them work.
Naturally I make sure the sender is
On Mon, 2007-10-08 at 10:29 -0700, Stephen Hemminger wrote:
>
> Looks good. Some minor stuff:
> * You can use network device stats in network device structure and
> no longer need the copy in bp
We can't use net device stats in the bp because the elements are also
used by HW and we can't rear
This patch removes dev->gso_skb as it is no longer necessary with
batching code.
cheers,
jamal
[NET_BATCH] kill dev->gso_skb
The batching code does what gso used to batch at the drivers.
There is no more need for gso_skb. If for whatever reason the
requeueing is a bad idea we are going to leave p
You are correct, I have tested back to 2.6.18 and the bug is still here. So I
don't know when the problem did NOT occur.
François-Frédéric
-Message d'origine-
De : Andrew Morton [mailto:[EMAIL PROTECTED]
Envoyé : lundi 8 octobre 2007 19:11
À : François-Frédéric Ozog
Cc : [EMAIL PROTECTE
This patch adds the usage of batching within the core.
cheers,
jamal
[NET_BATCH] net core use batching
This patch adds the usage of batching within the core.
Performance results demonstrating improvement are provided separately.
I have #if-0ed some of the old functions so the patch is more read
This patch introduces the netdevice interface for batching.
cheers,
jamal
[NET_BATCH] Introduce batching interface
This patch introduces the netdevice interface for batching.
BACKGROUND
-
A driver dev->hard_start_xmit() has 4 typical parts:
a) packet formating (example vlan, mss, descr
Please provide feedback on the code and/or architecture.
Last time i posted them i received little. They are now updated to
work with the latest net-2.6.24 from a few hours ago.
Patch 1: Introduces batching interface
Patch 2: Core uses batching interface
Patch 3: get rid of dev->gso_skb
What ha
From: Stephen Hemminger <[EMAIL PROTECTED]>
Already upstream.
After resume, driver has reset the chip so the current state
of transmit checksum offload state machine and DMA state machine
will be undefined.
The fix is to set the state so that first Tx will set MSS and offset
values.
Signed-off-
This is an updated driver howto for batching that works with patches
from yesterday and the revised ones i am going to post.
cheers,
jamal
Here's the beginning of a howto for driver authors.
The intended audience for this howto is people already
familiar with netdevices.
1.0 Netdevice Prerequis
From: Stephen Hemminger <[EMAIL PROTECTED]>
Already upstream.
The length check for truncated frames was not correctly handling
the case where VLAN acceleration had already read the tag.
Also, the Yukon EX has some features that use high bit of status
as security tag.
Signed-off-by: Pierre-Yves R
From: Stephen Hemminger <[EMAIL PROTECTED]>
This is the 2.6.22 version of a regression fix that is already
in 2.6.23. Change the watchdog timer form 10 per second all the time,
to 1 per second and only if interface is up.
Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]>
Signed-off-by: Greg K
Kanevsky, Arkady wrote:
Sean,
IB aside,
it looks like an ULP which is capable of being both RDMA aware and RDMA
not-aware,
like iSER and iSCSI, NFS-RDMA and NFS, SDP and sockets,
will be treated as two separete ULPs.
Each has its own IP address, since there is a different IP address for
iWARP
On Mon, 8 Oct 2007 13:48:44 +0200
Karsten Keil <[EMAIL PROTECTED]> wrote:
> On Sun, Oct 07, 2007 at 02:06:53PM +0200, Andreas Mohr wrote:
> > [not necessarily a very recent regression, used 2.6.19 kernels before...]
> >
> > Hi all,
> >
> > wondered why my main internet server (headless!) didn't
On Mon, 08 Oct 2007 14:34:45 +0200
"Eliezer Tamir" <[EMAIL PROTECTED]> wrote:
> [resubmitting, this time without line breaks, sorry]
>
> This is an initial version of the BNX2X, the Linux driver for the
> BCM5771X 10Gb Ethernet controller family.
>
> Although the chip is very different from the
On Mon, 2007-10-08 at 08:18 +0100, Christoph Hellwig wrote:
> Just curious: is there a diagram somewhere that shows the relation of
> the various tg3 chips to each other and what families exist?
>
Some high level descriptions of some of the chips can be found here:
http://www.broadcom.com/prod
(please respond via emailed reply-to-all, not vie the bugzilla web interface)
On Mon, 8 Oct 2007 09:18:02 -0700 (PDT) [EMAIL PROTECTED] wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=9132
>
>Summary: fcntl GET_OWN reports 0 for sockets instead of PID
>Product: Netw
On Mon, 8 Oct 2007 16:02:48 +0300 Matti Aarnio wrote:
> On Mon, Oct 08, 2007 at 02:34:45PM +0200, Eliezer Tamir wrote:
> > Message-ID: <[EMAIL PROTECTED]>
> > Date: Mon, 08 Oct 2007 14:34:45 +0200
> > From: Eliezer Tamir <[EMAIL PROTECTED]>
> > User-Agent: Thunderbird 2.0.0.6 (X11/20070728)
> > MI
In ip6_fib.c, fib6_clean_node() casts a fib6_walker_t pointer to
a fib6_cleaner_t pointer assuming a struct fib6_walker_t (field 'w')
is the first field in struct fib6_walker_t.
To prevent any future problems that may occur if one day a field
is inadvertently inserted before the 'w' field in struc
bnx2x_init.h - code that does chip init
From 8ef995a3102800d70b677aefb6e769c0d36e178c Mon Sep 17 00:00:00 2001
From: Eliezer Tamir <[EMAIL PROTECTED]>
Date: Mon, 8 Oct 2007 11:53:17 +0200
Subject: [PATCH 5/8] add bnx2x_init.h
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2
bnx2x.h - main .h file
From c32bf79956add229de2e4b81a848fad0e503d3d0 Mon Sep 17 00:00:00 2001
From: Eliezer Tamir <[EMAIL PROTECTED]>
Date: Mon, 8 Oct 2007 11:53:14 +0200
Subject: [PATCH 3/8] add bnx2x.h
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
drivers/net/bnx2x.h | 997 +++
[sorry for the mess. resubmitting, this time using attachments, if this
does not work I'm going to go nuts.]
This is an initial version of the BNX2X, the Linux driver for the
BCM5771X 10Gb Ethernet controller family.
Although the chip is very different from the 5706-8 family we based the
driver
Add bnx2x to Kconfig and Makefile
From 94bf385550356534e6dd41ce61879608a63ed972 Mon Sep 17 00:00:00 2001
From: Eliezer Tamir <[EMAIL PROTECTED]>
Date: Mon, 8 Oct 2007 11:48:10 +0200
Subject: [PATCH 1/8] add bnx2x to Kconfig and Makefile
Signed-off-by: Eliezer Tamir <[EMAIL PROTECTED]>
---
driv
"Denis V. Lunev" <[EMAIL PROTECTED]> writes:
> David Miller wrote:
>> From: "Denis V. Lunev" <[EMAIL PROTECTED]>
>> Date: Mon, 08 Oct 2007 10:34:23 +0400
>>
>>> OK. I am installing Fedora 7 right now...
>>
>> You don't need to install Fedora, just read the code! :-)
>>
>> The bug is obvious and
David Miller wrote:
if (err < 0)
- return err;
+ goto out_err;
if (err != (PHYXS_XGXS_LANE_STAT_ALINGED |
PHYXS_XGXS_LANE_STAT_MAGIC |
@@ -1133,6 +1133,10 @@ out:
*link_up_p = link_up;
return 0;
+
+out_err:
+ spin_unl
1 - 100 of 152 matches
Mail list logo
