[PATCH 3/4 Rev-3] Initilize and populate age field

The age field is filled with the current time at the time of creation of the route. When the routes are dumped then the age value stored in the route structure is subtracted from the current time value and the difference is the age expressed in secs. Signed-off-by: Varun Chandramohan <[EMAIL PRO

[PATCH 2/4 Rev-3] Add new timeval_to_sec function

A new function for converting timeval to time_t is added in netlink.h. Its a common function used in differentplaces. The reason for adding this function in netlink.h is that its used by netlink for stats purpose. Signed-off-by: Varun Chandramohan <[EMAIL PROTECTED]> --- include/net/netlink.h |

[PATCH 1/4 Rev-3] New attribute RTA_AGE

A new attribute RTA_AGE is added for the age value to be exported to userlevel using netlink Signed-off-by: Varun Chandramohan <[EMAIL PROTECTED]> --- include/linux/rtnetlink.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/rtnetlink.h b/include/linux/rtne

[PATCH 0/4 Rev-3] Age Entry For IPv4 & IPv6 Route Table

Hi Dave, The is the next revision of the age patch. This contains changes as suggested in the last rev. Can you review and push it in? I also added the changelog below. Original Comment: According to the RFC 4292 (IP Forwarding Table MIB) there is a need for an age entry for all the rout

[PATCH 1/2] PS3: improve tx throughput for gelic driver

Improve tx throughputs. netperf score gained approximately 20% Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]> CC: Geoff Levand <[EMAIL PROTECTED]> --- drivers/net/ps3_gelic_net.c | 140 +++- 1 file changed, 63 insertions(+), 77 deletions(-)

[PATCH 0/2] PS3: gelic updates

Hi, Two updates for the gelic network driver; - Improve tx throughput - Remove work-around code no longer needed -- Masakazu MOKUNO - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.or

[PATCH 2/2] PS3: Remove the workaround no longer needed

Removed the workaround that was needed for PS3 firmware versions prior to the first release. Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]> CC: Geoff Levand <[EMAIL PROTECTED]> --- drivers/net/ps3_gelic_net.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) --- a/dr

Bug in TC

Hello all. System Gentoo. Kernel version *2.6.22.5 Lot of Traffic (above 500mbs) Many clients (above 30 000 ip) Many TC rules (abobe 5) Many iptables rules (above 10 000) All classes - HTB, All qdisc - sfq Have 1-5 times on week k

Re: [PATCH 2.6.23 0/2] cxgb3 - Fix dev->priv usage

Looks OK to me but I would just roll up the second patch into the first patch and let Jeff merge it as one commit. There's no point in creating an intermediate tree that doesn't build -- it just breaks git bisect for no useful purpose. Also as a side note, when trying to test this I got the messa

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

From: Krishna Kumar2 <[EMAIL PROTECTED]> Date: Wed, 29 Aug 2007 10:43:23 +0530 > The reason was to run parallel copies, not for buffer limitations. Oh, I see. I'll note in passing that current lmbench-3 has some parallelization features you could play with, you might want to check it out. - To u

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

[EMAIL PROTECTED] wrote on 08/29/2007 10:21:50 AM: > From: Krishna Kumar2 <[EMAIL PROTECTED]> > Date: Wed, 29 Aug 2007 08:53:30 +0530 > > > I am scp'ng from 192.168.1.1 to 192.168.1.2 and captured at the send > > side. > > Bad choice of test, this is cpu limited since the scp > has to encrypt and

Re: pktgen terminating condition

From: Mandeep Singh Baines <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 21:43:52 -0700 > Here is what the datasheet has to say about TxIdle: > > "This event is signaled when the transmit state machine enters the idle state > from a non-idle state. This will happen whenever the state machine encoun

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

From: Krishna Kumar2 <[EMAIL PROTECTED]> Date: Wed, 29 Aug 2007 08:53:30 +0530 > I am scp'ng from 192.168.1.1 to 192.168.1.2 and captured at the send > side. Bad choice of test, this is cpu limited since the scp has to encrypt and MAC hash all the data it sends. Use something like straight ftp o

Re: pktgen terminating condition

On Tue, 2007-28-08 at 20:28 -0400, jamal wrote: > On Tue, 2007-28-08 at 17:06 -0700, David Miller wrote: > > > Devices need to free packets in a deterministic amount of time, no > > matter what. > > If i understood the driver pointed to - "finite amount of time" spec is > still met. Seems some inte

[PATCH 2/2] iw_cxgb3 - dev->priv fix follow up

From: Divy Le Ray <[EMAIL PROTECTED]> The RDMA driver sitting on top of cxgb3 now uses the exported function dev2t3cdev() to retrieve the the t3cdev associated with a net_device. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/cxio_hal.c |2 +- 1 files chan

[PATCH 2.6.23 1/2] cxgb3 - Fix dev->priv usage

From: Divy Le Ray <[EMAIL PROTECTED]> cxgb3 used netdev_priv() and dev->priv for different purposes. In 2.6.23, netdev_priv() == dev->priv, cxgb3 needs a fix. This patch is a partial backport of Dave Miller's changes in the net-2.6.24 git branch. Without this fix, cxgb3 crashes on 2.6.23. Sign

[PATCH 2.6.23 0/2] cxgb3 - Fix dev->priv usage

Jeff/Roland, I'm resubmitting the cxgb3 dev->priv fix for inclusion in 2.6.23. I also submit a follow-up patch for the iw_cxgb3 driver that fixes the previous infiniband breakage. Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

Hi Dave, I am scp'ng from 192.168.1.1 to 192.168.1.2 and captured at the send side. 192.168.1.1.37201 > 192.168.1.2.ssh: P 837178092:837178596(504) ack 1976304527 win 79 192.168.1.1.37201 > 192.168.1.2.ssh: . 837178596:837181492(2896) ack 1976304527 win 79 192.168.1.1.37201 > 192.168.1.2.ssh: .

Re: net-2.6.24 rebased

From: David Miller <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 17:54:04 -0700 (PDT) > I could have sworn I did, thanks for catching that I'll fix it > up. I pushed this fix into net-2.6.24 just now, thanks again. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: net-2.6.24 rebased

From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 18:33:19 -0700 > It seems that tg3 and bnx2 still have the tx locking changes. David, > didn't you revert those changes a few weeks ago? I could have sworn I did, thanks for catching that I'll fix it up. - To unsubscribe from this l

[NET_BATCH] UPDATE

Just to let folks know: I have a couple of bug fixes i havent updated on the tree at: git://git.kernel.org/pub/scm/linux/kernel/git/hadi/batch-lin26.git If you are using the tree then either contact me or give me about a day and i will get an opportunity to update it after some testing. There are

Re: net-2.6.24 rebased

On Tue, 2007-08-28 at 17:25 -0700, David Miller wrote: > The new NAPI struct patch is in there, one caveat of the new > behavior is that in drivers that conditionalize NAPI support > we can't be lazy and do the napi_{enable,disable}() outside > of the ifdefs any longer. I tried to audit all the dr

Re: pktgen terminating condition

On Tue, 2007-28-08 at 17:06 -0700, David Miller wrote: > Devices need to free packets in a deterministic amount of time, no > matter what. If i understood the driver pointed to - "finite amount of time" spec is still met. Seems some interupt is generated (TX_IDLE) when the tx path gets idle and t

net-2.6.24 rebased

The new NAPI struct patch is in there, one caveat of the new behavior is that in drivers that conditionalize NAPI support we can't be lazy and do the napi_{enable,disable}() outside of the ifdefs any longer. I tried to audit all the drivers but I might have missed a few. tg3, 8139cp and e100 are

Re: Please pull 'upstream-davem' branch of wireless-2.6

From: "John W. Linville" <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 18:50:29 -0400 > And, of course, simply ask and I'll rebase on whatever is current when > you get to my poor pull request. :-) You are perfect! You emailed this to me exactly when I pushed the rebased net-2.6.24 tree to master.k

Re: pktgen terminating condition

I don't even understand why this needs to be discussed to be honest with you :-) Just my (possibly frustrating :) habit of asking questions which help further my understanding of the code :) rick jones - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: Crash report 2.6.22.5

On 8/28/07, Michal Piotrowski <[EMAIL PROTECTED]> wrote: > Hi Pete, > > On 28/08/07, Pete Monroe <[EMAIL PROTECTED]> wrote: > > Hi, > > > > Sorry there's not more to go on here. > > > > A 32-bit firewall running the kernel LVS virtual server to fan out to > > a dozen webservers ran fine for a year

Re: pktgen terminating condition

From: Rick Jones <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 16:48:24 -0700 > Not to defend any one driver, but could it be that the behaviour of TCP > is such that we've not noticed until now? > > Does TCP particularly care for an SKB carrying an ACK? For ones carrying > data there would be an A

Re: Crash report 2.6.22.5

Hi Pete, On 28/08/07, Pete Monroe <[EMAIL PROTECTED]> wrote: > Hi, > > Sorry there's not more to go on here. > > A 32-bit firewall running the kernel LVS virtual server to fan out to > a dozen webservers ran fine for a year using 2.6.17.13, but won't > last more than four hours or so with 2.6.22.

Re: pktgen terminating condition

David Miller wrote: From: Mandeep Singh Baines <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 15:47:18 -0700 It seems that some drivers do not immediately free skbs on transmit complete. They will hold the skb until there are more packets to free. One example is the sis900 driver which uses TX_ID

Please pull 'upstream-jgarzik' branch of wireless-2.6

Jeff, A few more for 2.6.24 -- mostly libertas. Individual patches are available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream-jgarzik/ Thanks! John --- The following changes since commit e54cfa621f4cca9cca500019aa600c71d20f0592: Jeff Garzik (1

Re: [PATCH V4 10/10] net/bonding: Destroy bonding master when last slave is gone

Moni Shoua <[EMAIL PROTECTED]> wrote: >When bonding enslaves non Ethernet devices it takes pointers to functions >in the module that owns the slaves. In this case it becomes unsafe >to keep the bonding master registered after last slave was unenslaved >because we don't know if the pointers are s

Re: [PATCH V4 8/10] net/bonding: Handlle wrong assumptions that slave is always an Ethernet device

Moni Shoua <[EMAIL PROTECTED]> wrote: >bonding sometimes uses Ethernet constants (such as MTU and address length) >which >are not good when it enslaves non Ethernet devices (such as InfiniBand). > >Signed-off-by: Moni Shoua <[EMAIL PROTECTED]> >--- > drivers/net/bonding/bond_main.c |3 ++- >

Please pull 'upstream-davem' branch of wireless-2.6

Dave, A passel of mac80211 patches for 2.6.24... If you have already rebased, you can extract the series as: master-davem..upstream-davem Also, the individual patches are available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream-davem/ And,

Re: [3/4] 2.6.23-rc3: known regressions v3

Hi Stephen, On 24/08/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: > O > > Subject : New wake ups from sky2 > > References : http://lkml.org/lkml/2007/7/20/386 > > Last known good : ? > > Submitter : Thomas Meyer <[EMAIL PROTECTED]> > > Caused-By : Stephen Hemminger <[E

Re: [PATCH 3/3] [IrDA] Kingsun KS-959 IrDA USB driver

From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Mon, 27 Aug 2007 01:15:17 +0300 > This dongle does not follow the usb-irda specification, so it needs its own > special driver. First, it uses control URBs for data transfer, instead of > bulk or interrupt transfers; the only interrupt endpoint exposed

Re: [PATCH 2/3] [IrDA] Kingsun Dazzle IrDA USB driver

From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Mon, 27 Aug 2007 01:15:16 +0300 > This dongle does not follow the usb-irda specification, so it needs its own > special driver. Just like the Kingsun/Donshine dongle, it exposes two > interrupt endpoints. Reception is performed through direct reads from

Re: [PATCH 1/3] [IrDA] MSG_NOSIGNAL support for IrDA sockets

From: Samuel Ortiz <[EMAIL PROTECTED]> Date: Mon, 27 Aug 2007 01:15:15 +0300 > Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]> Applied. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/

Re: pktgen terminating condition

From: Mandeep Singh Baines <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 15:47:18 -0700 > It seems that some drivers do not immediately free skbs on transmit > complete. They will hold the skb until there are more packets to > free. One example is the sis900 driver which uses TX_IDLE (tx > state-mac

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

From: Michael Buesch <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 16:48:44 +0200 > On Monday 27 August 2007 23:11:50 David Miller wrote: > > From: Joe Perches <[EMAIL PROTECTED]> > > Date: Mon, 27 Aug 2007 13:57:42 -0700 > > > > > On Mon, 2007-08-27 at 13:41 -0700, David Miller wrote: > > > > From:

Re: [PATCH net-2.6.24] [NET]: DIV_ROUND_UP cleanup (part two)

From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 12:59:59 +0300 (EEST) > > Hopefully captured all single statement cases under net/. I'm > not too sure if there is some policy about #includes that are > "guaranteed" (ie., in the current tree) to be available through > some other #

Re: Remove softirq scheduling from pktgen [PATCH]

From: Robert Olsson <[EMAIL PROTECTED]> Date: Mon, 27 Aug 2007 20:22:26 +0200 > Christoph Hellwig writes: > > > > Hello, It's not a job for pktgen. > > > > Please also kill the do_softirq export while you're at it. > > > Right seems like pktgen luckily was the only user. > > Signed-off-by

pktgen terminating condition

Hi, I am having some trouble using pktgen with certain NICs. When running pktgen on some NICs, the test stalls because the worker thread is waiting for the driver to free the last skb. If a send a few pings out the interface, the worker thread will eventually unblock. Below is the snippet of code

Re: Remove softirq scheduling from pktgen [PATCH]

From: Robert Olsson <[EMAIL PROTECTED]> Date: Mon, 27 Aug 2007 18:57:19 +0200 > Hello, It's not a job for pktgen. > > Signed-off-by: Robert Olsson <[EMAIL PROTECTED]> Applied, thanks Robert. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PR

Re: pktgen Multiqueue support [PATCH]

From: Robert Olsson <[EMAIL PROTECTED]> Date: Mon, 27 Aug 2007 16:55:19 +0200 > Below some pktgen support to send into different TX queues. > This can of course be feed into input queues on other machines > > Signed-off-by: Robert Olsson <[EMAIL PROTECTED]> Thanks for implementing this Robert, p

Re: pktgen multiqueue oops

From: Robert Olsson <[EMAIL PROTECTED]> Date: Mon, 27 Aug 2007 11:16:19 +0200 > Initially pkt_dev can be NULL this causes netif_subqueue_stopped to > oops. The patch below should cure it. But maybe the pktgen TX logic > should be reworked to better support the new multiqueue support. > > Signe

Re: [PATCH] netlink: use container_of instead

From: Denis Cheng <[EMAIL PROTECTED]> Date: Wed, 29 Aug 2007 03:12:04 +0800 > this could make future redesign of struct netlink_sock easier. > > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> Seems reasonable, patch applied, thanks. - To unsubscribe from this list: send the line "unsubscribe net

Re: make bnx2.c use msleep()

From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 16:27:12 -0700 > [BNX2]: Add write posting comment. > > Add comment to explain why we cannot read back after chip reset > before delaying. > > Signed-off-by: Michael Chan <[EMAIL PROTECTED]> Patch applied, thanks. - To unsubscribe

Re: make bnx2.c use msleep()

On Tue, 2007-08-28 at 19:07 -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Aug 28, 2007 at 10:39:26PM +0100, Christoph Hellwig escreveu: > > On Tue, Aug 28, 2007 at 02:32:50PM -0700, David Miller wrote: > > > From: "Michael Chan" <[EMAIL PROTECTED]> > > > Date: Tue, 28 Aug 2007 15:21:30 -0700 > >

Re: make bnx2.c use msleep()

Em Tue, Aug 28, 2007 at 10:39:26PM +0100, Christoph Hellwig escreveu: > On Tue, Aug 28, 2007 at 02:32:50PM -0700, David Miller wrote: > > From: "Michael Chan" <[EMAIL PROTECTED]> > > Date: Tue, 28 Aug 2007 15:21:30 -0700 > > > > > This is a special case since we are resetting the chip. A read rig

Re: [PATCH] e100 module loads 1/2 times

On Tue, Aug 28, 2007 at 02:43:23PM -0700, Brandeburg, Jesse wrote: > Willy Tarreau wrote: > > --- e100-3.5.17/src/e100.c.orig 2007-08-13 08:53:18 +0200 > > +++ e100-3.5.17/src/e100.c 2007-08-13 09:24:56 +0200 > > @@ -2934,13 +2934,13 @@ > > printk(KERN_INFO PFX "%s\n", DRV_COPYRIGH

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

On 8/28/07, Larry Finger <[EMAIL PROTECTED]> wrote: > Johannes Berg wrote: > > On Tue, 2007-08-28 at 18:10 +0100, Christoph Hellwig wrote: > >> On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: > >>> -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o > >>> +ath5k-objs =

RE: [PATCH] e100 module loads 1/2 times

Willy Tarreau wrote: > --- e100-3.5.17/src/e100.c.orig 2007-08-13 08:53:18 +0200 > +++ e100-3.5.17/src/e100.c2007-08-13 09:24:56 +0200 > @@ -2934,13 +2934,13 @@ > printk(KERN_INFO PFX "%s\n", DRV_COPYRIGHT); > } > #ifdef E100_USE_REBOOT_NOTIFIER > - retval = pci_r

Re: make bnx2.c use msleep()

On Tue, Aug 28, 2007 at 02:32:50PM -0700, David Miller wrote: > From: "Michael Chan" <[EMAIL PROTECTED]> > Date: Tue, 28 Aug 2007 15:21:30 -0700 > > > This is a special case since we are resetting the chip. A read right > > after chip reset will hang the bus especially for A0 and A1 and that's >

Re: make bnx2.c use msleep()

From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 15:11:19 -0700 > On Tue, 2007-08-28 at 14:05 -0700, Arjan van de Ven wrote: > > bnx2.c (incorrectly) sets current->state directly to > > TASK_UNINTERRUPTIBLE, without going through set_task_state(). However > > all the code wants to d

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

From: Joe Perches <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 14:30:33 -0700 > I thought you said Johannes' patch was reverted, > but so far it seems not. > http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.24.git;a=summary > > Against what tree do you want a patch? > No hurry of course. I'

Re: make bnx2.c use msleep()

From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 15:21:30 -0700 > This is a special case since we are resetting the chip. A read right > after chip reset will hang the bus especially for A0 and A1 and that's > why we need the msleep(). TG3 also has the same problem with chip > res

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

On Tue, 2007-08-28 at 14:22 -0700, David Miller wrote: > > Option 2: > > DECLARE_MAC_BUF(mac); > > printk("%s", print_mac(mac, dev->dev_addr)); > Between them, 1 and 2 seem roughly the same, but I'm slightly leaning > towards 2. 2 it is then. I thought you said Johannes' patch was reverte

Re: make bnx2.c use msleep()

On Tue, 2007-08-28 at 22:10 +0100, Christoph Hellwig wrote: > On Tue, Aug 28, 2007 at 02:05:30PM -0700, Arjan van de Ven wrote: > > bnx2.c (incorrectly) sets current->state directly to > > TASK_UNINTERRUPTIBLE, without going through set_task_state(). However > > all the code wants to do is an mslee

Re: [PATCH 2.6.23 RESEND] cxgb3 - Fix dev->priv usage

Roland Dreier wrote: > I take that back. Rejected -- it breaks infiniband build. To be more precise: drivers/infiniband/hw/cxgb3/cxio_hal.c: In function 'cxio_rdev_open': drivers/infiniband/hw/cxgb3/cxio_hal.c:919: error: implicit declaration of function 'T3CDEV' it seems the proble

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

From: Joe Perches <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 14:12:00 -0700 > I've forward ported what I had. > > Option 1: > DECLARE_MAC_BUF(var); > printk(MAC_FMT, MAC_ARG(var, dev->dev_addr)); > > perhaps it looks nicer to remove the MAC_FMT and defines. > > Option 2: > DEC

Re: make bnx2.c use msleep()

From: "Michael Chan" <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 15:11:19 -0700 > On Tue, 2007-08-28 at 14:05 -0700, Arjan van de Ven wrote: > > bnx2.c (incorrectly) sets current->state directly to > > TASK_UNINTERRUPTIBLE, without going through set_task_state(). However > > all the code wants to d

Re: [PATCH 2.6.23 RESEND] cxgb3 - Fix dev->priv usage

> I take that back. Rejected -- it breaks infiniband build. To be more precise: drivers/infiniband/hw/cxgb3/cxio_hal.c: In function 'cxio_rdev_open': drivers/infiniband/hw/cxgb3/cxio_hal.c:919: error: implicit declaration of function 'T3CDEV' it seems the problem is that T3CDEV() has

Re: make bnx2.c use msleep()

On Tue, 2007-08-28 at 14:05 -0700, Arjan van de Ven wrote: > bnx2.c (incorrectly) sets current->state directly to > TASK_UNINTERRUPTIBLE, without going through set_task_state(). However > all the code wants to do is an msleep so just make it do that instead... > > Signed-off-by: Arjan van de Ven <

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

On Mon, 2007-08-27 at 14:37 -0700, David Miller wrote: > From: Joe Perches <[EMAIL PROTECTED]> > > My original patch had the equivalent of > > char* print_mac(char* buf, const char* addr) { > > sprintf(buf,"%02x:...", addr[0]...) > > return buf; > > } > > and used: >

Re: make bnx2.c use msleep()

On Tue, Aug 28, 2007 at 02:05:30PM -0700, Arjan van de Ven wrote: > bnx2.c (incorrectly) sets current->state directly to > TASK_UNINTERRUPTIBLE, without going through set_task_state(). However > all the code wants to do is an msleep so just make it do that instead... > REG_WR(bp, BNX

Re: [1/1] Block device throttling [Re: Distributed storage.]

On Tuesday 28 August 2007 10:54, Evgeniy Polyakov wrote: > On Tue, Aug 28, 2007 at 10:27:59AM -0700, Daniel Phillips ([EMAIL PROTECTED]) > wrote: > > > We do not care about one cpu being able to increase its counter > > > higher than the limit, such inaccuracy (maximum bios in flight > > > thus ca

make bnx2.c use msleep()

bnx2.c (incorrectly) sets current->state directly to TASK_UNINTERRUPTIBLE, without going through set_task_state(). However all the code wants to do is an msleep so just make it do that instead... Signed-off-by: Arjan van de Ven <[EMAIL PROTECTED]> --- linux-2.6.23-rc2/drivers/net/bnx2.c.org 2

Re: [E1000-devel] [PATCH net-2.6.24] e100: fix driver init lockup on e100_up()

From: James Chapman <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 17:06:14 +0100 > David Miller wrote: > > From: James Chapman <[EMAIL PROTECTED]> > > Date: Tue, 28 Aug 2007 09:22:36 +0100 > > > > [NET]: Make NAPI polling independent of struct net_device objects. > > This patch version works fine w

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

From: Roland Dreier <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 12:38:07 -0700 > It seems that the NIC would also have to look into a TCP stream (and > handle out of order segments etc) to find message boundaries for this > to be equivalent to what an RDMA NIC does. It would work for data that acc

Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)

From: OBATA Noboru <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 22:04:47 +0900 (JST) > (1) Make the application timeouts longer. (Steve has shown that > making an application timeouts twice the failover detection > timeout would be a solution.) This is the only feasible solution to your pr

Re: RFC: issues concerning the next NAPI interface

From: Jan-Bernd Themann <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 13:21:09 +0200 > So I guess one solution is to "force" an HW interrupt when two many > RQs are processed on the same CPU (when no IRQ pinning is > used). This is something the driver has to handle. No, the solution is to lock the

Re: RFC: issues concerning the next NAPI interface

From: Jan-Bernd Themann <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 13:21:09 +0200 > Problem for multi queue driver with interrupt distribution scheme set to > round robin for this simple example: > Assuming we have 2 SLOW CPUs. CPU_1 is under heavy load (applications). CPU_2 > is not under heavy l

Re: RFC: issues concerning the next NAPI interface

From: Jan-Bernd Themann <[EMAIL PROTECTED]> Date: Tue, 28 Aug 2007 13:19:03 +0200 > I will try the following scheme (once we get hrtimers): Each device > (queue) has a hrtimer. Schedule the timer in the poll function > instead of reactivating IRQs when a high load situation has been > detected an

[PATCH v3 8/8] fs_enet: sparse fixes

Mostly a bunch of __iomem annotations. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c | 16 +- drivers/net/fs_enet/fs_enet.h | 30 +- drivers/net/fs_enet/mac-fcc.c | 60 --- drivers/net/f

[PATCH v3 2/8] fs_enet: Whitespace cleanup.

Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c | 85 --- drivers/net/fs_enet/fs_enet.h |4 +- drivers/net/fs_enet/mac-fcc.c |1 - drivers/net/fs_enet/mii-fec.c |1 - 4 files changed, 41 insertions(+)

[PATCH v3 7/8] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

The existing OF glue code was crufty and broken. Rather than fix it, it will be removed, and the ethernet driver now talks to the device tree directly. The old, non-CONFIG_PPC_CPM_NEW_BINDING code can go away once CPM platforms are dropped from arch/ppc (which will hopefully be soon), and existin

[PATCH v3 5/8] fs_enet: mac-fcc: Eliminate __fcc-* macros.

These macros accomplish nothing other than defeating type checking. This patch also fixes one instance of the wrong register size being used that was revealed by enabling type checking. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/net/fs_enet/mac-fcc.c | 25 ---

[PATCH v3 4/8] fs_enet: Don't share the interrupt.

This driver can't handle an interrupt immediately after request_irq (making it fail with CONFIG_DEBUG_SHIRQ), and has unshared interrupts on all hardware I'm aware of. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c |2 +- 1 files changed, 1 insertions(+),

[PATCH v3 6/8] fs_enet: Align receive buffers.

At least some hardware driven by this driver needs receive buffers to be aligned on a 16-byte boundary. This usually happens by chance, but it breaks if slab debugging is enabled. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c | 21 +++-- d

[PATCH v3 3/8] fs_enet: Include linux/string.h from linux/fs_enet_pd.h

It is needed for strstr(). Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- include/linux/fs_enet_pd.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/fs_enet_pd.h b/include/linux/fs_enet_pd.h index 543cd3c..815c6f9 100644 --- a/include/linux/fs_enet_pd.h +

Re: [PATCH 4/5] Net: ath5k, license is GPLv2

On 8/28/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Tue, Aug 28, 2007 at 12:00:50PM -0400, Jiri Slaby wrote: > > ath5k, license is GPLv2 > > > > The files are available only under GPLv2 since now. > > Is this really a good idea? Most of the reverse-engineering was > done by the OpenBSD f

[PATCH v3 1/8] Generic bitbanged MDIO library

Previously, bitbanged MDIO was only supported in individual hardware-specific drivers. This code factors out the higher level protocol implementation, reducing the hardware-specific portion to functions setting direction, data, and clock. Signed-off-by: Scott Wood <[EMAIL PROTECTED]> --- drivers

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

Sorry for the long latency, I was at the beach all last week. > > And direct data placement really does give you a factor of two at > > least, because otherwise you're stuck receiving the data in one > > buffer, looking at some of the data at least, and then figuring out > > where to copy it.

[PATCH] netlink: use container_of instead

this could make future redesign of struct netlink_sock easier. Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- net/netlink/af_netlink.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 5681ce3..a78d962 100644 --

Re: [NET]: Mark Paul Moore as maintainer of labelled networking.

On Tuesday, August 28 2007 12:45:50 pm Joe Perches wrote: > On Tue, 2007-08-28 at 08:46 -0400, Paul Moore wrote: > > If having both a labeled networking and NetLabel maintainer entry is a > > problem then how about the patch below? > > I don't think it is. > > > -NETWORKING [LABELED] (NetLabel, CIP

Re: [-mm patch] make types.h usable for non-gcc C parsers

On Tue, Aug 28, 2007 at 07:59:04PM +0200, Adrian Bunk wrote: > On Tue, Aug 28, 2007 at 07:06:04PM +0200, Sam Ravnborg wrote: > > > > > > It fixes a bug exposed by a -mm only patch, not by the net tree > > > (and 2.6.23-rc3-mm1 doesn't contain the net tree at all). > > > > > > > But I'd like a bet

Re: [-mm patch] make types.h usable for non-gcc C parsers

On Tue, Aug 28, 2007 at 07:06:04PM +0200, Sam Ravnborg wrote: > > > > It fixes a bug exposed by a -mm only patch, not by the net tree > > (and 2.6.23-rc3-mm1 doesn't contain the net tree at all). > > > > > But I'd like a better description, please. Which "non-gcc parser" are we > > > talking abo

Re: [1/1] Block device throttling [Re: Distributed storage.]

On Tue, Aug 28, 2007 at 10:27:59AM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > > We do not care about one cpu being able to increase its counter > > higher than the limit, such inaccuracy (maximum bios in flight thus > > can be more than limit, difference is equal to the number of CPUs - >

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

Johannes Berg wrote: On Tue, 2007-08-28 at 18:10 +0100, Christoph Hellwig wrote: On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o +ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o \ +

Re: [-mm patch] make types.h usable for non-gcc C parsers

On 8/28/07, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > But I'd like a better description, please. Which "non-gcc parser" are we > > > talking about here? Something under ./scripts/. Well, please identify > > > it, > > > and describe what the problem is, and how the proposed patch will addres

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

On Tue, 2007-08-28 at 18:10 +0100, Christoph Hellwig wrote: > On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: > > -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o > > +ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o \ > > + ath5k_hw_phy.o ath5

Re: [1/1] Block device throttling [Re: Distributed storage.]

On Tuesday 28 August 2007 02:35, Evgeniy Polyakov wrote: > On Mon, Aug 27, 2007 at 02:57:37PM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: > > Say Evgeniy, something I was curious about but forgot to ask you > > earlier... > > > > On Wednesday 08 August 2007 03:17, Evgeniy Polyakov wrote: > >

Re: Distributed storage.

On Fri, Aug 03, 2007 at 09:04:51AM +0400, Manu Abraham ([EMAIL PROTECTED]) wrote: > On 7/31/07, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > > TODO list currently includes following main items: > > * redundancy algorithm (drop me a request of your own, but it is highly > > unlikley

Re: [PATCH 5/5] Net: ath5k, kconfig changes

On Tue, Aug 28, 2007 at 12:01:30PM -0400, Jiri Slaby wrote: > +config ATH5K_AR5210 > + bool "Support AR5210" > + depends on ATH5K > + default y > + > +config ATH5K_AR5211 > + bool "Support AR5211" > + depends on ATH5K > + default y > + > +config ATH5K_AR5212 > + bool "Su

Re: [PATCH 4/5] Net: ath5k, license is GPLv2

On Tue, Aug 28, 2007 at 12:00:50PM -0400, Jiri Slaby wrote: > ath5k, license is GPLv2 > > The files are available only under GPLv2 since now. Is this really a good idea? Most of the reverse-engineering was done by the OpenBSD folks, and it would certainly be helpful to work together with them on

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: > -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o > +ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o \ > + ath5k_hw_phy.o ath5k_hw_inivals.o And while I'm at nitpicking :) ath5k_hw_phy.o

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote: > obj-$(CONFIG_ATH5K) += ath5k.o > -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o > +ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o \ > + ath5k_hw_phy.o ath5k_hw_inivals.o Btw, this s

Re: [-mm patch] make types.h usable for non-gcc C parsers

> > It fixes a bug exposed by a -mm only patch, not by the net tree > (and 2.6.23-rc3-mm1 doesn't contain the net tree at all). > > > But I'd like a better description, please. Which "non-gcc parser" are we > > talking about here? Something under ./scripts/. Well, please identify it, > > and d

Re: [NET]: Mark Paul Moore as maintainer of labelled networking.

On Tue, 2007-08-28 at 08:46 -0400, Paul Moore wrote: > If having both a labeled networking and NetLabel maintainer entry is a > problem then how about the patch below? I don't think it is. > -NETWORKING [LABELED] (NetLabel, CIPSO, Labeled IPsec, SECMARK) > +NETWORKING [LABELED] (NetLabel/CIPSO, L

  1   2   >