On Thu, 26 Jul 2007 08:44:21 -0700 "Paul E. McKenney" <[EMAIL PROTECTED]> wrote:
> On Thu, Jul 26, 2007 at 11:49:42AM +0100, Stephen Hemminger wrote:
> > Whitespace cleanup run code through lindent then cleanup results.
> > Applys after other two patches.
> >
> > --- a/net/ipv4/fib_trie.c 2007-
On Jul 25, 2007, at 4:21 PM, Jeff Garzik wrote:
I'll let paulus and linuxppc merge this one (or not)...
That would most likely be me, than paulus. Since this is for a
Freescale PPC SoC.
- k
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [E
+
+Command Line Parameters
+===
+
+If the driver is built as a module, the following optional parameters are
+used by entering them on the command line with the modprobe command using
+this syntax:
+
+ modprobe ixgbe [=,,...]
+
+For example, with two PRO/10GbE PCI Expres
Glen Gray <[EMAIL PROTECTED]> :
> Hey Francois,
> I've CC'd the netdev list as requested
Your PR is not lost (nor are the pending ones btw...). I'm simply trying
to find a real explanation for
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242572
--
Ueimor
-
To unsubscribe from this list:
On Wed, 2007-07-25 at 17:17 -0700, David Miller wrote:
> From: Joy Latten <[EMAIL PROTECTED]>
> Date: Wed, 25 Jul 2007 14:21:43 -0500
>
> > This is 2nd revision of patch to modify xfrm_audit_log() such
> > that it can accomodate auditing other ipsec events
> > besides add/delete of an SA or SPD en
On Thu, 2007-07-26 at 00:15 -0700, David Miller wrote:
> The netpoll code has to take that anyways in order to call
> into ->hard_start_xmit() to send out the packet it has
> pending, I'm leveraging that as a synchronization mechanism
> in the drivers because the locking options are limited
> give
Thanks for the feedback Rick. We haven't used the netperf trunk. The
person who actually got these numbers will be trying the netperf trunk
little later and we will post the results..
Just in case someone has top-of-trunk worries, the basic single-stream,
bidirectional stuff is in the 2.4.3 rel
This patch adds support for the Intel(R) 82598 based PCI Express 10GbE
adapters.
Please find the full driver as a patch to latest linus-2.6 tree here:
git-pull git://lost.foo-projects.org/~aveerani/git/linux-2.6 ixgbe
Changes from the last submission...
1. Non-NAPI support is removed.
2. Et
On 7/23/07, Rick Jones <[EMAIL PROTECTED]> wrote:
>
>The bidirectional looks like a two concurrent stream (TCP_STREAM +
>TCP_MAERTS)
>test right?
>
>If you want a single-stream bidirectional test, then with the top of
trunk
>netperf you can use:
>
Thanks for the feedback Rick. We haven't used the
In article <[EMAIL PROTECTED]> (at Wed, 25 Jul 2007 17:12:03 -0700 (PDT)),
David Miller <[EMAIL PROTECTED]> says:
> Contrarily, there may be ipv6_addr_type() call sites that really
> do want to reject rfc4193 addresses.
I do not think we have such users.
--yoshfuji
-
To unsubscribe from this li
Hello.
In article <[EMAIL PROTECTED]> (at Wed, 25 Jul 2007 19:49:09 -0400), Dave
Johnson <[EMAIL PROTECTED]> says:
> ipv6_addr_type() doesn't check for 'Unique Local IPv6 Unicast
> Addresses' (RFC4193) and returns IPV6_ADDR_RESERVED for that range.
Acked-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]
Hello,
I tested 2.6.23-rc1 on my prep (arch=ppc) NAT firewall. iptables loaded
rules fine (simplest test was with single SNAT rule in POSTROUTING chain
in nat table) and iptables -L showed the rule was loaded. But no packets
matched the rule and traffic passed un-NATed (just routed). Adding LOG
Dave Johnson wrote:
> Simon Arlott writes:
>> But ULA's scope isn't global, shouldn't it be IPV6_ADDR_SCOPE_ORGLOCAL ?
>
> Isn't ORGLOCAL defined for multicast only?
Yes, it's only for multicast. Unicast addresses only have
2 scopes any more: Global and Link-Local.
-vlad
>
> rfc4193 section 3
On Thu, 26 Jul 2007, Adrian Bunk wrote:
> >
> > So maybe I'm old-fashioned and crazy, but "readability of the asm result"
> > actually is a worthwhile goal. Not because we care directly, but because
> > I'd like to encourage people to do it, due to the *indirect* benefits.
>
> This would lead
On Tue, Jul 24, 2007 at 12:48:13PM -0700, Linus Torvalds wrote:
>
>
> On Tue, 24 Jul 2007, Adrian Bunk wrote:
> >
> > > But do we
> > > care so much that it's worth inlining something like buffered_rmqueue()?
> > >...
> >
> > Where is the problem with having buffered_rmqueue() inlined?
>
> I
On Thursday 26 July 2007 20:21:59 Simon Arlott wrote:
> On 26/07/07 00:49, Dave Johnson wrote:
> > ipv6_addr_type() doesn't check for 'Unique Local IPv6 Unicast
> > Addresses' (RFC4193) and returns IPV6_ADDR_RESERVED for that range.
> >
> > + if ((st & htonl(0xFE00)) == htonl(0xFC00))
> >
Simon Arlott writes:
> But ULA's scope isn't global, shouldn't it be IPV6_ADDR_SCOPE_ORGLOCAL ?
Isn't ORGLOCAL defined for multicast only?
rfc4193 section 3.3 says:
> 3.3. Scope Definition
>By default, the scope of these addresses is global. That is, they
>are not limited by ambiguity l
Dave Johnson wrote:
> David Miller writes:
>> Contrarily, there may be ipv6_addr_type() call sites that really
>> do want to reject rfc4193 addresses.
>
> A quick look through the callers and only these functions should be
> effected, they check either RESERVED or UNICAST from ipv6_addr_type():
>
On Mon, Jul 23, 2007 at 04:36:22PM -0400, Lennart Sorensen wrote:
> I have been seeing some occasional strange behavior when using
> proxy_arp. I have a router running with an ADSL PPPoE link to the
> Internet, and an Ethernet link to a local network. It has proxy_arp
> enabled on the internal Et
The yearly ethtool update is available (it doesn't see a lot of action)
at its home page,
http://sf.net/projects/gkernel/
or directly via git SCM:
git://git.kernel.org/pub/scm/network/ethtool/ethtool.git
The release notes and full changelog (from git) are attached.
Je
Steve Glendinning wrote:
This patch adds support for SMSC's LAN911x and LAN921x families of
embedded ethernet controllers to ethtool's dump registers (-d) command.
This patch is for use with the smsc911x driver.
Signed-off-by: Steve Glendinning <[EMAIL PROTECTED]>
---
Makefile.am|3 +-
On 26/07/07 00:49, Dave Johnson wrote:
> ipv6_addr_type() doesn't check for 'Unique Local IPv6 Unicast
> Addresses' (RFC4193) and returns IPV6_ADDR_RESERVED for that range.
> + if ((st & htonl(0xFE00)) == htonl(0xFC00))
> + return (IPV6_ADDR_UNICAST |
> +
> This is the final fix for the problem Peter reported.
> Turns out most other schedulers get it right, the only other
> case is ingress setting skb->tc_index to the uninitialized
> value of res.classid.
I've applied this and tested prio and rr, and everything is happy again.
Thanks for finding
On Thu, Jul 26, 2007 at 11:49:42AM +0100, Stephen Hemminger wrote:
> Whitespace cleanup run code through lindent then cleanup results.
> Applys after other two patches.
>
> --- a/net/ipv4/fib_trie.c 2007-07-26 10:17:21.0 +0100
> +++ b/net/ipv4/fib_trie.c 2007-07-26 11:47:52.000
On Thu, 26 Jul 2007 14:44:01 +0200
Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> Hi,
>
> Very below is my patch proposal with a comment, which in my opinion
> is precious enough to save it for future help in reading and
> understanding the code.
>
> I hope Alan will not blame me I've not asked fo
Hi,
Very below is my patch proposal with a comment, which in my opinion
is precious enough to save it for future help in reading and
understanding the code.
I hope Alan will not blame me I've not asked for his permission before
sending, and he would ack this patch as it is or at least most of thi
This is the final fix for the problem Peter reported.
Turns out most other schedulers get it right, the only
other case is ingress setting skb->tc_index to the
uninitialized value of res.classid.
[NET_SCHED]: Fix prio/ingress classification logic error
Fix handling of empty or completely non-ma
David Miller writes:
> From: Stephen Hemminger <[EMAIL PROTECTED]>
> Date: Thu, 26 Jul 2007 09:46:48 +0100
>
> > Try this out:
> > * replace macro's with inlines
> > * get rid of places doing multiple evaluations of NODE_PARENT
>
> No objections from me.
>
> Robert?
Fine i
On Thu, Jul 26, 2007 at 11:37:15AM +0100, Stephen Hemminger wrote:
>
> Thanks for looking at this, are there bugs this fixes so it should
> go to stable?
Well it does fix bugs but I'm a bit anxious about pushing it
to stable straight away because the likelihood of it breaking
something else is jus
On Thu, 26 Jul 2007 11:43:34 +0100 Stephen Hemminger <[EMAIL PROTECTED]> wrote:
> This patch converts the messy macro for MASK_PFX to inline function
> and expands TKEY_GET_MASK in the one place it is used.
>
>
> --- a/net/ipv4/fib_trie.c 2007-07-26 09:26:19.0 +0100
> +++ b/net/ipv4/
Whitespace cleanup run code through lindent then cleanup results.
Applys after other two patches.
--- a/net/ipv4/fib_trie.c 2007-07-26 10:17:21.0 +0100
+++ b/net/ipv4/fib_trie.c 2007-07-26 11:47:52.0 +0100
@@ -156,7 +156,8 @@ struct trie {
};
static void put_child(s
This patch converts the messy macro for MASK_PFX to inline function
and expands TKEY_GET_MASK in the one place it is used.
--- a/net/ipv4/fib_trie.c 2007-07-26 09:26:19.0 +0100
+++ b/net/ipv4/fib_trie.c 2007-07-26 10:17:21.0 +0100
@@ -85,8 +85,6 @@
#define MAX_STAT_DE
On Thu, 26 Jul 2007 17:07:25 +0800
Herbert Xu <[EMAIL PROTECTED]> wrote:
> Hi Dave:
>
> This series of patches adds support to let netdev registration
> and change name events to fail. Failures of the former kind
> prevents the device from registered while the latter attempts
> to roll back the
The function is called like this- dev->hard_header(skb, dev, ptype,
dest_hw, src_hw, skb->len); where "skb->protocol" is same as "ptype",
but the former is expected to be in network byte order before calling
hard_header, while latter in host byte order (eth_header internally
does its own conversio
Hi Kyle.
On Wed, Jul 25, 2007 at 11:43:38PM -0400, Kyle Moffett ([EMAIL PROTECTED])
wrote:
> If you made all your sockets and inter-thread pipes nonblocking then
> in userspace you would just epoll_wait() on the sockets and pipes and
> be easily able to react to any IO from anywhere.
>
> In
On Thu, 26 Jul 2007 02:04:31 -0700
Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Thu, 26 Jul 2007 09:46:48 +0100 Stephen Hemminger <[EMAIL PROTECTED]>
> wrote:
>
> > Try this out:
> > * replace macro's with inlines
> > * get rid of places doing multiple evaluations of NODE_PARENT
>
>
* Jarek Poplawski <[EMAIL PROTECTED]> wrote:
> On Thu, Jul 26, 2007 at 10:31:20AM +0200, Ingo Molnar wrote:
> ...
> > yeah. The patch below enables sw-resend on x86, to test the theory
> > whether the APIC-driven hardware-vector-resend code has some problem.
>
> I think Marcin is using x86_64 (
[IPV6]: Remove circular dependency on if_inet6.h
net/if_inet6.h includes linux/ipv6.h which also tries to include
net/if_inet6.h. Since the latter only needs it for forward
declarations, we can fix this by adding the declarations.
A number of files are implicitly including net/if_inet6.h through
[IPV4/IPV6]: Fail registration if inet device construction fails
Now that netdev notifications can fail, we can use this to signal
errors during registration for IPv4/IPv6. In particular, if we
fail to allocate memory for the inet device, we can fail the netdev
registration.
Signed-off-by: Herbe
[NET]: Allow netdev REGISTER/CHANGENAME events to fail
This patch adds code to allow errors to be passed up from event
handlers of NETDEV_REGISTER and NETDEV_CHANGENAME. It also adds
the notifier_from_errno/notifier_to_errnor helpers to pass the
errno value up to the notifier caller.
If an error
[NET] loopback: Panic if registration fails
Because IPv4 and IPv6 both depend on the presence of the loopback device
to function, failure in registration the loopback device should be fatal.
Signed-off-by: Herbert Xu <[EMAIL PROTECTED]>
---
drivers/net/loopback.c |7 ++-
1 files changed
[NET]: Take dev_base_lock when moving device name hash list entry
When we added name-based hashing the dev_base_lock was designated as the
lock to take when changing the name hash list. Unfortunately, because
it was a preexisting lock that just happened to be taken in the right
spots we neglected
[NET]: Call uninit if necessary in register_netdevice
This patch makes register_netdevice call dev->uninit if the regsitration
fails after dev->init has completed successfully. Very few drivers use
the init/uninit calls but at least one (drivers/net/wan/sealevel.c) may
leak without this change.
Hi Dave:
This series of patches adds support to let netdev registration
and change name events to fail. Failures of the former kind
prevents the device from registered while the latter attempts
to roll back the change (which unfortunately can also fail).
If the failure occurs while a netdev is b
On Thu, 26 Jul 2007 09:46:48 +0100 Stephen Hemminger <[EMAIL PROTECTED]> wrote:
> Try this out:
> * replace macro's with inlines
> * get rid of places doing multiple evaluations of NODE_PARENT
And it fixes the rcu abuse which resulted in
http://lkml.org/lkml/2007/7/25/319. Which I assu
On Thu, Jul 26, 2007 at 10:10:31AM +0200, Thomas Gleixner wrote:
> On Thu, 2007-07-26 at 10:13 +0200, Jarek Poplawski wrote:
...
> > PS: Now, it seems to me Thomas could be the nearest. BTW, could somebody
> > give me some tip, how these re-triggered interrupts are skipped on dev's
> > reset before
Hi Dave:
Found this while looking at 8797. Although it's not clear
that this is the cause yet (it could only happen if a
seemingly remote TCP stream is DNATed to a local address),
we need this patch anyway to avoid clobbering incoming
traffic with CHECKSUM_PARTIAL in its ip_summed field.
[IPVS]:
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Thu, 26 Jul 2007 09:46:48 +0100
> Try this out:
> * replace macro's with inlines
> * get rid of places doing multiple evaluations of NODE_PARENT
No objections from me.
Robert?
-
To unsubscribe from this list: send the line "unsubscribe
Try this out:
* replace macro's with inlines
* get rid of places doing multiple evaluations of NODE_PARENT
--- a/net/ipv4/fib_trie.c 2007-07-26 09:22:47.0 +0100
+++ b/net/ipv4/fib_trie.c 2007-07-26 09:26:19.0 +0100
@@ -93,15 +93,8 @@ typedef unsigned int t_ke
On Thu, Jul 26, 2007 at 10:31:20AM +0200, Ingo Molnar wrote:
...
> yeah. The patch below enables sw-resend on x86, to test the theory
> whether the APIC-driven hardware-vector-resend code has some problem.
I think Marcin is using x86_64 (Athlon 64) yet.
Jarek P.
-
To unsubscribe from this list:
* Thomas Gleixner <[EMAIL PROTECTED]> wrote:
> The other question is:
>
> Is the driver confused by the resent irq or is the chip-set unhappy
> about the resend ?
>
> We could figure the latter out by activating the software based resend
> method.
yeah. The patch below enables sw-resend on x
* Marcin Ślusarz <[EMAIL PROTECTED]> wrote:
> 2007/7/25, Thomas Gleixner <[EMAIL PROTECTED]>:
> >(...)
>
> I've tested Jarek's patch, 2 Ingo's patches (2nd and 3rd) and Thomas'
> patch (one patch at time of course) - all of them fixed the problem,
> but the last one flooded my logs with "Skip
On Thu, 2007-07-26 at 10:13 +0200, Jarek Poplawski wrote:
> > I wanted to test them all on 2.6.22.1, but I didn't have enough time.
> > I've verified only that 2.6.22.1 has the same problem. I can test it
> > later, but I can report results back at beginning of next week.
>
>
> So, everything is
On Thu, Jul 26, 2007 at 10:13:26AM +0200, Jarek Poplawski wrote:
...
> So, everything is clear - any changes are good!
> Except the signed-off ones...
Oops! Marcin's patch was both signed-off and good.
So, there is probably something more...
Sorry Marcin,
Jarek P.
-
To unsubscribe from this list
On Thu, Jul 26, 2007 at 09:16:10AM +0200, Marcin Ślusarz wrote:
> 2007/7/25, Thomas Gleixner <[EMAIL PROTECTED]>:
> >(...)
>
> I've tested Jarek's patch, 2 Ingo's patches (2nd and 3rd) and Thomas'
> patch (one patch at time of course) - all of them fixed the problem,
> but the last one flooded my
Hey Francois,
I've CC'd the netdev list as requested
Francois Romieu wrote:
I'm in a particularly sticky situation in relation to the latest
kernels and multicast. And I need some help to get out of it. I'm
hoping with your combined experiences we might be able to solve my
problems.
Multi
2007/7/25, Thomas Gleixner <[EMAIL PROTECTED]>:
(...)
I've tested Jarek's patch, 2 Ingo's patches (2nd and 3rd) and Thomas'
patch (one patch at time of course) - all of them fixed the problem,
but the last one flooded my logs with "Skip resend for irq 17". All
tests were done on 2.6.21.3.
I wa
From: "Michael Chan" <[EMAIL PROTECTED]>
Date: Thu, 26 Jul 2007 00:05:47 -0700
> David Miller wrote:
>
> > So that ->poll_controller() can process TX acks by just having
> > the TX lock and interrupts disabled.
> >
> > Can you think of another way to process TX acks from absolutely
> > any execu
From: Marcel Holtmann <[EMAIL PROTECTED]>
Date: Mon, 23 Jul 2007 09:47:12 +0200
> Hi Adrian,
>
> > Commit 8de0a15483b357d0f0b821330ec84d1660cadc4e added the following
> > use-after-free in net/bluetooth/rfcomm/tty.c:
...
> > Spotted by the Coverity checker.
>
> really good catch. I fully overl
From: Simon Arlott <[EMAIL PROTECTED]>
Date: Mon, 23 Jul 2007 20:25:45 +0100
> The ADVMSS value was incorrectly updated for ALL routes when the MTU
> is updated because it's outside the effect of the if statement's
> condition.
>
> Signed-off-by: Simon Arlott <[EMAIL PROTECTED]>
Thanks for fix
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Tue, 24 Jul 2007 16:31:44 +0200
> Joakim Koskela wrote:
> > This patch modifies the xfrm state selection logic to use the inner
> > addresses where the outer have been (incorrectly) used. This is
> > required for beet mode in general and interfamily
From: Shannon Nelson <[EMAIL PROTECTED]>
Date: Tue, 24 Jul 2007 17:36:06 -0700
> (repost - original eaten by vger?)
>
> Al Viro pointed out that dma_memcpy_to_kernel_iovec() really was
> unreachable and thus unused. The code originally was there to support
> in-kernel dma needs, but since it rem
David Miller wrote:
> So that ->poll_controller() can process TX acks by just having
> the TX lock and interrupts disabled.
>
> Can you think of another way to process TX acks from absolutely
> any execution context whatsoever? That's what we need and
> preferably in some generic way, and the ab
From: Florian Westphal <[EMAIL PROTECTED]>
Date: Wed, 25 Jul 2007 00:02:56 +0200
> if printbuf allocation or tipc_node_attach_link() fails, invalid
> references to the link are left in the associated node and bearer
> structures.
> Fix by allocating printbuf early and moving timer initialization
>
From: Randy Dunlap <[EMAIL PROTECTED]>
Date: Mon, 23 Jul 2007 21:42:19 -0700
> From: Randy Dunlap <[EMAIL PROTECTED]>
>
> Fix kernel-doc omissions in net/:
>
> Warning(linux-2.6.23-rc1//net/core/dev.c:2728): No description found for
> parameter 'addr'
> Warning(linux-2.6.23-rc1//net/core/dev.c:
65 matches
Mail list logo
