On Tue, 24 Jul 2007, Sridhar Samudrala wrote:
> On Tue, 2007-07-24 at 10:13 -0700, Rick Jones wrote:
> > > Rick,
> > >
> > > I don't see any way around this. For example, on one of my test
> > > systems, I have the following link local routes:
> > >
> > > chance% netstat -A inet6 -rn | grep fe8
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Wed, 25 Jul 2007 15:09:55 +1000
> Not pretty 8(
Not at all and cmpxchg() isn't really a generically usable
primitive. Yes all platforms provide atomic_cmpxchg() in
one form or another, but it's really barbaric and inefficient
on some cpu types.
Let'
On Tue, 2007-07-24 at 21:29 -0700, David Miller wrote:
> From: Rusty Russell <[EMAIL PROTECTED]>
> Date: Wed, 25 Jul 2007 12:33:14 +1000
>
> > Maybe by adding YA state bit? Hold on, this might get ugly...
> >
> > Say netif_rx_schedule_prep() sets the MORE_TODO bit (atomically instead
> > of sett
From: David Miller <[EMAIL PROTECTED]>
Date: Tue, 24 Jul 2007 18:47:59 -0700 (PDT)
> EHEA is another case, in fact EHEA doesn't disable interrupts at
> all.
>
> The reason is that EHEA has several NAPI sources behind one single
> hardware interrupt.
>
> That driver's issues were discussed long ag
On Tue, 2007-07-24 at 11:25 -0700, Linus Torvalds wrote:
>
> On Tue, 24 Jul 2007, Andrew Morton wrote:
> >
> > I guess this was the bug:
>
> Looks very likely to me. Mike, Alexey, does this fix things for you?
I don't have very much runtime on it yet, but yes, it seems to have.
-Mike
Hi Patrick,
Krishna Kumar2/India/IBM wrote on 07/23/2007 08:27:53 AM:
> Hi Patrick,
>
> Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/22/2007 10:36:51 PM:
>
> > Krishna Kumar wrote:
> > > @@ -472,6 +474,9 @@ struct net_device
> > > void *priv; /* pointer to private data */
> > >
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Wed, 25 Jul 2007 12:33:14 +1000
> Maybe by adding YA state bit? Hold on, this might get ugly...
>
> Say netif_rx_schedule_prep() sets the MORE_TODO bit (atomically instead
> of setting __LINK_STATE_RX_SCHED) if it's going to fail, and
> netif_rx_comp
Jeff,
You committed old patch, which I had asked to ignore for two newer patches.
[PATCH 1/1] netxen: Load firmware during probe, dma watchdog fix.
is wrong patch that went in, instead please commit:
[PATCH 1/2] netxen: IMEZ multiport card 2nd port issue, dma watchdog fix
[PATCH 2/2] netxen: F
Jamal,
This is silly. I am not responding to this type of presumptuous and
insulting mails.
Regards,
- KK
J Hadi Salim <[EMAIL PROTECTED]> wrote on 07/25/2007 12:58:20 AM:
> KK,
>
> On Tue, 2007-24-07 at 09:14 +0530, Krishna Kumar2 wrote:
>
> >
> > J Hadi Salim <[EMAIL PROTECTED]> wrote on 07/
On Tue, 2007-07-24 at 18:47 -0700, David Miller wrote:
> One thing that's peculiar is that when netif_rx_schedule_prep()
> fails, we don't disable interrupts but we also don't clear the
> condition that is causing the interrupt to occur.
I think we're ok, but this stuff is tricky.
In the driver i
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Wed, 25 Jul 2007 11:15:49 +1000
> If I understand correctly, you're looking at a general model like the
> following:
>
> while (more_packets()) { ... netif_receive_skb() }
>
> enable_rx_and_rxnobuf_ints();
>
> /* Lock protects agai
On Wed, Jul 25, 2007 at 12:30:07AM +0100, Al Viro wrote:
> On Tue, Jul 24, 2007 at 04:26:21PM -0700, Brandon Philips wrote:
> > Could you point me to an example you have in mind?
> >
> > I quickly searched through a handful of the PCI device drivers and
> > couldn't find an example where the .remo
On Tue, 2007-07-24 at 17:45 -0700, David Miller wrote:
> I'm now going to go over the other resched cases and make sure
> things can be similarly handled in those drivers as well.
> To be honest I'm quite confident this will be the case.
If I understand correctly, you're looking at a general model
Al Boldi wrote:
> Patrick McHardy wrote:
>
>>Al Boldi wrote:
>>
>>>Also, we could leave this as is, and select NF_CONNTRACK_ENABLED instead
>>>of NF_CONNTRACK.
>>
>>I guess so, and that would have to select NF_CONNTRACK.
>
>
> Should I resend, or can you take care of it?
Please resend after te
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Tue, 24 Jul 2007 16:21:43 +1000
> On Mon, 2007-07-23 at 22:47 -0700, David Miller wrote:
> > Any objections?
>
> On the contrary, this looks good.
It turns out the explicit restart logic isn't necessary. On the first
driver I tried to "convert" this
From: Shannon Nelson <[EMAIL PROTECTED]>
Date: Tue, 24 Jul 2007 17:36:06 -0700
> (repost - original eaten by vger?)
This one seems to have made it.
> Al Viro pointed out that dma_memcpy_to_kernel_iovec() really was
> unreachable and thus unused. The code originally was there to support
> in-ker
PJ Waskiewicz wrote:
> This is a patch from Patrick McHardy to fix the sch_api code, which I
> went ahead and tested and made a slight fix to. This also includes
> the fix to sch_prio based on Patrick's patch.
>
> The sch->parent handle should contain the parent qdisc ID. When the
> qdisc is the
(repost - original eaten by vger?)
Al Viro pointed out that dma_memcpy_to_kernel_iovec() really was
unreachable and thus unused. The code originally was there to support
in-kernel dma needs, but since it remains unused, we'll pull it out.
Signed-off-by: Shannon Nelson <[EMAIL PROTECTED]>
---
d
Waskiewicz Jr, Peter P wrote:
> [...]
> Now I add a filter for ethernet (802.3), and things aren't as happy:
>
> # tc filter add dev eth0 protocol 802_3 parent 1: prio 2 u32 match u32
> 0x at 0 match u32 bytes of dst mac address> 0x at 4 flowid 1:1
>
> This should match the dest
I've been trying to use tc filtering to filter on ethertype, among other
things in the MAC layer. I'm running into multiple issues, and want to
put this out there in case I'm using the filters wrong, or if there
really is a bug in the filter code (I've stared at most of it today, and
my head hurts
On Tue, 2007-07-24 at 22:04 +0200, Ingo Molnar wrote:
> Marcin, could you try the patch below too? [without having any other
> patch applied.] It basically turns the critical section into an irqs-off
> critical section and thus checks whether your problem is related to that
> particular area of
> * netdev_pci_remove_one() can replace simple pci device remove
> functions
>
> * devm_alloc_netdev() is like alloc_netdev but allocates
> memory using devres.
> alloc_netdev() can be removed once all drivers use devres.
Please look at the multiqueue network code that is in 2.6.23. It
crea
Hi Florian,
On 24/07/07, Florian Lohoff <[EMAIL PROTECTED]> wrote:
On Tue, Jul 24, 2007 at 09:50:08AM +0100, Stephen Hemminger wrote:
> The problem is related to power management. The PHY has a number of PCI
configuration
> registers for power control, and the function of these changes based on
On Tue, Jul 24, 2007 at 04:26:21PM -0700, Brandon Philips wrote:
> Could you point me to an example you have in mind?
>
> I quickly searched through a handful of the PCI device drivers and
> couldn't find an example where the .remove function didn't do something
> to the tune of:
>
> unregi
On 00:09 Wed 25 Jul 2007, Al Viro wrote:
> On Tue, Jul 24, 2007 at 11:51:34PM +0100, Al Viro wrote:
> > On Tue, Jul 24, 2007 at 03:39:52PM -0700, [EMAIL PROTECTED] wrote:
> > > * netdev_pci_remove_one() can replace simple pci device remove
> > > functions
> > >
> > > * devm_alloc_netdev() is lik
On Tue, Jul 24, 2007 at 11:51:34PM +0100, Al Viro wrote:
> On Tue, Jul 24, 2007 at 03:39:52PM -0700, [EMAIL PROTECTED] wrote:
> > * netdev_pci_remove_one() can replace simple pci device remove
> > functions
> >
> > * devm_alloc_netdev() is like alloc_netdev but allocates memory using
> > devres
On Tue, Jul 24, 2007 at 03:39:52PM -0700, [EMAIL PROTECTED] wrote:
> * netdev_pci_remove_one() can replace simple pci device remove
> functions
>
> * devm_alloc_netdev() is like alloc_netdev but allocates memory using devres.
> alloc_netdev() can be removed once all drivers use devres.
E
devres manages device resources and is currently used by all libata low level
drivers. It can greatly reduce the complexity of the error handling on probe
and the device removal functions.
For example the e100_free() function and all of the gotos in e100_probe have
been removed. Also, e100_remo
* netdev_pci_remove_one() can replace simple pci device remove
functions
* devm_alloc_netdev() is like alloc_netdev but allocates memory using devres.
alloc_netdev() can be removed once all drivers use devres.
Applies against 2.6.22
Signed-off-by: Brandon Philips <[EMAIL PROTECTED]>
---
in
These patches update the network driver core and the e100 driver to use devres.
Devres is a simple resource manager for device drivers, see
Documentation/driver-model/devres.txt for more information.
If the RFC goes well I will create patches to update all applicable network
drivers.
Applies agai
From: Thomas Graf <[EMAIL PROTECTED]>
Date: Tue, 24 Jul 2007 11:44:27 +0200
> Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Also applied, thanks Thomas.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http:
This is a patch from Patrick McHardy to fix the sch_api code, which I
went ahead and tested and made a slight fix to. This also includes
the fix to sch_prio based on Patrick's patch.
The sch->parent handle should contain the parent qdisc ID. When the
qdisc is the root qdisc (TC_H_ROOT), the pare
Fix the check in prio_tune() to see if sch->parent is TC_H_ROOT instead of
sch->handle to load or reject the qdisc for multiqueue devices.
Signed-off-by: Peter P Waskiewicz Jr <[EMAIL PROTECTED]>
---
net/sched/sch_prio.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git
From: Thomas Graf <[EMAIL PROTECTED]>
Date: Tue, 24 Jul 2007 11:45:14 +0200
> The current calculation of the maximum number of genetlink
> multicast groups seems odd, fix it.
>
> Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Applied, thanks.
-
To unsubscribe from this list: send the line "unsub
From: Patrick McHardy <[EMAIL PROTECTED]>
Fix sch_api to correctly set sch->parent for both ingress and egress
qdiscs in qdisc_create().
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
Signed-off-by: Peter P Waskiewicz Jr <[EMAIL PROTECTED]>
---
net/sched/sch_api.c | 17 -
From: Thomas Graf <[EMAIL PROTECTED]>
Date: Tue, 24 Jul 2007 23:52:57 +0200
> family->mcast_groups is protected by genl_lock so it must
> be held while accessing the list in genl_unregister_mc_groups().
> Requires adding a non-locking variant of genl_unregister_mc_group().
>
> Signed-off-by: Thom
if printbuf allocation or tipc_node_attach_link() fails, invalid
references to the link are left in the associated node and bearer
structures.
Fix by allocating printbuf early and moving timer initialization
and the addition of the new link to the b_ptr->links list after
tipc_node_attach_link() suc
family->mcast_groups is protected by genl_lock so it must
be held while accessing the list in genl_unregister_mc_groups().
Requires adding a non-locking variant of genl_unregister_mc_group().
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]>
Index: net-2.6/net/netlink/genetlink.c
===
* Brian Haley <[EMAIL PROTECTED]> 2007-07-24 12:14
> Thomas Graf wrote:
> >@@ -217,14 +229,8 @@ EXPORT_SYMBOL(genl_register_mc_group);
> > void genl_unregister_mc_group(struct genl_family *family,
> > struct genl_multicast_group *grp)
> > {
> >-BUG_ON(grp->family != fa
Al Viro pointed out that dma_memcpy_to_kernel_iovec() really was
unreachable and thus unused. The code originally was there to support
in-kernel dma needs, but since it remains unused, we'll pull it out.
Signed-off-by: Shannon Nelson <[EMAIL PROTECTED]>
---
drivers/dma/iovlock.c | 27
Ayaz Abdulla wrote:
This patch contains new device ids for MCP73 chipset.
Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]>
applied 1-2
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.o
Geert Uytterhoeven wrote:
netdev: i82596 Ethernet needs on m68k
drivers/net/82596.c: In function 'init_rx_bufs':
drivers/net/82596.c:552: error: implicit declaration of function 'cache_clear'
drivers/net/82596.c: In function 'i596_start_xmit':
drivers/net/82596.c:1104: error: implicit declarati
Maciej W. Rozycki wrote:
This is a change to remove a local hack in favour to __maybe_unused that
has been recently added.
Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]>
---
Hi,
It should be obvious. The code builds, therefore it works.
Please apply,
Maciej
applied
-
To unsu
Adrian Bunk wrote:
The Coverity checker noted that we've already dereferenced "dev" when we
check whether it's NULL.
Since it's impossible that "dev" is NULL at this place this patch
removes the NULL check.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this
Jan-Bernd Themann wrote:
net_poll support for eHEA added
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c | 22 +-
2 files changed, 22 insertions(+), 2 deletions(-)
applied
-
To unsubscribe
Li Yang wrote:
The patch enables statistics in ucc_geth and adds ethtool support to
ucc_geth driver.
Signed-off-by: Li Yang <[EMAIL PROTECTED]>
---
drivers/net/Makefile |2 +-
drivers/net/ucc_geth.c | 19 +-
drivers/net/ucc_geth.h |6 +
drivers/net/ucc_geth_e
[EMAIL PROTECTED] wrote:
The firmware should be loaded after resetting hardware during PCI probe,
besides module unload. This fixes issue with 2nd port of multiport adapter
on powerpc blades. This patch also fixes a bug that PCI resources are not
freed if dma watchdog shutdown failed. The dma wat
Masakazu Mokuno wrote:
Fixed the bug that calculation of the address of rx descriptor was
wrong.
Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]>
---
drivers/net/ps3_gelic_net.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
applied 1-10
-
To unsubscribe from this list: send the
Jay Cliburn wrote:
Change tpd_avail() to atl1_tpd_avail().
Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]>
---
drivers/net/atl1/atl1_main.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
applied 1-5
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the bod
Micah Gruber wrote:
This patch fixes a potential null dereference bug where we dereference
DEV before a null check. This patch simply moves the dereferencing after
the null check.
Signed-off-by: Micah Gruber <[EMAIL PROTECTED]>
---
--- a/drivers/net/pcmcia/nmclan_cs.c+++
b/drivers/net/p
On Tue, Jul 24, 2007 at 11:25:22AM -0700, Linus Torvalds wrote:
> On Tue, 24 Jul 2007, Andrew Morton wrote:
> > I guess this was the bug:
>
> Looks very likely to me. Mike, Alexey, does this fix things for you?
Yeah, box is running for more than hour, survived LTP, gdb testsuite,
portage sync and
* Linus Torvalds <[EMAIL PROTECTED]> wrote:
> On Tue, 24 Jul 2007, Ingo Molnar wrote:
> >
> > please try the patch below instead.
>
> I'm hoping this is just a "let's see if the behavior changes" patch,
> not something that you think should be applied if it fixes something?
>
> This patch loo
Patrick McHardy wrote:
> Al Boldi wrote:
> > Also, we could leave this as is, and select NF_CONNTRACK_ENABLED instead
> > of NF_CONNTRACK.
>
> I guess so, and that would have to select NF_CONNTRACK.
Should I resend, or can you take care of it?
Thanks!
--
Al
-
To unsubscribe from this list: sen
Roland:
The guys at UNH found this and fixed it. I'm surprised no
one has hit this before. I guess it only breaks when the
refcount on the QP is non-zero.
Initialize the wait_queue_head_t in the c2_qp structure.
Signed-off-by: Ethan Burns <[EMAIL PROTECTED]>
Acked-by: Tom Tucker <[EMAIL PROTECT
Oliver Hartkopp <[EMAIL PROTECTED]> wrote on 07/23/2007 11:22:39 PM:
> When you like to create any timeout based on your calculated value, you
> might run into the problem that your calculated value is set to _zero_
> even if there was "some time" before the conversion. This might probably
> not w
On Tue, 24 Jul 2007, Adrian Bunk wrote:
>
> > But do we
> > care so much that it's worth inlining something like buffered_rmqueue()?
> >...
>
> Where is the problem with having buffered_rmqueue() inlined?
In this case, it was a pain to just even try to find the call chain, or
read the asm.
On Tue, 24 Jul 2007, Andi Kleen wrote:
>
> There's probably a --param where it can be tweaked exactly. The
> problem is that --params tend to be very gcc version specific
> and might do something completely different on a newer or
> older version. So it's better not to use them.
I agree wholeh
On Tue, Jul 24, 2007 at 12:15:48PM -0700, Linus Torvalds wrote:
>
>
> On Tue, 24 Jul 2007, Andrew Morton wrote:
> >
> > fwiw, -fno-inline-functions-called-once (who knew?) takes i386 allnoconfig
> > vmlinux .text from 928360 up to 955362 bytes (27k larger).
> >
> > A surprisingly large increase
Linus Torvalds <[EMAIL PROTECTED]> writes:
>
> So "called once" should probably make the inlining weight bigger (ie
> inline *larger* functions than you would otherwise), it just shouldn't
> make it "infinite". It's not worth it.
There's probably a --param where it can be tweaked exactly. The
p
On Tue, 24 Jul 2007, Ingo Molnar wrote:
>
> please try the patch below instead.
I'm hoping this is just a "let's see if the behavior changes" patch, not
something that you think should be applied if it fixes something?
This patch looks like it is trying to paper over (rather than fix) some
p
KK,
On Tue, 2007-24-07 at 09:14 +0530, Krishna Kumar2 wrote:
>
> J Hadi Salim <[EMAIL PROTECTED]> wrote on 07/23/2007 06:02:01 PM:
> Actually you have not sent netperf results with prep and without prep.
My results were based on pktgen (which i explained as testing the
driver). I think depend
Al Boldi wrote:
> Patrick McHardy wrote:
>
>>Al Boldi wrote:
>>
>>>Patrick McHardy wrote:
>>>
But I vaguely recall having tried this myself and it broke somewhere,
maybe it was because of the NF_CONNTRACK_ENABLED option, I can't
recall anymore. Al, if this also works without removal of
On Tue, 24 Jul 2007, Andrew Morton wrote:
>
> fwiw, -fno-inline-functions-called-once (who knew?) takes i386 allnoconfig
> vmlinux .text from 928360 up to 955362 bytes (27k larger).
>
> A surprisingly large increase - I wonder if it did something dumb. It
> appears to still correctly inline th
Patrick McHardy wrote:
> Al Boldi wrote:
> > Patrick McHardy wrote:
> >>But I vaguely recall having tried this myself and it broke somewhere,
> >>maybe it was because of the NF_CONNTRACK_ENABLED option, I can't
> >>recall anymore. Al, if this also works without removal of
> >>NF_CONNTRACK_ENABLED,
On Tue, 24 Jul 2007 11:14:21 -0700 (PDT)
Linus Torvalds <[EMAIL PROTECTED]> wrote:
>
>
> On Tue, 24 Jul 2007, Adrian Bunk wrote:
> >
> > buffered_rmqueue() and prep_new_page() are static functions with only
> > one caller each, and for the normal non-debug case it's a really nice
> > optimiza
On Tue, 24 Jul 2007, Andrew Morton wrote:
>
> I guess this was the bug:
Looks very likely to me. Mike, Alexey, does this fix things for you?
Linus
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo in
Al Viro:
>
> AFAICS, all callers of dma_skb_copy_datagram_iovec()
>are either
> * recursive for fragments, pass pinned_list unchanged or
> * called from tcp, with pinned_list coming from
>tp->ucopy.pinned_list and only when tp->ucopy.dma_chan is non-NULL.
>
>Now, all non-NULL assi
On Tue, 24 Jul 2007, Adrian Bunk wrote:
>
> buffered_rmqueue() and prep_new_page() are static functions with only
> one caller each, and for the normal non-debug case it's a really nice
> optimization to have them inlined automatically.
I'm not at all sure I agree.
Inlining big functions doe
On Mon, Jul 23, 2007 at 02:28:11PM -0700, Linus Torvalds wrote:
>
>
> On Mon, 23 Jul 2007, Andrew Morton wrote:
> >
> > It'd be nice to get a clean trace. Are you able to obtain the full
> > trace with CONFIG_FRAME_POINTER=y?
>
> If you are talking about
>
> http://userweb.kernel.org/~a
Al Boldi wrote:
> Patrick McHardy wrote:
>
>>But I vaguely recall having tried this myself and it broke somewhere,
>>maybe it was because of the NF_CONNTRACK_ENABLED option, I can't
>>recall anymore. Al, if this also works without removal of
>>NF_CONNTRACK_ENABLED, please resend without that part.
Patrick McHardy wrote:
> Sam Ravnborg wrote:
> > On Tue, Jul 24, 2007 at 08:36:33AM +0300, Al Boldi wrote:
> >>Replaces NF_CONNTRACK_ENABLED with NF_CONNTRACK and selects it for
> >>NF_CONNTRACK_IPV4 and NF_CONNTRACK_IPV6
> >>
> >>This exposes IPv4/6 connection tracking options for easier Kconfig
>
You must explicitly specify the desired interface. For example,
on my test system, the correct interface is eth6 which is interface 8
(lo eth0 eth1 eth2 ... eth5 eth6). Here is an example nuttcp test
specifying interface 8:
chance% nuttcp -P5100 fe80::202:b3ff:fed4:cd1%8
1178.5809 MB / 10.0
On Tue, 2007-07-24 at 10:13 -0700, Rick Jones wrote:
> > Rick,
> >
> > I don't see any way around this. For example, on one of my test
> > systems, I have the following link local routes:
> >
> > chance% netstat -A inet6 -rn | grep fe80::/64
> > fe80::/64 ::
On 7/20/07, Al Viro <[EMAIL PROTECTED]> wrote:
AFAICS, all callers of dma_skb_copy_datagram_iovec()
are either
* recursive for fragments, pass pinned_list unchanged or
* called from tcp, with pinned_list coming from
tp->ucopy.pinned_list and only when tp->ucopy.dma_chan is
Rick,
I don't see any way around this. For example, on one of my test
systems, I have the following link local routes:
chance% netstat -A inet6 -rn | grep fe80::/64
fe80::/64 ::
U 25600 eth0
fe80::/64
On Tuesday 24 July 2007 12:33:26 pm Joy Latten wrote:
> > It also wouldn't hurt to change the text being sent to this function to
> > have a hyphen instead of a space, so "SPD delete" becomes "SPD-delete".
> > This keeps the parser happy.
>
> Steve, more for my education, should all entries have th
On 24/07/07, Patrick McHardy <[EMAIL PROTECTED]> wrote:
Jesper Juhl wrote:
> This patch cleans up duplicate includes in
> net/netfilter/
I've queued this one and the bridge-netfilter patch (27/37), thanks
Jesper.
Thanks for the feedback Patrick.
--
Jesper Juhl <[EMAIL PROTECTED]>
Don't
Sam Ravnborg wrote:
> On Tue, Jul 24, 2007 at 08:36:33AM +0300, Al Boldi wrote:
>
>>Replaces NF_CONNTRACK_ENABLED with NF_CONNTRACK and selects it for
>>NF_CONNTRACK_IPV4 and NF_CONNTRACK_IPV6
>>
>>This exposes IPv4/6 connection tracking options for easier Kconfig setup.
>>
>>Signed-off-by: Al Bo
Jeff,
Any chance of these patches getting committed soon?
Thanks,
-Dhananjay Phadke
On 7/21/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
These patches include fix for problem with 2nd port of multiport adapters
on IBM blades. Also improves interrupt handling for multiport adapters
avoiding
On Tue, 2007-07-24 at 11:04 -0400, Steve Grubb wrote:
> It also wouldn't hurt to change the text being sent to this function to have
> a
> hyphen instead of a space, so "SPD delete" becomes "SPD-delete". This keeps
> the parser happy.
>
Steve, more for my education, should all entries have thi
Thomas Graf wrote:
@@ -217,14 +229,8 @@ EXPORT_SYMBOL(genl_register_mc_group);
void genl_unregister_mc_group(struct genl_family *family,
struct genl_multicast_group *grp)
{
- BUG_ON(grp->family != family);
genl_lock();
- netlink_clear_multicast_
On Tue, Jul 24, 2007 at 08:31:08AM -0700, Kok, Auke wrote:
> Andy Gospodarek wrote:
> >There seems to have been some discussion about a patch like this in the
> >past but I still haven't noticed any platforms fixes or noticed that
> >this got included, so I'd like to propose this modified version.
On Tue, 24 Jul 2007 12:01:09 +0200 Mike Galbraith <[EMAIL PROTECTED]> wrote:
> On Mon, 2007-07-23 at 13:24 -0700, Andrew Morton wrote:
>
> > You're using DEBUG_PAGEALLOC, but I was not, so I think we can rule that
> > out.
>
> My box bugged during boot the first time I booted 23-rc1, but nothin
On Tue, 2007-07-24 at 11:04 -0400, Steve Grubb wrote:
> > + audit_log_format(audit_buf, "%s: auid=%u", buf, auid);
> >
> > if (sid != 0 &&
> > security_secid_to_secctx(sid, &secctx, &secctx_len) == 0)
>
> The operation in buf will not be parsed by the user space to
Hello,
From: Ken-ichirou MATSUZAWA <[EMAIL PROTECTED]>
Subject: Oops in xfrm_bundle_ok
Date: Thu, 05 Jul 2007 02:47:10 +0900 (JST)
> I got Oops like below. I glanced xfrm_bundle_ok() in
> xfrm_policy.c and __xfrm4.bundle_create() in xfrm4_policy.c.
It seems this was fixed by below, thanks a lot
Jesper Juhl wrote:
> This patch cleans up duplicate includes in
> net/netfilter/
I've queued this one and the bridge-netfilter patch (27/37), thanks
Jesper.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info
Andy Gospodarek wrote:
There seems to have been some discussion about a patch like this in the
past but I still haven't noticed any platforms fixes or noticed that
this got included, so I'd like to propose this modified version.
Thoughts?
I've written a completely new version for IBM based on
There seems to have been some discussion about a patch like this in the
past but I still haven't noticed any platforms fixes or noticed that
this got included, so I'd like to propose this modified version.
Thoughts?
Signed-off-by: Andy Gospodarek <[EMAIL PROTECTED]>
---
e1000_hw.c |7 +
Joakim Koskela wrote:
> This patch modifies the xfrm state selection logic to use the inner
> addresses where the outer have been (incorrectly) used. This is
> required for beet mode in general and interfamily setups in both
> tunnel and beet mode.
Looks good.
Acked-by: Patrick McHardy <[EMAIL P
On 7/24/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
[...]
> What about the new async crypto stuff? I've been looking, but is it
> guarenteed that async_memcpy() runs in process context with interrupts
> enabled always? If not, there's a km type bug there.
I think Shannon maintains that now.
On 7/24/07, Jens Axboe <[EMAIL PROTECTED]> wrote:
What about the new async crypto stuff? I've been looking, but is it
guarenteed that async_memcpy() runs in process context with interrupts
enabled always? If not, there's a km type bug there.
Currently the only user is the MD raid456 driver, an
Patrick McHardy wrote:
> Varun Chandramohan wrote:
>
>> Oliver Hartkopp wrote:
>>
>>
> I don't think you should round down timeout values.
>
>
>
>
Can you elaborate on that? As per the RFC of MIB ,we need only seconds
granularity. Taking
Varun Chandramohan wrote:
> Oliver Hartkopp wrote:
>
I don't think you should round down timeout values.
>>>
>>>Can you elaborate on that? As per the RFC of MIB ,we need only seconds
>>>granularity. Taking that as the case i dont understand why round down
>>>should n
From: Rick Jones <[EMAIL PROTECTED]>
Subject: Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)
Date: Thu, 12 Jul 2007 13:51:44 -0700
> > TCP's timeouts are perfectly fine, and the only thing you
> > might be showing above is that the application timeouts
> > are too short or that TCP n
From: Rick Jones <[EMAIL PROTECTED]>
Subject: Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)
Date: Thu, 12 Jul 2007 15:27:30 -0700
> > So the problem is that RTO can grows to be twice the failover detection
> > time. So back to the original mail, the scenario has a switch with failo
ACK :-)
cheers,
Petko
On Mon, 23 Jul 2007, Micah Gruber wrote:
This patch fixes a potential null dereference bug where we dereference
pegasus before a null check. This patch simply moves the dereferencing after
the null check.
Signed-off-by: Micah Gruber <[EMAIL PROTECTED]>
---
--- a/dr
Feedback welcome, as always!
(There's been talk of a virtualization git tree, in which case there'll
be a decent home for these patches soon).
Cheers,
Rusty.
==
Add feature and GSO support to virtio net driver.
If you don't do GSO, you can simply ignore the first sg element of
every outgoing pac
Thomas Graf wrote:
> Please provide a new overall patch which is not based on your
> initial patch so I can review your idea properly.
Here it goes (merging two previous patches). I have diffed
against v2.6.22, which I am using currently as my base:
include/net/genetlink.h |1 +
net/netlink/
On Tue, 2007-07-24 at 12:01 +0200, Mike Galbraith wrote:
> On Mon, 2007-07-23 at 13:24 -0700, Andrew Morton wrote:
>
> > You're using DEBUG_PAGEALLOC, but I was not, so I think we can rule that
> > out.
>
> My box bugged during boot the first time I booted 23-rc1, but nothing
> made it to the co
On Mon, 2007-07-23 at 13:24 -0700, Andrew Morton wrote:
> You're using DEBUG_PAGEALLOC, but I was not, so I think we can rule that out.
My box bugged during boot the first time I booted 23-rc1, but nothing
made it to the console, and I didn't have a serial console running. I
didn't have DEBUG_PA
1 - 100 of 123 matches
Mail list logo