Hi Jamal,
J Hadi Salim <[EMAIL PROTECTED]> wrote on 07/21/2007 06:48:41 PM:
> >- Use a single qdisc interface to avoid code duplication and reduce
> > maintainability (sch_generic.c size reduces by ~9%).
> >- Has per device configurable parameter to turn on/off batching.
> >- qdi
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Sun, 22 Jul 2007 12:39:32 +1000
> But if netdev -> driver_private can be optimized, so can driver_private
> -> netdev. We just don't have a wrapper for it. netdev_of() perhaps?
>
> (If it can't be implemented by ptr arith, we have to do some allocat
On Sat, 2007-07-21 at 18:59 -0700, David Miller wrote:
> But note that you'd be adding a pointer deref, the current sequence:
>
> napi_struct --> netdev --> driver_private
>
> involves all pointer arithmetic and no derefs, whereas:
>
> napi_struct --> driver_private --> netdev
>
> will involve
From: David Howells <[EMAIL PROTECTED]>
Date: Fri, 20 Jul 2007 10:53:25 +0100
> Add missing entries to af_family_clock_key_strings[].
>
> Signed-off-by: David Howells <[EMAIL PROTECTED]>
Applied, thanks David.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a m
From: Jan-Bernd Themann <[EMAIL PROTECTED]>
Date: Fri, 20 Jul 2007 17:41:48 +0200
> Generic LRO patch
>
> Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
I have no general objections to this patch.
However I'd like to see at least one or two uses of these APIs before
we put it in, and it s
From: Jan Engelhardt <[EMAIL PROTECTED]>
Date: Sat, 21 Jul 2007 18:27:38 +0200 (CEST)
> Enabling drivers from "Devices > Networking" (in menuconfig), for
> example SLIP and/or PLIP, throws link time errors when CONFIG_NET itself
> is =n. Have CONFIG_NETDEVICES depend on CONFIG_NET.
>
> Signed-o
From: Al Viro <[EMAIL PROTECTED]>
Date: Sat, 21 Jul 2007 09:12:31 +0100
> IPV6_TCLASS_MASK is net-endian; what happens here is that we take
> a value and shove it into bits 20--27 of net-endian 32bit word.
> IOW, it's misannotated (it's really htonl, not ntohl) *and* the
> mask should be applied a
From: [EMAIL PROTECTED]
Date: Sat, 21 Jul 2007 11:13:07 +0300
> From: Stephen Rothwell <[EMAIL PROTECTED]>
>
> Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
> Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]>
Also applied, thanks.
-
To unsub
From: [EMAIL PROTECTED]
Date: Sat, 21 Jul 2007 11:13:06 +0300
> The EP7211 SIR driver was the only one left without a new SIR API port.
>
> Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]>
Applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EM
From: [EMAIL PROTECTED]
Date: Sat, 21 Jul 2007 11:13:05 +0300
> Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]>
Applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Sun, 22 Jul 2007 09:10:23 +1000
> In five years' time, the "napi_struct for simple drivers" in net_device
> will look confusing. Since your change touches all NAPI drivers anyway,
> it'd be nice to go straight to "everyone allocates their own NAPI
> s
On Sat, 2007-07-21 at 11:54 -0700, David Miller wrote:
> From: Rusty Russell <[EMAIL PROTECTED]>
> Date: Sat, 21 Jul 2007 18:00:11 +1000
>
> > No, I was just thinking that drivers will put the napi_struct in their
> > driver-specific struct (eg. struct e1000_adapter *adapter =
> > container_of(con
commit 36d139ccebba6a1082b743fbedb53c5a5097987c
Author: Mark Hindley <[EMAIL PROTECTED]>
Date: Sat Jul 21 22:56:08 2007 +0100
Check return of pci_enable_device in vortex_up().
Signed-off-by: Mark Hindley <[EMAIL PROTECTED]>
diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
ind
On Saturday 21 July 2007 20:53:04 David Miller wrote:
> From: Andi Kleen <[EMAIL PROTECTED]>
> Date: Sat, 21 Jul 2007 09:49:22 +0200
>
> > Since -git15 (probably David's merge) I see a lot of
> >
> > Virtual device lo asks to queue packet!
> > Virtual device lo asks to queue packet!
> > Virtual
Ben Greear <[EMAIL PROTECTED]> writes:
>> IOW: I think all Ethernet interfaces should always be VLAN-aware,
>> stripping the tag (only one) early on RX and adding it late on TX.
>> That means tcpdump would see packets with exactly one tag removed
>> (unless there was no tag), in both RX and TX.
>>
The sch->parent handle will be NULL for the scheduler that is TC_H_ROOT.
Change this check in prio_tune() so that only the root qdisc can be
multiqueue-enabled.
Signed-off-by: Peter P Waskiewicz Jr <[EMAIL PROTECTED]>
---
net/sched/sch_prio.c |6 --
1 files changed, 4 insertions(+), 2 de
> > Anyways, I tried a few different things, and what it looks like is
> > sch->parent will be NULL (0) for the top-level device. This is
> > sch->correct,
> > and trying to mess with that screws up qdisc_graft() when unloading
> > the qdisc. I also tried adding a TCQ_F_ROOT flag to
> sch->fla
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Sat, 21 Jul 2007 18:00:11 +1000
> No, I was just thinking that drivers will put the napi_struct in their
> driver-specific struct (eg. struct e1000_adapter *adapter =
> container_of(container_of(napi, struct e1000_adapter, napi);).
That works.
> Mu
From: Andi Kleen <[EMAIL PROTECTED]>
Date: Sat, 21 Jul 2007 09:49:22 +0200
> Since -git15 (probably David's merge) I see a lot of
>
> Virtual device lo asks to queue packet!
> Virtual device lo asks to queue packet!
> Virtual device lo asks to queue packet!
> Virtual device lo asks to queue pack
> From: Patrick McHardy <[EMAIL PROTECTED]>
> Date: Sat, 21 Jul 2007 06:01:07 +0200
>
> > Waskiewicz Jr, Peter P wrote:
> > > I just sent out a patch to fix this.
> >
> > I didn't see it yet.
>
> VGER ate it for some reason and I didn't notice it during my
> daily bounce analysis. I asked him
--- Tetsuo Handa <[EMAIL PROTECTED]> wrote:
>
> Hello.
>
> Patrick McHardy wrote:
> > Quoting Tetsuo:
> > > > So, my approach is not using security context associated with a socket
> > > > but security context associated with a process.
> > Isn't the socket context derived from the process cont
Krzysztof Halasa wrote:
Ben Greear <[EMAIL PROTECTED]> writes:
There is already a flag you can set on vlan devices (reorder-header)
that strips the VLAN tag before presenting it to user-space.
Sure, but isn't it only valid for VLAN device (not the main ethX)?
I.e., can you have the ta
This is the first listing of the open bugs that will be sent out and will
contain bugs on specific areas.
The bugs on the list below are about a year old and most of them confirmed
(or claimed) to still be a problem.
It would be appreciated if the corresponding maintenance team could take a
On Sat, Jul 21, 2007 at 06:49:30PM +0200, Andi Kleen ([EMAIL PROTECTED]) wrote:
> On Saturday 21 July 2007 09:49:22 Andi Kleen wrote:
> >
> > FYI
> >
> > Since -git15 (probably David's merge) I see a lot of
> >
> > Virtual device lo asks to queue packet!
> > Virtual device lo asks to queue pack
On Saturday 21 July 2007 09:49:22 Andi Kleen wrote:
>
> FYI
>
> Since -git15 (probably David's merge) I see a lot of
>
> Virtual device lo asks to queue packet!
> Virtual device lo asks to queue packet!
> Virtual device lo asks to queue packet!
> Virtual device lo asks to queue packet!
> Virtua
Hi,
enable everything from Drivers > Networking, but deselect CONFIG_NET.
This throws a ton of linking errors (when using CONFIG_MODULES=n), and
probably unresolved symbols (MODULES=m). Happens in current -git, but I
believe it dates much farther back, because this is imo just a simple
Kconfi
Hi,
This patch cleans up duplicate includes in
net/xfrm/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index c3a4b0a..e67489a 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -23,10 +23,9 @@
#include
Hi,
This patch cleans up duplicate includes in
net/tipc/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/tipc/port.c b/net/tipc/port.c
index 5d2b9ce..7608815 100644
--- a/net/tipc/port.c
+++ b/net/tipc/port.c
@@ -41,7 +41,6 @@
#include "addr.h"
#include "link.h"
#
Hi,
This patch cleans up duplicate includes in
net/ipv6/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index d67fb1e..db50114 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -56,7 +56,6 @@
#include
#include
#
Hi,
This patch cleans up duplicate includes in
net/sched/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/sched/act_police.c b/net/sched/act_police.c
index bf90e60..6085be5 100644
--- a/net/sched/act_police.c
+++ b/net/sched/act_police.c
@@ -16,7 +16,6 @@
#include
Hi,
This patch cleans up duplicate includes in
net/netfilter/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/netfilter/nf_conntrack_proto_tcp.c
b/net/netfilter/nf_conntrack_proto_tcp.c
index 87ad3cc..eb3fe74 100644
--- a/net/netfilter/nf_conntrack_proto_tcp.c
+++ b
Hi,
This patch cleans up duplicate includes in
net/atm/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/atm/lec.c b/net/atm/lec.c
index 2770fb4..59d5aa3 100644
--- a/net/atm/lec.c
+++ b/net/atm/lec.c
@@ -21,7 +21,6 @@
#include
#include
#include
-#include
#inc
Hi,
This patch cleans up duplicate includes in
net/bridge/
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
diff --git a/net/bridge/netfilter/ebt_log.c b/net/bridge/netfilter/ebt_log.c
index 031bfa4..89d0d59 100644
--- a/net/bridge/netfilter/ebt_log.c
+++ b/net/bridge/netfilter/ebt_lo
On 7/20/07, Jan-Bernd Themann <[EMAIL PROTECTED]> wrote:
Hi,
Thanks a lot for your comments so far.
This generic LRO patch differs from the last one in several points.
A new interface for a "receive in pages" mode has been added and tested
with an eHEA prototype. Seems to work well.
Does this e
On Fri, 2007-20-07 at 08:18 +0100, Stephen Hemminger wrote:
> You may see worse performance with batching in the real world when
> running over WAN's. Like TSO, batching will generate back to back packet
> trains that are subject to multi-packet synchronized loss.
Has someone done any study on
I tried to mount another nfs mount on a system running with nfsroot.
But I get
# mount basil:/home /basil/home/
mount: Network is down
The network is not down of course, the system is happily running with nfs root
from that
server. Userland is older SUSE 10.0
Excerpt from strace mount:
-Andi
I am (have been) under extreme travel mode - so i will have high latency
in follow ups.
On Fri, 2007-20-07 at 12:01 +0530, Krishna Kumar wrote:
> Hi Dave, Roland, everyone,
>
> In May, I had proposed creating an API for sending 'n' skbs to a driver to
> reduce lock overhead, DMA operations, and
David Miller <[EMAIL PROTECTED]> writes:
>
> Good candidates for taking advantage of multi-napi are:
>
> 1) e1000
> 2) ucc_geth
> 3) ehea
> 4) sunvnet
s2io.c
-Andi
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo i
Ben Greear <[EMAIL PROTECTED]> writes:
> There is already a flag you can set on vlan devices (reorder-header)
> that strips the VLAN tag before presenting it to user-space.
Sure, but isn't it only valid for VLAN device (not the main ethX)?
I.e., can you have the tag stripped from frames captured
Hi Sridhar,
Sridhar Samudrala <[EMAIL PROTECTED]> wrote on 07/20/2007 11:14:19 PM:
> > @@ -1566,7 +1605,7 @@ gso:
> > /* reset queue_mapping to zero */
> > skb->queue_mapping = 0;
> > rc = q->enqueue(skb, q);
> > - qdisc_run(dev);
> > + qdisc_run(dev,
Hi Sridhar,
Sridhar Samudrala <[EMAIL PROTECTED]> wrote on 07/20/2007 10:55:05 PM:
> > diff -ruNp org/include/net/pkt_sched.h new/include/net/pkt_sched.h
> > --- org/include/net/pkt_sched.h 2007-07-20 07:49:28.0 +0530
> > +++ new/include/net/pkt_sched.h 2007-07-20 08:30:22.0 +0
Hi Patrick,
Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 11:46:36 PM:
> Krishna Kumar wrote:
> > +static inline int get_skb(struct net_device *dev, struct Qdisc *q,
> > + struct sk_buff_head *blist,
> > + struct sk_buff **skbp)
> > +{
> > + if (likely(!blist) || (
Krishna Kumar2/India/IBM wrote on 07/21/2007 12:26:23 PM:
> Hi Patrick,
>
> Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 11:46:36 PM:
>
> > The check for tx_queue_len is wrong though,
> > its only a default which can be overriden and some qdiscs don't
> > care for it at all.
> I think
Stephen Hemminger <[EMAIL PROTECTED]> wrote on 07/20/2007
09:52:03 PM:
> Patrick McHardy <[EMAIL PROTECTED]> wrote:
>
> > Krishna Kumar2 wrote:
> > > Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 03:37:20 PM:
> > >
> > >
> > >
> > >> rtnetlink support seems more important than sysfs to me
The EP7211 SIR driver was the only one left without a new SIR API port.
Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]>
---
drivers/net/irda/Kconfig |9
drivers/net/irda/Makefile |1 +
drivers/net/irda/ep7211-sir.c | 89 +
include/li
From: Stephen Rothwell <[EMAIL PROTECTED]>
Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]>
---
drivers/net/irda/Kconfig |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--
Cheers,
Ste
Hi Dave,
Here go 3 minor IrDA patches that could hopefully make it to the merge window.
Cheers,
Samuel.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signed-off-by: Samuel Ortiz <[EMAIL PROTECTED]>
Index: net-2.6-quilt/net/irda/irnetlink.c
===
--- net-2.6-quilt.orig/net/irda/irnetlink.c 2007-07-21 02:41:24.0
+0300
+++ net-2.6-quilt/net/irda/irnetlink.c 2007-07-21 02:4
IPV6_TCLASS_MASK is net-endian; what happens here is that we take
a value and shove it into bits 20--27 of net-endian 32bit word.
IOW, it's misannotated (it's really htonl, not ntohl) *and* the
mask should be applied after conversion to net-endian, not before it.
The former is harmless, the latter
On Sat, 21 Jul 2007 00:44:08 -0700 (PDT) [EMAIL PROTECTED] wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=8789
>
>Summary: Error inserting ipt_LOG (mod_path): Device or resource
> busy
A 2.6.12 -> 2.6.22 regression.
>Product: Networking
>
On Sat, 2007-07-21 at 00:42 -0700, David Miller wrote:
> From: Rusty Russell <[EMAIL PROTECTED]>
> Date: Sat, 21 Jul 2007 17:14:31 +1000
>
> > This looks good! It might be nice though to go further and remove the
> > internal napi_struct. It's kind of a wart for multi-queue drivers which
> >
FYI
Since -git15 (probably David's merge) I see a lot of
Virtual device lo asks to queue packet!
Virtual device lo asks to queue packet!
Virtual device lo asks to queue packet!
Virtual device lo asks to queue packet!
Virtual device lo asks to queue packet!
Virtual device lo asks to queue packet
From: Rusty Russell <[EMAIL PROTECTED]>
Date: Sat, 21 Jul 2007 17:14:31 +1000
> This looks good! It might be nice though to go further and remove the
> internal napi_struct. It's kind of a wart for multi-queue drivers which
> are going to have their own array (or whatever).
I guess you're
On Fri, 2007-07-20 at 22:31 -0700, David Miller wrote:
> Stephen asked me if I could resurrect the last version of
> his napi_poll patch that I posted a long time ago, I finally
> got to that tonight.
>
> Basically, this disconnects the ->poll() object from the net
> device. This will allow drive
54 matches
Mail list logo
