From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sat, 21 Jul 2007 07:46:39 +0200
> I believe the compat attribute should work fine. One thing thing
> that is not explicitly supported as datatype, but works fine, is
> lists of attributes (using nla_for_each_attr), which looks like a
> good match for
David Miller wrote:
[ huge patch, not looked at it :) ]
> One area for discussion is what to do about rtnetlink, it allows
> setting the dev->napi.weight, but we need to extend it so it can
> do something sane in multi-napi-per-netdev situations.
I believe the compat attribute should work fine.
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sat, 21 Jul 2007 05:38:10 +0200
> Yes, some constant limit definitely makes sense. The Tx batching
> patches motivated me to work through struct net_device with pahole
> and I have some patches that rearrange it to save about 64 bytes and
> move some
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sat, 21 Jul 2007 06:01:07 +0200
> Waskiewicz Jr, Peter P wrote:
> > I just sent out a patch to fix this.
>
> I didn't see it yet.
VGER ate it for some reason and I didn't notice it during my
daily bounce analysis. I asked him on IRC to resend it,
Waskiewicz Jr, Peter P wrote:
>>Its set after grafting the parent, which is after initialization.
>>I think what should work is to set it in qdisc_create
>>instead, sch_api.c around line 490:
>>
>>+ sch->parent = handle;
>>
>>if (handle == TC_H_INGRESS) {
>>sch->flags |
AFAICS, all callers of dma_skb_copy_datagram_iovec()
are either
* recursive for fragments, pass pinned_list unchanged or
* called from tcp, with pinned_list coming from
tp->ucopy.pinned_list and only when tp->ucopy.dma_chan is non-NULL.
Now, all non-NULL assignments to ->dm
David Miller wrote:
> From: Patrick McHardy <[EMAIL PROTECTED]>
> Date: Thu, 19 Jul 2007 12:11:10 +0200
>
>
>>The easiest fix would be to use egress_subqueue[1] in struct
>>net_device, but I think that may cause warnings with newer gccs
>>when using a constant index that is > 0. OTOH using consta
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu, 19 Jul 2007 12:11:10 +0200
> The easiest fix would be to use egress_subqueue[1] in struct
> net_device, but I think that may cause warnings with newer gccs
> when using a constant index that is > 0. OTOH using constant
> indices doesn't seem to
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Thu, 19 Jul 2007 14:48:59 +0200
> Gabriel C wrote:
> > Hello ,
> >
> > I noticed on current git this warning in net/ipv4/inetpeer.c
>
> Yeah, I have no idea why the gcc people thought that this was
> something worth warning about. Especially since e
Hello.
Patrick McHardy wrote:
> Quoting Tetsuo:
> > > So, my approach is not using security context associated with a socket
> > > but security context associated with a process.
> Isn't the socket context derived from the process context?
Not so regarding my case.
static int smack_sk_alloc_secu
Denis Cheng wrote:
Cc: [EMAIL PROTECTED]
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
Acked-by: Divy Le Ray <[EMAIL PROTECTED]>
---
drivers/net/cxgb3/cxgb3_main.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drivers/net/cx
Got with randconfig:
XXX: undefined reference to `netif_carrier_on'
XXX: undefined reference to `dev_queue_xmit'
...
Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]>
Index: b/drivers/net/Kconfig
===
--- a/drivers/net/Kconfig
+++ b
Update the file link in the Pegasus USB network driver's help text.
Signed-off-by: Cal Peake <[EMAIL PROTECTED]>
--- ./drivers/net/usb/Kconfig~orig 2007-06-13 18:14:39.0 -0400
+++ ./drivers/net/usb/Kconfig 2007-07-20 18:26:57.0 -0400
@@ -71,7 +71,7 @@ config USB_PEGASUS
> Its set after grafting the parent, which is after initialization.
> I think what should work is to set it in qdisc_create
> instead, sch_api.c around line 490:
>
> + sch->parent = handle;
>
> if (handle == TC_H_INGRESS) {
> sch->flags |= TCQ_F_INGRESS;
>
Krzysztof Halasa wrote:
Another idea - perhaps we could make the software VLANs behave
the same as hw ones? I.e., stripping the tag on RX while setting
some magic skb field?
The packets could go via main interface first (normal path, with
eth_type_trans stripping the tag and setting protocol = s
netdev: i82596 Ethernet needs on m68k
drivers/net/82596.c: In function 'init_rx_bufs':
drivers/net/82596.c:552: error: implicit declaration of function 'cache_clear'
drivers/net/82596.c: In function 'i596_start_xmit':
drivers/net/82596.c:1104: error: implicit declaration of function 'cache_push'
Ben Greear <[EMAIL PROTECTED]> writes:
>> The net result is that dev_queue_xmit_nit() is called twice, once
>> for dev=eth0.2 then for dev=eth0.
>
> Maybe binding to all isn't such a good idea then.
Anyway I would expect the frame on eth0.2 and then on eth0 as well.
Anything different is crazy.
-
Another idea - perhaps we could make the software VLANs behave
the same as hw ones? I.e., stripping the tag on RX while setting
some magic skb field?
The packets could go via main interface first (normal path, with
eth_type_trans stripping the tag and setting protocol = some 802.1Q),
netif_rx | ne
Michael Chan wrote:
On Fri, 2007-07-20 at 18:59 +0200, patric wrote:
Thanks... That's a confirmation on what i suspected.. I think i'll dig
into the code instead and try to figure out some way of making it work a
bit better for my setup atleast...
I'll post a patch later if i get somethin
This fixes issue with 2nd port of multiport adapter that the MAC address
is reset by firmware in PCI probe. This patch also fixes a bug that PCI
resources are not released if dma watchdog shutdown failed. The dma watchdog
poll messages during module unload are also suppressed.
Signed-off-by: Dhana
This patch fixes masking of interrupts on multiport adapters. Also disables
interrupts upon ifdown interface. The wrong mask could result in interrupt
flood after interface is down.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen/netxen_nic_main.c
=
These patches include fix for problem with 2nd port of multiport adapters
on IBM blades. Also improves interrupt handling for multiport adapters
avoiding interrupt flood after interrupt is down.
Generated against upstream-fixes.
drivers/net/netxen/netxen_nic.h |3 +-
drivers/net/net
On Fri, 2007-07-20 at 18:59 +0200, patric wrote:
> Thanks... That's a confirmation on what i suspected.. I think i'll dig
> into the code instead and try to figure out some way of making it work a
> bit better for my setup atleast...
> I'll post a patch later if i get something working... Btw,
Krishna Kumar wrote:
> +static inline int get_skb(struct net_device *dev, struct Qdisc *q,
> + struct sk_buff_head *blist,
> + struct sk_buff **skbp)
> +{
> + if (likely(!blist) || (!skb_queue_len(blist) && qdisc_qlen(q) <= 1)) {
> + retur
On Fri, 2007-07-20 at 12:02 +0530, Krishna Kumar wrote:
> Changes in dev.c to support batching : add dev_add_skb_to_blist,
> register_netdev recognizes batch aware drivers, and net_tx_action is
> the sole user of batching.
>
> Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>
> ---
> dev.c | 77
On Fri, 2007-07-20 at 12:02 +0530, Krishna Kumar wrote:
> Networking include file changes for batching.
>
> Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>
> ---
> linux/netdevice.h | 10 ++
> net/pkt_sched.h |6 +++---
> 2 files changed, 13 insertions(+), 3 deletions(-)
>
> dif
Michael Chan wrote:
On Thu, 2007-07-19 at 15:24 +0200, patric wrote:
Just a hypothetical question. If the 2 network cards starts the
autonegotiation would it be possible that they get into a loop where
they are chasing each others state? Maybe a fix could be to add a sleep
of a random le
On Fri, Jul 20, 2007 at 12:57:02AM -0700, Andrew Morton wrote:
> On Fri, 20 Jul 2007 11:50:39 +0400 Vitaly Bordug <[EMAIL PROTECTED]> wrote:
> > On Thu, 19 Jul 2007 23:23:37 -0700
> > Andrew Morton wrote:
> > > Shouldn't these be runtime options (ie: module parameters)?
> > >
> > I thought about i
Hi Jeff,
> Where is the hard_start_xmit/TX-completion locking?
The entire PIO Tx operation is performed within hard_start_xmit, so should
be covered by netif_tx_lock.
Regards,
--
Steve Glendinning
SMSC GmbH
m: +44 777 933 9124
e: [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line
On Fri, 20 Jul 2007 13:21:51 +0200
Patrick McHardy <[EMAIL PROTECTED]> wrote:
> Krishna Kumar2 wrote:
> > Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 03:37:20 PM:
> >
> >
> >
> >> rtnetlink support seems more important than sysfs to me.
> >>
> >
> > Thanks, I will add that as a
Patrick McHardy wrote:
> [ Please quote and break your lines appropriately ]
Oops, sorry for that, definitely was not intentional :(.
> Export the lock/unlock/.. functions. You'll also need a new version
> similar to __rtnl_unlock.
Patrick, you might feel, I am not reading your lines, but in fa
Generic LRO patch
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]>
---
include/linux/inet_lro.h | 154 +
net/ipv4/inet_lro.c | 549 ++
2 files changed, 703 insertions(+), 0 deletions(-)
create mode 100644 include/linux/inet_lro.
Hi,
Thanks a lot for your comments so far.
This generic LRO patch differs from the last one in several points.
A new interface for a "receive in pages" mode has been added and tested
with an eHEA prototype. Seems to work well.
Does this extended interface seem to be sufficient?
Below some more e
James Morris wrote:
On Sat, 21 Jul 2007, Tetsuo Handa wrote:
I can't use netfilter infrastructure because
it is too early to know who the recipant process of the packet is.
I think the way forward on this is to re-visit the idea of providing a
proper solution for the incoming packet/
On Sat, 21 Jul 2007, Tetsuo Handa wrote:
> I can't use netfilter infrastructure because
> it is too early to know who the recipant process of the packet is.
I think the way forward on this is to re-visit the idea of providing a
proper solution for the incoming packet/user match problem.
I poste
On Fri, 20 Jul 2007 16:07:33 +0100
Al Viro <[EMAIL PROTECTED]> wrote:
> Doing |= 1 << 19 to 16bit unsigned is not particulary useful;
> that register is 32bit, unlike the ones dealt with in the rest of
> function, so we need u32 variable here.
>
> Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Hello.
> > Isn't it better to hook into existing netfilter infrastructure somehow?
> Yes, it has been suggested several times.
I want to use a process's context who issued
accept()/recv()/recvfrom()/recvmsg()/read() requests.
But Stephen Smalley said at
http://marc.info/?l=linux-security-module&
Please ignore this patch. There's one more patch in the series. I will
send them together.
Thanks,
-Dhananjay
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[ Please quote and break your lines appropriately ]
Richard MUSIL wrote:
> Patrick McHardy wrote:
>>
>>The usual way to do this for auto-loading of modules that register
>>things that take a mutex that is already held during netlink queue
>>processing, like qdiscs, classifiers, .. is:
>>
>>- look
Patrick McHardy wrote:
> Richard MUSIL wrote:
>> I am currently trying to write a module which communicates with user
>> space using NETLINK_GENERIC. This module (dev_mgr) manages virtual
>> devices which are also supposed to use genetlink for communication
>> with user space.
>>
>> I want to do so
Richard MUSIL wrote:
I am currently trying to write a module which communicates with user space
using NETLINK_GENERIC. This module (dev_mgr) manages virtual devices which are
also supposed to use genetlink for communication with user space.
I want to do something like that:
dev_mgr <- receives
I am currently trying to write a module which communicates with user space
using NETLINK_GENERIC. This module (dev_mgr) manages virtual devices which are
also supposed to use genetlink for communication with user space.
I want to do something like that:
dev_mgr <- receives message from user spac
On Fri, 20 Jul 2007, Gabriel C wrote:
> Robert P. J. Day wrote:
> > this has *nothing* to do with the aforementioned maturity levels.
> > i understand entirely the inconsistency above. what i'm
> > suggesting is that it might very well be more appropriate to *drop
> > the dependency* rather than
Hi Evgeniy,
Evgeniy Polyakov <[EMAIL PROTECTED]> wrote on 07/20/2007 06:24:23 PM:
> > After fine-tuning qdisc and other changes, I modified IPoIB to use this
API,
> > and now get good gains. Summary for TCP & No Delay: 1 process improves
for
> > all cases from 1.4% to 49.5%; 4 process has almost
Hi Krishna.
On Fri, Jul 20, 2007 at 12:01:49PM +0530, Krishna Kumar ([EMAIL PROTECTED])
wrote:
> After fine-tuning qdisc and other changes, I modified IPoIB to use this API,
> and now get good gains. Summary for TCP & No Delay: 1 process improves for
> all cases from 1.4% to 49.5%; 4 process has
This is a change to remove a local hack in favour to __maybe_unused that
has been recently added.
Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]>
---
Hi,
It should be obvious. The code builds, therefore it works.
Please apply,
Maciej
patch-mips-2.6.22-20070710-defxx-unused-0
diff -
(My Notes crashed when I hit the Send button, so not sure if this went
out).
__
Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 04:50:37 PM:
> 32 bytes? I count 16, - 4 for the pointer, so its 12 bytes of waste.
> If you'd use it for gso_skb it would come down to 8 bytes
Krishna Kumar2 wrote:
Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 04:50:37 PM:
32 bytes? I count 16, - 4 for the pointer, so its 12 bytes of waste.
If you'd use it for gso_skb it would come down to 8 bytes. struct
net_device is a pig already, and there are better ways to reduce t
Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 04:50:37 PM:
> 32 bytes? I count 16, - 4 for the pointer, so its 12 bytes of waste.
> If you'd use it for gso_skb it would come down to 8 bytes. struct
> net_device is a pig already, and there are better ways to reduce this
> than starting to
Robert P. J. Day wrote:
> On Fri, 20 Jul 2007, Gabriel C wrote:
>
>> Robert P. J. Day wrote:
>>> On Fri, 20 Jul 2007, Gabriel C wrote:
>>>
Hi,
IP_VS has :
..
tristate "IP virtual server support (EXPERIMENTAL)"
..
but it does not depend on EXPE
On Fri, 20 Jul 2007, Gabriel C wrote:
> Robert P. J. Day wrote:
> > On Fri, 20 Jul 2007, Gabriel C wrote:
> >
> >> Hi,
> >>
> >> IP_VS has :
> >>
> >> ..
> >>
> >> tristate "IP virtual server support (EXPERIMENTAL)"
> >>
> >> ..
> >>
> >> but it does not depend on EXPERIMENTAL.
> >>
> >>
> >> Sign
Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007:
> I can't really argue about the numbers, but it seems to me that only
> devices which *usually* have a sufficient queue length will support
> this, and anyone setting the queue length of a gbit device to <16 is
> begging for trouble anyway.
Robert P. J. Day wrote:
> On Fri, 20 Jul 2007, Gabriel C wrote:
>
>> Hi,
>>
>> IP_VS has :
>>
>> ..
>>
>> tristate "IP virtual server support (EXPERIMENTAL)"
>>
>> ..
>>
>> but it does not depend on EXPERIMENTAL.
>>
>>
>> Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]>
>>
>> ---
>>
>> net/
as a short followup to my previous post, at the *very least*, a
cleanup that could be done now is to find all entries which have an
actual dependency on "EXPERIMENTAL" but don't advertise themselves as
such:
...
config MA600_DONGLE
tristate "Mobile Action MA600 dongle"
depends o
Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 03:41:01 PM:
> Krishna Kumar wrote:
> > diff -ruNp org/net/sched/sch_generic.c new/net/sched/sch_generic.c
> > --- org/net/sched/sch_generic.c 2007-07-20 07:49:28.0 +0530
> > +++ new/net/sched/sch_generic.c 2007-07-20 08:30:22.000
On Fri, 20 Jul 2007, Gabriel C wrote:
> Hi,
>
> IP_VS has :
>
> ..
>
> tristate "IP virtual server support (EXPERIMENTAL)"
>
> ..
>
> but it does not depend on EXPERIMENTAL.
>
>
> Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]>
>
> ---
>
> net/ipv4/ipvs/Kconfig |2 +-
> 1 files changed
Krishna Kumar2 wrote:
Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 04:50:37 PM
Is there any downside in using batching with smaller queue sizes?
I think there is, but as yet I don't have any data (and 16 is probably
higher
than reqd) to show it. If the queue size is very small
Hi Patrick,
Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 04:50:37 PM:
> > I have a TODO comment in net-sysfs.c which is to catch this case.
> >
>
> I noticed that. Still wondering why it is important at all though.
I saw another mail of yours on the marc list on this same topic (which
Hi,
IP_VS has :
..
tristate "IP virtual server support (EXPERIMENTAL)"
..
but it does not depend on EXPERIMENTAL.
Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]>
---
net/ipv4/ipvs/Kconfig |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/ipvs/Kconfi
Krishna Kumar2 wrote:
Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 03:41:01 PM:
-static inline int qdisc_restart(struct net_device *dev)
+static inline int qdisc_restart(struct net_device *dev,
+struct sk_buff_head *blist)
{
struct Qdisc *q = dev->qdisc;
struct
Krishna Kumar2 wrote:
Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 03:37:20 PM:
rtnetlink support seems more important than sysfs to me.
Thanks, I will add that as a patch. The reason to add to sysfs is that
it is easier to change for a user (and similar to tx_queue_len).
Krishna Kumar2 wrote:
Hi Patrick,
Thanks for your comments.
Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 03:34:30 PM:
The queue length can be changed through multiple interfaces, if that
really is important you need to catch these cases too.
I have a TODO comment in net-s
Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 03:37:20 PM:
> Krishna Kumar wrote:
> > Support to turn on/off batching from /sys.
>
>
> rtnetlink support seems more important than sysfs to me.
Thanks, I will add that as a patch. The reason to add to sysfs is that
it is easier to change f
Hi Patrick,
Thanks for your comments.
Patrick McHardy <[EMAIL PROTECTED]> wrote on 07/20/2007 03:34:30 PM:
> The queue length can be changed through multiple interfaces, if that
> really is important you need to catch these cases too.
I have a TODO comment in net-sysfs.c which is to catch this
Kok, Auke wrote:
Jeff Garzik wrote:
Kok, Auke wrote:
http://foo-projects.org/~sofar/igb.patch [558K]
http://foo-projects.org/~sofar/igb.patch.bz2 [98K]
Just took a look at this.
This has the same problem as in the other thread -- huge internal API
-- except this time, the
Evgeniy Polyakov <[EMAIL PROTECTED]> writes:
> Hi.
>
> On Wed, Jul 18, 2007 at 11:51:03PM -0700, vinay ravuri ([EMAIL PROTECTED])
> wrote:
> > How about the following approach:
> >
> > I allocate an skb of 0 bytes and replace data element
> > of skb struct (i.e. skb.data = addr_given_by_hw) whe
Krishna Kumar wrote:
> diff -ruNp org/net/sched/sch_generic.c new/net/sched/sch_generic.c
> --- org/net/sched/sch_generic.c 2007-07-20 07:49:28.0 +0530
> +++ new/net/sched/sch_generic.c 2007-07-20 08:30:22.0 +0530
> @@ -9,6 +9,11 @@
> * Authors: Alexey Kuznetsov, <[EM
Krishna Kumar wrote:
> Support to turn on/off batching from /sys.
rtnetlink support seems more important than sysfs to me.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-inf
Krishna Kumar wrote:
> @@ -3397,6 +3440,28 @@ int register_netdevice(struct net_device
> }
> }
>
> + if (dev->features & NETIF_F_BATCH_SKBS) {
> + if (!dev->hard_start_xmit_batch ||
> + dev->tx_queue_len < MIN_QUEUE_LEN_BATCH) {
> +
Krishna Kumar wrote:
> diff -ruNp org/include/linux/netdevice.h new/include/linux/netdevice.h
> --- org/include/linux/netdevice.h 2007-07-20 07:49:28.0 +0530
> +++ new/include/linux/netdevice.h 2007-07-20 08:30:55.0 +0530
> @@ -264,6 +264,8 @@ enum netdev_state_t
> __L
Add missing entries to af_family_clock_key_strings[].
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
net/core/sock.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/core/sock.c b/net/core/sock.c
index bd209c4..cfed7d4 100644
--- a/net/core/sock.c
+++ b/net/co
Hi,
Find attached a patch to get IPv6 Unique Local Addresses (FC00::/7)
flagged unicast global in __ipv6_addr_type(), as expected by RFC 4193.
One easy way to see the current difference of handling with a more
common unicast global address is by trying to insert a default route
using a unique lo
Reduced allocation size for rx skb buffers, from 2308 bytes to
1356 per buffer.
Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]>
---
drivers/net/ps3_gelic_net.c | 45
drivers/net/ps3_gelic_net.h | 12 ++-
2 files changed, 44 insertions(+
Fixed rare issue that 'lv1_net_start_rx_dma failed, status=-9" was shown
in dmesg. This meant restarting rx DMA had been rejected by the hypervisor.
This issue would caused if the guest os requested starting DMA when
the hypervisor thought the DMA was in progress.
The state machine for DMA status
void __exit uec_mdio_exit(void) is called from
- static int __init ucc_geth_init(void)
- static void __exit ucc_geth_exit(void)
First one would make error path more than just an error.
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
---
drivers/net/ucc_geth_mii.c |3 ++-
1 file changed, 2
On Fri, 20 Jul 2007 09:19:15 +0200
"Reither Robert" <[EMAIL PROTECTED]> wrote:
>
> Hi Francois ,
>
> i can spare some time now, so i ask:
> Would it help, if i code/send u a tool to simulate your multicast packet
> scenario ?
> Buts its possible for me to reproduce the problem with e.g. nc -u 2
Use net_device name for registration of irq as many network drivers do.
Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]>
---
drivers/net/ps3_gelic_net.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ps3_gelic_net.c
+++ b/drivers/net/ps3_gelic_net.c
@@ -1073,7 +1073
Removed use of netif_poll_enable() in open function.
Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]>
---
drivers/net/ps3_gelic_net.c |1 -
1 file changed, 1 deletion(-)
--- a/drivers/net/ps3_gelic_net.c
+++ b/drivers/net/ps3_gelic_net.c
@@ -1134,7 +1134,6 @@ static int gelic_net_open(stru
Removed the statistics information from private structre.
Instead, use net_device_stats in net_device structure.
Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]>
---
drivers/net/ps3_gelic_net.c | 31 ---
drivers/net/ps3_gelic_net.h |1 -
2 files changed, 8 ins
Removed conditional ethtool support. Always enabled.
Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]>
---
drivers/net/ps3_gelic_net.c |4
drivers/net/ps3_gelic_net.h |2 --
2 files changed, 6 deletions(-)
--- a/drivers/net/ps3_gelic_net.c
+++ b/drivers/net/ps3_gelic_net.c
@@ -116
Removed defines no longer used.
Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]>
---
drivers/net/ps3_gelic_net.h |7 ---
1 file changed, 7 deletions(-)
--- a/drivers/net/ps3_gelic_net.h
+++ b/drivers/net/ps3_gelic_net.h
@@ -28,15 +28,8 @@
#ifndef _GELIC_NET_H
#define _GELIC_NET_H
-
gelic: TX descriptor handling cleanup
- Emitted return value of NETDEV_TX_LOCKED when DMA map or kick
failure.
Now it would free the skb, update drop packet statistics
and return OK. Requested from Jeff Garzik.
- Enable tx queue if number of free desc
- Removed the embarrassing definition which was used in only one
place.
- Fixed wrong initialization of dmac_cmd_status.
Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]>
---
drivers/net/ps3_gelic_net.c |5 +++--
drivers/net/ps3_gelic_net.h |1 -
2 files changed, 3 insertions(+), 3 d
Fixed the bug that calculation of the address of rx descriptor was
wrong.
Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]>
---
drivers/net/ps3_gelic_net.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ps3_gelic_net.c
+++ b/drivers/net/ps3_gelic_net.c
@@ -1107,7 +11
Am Freitag, 20. Juli 2007 09:33 schrieben Sie:
> Well, these useless abstractions are really annoying and nothing we allow
> into other drivers either.
However, they make it easier for multiple developers to work as a team. This
is useful for development pace and makes maintainance less dependan
IPoIB verb changes to support batching.
Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>
---
ipoib_verbs.c | 23 ++-
1 files changed, 14 insertions(+), 9 deletions(-)
diff -ruNp org/drivers/infiniband/ulp/ipoib/ipoib_verbs.c
new/drivers/infiniband/ulp/ipoib/ipoib_verbs.c
-
Michael Neuling wrote:
From ehea_start_xmit in ehea_main.c we have:
if (unlikely(atomic_read(&pr->swqe_avail) <= 1)) {
spin_lock_irqsave(&pr->netif_queue, flags);
if (unlikely(atomic_read(&pr->swqe_avail) <= 1)) {
pr->p_stats.queue_stopped++;
Changes in dev.c to support batching : add dev_add_skb_to_blist,
register_netdev recognizes batch aware drivers, and net_tx_action is
the sole user of batching.
Signed-off-by: Krishna Kumar <[EMAIL PROTECTED]>
---
dev.c | 77 +++---
1
This patchset are fixes and updates incorporating the comments from Jeff
Garzik and Stephen Hemminger.
Please accept the following patches for the ps3_gelic driver. Thanks.
[1] ps3: fix wrong calculation of rx descriptor address
[2] ps3: some minor cleanups
[3] ps3: tx descriptor handling clea
Stephen Hemminger <[EMAIL PROTECTED]> wrote on 07/20/2007
12:48:48 PM:
> You may see worse performance with batching in the real world when
> running over WAN's. Like TSO, batching will generate back to back packet
> trains that are subject to multi-packet synchronized loss. The problem is
that
>
On Fri, 20 Jul 2007 13:00:25 +0530
Krishna Kumar2 <[EMAIL PROTECTED]> wrote:
> Stephen Hemminger <[EMAIL PROTECTED]> wrote on 07/20/2007
> 12:48:48 PM:
>
> > You may see worse performance with batching in the real world when
> > running over WAN's. Like TSO, batching will generate back to back p
On Fri, 20 Jul 2007 11:50:39 +0400 Vitaly Bordug <[EMAIL PROTECTED]> wrote:
> On Thu, 19 Jul 2007 23:23:37 -0700
> Andrew Morton wrote:
>
> > On Thu, 19 Jul 2007 03:38:04 +0400 Vitaly Bordug
> > <[EMAIL PROTECTED]> wrote:
> >
> > >
> > > device_bind_driver() error code returning has been fixed.
On Thu, 19 Jul 2007 23:23:37 -0700
Andrew Morton wrote:
> On Thu, 19 Jul 2007 03:38:04 +0400 Vitaly Bordug
> <[EMAIL PROTECTED]> wrote:
>
> >
> > device_bind_driver() error code returning has been fixed.
> > release() function has been written, so that to free resources
> > in correct way; th
Stephen Hemminger <[EMAIL PROTECTED]> wrote on 07/20/2007
12:48:48 PM:
> You may see worse performance with batching in the real world when
> running over WAN's. Like TSO, batching will generate back to back packet
> trains that are subject to multi-packet synchronized loss. The problem is
that
>
On Thu, Jul 19, 2007 at 04:52:02PM -0700, Kok, Auke wrote:
> Why don't you accept it now and allow us the time to work on this in the
> coming period? The driver works, performs better than all 8257x hardware
> and uses less CPU utilization. That must be good for everyone. Keeping it
> outside o
Attached file contains scripts for running tests and parsing results :
(See attached file: scripts.tar)
The result of a 10 run (average) TCP iperf (and 1 netperf for UDP) is
given below.
Thanks,
- KK
-
Test configurat
On Fri, 20 Jul 2007 12:01:49 +0530
Krishna Kumar <[EMAIL PROTECTED]> wrote:
> Hi Dave, Roland, everyone,
>
> In May, I had proposed creating an API for sending 'n' skbs to a driver to
> reduce lock overhead, DMA operations, and specific to drivers that have
> completion notification like IPoIB -
Hi Francois ,
i can spare some time now, so i ask:
Would it help, if i code/send u a tool to simulate your multicast packet
scenario ?
Buts its possible for me to reproduce the problem with e.g. nc -u 224.1.1.1
10500 http://www.av-digital.at>
-
To unsubscribe from this list: send the line "un
98 matches
Mail list logo
