Re: Socket Buffers and Memory Managment

2007-07-18 Thread vinay ravuri
How about the following approach: I allocate an skb of 0 bytes and replace data element of skb struct (i.e. skb.data = addr_given_by_hw) when the h/w interrupts me with a packet. I register for a destructor for this skb and when the kernel is ready to free the skb, I make sure that my free is inv

Re: ~3 hours old git tree: Virtual device lo asks to queue packet!

2007-07-18 Thread Arkadiusz Miskiewicz
On Thursday 19 of July 2007, Patrick McHardy wrote: > Arkadiusz Miskiewicz wrote: > > I'm having problems with networking on recent git kernel. > > > > kernel logs tons of "Virtual device lo asks to queue packet!" > > and networking stops working correctly: > > > > CONFIG_NETDEVICES_MULTIQUEUE=y >

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-07-18 Thread Adrian Bunk
On Wed, Jul 18, 2007 at 05:18:20PM -0400, Robert P. J. Day wrote: > On Wed, 18 Jul 2007, Adrian Bunk wrote: > > > On Wed, Jul 18, 2007 at 04:51:33PM -0400, Robert P. J. Day wrote: > > > On Wed, 18 Jul 2007, Jeff Garzik wrote: > > > > > > > Randy Dunlap wrote: > > > > > On Wed, 18 Jul 2007 16:23:09

[PATCH] Merge GT/MV642xx Support into MV643xx Driver [2/8]

2007-07-18 Thread Steven J. Hill
Add #defines for RGMII Discovery II/III in 'include/linux/mv643xx.h' file. Signed-off-by: Steven J. Hill <[EMAIL PROTECTED]> --- --- linux-2.6.22.1/include/linux/mv643xx.h 2007-05-10 15:16:24.0 -0500 +++ linux-2.6.22.1-rci/include/linux/mv643xx.h 2007-07-18 15:50:44.0 -0500 @@ -124

[PATCH] Merge GT/MV642xx Support into MV643xx Driver [1/8]

2007-07-18 Thread Steven J. Hill
This first patch 642xx #defines to the 'include/linux/mv643xx.h' file. Signed-off-by: Steven J. Hill <[EMAIL PROTECTED]> --- --- linux-2.6.22.1/include/linux/mv643xx.h 2007-05-10 15:16:24.0 -0500 +++ linux-2.6.22.1-rci/include/linux/mv643xx.h 2007-07-18 15:50:44.0 -0500 @@ -666,7

[PATCH] Merge GT/MV642xx Support into MV643xx Driver [3/8]

2007-07-18 Thread Steven J. Hill
Add 642xx support to 'drivers/net/mv643xx_eth.h' Signed-off-by: Steven J. Hill <[EMAIL PROTECTED]> --- --- linux-2.6.22.1/drivers/net/mv643xx_eth.h 2007-07-11 08:53:06.0 -0500 +++ linux-2.6.22.1-rci/drivers/net/mv643xx_eth.h 2007-07-11 09:28:16.0 -0500 @@ -14,8 +14,13 @@ /* Checks

[PATCH] Merge GT/MV642xx Support into MV643xx Driver [8/8]

2007-07-18 Thread Steven J. Hill
Fix long standing panic with regards to descriptors and locking. Signed-off-by: Steven J. Hill <[EMAIL PROTECTED]> --- diff -ur linux-2.6.22.1/drivers/net/mv643xx_eth.c linux-2.6.22.1-rci/drivers/net/mv643xx_eth.c --- linux-2.6.22.1/drivers/net/mv643xx_eth.c 2007-07-18 22:55:11.0 -0500 +++

[PATCH] Merge GT/MV642xx Support into MV643xx Driver [7/8]

2007-07-18 Thread Steven J. Hill
Get rid of global PHY spinlock. Signed-off-by: Steven J. Hill <[EMAIL PROTECTED]> --- diff -ur linux-2.6.22.1/drivers/net/mv643xx_eth.c linux-2.6.22.1-rci/drivers/net/mv643xx_eth.c --- linux-2.6.22.1/drivers/net/mv643xx_eth.c 2007-07-18 22:51:54.0 -0500 +++ linux-2.6.22.1-rci/drivers/net/m

[PATCH] Merge GT/MV642xx Support into MV643xx Driver [6/8]

2007-07-18 Thread Steven J. Hill
Fix the TX bytes statistics counter to, um, actually count. Signed-off-by: Steven J. Hill <[EMAIL PROTECTED]> --- --- linux-2.6.22.1/drivers/net/mv643xx_eth.c 2007-07-18 21:51:49.0 -0500 +++ linux-2.6.22.1-rci/drivers/net/mv643xx_eth.c 2007-07-18 21:44:07.0 -0500 @@ -1506,7 +1511,7

[PATCH] Merge GT/MV642xx Support into MV643xx Driver [5/8]

2007-07-18 Thread Steven J. Hill
Fix 'mv643xx_eth_tx_timeout_task' function prototype. Signed-off-by: Steven J. Hill <[EMAIL PROTECTED]> --- --- linux-2.6.22.1/drivers/net/mv643xx_eth.c 2007-07-18 21:45:13.0 -0500 +++ linux-2.6.22.1-rci/drivers/net/mv643xx_eth.c 2007-07-18 21:44:07.0 -0500 @@ -317,11 +315,9 @@ *

[PATCH] Merge GT/MV642xx Support into MV643xx Driver [4/8]

2007-07-18 Thread Steven J. Hill
Add main 642xx support to 'drivers/net/mv643xx_eth.c' file. Signed-off-by: Steven J. Hill <[EMAIL PROTECTED]> --- --- linux-2.6.22.1/drivers/net/mv643xx_eth.c 2007-07-18 22:19:31.0 -0500 +++ linux-2.6.22.1-rci/drivers/net/mv643xx_eth.c 2007-07-18 22:22:04.0 -0500 @@ -13,8 +13,7 @@

Re: [TG3]: Fix msi issue with kexec/kdump.

2007-07-18 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Wed, 18 Jul 2007 20:40:47 -0700 > [TG3]: Fix msi issue with kexec/kdump. > > Tina Yang <[EMAIL PROTECTED]> discovered an MSI related problem > when doing kdump. The problem is that the kexec kernel is booted > without going through system reset, and

Re: [GIT PULL] [NET]: Whitespace fixes

2007-07-18 Thread David Miller
From: YOSHIFUJI Hideaki / 吉藤英明 <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 11:21:33 +0900 (JST) > Please consider pulling the following commits from > net-2.6-20070719-whitespace-20070719 > branch at > . Pulled, thanks a lot. - To unsubscribe from this list: send the line "unsubscribe

Re: Realtek RTL8111B serious performance issues

2007-07-18 Thread Bill Fink
Hi John, On Wed, 18 Jul 2007, [EMAIL PROTECTED] wrote: > On Wed, 18 Jul 2007, Francois Romieu wrote: > > > [EMAIL PROTECTED] <[EMAIL PROTECTED]> : > > [...] > >> Anyone have any suggestions for solving this problem? > > > > Try 2.6.23-rc1 when it is published or apply against 2.6.22 one of: > >

[PATCH 2/2] ucc_geth: add support to netif message level

2007-07-18 Thread Li Yang
Adds netif message level control to the ucc_geth driver. The level can be set by module parameter and ethtool. Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c | 315 +--- 1 files changed, 190 insertions(+), 125 deletions(-) diff

[PATCH 1/2] ucc_geth: add ethtool support

2007-07-18 Thread Li Yang
The patch enables statistics in ucc_geth and adds ethtool support to ucc_geth driver. Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- drivers/net/Makefile |2 +- drivers/net/ucc_geth.c | 19 +- drivers/net/ucc_geth.h |6 + drivers/net/ucc_geth_ethtool.c | 388 +

Re: ANNOUNCE: igb: Intel 82575 Gigabit Ethernet driver (PCI-Express)

2007-07-18 Thread Jeff Garzik
Kok, Auke wrote: All, We are pleased to announce a new Gigabit Ethernet product and its driver to the linux community. This product is the Intel(R) 82575 Gigabit Ethernet adapter family. Physical adapters will be available to the public soon. These adapters come in 2- and 4-port versions (c

[TG3]: Fix msi issue with kexec/kdump.

2007-07-18 Thread Michael Chan
[TG3]: Fix msi issue with kexec/kdump. Tina Yang <[EMAIL PROTECTED]> discovered an MSI related problem when doing kdump. The problem is that the kexec kernel is booted without going through system reset, and as a result, MSI may already be enabled when tg3_init_one() is called. tg3_init_one() ca

[GIT PULL] [NET]: Whitespace fixes

2007-07-18 Thread YOSHIFUJI Hideaki / 吉藤英明
Dave, Please consider pulling the following commits from net-2.6-20070719-whitespace-20070719 branch at . Thanks. HEADLINES - [NET] AX25: Fix whitespace errors. [NET] BLUETOOTH: Fix whitespace errors. [NET] CORE: Fix whitespace errors. [NET] DCCP: Fix whi

Re: Please pull 'upstream-davem' branch of wireless-2.6

2007-07-18 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Wed, 18 Jul 2007 20:45:10 -0400 > On Wed, Jul 18, 2007 at 03:32:48PM -0700, David Miller wrote: > > From: "John W. Linville" <[EMAIL PROTECTED]> > > Date: Wed, 18 Jul 2007 11:34:49 -0400 > > > > > On Tue, Jul 17, 2007 at 08:17:16PM -0700, David M

Re: [PATCH 2.6.22-git5] via-rhine: Disable rx_copybreak on archs that don't allow unaligned DMA access

2007-07-18 Thread Andrew Morton
(mailing lsits and cc's added - I trust that's OK) (Please always cc mailing list(s) on patches) On Sat, 14 Jul 2007 14:10:52 -0500 Dustin Marquess <[EMAIL PROTECTED]> wrote: > From: Dustin Marquess <[EMAIL PROTECTED]> > > Patch to disable the rx_copybreak feature on hardware architectures tha

Re: Please pull 'upstream-davem' branch of wireless-2.6

2007-07-18 Thread John W. Linville
On Wed, Jul 18, 2007 at 03:32:48PM -0700, David Miller wrote: > From: "John W. Linville" <[EMAIL PROTECTED]> > Date: Wed, 18 Jul 2007 11:34:49 -0400 > > > On Tue, Jul 17, 2007 at 08:17:16PM -0700, David Miller wrote: > > > From: "John W. Linville" <[EMAIL PROTECTED]> > > > Date: Tue, 17 Jul 2007 2

Re: Linux, tcpdump and vlan

2007-07-18 Thread Patrick McHardy
Ben Greear wrote: > Patrick McHardy wrote: > >> Its actually more a problem on the RX path. VLAN acceleration >> works (at least with some drivers) by enabling HW header striping >> and using the VLAN ID for an immediate lookup in the VLAN devices >> configured on that device. So if the VLAN is no

[git patches] net driver updates

2007-07-18 Thread Jeff Garzik
Nothing highly notable. Wireless pull, and new blackfin eth driver (didn't get merged with rest of blackfin, since additional review was requested). Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the foll

Re: Linux, tcpdump and vlan

2007-07-18 Thread Ben Greear
Patrick McHardy wrote: Ben Greear wrote: Patrick McHardy wrote: Put another way, once you enable VLAN header stripping, you won't see the headers for *any* VLAN, not only for those you're actually running locally. This is also a problem for devices like macvlan, where it would be desir

[PATCH] tg3: add PCI error recovery support

2007-07-18 Thread Linas Vepstas
Add support for PCI Error Recovery for the tg3 ethernet device driver. The general principles of operation are described in Documentation/pci-error-recovery.txt Other drivers having similar structure include e100, e1000, ixgb, s2io, ipr, sym53c8xx_2, and lpfc Signed-off-by: Linas Vepstas <[EMAIL

RE: Question: how to detect if a qdisc is root or not?

2007-07-18 Thread Waskiewicz Jr, Peter P
> Its set after grafting the parent, which is after initialization. > I think what should work is to set it in qdisc_create > instead, sch_api.c around line 490: > > + sch->parent = handle; > > if (handle == TC_H_INGRESS) { > sch->flags |= TCQ_F_INGRESS; >

Re: Question: how to detect if a qdisc is root or not?

2007-07-18 Thread Patrick McHardy
Waskiewicz Jr, Peter P wrote: >>You're right, thats a bug. TC_H_ROOT is the parent ID, which >>is stored in sch->parent. IIRC its also passed to the >>->init() function. > > > Unfortunately it's not passed. It is passed into the ->change() > function: > > static int prio_init(struct Qdisc *sc

[PATCH] [updated] PHY fixed driver: rework release path and update phy_id notation

2007-07-18 Thread Vitaly Bordug
device_bind_driver() error code returning has been fixed. release() function has been written, so that to free resources in correct way; the release path is now clean. Before the rework, it used to cause Device '[EMAIL PROTECTED]:1' does not have a release() function, it is broken and mu

Re: Linux, tcpdump and vlan

2007-07-18 Thread Patrick McHardy
Ben Greear wrote: > Patrick McHardy wrote: > >> Put another way, once you enable VLAN header stripping, you >> won't see the headers for *any* VLAN, not only for those you're >> actually running locally. This is also a problem for devices >> like macvlan, where it would be desirable to make use of

RE: Question: how to detect if a qdisc is root or not?

2007-07-18 Thread Waskiewicz Jr, Peter P
> You're right, thats a bug. TC_H_ROOT is the parent ID, which > is stored in sch->parent. IIRC its also passed to the > ->init() function. Unfortunately it's not passed. It is passed into the ->change() function: static int prio_init(struct Qdisc *sch, struct rtattr *opt) static int prio_ch

Re: Question: how to detect if a qdisc is root or not?

2007-07-18 Thread Patrick McHardy
Waskiewicz Jr, Peter P wrote: > I've been tracking down an issue with the recent multiqueue code, > specifically with sch_prio and sch_rr loading as a root qdisc. Right > now, we do not want to allow child qdiscs of sch_rr and sch_prio to load > with multiqueue enabled; we want to restrict multiqu

Re: Linux, tcpdump and vlan

2007-07-18 Thread Ben Greear
Patrick McHardy wrote: andrei radulescu-banu wrote: [...] In conclusion, here is the buglist: 1). If set promiscuous, the e1000 should disable any vlan rx filtering, so that it can receive vlan frames of other vlan id's. Other ethernet drivers probably need fixed as well. 2). The packet

Re: [PATCH] pktgen - define and use pktgen_dbg,err,warn,info

2007-07-18 Thread Joe Perches
On Wed, 2007-07-18 at 15:49 -0700, David Miller wrote: > From: Joe Perches <[EMAIL PROTECTED]> > Date: Wed, 18 Jul 2007 15:14:13 -0700 > > > -#define VERSION "pktgen v2.68: Packet Generator for packet performance > > testing.\n" > > +#define PKTGEN_NAME"pktgen" > > +#define PKTGEN_VERSION "v

Question: how to detect if a qdisc is root or not?

2007-07-18 Thread Waskiewicz Jr, Peter P
I've been tracking down an issue with the recent multiqueue code, specifically with sch_prio and sch_rr loading as a root qdisc. Right now, we do not want to allow child qdiscs of sch_rr and sch_prio to load with multiqueue enabled; we want to restrict multiqueue-enabled qdiscs to the root qdisc (

Re: ~3 hours old git tree: Virtual device lo asks to queue packet!

2007-07-18 Thread Patrick McHardy
Arkadiusz Miskiewicz wrote: > I'm having problems with networking on recent git kernel. > > kernel logs tons of "Virtual device lo asks to queue packet!" > and networking stops working correctly: > > CONFIG_NETDEVICES_MULTIQUEUE=y Does it go away if you disable this option? - To unsubscribe from

Re: updated tcatm patches for kernel/iproute 2.6.22

2007-07-18 Thread Patrick McHardy
Sami Farin wrote: > I had used tcatm patch with 2.6.16 kernel and I was > happy with it. > Now I patched Linux kernel 2.6.22 and iproute-2.6.22 > for tcatm. Seems to work (TM). Only HTB tested. Let me repeat again before we get in an endless discussion again - I will NACK these patches until we

Re: Linux, tcpdump and vlan

2007-07-18 Thread Patrick McHardy
andrei radulescu-banu wrote: > [...] > > In conclusion, here is the buglist: > 1). If set promiscuous, the e1000 should disable any vlan rx filtering, so > that it can receive vlan frames of other vlan id's. Other ethernet drivers > probably need fixed as well. > 2). The packet layer should

Re: [PATCH] pktgen - define and use pktgen_dbg,err,warn,info

2007-07-18 Thread David Miller
From: Joe Perches <[EMAIL PROTECTED]> Date: Wed, 18 Jul 2007 15:14:13 -0700 > -#define VERSION "pktgen v2.68: Packet Generator for packet performance > testing.\n" > +#define PKTGEN_NAME"pktgen" > +#define PKTGEN_VERSION "v2.68" > +#define PKTGEN_DESC"Packet Generator for packet performa

Re: Linux 2.6.22: Leak r=1 1

2007-07-18 Thread Sami Farin
On Wed, Jul 18, 2007 at 12:16:56 +0300, Ilpo Järvinen wrote: > On Wed, 11 Jul 2007, Sami Farin wrote: > > > That's right, so descriptive is the new Linux kernel 2.6.22. > > > > Linux safari.finland.fbi 2.6.22-cfs-v19 #3 SMP Tue Jul 10 00:22:25 EEST > > 2007 i686 i686 i386 GNU/Linux > > > > [EMA

Re: [PATCH try#6] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-07-18 Thread Jeff Garzik
Bryan Wu wrote: This patch implements the driver necessary use the Analog Devices Blackfin processor's on-chip ethernet MAC controller. [try#2] - add timeout control - kill dma_config_reg bitfields - some trivial cleanup [try#3] - add endianess check - add DRV_NAME, DRV_VERSION... driver i

Re: [PATCH] eHEA: Fix bonding support

2007-07-18 Thread Jeff Garzik
Thomas Klein wrote: The driver didn't allow an interface's MAC address to be modified if the respective interface wasn't setup - a failing Hcall was the result. Thus bonding wasn't usable. The fix moves the failing Hcall which was registering a MAC address for the reception of BC packets in firmw

Re: updated tcatm patches for kernel/iproute 2.6.22

2007-07-18 Thread Stephen Hemminger
On Thu, 19 Jul 2007 00:06:38 +0300 Sami Farin <[EMAIL PROTECTED]> wrote: > I got tired of getting 15% packet loss [1] when doing > lots of DNS lookups on my ADSL link... > And that was even when limiting outgoing DNS traffic > to 200 Kbit/s (ADSL modem upstream speed is 512 Kbit/s). > > I had use

Re: [PATCH] fix wrong argument of tc35815_read_plat_dev_addr()

2007-07-18 Thread Jeff Garzik
Yoichi Yuasa wrote: Fix wrong argument of tc35815_read_plat_dev_addr() Signed-off-by: Yoichi Yuasa <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majo

Re: [PATCH] rfkill: Make state sysfs writable

2007-07-18 Thread David Miller
From: Ivo van Doorn <[EMAIL PROTECTED]> Date: Wed, 18 Jul 2007 19:59:22 +0200 > The rfkill state Sysfs attribute should be made writable, > we already pass the argument for the store handler, > so we only need to update the permissions flag. > > Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> A

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

2007-07-18 Thread Jeff Garzik
Where is the hard_start_xmit/TX-completion locking? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] PHY fixed driver: rework release path and update phy_id notation

2007-07-18 Thread Jeff Garzik
Vitaly Bordug wrote: device_bind_driver() error code returning has been fixed. release() function has been written, so that to free resources in correct way; the release path is now clean. Before the rework, it used to cause Device '[EMAIL PROTECTED]:1' does not have a release() function,

Re: [PATCH 4/4] ibmveth: Add ethtool driver stats hooks

2007-07-18 Thread Jeff Garzik
Brian King wrote: Add ethtool hooks to ibmveth to retrieve driver statistics. ACK patches 3-4 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] pktgen - define and use pktgen_dbg,err,warn,info

2007-07-18 Thread Joe Perches
Similar usage to ndev_ and dev_ printk macros Adds KERN_ indicators to all printks. Correct a spelling error Format u64 subtraction to %llu and (unsigned long long) Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/net/core/pktgen.c b/net/core/pktgen.c index b92a322..5a94cfc 100644 ---

Re: [PATCH 2/4] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-07-18 Thread Jeff Garzik
Brian King wrote: This patch adds the appropriate ethtool hooks to allow for enabling/disabling of hypervisor assisted checksum offload for TCP. Signed-off-by: Brian King <[EMAIL PROTECTED]> --- linux-2.6-bjking1/drivers/net/ibmveth.c | 120 +++- linux-2.6-bjking1/

Re: [PATCH v2 1/3] netlink: allocate group bitmaps dynamically

2007-07-18 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 18 Jul 2007 18:30:04 +0200 > Johannes Berg wrote: > > Allow changing the number of groups for a netlink family > > after it has been created, use RCU to protect the listeners > > bitmap keeping netlink_has_listeners() lock-free. > > > > Signed-

Re: Please pull 'upstream-davem' branch of wireless-2.6

2007-07-18 Thread David Miller
From: "John W. Linville" <[EMAIL PROTECTED]> Date: Wed, 18 Jul 2007 11:34:49 -0400 > On Tue, Jul 17, 2007 at 08:17:16PM -0700, David Miller wrote: > > From: "John W. Linville" <[EMAIL PROTECTED]> > > Date: Tue, 17 Jul 2007 22:16:07 -0400 > > > > > A few more for 2.6.23...individual patches availa

Re: [PATCH 1/4] ibmveth: Enable TCP checksum offload

2007-07-18 Thread Jeff Garzik
Brian King wrote: This patchset enables TCP checksum offload support for IPV4 on ibmveth. This completely eliminates the generation and checking of the checksum for packets that are completely virtual and never touch a physical network. A simple TCP_STREAM netperf run on a virtual network with ma

Re: Please pull 'upstream-jgarzik' branch of wireless-2.6

2007-07-18 Thread Jeff Garzik
John W. Linville wrote: A few more for 2.6.23... Thanks! John --- The following changes since commit 4ad1366376bfef32ec0ffa12d1faa483d6f330bd: NeilBrown (1): md: change bitmap_unplug and others to void functions are available in the git repository at: git://git.kernel.org/pub/sc

Re: [PATCH v2] mac80211: fix GCC warning on 64bit platforms

2007-07-18 Thread David Miller
From: Jiri Benc <[EMAIL PROTECTED]> Date: Wed, 18 Jul 2007 17:10:44 +0200 > - local->tx_headroom = max(local->hw.extra_tx_headroom, > - sizeof(struct ieee80211_tx_status_rtap_hdr)); > + local->tx_headroom = max_t(unsigned, local->hw.extra_tx_headroom, > +

Re: [PATCH v2 2/3] netlink: allow removing multicast groups

2007-07-18 Thread David Miller
Please don't resubmit sub-patches, I delete entire patch series from my inbox when some of them need revisions. Please resubmit the whole set once everything is worked out. Thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] M

Re: [RFC 0/3] lro: Generic Large Receive Offload for TCP traffic (IPv6)

2007-07-18 Thread David Miller
From: Jan-Bernd Themann <[EMAIL PROTECTED]> Date: Wed, 18 Jul 2007 15:00:59 +0200 > Hi, > > I suggest we keep the interface open for IPv6 support by adding > an additional parameter but first just get IPv4 support only > into the kernel. IPv6 support can then incrementially be added. > Would th

Re: [PATCH] Add a network activity LED trigger

2007-07-18 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 18 Jul 2007 15:54:56 +0200 > Florian Fainelli wrote: > >> Besides missing a declaration and not linking without the network > >> LED config option, its pretty ridiculous to call this for every > >> packet just to make a led blink. > >> > >

updated tcatm patches for kernel/iproute 2.6.22

2007-07-18 Thread Sami Farin
I got tired of getting 15% packet loss [1] when doing lots of DNS lookups on my ADSL link... And that was even when limiting outgoing DNS traffic to 200 Kbit/s (ADSL modem upstream speed is 512 Kbit/s). I had used tcatm patch with 2.6.16 kernel and I was happy with it. Now I patched Linux kernel 2

Re: Realtek RTL8111B serious performance issues

2007-07-18 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : [...] > Unfortunately, the 20070628 patch did not make any difference. @!#$ [...] > >http://www.fr.zoreil.com/linux/kernel/2.6.x/2.6.22-rc6/r8169-20070628/ > > I tried various patches from that directory (aren't most or all of them > included in the 200706

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-07-18 Thread Robert P. J. Day
On Wed, 18 Jul 2007, Adrian Bunk wrote: > If you are not doing it, noone might do it. And discusing > improvements noone will implement is somehow pointless... sure, i'm willing to help, but i don't think doing *nothing* about it is an option. you may not like gabriel's proposed patch, but you h

Re: Realtek RTL8111B serious performance issues

2007-07-18 Thread john
On Wed, 18 Jul 2007, Francois Romieu wrote: [EMAIL PROTECTED] <[EMAIL PROTECTED]> : [...] Anyone have any suggestions for solving this problem? Try 2.6.23-rc1 when it is published or apply against 2.6.22 one of: http://www.fr.zoreil.com/people/francois/misc/20070628-2.6.22-rc6-r8169-test.pat

Re: Socket Buffers and Memory Managment

2007-07-18 Thread Stephen Hemminger
On Wed, 18 Jul 2007 13:13:21 -0400 Roy Pledge <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > > > You could play tricks with skb frags but it would be fragile > > and not worth the trouble. The problem is that the receive > > skb can stay in the system for a really long time (until the

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-07-18 Thread Robert P. J. Day
On Wed, 18 Jul 2007, Adrian Bunk wrote: > On Wed, Jul 18, 2007 at 04:51:33PM -0400, Robert P. J. Day wrote: > > On Wed, 18 Jul 2007, Jeff Garzik wrote: > > > > > Randy Dunlap wrote: > > > > On Wed, 18 Jul 2007 16:23:09 -0400 (EDT) Robert P. J. Day wrote: > > > > > there's no point adding all that

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-07-18 Thread Adrian Bunk
On Wed, Jul 18, 2007 at 04:51:33PM -0400, Robert P. J. Day wrote: > On Wed, 18 Jul 2007, Jeff Garzik wrote: > > > Randy Dunlap wrote: > > > On Wed, 18 Jul 2007 16:23:09 -0400 (EDT) Robert P. J. Day wrote: > > > > there's no point adding all that redundant content when it can all be > > > > done au

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-07-18 Thread Robert P. J. Day
On Wed, 18 Jul 2007, Jeff Garzik wrote: > Randy Dunlap wrote: > > On Wed, 18 Jul 2007 16:23:09 -0400 (EDT) Robert P. J. Day wrote: > > > there's no point adding all that redundant content when it can all be > > > done automatically. > > > > I like it. Are there any kconfig patches to support this

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-07-18 Thread Randy Dunlap
Jeff Garzik wrote: Randy Dunlap wrote: On Wed, 18 Jul 2007 16:23:09 -0400 (EDT) Robert P. J. Day wrote: there's no point adding all that redundant content when it can all be done automatically. I like it. Are there any kconfig patches to support this plan? Speaking specifically to adding

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-07-18 Thread Gabriel C
Robert P. J. Day wrote: > On Wed, 18 Jul 2007, Gabriel C wrote: > >> Everything 'depends on' EXPERIMENTAL should be marked as such, >> visible in the menus. > > rather than add all that extraneous dreck to the Kconfig files, i > *really* wish folks would give serious thought to my earlier > sugge

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-07-18 Thread Robert P. J. Day
On Wed, 18 Jul 2007, Randy Dunlap wrote: > On Wed, 18 Jul 2007 16:23:09 -0400 (EDT) Robert P. J. Day wrote: > > > On Wed, 18 Jul 2007, Gabriel C wrote: > > > > > Everything 'depends on' EXPERIMENTAL should be marked as such, > > > visible in the menus. > > > > rather than add all that extraneous d

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-07-18 Thread Jeff Garzik
Randy Dunlap wrote: On Wed, 18 Jul 2007 16:23:09 -0400 (EDT) Robert P. J. Day wrote: there's no point adding all that redundant content when it can all be done automatically. I like it. Are there any kconfig patches to support this plan? Speaking specifically to adding 'EXPERIMENTAL', I di

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-07-18 Thread Randy Dunlap
On Wed, 18 Jul 2007 16:23:09 -0400 (EDT) Robert P. J. Day wrote: > On Wed, 18 Jul 2007, Gabriel C wrote: > > > Everything 'depends on' EXPERIMENTAL should be marked as such, > > visible in the menus. > > rather than add all that extraneous dreck to the Kconfig files, i > *really* wish folks woul

[PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-07-18 Thread Gabriel C
Everything 'depends on' EXPERIMENTAL should be marked as such, visible in the menus. Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]> --- drivers/net/irda/Kconfig | 14 +++--- drivers/net/usb/Kconfig |4 ++-- drivers/net/wireless/Kconfig

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-07-18 Thread Robert P. J. Day
On Wed, 18 Jul 2007, Gabriel C wrote: > Everything 'depends on' EXPERIMENTAL should be marked as such, > visible in the menus. rather than add all that extraneous dreck to the Kconfig files, i *really* wish folks would give serious thought to my earlier suggestion about a "maturity level" attribu

Re: Stalled connection (need help to debug)

2007-07-18 Thread Oleg Verych
> Hallo. > > I have a very strange problem. [] > Any advise on how to debug this will be very appreciated. Thanks. Thanks... - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majord

Re: [PATCH 1/2] Fix error checking in Vitesse IRQ config

2007-07-18 Thread Andy Fleming
On Jul 18, 2007, at 02:00, pradeep singh wrote: On 7/18/07, Andy Fleming <[EMAIL PROTECTED]> wrote: - if (err) + if (err < 0) return err; but would that mean, if phy_read returns > 0 it is a success? Yes. phy_read() returns a 32-bit va

Re: pmtu discovery on SA

2007-07-18 Thread Mika Penttilä
Patrick McHardy wrote: Mika Penttilä wrote: Hmm. esp4_err() looks like this : struct iphdr *iph = (struct iphdr*)skb->data; struct ip_esp_hdr *esph = (struct ip_esp_hdr*)(skb->data+(iph->ihl<<2)); struct xfrm_state *x; if (icmp_hdr(skb)->type != ICMP_DEST_UNREACH || icmp_h

Re: pmtu discovery on SA

2007-07-18 Thread Patrick McHardy
Mika Penttilä wrote: Hmm. esp4_err() looks like this : struct iphdr *iph = (struct iphdr*)skb->data; struct ip_esp_hdr *esph = (struct ip_esp_hdr*)(skb->data+(iph->ihl<<2)); struct xfrm_state *x; if (icmp_hdr(skb)->type != ICMP_DEST_UNREACH || icmp_hdr(skb)->code != ICMP_FR

Re: pmtu discovery on SA

2007-07-18 Thread Mika Penttilä
Patrick McHardy wrote: Mika Penttilä wrote: Patrick McHardy wrote: Its a debugging message nowadays (NETDEBUG). I was mostly interested in this since I changed the IPsec MTU calculation in 2.6.22 and it might have been a bug. And we don't have pmtu discovery for esp yet, ri

Re: pmtu discovery on SA

2007-07-18 Thread Patrick McHardy
Mika Penttilä wrote: > Patrick McHardy wrote: > >> Its a debugging message nowadays (NETDEBUG). I was mostly interested >> in this since I changed the IPsec MTU calculation in 2.6.22 and it >> might have been a bug. >> >> > > And we don't have pmtu discovery for esp yet, right? We do. The be

Re: pmtu discovery on SA

2007-07-18 Thread Mika Penttilä
Patrick McHardy wrote: Beschorner Daniel wrote: Beschorner Daniel wrote: So its using 1492 now? Otherwise it would be expected since the initial MTU calculation would be based on 1500. I'm using 1500 again. Just to make it clear: Is this message an error, or a warning or just for in

[PATCH] rfkill: Make state sysfs writable

2007-07-18 Thread Ivo van Doorn
The rfkill state Sysfs attribute should be made writable, we already pass the argument for the store handler, so we only need to update the permissions flag. Signed-off-by: Ivo van Doorn <[EMAIL PROTECTED]> --- diff --git a/net/rfkill/rfkill.c b/net/rfkill/rfkill.c index f3986d4..db3395b 100644

Re: Socket Buffers and Memory Managment

2007-07-18 Thread Roy Pledge
Stephen Hemminger wrote: You could play tricks with skb frags but it would be fragile and not worth the trouble. The problem is that the receive skb can stay in the system for a really long time (until the application reads the data) so your fixed size buffer pool in hardware would get exhausted

Re: [Bugme-new] [Bug 8778] New: Ocotea board: kernel reports access of bad area during boot with DEBUG_SLAB=y

2007-07-18 Thread Eugene Surovegin
On Wed, Jul 18, 2007 at 09:55:37AM -0700, Andrew Morton wrote: > On Wed, 18 Jul 2007 08:59:40 -0700 Eugene Surovegin <[EMAIL PROTECTED]> wrote: > > > On Wed, Jul 18, 2007 at 08:41:10AM -0500, Josh Boyer wrote: > > > On Wed, 2007-07-18 at 01:34 -0700, Eugene Surovegin wrote: > > > > On Wed, Jul 18,

Re: [PATCH v2] mac80211: fix GCC warning on 64bit platforms

2007-07-18 Thread Johannes Berg
On Wed, 2007-07-18 at 17:10 +0200, Jiri Benc wrote: > net/mac80211/ieee80211.c: In function ieee80211_register_hw: > net/mac80211/ieee80211.c:4989: warning: comparison of distinct pointer types > lacks a cast > > Size of ieee80211_tx_status_rtap_hdr structure will never be greater than > unsigned

Re: [Bugme-new] [Bug 8778] New: Ocotea board: kernel reports access of bad area during boot with DEBUG_SLAB=y

2007-07-18 Thread Andrew Morton
On Wed, 18 Jul 2007 08:59:40 -0700 Eugene Surovegin <[EMAIL PROTECTED]> wrote: > On Wed, Jul 18, 2007 at 08:41:10AM -0500, Josh Boyer wrote: > > On Wed, 2007-07-18 at 01:34 -0700, Eugene Surovegin wrote: > > > On Wed, Jul 18, 2007 at 12:52:53AM -0700, Andrew Morton wrote: > > > > On Wed, 18 Jul 20

Re: [PATCH v2] mac80211: fix GCC warning on 64bit platforms

2007-07-18 Thread Larry Finger
Jiri Benc wrote: If you think "int" is more appropriate, fine with me, I don't really care. No, I'm just trying to learn. Larry - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majo

Re: [PATCH v2 1/3] netlink: allocate group bitmaps dynamically

2007-07-18 Thread Patrick McHardy
Johannes Berg wrote: > Allow changing the number of groups for a netlink family > after it has been created, use RCU to protect the listeners > bitmap keeping netlink_has_listeners() lock-free. > > Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> > > --- > Changes: incorporate Patrick's comments,

Re: [Bugme-new] [Bug 8778] New: Ocotea board: kernel reports access of bad area during boot with DEBUG_SLAB=y

2007-07-18 Thread Josh Boyer
On Wed, 2007-07-18 at 08:59 -0700, Eugene Surovegin wrote: > On Wed, Jul 18, 2007 at 08:41:10AM -0500, Josh Boyer wrote: > > On Wed, 2007-07-18 at 01:34 -0700, Eugene Surovegin wrote: > > > On Wed, Jul 18, 2007 at 12:52:53AM -0700, Andrew Morton wrote: > > > > On Wed, 18 Jul 2007 00:07:50 -0700 (PD

Re: [PATCH v2] mac80211: fix GCC warning on 64bit platforms

2007-07-18 Thread Jiri Benc
On Wed, 18 Jul 2007 11:14:40 -0500, Larry Finger wrote: > > - local->tx_headroom = max(local->hw.extra_tx_headroom, > > -sizeof(struct ieee80211_tx_status_rtap_hdr)); > > + local->tx_headroom = max_t(unsigned, local->hw.extra_tx_headroom, > > +

Re: pmtu discovery on SA

2007-07-18 Thread Patrick McHardy
Beschorner Daniel wrote: >>Beschorner Daniel wrote: >> >>So its using 1492 now? Otherwise it would be expected since the >>initial MTU calculation would be based on 1500. > > > I'm using 1500 again. > > Just to make it clear: Is this message an error, or a warning or just > for information? > Co

Re: Occational lockups during boot with post 2.6.22 kernels

2007-07-18 Thread Johannes Berg
On Wed, 2007-07-18 at 10:58 -0400, Chuck Ebbert wrote: > On 07/17/2007 08:20 PM, Peter Osterlund wrote: > > Current -git kernels sometimes lock up on my computer during boot. I > > guess it happens about 10-20% of the time. I first saw this maybe a > > week ago, but never with kernels <= 2.6.22. >

Re: [PATCH v2] mac80211: fix GCC warning on 64bit platforms

2007-07-18 Thread Larry Finger
Jiri Benc wrote: net/mac80211/ieee80211.c: In function ieee80211_register_hw: net/mac80211/ieee80211.c:4989: warning: comparison of distinct pointer types lacks a cast Size of ieee80211_tx_status_rtap_hdr structure will never be greater than unsigned int. Signed-off-by: Jiri Benc <[EMAIL PROTE

Re: pmtu discovery on SA

2007-07-18 Thread Beschorner Daniel
> Beschorner Daniel wrote: > >>>No more crashes with IPComp and smaller PMTUs. > >>>But the "pmtu discovery on SA ESP/..." messages don't disappear. > >> > >>Thats probably a different issue. Please post the output of > >>"ip -x xfrm state" (obfuscate keys if you care ..). > > > > > > Linux (MTU

Re: Please pull 'upstream-davem' branch of wireless-2.6

2007-07-18 Thread John W. Linville
On Tue, Jul 17, 2007 at 08:17:16PM -0700, David Miller wrote: > From: "John W. Linville" <[EMAIL PROTECTED]> > Date: Tue, 17 Jul 2007 22:16:07 -0400 > > > A few more for 2.6.23...individual patches available here: > > > > > > http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/

Re: [Bugme-new] [Bug 8778] New: Ocotea board: kernel reports access of bad area during boot with DEBUG_SLAB=y

2007-07-18 Thread Eugene Surovegin
On Wed, Jul 18, 2007 at 08:41:10AM -0500, Josh Boyer wrote: > On Wed, 2007-07-18 at 01:34 -0700, Eugene Surovegin wrote: > > On Wed, Jul 18, 2007 at 12:52:53AM -0700, Andrew Morton wrote: > > > On Wed, 18 Jul 2007 00:07:50 -0700 (PDT) [EMAIL PROTECTED] wrote: > > > > > > > http://bugzilla.kernel.o

[PATCH v2 3/3] generic netlink: dynamic multicast groups

2007-07-18 Thread Johannes Berg
Introduce API to dynamically register and unregister multicast groups. Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> --- Changes: update for slightly changed API from v2 of patch 1 and 2, add kernel-doc, properly register the generic netlink group as well, fix bug with that group (it isn't ID 1

[PATCH v2 1/3] netlink: allocate group bitmaps dynamically

2007-07-18 Thread Johannes Berg
Allow changing the number of groups for a netlink family after it has been created, use RCU to protect the listeners bitmap keeping netlink_has_listeners() lock-free. Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> --- Changes: incorporate Patrick's comments, add kernel-doc include/linux/netli

[PATCH v2 2/3] netlink: allow removing multicast groups

2007-07-18 Thread Johannes Berg
Allow kicking listeners out of a multicast group when necessary (for example if that group is going to be removed.) Signed-off-by: Johannes Berg <[EMAIL PROTECTED]> --- Changes: incorporate Patrick's comments, add kernel-doc. include/linux/netlink.h |1 net/netlink/af_netlink.c | 57 +++

Re: [patch 1/3] netlink: allocate group bitmaps dynamically

2007-07-18 Thread Johannes Berg
On Tue, 2007-07-17 at 17:45 +0200, Patrick McHardy wrote: > > --- wireless-dev.orig/net/netlink/af_netlink.c 2007-07-17 > > 14:05:30.210964463 +0200 > > +++ wireless-dev/net/netlink/af_netlink.c 2007-07-17 14:05:30.720964463 > > +0200 > > -static int netlink_alloc_groups(struct sock *sk)

Re: [patch 2/3] netlink: allow removing multicast groups

2007-07-18 Thread Johannes Berg
On Tue, 2007-07-17 at 17:50 +0200, Patrick McHardy wrote: > Having the caller lock the table would save lots of atomic operation > in case of netlink_clear_multicast_users. Good point. > > +void netlink_clear_multicast_users(int unit, unsigned int group) > > Same as in the last patch, passing t

  1   2   >