phy_read() returns a negative number if there's an error, but the
error-checking code in the Vitesse driver's config_intr function
triggers if phy_read() returns non-zero. Correct that.
Signed-off-by: Andy Fleming <[EMAIL PROTECTED]>
---
I made a really stupid mistake in the 4 patches I sent out,
Hi,
I originally sent this email to the linux-net list before realizing it
probably belonged on the netdev list.
I just subscribed to this list, so I apologize if this is a known issue. I
did try looking through the archives, and did not see it there either.
We just put together a new "app s
Hi.
Is it a bug that:
# tc filter add dev eth0 parent 1: protocol ip prio 0 handle 0xfff
fw police rate 1 burst 1 mpu 0 mtu 1 action drop
^^^
creates a filter that looks like:
# tc filter ls dev eth0
filter parent 1: protocol ip pref
From: "John W. Linville" <[EMAIL PROTECTED]>
Date: Tue, 17 Jul 2007 22:16:07 -0400
> A few more for 2.6.23...individual patches available here:
>
>
> http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream-davem
What about this warning which I reported to you right after
On Wed, 18 Jul 2007 11:13:42 +0900, Yoichi Yuasa <[EMAIL PROTECTED]> wrote:
> Fix wrong argument of tc35815_read_plat_dev_addr()
Oh my fault! Thanks!
Acked-by: Atsushi Nemoto <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAI
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
---
net/core/dev.c | 28 ++--
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 17c9cbd..6357f54 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2715,20 +2715,6 @@ int
Because this function is only called by unregister_netdevice,
this moving could make this non-global function static,
and also remove its declaration in netdevice.h;
Any further, function __dev_addr_discard is also just called by
dev_mc_discard and dev_unicast_discard, keeping this two functions
b
this two functions could share the dev->_xmit_lock acquired context.
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]>
---
net/core/dev.c | 16
1 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 3ba63aa..17c9cbd 100644
--- a/net/c
A few more for 2.6.23...individual patches available here:
http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream-davem
Thanks!
John
---
The following changes since commit 4ad1366376bfef32ec0ffa12d1faa483d6f330bd:
NeilBrown (1):
md: change bitmap_unplug and ot
A few more for 2.6.23...
Thanks!
John
---
The following changes since commit 4ad1366376bfef32ec0ffa12d1faa483d6f330bd:
NeilBrown (1):
md: change bitmap_unplug and others to void functions
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/linvill
Fix wrong argument of tc35815_read_plat_dev_addr()
Signed-off-by: Yoichi Yuasa <[EMAIL PROTECTED]>
diff -pruN -X generic/Documentation/dontdiff generic-orig/drivers/net/tc35815.c
generic/drivers/net/tc35815.c
--- generic-orig/drivers/net/tc35815.c 2007-07-18 10:45:56.542655750 +0900
+++ generic
Rusty Russell wrote:
> The default function points to the internal stats...
>
Right you are.
J
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2007-07-17 at 07:28 -0700, Jeremy Fitzhardinge wrote:
> Stephen Hemminger wrote:
> >> +struct netfront_info {
> >> + struct list_head list;
> >> + struct net_device *netdev;
> >> +
> >> + struct net_device_stats stats;
> >>
> >
> > There is now a net_device_stats element inside net_
Beschorner Daniel wrote:
>>I fixed it myself. Daniel, can you please test this patch?
>
>
> Many thanks Patrick!!!
> I tested it and found it working!
Thanks for testing.
> No more crashes with IPComp and smaller PMTUs.
> But the "pmtu discovery on SA ESP/..." messages don't disappear.
Thats
> >>> I managed to reproduce a crash with ipcomp, will try to
> fix it later.
> >>>
> >> Yes, I can confirm this.
> >> After disabling IPComp the crashes went away.
> >>
> > The crash happens in xfrm_bundle_ok when walking the bundle upwards
> > following xfrm_dst->u.next. The loop sho
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Tue, 17 Jul 2007 20:41:29 +0100
> Sounds like sucky hardware...
Although expect more of the same in the future, not less.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majord
On Tue, 17 Jul 2007 10:20:58 -0700 (PDT)
vinay ravuri <[EMAIL PROTECTED]> wrote:
> Hi,
>
> I am fairly new to linux socket buffers and have the
> following questions!
>
> I am working with a custom ethernet MAC that does not
> allow me to specify a particular memory location for
> the h/w to DMA
[EMAIL PROTECTED] wrote:
This is a note to let you know that I've just added the patch titled
Subject: [PATCH] PCI: quirk_e100_interrupt() called too early
to my gregkh-2.6 tree. Its filename is
pci-quirk_e100_interrupt-called-too-early.patch
This tree can be found at
http://w
Hi,
I am fairly new to linux socket buffers and have the
following questions!
I am working with a custom ethernet MAC that does not
allow me to specify a particular memory location for
the h/w to DMA the packet into (Rx side). Instead, it
has a pool of fixed size buffers with some h/w
specific h
This is a note to let you know that I've just added the patch titled
Subject: [PATCH] PCI: quirk_e100_interrupt() called too early
to my gregkh-2.6 tree. Its filename is
pci-quirk_e100_interrupt-called-too-early.patch
This tree can be found at
http://www.kernel.org/pub/linux/ke
Patrick McHardy wrote:
Beschorner Daniel wrote:
I managed to reproduce a crash with ipcomp, will try to fix it later.
Yes, I can confirm this.
After disabling IPComp the crashes went away.
The crash happens in xfrm_bundle_ok when walking the bundle upwards
following xfrm_dst->
Joakim Koskela wrote:
> On Monday 16 July 2007 21:47:40 Patrick McHardy wrote:
>
>>>diff --git a/net/ipv4/xfrm4_output.c b/net/ipv4/xfrm4_output.c
>>>index 44ef208..8db7910 100644
>>>--- a/net/ipv4/xfrm4_output.c
>>>+++ b/net/ipv4/xfrm4_output.c
>>>@@ -53,7 +53,8 @@ static int xfrm4_output_one(str
Johannes Berg wrote:
> +static void netlink_update_socket_mc(struct netlink_sock *nlk,
> + unsigned int group,
> + int is_new)
> +{
> + int old, new = !!is_new, subscriptions;
> +
> + netlink_table_grab();
Having the caller
Johannes Berg wrote:
> Allow changing the number of groups for a netlink family
> after it has been created, use RCU to protect the listeners
> bitmap keeping netlink_has_listeners() lock-free.
>
> Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
>
> ---
> include/linux/netlink.h |1
> net
On Monday 16 July 2007 21:47:40 Patrick McHardy wrote:
>
> I lost interest here, but the reintroduced bugs make me think that
> some old version was simply rediffed without even checking the
> output and the state initialization also seems to need a bit more work.
>
Thanks for reviewing the code,
Add ethtool hooks to ibmveth to retrieve driver statistics.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/drivers/net/ibmveth.c | 53 +++-
1 file changed, 52 insertions(+), 1 deletion(-)
diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_driver_
This patchset enables TCP checksum offload support for IPV4
on ibmveth. This completely eliminates the generation and checking of
the checksum for packets that are completely virtual and never
touch a physical network. A simple TCP_STREAM netperf run on
a virtual network with maximum mtu set yield
This patch adds the appropriate ethtool hooks to allow for enabling/disabling
of hypervisor assisted checksum offload for TCP.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/drivers/net/ibmveth.c | 120 +++-
linux-2.6-bjking1/drivers/net/ibmveth
Add handlers for get_tso and get_ufo to prevent errors being printed
by ethtool.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/drivers/net/ibmveth.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_get_tso drivers
Adrian Bunk wrote:
> ipt_iprange.h must #include since it uses __be32.
Applied, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Stephen Hemminger wrote:
>> +struct netfront_info {
>> +struct list_head list;
>> +struct net_device *netdev;
>> +
>> +struct net_device_stats stats;
>>
>
> There is now a net_device_stats element inside net_device on
> 2.6.21 or later.
>
Ah, OK. Should I just do a s/stats/net
On 7/10/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
Veeraiyan, Ayyappan wrote:
> On 7/10/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
>> [EMAIL PROTECTED] wrote:
>>
> I will post the performance numbers later today..
Sorry for not responding earlier. We faced couple of issues lik
Allow changing the number of groups for a netlink family
after it has been created, use RCU to protect the listeners
bitmap keeping netlink_has_listeners() lock-free.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
---
include/linux/netlink.h |1
net/netlink/af_netlink.c | 86 ++
Allow kicking listeners out of a multicast group when necessary
(for example if that group is going to be removed.)
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
---
include/linux/netlink.h |1 +
net/netlink/af_netlink.c | 47 ++-
2 files cha
This patch series adds dynamic generic netlink multicast groups.
The ACPI people are open to rebasing their patches on top of this.
Both Jamal and Patrick gave it a quick review (Patrick said he'll
review it again when he gets around) and we've discussed the API
for a while ending up with this. Ple
Introduce API to dynamically register and unregister multicast groups.
Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>
---
include/linux/genetlink.h | 13 +++
include/net/genetlink.h | 22 +
net/netlink/genetlink.c | 190 --
3 files change
Reading netlink_setsockopt it's not immediately clear why there isn't a
bug when you pass in negative numbers, the reason being that the >=
comparison is really unsigned although 'val' is signed because
nlk->ngroups is unsigned. Make 'val' unsigned too.
Signed-off-by: Johannes Berg <[EMAIL PROTECT
[PPPOL2TP]: Reset meta-data in xmit function
Reset netfilter data and IP CB, fix dst_entry leak.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 308ac1b6249226730b70fcf7c13a289c27ce2bf3
tree ea05987add4c9423af023e4bc9ca773ab70568c3
parent 86394ab99d7a4532cf23f8d456aecfa6e3085dfd
au
[PPPOL2TP]: Fix use-after-free
Don't use skb->len after passing it to ip_queue_xmit.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 86394ab99d7a4532cf23f8d456aecfa6e3085dfd
tree 704cfbb8d9c06f79c21a54f189608db1d1b06915
parent 2e27afb300b56d83bb03fbfa68852b9c1e2920c6
author Patrick
On Tue, Jul 17, 2007 at 02:01:48PM +0200, Patrick McHardy wrote:
...
Thanks,
Jarek P.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jarek Poplawski wrote:
> This patch looks fine, but while checking for this lock I've found
> another strange thing: for actions tcfc_stats_lock is used here, which
> is equivalent to tcfc_lock; so, in gen_kill_estimator we get this lock
> sometimes after dev->queue_lock; this order is also possibl
On Mon, Jul 16, 2007 at 08:45:05PM +0300, Ranko Zivojnovic wrote:
...
> [NET] gen_estimator deadlock fix
>
> -Fixes ABBA deadlock noted by Patrick McHardy <[EMAIL PROTECTED]>:
>
> > There is at least one ABBA deadlock, est_timer() does:
> > read_lock(&est_lock)
> > spin_lock(e->stats_lock) (which
On Mon, 2007-07-16 at 15:42 +0200, Patrick McHardy wrote:
> Sorry, I'm behind with my plans. I'll try to get to it ASAP,
> but I don't want to stand in your way until then.
Don't want to hurry you or anything, just thought maybe it had dropped
off.
> So here's
> a preliminary ACK based on my fi
On Sun, 15 Jul 2007 15:03:21 +0300 Sami Farin <[EMAIL PROTECTED]> wrote:
> After I got this error [1], system got real slow, like 386 having 32 MB of RAM
> and swapping constantly.
> My system is P4 SMP with 1GB of RAM.
>
> I got this same behavior with 2.6.19, too, but then I used GNU cp v6.9
>
> +struct netfront_info {
> + struct list_head list;
> + struct net_device *netdev;
> +
> + struct net_device_stats stats;
There is now a net_device_stats element inside net_device on
2.6.21 or later.
> +
> + struct xen_netif_tx_front_ring tx;
> + struct xen_netif_rx_front_ri
On Mon, Jul 16, 2007 at 06:57:21PM -0400, Jeff Garzik wrote:
> Minor fixes and cleanups, and a wireless pull from Linville.
>
> Please pull from 'upstream-linus' branch of
> master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
> upstream-linus
>
did you get the dgrs removal patch?
46 matches
Mail list logo
