Re: ip6_fib.c locking protocol.

2007-06-19 Thread Paul E. McKenney
On Wed, Jun 20, 2007 at 12:17:04AM -0400, C. Scott Ananian wrote: > I'm working on a patch to implement RDNSS options > in Router Advertisement messages in IPv6. (Draft RFC at: > http://tools.ietf.org/html/draft-jeong-dnsop-ipv6-dns-discovery-12 > Support is already in radvd.) > > I don't quite u

Re: [NET 00/02]: MACVLAN driver

2007-06-19 Thread Jeff Garzik
David Miller wrote: This is actually a real issue for virtualization, and many if not all current generation ethernet chips support programming several unicast ethernet addresses in the MAC. Networking switches in domain0 on virtualization hosts use this feature to support seperate MACs per gues

Re: [PATCH] NET: Multiqueue network device support.

2007-06-19 Thread Zhu Yi
On Tue, 2007-06-19 at 12:04 -0400, jamal wrote: > In the case of wireless, pick two numbers XHH and XHL with XHL < XHH. > The timers would be similar in nature (THH > THL). All these variables > are only valid if you shutdown the ring. > So in the case HL shuts down the ring, you fire THL. If eith

ip6_fib.c locking protocol.

2007-06-19 Thread C. Scott Ananian
I'm working on a patch to implement RDNSS options in Router Advertisement messages in IPv6. (Draft RFC at: http://tools.ietf.org/html/draft-jeong-dnsop-ipv6-dns-discovery-12 Support is already in radvd.) I don't quite understand how 'struct rt6_info' allocation/deallocation and locking are happe

Re: [NET 00/02]: MACVLAN driver

2007-06-19 Thread Patrick McHardy
David Miller wrote: From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 19 Jun 2007 23:14:21 +0200 Stephen Hemminger wrote: Looks good. I have some changes to allow devices with multiple MAC addresses (never finished). This device could use that. How would the driver do that?

Re: [IPROUTE]: Fix symbolic link to tc-bfifo.8

2007-06-19 Thread Stephen Hemminger
On Mon, 18 Jun 2007 11:16:42 +0900 (JST) Yasuyuki KOZAKAI <[EMAIL PROTECTED]> wrote: > > tc-pbfifo.8 does not exist because it was moved to tc-bfifo.8. > > Signed-off-by: Yasuyuki Kozakai <[EMAIL PROTECTED]> > --- > Makefile |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > di

Re: [PATCH] iproute2: Format IPv6 tunnels endpoints nicely.

2007-06-19 Thread Stephen Hemminger
On Sat, 9 Jun 2007 15:53:58 +0200 David Lamparter <[EMAIL PROTECTED]> wrote: > Change formatting of IPv6 tunnel endpoints from hex chain to standard IPv6 > representation. > > Signed-off-by: David Lamparter <[EMAIL PROTECTED]> > > --- > lib/ll_addr.c |3 +++ > 1 files changed, 3 insertions(

Re: [RESEND][PATCH][IPROUTE2] see SAD info

2007-06-19 Thread Stephen Hemminger
On Thu, 03 May 2007 19:09:41 -0400 jamal <[EMAIL PROTECTED]> wrote: > Stephen, > Use this patch instead of the one i sent yesterday. > As before, you will need to pull include/linux/xfrm.h from > net-2.6 once Dave applies the kernel patch. > > cheers, > jamal > Using current xfrm.h from kernel

Re: [RFC PATCH tcp-2.6 1/2] [TCP]: Discard fuzzy SACK blocks

2007-06-19 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Wed, 20 Jun 2007 02:09:44 +0300 (EEST) > For sure you're curious enough - have a nice day with the negations... ;-) > ...Seriously, double verification of that pkt_len part wouldn't hurt > considering it's complexity. Thanks for explaining everythi

RE: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-19 Thread Waskiewicz Jr, Peter P
> It's not being allocated at "compile time", it's being > allocated linearly into one block of ram in order to avoid > pointer derefs but it's still "dynamic" in that the size > isn't known until the alloc_netdev() call. > > We do this trick all over the networking, TCP sockets are 3 > or 4 d

Re: [RFC PATCH tcp-2.6 1/2] [TCP]: Discard fuzzy SACK blocks

2007-06-19 Thread Ilpo Järvinen
On Mon, 18 Jun 2007, David Miller wrote: > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > Date: Tue, 19 Jun 2007 01:25:57 +0300 > > > From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]> > > > > SACK processing code has been sort of russian roulette as no > > validation of SACK blocks is prev

Re: r8169 tx problem (1s pause with ping)

2007-06-19 Thread Francois Romieu
r.zoreil.com/people/francois/misc/20070619-2.6.22-rc5-r8169-test.patch It applies against 2.6.22-rc5 too. I should come with something else soon. diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 8f3e0da..8c0851f 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -26

Re: [NET 00/02]: MACVLAN driver

2007-06-19 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Tue, 19 Jun 2007 23:14:21 +0200 > Stephen Hemminger wrote: > > Looks good. I have some changes to allow devices with multiple MAC addresses > > (never finished). This device could use that. > > > How would the driver do that? I was thinking about

Re: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-19 Thread David Miller
From: "Waskiewicz Jr, Peter P" <[EMAIL PROTECTED]> Date: Tue, 19 Jun 2007 13:01:18 -0700 > I've been thinking about this more today, so please bear with me if I'm > missing something. Right now, with how qdisc_restart() is running, we'd > definitely call netif_subqueue_stopped(dev, skb->queue_map

Re: [NET 00/02]: MACVLAN driver

2007-06-19 Thread Stephen Hemminger
On Tue, 19 Jun 2007 23:14:21 +0200 Patrick McHardy <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > Looks good. I have some changes to allow devices with multiple MAC addresses > > (never finished). This device could use that. > > > How would the driver do that? I was thinking about us

Re: [WIP][PATCHES] Network xmit batching

2007-06-19 Thread David Miller
From: Robert Olsson <[EMAIL PROTECTED]> Date: Tue, 19 Jun 2007 19:35:45 +0200 > pktgen heavily uses gettimeofday. I was using tsc as clock source with > our opterons in the lab. In late 2.6.20 gettimeofday was changed so tsc > couldn't be used on opterons (pktgen at least). > > To give you

Re: Why is this patch not in 2.6.22-rc5?

2007-06-19 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Tue, 19 Jun 2007 13:52:14 -0400 > Stephen Hemminger wrote: > > On Wed, 13 Jun 2007 21:36:30 -0700 > > Jay Vosburgh <[EMAIL PROTECTED]> wrote: > > > >>The following patch (based on a patch from Stephen Hemminger > >> <[EMAIL PROTECTED]>) removes use

Re: [PATCH] TIPC: Fix infinite loop in netlink handler

2007-06-19 Thread Patrick McHardy
Florian Westphal wrote: > From: Florian Westphal <[EMAIL PROTECTED]> > > The tipc netlink config handler uses the nlmsg_pid from the > request header as destination for its reply. If the application > initialized nlmsg_pid to 0, the reply is looped back to the kernel, > causing hangup. Fix: use nl

Re: [PATCH 2.6.21.3] ppp_mppe: account for osize too small errors in mppe_decompress()

2007-06-19 Thread Konstantin
Thanks for pointing this out. It seems that we would need to allocate this extra byte somewhere in kernel ppp code. However, I am not very familiar with that part of the code yet, and I'll appreciate any help with finding parts of code where obuffer for mppe_decompress is allocated. On 6/20/07,

Re: [NET_SCHED 03/04]: sch_htb: use generic estimator

2007-06-19 Thread Patrick McHardy
Ranjit Manomohan wrote: > On 6/19/07, Patrick McHardy <[EMAIL PROTECTED]> wrote: > >> [NET_SCHED]: sch_htb: use generic estimator >> >> Use the generic estimator instead of reimplementing (parts of) it. >> For compatibility always create a default estimator for new classes. >> >> >> +

Re: [NET 00/02]: MACVLAN driver

2007-06-19 Thread Patrick McHardy
Stephen Hemminger wrote: > Looks good. I have some changes to allow devices with multiple MAC addresses > (never finished). This device could use that. How would the driver do that? I was thinking about using dev_add_mc, but wasn't sure if that would work with all drivers for non-multicast addre

Re: 2.6.22: ERROR: "__ucmpdi2" [drivers/net/s2io.ko] undefined!

2007-06-19 Thread Olaf Hering
On Tue, Jun 19, Stephen Hemminger wrote: > On Tue, 19 Jun 2007 21:02:53 +0200 > Olaf Hering <[EMAIL PROTECTED]> wrote: > > > > > What happend to __ucmpdi2 from David Woodhouse? > > google has a few hits about stuff like this on 32bit powerpc with gcc 4.1.2: > > > > ERROR: "__ucmpdi2" [drivers/n

[PATCH] TIPC: Fix infinite loop in netlink handler

2007-06-19 Thread Florian Westphal
From: Florian Westphal <[EMAIL PROTECTED]> The tipc netlink config handler uses the nlmsg_pid from the request header as destination for its reply. If the application initialized nlmsg_pid to 0, the reply is looped back to the kernel, causing hangup. Fix: use nlmsg_pid of the skb that triggered th

Re: 2.6.22: ERROR: "__ucmpdi2" [drivers/net/s2io.ko] undefined!

2007-06-19 Thread Stephen Hemminger
On Tue, 19 Jun 2007 21:02:53 +0200 Olaf Hering <[EMAIL PROTECTED]> wrote: > > What happend to __ucmpdi2 from David Woodhouse? > google has a few hits about stuff like this on 32bit powerpc with gcc 4.1.2: > > ERROR: "__ucmpdi2" [drivers/net/s2io.ko] undefined! > > using the drivers/net/s2io* fi

RE: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-19 Thread Waskiewicz Jr, Peter P
> From: PJ Waskiewicz <[EMAIL PROTECTED]> > Date: Mon, 18 Jun 2007 11:42:29 -0700 > > > + > > + /* The TX queue control structures */ > > + struct net_device_subqueue *egress_subqueue; > > + int egress_subqueue_count; > > Since every net device will have at

Re: [NET 00/02]: MACVLAN driver

2007-06-19 Thread Chris Leech
On 6/19/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote: Looks good. I have some changes to allow devices with multiple MAC addresses (never finished). This device could use that. Stephen, Is this patch available somewhere? I'd be interested in taking a look at it. - Chris - To unsubscribe

3c59x: multiple problems

2007-06-19 Thread Chuck Ebbert
More and more people are reporting this error message: Jun 18 19:54:33 loki kernel: NETDEV WATCHDOG: eth0: transmit timed out Jun 18 19:54:33 loki kernel: eth0: transmit timed out, tx_status 00 status 8601. Jun 18 19:54:33 loki kernel: diagnostics: net 0ccc media 8880 dma 003a fifo Jun

[PATCH] bonding: Fix use after free in unregister path

2007-06-19 Thread Jay Vosburgh
The following patch (based on a patch from Stephen Hemminger <[EMAIL PROTECTED]>) removes use after free conditions in the unregister path for the bonding master. Without this patch, an operation of the form "echo -bond0 > /sys/class/net/bonding_masters" would trigger a NULL pointer deref

Re: [NET_SCHED 03/04]: sch_htb: use generic estimator

2007-06-19 Thread Ranjit Manomohan
On 6/19/07, Patrick McHardy <[EMAIL PROTECTED]> wrote: [NET_SCHED]: sch_htb: use generic estimator Use the generic estimator instead of reimplementing (parts of) it. For compatibility always create a default estimator for new classes. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- comm

Re: [WIP][PATCHES] Network xmit batching

2007-06-19 Thread Evgeniy Polyakov
On Tue, Jun 19, 2007 at 01:48:20PM -0400, jamal ([EMAIL PROTECTED]) wrote: > On Tue, 2007-19-06 at 19:35 +0200, Robert Olsson wrote: > > > But Evgeniy is most likely using the same clocksource both for the > > mainline > > and batch tests so there must be something different... > > Iam curiou

Re: Why is this patch not in 2.6.22-rc5?

2007-06-19 Thread Jeff Garzik
Stephen Hemminger wrote: On Wed, 13 Jun 2007 21:36:30 -0700 Jay Vosburgh <[EMAIL PROTECTED]> wrote: The following patch (based on a patch from Stephen Hemminger <[EMAIL PROTECTED]>) removes use after free conditions in the unregister path for the bonding master. Without this patch, an

Re: [WIP][PATCHES] Network xmit batching

2007-06-19 Thread jamal
On Tue, 2007-19-06 at 19:35 +0200, Robert Olsson wrote: > But Evgeniy is most likely using the same clocksource both for the mainline > and batch tests so there must be something different... Iam curious though which one, from my notes on my laptop for that test machine: # cat /sys/devices/sy

Re: [WIP][PATCHES] Network xmit batching

2007-06-19 Thread Robert Olsson
jamal writes: > What is your kernel config in regards to HRES timers? Robert mentioned > to me that the clock source maybe causing issues with pktgen (maybe even > qos). Robert, insights? pktgen heavily uses gettimeofday. I was using tsc as clock source with our opterons in the lab. In lat

Re: [WIP][PATCHES] Network xmit batching

2007-06-19 Thread Evgeniy Polyakov
On Tue, Jun 19, 2007 at 12:32:48PM -0400, jamal ([EMAIL PROTECTED]) wrote: > > > pktgen reults are quite poor: > > > batch (changed from default script: count reduced, clone increased to 10k) > > > 241319pps 115Mb/sec > > BTW, dont turn on the cloning - leave it as 1 so we can have every > packet

RE: [PATCH 3/3] NET: [CORE] Stack changes to add multiqueue hardware support API

2007-06-19 Thread Waskiewicz Jr, Peter P
> From: PJ Waskiewicz <[EMAIL PROTECTED]> > Date: Mon, 18 Jun 2007 11:42:29 -0700 > > > + > > + /* The TX queue control structures */ > > + struct net_device_subqueue *egress_subqueue; > > + int egress_subqueue_count; > > Since every net device will have at

Re: [WIP][PATCHES] Network xmit batching

2007-06-19 Thread Evgeniy Polyakov
On Tue, Jun 19, 2007 at 12:28:49PM -0400, jamal ([EMAIL PROTECTED]) wrote: > In my case, I have: > # CONFIG_TICK_ONESHOT is not set > # CONFIG_NO_HZ is not set > # CONFIG_HIGH_RES_TIMERS is not set $ cat ./.config | egrep "CONFIG_TICK_ONESHOT|CONFIG_NO_HZ|CONFIG_HIGH_RES_TIMERS" $ > I will try t

Re: [WIP][PATCHES] Network xmit batching

2007-06-19 Thread Evgeniy Polyakov
On Tue, Jun 19, 2007 at 12:28:49PM -0400, jamal ([EMAIL PROTECTED]) wrote: > On Tue, 2007-19-06 at 18:00 +0400, Evgeniy Polyakov wrote: > > > pktgen reults are quite poor: > > batch (changed from default script: count reduced, clone increased to 10k) > > 241319pps 115Mb/sec > > > > mainline (the

Re: [WIP][PATCHES] Network xmit batching

2007-06-19 Thread jamal
On Tue, 2007-19-06 at 18:09 +0400, Evgeniy Polyakov wrote: > On Tue, Jun 19, 2007 at 06:00:39PM +0400, Evgeniy Polyakov ([EMAIL > PROTECTED]) wrote: > > > > pktgen reults are quite poor: > > batch (changed from default script: count reduced, clone increased to 10k) > > 241319pps 115Mb/sec BTW,

Re: [WIP][PATCHES] Network xmit batching

2007-06-19 Thread jamal
On Tue, 2007-19-06 at 18:00 +0400, Evgeniy Polyakov wrote: > pktgen reults are quite poor: > batch (changed from default script: count reduced, clone increased to 10k) > 241319pps 115Mb/sec > > mainline (the same script, on start it wrote about unsupported batch_low > parameter: > 497520pps 238Mb

Re: [WIP][PATCHES] Network xmit batching

2007-06-19 Thread jamal
On Tue, 2007-19-06 at 17:21 +0400, Evgeniy Polyakov wrote: > I've ran several simple tests with desktop e1000 adapter I managed to > find. Mucho gracias Evgeniy. > Test machine is amd athlon64 3500+ with 1gb of ram. > Another point is dektop core duo 3.4 ghz with 2 gb of ram and sky2 > driver.

Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

2007-06-19 Thread jamal
On Tue, 2007-19-06 at 13:30 +0200, Johannes Berg wrote: > Ah, that coincides with something I was wondering about. Isn't it > possible to have multiple multicast groups with generic netlink? If so, > we might have to use real netlink for wireless... There is one default mcast group per entity. M

Re: [PATCH 1/2 - rev2] qdisc_restart - readability changes plus onebug fix.

2007-06-19 Thread jamal
On Mon, 2007-18-06 at 20:58 -0700, David Miller wrote: > From: Krishna Kumar2 <[EMAIL PROTECTED]> > Date: Tue, 19 Jun 2007 09:05:28 +0530 > > > Dave, does it make sense to add this to 2.6.23 ? Herbert and Peter > > had earlier reviewed Patch 2/2 and said they were OK with it. > > What does Jamal

Re: [NET 00/02]: MACVLAN driver

2007-06-19 Thread Stephen Hemminger
On Tue, 19 Jun 2007 15:08:41 +0200 (MEST) Patrick McHardy <[EMAIL PROTECTED]> wrote: > These patches add a rewritten version of Ben's macvlan driver, which > allows to create virtual ethernet devices. The underlying device is > put in promiscous mode and packets are demuxed based on MAC address. >

Re: [PATCH] NET: Multiqueue network device support.

2007-06-19 Thread jamal
On Tue, 2007-19-06 at 10:12 +0800, Zhu Yi wrote: > Mine was much simpler. We don't need to > consider the wireless dynamic priority change case at this time. Just > tell me what you suppose the driver to do (stop|start queue) when the > hardware PHL is full but PHH is empty? I already responded t

Why is this patch not in 2.6.22-rc5?

2007-06-19 Thread Stephen Hemminger
On Wed, 13 Jun 2007 21:36:30 -0700 Jay Vosburgh <[EMAIL PROTECTED]> wrote: > > The following patch (based on a patch from Stephen Hemminger > <[EMAIL PROTECTED]>) removes use after free conditions in > the unregister path for the bonding master. Without this patch, an > operation of the fo

RTF_DYNAMIC flag in ipv4 and in ipv6 , ICMP redirect and the routing table/cache

2007-06-19 Thread Ian Brown
Hello, Suppose a routing cache entry is added as a consequence of a redirect to host ICMP message. There is in include/linux.h two flags , one for entry which is created and one for an entry which is modified because of a redirect: #define RTF_DYNAMIC 0x0010 /* created dyn. (by red

Re: [PATCH 2.6.21.3] ppp_mppe: account for osize too small errors in mppe_decompress()

2007-06-19 Thread Sergey Vlasov
On Tue, 05 Jun 2007 22:23:02 +1100 Konstantin Sharlaimov wrote: > Prevent mppe_decompress() from generating "osize too small" errors when > checking > for output buffer size. When receiving a packet of mru size the output buffer > for decrypted data is 1 byte too small since mppe_decompress() tri

Re: [RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-19 Thread Satyam Sharma
Hi again Keiichi, On 6/19/07, Keiichi KII <[EMAIL PROTECTED]> wrote: Hello Satyam, > *ugh*. I was wondering what a show-stopper this particular patch > was -- introduces a couple of ioctl()'s, exports a new structure to > userspace, adds a hitherto-unneeded header file, brings in > tty_struct/t

[NET_SCHED 03/04]: sch_htb: use generic estimator

2007-06-19 Thread Patrick McHardy
[NET_SCHED]: sch_htb: use generic estimator Use the generic estimator instead of reimplementing (parts of) it. For compatibility always create a default estimator for new classes. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit f18cfcd1e11aabd3c0b606c7f3265634b5261e88 tree f6118555

[NET_SCHED 04/04]: Remove unnecessary includes

2007-06-19 Thread Patrick McHardy
[NET_SCHED]: Remove unnecessary includes Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit ca29df065c5d0caa69cde99f9cf1775d63b3468d tree 102917a89c4c3e63f9ba1d586bd112614f8c6614 parent f18cfcd1e11aabd3c0b606c7f3265634b5261e88 author Patrick McHardy <[EMAIL PROTECTED]> Tue, 19 Jun 2007

[NET_SCHED 01/04]: Remove CONFIG_NET_ESTIMATOR option

2007-06-19 Thread Patrick McHardy
[NET_SCHED]: Remove CONFIG_NET_ESTIMATOR option The generic estimator is always built in anways and all the config options does is prevent including a minimal amount of code for setting it up. Additionally the option is already automatically selected for most cases. Signed-off-by: Patrick McHardy

[NET_SCHED 02/04]: Remove unnecessary stats_lock pointers

2007-06-19 Thread Patrick McHardy
[NET_SCHED]: Remove unnecessary stats_lock pointers Remove stats_lock pointers from qdisc-internal structures, in all cases it points to dev->queue_lock. The only case where it is necessary is for top-level qdiscs, where it might also point to dev->ingress_lock in case of the ingress qdisc. Also r

[NET_SCHED 00/04]: Cleanups

2007-06-19 Thread Patrick McHardy
These patches contain some cleanup in net/sched related to estimators (removal of the NET_ESTIMATOR config option, unnecessary stats_lock pointers in multiple structures and the HTB estimator reimplementation) and additionally remove lots of unnecessary includes. Please apply, thanks. include/n

Re: [RFC][PATCH -mm take5 4/7] using symlink for the net_device

2007-06-19 Thread Satyam Sharma
Hi, On 6/19/07, Keiichi KII <[EMAIL PROTECTED]> wrote: Hello Satyam, > and this is why we have to use the dual-list mechanism to react to the net > device rename. This isn't so obvious, a comment at the point where you > declare modify_target_list would be nice? (BTW temporary_list would be > a

Re: [WIP][PATCHES] Network xmit batching

2007-06-19 Thread Evgeniy Polyakov
On Tue, Jun 19, 2007 at 06:00:39PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > On Tue, Jun 19, 2007 at 05:33:33PM +0400, Evgeniy Polyakov ([EMAIL > PROTECTED]) wrote: > > On Tue, Jun 19, 2007 at 05:21:48PM +0400, Evgeniy Polyakov ([EMAIL > > PROTECTED]) wrote: > > > Simple test included

Re: [RFC][PATCH -mm take5 4/7] using symlink for the net_device

2007-06-19 Thread Satyam Sharma
Hi Keiichi, On 6/19/07, Keiichi KII <[EMAIL PROTECTED]> wrote: Hello Satyam, > Sorry, but we're not covering from the error condition fully here. Note > that later you merge the temporary modify_target_list entirely back > into the target_list ... which would still contain these erroneous > nod

Re: [WIP][PATCHES] Network xmit batching

2007-06-19 Thread Evgeniy Polyakov
Hi. On Thu, Jun 07, 2007 at 07:43:49AM -0400, jamal ([EMAIL PROTECTED]) wrote: > Folks, we need help. Please run this on different hardware. Evgeniy, i > thought this kind of stuff excites you, no? ;-> (wink, wink). > Only the sender needs the patch but the receiver must be a more powerful > machi

Re: [WIP][PATCHES] Network xmit batching

2007-06-19 Thread Evgeniy Polyakov
On Tue, Jun 19, 2007 at 05:33:33PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > On Tue, Jun 19, 2007 at 05:21:48PM +0400, Evgeniy Polyakov ([EMAIL > PROTECTED]) wrote: > > Simple test included test -> desktop and vice versa traffic with 128 and > > 4096 block size in netperf-2.4.3 setup.

Re: [WIP][PATCHES] Network xmit batching

2007-06-19 Thread Evgeniy Polyakov
On Tue, Jun 19, 2007 at 05:21:48PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > Simple test included test -> desktop and vice versa traffic with 128 and > 4096 block size in netperf-2.4.3 setup. I.e. it is not pktgen, but usual userspace application, which should not use new batch methods

Network namespace ported to 2.6.21-mm2

2007-06-19 Thread Daniel Lezcano
Hi all, The network namespace patchset has been ported to 2.6.21-mm2. They are still some issues but we are on it, for this reason the patchset is named netns1-beta1. The patchset can be found here : http://lxc.sourceforge.net/patches/2.6.21/2.6.21-mm2-netns1-beta1/ Documentation can be fou

[ETHERNET 01/02]: Validate new address in eth_mac_addr

2007-06-19 Thread Patrick McHardy
[ETHERNET]: Validate new address in eth_mac_addr Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit c92ac42cd3badaf120e97223ac4798abf5226424 tree 824d080a4748fcd6f025bbe7b9466feee46e3303 parent 45da27ba265dba3c740c45d47f584c30d7066f82 author Patrick McHardy <[EMAIL PROTECTED]> Mon, 18

[NET 02/02]: Add MACVLAN driver

2007-06-19 Thread Patrick McHardy
[NET]: Add MACVLAN driver Add macvlan driver, which allows to create virtual ethernet devices based on MAC address. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 890e2ae4ef5599ee34f280af4882f97c2dcfcb7b tree a41a8564a8add18a2095a18d4a3f1a2ce0c25997 parent c92ac42cd3badaf120e97223

[NET 00/02]: MACVLAN driver

2007-06-19 Thread Patrick McHardy
These patches add a rewritten version of Ben's macvlan driver, which allows to create virtual ethernet devices. The underlying device is put in promiscous mode and packets are demuxed based on MAC address. It behaves similar to bridge devices in that packets are visible on the real device before de

Re: [XFRM]: Fix MTU calculation for non-ESP SAs

2007-06-19 Thread Patrick McHardy
David Miller wrote: > From: Patrick McHardy <[EMAIL PROTECTED]> > Date: Mon, 18 Jun 2007 18:09:11 +0200 > > >>[XFRM]: Fix MTU calculation for non-ESP SAs >> >>My IPsec MTU optimization patch introduced a regression in MTU calculation >>for non-ESP SAs, the SA's header_len needs to be subtracted f

Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

2007-06-19 Thread Johannes Berg
On Mon, 2007-06-18 at 11:01 -0400, jamal wrote: > Ok, by inspection (sorry, still dont have much time) - your kernel code > is sending to group 1; i.e > > genlmsg_multicast(skb, 0, 1, GFP_ATOMIC); > > you need to change that to send to your assigned id, i.e: > genlmsg_multicast(skb, 0, acpi_even

Re: r8169 tx problem (1s pause with ping)

2007-06-19 Thread David Gundersen
Out of curiousity, does it work if you just do a single read (ie RTL_R8(TxPoll);) of the register before writing to it? That would clear things up if it is a PCI posting problem. Hi Ben, I tried your suggestion but it didn't seem to make any difference :( I tried the following combinations

[PATCH] ps3: gigabit ethernet driver for PS3, take2

2007-06-19 Thread MOKUNO Masakazu
Hi, This is the second submission of the network driver for PS3. This version have been updated to address issues raised in the review. Please apply for 2.6.23. From: Masakazu Mokuno <[EMAIL PROTECTED]> Add Gigabit Ethernet support for the PS3 game console. The module will be called ps3_gelic.

Re: 2.4.35-pre1: new e1000 driver breaks old hardware

2007-06-19 Thread Wolfgang Nothdurft
Kok, Auke wrote: > Wolfgang Nothdurft wrote: >> Hi, >> >> with the new e1000 driver version 7.3.20 the onboard gigabit nic 82547EI >> (8086:1019) doesn't work correctly. >> After transferring about 100 megabytes over a gigabit link the transfer >> stopped and I have to reinit the link either by doi

[PATCH 2.6.22 2/4]S2IO: Removing MSI support from the driver

2007-06-19 Thread Veena Parat
1.Removed MSI support from driver - unused feature 2.Removed pci_request_regions call to allocate bar2 as it is not used in driver 3.Removed pci_release_regions since pci_request_regions is not done Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -urpN patch_1/drivers/net/s2io.c patch_2/dr

[PATCH 2.6.22 1/4]S2IO: Adding checks to check the return value of pci mapping function

2007-06-19 Thread Veena Parat
Adding checks to check the return value of pci mapping function Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -urpN org/drivers/net/s2io.c patch_1/drivers/net/s2io.c --- org/drivers/net/s2io.c 2007-05-17 20:35:39.0 +0530 +++ patch_1/drivers/net/s2io.c 2007-05-17 20:35:55.0

[PATCH 2.6.22 4/4]S2IO: Implementing review comments from old patches

2007-06-19 Thread Veena Parat
Implementation of review comments 1. Incorporated Jeff Garzik's comments on coding standards. 2. Incorporated Andreas Schwab's comments on redundant condition check. Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -urpN patch_3/drivers/net/s2io.c patch_4/drivers/net/s2io.c --- patch_3/dri

Re: [RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-19 Thread Keiichi KII
Hello Satyam, *ugh*. I was wondering what a show-stopper this particular patch was -- introduces a couple of ioctl()'s, exports a new structure to userspace, adds a hitherto-unneeded header file, brings in tty_struct/tty_operations and ends up adding so much complexity/ bloat to netconsole.c. No

Re: [RFC][PATCH -mm take5 4/7] using symlink for the net_device

2007-06-19 Thread Keiichi KII
Hello Satyam, and this is why we have to use the dual-list mechanism to react to the net device rename. This isn't so obvious, a comment at the point where you declare modify_target_list would be nice? (BTW temporary_list would be a better name for that, IMO) All right, my patches are short of

Re: [RFC][PATCH -mm take5 4/7] using symlink for the net_device

2007-06-19 Thread Keiichi KII
Hello Satyam, Sorry, but we're not covering from the error condition fully here. Note that later you merge the temporary modify_target_list entirely back into the target_list ... which would still contain these erroneous nodes. A full cleanup (kobject_unregister the entry, and then list_del from

Re: [RFC][PATCH -mm take5 3/7] add interface for netconsole using sysfs

2007-06-19 Thread Keiichi KII
Hello Satyam, First, I'm sorry I couldn't reply to your comments. I'm so appreciate for your comments. I will fix my patches following your advices. But, I have some questions on the another patches. So, I want to ask you some questions and answer your questions. +static int miscdev_configured

[PATCH 2.6.22 3/4]S2IO: Removing 3 buffer mode support from the driver

2007-06-19 Thread Veena Parat
Removed 3 buffer mode support from driver - unused feature Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -urpN patch_2/drivers/net/s2io.c patch_3/drivers/net/s2io.c --- patch_2/drivers/net/s2io.c 2007-05-21 15:15:11.0 +0530 +++ patch_3/drivers/net/s2io.c 2007-06-07 12:11:27.000

[PATCH] net: Make skb_seq_read unmap the last fragment

2007-06-19 Thread Olaf Kirch
From: Olaf Kirch <[EMAIL PROTECTED]> Make skb_seq_read unmap the last fragment Having walked through the entire skbuff, skb_seq_read would leave the last fragment mapped. As a consequence, the unwary caller would leak kmaps, and proceed with preempt_count off by one. The only (kind of non-intuit